Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-08-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- (Updated Aug. 9, 2016, 8:37 a.m.) Status -- This change has been

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-08-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review98219 --- Ship it! Ship It! - Martin Gräßlin On July 21, 2016,

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-07-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- (Updated July 21, 2016, 1:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-07-15 Thread Mindaugas Baranauskas
> On Nov. 22, 2015, 1:24 p.m., Alex Merry wrote: > > Ship It! > > Mindaugas Baranauskas wrote: > Seems that with this patch KDE Plasma crash more often: > https://bugs.kde.org/show_bug.cgi?id=357895#c22 > > David Edmundson wrote: > @Mindaugas > > Can you try this patch now

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread David Edmundson
> On Nov. 23, 2015, 7:13 a.m., Martin Gräßlin wrote: > > are you sure it means that? I mean I did read the documentation when > > writing that code and did deliberately wrote the code like that. So I'm a > > little bit surprised that I got it exactly the other way around. How do you

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread Martin Gräßlin
> On Nov. 23, 2015, 8:13 a.m., Martin Gräßlin wrote: > > are you sure it means that? I mean I did read the documentation when > > writing that code and did deliberately wrote the code like that. So I'm a > > little bit surprised that I got it exactly the other way around. > > David Edmundson

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread David Edmundson
> On Nov. 23, 2015, 7:13 a.m., Martin Gräßlin wrote: > > are you sure it means that? I mean I did read the documentation when > > writing that code and did deliberately wrote the code like that. So I'm a > > little bit surprised that I got it exactly the other way around. > > David Edmundson

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88703 --- are you sure it means that? I mean I did read the

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-22 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88705 --- Deleting a texture twice is legal in OpenGL, since unused

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88691 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 1:57

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- (Updated Nov. 22, 2015, 1:57 a.m.) Review request for KDE Frameworks and

Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- Review request for KDE Frameworks and Plasma. Repository: