Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-27 Thread Luigi Toscano
//git.reviewboard.kde.org/r/115209/ > --- > > (Updated Jan. 22, 2014, 3:12 p.m.) > > > Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > &g

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-26 Thread Kevin Ottens
org/r/115209/ > --- > > (Updated Jan. 22, 2014, 3:12 p.m.) > > > Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Two separate commit

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-22 Thread Alexander Richardson
Frameworks, kdewin, and Luigi Toscano. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-22 Thread Luigi Toscano
tation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > Two separate commits: > > --- > > Print a message when a file is not found > > This way meinproc no longer fails silen

Review Request 115209: Fix KDoctools build on Windows

2014-01-21 Thread Alexander Richardson
. Repository: kdoctools Description --- Two separate commits: --- Print a message when a file is not found This way meinproc no longer fails silently -- Allow compiling on Windows with MSVC Diffs - CMakeLists.txt

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-21 Thread Commit Hook
rd.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 4:48 p.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett > Clark. > > > Repository: kdoctools > > > Descriptio

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-21 Thread Jonathan Riddell
marked as submitted. Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs - CMakeLists.txt 74c7af5

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-19 Thread Luigi Toscano
> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 4:48 p.m.) > > > Review r

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-19 Thread David Faure
ewboard.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 4:48 p.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett > Clark. > > > Repository: kdoctools > > > Description > --- > > Rename man

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-19 Thread David Faure
gt; This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 4:48 p.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett > Clark. > > > Reposit

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-18 Thread Luigi Toscano
-- > > (Updated Jan. 17, 2014, 4:48 p.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett > Clark. > > > Repository: kdoctools > > > Description > --- > > Rename man pages and checkXML tool to p

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Jonathan Riddell
Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs (updated) - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
n automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 3:30 a.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett &g

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
n automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 3:30 a.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett &g

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
cally generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 3:30 a.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett &g

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Scarlett Clark
oard.kde.org/r/115065/ > --- > > (Updated Jan. 17, 2014, 3:30 a.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett > Clark. > > > Repository: kdoctools > > &

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread David Narváez
works/kdoctools/docs/checkXML5/man-checkXML.1.docbook', needed by 'docs/checkXML5/checkXML.1'. Stop. Scanning dependencies of target qt5options-manpage-man-qtoptions gmake[2]: *** No rule to make target '/home/david/Projects/Frameworks/src/frameworks/kdoctools/docs/kde5options

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-17 Thread Jonathan Riddell
, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE-CREATION

Re: Review Request 114524: Load the kdoctools macro before trying to find the build deps

2013-12-28 Thread Christophe Giboudeaux
discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- Tiny fix for kdoctools. While trying to build the split frameworks, the ones calling kdoctools were failing because find_dependency was called before including KF5DocToolsTargets.cmake. If find_dependency

Re: Review Request 114524: Load the kdoctools macro before trying to find the build deps

2013-12-28 Thread Alex Merry
s an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114524/ > --- > > (Updated Dec. 18, 2013, 3:23 a.m.) > > > Review request for KDE Frameworks. > > > Reposito

Review Request 114524: Load the kdoctools macro before trying to find the build deps

2013-12-17 Thread Christophe Giboudeaux
--- Tiny fix for kdoctools. While trying to build the split frameworks, the ones calling kdoctools were failing because find_dependency was called before including KF5DocToolsTargets.cmake. If find_dependency is called before, the PACKAGE_PREFIX_DIR gets changed to point to the dependency

Re: kdoctools

2013-11-22 Thread David Faure
On Friday 15 November 2013 10:12:23 Treeve Jelbert wrote: > kdoctools installs files to /opt/qt5/share/ksgmltools2/customization > whereas kdelibs4 uses /opt/qt4/share/apps/ksgmltools2/customization > > is the problem due to the extra apps directory? That would be a bug, then

Re: kdoctools

2013-11-15 Thread Aleix Pol
On Fri, Nov 15, 2013 at 10:12 AM, Treeve Jelbert wrote: > I build all of kf5 as standalone modules > > kdoctools is now required when building kdewidgets, but the build fails > > FAILED: cd /usr/src/kdewidgets-5.x/build/docs/makekdewidgets && > /opt/qt5/bin/meinpro

kdoctools

2013-11-15 Thread Treeve Jelbert
I build all of kf5 as standalone modules kdoctools is now required when building kdewidgets, but the build fails FAILED: cd /usr/src/kdewidgets-5.x/build/docs/makekdewidgets && /opt/qt5/bin/meinproc5 --stylesheet /opt/qt5/share/ksgmltools2/customization/kde-include-man.xsl --check

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Aurélien Gâteau
marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs - superbuild/CMakeLists.txt

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Commit Hook
rd.kde.org/r/113328/ > --- > > (Updated Oct. 21, 2013, 1:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Fix standalone build of kdoct

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Kevin Ottens
t. 21, 2013, 1:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Fix standalone build of kdoctools: it was not looking for KArchive. This > patch also aligns the top-level CMakeLists.txt with temp

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau
> On Oct. 21, 2013, 1:43 p.m., Kevin Ottens wrote: > > tier2/kdoctools/CMakeLists.txt, line 18 > > <http://git.reviewboard.kde.org/r/113328/diff/2/?file=203416#file203416line18> > > > > FOOBAR really? :-) > > > > In fact ecm_setup_vers

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau
. Changes --- No need to call ecm_setup_version() in kdoctools, it's not a library. Repository: kdelibs Description --- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs (up

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42080 --- tier2/kdoctools/CMakeLists.txt <h

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau
. Changes --- Move find_package(KF5) Repository: kdelibs Description --- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs (updated) - superbuild/CMakeLists.txt 5cdec94

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau
> On Oct. 18, 2013, 5:23 p.m., Aleix Pol Gonzalez wrote: > > tier2/kdoctools/CMakeLists.txt, line 30 > > <http://git.reviewboard.kde.org/r/113328/diff/1/?file=203382#file203382line30> > > > > The KF5 find_package should be outside of the if Oh right, should

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review41951 --- tier2/kdoctools/CMakeLists.txt <h

Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau
--- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs - tier2/kdoctools/src/CMakeLists.txt 8b726a8 tier2/kdoctools/CMakeLists.txt 53fd0e9 superbuild/CMakeLists.txt 5cdec94

Re: Making KDocTools independent of KArchive

2013-09-30 Thread T. C. Hollingsworth
Nicolás Alvarez wrote: > Maybe we can use a third-party docbook-to-manpage conversion tool. On > Linux it would be easy to install, and on Windows it wouldn't be needed > ("what's a manpage?"). And still leave it optional everywhere... Well if this is okay, you could just remove the KDE-specific D

Re: [kde-doc-english] Making KDocTools independent of KArchive

2013-09-30 Thread Luigi Toscano
Albert Astals Cid wrote: > El Diumenge, 29 de setembre de 2013, a les 12:14:49, David Faure va escriure: >> On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: >>> So we don't have a man page anymore? Debian will be happy :D >>> >>> Also we're losing the i18n-zation side of the man page,

Re: Making KDocTools independent of KArchive

2013-09-29 Thread Albert Astals Cid
El Diumenge, 29 de setembre de 2013, a les 12:14:49, David Faure va escriure: > On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: > > So we don't have a man page anymore? Debian will be happy :D > > > > Also we're losing the i18n-zation side of the man page, which the current > > -- he

Re: Making KDocTools independent of KArchive

2013-09-29 Thread David Faure
On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: > So we don't have a man page anymore? Debian will be happy :D > > Also we're losing the i18n-zation side of the man page, which the current -- > help does not have. What do non-kde projects do? Write a man page by hand and translate i

Re: Making KDocTools independent of KArchive

2013-09-27 Thread Kevin Ottens
would be easy to install, and on Windows it wouldn't be needed > > > > > ("what's > > > > > a manpage?"). And still leave it optional everywhere... > > > > > > > > Thats a very good question. Maybe in that case kdoctools is ind

Re: Making KDocTools independent of KArchive

2013-09-25 Thread Alexander Neundorf
indows it wouldn't be needed > > > > > ("what's > > > > > a manpage?"). And still leave it optional everywhere... > > > > > > > > Thats a very good question. Maybe in that case kdoctools is indeed > > > > ove

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Albert Astals Cid
quot;). And still leave it optional everywhere... > > > > > > Thats a very good question. Maybe in that case kdoctools is indeed > > > overkill. Someone would have to investigate if something else could be > > > used though. > > > > That's rea

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Sune Vuorela
> Maybe we can bundle the generated documentation? Distributions in general don't want pregenerated . /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Kevin Ottens
> > > Maybe we can bundle the generated documentation? > I think we're making it more of a problem than actually is... Maybe the > problem here is considering kdoctools as a framework instead of a tool set. That's indeed a solution. We could deal with those man pages in t

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Aleix Pol
> > > Maybe we can use a third-party docbook-to-manpage conversion tool. On > > > > Linux > > > > it would be easy to install, and on Windows it wouldn't be needed > > > > ("what's > > > > a manpage?"). And still leave it

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Kevin Ottens
ol. On > > > Linux > > > it would be easy to install, and on Windows it wouldn't be needed > > > ("what's > > > a manpage?"). And still leave it optional everywhere... > > > > Thats a very good question. Maybe in that case kdoctool

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Albert Astals Cid
it wouldn't be needed ("what's > > a manpage?"). And still leave it optional everywhere... > > Thats a very good question. Maybe in that case kdoctools is indeed overkill. > Someone would have to investigate if something else could be used though. That's rea

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Kevin Ottens
rywhere... Thats a very good question. Maybe in that case kdoctools is indeed overkill. Someone would have to investigate if something else could be used though. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Nicolás Alvarez
gt;> > Anyway as I was chatting with Aleix yesterday, kdoctools being a > > > >> > tier1 > > > >> > framework "is not enough" since kconfig has docbook files (e.g. > man > > > >> > page of kconfig_compiler) so we need a tier0 here ;

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Nicolás Alvarez
> escriure: >> > > Albert Astals Cid wrote: > > > >> > > >> > Anyway as I was chatting with Aleix yesterday, kdoctools being a >> > > >> > tier1 >> > > >> > framework "is not enough" since kconfig has

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Albert Astals Cid
hat would break? Everything that reads and writes those files is > > > in-tree. > > > > Right, i tought khelpcenter did some of the decoding, but it's done via > > meinproc too. > > > > > >> > Anyway as I was chatting with Aleix yesterday, kdo

Re: Making KDocTools independent of KArchive

2013-09-22 Thread Kevin Ottens
change it you are going to break stuff that uses it". So yes, no > > > reason. > > > > What would break? Everything that reads and writes those files is in-tree. > > Right, i tought khelpcenter did some of the decoding, but it's done via > meinproc too. &g

Re: Making KDocTools independent of KArchive

2013-09-21 Thread Albert Astals Cid
se files is in-tree. Right, i tought khelpcenter did some of the decoding, but it's done via meinproc too. > > >> > Anyway as I was chatting with Aleix yesterday, kdoctools being a tier1 > >> > framework "is not enough" since kconfig has docbook files (e.

Re: Making KDocTools independent of KArchive

2013-09-21 Thread Stephen Kelly
t it does and if > you change it you are going to break stuff that uses it". So yes, no > reason. What would break? Everything that reads and writes those files is in-tree. >> >> > Anyway as I was chatting with Aleix yesterday, kdoctools being a tier1 >> > frame

Re: Making KDocTools independent of KArchive

2013-09-21 Thread Albert Astals Cid
va > > > > > > escriure: > > >> KDocTools depends on KArchive so that it can write cache files. Those > > >> files are currently written as .bz2 files, which is why KArchive is > > >> needed. > > >> > > >> However,

Re: Making KDocTools independent of KArchive

2013-09-21 Thread Albert Astals Cid
El Dissabte, 21 de setembre de 2013, a les 10:39:22, Stephen Kelly va escriure: > Albert Astals Cid wrote: > > El Dissabte, 21 de setembre de 2013, a les 10:25:59, Stephen Kelly va > > > > escriure: > >> KDocTools depends on KArchive so that it can write cac

Re: Making KDocTools independent of KArchive

2013-09-21 Thread Stephen Kelly
Albert Astals Cid wrote: > El Dissabte, 21 de setembre de 2013, a les 10:25:59, Stephen Kelly va > escriure: >> KDocTools depends on KArchive so that it can write cache files. Those >> files are currently written as .bz2 files, which is why KArchive is >> needed. >

Re: Making KDocTools independent of KArchive

2013-09-21 Thread Albert Astals Cid
El Dissabte, 21 de setembre de 2013, a les 10:25:59, Stephen Kelly va escriure: > KDocTools depends on KArchive so that it can write cache files. Those files > are currently written as .bz2 files, which is why KArchive is needed. > > However, I can see no reason why qCompress and

Making KDocTools independent of KArchive

2013-09-21 Thread Stephen Kelly
KDocTools depends on KArchive so that it can write cache files. Those files are currently written as .bz2 files, which is why KArchive is needed. However, I can see no reason why qCompress and qUncompress would not do the job just as well. Porting to those would make KDocTools a tier1

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Commit Hook
ound. > > > Diffs > - > > cmake/modules/KDE4Macros.cmake 403679f > staging/CMakeLists.txt 7826b07 > tier2/CMakeLists.txt 6c98a7d > tier2/kdoctools/CMakeLists.txt 7e09279 > > Diff: http://git.reviewboard.kde.org/r/112795/diff/ > &

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Commit Hook
marked as submitted. Review request for KDE Frameworks. Description --- Does the move, changes a couple of things so the macros are still found. Diffs - cmake/modules/KDE4Macros.cmake 403679f staging/CMakeLists.txt 7826b07 tier2/CMakeLists.txt 6c98a7d tier2/kdoctools

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Aleix Pol Gonzalez
> On Sept. 19, 2013, 7:40 a.m., David Faure wrote: > > tier2/kdoctools/CMakeLists.txt, line 44 > > <http://git.reviewboard.kde.org/r/112795/diff/1/?file=190432#file190432line44> > > > > I'm curious, what does that do? It's where the *Config.cma

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread David Faure
done" from the wiki? tier2/kdoctools/CMakeLists.txt <http://git.reviewboard.kde.org/r/112795/#comment29758> I'm curious, what does that do? - David Faure On Sept. 18, 2013, 3:34 p.m., Aleix Pol Gonzalez wrote: > > -

Review Request 112795: Move KDocTools to tier2

2013-09-18 Thread Aleix Pol Gonzalez
, changes a couple of things so the macros are still found. Diffs - cmake/modules/KDE4Macros.cmake 403679f staging/CMakeLists.txt 7826b07 tier2/CMakeLists.txt 6c98a7d tier2/kdoctools/CMakeLists.txt 7e09279 Diff: http://git.reviewboard.kde.org/r/112795/diff/ Testing --- Builds

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-18 Thread Commit Hook
marked as submitted. Review request for KDE Frameworks and Stephen Kelly. Description --- Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt. This should make it possible to move kdoctools to its own tier. Question: At the moment, to use kdoctools from an

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-18 Thread Commit Hook
org/r/112699/ > --- > > (Updated Sept. 13, 2013, 11:15 a.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Description > --- > > Move the finders from kdoctools/CMakeLists.txt t

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-13 Thread Aleix Pol Gonzalez
> On Sept. 12, 2013, 7:57 p.m., Stephen Kelly wrote: > > > Move the finders from kdoctools/CMakeLists.txt to > > > kdoctools/src/CMakeLists.txt. > > > This should make it possible to move kdoctools to its own tier. > > > > Why is this necessary to mo

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-13 Thread Aleix Pol Gonzalez
and Stephen Kelly. Changes --- Adds the log listing the features, in case it's built separately. Description --- Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt. This should make it possible to move kdoctools to its own tier. Question: At the momen

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-12 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/#review39917 --- > Move the finders from kdoctools/CMakeLists.txt

Review Request 112699: Reorganize KDocTools cmake code

2013-09-12 Thread Aleix Pol Gonzalez
--- Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt. This should make it possible to move kdoctools to its own tier. Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake. Wouldn't it make sense to re

Re: [kdelibs/frameworks] staging/kdoctools: meinproc5.shell doesn't exist anymore since now it doesn't use kde4_add_executable

2013-09-05 Thread Aleix Pol
On Thu, Sep 5, 2013 at 6:09 PM, David Faure wrote: > On Thursday 05 September 2013 16:40:48 Stephen Kelly wrote: > > Aleix Pol wrote: > > > Git commit 25c6f2501ba077ef6f566dac3f12fc766ff5b4ab by Aleix Pol. > > > Committed on 05/09/2013 at 14:36. > > > Pushed by apol into branch 'frameworks'. > >

Re: [kdelibs/frameworks] staging/kdoctools: meinproc5.shell doesn't exist anymore since now it doesn't use kde4_add_executable

2013-09-05 Thread David Faure
On Thursday 05 September 2013 16:40:48 Stephen Kelly wrote: > Aleix Pol wrote: > > Git commit 25c6f2501ba077ef6f566dac3f12fc766ff5b4ab by Aleix Pol. > > Committed on 05/09/2013 at 14:36. > > Pushed by apol into branch 'frameworks'. > > > > meinproc5.shell doesn't exist anymore since now it doesn't

Re: Review Request 112457: Start cleanup of KDocTools

2013-09-04 Thread Commit Hook
marked as submitted. Review request for KDE Frameworks. Description --- Start using DocBook*cmake modules from ECM (pending to be solved). Properly construct strings for KDocTools, making sure QStringLiteral & friends are used. Diffs - staging/kdoctools/config-kdoctools.h.c

Re: Review Request 112457: Start cleanup of KDocTools

2013-09-04 Thread Commit Hook
org/r/112457/ > --- > > (Updated Sept. 2, 2013, 4:42 p.m.) > > > Review request for KDE Frameworks. > > > Description > --- > > Start using DocBook*cmake modules from ECM (pending to be solved). &g

Re: Review Request 112457: Start cleanup of KDocTools

2013-09-03 Thread Aleix Pol Gonzalez
> On Sept. 3, 2013, 9:30 a.m., David Faure wrote: > > staging/kdoctools/src/meinproc.cpp, line 146 > > <http://git.reviewboard.kde.org/r/112457/diff/1/?file=186392#file186392line146> > > > > I'd write exe = QStringLiteral(XMLLINT) > > instead

Re: Review Request 112457: Start cleanup of KDocTools

2013-09-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/#review39242 --- Ship it! just one thing staging/kdoctools/config

Review Request 112457: Start cleanup of KDocTools

2013-09-02 Thread Aleix Pol Gonzalez
DocBook*cmake modules from ECM (pending to be solved). Properly construct strings for KDocTools, making sure QStringLiteral & friends are used. Diffs - staging/kdoctools/config-kdoctools.h.cmake f2fe22c staging/kdoctools/src/CMakeLists.txt de82d4d staging/kdoctools

<    1   2   3   4