Re: Review Request 125615: Make phonon dependency optional

il. To reply, visit: > https://git.reviewboard.kde.org/r/125615/ > --- > > (Updated Oct. 12, 2015, 9:01 p.m.) > > > Review request for KDE Frameworks and Sune Vuorela. > > > Repository: knotifications > > > Description > --- &

Re: Policy for Dependencies

On 2015-10-13, Martin Graesslin wrote: > I'm not sure whether it's the best solution. The problem you try to fix with > it is distros breaking packaging. I agree with Martin K that this is a huge > problem and that it will happen - since the automation of packages I also > experienced that nobo

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

e.cpp (line 137) <https://git.reviewboard.kde.org/r/126105/#comment60725> if(rc == 0) return false src/engine/database.cpp (line 167) <https://git.reviewboard.kde.org/r/126105/#comment60726> if(rc == 0) return false - Sune Vuorela On Nov. 18, 2015, 7:40 p.m.

Re: kactivities

On 2011-12-05, Aaron J. Seigo wrote: > so .. if all is good with everyone, i'd like to put this on the "splitt= > ing=20 > kdelibs" epic as targeting a Tier 2 Functional Framework. Kevin: did i = > get=20 > that taxonomy correct? To me, it smells like a Solution (it has runtime components and dae

Re: examples

On 2011-12-05, Oswald Buddenhagen wrote: >> we could perhaps encourage packagers to do this, which means asking >> them about the feasibility of this. >> doesn't do much to help people on windows, though. >> > both are just a matter of what we put in our install rules. works for > qt, after all -

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. > > Pino Toscano wrote: > No I don't :-/ I remember it was just removing indexes with associated >

Releasing prison with next frameworks

Hi peoples After a final round of api changes in libprison, I think it is just a version number bump away from being release d with next round of framework releases, and thus going from the previous kdesupport area and into a real framework. What are the exact steps needed? /Sune __

Review Request 128233: Don't trust files claiming to be created on unix more than other files

iff: https://git.reviewboard.kde.org/r/128233/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128237: add failing unit test likely showing off bug 232843

easily be recreated Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Is it able to make kservice's weightedOffers public access?

On 2016-06-28, Leslie Zhai wrote: > Hi KDE developers, > > It might needs to use static KServiceTypeTrader::weightedOffers(const > QString &serviceType) to get KServiceOfferList offers, for example, I'll let David Faure (kservice maintainer) to comment on if this makes sense or not. But if it d

Re: Review Request 128237: add failing unit test likely showing off bug 232843

tps://git.reviewboard.kde.org/r/128237/#comment65564> Will add a bug number - Sune Vuorela On June 18, 2016, 2:21 p.m., Sune Vuorela wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 128237: add failing unit test likely showing off bug 232843

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit c75a82d1645062c33fc62c6a7b719ba0202d80d5 by Sune Vuorela to branch master. Repository: karchive Description --- Create unit test with expected failure to likely handle bug

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

mkdir out > > cd out > > unzip ../*zip Ok. I might also be adding that as a unit test. - Sune ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128233/#review97019 -

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

-- autotests/data/unusual_but_valid_364071.zip PRE-CREATION autotests/karchivetest.h 5a6375c autotests/karchivetest.cpp dd03dac src/kzip.cpp e7e8477 Diff: https://git.reviewboard.kde.org/r/128233/diff/ Testing --- Thanks, Sune Vuorela

Review Request 128353: Unit tests of directory permissions in zip files

Description --- Add unit test to prevent later changes to abandon directory permissions in zip files Diffs - autotests/karchivetest.h 5a6375c autotests/karchivetest.cpp dd03dac Diff: https://git.reviewboard.kde.org/r/128353/diff/ Testing --- Thanks, Sune Vuorela

Re: Review Request 128353: Unit tests of directory permissions in zip files

my.zip 7* Diffs - autotests/karchivetest.h 5a6375c autotests/karchivetest.cpp dd03dac Diff: https://git.reviewboard.kde.org/r/128353/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 128353: Unit tests of directory permissions in zip files

Previous unit test does the same - Sune --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/#review97066 ------- On

Re: Review Request 128353: Unit tests of directory permissions in zip files

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit dda62267aab8893db0ff695391d0fd8b37ace1f6 by Sune Vuorela to branch master. Repository: karchive Description --- Add unit test to prevent later changes to abandon directory

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit b7d8fce0a7167f4cea7127c6142ea10c92ff546d by Sune Vuorela to branch master. Repository: karchive Description --- Don't trust files claiming to be created on unix more than

Re: Review Request 128420: Name supported platforms in YAML file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128420/#review97259 --- Ship it! Ship It! - Sune Vuorela On July 10, 2016, 10

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97467 --- looks good. - Sune Vuorela On July 16, 2016, 12:52 a.m

Re: Review Request 128464: Allow scrolling in config windows for small screens

> On July 16, 2016, 1:06 a.m., Olivier Churlaud wrote: > > Same patch should be applied to Konversation. I think you need to submit i to konversation as well, then. - Sune --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128464: Allow scrolling in config windows for small screens

> On July 16, 2016, 9:53 a.m., Sune Vuorela wrote: > > looks good. > > Olivier Churlaud wrote: > Who should provide the ship it flag? I don't know who is the maintainer... if no one else gives a more formal shipit by monday, consider

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

could reproduce the issue. But my test didn't pass when I added this changeset. Maybe I should publish my test case somewhere... - Sune Vuorela On July 8, 2016, 2:58 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote: > > I tried writing a small test for it, and it seemed like I could reproduce > > the issue. But my test didn't pass when I added this changeset. > > > > Maybe I should publish my test case somewhere... h

Review Request 128513: Unittest for content test of kdescendantsproxymodel

PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128513/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128513: Unittest for content test of kdescendantsproxymodel

marked as submitted. Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, and Stephen Kelly. Changes --- Submitted with commit 3244f2ff34959f3e5c0a2c864a08737f47f96922 by Sune Vuorela to branch master. Repository: kitemmodels Description --- A skipped unit

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review97915 --- Ship it! Ship It! - Sune Vuorela On July 24, 2016, 9

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

nience helpers just seems ... candidates for extreme growth. isPlatformSurfaceFlinger isPlatformWindows isPlatformWindowsRT isPlatformMacOsForWatch isPlatformMacOsForTV isPlatform Do we need them? - Sune Vuorela On Aug. 1, 2016, 3:27 p.m., Martin Gräßlin wrote: > > --

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

r him to look over his comments as well, but besides that, I'd say shipit. - Sune Vuorela On Aug. 2, 2016, 5:47 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Review Request 128810: Documentation update

--- Apparantly the class name was changed at some point, and not all docs was updated. Diffs - src/kbreadcrumbselectionmodel.h 8e8fd60 Diff: https://git.reviewboard.kde.org/r/128810/diff/ Testing --- Thanks, Sune Vuorela

Review Request 128811: Unit tests of seperator handling - and proper emission of signals

--- Thanks, Sune Vuorela

Re: Review Request 128811: Unit tests of seperator handling - and proper emission of signals

marked as submitted. Review request for KDE Frameworks, David Faure and Stephen Kelly. Changes --- Submitted with commit 35bad64f2e19b66c699c56b9bc2f0b675920dd74 by Sune Vuorela to branch master. Repository: kitemmodels Description --- Verify that correct signals are emitted when

Re: Review Request 128810: Documentation update

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0496fe68640b19ac568ceabc85a75c1b2fb5ca44 by Sune Vuorela to branch master. Repository: kitemmodels Description --- Apparantly the class name was changed at some point, and not all docs was

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

problems in changing the data types from a binary compatibility point of view. - Sune Vuorela On Sept. 11, 2016, 10:57 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead

ever possible. It would be an easy bug to reintroduce. - Sune Vuorela On Sept. 11, 2016, 11:49 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128904/#review99158 --- Ship it! Ship It! - Sune Vuorela On Sept. 14, 2016, 1

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

tps://git.reviewboard.kde.org/r/128916/#comment66819> Isn't a QSKIP if user is root in the beginning of the test a better approach ? - Sune Vuorela On Sept. 16, 2016, 7:17 a.m., Evgeniy Sadovnik wrote: > > --- > This is an autom

Re: Help requested with KAuth backends : OS X

On 2016-09-17, René J.V Bertin wrote: > Can someone please give me some help setting up a working Mac backend for > KAuth? I know nothing about mac, and only have a limited knowledge of KAuth, on linux, but I'll give it a go replying anyways. On linux, there is a thing called policykit. It is

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

> On Sept. 16, 2016, 4:57 p.m., Sune Vuorela wrote: > > autotests/kconfigtest.cpp, line 1376 > > <https://git.reviewboard.kde.org/r/128916/diff/4/?file=476949#file476949line1376> > > > > Isn't a QSKIP if user is root in the beginning of the test a better

Shipping prison with next frameworks version

Hi Other than asking sysadmin to move prison from kdesupport to kdeframeworks, are there other bits I'm supposed to do? I *think* I have followed the checklists. Thanks in advance. /Sune

Re: Minimum required cmake version

On 2016-12-27, Aleix Pol wrote: > Now everything makes sense, thanks! > > I confirm Q_GADGET is mentioned in cmake 3.0.0 codebase while it isn't > in 2.8.11. > +1 on changing to 3.0. As a datapoint, Debian stable has cmake 3.0 /Sune

D28030: Also expose the true minimum size to QML

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D28030 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

svuorela accepted this revision. svuorela added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcmoduleinfo.cpp:73 > +lib = pluginInfo.libraryPath(); > +keywords = > pluginInfo.property(QStringLiteral("Keywords")).toStringList(); > } At a later poin

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

svuorela added a comment. I've been looking at it for a while, and after trying to decipher the long lambdas, which might have been better as named functions, I think it is, beside Kossebau's comments, fine. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29385 To: dfa

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

svuorela accepted this revision. svuorela added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dialog.cpp:317 > const QStringList dirs = > QStandardPaths::locateAll(QStandardPaths::DataLocation, > QStringLiteral("ksettingsdialog"), QStandardPaths::Loca

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

svuorela added a comment. I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. Also, while I might be a unconventional developer, but given this is a tier 1 library, I'm often hand patching the required ECM version to a much lower versi

Re: kio-extras and the KF5/KF6 period

On 2023-05-16, Albert Astals Cid wrote: > If we're going to support a period on which we ship both Kf5 and KF6 based > applications we need to: > > Make sure kf5 and kf6 are coinstallable. > > a) release two tarballs, one for each KF > b) release one tarball that compiles both for kf5 and kf6 >

Re: kio-extras and the KF5/KF6 period

On 2023-06-20, David Redondo wrote: > Harald and I prototyped another solution to build a Qt > 5 and Qt 6 version out of the same repo and employed it on > plasma-integration: https://invent.kde.org/plasma/plasma-integration/-/ > merge_requests/91 Did I miss something or is this just branching b

Re: Breeze and ECM are incompatible for installing icons

On 2023-11-03, David Jarvie wrote: > I wanted to provide an icon that is visually compatible with the Breeze > theme, and Breeze doesn't supply it. Did you consider submitting it to breeze ? I have heard they don't bite that much ... /Sune

T11542: Remove KHTML

svuorela closed subtask T11539: Port Okular away from KHTML as "Resolved". TASK DETAIL https://phabricator.kde.org/T11542 To: svuorela Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, cpmontanari, ghost62, hannahk, davidre, GB_2, ahmadsamir, kp

plugins-to-plugins and mimetypes and json

Hi wise peoples During the switch to KF6, all plugins seems to now be required to use the json based plugin approach, which has quite many advantages, like "data embedded into the binary and no change of getting out of sync" Unfortunately it also seems to have at least one disadvantage. How do I

Re: plugins-to-plugins and mimetypes and json

On 2024-01-05, Sune Vuorela wrote: > Or is this a feature that has just been accidentally lost and thus we > accidentally killed advanced usage of kparts ? https://invent.kde.org/frameworks/kparts/-/merge_requests/82 and https://invent.kde.org/graphics/okular/-/merge_requests/902 make

Re: KDE Frameworks with failing CI (master) (29 January 2024)

On 2024-01-29, Albert Astals Cid wrote: > Bad news: 6 repositories have started failing > > baloo: > kconfig: > kcontacts > kfilemetadata: > ki18n: > threadweaver: > * FreeBSD tests are failing I haven't studied these, and don't know if they are frequent or occasional failures. I have seen, aft

D12477: Add unit test to see that :/ files can work

svuorela created this revision. svuorela added reviewers: dfaure, kossebau, Frameworks. Restricted Application added a project: Frameworks. svuorela requested review of this revision. REVISION SUMMARY I wasn't sure if :/foo stuff would work, so I tried writing a unit test to help me. Let's subm

D14400: Fix Mixed to Upper mode latching in Aztec code generation

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D14400 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14565: Fix overflow in rounding code

svuorela created this revision. svuorela added reviewers: cfeck, safaalfulaij. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. svuorela requested review of this revision. REVISION SUMMARY qRound works with int. BUG: 397008

D14565: Fix overflow in rounding code

svuorela updated this revision to Diff 39024. svuorela added a comment. s/largevalue/largeValue/ REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14565?vs=38978&id=39024 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14565 AFFECTED FILE

D14565: Fix overflow in rounding code

svuorela added a comment. In D14565#302581 , @cfeck wrote: > In D14565#302551 , @safaalfulaij wrote: > > > Maybe you should use `largeValue` instead of `largevalue`. > > > Yes, that would be co

D14565: Fix overflow in rounding code

This revision was automatically updated to reflect the committed changes. Closed by commit R244:ea2779611800: Fix overflow in rounding code (authored by svuorela). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14565?vs=39024&id=39025 REVISION DETAIL ht

D14772: Deprecate KFilterProxySearchLine

svuorela created this revision. svuorela added reviewers: kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. svuorela requested review of this revision. REVISION SUMMARY It is too primitive and simple for anythin

D14772: Deprecate KFilterProxySearchLine

svuorela updated this revision to Diff 39579. svuorela added a comment. Improve deprecation documentation REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14772?vs=39528&id=39579 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14772 AFFEC

D14772: Deprecate KFilterProxySearchLine

This revision was automatically updated to reflect the committed changes. Closed by commit R276:f5fef035e5a2: Deprecate KFilterProxySearchLine (authored by svuorela). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14772?vs=39579&id=39580 REVISION DETAIL

D18369: Create tel: links for phone numbers

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18369 To: vkrause, svuorela Cc: apol, aacid, svuorela, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D20145: Fix RGBHandler::canRead

svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. I'm not sure why it as such is needed, but it isn't wrong. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20145 To: aacid, svuorela Cc:

D20143: ora:kra: qstrcmp -> qstrncmp

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH arcpatch-D20143 REVISION DETAIL https://phabricator.kde.org/D20143 To: aacid, svuorela Cc: apol, pino, security-team, rempt, kde-frameworks-devel, michaelh, ngraham, bru

D20149: Fix compilation

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20149 To: aacid, svuorela Cc: svuorela, apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

svuorela requested changes to this revision. svuorela added a comment. This revision now requires changes to proceed. I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name. My systems have several users named "

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

svuorela added a comment. In D20312#445122 , @ahmedbilal wrote: > > @svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there see

D20939: Aztec: Fix padding if the last partial codeword is all one bits

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D20939 To: vkrause, svuorela, nicolasfella Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20938: Add Mounts Backend

svuorela added a comment. After reading the code a bit, I wonder - can't some of the parsing code be made testable (and tests added) - This likely also requires to get rid of the global static. - rather than poll /proc/mounts every second, I was wondering if one of the filesystem no

[Differential] [Accepted] D4444: Make tier3 dependency for tests optional

svuorela accepted this revision. svuorela added a reviewer: svuorela. svuorela added a comment. This revision is now accepted and ready to land. I'm not fully sure what the scalable test does, but having tier3 libraries required for tests in tier1 thingns is a bit bad to me. REPOSITORY R266

[Differential] [Request, 177 lines] D4448: Don't use tier3 frameworks in unit tests

svuorela created this revision. svuorela added reviewers: sitter, vonreth, kde-frameworks-devel. svuorela set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Port aw

[Differential] [Closed] D4448: Don't use tier3 frameworks in unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b42483f4cbdb: Rewrite tests to not use tier3 frameworks (authored by svuorela). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4448?vs=10942&id=11351#toc REPOSITORY R266 Breeze Icons CHANGE

D8546: Add Aztec code generator

svuorela added a comment. Thanks for this contribution. I think it is good and needed. INLINE COMMENTS > CMakeLists.txt:1 > +set(aztecbarcodetest_srcs > +aztecbarcodetest.cpp I'd like an extra level of directories given the large amount of test files, so we have e.g. autotests/aztec/ wi

D8546: Add Aztec code generator

svuorela accepted this revision. svuorela added a comment. I like it. Though I haven't fully reviewed the bit magic and actually tested it, but the first can be fixed at a later point, and the latter I trust you on. INLINE COMMENTS > vkrause wrote in aztec-compact-data-0011.png:1 > There are

D8546: Add Aztec code generator

svuorela accepted this revision. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D8546 To: vkrause, #frameworks, svuorela, dfaure Cc: dfaure, #frameworks

D10432: Set minimum size on 1D barcodes as well

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D10432 To: vkrause, #frameworks, svuorela Cc: michaelh

D10603: Make DMTX dependency optional

svuorela added a comment. Thanks. The ability to cleanly do something like that was one of the reasons for the api changes I did between qt4 and qt5. INLINE COMMENTS > prison.cpp:44 > +#ifdef HAVE_DMTX > case Prison::DataMatrix: > return new DataMatrixBarcode; I'm wond

D10603: Make DMTX dependency optional

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10603 To: vkrause, #frameworks, svuorela Cc: michaelh

D10631: Update links to dependencies, and mark Android as officially supported

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10631 To: vkrause, svuorela Cc: #frameworks, michaelh

D10433: Add QML support for Prison

svuorela added a comment. I am a bit unsure if this is the right approach. I can still be convinced both ways. one of the big differences from prison/qt4 to prison/qt5 was that it changed from being a barcode display library to a barcode generation library, removing all means of actuall

D10433: Add QML support for Prison

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 To: vkrause, #frameworks, svuorela Cc: broulik, davidedmundson, michaelh

D10826: Introduce DocumentId class

svuorela added a comment. A quick review of some quirks and weirdnesses in c++ INLINE COMMENTS > documentid.cpp:67 > +#if(0) > +// Due to operator DeviceIdAndInode(), apparently the following > +// became obsolete. if you make operator DeviceIdAndInode explicit, you probably end up with a bi

D10826: Introduce DocumentId class

svuorela added inline comments. INLINE COMMENTS > anthonyfieroni wrote in documentid.h:51-52 > Make a d poniter in exported class. it depends on why it is exported. If it is exported just for unit test (and the header file not installed), then we don't need to have the mental and code wise ove

D14896: Fix bzip main page

svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. yesplease. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D14896 To: ltoscano, svuorela Cc: svuorela, kde-frameworks-devel, michaelh, ngraham

D14529: Android: Make sure Qm translations get loaded

svuorela added a comment. In D14529#302624 , @aacid wrote: > Ok, second option, we are actually installing these files ourselves, right? It is where androiddeployqt puts things (I guess to avoid conflict with javastuff) REPOSITORY R240

D15364: Plasma style: Remove hardcoded textFormat

svuorela added a comment. I think it is undesireable to change the default, because all users are now used to having it PlainText, so they are now dumping things-that-looks-like-html into it and expecting it to be plaintext. so all users of Label that don't have textFormat set now needs

D15511: Add support for Code 128 barcodes

svuorela added inline comments. INLINE COMMENTS > CMakeLists.txt:26 > +) > +# qt5_add_resources(aztecbarcodetest_srcs aztec/aztec.qrc) > + copy/paste error ? > code128barcodetest.cpp:111 > +qDebug() << "Expected:" << output; > +} > +QCOMPARE(v, output); doesn't QCOM

D15511: Add support for Code 128 barcodes

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15511 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15527: Remove assumption about the barcode aspect ratio from the QML integration

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15527 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15526: Fix rendering glitches caused by rounding errors in Code 128

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15526 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. Though unit tests would be nice. It looks like something that quite easy could break if next author is not careful. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://pha

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

svuorela added a comment. @fvogt mostly a unit test that ensures that all these 3 codepaths in slotData works. I'm not sure that the current unit tests ensures that. I might be wrong though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks,

D15614: remove usage of own TString to QString conversion function

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_extractor_string_conversion REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhn

D15615: bump required taglib version

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH bumb_taglib_version REVISION DETAIL https://phabricator.kde.org/D15615 To: astippich, mgallien, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astipp

D15704: increase test coverage of taglibwriter

svuorela added a comment. Looks good to me. A nice and simple way to drastically increase test coverage. INLINE COMMENTS > taglibwriter.cpp:22 > { > QStringList types = { > QStringLiteral("audio/mpeg"), Unrelated. but consider making this static ? REPOSITORY R286 KFileMetaD

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

svuorela added inline comments. INLINE COMMENTS > taglibwritertest.cpp:66 > +QCOMPARE(extractedGenre, QString(QStringLiteral("Genre1") + > stringSuffix)); > +QCOMPARE(extractedComment, QString(QStringLiteral("Comment1") + > stringSuffix)); > I suggest checking that the last bytes of

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

svuorela added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:66 > ? > The file/tags are written inside this test. yeah. given you write and read it, if somehow it gets encoded e.g. as iso-8859-15 rather than utf8, the euro sign would be encoded as 0xa4 rather than 0x20

D15715: remove own implementation of QString to TString conversion for taglibwriter

svuorela added a comment. In D15715#330743 , @astippich wrote: > since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right? Yes. not exported (and not d

<    1   2   3   >