---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108394/
---
(Updated Jan. 13, 2013, 5:26 p.m.)
Review request for Solid and Àlex
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108394/
---
(Updated Jan. 13, 2013, 5:29 p.m.)
Review request for Solid and Àlex
On Jan. 13, 2013, 10:51 p.m., Dan Vrátil wrote:
Good catch.
However you have to update the KScreen KCM too to match the new angles.
Check Output.qml and OutputControls.qml files. Post a separate review
please and ship them together (when you get 'ship it' on the other one)
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108394/#review25431
---
Ship it!
Ship It!
- Dan Vrátil
On Jan. 14, 2013, 1:29
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106795/#review25439
---
Ship it!
Ship It!
- Dario Freddi
On Oct. 11, 2012, 1:15
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
Review request for Solid and Dario Freddi.
Description
---
This
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106795/#review25438
---
Ship it!
In correspondance with
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25443
---
There's a couple things to fix
On Jan. 14, 2013, 1:22 p.m., Dario Freddi wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 152
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line152
Wow. Is it really a no and not a boolean from the remote interface?
Can we submit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 14, 2013, 1:52 p.m.)
Review request for Solid and Dario
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25453
---
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
On Jan. 14, 2013, 2:02 p.m., Dario Freddi wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 147
http://git.reviewboard.kde.org/r/108407/diff/2/?file=107194#file107194line147
Watch out! If you are using a QWeakPointer, this check might be bogus.
You should
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 14, 2013, 2:22 p.m.)
Review request for Solid and Dario
On Jan. 14, 2013, 1:40 p.m., Lamarque Vieira Souza wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 53
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line53
Why not use QDBusPendingCallWatcher to track when the call above
finishes
On Jan. 14, 2013, 1:43 p.m., Dario Freddi wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 151
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line151
I skipped this for any reason - I support the request for the same
reasonings
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 14, 2013, 3:24 p.m.)
Review request for Solid and Dario
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108394/#review25480
---
This review has been submitted with commit
On Jan. 14, 2013, 12:40 p.m., Lamarque Vieira Souza wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 53
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line53
Why not use QDBusPendingCallWatcher to track when the call above
finishes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25497
---
The review now looks good except the point raised by Lamarque
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25496
---
The review now looks good except the point raised by Lamarque
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25494
---
The review now looks good except the point raised by Lamarque
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108415/
---
Review request for Solid, Àlex Fiestas and Dan Vrátil.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108415/
---
(Updated Jan. 14, 2013, noon)
Review request for Solid, Àlex Fiestas and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108416/
---
Review request for Solid and Dario Freddi.
Description
---
Required
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108416/#review25530
---
Ship it!
Ship It!
- Dario Freddi
On Jan. 14, 2013, 7:50
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108395/#review25532
---
Ship it!
Ship It!
- Dan Vrátil
On Jan. 13, 2013, 8:31
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108415/#review25533
---
Ship it!
Looks good to me, please ship together with the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108415/#review25534
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108418/#review25544
---
Man, how you do this :) Check my review request posted earlier
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108418/
---
Review request for kde-workspace, Solid, Dario Freddi, and Lukáš Tinkl.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108418/#review25545
---
A similar patch has been submitted today as #108407. I'll have
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25553
---
Well, obvious this is more complete than mine, sorry for my
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25554
---
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
33 matches
Mail list logo
