Re: [Kde-hardware-devel] Review Request 121537: Remove systemd version checks

2014-12-15 Thread Kai Uwe Broulik
, suspending the session still works and now uses the Login1suspendjob here, although I don't use systemd but I do have logind. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Kde-hardware-devel] Review Request 121508: Allow turning off keyboard in dim display action

2014-12-15 Thread Kai Uwe Broulik
?! File Attachments Settings in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/14/f4650b04-42c1-4d4b-b772-710623300fa9__dimkeyboard.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware

[Kde-hardware-devel] Review Request 121506: Add setBrightnessSilent calls that don't show the OSD

2014-12-14 Thread Kai Uwe Broulik
: https://git.reviewboard.kde.org/r/121506/diff/ Testing --- The calls work as expected for both keyboard and screen, both silent and normal. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

[Kde-hardware-devel] Review Request 121508: Allow turning off keyboard in dim display action

2014-12-14 Thread Kai Uwe Broulik
Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121508: Allow turning off keyboard in dim display action

2014-12-14 Thread Kai Uwe Broulik
to have your screen dim but not your keyboard?! File Attachments Settings in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/14/f4650b04-42c1-4d4b-b772-710623300fa9__dimkeyboard.png Thanks, Kai Uwe Broulik ___ Kde

Re: [Kde-hardware-devel] Review Request 121364: Emit signal when maximum brightness changes

2014-12-08 Thread Kai Uwe Broulik
58a1b80 Diff: https://git.reviewboard.kde.org/r/121364/diff/ Testing --- I cannot really test that but the signal appears in qdbusviewer Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org

[Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2014-12-07 Thread Kai Uwe Broulik
a more precise backlight handling but I get a range of 0..10 nonetheless. Other than that seems to work exactly like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

Re: [Kde-hardware-devel] Review Request 121343: fix battery remaining time update with upower 0.99

2014-12-05 Thread Kai Uwe Broulik
and then just merge them to master. Thanks! - Kai Uwe Broulik On Dez. 5, 2014, 4:05 nachm., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121343

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Kai Uwe Broulik
-ff36777b91c6__batterykeyboardsteps.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Kai Uwe Broulik
On Dez. 5, 2014, 11:39 nachm., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery

[Kde-hardware-devel] Review Request 121364: Emit signal when maximum brightness changes

2014-12-05 Thread Kai Uwe Broulik
test that but the signal appears in qdbusviewer Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Kai Uwe Broulik
On Dez. 5, 2014, 11:39 nachm., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery

[Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
or screen brightness to test the availability. File Attachments Battery monitor with keyboard https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c00db2e1-5278-4a1b-bd32-ff36777b91c6__batterykeyboardsteps.png Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
/#review71367 --- On Dez. 4, 2014, 8:41 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355

Re: [Kde-hardware-devel] Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
On Dez. 4, 2014, 9:20 nachm., Emmanuel Pescosta wrote: dataengines/powermanagement/powermanagementengine.cpp, line 170 https://git.reviewboard.kde.org/r/121355/diff/1/?file=331906#file331906line170 You can remove the this receiver here and in other connect calls. Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121343: fix battery remaining time update with upower 0.99

2014-12-03 Thread Kai Uwe Broulik
- Kai Uwe Broulik On Dez. 4, 2014, 6:50 vorm., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121343

[Kde-hardware-devel] Review Request 121188: Use a proper ToolButton for the refresh button

2014-11-20 Thread Kai Uwe Broulik
- applet/contents/ui/Header.qml a63fa8d60d9857c489d6a01e66536ca5c0bbe5dc Diff: https://git.reviewboard.kde.org/r/121188/diff/ Testing --- Looks like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel

[Kde-hardware-devel] Review Request 120371: Round plasma-nm icon size to icon sizes

2014-09-25 Thread Kai Uwe Broulik
-4f4c-b908-850eb78ac4e4__newiconsizes1.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 120371: Round plasma-nm icon size to icon sizes

2014-09-25 Thread Kai Uwe Broulik
Fixed icon size https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/dfe1c15d-f8f2-4f4c-b908-850eb78ac4e4__newiconsizes1.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org

Re: [Kde-hardware-devel] Review Request 117538: Adjust soliddevice dataengine to API changes

2014-08-03 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/117538/diff/ Testing --- Compiles. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 119559: Brightness fixes, part 1: make all layers aware of the actual brightness value and the maximum brightness value.

2014-08-01 Thread Kai Uwe Broulik
the absolute values) and whether it will be removed from powerdevil then. - Kai Uwe Broulik On Aug. 1, 2014, 7:42 vorm., Nikita Skovoroda wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 117538: Adjust soliddevice dataengine to API changes

2014-07-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117538/#review63597 --- On April 13, 2014, 1:14 nachm., Kai Uwe Broulik wrote

Re: [Kde-hardware-devel] [Patch included] Re: OSX/MacPorts KDE CI System: Build failed for framework solid

2014-07-03 Thread Kai Uwe Broulik
Hi, That said it says not yet implemented for all the new stuff, doesn't give me much confidence in it. I hacked that thing together in the office (the only place where I have access to a Mac) to fix build. The functionality can be added at a later point, I also don't have any experience with

Re: [Kde-hardware-devel] Review Request 117339: Add timeToFull/timeToEmpty, recall notice and FullyCharged to Solid::Battery

2014-06-05 Thread Kai Uwe Broulik
Battery.recalled = false (bool) Battery.recallVendor = '' (string) Battery.recallUrl = '' (string) Battery.serial = '' (string) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

Re: [Kde-hardware-devel] Review Request 118390: Powerdevil KCM Updates

2014-05-29 Thread Kai Uwe Broulik
independent - Kai Uwe Broulik On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390

Re: [Kde-hardware-devel] Review Request 117806: [WIP] Solid device import with proper model support

2014-05-28 Thread Kai Uwe Broulik
/117806/diff/ Testing --- I tried to iron out most of the crashes and issues and that thing will definitely need a whole lot of unit tests. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

Re: [Kde-hardware-devel] Review Request 117339: Add timeToFull/timeToEmpty, recall notice and FullyCharged to Solid::Battery

2014-05-28 Thread Kai Uwe Broulik
' (string) ? same Battery.recalled = false (bool) Battery.recallVendor = '' (string) Battery.recallUrl = '' (string) Battery.serial = '' (string) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

Re: [Kde-hardware-devel] Review Request 117806: [WIP] Solid device import with proper model support

2014-04-27 Thread Kai Uwe Broulik
and that thing will definitely need a whole lot of unit tests. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 117339: Add timeToFull/timeToEmpty, recall notice and FullyCharged to Solid::Battery

2014-04-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117339/#review55056 --- Ping? - Kai Uwe Broulik On April 3, 2014, 9:46 p.m., Kai

Re: [Kde-hardware-devel] Review Request 117339: Add timeToFull/timeToEmpty, recall notice and FullyCharged to Solid::Battery

2014-04-03 Thread Kai Uwe Broulik
--- On April 2, 2014, 7:33 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117339

Re: [Kde-hardware-devel] Review Request 117339: Add timeToFull/timeToEmpty, recall notice and FullyCharged to Solid::Battery

2014-04-03 Thread Kai Uwe Broulik
On April 3, 2014, 11:23 a.m., Lukáš Tinkl wrote: While you're at it, do you think it would be worthwhile to also add the other (new) properties, like temperature? Kai Uwe Broulik wrote: Sure, saw them in dbusviewer but I didn't find them in the specs [1]. Do you know where I can

Re: [Kde-hardware-devel] Review Request 117339: Add timeToFull/timeToEmpty, recall notice and FullyCharged to Solid::Battery

2014-04-03 Thread Kai Uwe Broulik
) Battery.serial = '' (string) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 117339: Add timeToFull/timeToEmpty, recall notice and FullyCharged to Solid::Battery

2014-04-02 Thread Kai Uwe Broulik
everywhere Battery.energyRate = '9.324' (string) ? same Battery.voltage = '7.4' (string) ? same Battery.recalled = false (bool) Battery.recallVendor = '' (string) Battery.recallUrl = '' (string) Battery.serial = '' (string) Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-03-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/#review52338 --- On Feb. 15, 2014, 10:19 p.m., Kai Uwe Broulik wrote

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/115409/diff/ Testing --- Has some minor glitches, please see bugreport. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: [Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/115409/diff/ Testing --- Has some minor glitches, please see bugreport. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

[Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

2014-01-30 Thread Kai Uwe Broulik
bugreport. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 107415: [High-dpi issues] Fix BluetoothDevicesDelegate with huge fonts and icon sizes

2014-01-08 Thread Kai Uwe Broulik
as well). Since there is no 48px default size, I am using Dialog icon size (default is 32) and multiply it by 1.5 to get the 48 which matches SizeLarge. Screenshots --- Bluedevil with 200 dpi https://git.reviewboard.kde.org/r/107415/s/846/ Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 113587: Add support for x-gvfs style options in fstab

2013-11-03 Thread Kai Uwe Broulik
/fstab/fstabdevice.cpp http://git.reviewboard.kde.org/r/113587/#comment30998 Same here. solid/solid/backends/fstab/fstabdevice.cpp http://git.reviewboard.kde.org/r/113587/#comment30999 QLatin1String(network-server) ? - Kai Uwe Broulik On Nov. 3, 2013, 2:41 a.m., Stefan Brüns wrote

[Kde-hardware-devel] Review Request 111963: Turn off Battery fully charged notification by default

2013-08-09 Thread Kai Uwe Broulik
--- No Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 111719: Add stub getters for isPowerSupply and capacity in IOKit battery interface

2013-07-26 Thread Kai Uwe Broulik
. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 110384: Add isPowerSupply support to PowerDevil

2013-07-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110384/#review36517 --- On May 13, 2013, 3:38 p.m., Kai Uwe Broulik wrote

Re: [Kde-hardware-devel] Review Request 111389: Handle max_brightness == 0 (broken HW?)

2013-07-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111389/#review35584 --- Ship it! Ship It! - Kai Uwe Broulik On July 4, 2013, 11:50

[Kde-hardware-devel] [kde-workspace] powerdevil/kcmodule/profiles: Early exit battery loop. Disregard non-powersupply batteries for profile config.

2013-06-13 Thread Kai Uwe Broulik
Git commit faa8548ec43265771ceddf0fe81b3ebf98cbbc50 by Kai Uwe Broulik. Committed on 13/06/2013 at 16:12. Pushed by broulik into branch 'master'. Early exit battery loop. Disregard non-powersupply batteries for profile config. CCMAIL: kde-hardware-devel@kde.org M +5-6powerdevil

[Kde-hardware-devel] Review Request 110982: Disregard non-powersupply batteries for powerdevil

2013-06-12 Thread Kai Uwe Broulik
are consistent with what the new battery monitor tells. Diffs - powerdevil/daemon/powerdevilcore.cpp 5815092 Diff: http://git.reviewboard.kde.org/r/110982/diff/ Testing --- Nope, compiles. Looks safe though. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 110746: Bug 315017 - kded crashed while plug off the A/C

2013-06-01 Thread Kai Uwe Broulik
trying to access it. This addresses bug 315017. http://bugs.kde.org/show_bug.cgi?id=315017 Diffs (updated) - powerdevil/daemon/powerdevilpolicyagent.cpp e9d7ab3 Diff: http://git.reviewboard.kde.org/r/110746/diff/ Testing --- Compiles. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 110607: Add support for battery capacity

2013-05-23 Thread Kai Uwe Broulik
/#comment24434 Something I forgot to add with my last patch - Kai Uwe Broulik On May 23, 2013, 9:07 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

[Kde-hardware-devel] Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataengine

2013-05-23 Thread Kai Uwe Broulik
/powermanagementservice.operations 533c00a Diff: http://git.reviewboard.kde.org/r/110608/diff/ Testing --- Adjusting keyboard brightness from the battery monitor so col. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 107257: Handle unsupported actions quietly

2013-05-15 Thread Kai Uwe Broulik
On May 5, 2013, 10:36 p.m., Kai Uwe Broulik wrote: Ping? Wednesday is Feature Freeze for 4.11! - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107257/#review32113

Re: [Kde-hardware-devel] Review Request 110384: Add isPowerSupply support to PowerDevil

2013-05-13 Thread Kai Uwe Broulik
and battery monitor, I had it show two batteries (laptop battery and bluetooth mouse) and only take the laptop battery for battery percentage. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

Re: [Kde-hardware-devel] Review Request 110384: Add isPowerSupply support to PowerDevil

2013-05-13 Thread Kai Uwe Broulik
/110384/diff/ Testing --- After adjusting Plasma's powermanagement dataengine and battery monitor, I had it show two batteries (laptop battery and bluetooth mouse) and only take the laptop battery for battery percentage. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-05-11 Thread Kai Uwe Broulik
. File Attachments Battery OSD http://git.reviewboard.kde.org/media/uploaded/files/2013/02/10/batteryosd.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

Re: [Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-02-14 Thread Kai Uwe Broulik
, 10:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108894/ --- (Updated Feb. 10, 2013, 10:54 p.m

Re: [Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-02-14 Thread Kai Uwe Broulik
it - It solves a fringe case I see how it can be useful to solve a very specific usecase, but it's not a feature that should be available to the general public (after all, being able to see the battery is also only one keystroke away) Kai Uwe Broulik wrote: - the OSD

Re: [Kde-hardware-devel] Review Request 108223: use Plasma::Dialog for kmix osd

2013-02-12 Thread Kai Uwe Broulik
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/ --- (Updated Jan. 6, 2013, 11:52 p.m.) Review request for Plasma, Solid, Aaron J. Seigo, Kai Uwe Broulik, and Christian Esken. Description

[Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

2013-02-10 Thread Kai Uwe Broulik
/media/uploaded/files/2013/02/10/batteryosd.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Kai Uwe Broulik
On Jan. 7, 2013, 9:35 p.m., Kai Uwe Broulik wrote: What about KDE/4.10 branch? Ok, you merged. Never mind :-) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223

[Kde-hardware-devel] Review Request: Only add DPMS to the profile if it is supported

2012-11-28 Thread Kai Uwe Broulik
. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request: Show Battery Low notification on startup along with Broken Battery notifications so it doesn't appear before workspace is up

2012-11-28 Thread Kai Uwe Broulik
77c3f2f powerdevil/daemon/powerdevilcore.cpp 2dcdbc6 Diff: http://git.reviewboard.kde.org/r/107505/diff/ Testing --- Tested with AC unplugged, logged in, no notification, after 30 seconds in the workspace, I got a notification saying my battery is low. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request: Handle unsupported actions quietly

2012-11-27 Thread Kai Uwe Broulik
, no matter if it is supported, compiled, or otherwise doesn't work. It is being added by the profile generator on first start along with all the other default settings. This means this message will always appear if the system does not DPMS for some reason. - Kai Uwe Broulik On Nov. 21, 2012, 7:20 p.m

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-11-21 Thread Kai Uwe Broulik
On Nov. 18, 2012, 1:23 p.m., Kai Uwe Broulik wrote: Great! Now that I have tested the Keyboard brightness support patch that is on Review Board atm, I get two error messages simultaneously on startup: One for DPMS, the other for Keyboard brightness. This really needs to be fixed

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-11-08 Thread Kai Uwe Broulik
will not have effect on this? Comments? - Kai Uwe Broulik On Nov. 3, 2012, 2:46 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106863

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-11-03 Thread Kai Uwe Broulik
, though. (Dunno how to get powerdevil debug console output) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request: Emit battery low/critical notification when starting the session

2012-10-30 Thread Kai Uwe Broulik
. To reply, visit: http://git.reviewboard.kde.org/r/107117/#review21120 --- On Oct. 29, 2012, 4:13 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply

Re: [Kde-hardware-devel] Review Request: Emit battery low/critical notification when starting the session

2012-10-30 Thread Kai Uwe Broulik
. Once the desktop was up I got the notification that my battery was low. I don't know if it is good to also start the suspend timer right when the desktop comes up, though. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-10-29 Thread Kai Uwe Broulik
is configured in but the display doesn't support DPMS (e.g. qxl or vmware displays in a VM) Kai Uwe Broulik wrote: I ifdef'd out all the DPMS-related stuff but it would probably also be good to add a if (action) { if (action-isSupported()) { action-onProfileLoad

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-10-25 Thread Kai Uwe Broulik
is configured in but the display doesn't support DPMS (e.g. qxl or vmware displays in a VM) Kai Uwe Broulik wrote: I ifdef'd out all the DPMS-related stuff but it would probably also be good to add a if (action) { if (action-isSupported()) { action-onProfileLoad

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-10-24 Thread Kai Uwe Broulik
, 4:17 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106863/ --- (Updated Oct. 15, 2012, 4:17 p.m

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-10-15 Thread Kai Uwe Broulik
. To reply, visit: http://git.reviewboard.kde.org/r/106863/#review20372 --- On Oct. 15, 2012, 3:14 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-10-15 Thread Kai Uwe Broulik
to get powerdevil debug console output) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-10-15 Thread Kai Uwe Broulik
Diff: http://git.reviewboard.kde.org/r/106863/diff/ Testing --- Compiles. The previous passivepopup does not appear anymore. Did not test whether the kwarning is triggered, though. (Dunno how to get powerdevil debug console output) Thanks, Kai Uwe Broulik

[Kde-hardware-devel] Review Request: Silence Profile foo could not activate bar which is a non-existent action message

2012-10-14 Thread Kai Uwe Broulik
. Did not test whether the kwarning is triggered, though. (Dunno how to get powerdevil debug console output) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware

[Kde-hardware-devel] Review Request: Fix PowerDevil KCM On AC Power tab background missing gradient

2012-10-14 Thread Kai Uwe Broulik
. When resizing the dialog, scroll bars appear. It also works when the tabbar is hidden (when no batteries present - just saw: the battery detection code could be simplified like in the other KCM (hasBattery rather than batteryCount)). Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request: Fix PowerDevil KCM On AC Power tab background missing gradient

2012-10-14 Thread Kai Uwe Broulik
be simplified like in the other KCM (hasBattery rather than batteryCount)). Screenshots (updated) --- Proof screenshot :) http://git.reviewboard.kde.org/r/106864/s/772/ Proof screenshot :) http://git.reviewboard.kde.org/r/106864/s/773/ Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request: Fix PowerDevil KCM On AC Power tab background missing gradient

2012-10-14 Thread Kai Uwe Broulik
like in the other KCM (hasBattery rather than batteryCount)). Screenshots (updated) --- Proof screenshot :) http://git.reviewboard.kde.org/r/106864/s/772/ Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel

Re: [Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

2012-10-10 Thread Kai Uwe Broulik
of its lifecycle. Hence, the fact that batteryCount == 0 might also mean that the battery is simply unplugged, and maybe if that's the case having the fields simply disabled might make more sense. What do you think? Kai Uwe Broulik wrote: Correct me if I am wrong but I think in 90

Re: [Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

2012-10-10 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/106783/diff/ Testing --- Didn’t test whether the elements are really hidden in the real condition (Have a notebook only here, but I know that if works) but commented out the if and the elements are all properly removed. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request: Make threshold for when the battery is considered full configurable (like you can with crtiical/low)

2012-10-02 Thread Kai Uwe Broulik
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106677/#review19726 --- On Oct. 1, 2012, 10:30 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated

[Kde-hardware-devel] Review Request: Fix battery full notification not being emitted and make it watch for ChargeState rather than a charge percentage

2012-10-02 Thread Kai Uwe Broulik
: http://git.reviewboard.kde.org/r/106686/diff/ Testing --- Compiles. Did not test if notification is properly emited, will do. Just wanted to know if this is the right approach. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde

[Kde-hardware-devel] Review Request: Tidy up PowerDevil notifyrc

2012-10-02 Thread Kai Uwe Broulik
/powerdevil.notifyrc 0e9ac81 Diff: http://git.reviewboard.kde.org/r/106689/diff/ Testing --- Compiles and notification settings are much more tidy :) Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org

Re: [Kde-hardware-devel] Review Request: Tidy up PowerDevil notifyrc

2012-10-02 Thread Kai Uwe Broulik
) - powerdevil/daemon/actions/bundled/suspendsession.cpp 8369413 powerdevil/powerdevil.notifyrc 0e9ac81 Diff: http://git.reviewboard.kde.org/r/106689/diff/ Testing --- Compiles and notification settings are much more tidy :) Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request: Fix battery full notification not being emitted and make it watch for ChargeState rather than a charge percentage

2012-10-02 Thread Kai Uwe Broulik
, visit: http://git.reviewboard.kde.org/r/106686/#review19760 --- On Oct. 2, 2012, 11:21 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [Kde-hardware-devel] Review Request: Fix battery full notification not being emitted and make it watch for ChargeState rather than a charge percentage

2012-10-02 Thread Kai Uwe Broulik
. Kai Uwe Broulik wrote: I tried it again and it seems that (m_backend-acAdapterState() == BackendInterface::Plugged) is always false when this slot is triggered. Without it my new logic works fine. Dario Freddi wrote: Indeed, I am not saying your logic is wrong (apart from the comment

Re: [Kde-hardware-devel] Review Request: Fix some visual and user experience glitches in Power Management notifications

2012-10-01 Thread Kai Uwe Broulik
/ Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request: Make threshold for when the battery is considered full configurable (like you can with crtiical/low)

2012-10-01 Thread Kai Uwe Broulik
for the battery percentage? Any idea? Screenshots --- KCM with third option (ordered descending) http://git.reviewboard.kde.org/r/106677/s/751/ Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

<    1   2