Re: [Kde-hardware-devel] Review Request 128083: Find CPUs by subsystem rather than driver

> On June 6, 2016, 11:33 p.m., Rohan Garg wrote: > > Hi > > Could we get a shipit on these? I'd really appreciate it if we could have > > these in Frameworks 5.23 I don't want to disappoint you, but it's too late for 5.23 - Martin ---

Re: [Kde-hardware-devel] Review Request 128073: Make Wayland optional

reviewboard.kde.org/r/128073/#comment64993> what's the point of having setDpms method around if the implementation is ifdefed? src/doctor/doctor.cpp (lines 144 - 155) <https://git.reviewboard.kde.org/r/128073/#comment64994> same here - the method is pointless - Martin G

Re: [Kde-hardware-devel] Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with >

Re: [Kde-hardware-devel] Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with >

Re: [Kde-hardware-devel] Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with >

Re: [Kde-hardware-devel] Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with >

Re: [Kde-hardware-devel] Review Request 128073: Make Wayland optional

explanation why we don't want this. - Martin Gräßlin On June 1, 2016, 10:10 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127387/#review93639 --- Ship it! Ship It! - Martin Gräßlin On March 16, 2016

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

(line 161) <https://git.reviewboard.kde.org/r/127387/#comment63831> QStringLiteral - Martin Gräßlin On March 16, 2016, 2:54 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: [Kde-hardware-devel] Review Request 127387: Refactor the backend loading code

nt63821> const src/backendmanager.cpp (line 220) <https://git.reviewboard.kde.org/r/127387/#comment63822> nitpick: added empty new line - Martin Gräßlin On March 15, 2016, 6:57 p.m., Sebastian Kügler wrote: > > ---

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

some commented code. backends/kwayland/waylandconfig.cpp (line 203) <https://git.reviewboard.kde.org/r/126381/#comment61460> this as context object? backends/kwayland/waylandoutput.cpp (line 103) <https://git.reviewboard.kde.org/r/126381/#comment61461> this, [this] - Ma

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

l. To reply, visit: > https://git.reviewboard.kde.org/r/126381/ > --- > > (Updated Dec. 17, 2015, 7:53 p.m.) > > > Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin. > > > Repository: libkscreen >

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

landscreen.cpp (line 61) <https://git.reviewboard.kde.org/r/126381/#comment61439> that's what Bill Gates said :-P - Martin Gräßlin On Dec. 17, 2015, 7:53 p.m., Sebastian Kügler wrote: > > -

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

t.reviewboard.kde.org/r/126381/#comment61329> QStringLiteral src/backendmanager.cpp (line 205) <https://git.reviewboard.kde.org/r/126381/#comment61330> hmm? src/backendmanager.cpp (line 353) <https://git.reviewboard.kde.org/r/126381

Re: [Kde-hardware-devel] Review Request 126096: Fix memory leak in kscreen backend of libkscreen

tps://git.reviewboard.kde.org/r/126096/#comment60628> Suggestion QScopedPointer - Martin Gräßlin On Nov. 17, 2015, 4:26 p.m., Lamarque Souza wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Kde-hardware-devel] Review Request 125156: Fix brightness and animation

report would be to add an autotest for it, though. @Kai: could that be achieved? - Martin Gräßlin On Sept. 11, 2015, 12:19 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: [Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

marked as submitted. Review request for Solid and Kai Uwe Broulik. Changes --- Submitted with commit 3321b9d2c78c64e6e7c9be4f7f14cb2776bc2e71 by Martin Gräßlin to branch master. Repository: powerdevil Description --- An AbstractDpmsHelper is introduced with a concrete subclass

Re: [Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

that things somehow stopped working with 5.5. So this needs additional testing. Thanks, Martin Gräßlin ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 109693: Try to complete locking screen before suspend

it's impossible without Wayland. Nevertheless: thanks for the approach to fixing the issue. - Martin Gräßlin On March 25, 2013, 4:23 p.m., Oliver Henshaw wrote: > > --- > This is an automatically generated e-mail. To re

Re: [Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

mail. To reply, visit: https://git.reviewboard.kde.org/r/125026/#review84747 ----------- On Sept. 2, 2015, 9:12 a.m., Martin Gräßlin wrote: > > --- > This is an automa

[Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

* watched screen go off * enabled again, looked at debug output to verify it was triggered by powerdevil. It's currently only tested with Qt 5.4. At least for idle integration I had the problem that things somehow stopped working with 5.5. So this needs additional testing. Thanks, M

Re: [Kde-hardware-devel] Review Request 124388: Add ConsoleKit2 as a power backend

> On July 20, 2015, 8:22 a.m., Martin Gräßlin wrote: > > May I ask you a favor? Could you please try whether you can get > > kwin_wayland (drm/libinput) to work with consolekit2? That would be totally > > awesome! > > > > Of course I'm also interested in

Re: [Kde-hardware-devel] Review Request 124388: Add ConsoleKit2 as a power backend

s and inhibits suspend to ensure the lock screen is in place before the system goes to sleep state). - Martin Gräßlin On July 19, 2015, 11:22 a.m., Eric Koegel wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

marked as submitted. Review request for Solid and Kai Uwe Broulik. Changes --- Submitted with commit 3b56856d66f392bf18343f3b45f35da40813509f by Martin Gräßlin to branch master. Repository: powerdevil Description --- KJob::exec is dangerous and caused freezes on my system. Thus

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

://git.reviewboard.kde.org/r/123475/diff/ Testing --- kded5 no longer freezes. But I'm not sure whether the init gets finished: is there a way to easily verify whether the module loaded completely? Thanks, Martin Gräßlin ___ Kde-hardware-devel mailing list Kde-har

Re: [Kde-hardware-devel] Review Request 124318: Load DPMSAction only on xcb platform

marked as submitted. Review request for Plasma and Solid. Changes --- Submitted with commit cc89ab71b572473f84d94868fc82993073992a12 by Martin Gräßlin to branch master. Repository: powerdevil Description --- The DPMS action is implemented in a very x11 specific way calling into xcb

[Kde-hardware-devel] Review Request 124318: Load DPMSAction only on xcb platform

/124318/diff/ Testing --- No longer crashes in a Plasma/Wayland session. Thanks, Martin Gräßlin ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123999: Don't crash in XRandrBrightness if not on xcb

marked as submitted. Review request for Plasma, Solid and Kai Uwe Broulik. Changes --- Submitted with commit bb67165aa5d99e9eeea3c7f8b328b3b53a5e70a5 by Martin Gräßlin to branch master. Repository: powerdevil Description --- On e.g. platform wayland XRandrBrightness shouldn'

[Kde-hardware-devel] Review Request 123999: Don't crash in XRandrBrightness if not on xcb

org/r/123999/diff/ Testing --- kded5 no longer crashes when initializing powerdevil when running with platform wayland. Thanks, Martin Gräßlin ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinf

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/#review80178 ------- On April 24, 2015, 8:29 a.m., Martin Gräßlin wrote: > >

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

there a way to easily verify whether the module loaded completely? Thanks, Martin Gräßlin ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

I missed that one :-( - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/#review79375 --- On April 23, 2015

[Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

/powerdevilupowerbackend.cpp 87b9cc7b7db1b6a6f5b31263cd3832715c497328 Diff: https://git.reviewboard.kde.org/r/123475/diff/ Testing --- kded5 no longer freezes. But I'm not sure whether the init gets finished: is there a way to easily verify whether the module loaded completely? Thanks, Martin Gr

Re: [Kde-hardware-devel] Review Request 123418: Add X11 guards

on if we are on x11, mostly because I don't trust Qt :-P - Martin Gräßlin On April 18, 2015, 6:34 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: [Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

tps://git.reviewboard.kde.org/r/122414/#comment52126> I doubt that the two xcb_flush are needed. The XFlush seem wrong to me, too, and might only have been needed for the XSetErrorHandler calls. Please try without the xcb_flushs. - Martin Gräßlin On Feb. 3, 2015, 10:18 p.m., Kai Uwe B

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

ove the code look > (nullptr, C++ style casts, etc) welcome. Using KWin's xcbutils.h would significantly improve this. Maybe I should start thinking of how we can split that out into a dedicated repo. - Martin Gräßlin On Jan. 20, 2015, 7:44 p.m., Kai Uwe Br

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

tps://git.reviewboard.kde.org/r/121386/#comment51639> According to the commit message you still use XSync, but this is a sync implementation. Maybe split out into a helper method and use it instead of XSync? - Martin Gräßlin On Jan. 20, 2015, 7:44 p.m., Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

tps://git.reviewboard.kde.org/r/121386/#comment51599> do not use get_screen_resources: it blocks, see https://bugreports.qt.io/browse/QTBUG-40207 and https://bugs.kde.org/show_bug.cgi?id=329979#c17 - Martin Gräßlin On Jan. 19, 2015, 10:30 p.m., Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 122128: Don't listen for Login1 Lock signal anymore

;s no longer needed. - Martin Gräßlin On Jan. 18, 2015, 5:05 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: [Kde-hardware-devel] Review Request 121530: Remove lock screen on suspend

cd103c6d8da47be210b954e324bec3fc3fae5467 Diff: https://git.reviewboard.kde.org/r/121530/diff/ Testing --- it compiles. I'm not familiar enough with powerdevil to know whether this is correct. Thanks, Martin Gräßlin ___ Kde-hardware-devel ma

Re: [Kde-hardware-devel] Review Request 121857: Remove lock screen on suspend and use fade effect

On Jan. 5, 2015, 1:20 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121857/ > --- > > (Updated Jan. 5, 2015, 1:20 p.m.) > > &

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

tps://git.reviewboard.kde.org/r/121798/#comment50850> just wondering: why don't you make KWinScreenHelperEffect multiple inherit from QObject and QAbstractNativeEventFilter? overall looks good to me from X11 perspective. - Martin Gräßlin On Jan. 5, 2015, 10:27 a.m., Kai Uwe Br

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

lso verify that format is 32 daemon/kwineffect.cpp <https://git.reviewboard.kde.org/r/121798/#comment50846> the type xcb_atom_t looks wrong to me. It should just be a uint32_t IIRC - Martin Gräßlin On Jan. 3, 2015, 1:14 p.m., Kai Uwe Broulik wrote: > > --

Re: [Kde-hardware-devel] Review Request 121530: Remove lock screen on suspend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121530/#review72924 --- ping? - Martin Gräßlin On Dec. 15, 2014, 11:45 a.m

Re: [Kde-hardware-devel] Review Request 121530: Remove lock screen on suspend

e possible to query the backend in advance > > whether it supports logind and lock manually if not. > > Martin Gräßlin wrote: > or we declare lock screen on suspend as unsupported on non-logind. to add to that: there is nothing wrong with having a sufficient interface for the oth

Re: [Kde-hardware-devel] Review Request 121530: Remove lock screen on suspend

generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121530/#review72036 ----------- On Dec. 15, 2014, 11:45 a.m., Martin Gräßlin wrote: > > --- > This

[Kde-hardware-devel] Review Request 121530: Remove lock screen on suspend

/diff/ Testing --- it compiles. I'm not familiar enough with powerdevil to know whether this is correct. Thanks, Martin Gräßlin ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

ot working as it's in a helper library. You can find a sync implementation in KWin's xcbutils.h - Martin Gräßlin On Dec. 7, 2014, 10:36 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically genera

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

to cookie is as obvious as xcb_randr_foo_bar_cookie_t cookie - Martin Gräßlin On Dec. 7, 2014, 10:36 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: [Kde-hardware-devel] Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 66 > > > > > > If we don't have a config even though we correctly configured the > > backend, should not we fail? a QS

Re: [Kde-hardware-devel] Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 90 > > > > > > Q_FOREACH or instead of using Qt macros one could use what the language provides: for (const KScreen::

Re: [Kde-hardware-devel] Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > Besides the nitpits, here is a concern I have. > > > > KScreen is a library that should be used only by components of the shell > > (kwin, plasma, kscreen), the idea is to have a library that manipulates > > lowlevel stuff directly so we c