---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review27451
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Feb. 4, 2013, 4:35 p.m.)
Review request for Solid and Dario
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Feb. 4, 2013, 4:41 p.m.)
Review request for Solid and Dario
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 28, 2013, 5:45 p.m.)
Review request for Solid and Dario
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review26323
---
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 28, 2013, 9:06 p.m.)
Review request for Solid and Dario
On Jan. 17, 2013, 1:03 a.m., Dario Freddi wrote:
After a second look, there's a whole load of synchronous things in the
backend init, hence I'd waive the .waitForFinished() version to be merged,
with a huge note to self to revise that whole init routine for 4.11
(already on it).
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 22, 2013, 2:45 p.m.)
Review request for Solid and Dario
On Jan. 17, 2013, 2:03 a.m., Dario Freddi wrote:
After a second look, there's a whole load of synchronous things in the
backend init, hence I'd waive the .waitForFinished() version to be merged,
with a huge note to self to revise that whole init routine for 4.11
(already on it).
On Jan. 17, 2013, 2:03 a.m., Dario Freddi wrote:
After a second look, there's a whole load of synchronous things in the
backend init, hence I'd waive the .waitForFinished() version to be merged,
with a huge note to self to revise that whole init routine for 4.11
(already on it).
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25705
---
Ship it!
After a second look, there's a whole load of
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
Review request for Solid and Dario Freddi.
Description
---
This
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25443
---
There's a couple things to fix
On Jan. 14, 2013, 1:22 p.m., Dario Freddi wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 152
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line152
Wow. Is it really a no and not a boolean from the remote interface?
Can we submit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 14, 2013, 1:52 p.m.)
Review request for Solid and Dario
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25453
---
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
On Jan. 14, 2013, 2:02 p.m., Dario Freddi wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 147
http://git.reviewboard.kde.org/r/108407/diff/2/?file=107194#file107194line147
Watch out! If you are using a QWeakPointer, this check might be bogus.
You should
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 14, 2013, 2:22 p.m.)
Review request for Solid and Dario
On Jan. 14, 2013, 1:40 p.m., Lamarque Vieira Souza wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 53
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line53
Why not use QDBusPendingCallWatcher to track when the call above
finishes
On Jan. 14, 2013, 1:43 p.m., Dario Freddi wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 151
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line151
I skipped this for any reason - I support the request for the same
reasonings
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
---
(Updated Jan. 14, 2013, 3:24 p.m.)
Review request for Solid and Dario
On Jan. 14, 2013, 12:40 p.m., Lamarque Vieira Souza wrote:
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 53
http://git.reviewboard.kde.org/r/108407/diff/1/?file=107187#file107187line53
Why not use QDBusPendingCallWatcher to track when the call above
finishes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25497
---
The review now looks good except the point raised by Lamarque
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25496
---
The review now looks good except the point raised by Lamarque
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25494
---
The review now looks good except the point raised by Lamarque
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25553
---
Well, obvious this is more complete than mine, sorry for my
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25554
---
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
27 matches
Mail list logo
