Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread John de la Garza
On Wed, Sep 17, 2014 at 05:13:58PM +, Bruno Guedes Souto wrote: > This was a great discussion, until you guys started feeding the troll again. It seems like a lot of people here don't get it and continue to keep basically repeating themselves. ___ K

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Nick Krause
On Wed, Sep 17, 2014 at 2:15 PM, Robert P. J. Day wrote: > On Wed, 17 Sep 2014, Nick Krause wrote: > >> ... like to improve my rep with a tutor or someone who is willing to >> be my router to the community ... > > there is no sane human being that would offer to be a tutor or > mentor (a reques

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Robert P. J. Day
On Wed, 17 Sep 2014, Nick Krause wrote: > ... like to improve my rep with a tutor or someone who is willing to > be my router to the community ... there is no sane human being that would offer to be a tutor or mentor (a request you've made before) or "router" to someone who absolutely refuses

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Nick Krause
e stranger on the internet is going to be your tutor? Unless you belong to some minority, you shouldn't be waiting for a tutor to take your hand and guide you... that's probably not going to happen. Apply the advice that's been already given to you, e.g. read the old mails and write each advice dow

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Philipp Muhoray
Am 2014-09-17 19:47, schrieb Nick Krause: > On Wed, Sep 17, 2014 at 1:13 PM, Bruno Guedes Souto > wrote: >> This was a great discussion, until you guys started feeding the troll again. >> >> Can we just stop feeding the troll? He will prob go way... >> >> If every *single* time that Nick posts so

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Nick Krause
On Wed, Sep 17, 2014 at 1:13 PM, Bruno Guedes Souto wrote: > This was a great discussion, until you guys started feeding the troll again. > > Can we just stop feeding the troll? He will prob go way... > > If every *single* time that Nick posts something you reply to him it will only > lead to more

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Bruno Guedes Souto
This was a great discussion, until you guys started feeding the troll again. Can we just stop feeding the troll? He will prob go way... If every *single* time that Nick posts something you reply to him it will only lead to more replies from him saying he will get better, understand what he is

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Nick Krause
On Wed, Sep 17, 2014 at 10:39 AM, wrote: > On Wed, 17 Sep 2014 08:02:01 -0400, nick said: >> it off , if not I would like to known exactly where I am wrong so I can >> learn. > > Somebody wake me up when he actually *means* that. > Valdis, I understand that was what he stated I was looking into

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Valdis . Kletnieks
On Wed, 17 Sep 2014 08:02:01 -0400, nick said: > it off , if not I would like to known exactly where I am wrong so I can learn. Somebody wake me up when he actually *means* that. pgpep_zcvBkMR.pgp Description: PGP signature ___ Kernelnewbies mailing l

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Valdis . Kletnieks
On Wed, 17 Sep 2014 08:09:36 -0400, nick said: > On 14-09-17 08:05 AM, Greg Freemyer wrote: > > I don't know that chunk of code, but error messages that go to the kernel > > log exist for a specific reason. Taking them out requires a specific > > reason. > > > > Ie. This would make a good commi

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Greg Freemyer
On September 17, 2014 8:09:36 AM EDT, nick wrote: > > >On 14-09-17 08:05 AM, Greg Freemyer wrote: >> >> >> On September 17, 2014 7:53:24 AM EDT, nick >wrote: >>> >>> >>> On 14-09-17 07:51 AM, Sudip Mukherjee wrote: On Wed, Sep 17, 2014 at 5:08 PM, nick wrote: > > > On 14-09-

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 08:17 AM, Kai Bojens wrote: > On 17-09-14 08:09:36, nick wrote: > > [Again quoting everything] > > Please read and understand this: > > -> http://en.wikipedia.org/wiki/Posting_style#How_much_to_trim > > Your replies are unreadable to me as I don't intend to scroll down > several p

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Nick Krause
> Because in general we don't use asserts in the kernel. I'm sure I've used > 10,000s of asserts in user space over the decades. Zero in the kernel. > > Specifically, in user space when writing code we can put asserts throughout > the code that will cause an immediate code explosion if unexpecte

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Kai Bojens
On 17-09-14 08:09:36, nick wrote: [Again quoting everything] Please read and understand this: -> http://en.wikipedia.org/wiki/Posting_style#How_much_to_trim Your replies are unreadable to me as I don't intend to scroll down several pages just to read the one line you added as an answer. If you

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 08:17 AM, Chris Lee wrote: >> >> Rday, >> I meant I didn't understand the code not the effect to write good solid >> patches and learn it. >> Please read my messages more carefully. >> Nick >> >> ___ >> Kernelnewbies mailing list >> Kernelne

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Chris Lee
> > Rday, > I meant I didn't understand the code not the effect to write good solid > patches and learn it. > Please read my messages more carefully. > Nick > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbie

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 08:05 AM, Greg Freemyer wrote: > > > On September 17, 2014 7:53:24 AM EDT, nick wrote: >> >> >> On 14-09-17 07:51 AM, Sudip Mukherjee wrote: >>> On Wed, Sep 17, 2014 at 5:08 PM, nick wrote: On 14-09-17 07:20 AM, Robert P. J. Day wrote: >>> > anyway, it's time

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 08:00 AM, Robert P. J. Day wrote: > On Wed, 17 Sep 2014, Greg Freemyer wrote: > >> >> >> On September 17, 2014 7:20:42 AM EDT, "Robert P. J. Day" >> wrote: >> >>> >>> and, as we've all seen, nick's other flaw is that, quite simply, >>> he's selfish and greedy. his entire obsessio

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Greg Freemyer
On September 17, 2014 7:53:24 AM EDT, nick wrote: > > >On 14-09-17 07:51 AM, Sudip Mukherjee wrote: >> On Wed, Sep 17, 2014 at 5:08 PM, nick wrote: >>> >>> >>> On 14-09-17 07:20 AM, Robert P. J. Day wrote: >> anyway, it's time for coffee. rday >>> Rday and others, >>> Tha

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 07:56 AM, Greg Freemyer wrote: > > > On September 17, 2014 7:20:42 AM EDT, "Robert P. J. Day" > wrote: > >> >> and, as we've all seen, nick's other flaw is that, quite simply, >> he's selfish and greedy. his entire obsession is with the output of >> checkpatch, which means he wa

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Robert P. J. Day
On Wed, 17 Sep 2014, Greg Freemyer wrote: > > > On September 17, 2014 7:20:42 AM EDT, "Robert P. J. Day" > wrote: > > > > > and, as we've all seen, nick's other flaw is that, quite simply, > >he's selfish and greedy. his entire obsession is with the output of > >checkpatch, which means he want

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Greg Freemyer
On September 17, 2014 7:20:42 AM EDT, "Robert P. J. Day" wrote: > > and, as we've all seen, nick's other flaw is that, quite simply, >he's selfish and greedy. his entire obsession is with the output of >checkpatch, which means he wants to grab all the trivial cleanup (the >low-hanging fruit,

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 07:53 AM, Robert P. J. Day wrote: > > what did i say? what did i just say? i wrote: > > On Wed, 17 Sep 2014, nick wrote: >> On 14-09-17 07:20 AM, Robert P. J. Day wrote: >>> >>> and, as we've all seen, nick's other flaw is that, quite simply, >>> he's selfish and greedy. his ent

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Robert P. J. Day
what did i say? what did i just say? i wrote: On Wed, 17 Sep 2014, nick wrote: > On 14-09-17 07:20 AM, Robert P. J. Day wrote: > > > > and, as we've all seen, nick's other flaw is that, quite simply, > > he's selfish and greedy. his entire obsession is with the output > > of checkpatch, which

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 07:51 AM, Sudip Mukherjee wrote: > On Wed, Sep 17, 2014 at 5:08 PM, nick wrote: >> >> >> On 14-09-17 07:20 AM, Robert P. J. Day wrote: > >>> anyway, it's time for coffee. >>> >>> rday >>> >> Rday and others, >> That's not what I wanted I was trying to improve my rep after getting

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Sudip Mukherjee
On Wed, Sep 17, 2014 at 5:08 PM, nick wrote: > > > On 14-09-17 07:20 AM, Robert P. J. Day wrote: >> anyway, it's time for coffee. >> >> rday >> > Rday and others, > That's not what I wanted I was trying to improve my rep after getting banned > from vger.org and now it seems > I can't even get

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread nick
On 14-09-17 07:20 AM, Robert P. J. Day wrote: > On Tue, 16 Sep 2014, Greg KH wrote: > >> On Tue, Sep 16, 2014 at 11:42:18PM -0400, valdis.kletni...@vt.edu wrote: >>> (And this sort of analysis is exactly *why* people need to apply their >>> brains >>> when looking at checkpatch output) >> >

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Robert P. J. Day
On Tue, 16 Sep 2014, Greg KH wrote: > On Tue, Sep 16, 2014 at 11:42:18PM -0400, valdis.kletni...@vt.edu wrote: > > (And this sort of analysis is exactly *why* people need to apply their > > brains > > when looking at checkpatch output) > > No one has ever said that they shouldn't. > > Remembe

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-17 Thread Robert P. J. Day
On Tue, 16 Sep 2014, Greg KH wrote: > On Tue, Sep 16, 2014 at 11:42:18PM -0400, valdis.kletni...@vt.edu wrote: > > (And this sort of analysis is exactly *why* people need to apply their > > brains > > when looking at checkpatch output) > > No one has ever said that they shouldn't. > > Remembe

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-16 Thread Sudip Mukherjee
On Wed, Sep 17, 2014 at 10:26 AM, Greg KH wrote: > On Tue, Sep 16, 2014 at 11:42:18PM -0400, valdis.kletni...@vt.edu wrote: >> (And this sort of analysis is exactly *why* people need to apply their brains >> when looking at checkpatch output) > > No one has ever said that they shouldn't. > > R

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-16 Thread Greg KH
On Tue, Sep 16, 2014 at 11:42:18PM -0400, valdis.kletni...@vt.edu wrote: > (And this sort of analysis is exactly *why* people need to apply their brains > when looking at checkpatch output) No one has ever said that they shouldn't. Remember, I know _lots_ of kernel developers who started with

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-16 Thread Valdis . Kletnieks
On Tue, 16 Sep 2014 20:35:35 -0500, Greg Donald said: > fs/* currently contains 96,375 errors and 22,555 warnings. [/usr/src/linux-next] find fs -type f -name '*.[ch]' | xargs cat | wc -l 1138557 96K errors seemed to be a tad high. So.. doublechecking.. [/usr/src/linux-next] for i in `find

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-16 Thread Greg Donald
On Tue, Sep 16, 2014 at 7:25 PM, Valdis Kletnieks wrote: > In general, stand-alone patches to "fix" checkpatch whining are a Bad > Idea(TM). That's just YOUR opinion. GregKH actually made a presentation to help us n00bs do exactly that: https://www.youtube.com/watch?v=LLBrBBImJt4 And he has b

Re: A quick guide to why stand-alone checkpatch patches suck...

2014-09-16 Thread Greg KH
On Tue, Sep 16, 2014 at 08:25:51PM -0400, Valdis Kletnieks wrote: > In general, stand-alone patches to "fix" checkpatch whining are a Bad > Idea(TM). And here's why checkpatch patches are a "Good Idea(TM)": - it teaches you how to set up your email client properly - it teaches you how to de

A quick guide to why stand-alone checkpatch patches suck...

2014-09-16 Thread Valdis Kletnieks
In general, stand-alone patches to "fix" checkpatch whining are a Bad Idea(TM). Here's why... First off, the type of programmer who is tempted to do checkpatch cleanup as "My First Kernel Patch" are, by and large, novices. The code in the kernel falls into one of several states of use and stabil