Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread Rene Pöschl
On 19 Sep 2017 2:05 am, "José Ignacio" wrote: Probably, contributors would need to agree to be attributed as a group when the work is embedded in a design (When the library is distributed in whole or part they should get attributed individually as the GPL requires).

[Kicad-developers] Live zone filling

2017-09-18 Thread Jon Evans
Hi all, I've been wanting to take a look at live zone filling, as it's a really useful feature that some professional EDA tools have. If zones refill in real time as you move things around, it's easy to make sure you leave enough space for your fill to succeed. I made a quick patch to pcbnew

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread José Ignacio
Probably, contributors would need to agree to be attributed as a group when the work is embedded in a design (When the library is distributed in whole or part they should get attributed individually as the GPL requires). Ownership transfer shouldn't be necessary. a CLA is a good idea anyway to

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread Oliver Walters
Huh, this looks pretty cool - https://github.com/cla-assistant/cla-assistant On Tue, Sep 19, 2017 at 9:46 AM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > PS: It would be nice to provide a simplified way for non-GPL users to >> provide attribution for the libraries without having to

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread Oliver Walters
> > PS: It would be nice to provide a simplified way for non-GPL users to > provide attribution for the libraries without having to name every single > john doe that made a symbol or footprint. If it's made simple people will > probably be more inclined to comply. What would such a thing look

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread Oliver Walters
Thanks for the links Rene. Rene also found an older reference to a discussion between Wayne and Torsten - https://www.mail-archive.com/kicad-developers@lists.launchpad.net/msg16268.html This strongly suggests that the gEDA license is the way to go. Unless I hear any very strong objections I

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread Rene Pöschl
On 19/09/17 00:59, José Ignacio wrote: The GPL with font exception is probably the better of the two, as it is the least restrictive one contributors seem to agree on Well we use this already for the 3d model lib. https://github.com/KiCad/kicad-packages3D/wiki/Model-Licencing So it would

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Kristoffer Ödmark
Thank you Tomasz! That was most likely the error, I cannot reproduce the crash after fixing so that I do not modify the existing board! I updated the branch, now bed for me! - Kristofffer On 09/18/2017 11:54 PM, Tomasz Wlostowski wrote: On 18.09.2017 22:37, Kristoffer Ödmark wrote: I have

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

2017-09-18 Thread Jon Evans
I made a quick implementation of this in my GerbView branch and it seems to work great. I'm not sure about doing it this way for pcbnew because all the items override ViewGetLayers -- do you think adding some superclass behavior to ViewGetLayers would be a good approach, or maybe there is a better

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread José Ignacio
PS: It would be nice to provide a simplified way for non-GPL users to provide attribution for the libraries without having to name every single john doe that made a symbol or footprint. If it's made simple people will probably be more inclined to comply. On Mon, Sep 18, 2017 at 5:59 PM, José

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread José Ignacio
The GPL with font exception is probably the better of the two, as it is the least restrictive one contributors seem to agree on. On Mon, Sep 18, 2017 at 5:47 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > A further issue that has cropped up twice in the last hour: Library >

Re: [Kicad-developers] [PATCH] GerbView GAL support

2017-09-18 Thread Jon Evans
While I'm waiting for review I made another small fix On Sun, Sep 17, 2017 at 9:04 PM, Jon Evans wrote: > One follow-on patch attached after I realized that a fix hadn't made its > way in. > -Jon > > On Sun, Sep 17, 2017 at 6:47 PM, Jon Evans wrote: > >>

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread Oliver Walters
A further issue that has cropped up twice in the last hour: Library licensing https://github.com/KiCad/kicad-library/issues/1259#issuecomment-330374095 https://forum.kicad.info/t/default-libraries-gpl-licencing-vs-proprietary- designs/140/8 We have been discussing this for a while in this

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Tomasz Wlostowski
On 18.09.2017 22:37, Kristoffer Ödmark wrote: > I have made almost no changes as of yet. Just trying to figure out what > causes the crash. Hi, Looking at kicad_clipboard.cpp: // only a module selected. if( aSelected.Size() == 1 && aSelected.Front()->Type() == PCB_MODULE_T ) {

Re: [Kicad-developers] [PATCH] Change default grid size to match KLC in LIBEDIT

2017-09-18 Thread Oliver Walters
100mil is very coarse for elements other than pins to be placed. I think there are cases where we need to change code to match KLC but I don't think this is necessarily one of them. 50mils is easy for placing pins, just have one grid dot between each pin! Plus the grid spacing is accessible with

Re: [Kicad-developers] [PATCH] Add background color for subsheets

2017-09-18 Thread Oliver Walters
It makes more sense to me to wait then, rather than duplicating efforts on non critical features. Thanks On 19 Sep 2017 01:03, "Wayne Stambaugh" wrote: > Hey Oliver, > > I just tested your updates it seems to work OK except for the fact that > the fill color cannot be set

Re: [Kicad-developers] Questions regarding .sweet format

2017-09-18 Thread Oliver Walters
Andy, Yes this is possible. Simply add to the file (property MPN MCP2551) And then in the alias: (property MPN MCP2552) This overrides the previously defined value (think of a map) One of the rare cases where reading the specification document would have helped ;) On 19 Sep 2017 03:24,

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Kristoffer Ödmark
I have made almost no changes as of yet. Just trying to figure out what causes the crash. I noticed in pcbnew/tools/edit_tool.cpp cutToClipboard that the method does not cause a crash If i only run on of the two method calls in it. Doesnt matter which one I remove, I also noticed that the

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Tomasz Wlostowski
On 18.09.2017 21:18, Kristoffer Ödmark wrote: > I cannot reproduce the crash on copying, I can however crash it on the > Cut functionality, I am at a total loss as to why though. > > I noticed that the crash does not happen if one hides the board > ratsnest, but it will later crash when trying to

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Kristoffer Ödmark
I cannot reproduce the crash on copying, I can however crash it on the Cut functionality, I am at a total loss as to why though. I noticed that the crash does not happen if one hides the board ratsnest, but it will later crash when trying to re-enable the ratsnest. Can someone maybe help

Re: [Kicad-developers] [PATCH] Change default grid size to match KLC in LIBEDIT

2017-09-18 Thread Gaurav Juvekar
Hi, > I'm not sure I like this change. Is the 100mil grid just for pin > placement or all symbol elements such as text, polygons, etc.? Only for pin placement. Alignment of other elements is unspecified in KLC. -- Regards, Gaurav Juvekar ___

Re: [Kicad-developers] Questions regarding .sweet format

2017-09-18 Thread Andy Peters
> On Sep 18, 2017, at 6:27 AM, Wayne Stambaugh wrote: > > On 9/17/2017 2:59 AM, Oliver Walters wrote: >> Hi Wayne, others, >> >> *2. Symbol Variants* >> * >> * >> One of the pressing shortfalls in the current library scheme is that the >> footprint field is common to all

Re: [Kicad-developers] small typo - please fix

2017-09-18 Thread Wayne Stambaugh
Marco, You cannot fix the tooltips in dialogs generated by wxFormbuilder this way. The next time someone edits the dialog, your changes will be lost. I will fix tooltip using wxFormbuilder. Thanks, Wayne On 9/16/2017 3:12 PM, Marco Ciampa wrote: > diff --git

Re: [Kicad-developers] [PATCH] Improve template selector for macOS

2017-09-18 Thread Adam Wolf
Thanks Seppe. This bug has been irritating, thanks for fixing it! Adam Wolf On Mon, Sep 18, 2017 at 9:58 AM, jp charras wrote: > Le 18/09/2017 à 16:11, Seppe Stas a écrit : >> This fixes some issues with the template selector that cause it not to work >> properly on

Re: [Kicad-developers] [PATCH] Improve template selector for macOS

2017-09-18 Thread jp charras
Le 18/09/2017 à 16:11, Seppe Stas a écrit : > This fixes some issues with the template selector that cause it not to work > properly on macOS. > > The main issue is a race condition where `OnPageChange` uses > `m_notebook->GetSelection()` to get the > selected page number instead of

Re: [Kicad-developers] Questions regarding .sweet format

2017-09-18 Thread Kristoffer Ödmark
Well, that depends. If i just wanna sift through them all and get an overview of hide versus show, just searching for "visible" will make me able to read the status of them all. Anyway, these are very specific cases, but i think tokens with a state are both more extendable and more consistent

Re: [Kicad-developers] Questions regarding .sweet format

2017-09-18 Thread Wayne Stambaugh
On 9/18/2017 10:36 AM, Kristoffer Ödmark wrote: > > On 09/18/2017 03:27 PM, Wayne Stambaugh wrote: > >> It implies the text field is visible.  No token, implies not visible. >> I'm not opposed to using show/hide.  I would rather a single token than >> a token with a state (visible yes/no) which

Re: [Kicad-developers] Questions regarding .sweet format

2017-09-18 Thread Jon Evans
Having tokens with state also means you can tell if the parent doesn't have the token for some reason (i.e. maybe a new token has been added and you are migrating a file to the new format version) vs. if the parent just has the parameter set to false. On Mon, Sep 18, 2017 at 10:36 AM, Kristoffer

Re: [Kicad-developers] Questions regarding .sweet format

2017-09-18 Thread Kristoffer Ödmark
On 09/18/2017 03:27 PM, Wayne Stambaugh wrote: It implies the text field is visible. No token, implies not visible. I'm not opposed to using show/hide. I would rather a single token than a token with a state (visible yes/no) which is more verbose with no improvement in readability. I

[Kicad-developers] [PATCH] Improve template selector for macOS

2017-09-18 Thread Seppe Stas
This fixes some issues with the template selector that cause it not to work properly on macOS. The main issue is a race condition where `OnPageChange` uses `m_notebook->GetSelection()` to get the selected page number instead of `event.GetSelection()` as defined in the docs

Re: [Kicad-developers] Need testers (especially on OSX) for this patch.

2017-09-18 Thread jp charras
Le 18/09/2017 à 15:54, Jon Evans a écrit : > Hi JP, works well for me on macOS 10.12.  Arrow keys do nothing in GerbView > and move the cursor > around in footprint editor as expected. > > Thanks > Jon > Thanks. I committed the fix. > On Mon, Sep 18, 2017 at 7:08 AM, jp charras

Re: [Kicad-developers] Need testers (especially on OSX) for this patch.

2017-09-18 Thread Jon Evans
Hi JP, works well for me on macOS 10.12. Arrow keys do nothing in GerbView and move the cursor around in footprint editor as expected. Thanks Jon On Mon, Sep 18, 2017 at 7:08 AM, jp charras wrote: > Hi All, > > I am trying to fix an issue in GAL mode. > It is related to

[Kicad-developers] Simple command line interface to KiCad, seeking comments

2017-09-18 Thread Greg Smith
I have written a command string parser based on Python and postfix processing (think HP calculators or the programming language Forth). It ended up being quite useful to me. I would love some feedback! It works on the nightly version of KiCad as an ActionPlugin and is dead simple to install

Re: [Kicad-developers] Questions regarding .sweet format

2017-09-18 Thread Wayne Stambaugh
On 9/17/2017 2:59 AM, Oliver Walters wrote: > Hi Wayne, others, > > It has been a while since I have heard anything on here regarding the > .sweet format for schematic symbols.  > > I remember reading that Wayne was not wanting extra input on this, but > this was a very long time ago! > > With

Re: [Kicad-developers] KiCad Libraries (again)

2017-09-18 Thread Wayne Stambaugh
Oliver, Great work! This is really shaping up nicely. Cheers, Wayne On 9/17/2017 12:13 AM, Oliver Walters wrote: > Hugo can use external JSON data during the build step, so I've worked > out how to list the GitHub library releases directly onto the downloads > page! > > Some progress images

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Kristoffer Ödmark
Thank you! I will take a look at that PCB when I get home from work. The refill zones is probably only one of the few quirks that comes with the fact that I am piggybacking on the appendBoard function. This is the broad flow: I wrapped/inherited the real parser and redirected the

Re: [Kicad-developers] A treatise on the consistency of orientation and module.GraphicalItems vs. board.Drawings.

2017-09-18 Thread Wayne Stambaugh
This has been discussed before, particularly the text objects. I'm not opposed to these suggestions. It really is a matter of manpower to make the changes. If you choose to work on this, be very careful. There are some subtle differences between TEXTE_PCB and TEXTE_MODULE that can get you into

Re: [Kicad-developers] [PATCH] More aggressive sheet-selection

2017-09-18 Thread Maciej Sumiński
Kristoffer, I sincerely apologize for the delay. Finally I have managed to review and commit the patches. Thank you very much for your contribution. Regards, Orson On 09/04/2017 10:01 AM, Kristoffer Ödmark wrote: > I beleive the two latest patches will benefit most people. the automatic >

[Kicad-developers] Need testers (especially on OSX) for this patch.

2017-09-18 Thread jp charras
Hi All, I am trying to fix an issue in GAL mode. It is related to "special keys": ARROW keys PAGE UP and PAGE DOWN that have a special behavior: if not explicitly used in the a scrolled frame, they have a predefined action: scroll the frame. Until now these keys (managed by a wxEVENT_CHAR_HOOK)

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Kristoffer Ödmark
Hmm, I cannot manage to reproduce the crash. The things you are testing on, is the components pasted in using an earlier version? On 09/18/2017 11:19 AM, Tomasz Wlostowski wrote: On 18.09.2017 00:32, Kristoffer Ödmark wrote: That being said, I dont like the way the ref.pt is set now either,

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-18 Thread Tomasz Wlostowski
On 18.09.2017 00:32, Kristoffer Ödmark wrote: > That being said, I dont like the way the ref.pt is set now either, which > is not at all. Personally I would like have the components added at the > point of the cursor, but I also believe having a copy functionality that > is not perfect as of now

Re: [Kicad-developers] [PATCH] Select via sizes from design rules

2017-09-18 Thread Maciej Sumiński
Mathias, I have committed your patch, as it nicely complements the track width dropdown list patch. Thank you for your contribution. Regards, Orson On 09/04/2017 10:18 PM, Mathias Grimmberger wrote: > > Hi Maciej, > > Maciej Sumiński writes: >> Hi Mathias, >> >> I

Re: [Kicad-developers] KiCad Janitor holidays

2017-09-18 Thread Maciej Sumiński
I am sure you have already noticed by now, but the host running the Janitor is back again, so the "Fixes" commit messages should mark bug reports as fixed. Regards, Orson On 09/05/2017 09:46 AM, Maciej Sumiński wrote: > Just to let you know, the host that runs KiCad Janitor (the guy who > marks

Re: [Kicad-developers] [PATCH] Field editor buttons

2017-09-18 Thread Fabrizio Tappero
Hi Oliver, hups, sorry my bad. Please forget what I said ;-) cheers Fabrizio On Fri, Sep 15, 2017 at 11:35 PM, Oliver Walters wrote: > Hi Fabrizio, > > The icons I used were already in the bitmap_src directory, I didn't create > any new ones? Or do I