Whoops, I'll try to get the coding style right next time. Glad to be of help!
--
"Violence is the last refuge of the incompetent." - Isaac Asimov
> On May 5, 2016, at 9:35 AM, Chris Pavlina wrote:
>
> Thank you! I pushed your patch in revision 6775 with coding style fixes.
>
> On Thu, May 05,
Thank you! I pushed your patch in revision 6775 with coding style fixes.
On Thu, May 05, 2016 at 01:44:54AM -0600, Collin Anderson wrote:
> Hi, I have attached a patch that fixes an annoyance that is present in the
> footprint editor and pcbnew, but only under OS X. In either of these
> editors
On Thu, May 5, 2016 at 1:44 AM, Collin Anderson
wrote:
> I can definitely confirm that it has been an ever-present problem on OS X,
> to the point I'm in the habit of turning off my speakers as soon as I open
> pcbnew :). It's minor but annoying. It was never fixed as the patch broke
> other th
On Thu, May 5, 2016 at 1:44 AM, Collin Anderson
wrote:
> I can definitely confirm that it has been an ever-present problem on OS X,
> to the point I'm in the habit of turning off my speakers as soon as I open
> pcbnew :). It's minor but annoying. It was never fixed as the patch broke
> other th
On 5/5/2016 6:52 AM, Chris Pavlina wrote:
> Yes, please don't go interleaving preprocessor statements with fragments of
> code like that, it's ugly and very prone to causing mistakes and
> misunderstandings.
>
> #ifdef __APPLE__
> if( type != wxEVT_CHAR )
> aEvent.Skip();
> #else
> aEvent.
Yes, please don't go interleaving preprocessor statements with fragments of
code like that, it's ugly and very prone to causing mistakes and
misunderstandings.
#ifdef __APPLE__
if( type != wxEVT_CHAR )
aEvent.Skip();
#else
aEvent.Skip();
#endif
^ That is much clearer to me, it actually re
In its current state i am not a fan of this patch, as if someone comes
along and adds a line between the #ifdev and aEvent.skip() is will
break, Ideally it should probably be
#ifdef __APPLE__
if ( type != wxEVT_CHAR ) aEvent.Skip();
#else
aEvent.Skip();
#endif
the comment can still be bet
Hi, I have attached a patch that fixes an annoyance that is present in the
footprint editor and pcbnew, but only under OS X. In either of these editors,
any time a hotkey (or any key in the main edit frame) is pressed, it also
triggers OS X's error alert. This means a system alert sound is pla
8 matches
Mail list logo
