Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-05-07 Thread Łukasz Wojniłowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127559/ --- (Updated May 7, 2016, 10:33 a.m.) Status -- This change has been mar

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-18 Thread Allan Anderson
> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-17 Thread Łukasz Wojniłowicz
> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-17 Thread Allan Anderson
> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-17 Thread Cristian Oneț
> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-09 Thread aga
On 09/04/16 14:01, Łukasz Wojniłowicz wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127559/ On April 7th, 2016, 7:59 p.m. UTC, *Christian David* wrote: kmymoney/plugins/csvimport/investprocessing.cpp

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-09 Thread Łukasz Wojniłowicz
> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-08 Thread Christian David
> On April 7, 2016, 9:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-08 Thread Łukasz Wojniłowicz
> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-08 Thread Allan Anderson
> On April 7, 2016, 7:59 p.m., Christian David wrote: > > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967 > > > > > > Should become > > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", >

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-07 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127559/#review94397 --- I withdraw my last comment. I did not see that ```m_buy...```

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-07 Thread Christian David
> On April 3, 2016, 2:37 p.m., Allan Anderson wrote: > > > > Allan Anderson wrote: > We have had discussons about this in the bug report. I think you are > confusing the issue by stating your experience (using the Polish translation) > as a general issue. For me, if I delete the csvimpor

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-07 Thread Allan Anderson
> On April 3, 2016, 12:37 p.m., Allan Anderson wrote: > > > > Allan Anderson wrote: > We have had discussons about this in the bug report. I think you are > confusing the issue by stating your experience (using the Polish translation) > as a general issue. For me, if I delete the csvimpo

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-03 Thread Łukasz Wojniłowicz
> On April 3, 2016, 12:37 p.m., Allan Anderson wrote: > > > > Allan Anderson wrote: > We have had discussons about this in the bug report. I think you are > confusing the issue by stating your experience (using the Polish translation) > as a general issue. For me, if I delete the csvimpo

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-03 Thread Allan Anderson
> On April 3, 2016, 12:37 p.m., Allan Anderson wrote: > > We have had discussons about this in the bug report. I think you are confusing the issue by stating your experience (using the Polish translation) as a general issue. For me, if I delete the csvimporterrc file and then initiate loadi

Re: Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-03 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127559/#review94211 --- - Allan Anderson On April 3, 2016, 4:45 a.m., Łukasz Wojnił

Review Request 127559: BUG 360129 Do not fetch from csvimporterrc if it's empty

2016-04-02 Thread Łukasz Wojniłowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127559/ --- Review request for KMymoney. Bugs: 360129 http://bugs.kde.org/show_bu