https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
CC|martin.renvoize@ptfs-europe |
|.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Thibaud Guillot changed:
What|Removed |Added
CC||thibaud.guil...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #145 from Thibaud Guillot ---
Hello
I wake up this BZ a little :) I'm wonder if this behavior would not be fixed by
bug 33028 (and bug 21507 too) ?
--
You are receiving this mail because:
You are watching all bug chan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #146 from Victor Grousset/tuxayo ---
bug 33028 looks like to be mostly about cron and circulation rules, right?
So it's not helping for this on and it's successor, bug 21507 :(
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
mathieu saby changed:
What|Removed |Added
CC||mathsaby...@gmail.com
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Summary|Accept different monetary |Decimal separators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #79 from Victor Grousset/tuxayo ---
Created attachment 75123
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75123&action=edit
Bug 12310: Fix decimal separators issues in fines: writeoff amount field
Th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_18_05_candidate |
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
sandbo...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #74527|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #74528|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #75123|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #74529|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #81 from sandbo...@biblibre.com ---
Created attachment 75127
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75127&action=edit
Bug 12310 : Decimal separator issues: fixes in fines
The main goal is to pr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #82 from sandbo...@biblibre.com ---
Created attachment 75128
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75128&action=edit
Bug 12310 : Follow up to keep the example text in fines
This puts the examp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #83 from sandbo...@biblibre.com ---
Created attachment 75129
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75129&action=edit
Bug 12310: Follow up to prevent updatedatabase noise
Added IGNORE into the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #84 from sandbo...@biblibre.com ---
Created attachment 75130
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75130&action=edit
Bug 12310: Fix decimal separators issues in fines: writeoff amount field
Th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #85 from Koha Team Lyon 3 ---
Hello,
tested it again with different inputs (with dot, comma, symbol, names) in fines
patrons tab (maninvoice.pl, mancredit.pl, paycollect.pl) and it works, even
for Write off :)
So for me
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #87 from Victor Grousset/tuxayo ---
(In reply to Koha Team Lyon 3 from comment #85)
> When you choose to pay or to write off a fine, you arrive on paycollect.pl :
> there, the amounts are displayed with a dot.
Indeed th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #88 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #86)
> Reading: "So thousands separators come at the expense of handling both dots
> and commas."
>
> If I understand correctly, you do not kno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #89 from Marcel de Rooy ---
(In reply to Victor Grousset/tuxayo from comment #88)
> (In reply to Marcel de Rooy from comment #86)
> > Reading: "So thousands separators come at the expense of handling both dots
> > and com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #90 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #89)
> (In reply to Victor Grousset/tuxayo from comment #88)
> > That means that in the case of wanting to use thousands separators;
> > one has
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #91 from Marcel de Rooy ---
(In reply to Victor Grousset/tuxayo from comment #90)
> Hopefully not, because on the IRC and mainly during the hackfest, I have
> collected a lot of feedback.
> Which caused the proposed solut
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #92 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #91)
> > So one can use anything as a thousands sep. As long as it's not a digit a
> > minus or in the DecimalSeparators syspref.
>
> In our co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #93 from Marcel de Rooy ---
(In reply to Victor Grousset/tuxayo from comment #92)
> (In reply to Marcel de Rooy from comment #91)
> > > So one can use anything as a thousands sep. As long as it's not a digit a
> > > minus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #94 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #93)
> I could be the next QAer.. (Only glanced thru so far.)
:)
> The sentence I referred to earlier "at the expense" is somewhat unclear and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #95
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #96 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #95)
> Very brave to take this upon you !
Thanks Marcel :)
> Tiny suggestion:
> .decimal-unformating
> Fix spelling please. At least t => tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #97 from Marcel de Rooy ---
(In reply to Victor Grousset/tuxayo from comment #96)
> I followed this example:
> https://metacpan.org/pod/Number::Format#unformat_number($formatted)
OK If you feel the name is good enough, ke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #98 from Victor Grousset/tuxayo ---
Created attachment 75947
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75947&action=edit
Bug 12310: Decimal separator issues: fixes in fines
The main goal is to pre
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #100 from Victor Grousset/tuxayo ---
Created attachment 75949
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75949&action=edit
Bug 12310: (QA follow-up) Prevent updatedatabase noise
Added IGNORE into t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #99 from Victor Grousset/tuxayo ---
Created attachment 75948
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75948&action=edit
Bug 12310: (follow-up) Keep the example text in fines
This puts the example
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #103 from Victor Grousset/tuxayo ---
Created attachment 75952
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75952&action=edit
Bug 12310: (follow-up) Complete DecimalSeparators syspref description
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #102 from Victor Grousset/tuxayo ---
Created attachment 75951
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75951&action=edit
Bug 12310: (QA follow-up) Fix typo: unformating → unformatting
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #101 from Victor Grousset/tuxayo ---
Created attachment 75950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75950&action=edit
Bug 12310: (follow-up) Fix forgotten writeoff amount field
This is a follo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75129|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75128|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75130|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75127|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75947|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75948|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75952|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75949|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #108 from Victor Grousset/tuxayo ---
Created attachment 75958
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75958&action=edit
Bug 12310: (QA follow-up) Fix typo: unformating → unformatting
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75950|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75951|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Patch doesn't apply |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #111 from Marcel de Rooy ---
-- "Any of these characters can be used as a separator between integer
and decimal parts in the price fields. To work well with thousands separators
you must (usually) choose between d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marcel de Rooy changed:
What|Removed |Added
Status|In Discussion |Signed Off
--- Comment #11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #113 from Victor Grousset/tuxayo ---
Thanks Marcel for your feedback, I hope to process it in the following days.
I just came to ask this question: Should the DecimalSeparators syspref be
shared to HEA?
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #114 from Marcel de Rooy ---
(In reply to Victor Grousset/tuxayo from comment #113)
> I just came to ask this question: Should the DecimalSeparators syspref be
> shared to HEA?
Good idea
--
You are receiving this mail b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #115 from Victor Grousset/tuxayo ---
Created attachment 76896
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76896&action=edit
Bug 12310: (QA follow-up) Simplify DecimalSeparators syspref description
T
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75959|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #116 from Victor Grousset/tuxayo ---
Created attachment 76933
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76933&action=edit
Bug 12310: (follow-up) Add relevant sysprefs to HEA
DecimalSeparators: the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #117 from Victor Grousset/tuxayo ---
In HEA I've added the sysprefs next to other i18n ones. And added
CurrencyFormat as it's somewhat linked with the one introduced by this patch.
--
You are receiving this mail because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #118 from Marcel de Rooy ---
Resuming here now
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #119 from Marcel de Rooy ---
There is something strange here with git-bz.
When adding a follow-up to the test bug 6473, no problem.
When attaching to this report:
Traceback (most recent call last):
File "/usr/local/bin/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #120 from Marcel de Rooy ---
Wanted to add:
diff --git a/t/db_dependent/UsageStats.t b/t/db_dependent/UsageStats.t
index f2770f7..e4704b4 100644
--- a/t/db_dependent/UsageStats.t
+++ b/t/db_dependent/UsageStats.t
@@ -588,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #121
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #122 from Victor Grousset/tuxayo ---
Created attachment 77971
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77971&action=edit
Bug 12310: (QA follow-up) Fix typo: unformating => unformatting
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #76896|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #76933|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #75958|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #125 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #119)
> There is something strange here with git-bz.
> When adding a follow-up to the test bug 6473, no problem.
> When attaching to this repor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #126 from Victor Grousset/tuxayo ---
Created attachment 77995
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77995&action=edit
Bug 12310: (follow-up) Complete HEA tests
With the added sysprefs
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #127 from Victor Grousset/tuxayo ---
Sorry for the inconvenience. Your patch has been attached. With you as git
author if that's ok.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #77995|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #129 from Victor Grousset/tuxayo ---
I realized that your patch was in bug 6473 so I attached it here instead of my
version.
- showed the raw patch in bug 6473
- copied the text
- added an attachment here where the text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #75955|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #75956|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #75954|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #77972|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #77971|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #75957|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #78017|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
Attachment #77973|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #139 from Martin Renvoize ---
I'm afraid I agree with marcelr, I don't really like that one can enter one
thing and when it's displayed later see a different thing due to the distinct
preferences.
I also can't help but f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #140 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #121)
> The relation between CurrencyFormat and DecimalSeparators still worries me.
The only simple solution might be to keep them separated (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #141 from Victor Grousset/tuxayo ---
(In reply to Martin Renvoize from comment #139)
> I'm afraid I agree with marcelr, I don't really like that one can enter one
> thing and when it's displayed later see a different thin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #142 from Victor Grousset/tuxayo ---
> And also we might prefer focusing on getting rid of x100 or /100 of the
> amounts + decimal part truncation.
Additional note: these are regressions from the 16.11 or the 16.05
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Josef Moravec changed:
What|Removed |Added
Blocks|18723 |
Referenced Bugs:
https:/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
See Also||https://bugs.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Depends on||21507
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Failed QA |BLOCKED
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
90 matches
Mail list logo
