[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Assignee|bugzi...@warmlight.co.uk

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Caroline Cyr La Rose changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement adds |This enhancement adds

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #65 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Jonathan Druart changed: What|Removed |Added Attachment #123390|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #63 from Nick Clemens --- Slight rebase and small follow-up to record when fund is not changed upon receipt. While I would like to see fuller logging of objects these patches add more information and will help track

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #62 from Nick Clemens --- Created attachment 123391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123391=edit Bug 24190: (QA follow-up) record unchanged bookfund and fix typo Signed-off-by: Nick

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #61 from Nick Clemens --- Created attachment 123390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123390=edit Bug 24190: (follow-up) Rename AcqLog As requested in comment #49, renamed uses of AcqLog

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #60 from Nick Clemens --- Created attachment 123389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123389=edit Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #59 from Nick Clemens --- Created attachment 123388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123388=edit Bug 24190: (follow-up) Add tests In response to Jonathan's request for tests, I have now

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #58 from Nick Clemens --- Created attachment 123387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123387=edit Bug 24190: (follow-up) Respond to QA feedback This commit makes changes in response to

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #57 from Nick Clemens --- Created attachment 123386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123386=edit Bug 24190: (follow-up) Cancel order del item bug If an order is cancelled but the

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Nick Clemens changed: What|Removed |Added Attachment #122040|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116152|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #55 from Andrew Isherwood --- Created attachment 122045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122045=edit Bug 24190: (Follow-up) Rename AcqLog As requested in comment #49, renamed uses of

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116153|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116151|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116150|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116149|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116148|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #49 from Jonathan Druart --- Pref renamed AcquisitionLog on bug 23971, run % perl -p -i -e 's#AcqLog#AcquisitionLog#' **/*.t **/*.pl **/*.pm **/*.sql **/*.perl **/*.pref To apply it here. -- You are receiving this

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #48

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #47 from Andrew Isherwood --- (In reply to Nick Clemens from comment #39) > I will retest the rest once this applies Hi Nick - thanks so much for your efforts on this one! :-) I've now rebased it (having first rebased

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #112514|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #112513|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #112512|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #112511|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #112510|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #112509|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Nick Clemens changed: What|Removed |Added Status|Failed QA |Patch doesn't apply ---

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #111084|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #111083|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #37 from Andrew Isherwood --- Created attachment 112514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112514=edit Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #38 from Andrew Isherwood --- (In reply to Nick Clemens from comment #31) Hi Nick Thanks for the feedback > [..] I wonder why the scope > of information is limited for each object > if I modify a field that isn't

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #111080|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #111082|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #111081|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #30 from Katrin Fischer --- Waiting for the final QA on bug 23971. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #28

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #26 from Andrew Isherwood --- Revised reports: 1. Order line cancellations: SELECT o.ordernumber AS 'Order number', bi.title AS 'Title', bi.author AS 'Author', ba.basketname

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #25 from Andrew Isherwood --- Created attachment 111084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111084=edit Bug 24190: (follow-up) Fix erroneous tabs The QA script was reporting forbidden tabs

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #106098|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #23 from Andrew Isherwood --- Created attachment 111082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111082=edit Bug 24190: (follow-up) Respond to QA feedback This commit makes changes in response

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #24 from Andrew Isherwood --- Created attachment 111083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111083=edit Bug 24190: (follow-up) Add tests In response to Jonathan's request for tests, I have

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #106099|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #20 from Andrew Isherwood --- I gather you've spoken with Martin, I'm going to proceed with storing in JSON -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #19 from Andrew Isherwood --- Hi Jonathan - After creating the patches to use JSON rather than zero padded strings, I remembered the reason I went for zero padded strings rather than another format. Since the content of

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #18 from Andrew Isherwood --- (In reply to Jonathan Druart from comment #14) Hi Jonathan > 1. You really should avoid indentation spaces outside of the block you are > editing It was a while ago, but this was almost

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #17 from Katrin Fischer --- Please also check the comments! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #15 from Jonathan Druart --- 4. You should also consider adding tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 rkui...@roundrocktexas.gov changed: What|Removed |Added Blocks||25916

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Attachment #106097|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Attachment #106096|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Attachment #105082|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Attachment #105083|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #9 from Martin Renvoize --- Created attachment 106096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106096=edit Bug 24190: Add acquisition logging -- You are receiving this mail because: You are

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #100243|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #8 from Andrew Isherwood --- Created attachment 105083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105083=edit Bug 24190: (follow-up) Cancel order del item bug If an order is cancelled but the

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Version|18.11 |master -- You are

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Version|18.11 |master

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Martin Renvoize changed: What|Removed |Added Version|master |18.11 -- You are

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #96369|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff ---

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #4 from Andrew Isherwood --- 1. Order line cancellations: SELECT o.ordernumber AS 'Order number', bi.title AS 'Title', bi.author AS 'Author', ba.basketname AS 'Basket',

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #96364|0 |1 is obsolete|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #3 from Andrew Isherwood --- Associated reports: 1. Order line cancellations SELECT o.ordernumber AS 'Order number', ba.basketname AS 'Basket', f.budget_name AS 'Fund', CONCAT(b.firstname, ' ',

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #1 from Andrew Isherwood --- Created attachment 96364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96364=edit Bug 24190 - Add acquisition logging -- You are receiving this mail because: You are

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 24190] Add additional Acquisition logging

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Depends on||23971 Referenced Bugs: