[ANNOUNCE] kvm-74 release

2008-08-28 Thread Avi Kivity
The big changes in this release come from upstream qemu: much improved usb support. You can now have qemu automatically assign usb devices to the guest, and performance and reliability should both be improved. For ia64 users, this is the first release that supports building the kvm external modul

MADV_DONTFORK undeclared

2008-08-28 Thread Dietmar Maurer
Compiling latest version 74 give me (on debian 4.0): /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c: In function 'kvm_setup_guest_memory': /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c:821: error: 'MADV_DONTFORK' undeclared (first use in this function) /home/dietmar/pve/pve-kvm

RE: MADV_DONTFORK undeclared

2008-08-28 Thread Zhang, Xiantao
Dietmar Maurer wrote: > Compiling latest version 74 give me (on debian 4.0): > > /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c: In function > 'kvm_setup_guest_memory': > /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c:821: error: > 'MADV_DONTFORK' undeclared (first use in this fu

AW: MADV_DONTFORK undeclared

2008-08-28 Thread Dietmar Maurer
Well, I guess I need to update my kernel headers > -Ursprüngliche Nachricht- > Von: Zhang, Xiantao [mailto:[EMAIL PROTECTED] > Gesendet: Donnerstag, 28. August 2008 13:01 > An: Dietmar Maurer; kvm@vger.kernel.org > Betreff: RE: MADV_DONTFORK undeclared > > Dietmar Maurer wrote: > > Comp

RE: MADV_DONTFORK undeclared

2008-08-28 Thread Zhang, Xiantao
Dietmar Maurer wrote: > Well, I guess I need to update my kernel headers Yeah :) >> -Ursprüngliche Nachricht- >> Von: Zhang, Xiantao [mailto:[EMAIL PROTECTED] >> Gesendet: Donnerstag, 28. August 2008 13:01 >> An: Dietmar Maurer; kvm@vger.kernel.org >> Betreff: RE: MADV_DONTFORK undeclared

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devicesto guests

2008-08-28 Thread Amit Shah
* On Wednesday 27 Aug 2008 18:18:54 Ben-Ami Yassour wrote: > On Tue, 2008-08-26 at 18:29 +0300, Amit Shah wrote: > > +#define assigned_dev_ioport_read(suffix) \ > > + static uint32_t assigned_dev_ioport_read##suffix(void *opaque, uint32_t > > addr) \ + {

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devicesto guests

2008-08-28 Thread Amit Shah
* On Wednesday 27 Aug 2008 19:16:40 Muli Ben-Yehuda wrote: > On Wed, Aug 27, 2008 at 03:48:54PM +0300, Ben-Ami Yassour1 wrote: > > On Tue, 2008-08-26 at 18:29 +0300, Amit Shah wrote: > > > From: Or Sagi <[EMAIL PROTECTED]> > > > From: Nir Peleg <[EMAIL PROTECTED]> > > > From: Amit Shah <[EMAIL PROT

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests

2008-08-28 Thread Amit Shah
* On Wednesday 27 Aug 2008 19:20:26 Anthony Liguori wrote: > Hi Amit, > > Amit Shah wrote: > > With this patch, we can assign a device on the host machine to a > > guest. > > > > A new command-line option, -pcidevice is added. > > For example, to invoke it for a device sitting at PCI bus:dev.fn > >

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests

2008-08-28 Thread Amit Shah
Hello Ian, * On Wednesday 27 Aug 2008 19:50:12 Ian Jackson wrote: > Anthony Liguori writes ("Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests"): > > Where did this come from originally? It's completely different from > > what is in xen-unstable. What's in xen-unstable

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests

2008-08-28 Thread Anthony Liguori
Amit Shah wrote: * On Wednesday 27 Aug 2008 19:20:26 Anthony Liguori wrote: libkvm/libkvm-x86.c | 14 + libkvm/libkvm.h | 27 ++ qemu/Makefile.target|1 + qemu/hw/device-assignment.c | 600 +++ qemu/hw/device-assign

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests

2008-08-28 Thread Amit Shah
Hi Anthony, * On Thursday 28 Aug 2008 18:41:33 Anthony Liguori wrote: > Amit Shah wrote: > >> This patch is too big on it's on. It should be split into logical > >> parts. > > > > However, it just adds device assignment support and does nothing else. I > > don't see a way of splitting this any m

LSI SCSI: raise UDC on infinite loop

2008-08-28 Thread Marcelo Tosatti
Raise UDC (Unexpected Disconnect) when a large enough number of instructions has been executed by the SCRIPTS processor. This "solution" is much simpler than temporarily interrupting execution. This remedies the situation with Windows which downloads SCRIPTS code that busy loops on guest main mem

Re: MADV_DONTFORK undeclared

2008-08-28 Thread Marcelo Tosatti
On Thu, Aug 28, 2008 at 01:06:13PM +0200, Dietmar Maurer wrote: > Well, I guess I need to update my kernel headers > > > Dietmar Maurer wrote: > > > Compiling latest version 74 give me (on debian 4.0): > > > > > > /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c: In function > > > 'kvm_set

Re: madvise() not triggering page discard with MMU-notifiers

2008-08-28 Thread Andrea Arcangeli
On Mon, Aug 18, 2008 at 05:04:25PM -0500, Anthony Liguori wrote: > +if (!kvm_enabled() || !qemu_kvm_has_mmu_notifiers()) > +madvise(addr, TARGET_PAGE_SIZE, > +deflate ? MADV_WILLNEED : MADV_DONTNEED); The check was reversed so madvise wasn't invoked in the first place i

Re: [PATCH] KVM: SVM: fix random segfaults with NPT enabled

2008-08-28 Thread Joerg Rodel
On Wed, Aug 27, 2008 at 07:59:24PM +0300, Avi Kivity wrote: > Avi Kivity wrote: > >Joerg Rodel wrote: > >>>Meanwhile, I applied the patch, but I'm very worried about this. > >>> > >> > >>Yes, we are also worried. Another question is why this only happens with > >>NPT. The SoftMMU code should al

Re: [PATCH] KVM: SVM: fix random segfaults with NPT enabled

2008-08-28 Thread Avi Kivity
Joerg Rodel wrote: > I did a bit meditation about the softmmu code today. In the path of the > NPT fault the function kvm_mmu_free_some_pages() is called which itself > calls kvm_mmu_zap_page(). There the two functions > kvm_mmu_page_unlink_children() and kvm_mmu_unlink_parents() are called. > The

Re: [PATCH] KVM: SVM: fix random segfaults with NPT enabled

2008-08-28 Thread Joerg Roedel
On Thu, Aug 28, 2008 at 06:15:57PM +0300, Avi Kivity wrote: > Joerg Rodel wrote: > > I did a bit meditation about the softmmu code today. In the path of the > > NPT fault the function kvm_mmu_free_some_pages() is called which itself > > calls kvm_mmu_zap_page(). There the two functions > > kvm_mmu

Re: [PATCH] KVM: SVM: fix random segfaults with NPT enabled

2008-08-28 Thread Avi Kivity
Avi Kivity wrote: > Joerg Rodel wrote: > >> I did a bit meditation about the softmmu code today. In the path of the >> NPT fault the function kvm_mmu_free_some_pages() is called which itself >> calls kvm_mmu_zap_page(). There the two functions >> kvm_mmu_page_unlink_children() and kvm_mmu_unlin

Re: [PATCH] KVM: SVM: fix random segfaults with NPT enabled

2008-08-28 Thread Avi Kivity
Joerg Roedel wrote: > Ok, cool. But the bug happens only rarely so I think there is some > probability that this is the missing tlb flush, I think. But lets see. > It reproduces rapidly for me, and it did after adding the missing flush to kvm_mmu_zap_page(). -- Do not meddle in the internals

Re: [PATCH] KVM: SVM: fix random segfaults with NPT enabled

2008-08-28 Thread Joerg Roedel
On Thu, Aug 28, 2008 at 06:29:19PM +0300, Avi Kivity wrote: > Avi Kivity wrote: > > Joerg Rodel wrote: > > > >> I did a bit meditation about the softmmu code today. In the path of the > >> NPT fault the function kvm_mmu_free_some_pages() is called which itself > >> calls kvm_mmu_zap_page(). The

Re: [PATCH][RESEND] kvm: testsuite: Consolidate mov r, imm testing in one function

2008-08-28 Thread Avi Kivity
Mohammed Gamal wrote: > Consolidate mov r, imm testing in one function > > Doesn't apply, likely due to coding style fixes I made to the previous patch. > - if(!regs_equal(&inregs, &outregs, R_AX) || outregs.eax != 1234567890) > + if(!regs_equal(inregs, outregs, R_AX) || outregs->eax !

KVM: use get_user_pages_fast

2008-08-28 Thread Marcelo Tosatti
Convert gfn_to_pfn() to use get_user_pages_fast(), which can do lockless pagetable lookups. Kernel compilation on 4-way guest is 3.7% faster on VMX. Andrea, please review (especially mmu notifiers synchronization). kvm_vm_fault, used by older userspace without CAP_USER_MEMORY, had gfn_to_page op

Re: [Qemu-devel] Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests

2008-08-28 Thread Ian Jackson
Amit Shah writes ("[Qemu-devel] Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests"): > I got the xen-unstable hg tree and am looking at > tools/ioemu/pass-through.[ch] That's the old ioemu tree which is pretty much dead now. > Please point me to the code you're looking a

Re: [PATCH][RESEND] kvm: testsuite: Consolidate mov r, imm testing in one function

2008-08-28 Thread Mohammed Gamal
On Thu, Aug 28, 2008 at 7:05 PM, Avi Kivity <[EMAIL PROTECTED]> wrote: > Mohammed Gamal wrote: >> Consolidate mov r, imm testing in one function >> >> > > Doesn't apply, likely due to coding style fixes I made to the previous > patch. > >> - if(!regs_equal(&inregs, &outregs, R_AX) || outregs.ea

Re: [PATCH][RESEND] kvm: testsuite: Consolidate mov r, imm testing in one function

2008-08-28 Thread Mohammed Gamal
[Fixed coding style] Consolidate mov r, imm testing in one function Signed-off-by: Mohammed Gamal <[EMAIL PROTECTED]> --- user/test/x86/realmode.c | 49 + 1 files changed, 27 insertions(+), 22 deletions(-) diff --git a/user/test/x86/realmode.c b/use

[PATCH 1/3] Extend virtio config routines to support ballooning

2008-08-28 Thread Anthony Liguori
This patch updates the virtio device methods to provide hooks for setting and getting the config. This is needed for ballooning since the balloon driver uses config changes to signal changes in the balloon amount. We also add a method to signal that we have changed the config. Signed-off-by: Ant

[PATCH 2/3] add ballooning infrastructure to QEMU

2008-08-28 Thread Anthony Liguori
This patch adds a ballooning infrastructure to QEMU. This includes a pair of monitor commands, balloon and info balloon, to balloon a guest and to query the guest's balloon status. Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> diff --git a/qemu/balloon.h b/qemu/balloon.h new file mode 10064

[PATCH 3/3] Add virtio balloon driver (v2)

2008-08-28 Thread Anthony Liguori
This patch adds the virtio balloon driver. It doesn't actually reduce the RSS size when using KVM (although it does when using -no-kvm). This is because even with MMU notifiers, we're holding a reference to each page in the shadow page table. Once we switch to not taking a reference for pages in

Re: madvise() not triggering page discard with MMU-notifiers

2008-08-28 Thread Anthony Liguori
Andrea Arcangeli wrote: On Mon, Aug 18, 2008 at 05:04:25PM -0500, Anthony Liguori wrote: +if (!kvm_enabled() || !qemu_kvm_has_mmu_notifiers()) +madvise(addr, TARGET_PAGE_SIZE, +deflate ? MADV_WILLNEED : MADV_DONTNEED); The check was reversed so madvise wasn'

Re: [PATCH 3/3] Add virtio balloon driver (v2)

2008-08-28 Thread Anthony Liguori
Anthony Liguori wrote: This patch adds the virtio balloon driver. It doesn't actually reduce the RSS size when using KVM (although it does when using -no-kvm). This is because even with MMU notifiers, we're holding a reference to each page in the shadow page table. Once we switch to not taking

[ kvm-Bugs-2076615 ] Win2K does not boot anymore

2008-08-28 Thread SourceForge.net
Bugs item #2076615, was opened at 2008-08-26 22:04 Message generated for change (Comment added) made by markit You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2076615&group_id=180599 Please note that this message will contain a full copy of the comment th

[ kvm-Bugs-1906204 ] AMD NPT causes performance degradation

2008-08-28 Thread SourceForge.net
Bugs item #1906204, was opened at 2008-03-03 12:45 Message generated for change (Comment added) made by markit You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1906204&group_id=180599 Please note that this message will contain a full copy of the comment th

Re: [ANNOUNCE] kvm-74 release

2008-08-28 Thread Iain Paton
Hi, Given a kernel tree originally built using the O= method, what's the suggested way to build the external modules ? I've tried giving configure a --kerneldir of both the original tree and the O= tree, along with passing the O= option to make and/or configure. So far without success. qemu par

[PATCH] Fix a typo.

2008-08-28 Thread Zhang, Xiantao
>From 297fb289f827e7921ae105d3a8ff79ca4c43a03a Mon Sep 17 00:00:00 2001 From: Xiantao Zhang <[EMAIL PROTECTED]> Date: Fri, 29 Aug 2008 10:55:26 +0800 Subject: [PATCH] kvm: Qemu: Fix a typo. VGA_RAM_SIZE -> GFW_SIZE. Signed-off-by: Xiantao Zhang <[EMAIL PROTECTED]> --- qemu/hw/ipf.c |2 +- 1 f

[ kvm-Bugs-2076615 ] Win2K does not boot anymore

2008-08-28 Thread SourceForge.net
Bugs item #2076615, was opened at 2008-08-27 01:34 Message generated for change (Settings changed) made by amitshah You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2076615&group_id=180599 Please note that this message will contain a full copy of the comme

[IPF] Test report for kvm-74 on IPF --- kvm-ia64 is easy to be used from kvm-74

2008-08-28 Thread Zhang, Jingke
Hi all, From kvm-74, the building process of kvm-ia64 is the same as x86 side. It means kvm-ia64 is very easy to be used now. Still existing issues (2 have been fixed. 3 are in debuging): 1. [FIXED, not checked in] guest domain can not boot up network 2. [

Re: [ANNOUNCE] kvm-74 release

2008-08-28 Thread Charles Duffy
A few quick notes: - The extboot.bin regression from kvm-71 (SCSI drives being unavailable after reboot) is still outstanding. - kvm (and presumably qemu) doesn't check for fd= parameters pointing to file descriptor numbers which are not, in fact, open; this results in select() spinning on