Re: [lazarus] Proporosed patch for graphmath.pp and infbaselcl.inc

2007-04-23 Thread Alex Smirnov
Micha Nelissen ?: Alex Smirnov wrote: Why did you change FullAngle to dFullAngle? Actually, whole function was rewritten. And I alway notate my vars to understand the type of them. You think it is not a good idea? It doesn't matter much until you want to change the type ...

Re: [lazarus] Proporosed patch for graphmath.pp and infbaselcl.inc

2007-04-23 Thread Graeme Geldenhuys
On 4/23/07, Micha Nelissen <[EMAIL PROTECTED]> wrote: Alex Smirnov wrote: >> Why did you change FullAngle to dFullAngle? > Actually, whole function was rewritten. And I alway notate my vars to > understand the type of them. You think it is not a good idea? It doesn't matter much until you want t

Re: [lazarus] Proporosed patch for graphmath.pp and infbaselcl.inc

2007-04-23 Thread Micha Nelissen
Alex Smirnov wrote: >> Why did you change FullAngle to dFullAngle? > Actually, whole function was rewritten. And I alway notate my vars to > understand the type of them. You think it is not a good idea? It doesn't matter much until you want to change the type ... then you have to change a lot of c

Re: [lazarus] Proporosed patch for graphmath.pp and infbaselcl.inc

2007-04-23 Thread Alex Smirnov
*Hello, Vincent!* Good that you have this working. Thank you. Some remarks. I know to little of graphics to give feedback on the contents of the patch, so I will say only something about the style. Why did you change FullAngle to dFullAngle? Actually, whole function was rewritten. And I al

Re: [lazarus] Proporosed patch for graphmath.pp and infbaselcl.inc

2007-04-23 Thread Vincent Snijders
Alex Smirnov schreef: *Hello, Vincent!* Here are patches for mentioned files. It solves problem with GTK2 crash in Canvas.Pie (that is working without any troubles in GTK1). Also some things were changed in graphmath.pp for PolyBezierArcPoints. I had sent it before, but not as a patch - sorry

[lazarus] Proporosed patch for graphmath.pp and infbaselcl.inc

2007-04-23 Thread Alex Smirnov
*Hello, Vincent!* Here are patches for mentioned files. It solves problem with GTK2 crash in Canvas.Pie (that is working without any troubles in GTK1). Also some things were changed in graphmath.pp for PolyBezierArcPoints. I had sent it before, but not as a patch - sorry for that. I am really