Re: Discuss: remove support (later) for old unls in g.findUnl?

2023-07-08 Thread Edward K. Ream
On Sat, Jul 8, 2023 at 7:45 AM Thomas Passin wrote: These apps worked a week ago. I had already adapted them for the big PR > and checked that they work. Part of that was handling an escape that > hadn't needed to be handled previously (%3E for ">"). But here's another > that doesn't have

Re: Discuss: remove support (later) for old unls in g.findUnl?

2023-07-08 Thread Thomas Passin
On Saturday, July 8, 2023 at 8:28:09 AM UTC-4 Edward K. Ream wrote: On Sat, Jul 8, 2023 at 6:47 AM Thomas Passin wrote: Using the ekr-tweak-unls branch breaks both the bookmarks and zettel tabbed apps. I will look into what isn't working, but in the zettel browser, I see it's looking for

Re: Discuss: remove support (later) for old unls in g.findUnl?

2023-07-08 Thread Edward K. Ream
On Sat, Jul 8, 2023 at 6:47 AM Thomas Passin wrote: > Using the ekr-tweak-unls branch breaks both the bookmarks and zettel > tabbed apps. I will look into what isn't working, but in the zettel > browser, I see it's looking for and can't find expressions like > 'unl://#tom.20220910123825.1',

Re: Discuss: remove support (later) for old unls in g.findUnl?

2023-07-08 Thread Thomas Passin
Using the ekr-tweak-unls branch breaks both the bookmarks and zettel tabbed apps. I will look into what isn't working, but in the zettel browser, I see it's looking for and can't find expressions like 'unl://#tom.20220910123825.1', which is not a legacy unl. In the case of the bookmarks

Re: Discuss: remove support (later) for old unls in g.findUnl?

2023-07-08 Thread Edward K. Ream
On Fri, Jul 7, 2023 at 9:09 PM Thomas Passin wrote: > I've never used g.findUnl() with patterns at all. So as long as the > newer one picks up legacy-style unls I'd be OK with it. > Hmm. Your plugins might be using g.findUnl indirectly. Could you please put a trace at the start of g.findUnl

Re: Discuss: remove support (later) for old unls in g.findUnl?

2023-07-07 Thread Thomas Passin
I've never used g.findUnl() with patterns at all. So as long as the newer one picks up legacy-style unls I'd be OK with it. On Friday, July 7, 2023 at 7:36:26 PM UTC-4 Edward K. Ream wrote: > g.findUnl is the handler for path-based unls. It contains two regex > patterns: > > #

Discuss: remove support (later) for old unls in g.findUnl?

2023-07-07 Thread Edward K. Ream
g.findUnl is the handler for path-based unls. It contains two regex patterns: # (file_name):(comma-separated list of node indices) old_pat = re.compile(r'^(.*):(\d+),?(\d+)?,?([-\d]+)?,?(\d+)?$') # (file_name)::(line_number). new_pat = re.compile(r'^(.*?)(::)([-\d]+)?$') Leo's present unit