Re: ENB: about external file format 5-thin

2020-06-06 Thread Edward K. Ream
On Sat, Jun 6, 2020 at 8:30 AM vitalije wrote: Anyway, I won't insist on changing the format, but if we are changing > something it would be better to make all changes at once. > I agree. > > Regarding the first node start sentinel, perhaps new read code can just > skip this sentinel and use th

Re: ENB: about external file format 5-thin

2020-06-06 Thread Edward K. Ream
On Sat, Jun 6, 2020 at 10:48 AM Thomas Passin wrote: > > > On Saturday, June 6, 2020 at 10:42:37 AM UTC-4, vitalije wrote: >> >> >> You wonder why the speed of reading and writing matters. Perhaps when you >> use Leo it doesn't matter to you if it will load 200ms faster or not. But >> If a develo

Re: ENB: about external file format 5-thin

2020-06-06 Thread Thomas Passin
On Saturday, June 6, 2020 at 10:42:37 AM UTC-4, vitalije wrote: > > > You wonder why the speed of reading and writing matters. Perhaps when you > use Leo it doesn't matter to you if it will load 200ms faster or not. But > If a developer wants to run thousand of tests than 20ms less actually mea

Re: ENB: about external file format 5-thin

2020-06-06 Thread vitalije
On Saturday, June 6, 2020 at 4:18:00 PM UTC+2, Thomas Passin wrote: > > Edward also mentioned redundancy. IMO, redundancy that helps in error > recovery is good. Remember, there are going to be tens of thousands of > files in the new format eventually. Some of them will have mis-used > direc

Re: ENB: about external file format 5-thin

2020-06-06 Thread Thomas Passin
On Saturday, June 6, 2020 at 9:30:38 AM UTC-4, vitalije wrote: > > 6. Changing Leo's file format to make your new code easier to test would >> be letting the tail wag the dog. I am confident that you can find a robust >> testing strategy that does not depend on a new file format. >> > > I unders

Re: ENB: about external file format 5-thin

2020-06-06 Thread vitalije
> > 6. Changing Leo's file format to make your new code easier to test would > be letting the tail wag the dog. I am confident that you can find a robust > testing strategy that does not depend on a new file format. > I wrote this post not because I couldn't make tests. The attached Leo docume

Re: ENB: about external file format 5-thin

2020-06-06 Thread Edward K. Ream
On Fri, Jun 5, 2020 at 10:10 AM vitalije wrote: For the past few days I've been working on the reusable functions for both > parsing content of external files and writing external files. In the > attached Leo document there are two new scripts. One is for generating the > test data, and the other

Re: ENB: about external file format 5-thin

2020-06-05 Thread Thomas Passin
On Friday, June 5, 2020 at 1:34:31 PM UTC-4, vitalije wrote: > > >> >> I just used @delims the other day for a Windows command file. In cmd >> files I use "::" as a comment marker. I didn't find a Leo file type for >> cmd files, so I just went ahead and used the directive. >> > > Ok, this is

Re: ENB: about external file format 5-thin

2020-06-05 Thread vitalije
> This has bothered me five or ten times when for unusual reasons I wanted > to @file one external file from two Leo-Editor files. In most cases > this problem caused me to do something else. In one or two cases I > lived with this problem. > > -- > Segundo Bob > segun...@gmail.com > O

Re: ENB: about external file format 5-thin

2020-06-05 Thread vitalije
> > > > I just used @delims the other day for a Windows command file. In cmd > files I use "::" as a comment marker. I didn't find a Leo file type for > cmd files, so I just went ahead and used the directive. > Ok, this is a valid use case, though I didn't object this kind of usage.This ki

Re: ENB: about external file format 5-thin

2020-06-05 Thread Segundo Bob
On 6/5/20 8:10 AM, vitalije wrote: > top level node gnx and its headline are not necessary. Both headline and > gnx are present in the xml. They don't provide any useful information. > This also can cause problems when two different outlines contain the > same external file. If the top level node h

Re: ENB: about external file format 5-thin

2020-06-05 Thread Thomas Passin
On Friday, June 5, 2020 at 11:10:24 AM UTC-4, vitalije wrote: > > For the past few days I've been working on the reusable functions for both > parsing content of external files and writing external files. In the > attached Leo document there are two new scripts. One is for generating the > test

Re: ENB: about external file format 5-thin

2020-06-05 Thread vitalije
I forgot to mention that round trip using new functions is 1.9 times faster than using c.atFileCommands. Test script compares round trip of leo/core/leoGlobals.py $ python p.py setting leoID from os.getenv('USER'): 'vitalije' f_new average: 30.429ms f_old average: 58.055ms Vitalije -- You rec

ENB: about external file format 5-thin

2020-06-05 Thread vitalije
For the past few days I've been working on the reusable functions for both parsing content of external files and writing external files. In the attached Leo document there are two new scripts. One is for generating the test data, and the other is for testing these two new functions. All tests a