Re: Proposal: abandon #303 and VR3

2016-09-24 Thread Edward K. Ream
On Sat, Sep 24, 2016 at 6:37 AM, lewis wrote: > Thanks for the fix, these vr/vr2 plugins are now significantly more robust. > ​Thanks for the confirmation. ​> ​ May I suggest that Leo reports to the log pane 'switching to viewrendered' where applicable? ​Imo, that

Re: Proposal: abandon #303 and VR3

2016-09-24 Thread lewis
Thanks for the fix, these vr/vr2 plugins are now significantly more robust. With viewrendered2 *only* enabled: Leo reports 'The viewrendered2 plugin is not compatible with PyQt5' If you run vr commands, Leo remains stable and does not attempt or perform any rendering. With viewrendered and

Re: Proposal: abandon #303 and VR3

2016-09-24 Thread Edward K. Ream
On Sat, Sep 24, 2016 at 4:15 AM, Edward K. Ream wrote: > On Fri, Sep 23, 2016 at 7:13 PM, lewis wrote: > > ​​ >> Running commit 6e9d291, I ran vr and leo flashes the vr pane for a >> fraction of a second then leo closes completely. >> > ​Fixed at

Re: Proposal: abandon #303 and VR3

2016-09-24 Thread Edward K. Ream
On Fri, Sep 23, 2016 at 7:13 PM, lewis wrote: Running commit 6e9d291, I ran vr and leo flashes the vr pane for a fraction > of a second then leo closes completely. > ​Thanks for this report. vr2 is known not to work with PyQt5.​ ​This is a strange one: the log says:

Re: Proposal: abandon #303 and VR3

2016-09-23 Thread lewis
Running commit 6e9d291, I ran vr and leo flashes the vr pane for a fraction of a second then leo closes completely. Here is log after loading: *Leo Log WindowLeo 5.4-devel, build 20160722143100, Fri, Jul 22, 2016 2:31:00 PMGit repo info: branch = master, commit = 6e9d2918348dPython

Re: Proposal: abandon #303 and VR3

2016-09-23 Thread Edward K. Ream
On Thu, Sep 22, 2016 at 5:22 PM, lewis wrote: Leo successfully reports the that viewrendered2 doesn't get on well with > PyQt5, and proceeds to load viewrendered plugin. All the unpleasant errors > are gone. > This is very neat! > ​This is more of a bug than a feature

Re: Proposal: abandon #303 and VR3

2016-09-22 Thread lewis
I just ran last commit *3f0d2ce*, running vr2 and PyQt5 to test the new warnings: *Leo Log WindowLeo 5.4-devel, build 20160722143100, Fri, Jul 22, 2016 2:31:00 PMGit repo info: branch = master, commit = 3f0d2ce1acd8Python 3.5.2, PyQt version 5.7.0Windows 10 AMD64 (build 10.0.14393)

Re: Proposal: abandon #303 and VR3

2016-09-22 Thread Edward K. Ream
On Wednesday, September 21, 2016 at 3:45:44 PM UTC-5, Edward K. Ream wrote: > I'm having second thoughts about the wisdom of merging VR and VR2 into VR3 As mentioned just now in a comment to #303 , there is a much easier way to do the merge.

Re: Proposal: abandon #303 and VR3

2016-09-22 Thread Edward K. Ream
​​ On Wed, Sep 21, 2016 at 5:24 PM, lewis wrote: I was under the impression (possibly mistaken) that vr3 was the future and > that vr + vr2 were headed for the attic. > ​That was the original plan. This proposal it an acknowledgement that this plan wasn't working. The

Re: Proposal: abandon #303 and VR3

2016-09-21 Thread lewis
I was under the impression (possibly mistaken) that vr3 was the future and that vr + vr2 were headed for the attic. So now would be a good time to summarise the actual feature sets or differentiating features of vr, vr2 and vr3. I think this will help in reviewing any convincing reasons.

Proposal: abandon #303 and VR3

2016-09-21 Thread Edward K. Ream
I'm having second thoughts about the wisdom of merging VR and VR2 into VR3, for the following reasons: 1. The code bases are significantly different, despite similarities. 2. Most people will strongly prefer one or the other. 3. There is no great need for the merger. In fact, it's possible to