Re: [libav-devel] [PATCH] matroskaenc: expand WAVEFORMAT to WAVEFORMATEX for A_MS/ACM data

2011-10-12 Thread John Brooks
On Wed, Oct 12, 2011 at 11:53 PM, Anton Khirnov wrote: > > On Wed, 12 Oct 2011 18:40:48 -0600, John Brooks > wrote: >> >> It's also worth noting that asfenc contains similar logic, for the >> same reason. I'd prefer to handle this in ff_put_wav_header somehow, >> but I don't really think it's wo

Re: [libav-devel] [PATCH] matroskaenc: expand WAVEFORMAT to WAVEFORMATEX for A_MS/ACM data

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 18:40:48 -0600, John Brooks wrote: > 2011/10/12 Måns Rullgård : > > Are the files we produce valid?  If so, should the players not be fixed > > instead? > > > > I don't believe so; > http://matroska.org/technical/specs/codecid/index.html states that > "The private data conta

Re: [libav-devel] [PATCH 4/4] mlpdec: return meaningful error codes instead of -1

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 10:49:32PM -0400, Justin Ruggles wrote: > --- > libavcodec/mlp_parser.c |6 +- > libavcodec/mlpdec.c | 112 -- > 2 files changed, 61 insertions(+), 57 deletions(-) LGTM ___ lib

Re: [libav-devel] [PATCH 3/4] mlpdec: remove unnecessary wrapper function

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 10:49:31PM -0400, Justin Ruggles wrote: > --- > libavcodec/mlpdec.c | 15 +++ > 1 files changed, 3 insertions(+), 12 deletions(-) LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailm

Re: [libav-devel] [PATCH 2/4] mlpdec: only calculate output size once

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 10:49:30PM -0400, Justin Ruggles wrote: > --- > libavcodec/mlpdec.c | 10 +++--- > 1 files changed, 7 insertions(+), 3 deletions(-) LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/lis

Re: [libav-devel] [PATCH 1/4] mlpdec: validate that the reported channel count matches the actual output channel count

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 10:49:29PM -0400, Justin Ruggles wrote: > --- > libavcodec/mlpdec.c |9 +++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c > index c90285a..09e047a 100644 > --- a/libavcodec/mlpdec.c > +++ b/libavcode

[libav-devel] [PATCH 4/4] mlpdec: return meaningful error codes instead of -1

2011-10-12 Thread Justin Ruggles
--- libavcodec/mlp_parser.c |6 +- libavcodec/mlpdec.c | 112 -- 2 files changed, 61 insertions(+), 57 deletions(-) diff --git a/libavcodec/mlp_parser.c b/libavcodec/mlp_parser.c index e85eb72..e1f4c56 100644 --- a/libavcodec/mlp_parser.c +++ b

[libav-devel] [PATCH 3/4] mlpdec: remove unnecessary wrapper function

2011-10-12 Thread Justin Ruggles
--- libavcodec/mlpdec.c | 15 +++ 1 files changed, 3 insertions(+), 12 deletions(-) diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c index 370baf9..1fcd04a 100644 --- a/libavcodec/mlpdec.c +++ b/libavcodec/mlpdec.c @@ -901,14 +901,15 @@ static void rematrix_channels(MLPDecodeC

[libav-devel] [PATCH 2/4] mlpdec: only calculate output size once

2011-10-12 Thread Justin Ruggles
--- libavcodec/mlpdec.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c index 09e047a..370baf9 100644 --- a/libavcodec/mlpdec.c +++ b/libavcodec/mlpdec.c @@ -906,6 +906,7 @@ static int output_data_internal(MLPDecodeContext

[libav-devel] [PATCH 1/4] mlpdec: validate that the reported channel count matches the actual output channel count

2011-10-12 Thread Justin Ruggles
--- libavcodec/mlpdec.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c index c90285a..09e047a 100644 --- a/libavcodec/mlpdec.c +++ b/libavcodec/mlpdec.c @@ -909,11 +909,16 @@ static int output_data_internal(MLPDecodeContex

Re: [libav-devel] [PATCH] matroskaenc: expand WAVEFORMAT to WAVEFORMATEX for A_MS/ACM data

2011-10-12 Thread John Brooks
2011/10/12 Måns Rullgård : > Are the files we produce valid?  If so, should the players not be fixed > instead? > I don't believe so; http://matroska.org/technical/specs/codecid/index.html states that "The private data contains the ACM structure WAVEFORMATEX including the extra private bytes, as d

Re: [libav-devel] [PATCH] matroskaenc: expand WAVEFORMAT to WAVEFORMATEX for A_MS/ACM data

2011-10-12 Thread Måns Rullgård
John Brooks writes: > Fixes audio playback in some players (e.g. VLC) that expect a full > WAVEFORMATEX structure where we were generating WAVEFORMAT Are the files we produce valid? If so, should the players not be fixed instead? -- Måns Rullgård m...@mansr.com ___

[libav-devel] [PATCH] matroskaenc: expand WAVEFORMAT to WAVEFORMATEX for A_MS/ACM data

2011-10-12 Thread John Brooks
Fixes audio playback in some players (e.g. VLC) that expect a full WAVEFORMATEX structure where we were generating WAVEFORMAT Signed-off-by: John Brooks --- libavformat/matroskaenc.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavf

Re: [libav-devel] [PATCH 5/5] adpcmdec: calculate actual number of output samples for each decoder.

2011-10-12 Thread Justin Ruggles
On 10/12/2011 07:02 PM, Justin Ruggles wrote: > This also allows for removing some of the buf_size checks and using the > sample count for some of the decoding loops. > --- > libavcodec/adpcm.c | 352 > ++-- > 1 files changed, 232 insertions(+), 1

[libav-devel] [PATCH 5/5] adpcmdec: calculate actual number of output samples for each decoder.

2011-10-12 Thread Justin Ruggles
This also allows for removing some of the buf_size checks and using the sample count for some of the decoding loops. --- libavcodec/adpcm.c | 351 ++-- 1 files changed, 231 insertions(+), 120 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcode

[libav-devel] [PATCH 5/5] adpcmdec: calculate actual number of output samples for each decoder.

2011-10-12 Thread Justin Ruggles
This also allows for removing some of the buf_size checks and using the sample count for some of the decoding loops. --- libavcodec/adpcm.c | 352 ++-- 1 files changed, 232 insertions(+), 120 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcode

Re: [libav-devel] [PATCH] movenc: Don't wrap whole extradata atoms in glbl.

2011-10-12 Thread Alex Converse
On Fri, Sep 30, 2011 at 5:11 AM, Tomas Härdin wrote: > On Fri, 2011-09-30 at 13:44 +0200, Luca Barbato wrote: >> On 9/30/11 10:59 AM, Benjamin Larsson wrote: >> > >> >> >> >> At work we added an "int interlacing;" field to AVCodecContext. It's >> >> only set by a few decoders though (no demuxer se

[libav-devel] [PATCH] movenc: Rudimentary IODs support.

2011-10-12 Thread Alex Converse
--- libavformat/movenc.c | 39 --- libavformat/movenc.h |3 +++ 2 files changed, 31 insertions(+), 11 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index fb8749c..50f1a3e 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c

[libav-devel] [PATCH 3/5] avformat: add AVInputFormat flag AVFMT_NO_BYTE_SEEK.

2011-10-12 Thread Justin Ruggles
This will prevent seeking by bytes for formats that cannot handle this. --- doc/APIchanges |3 +++ libavformat/avformat.h |3 ++- libavformat/utils.c|2 +- libavformat/version.h |2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/

[libav-devel] [PATCH 6/7] mpegts: MP4 OD support

2011-10-12 Thread Alex Converse
--- libavformat/isom.h |1 + libavformat/mpegts.c | 88 ++ 2 files changed, 89 insertions(+), 0 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 838eb42..04edb1f 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h

[libav-devel] [PATCH 7/7] mpegts: MP4 SL support

2011-10-12 Thread Alex Converse
--- libavformat/isom.h |1 + libavformat/mpegts.c | 157 +++--- libavformat/mpegts.h | 18 ++ 3 files changed, 155 insertions(+), 21 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 04edb1f..e6d04dc 100644 --- a/libav

[libav-devel] [PATCH 5/7] mpegts: Add support for Sections in PMT

2011-10-12 Thread Alex Converse
--- libavformat/mpegts.c | 39 ++- libavformat/mpegts.h |4 +++- libavformat/wtv.c|2 +- 3 files changed, 38 insertions(+), 7 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 6a50dc7..2a4e0e2 100644 --- a/libavformat/mpe

[libav-devel] [PATCH 4/7] mpegts: Replace the MP4 descriptor parser with a recursive parser.

2011-10-12 Thread Alex Converse
--- libavformat/mpegts.c | 174 -- 1 files changed, 140 insertions(+), 34 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index bb7390d..6a50dc7 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -868,38 +868,147

[libav-devel] [PATCH 3/7] mpegts: Add support for multiple mp4 descriptors

2011-10-12 Thread Alex Converse
--- libavformat/mpegts.c | 40 libavformat/mpegts.h |9 +++-- libavformat/wtv.c|2 +- 3 files changed, 32 insertions(+), 19 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 5753136..bb7390d 100644 --- a/libavfor

[libav-devel] [PATCH 2/7] mpegts: Parse mpeg2 SL descriptors.

2011-10-12 Thread Alex Converse
--- libavformat/mpegts.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index b232b2c..5753136 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -907,7 +907,7 @@ int ff_parse_mpeg2_descriptor(AVFormat

[libav-devel] [PATCH 1/7] isom: Add MPEG4SYSTEMS dummy object type indication.

2011-10-12 Thread Alex Converse
--- libavcodec/avcodec.h |2 ++ libavformat/isom.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 5a69c24..26a8273 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -365,6 +365,8 @@ enum CodecID {

[libav-devel] [PATCH 0/7] DMB demuxer

2011-10-12 Thread Alex Converse
This patch set adds support for DMB to the MPEG-TS demuxer. It is still a little rough around the edges. I'd appreciate feedback on what to do with the parser and how to handle the timebase. DMB samples are available at http://streams.videolan.org/samples/V-codecs/h264/dmb/ [PATCH 1/7] isom:

Re: [libav-devel] [PATCH 3/5] avformat: add AVInputFormat flag AVFMT_NO_SEEK_BY_BYTES.

2011-10-12 Thread Justin Ruggles
On 10/12/2011 05:24 PM, Anton Khirnov wrote: > > On Sun, 2 Oct 2011 12:09:09 -0400, Justin Ruggles > wrote: >> This will prevent seeking by bytes for formats that cannot handle this. >> --- >> libavformat/avformat.h |3 ++- >> libavformat/utils.c|2 +- >> 2 files changed, 3 insert

Re: [libav-devel] [PATCH 3/5] avformat: add AVInputFormat flag AVFMT_NO_SEEK_BY_BYTES.

2011-10-12 Thread Anton Khirnov
On Sun, 2 Oct 2011 12:09:09 -0400, Justin Ruggles wrote: > This will prevent seeking by bytes for formats that cannot handle this. > --- > libavformat/avformat.h |3 ++- > libavformat/utils.c|2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > I guess a minor or micro bump

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 22:16:53 +0100, Måns Rullgård wrote: > Anton Khirnov writes: > > > On Wed, 12 Oct 2011 21:55:58 +0100, Måns Rullgård wrote: > >> Anton Khirnov writes: > >> > >> > On Wed, 12 Oct 2011 21:41:52 +0100, Måns Rullgård wrote: > >> >> Jindřich Makovička writes: > >> >> > >> >

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Måns Rullgård
Anton Khirnov writes: > On Wed, 12 Oct 2011 21:55:58 +0100, Måns Rullgård wrote: >> Anton Khirnov writes: >> >> > On Wed, 12 Oct 2011 21:41:52 +0100, Måns Rullgård wrote: >> >> Jindřich Makovička writes: >> >> >> >> > Hi, >> >> > >> >> > when including avutil/log.h in the code compiled as C

Re: [libav-devel] [PATCH 2/4] rtsp: Accept options via private avoptions instead of URL options

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 23:41:40 +0300 (EEST), Martin Storsjö wrote: > On Wed, 12 Oct 2011, Anton Khirnov wrote: > > > On Wed, 12 Oct 2011 22:30:54 +0200, Anton Khirnov wrote: > >> > >>> /** Whether the server accepts the x-Dynamic-Rate header */ > >>> int accept_dynamic_rate; > >>> + >

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 21:55:58 +0100, Måns Rullgård wrote: > Anton Khirnov writes: > > > On Wed, 12 Oct 2011 21:41:52 +0100, Måns Rullgård wrote: > >> Jindřich Makovička writes: > >> > >> > Hi, > >> > > >> > when including avutil/log.h in the code compiled as C++, g++ 4.6 > >> > >> Libav is C

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Uoti Urpala
On Wed, 2011-10-12 at 22:03 +0100, Måns Rullgård wrote: > git grep 'struct AVClass' comes up blank here... Maybe you're running it in the wrong repo or something? Or outdated one? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.or

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Jindřich Makovička
2011/10/12 Måns Rullgård : > Anton Khirnov writes: > >> On Wed, 12 Oct 2011 21:41:52 +0100, Måns Rullgård wrote: >>> Jindřich Makovička writes: >>> >>> > Hi, >>> > >>> > when including avutil/log.h in the code compiled as C++, g++ 4.6 >>> >>> Libav is C, not C++. >>> >> >> Which doesn't mean it

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Måns Rullgård
Uoti Urpala writes: > On Wed, 2011-10-12 at 21:41 +0100, Måns Rullgård wrote: >> > when including avutil/log.h in the code compiled as C++, g++ 4.6 >> >> Libav is C, not C++. > > I already reported the problem with that code on IRC earlier. It's buggy > C too. As the quoted error messages show,

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Uoti Urpala
On Wed, 2011-10-12 at 21:41 +0100, Måns Rullgård wrote: > > when including avutil/log.h in the code compiled as C++, g++ 4.6 > > Libav is C, not C++. I already reported the problem with that code on IRC earlier. It's buggy C too. As the quoted error messages show, the code does refer to "struct A

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Måns Rullgård
Anton Khirnov writes: > On Wed, 12 Oct 2011 21:41:52 +0100, Måns Rullgård wrote: >> Jindřich Makovička writes: >> >> > Hi, >> > >> > when including avutil/log.h in the code compiled as C++, g++ 4.6 >> >> Libav is C, not C++. >> > > Which doesn't mean it should be unusable in C++ code. Will

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 21:41:52 +0100, Måns Rullgård wrote: > Jindřich Makovička writes: > > > Hi, > > > > when including avutil/log.h in the code compiled as C++, g++ 4.6 > > Libav is C, not C++. > Which doesn't mean it should be unusable in C++ code. The patch looks fine to me, maybe with a

Re: [libav-devel] [PATCH] avconv: add presets

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 16:23:42 +0200, Diego Biurrun wrote: > On Wed, Oct 12, 2011 at 01:35:19PM +0100, alexan...@khirnov.net wrote: > > > > --- a/avconv.c > > +++ b/avconv.c > > @@ -2966,15 +2968,62 @@ static void parse_forced_key_frames(char *kf, > > OutputStream *ost, > > > > +while ((c =

Re: [libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Måns Rullgård
Jindřich Makovička writes: > Hi, > > when including avutil/log.h in the code compiled as C++, g++ 4.6 Libav is C, not C++. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/lib

Re: [libav-devel] [PATCH 2/4] rtsp: Accept options via private avoptions instead of URL options

2011-10-12 Thread Martin Storsjö
On Wed, 12 Oct 2011, Anton Khirnov wrote: On Wed, 12 Oct 2011 22:30:54 +0200, Anton Khirnov wrote: /** Whether the server accepts the x-Dynamic-Rate header */ int accept_dynamic_rate; + +/** + * Various option flags for the RTSP muxer/demuxer. + */ +int rtsp_flags;

[libav-devel] fix build error when using avutil/log.h with C++ code

2011-10-12 Thread Jindřich Makovička
Hi, when including avutil/log.h in the code compiled as C++, g++ 4.6 produces the following error because of missing AVClass struct name in the declaration. log.h:89:3: error: conflicting declaration ‘typedef struct AVClass AVClass’ log.h:88:18: error: ‘struct AVClass’ has a previous declaration

Re: [libav-devel] [PATCH 2/4] rtsp: Accept options via private avoptions instead of URL options

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 22:30:54 +0200, Anton Khirnov wrote: > > > > > @@ -1308,15 +1315,23 @@ int ff_rtsp_connect(AVFormatContext *s) > > char *option_list, *option, *filename; > > int port, err, tcp_fd; > > RTSPMessageHeader reply1 = {0}, *reply = &reply1; > > -int lower_trans

Re: [libav-devel] [PATCH 1/4] rtsp: Merge the AVOption lists

2011-10-12 Thread Martin Storsjö
On Wed, 12 Oct 2011, Anton Khirnov wrote: On Wed, 12 Oct 2011 20:56:12 +0300, Martin Storsjö wrote: This eases adding options that are common for both. The AV_OPT_FLAG_EN/DECODING_PARAM still indicates whether they belong to the muxer or demuxer. --- libavformat/rtsp.c|7 +++ lib

Re: [libav-devel] [PATCH 2/4] rtsp: Accept options via private avoptions instead of URL options

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 20:56:13 +0300, Martin Storsjö wrote: > Eventually, the old way of passing options by adding > stuff to the URL can be dropped. > > This avoids having to tamper with the user-specified URL to > pass options on the transport mode. This also works better > with redirects, since

Re: [libav-devel] [PATCH 3/5] avformat: add AVInputFormat flag AVFMT_NO_SEEK_BY_BYTES.

2011-10-12 Thread Justin Ruggles
On 10/12/2011 03:55 PM, Janne Grunau wrote: > On Wed, Oct 12, 2011 at 09:50:13PM +0200, Janne Grunau wrote: >> On Sun, Oct 02, 2011 at 12:09:09PM -0400, Justin Ruggles wrote: >>> This will prevent seeking by bytes for formats that cannot handle this. >>> --- >>> libavformat/avformat.h |3 ++-

Re: [libav-devel] [PATCH 1/4] rtsp: Merge the AVOption lists

2011-10-12 Thread Anton Khirnov
On Wed, 12 Oct 2011 20:56:12 +0300, Martin Storsjö wrote: > This eases adding options that are common for both. The > AV_OPT_FLAG_EN/DECODING_PARAM still indicates whether they belong > to the muxer or demuxer. > --- > libavformat/rtsp.c|7 +++ > libavformat/rtsp.h|3 +++ > l

Re: [libav-devel] [PATCH 5/5] adpcmdec: calculate actual number of output samples for each decoder.

2011-10-12 Thread Justin Ruggles
On 10/12/2011 03:38 PM, Janne Grunau wrote: > On Tue, Oct 04, 2011 at 06:02:07PM -0400, Justin Ruggles wrote: >> This also allows for removing some of the buf_size checks and using the >> sample count for some of the decoding loops. >> --- >> libavcodec/adpcm.c | 352 >>

Re: [libav-devel] [PATCH 5/5] shorten: remove the flush function.

2011-10-12 Thread Janne Grunau
On Sun, Oct 02, 2011 at 12:09:11PM -0400, Justin Ruggles wrote: > The shorten decoder does not support seeking. > --- > libavcodec/shorten.c |8 > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/shorten.c b/libavcodec/shorten.c > index 80b1b4d..03c6f54 10

Re: [libav-devel] [PATCH 3/5] avformat: add AVInputFormat flag AVFMT_NO_SEEK_BY_BYTES.

2011-10-12 Thread Janne Grunau
On Wed, Oct 12, 2011 at 09:50:13PM +0200, Janne Grunau wrote: > On Sun, Oct 02, 2011 at 12:09:09PM -0400, Justin Ruggles wrote: > > This will prevent seeking by bytes for formats that cannot handle this. > > --- > > libavformat/avformat.h |3 ++- > > libavformat/utils.c|2 +- > > 2 fil

Re: [libav-devel] [PATCH 4/5] shn: do not allow seeking in the raw shn demuxer.

2011-10-12 Thread Janne Grunau
On Sun, Oct 02, 2011 at 12:09:10PM -0400, Justin Ruggles wrote: > The demuxer does not read the seektable, a parser is not possible without a > full decode, and no shorten decoder can handle random seeking because it needs > side info from the seektable. > --- > libavformat/rawdec.c |2 +- > 1

Re: [libav-devel] [PATCH 3/5] avformat: add AVInputFormat flag AVFMT_NO_SEEK_BY_BYTES.

2011-10-12 Thread Janne Grunau
On Sun, Oct 02, 2011 at 12:09:09PM -0400, Justin Ruggles wrote: > This will prevent seeking by bytes for formats that cannot handle this. > --- > libavformat/avformat.h |3 ++- > libavformat/utils.c|2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/

Re: [libav-devel] [PATCH 2/5] avformat: update AVInputFormat allowed flags

2011-10-12 Thread Janne Grunau
On Sun, Oct 02, 2011 at 12:09:08PM -0400, Justin Ruggles wrote: > --- > libavformat/avformat.h |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index cc5457e..7b350f1 100644 > --- a/libavformat/avformat.h > +++ b/li

Re: [libav-devel] [PATCH 1/5] avformat: don't unconditionally call ff_read_frame_flush() when trying to seek.

2011-10-12 Thread Janne Grunau
On Sun, Oct 02, 2011 at 12:09:07PM -0400, Justin Ruggles wrote: > This prevents flushing the packet buffer when the input format does not > support seeking. > --- > libavformat/utils.c | 24 ++-- > 1 files changed, 14 insertions(+), 10 deletions(-) > > diff --git a/libavform

Re: [libav-devel] [PATCH 4/6] fmtconvert: check compile-time x86 instruction set flags

2011-10-12 Thread Janne Grunau
On Wed, Oct 12, 2011 at 03:24:05PM -0400, Justin Ruggles wrote: > --- > libavcodec/x86/fmtconvert_mmx.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/x86/fmtconvert_mmx.c b/libavcodec/x86/fmtconvert_mmx.c > index 949dc97..6e43280 100644 > --- a/li

Re: [libav-devel] [PATCH 5/5] adpcmdec: calculate actual number of output samples for each decoder.

2011-10-12 Thread Janne Grunau
On Tue, Oct 04, 2011 at 06:02:07PM -0400, Justin Ruggles wrote: > This also allows for removing some of the buf_size checks and using the > sample count for some of the decoding loops. > --- > libavcodec/adpcm.c | 352 > +++- > 1 files changed, 235

[libav-devel] [PATCH 6/6] fmtconvert: port float_to_int16_interleave() 2-channel x86 inline asm to yasm

2011-10-12 Thread Justin Ruggles
--- libavcodec/x86/fmtconvert.asm | 52 + libavcodec/x86/fmtconvert_mmx.c | 69 +- 2 files changed, 61 insertions(+), 60 deletions(-) diff --git a/libavcodec/x86/fmtconvert.asm b/libavcodec/x86/fmtconvert.asm index 734a7f6..9bf

[libav-devel] [PATCH 4/6] fmtconvert: check compile-time x86 instruction set flags

2011-10-12 Thread Justin Ruggles
--- libavcodec/x86/fmtconvert_mmx.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/fmtconvert_mmx.c b/libavcodec/x86/fmtconvert_mmx.c index 949dc97..6e43280 100644 --- a/libavcodec/x86/fmtconvert_mmx.c +++ b/libavcodec/x86/fmtconvert_mmx.c @@ -208,19

Re: [libav-devel] [PATCH 4/5] adpcmdec: check remaining buffer size before decoding next block in the ADPCM IMA WAV decoder.

2011-10-12 Thread Janne Grunau
On Tue, Oct 04, 2011 at 06:02:06PM -0400, Justin Ruggles wrote: > --- > libavcodec/adpcm.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index 023805b..c26c515 100644 > --- a/libavcodec/adpcm.c > +++ b/libavcodec/adpcm.c >

Re: [libav-devel] [PATCH 4/6] fmtconvert: check compile-time x86 instruction set flags

2011-10-12 Thread Måns Rullgård
Justin Ruggles writes: > -if(mm_flags & AV_CPU_FLAG_3DNOW){ > +if (mm_flags & AV_CPU_FLAG_3DNOW && HAVE_AMD3DNOW){ ^ ^ If you're fixing the whitespace at one end, why not the other? -- Måns Rullgård m...@mansr.com __

Re: [libav-devel] [PATCH 4/6] fmtconvert: check compile-time x86 instruction set flags

2011-10-12 Thread Janne Grunau
On Mon, Oct 10, 2011 at 12:48:17AM -0400, Justin Ruggles wrote: > --- > libavcodec/x86/fmtconvert_mmx.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/x86/fmtconvert_mmx.c b/libavcodec/x86/fmtconvert_mmx.c > index 949dc97..6371a89 100644 > --- a/li

Re: [libav-devel] [PATCH 2/2] avplay: free the active audio packet at exit.

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 02:47:54PM -0400, Justin Ruggles wrote: > fixes a memleak > --- > avplay.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/avplay.c b/avplay.c > index c2b5e4b..a4b58a5 100644 > --- a/avplay.c > +++ b/avplay.c > @@ -2268,6 +2268,7 @@ static voi

Re: [libav-devel] [PATCH 1/2] avplay: free rdft data used for spectrogram analysis.

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 02:47:53PM -0400, Justin Ruggles wrote: > fixes a memleak > --- > avplay.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/avplay.c b/avplay.c > index 8da50eb..c2b5e4b 100644 > --- a/avplay.c > +++ b/avplay.c > @@ -2271,6 +2271,11 @@ stati

[libav-devel] [PATCH 2/2] avplay: free the active audio packet at exit.

2011-10-12 Thread Justin Ruggles
fixes a memleak --- avplay.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/avplay.c b/avplay.c index c2b5e4b..a4b58a5 100644 --- a/avplay.c +++ b/avplay.c @@ -2268,6 +2268,7 @@ static void stream_component_close(VideoState *is, int stream_index) SDL_CloseAudio(

[libav-devel] [PATCH 1/2] avplay: free rdft data used for spectrogram analysis.

2011-10-12 Thread Justin Ruggles
fixes a memleak --- avplay.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/avplay.c b/avplay.c index 8da50eb..c2b5e4b 100644 --- a/avplay.c +++ b/avplay.c @@ -2271,6 +2271,11 @@ static void stream_component_close(VideoState *is, int stream_index) if (is->re

[libav-devel] [PATCH 0/2] fix avplay memleaks

2011-10-12 Thread Justin Ruggles
valgrind output when playing a wav file: current: ==10157== LEAK SUMMARY: ==10157==definitely lost: 12,470 bytes in 6 blocks ==10157==indirectly lost: 5,296 bytes in 6 blocks ==10157== possibly lost: 8,176 bytes in 1 blocks ==10157==still reachable: 125,971 bytes in 1,357 blocks

[libav-devel] [PATCH] mpegtsenc: fix av_freep() of adts null pointer

2011-10-12 Thread Chris Kennedy
The mpegts_write_end() function in libavformat/mpegtsenc.c trys to run av_freep() on the adts data part of the mpegts structure even when it wasn't allocated (non AAC based audio in mpegts). This has given segfaults, seems to rarely happen but it does, and code seems to just "make sense". Plus m

[libav-devel] [PATCH 4/4] doc: Update the documentation on setting options for RTSP

2011-10-12 Thread Martin Storsjö
--- doc/protocols.texi | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index cc35982..8aee5f6 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -246,12 +246,15 @@ supporting it (currently Darwin Strea

[libav-devel] [PATCH 3/4] rtsp: Remove the separate filter_source variable

2011-10-12 Thread Martin Storsjö
Read it as a flag from the flags field instead. --- libavformat/rtsp.c |6 ++ libavformat/rtsp.h |4 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 27cf78c..99f6902 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp

[libav-devel] [PATCH 2/4] rtsp: Accept options via private avoptions instead of URL options

2011-10-12 Thread Martin Storsjö
Eventually, the old way of passing options by adding stuff to the URL can be dropped. This avoids having to tamper with the user-specified URL to pass options on the transport mode. This also works better with redirects, since the options don't need to be parsed out from the URL. --- libavformat/

[libav-devel] [PATCH 1/4] rtsp: Merge the AVOption lists

2011-10-12 Thread Martin Storsjö
This eases adding options that are common for both. The AV_OPT_FLAG_EN/DECODING_PARAM still indicates whether they belong to the muxer or demuxer. --- libavformat/rtsp.c|7 +++ libavformat/rtsp.h|3 +++ libavformat/rtspdec.c |8 +--- libavformat/rtspenc.c |9 +--

[libav-devel] [PATCH 2/4] lavf, lavd: replace av_new_stream->avformat_new_stream part I.

2011-10-12 Thread Anton Khirnov
Trivial replacements with sed are done in this commit: sed 's/av_new_stream(\([^)]*\), 0)/avformat_new_stream(\1, NULL)/' --- libavdevice/alsa-audio-dec.c |2 +- libavdevice/bktr.c |2 +- libavdevice/fbdev.c |2 +- libavdevice/jack_audio.c |2 +- libavdevice/

[libav-devel] [PATCH 3/4] lavf: replace av_new_stream->avformat_new_stream part II.

2011-10-12 Thread Anton Khirnov
Manual replacements are done in this commit. --- avconv.c|5 - libavformat/4xm.c |2 +- libavformat/applehttp.c |3 ++- libavformat/avidec.c|2 +- libavformat/avisynth.c |4 ++-- libavformat/avs.c |4 ++-- libavformat/bink.c |2

[libav-devel] [PATCH 1/4] lavf: add avformat_new_stream as a replacement for av_new_stream.

2011-10-12 Thread Anton Khirnov
It takes a codec parameter, thus enabling codec-specific defaults. --- doc/APIchanges |3 +++ libavformat/avformat.h | 21 + libavformat/utils.c| 13 +++-- libavformat/version.h |5 - 4 files changed, 39 insertions(+), 3 deletions(-) diff -

[libav-devel] [PATCH 4/4] lavc: make avcodec_get_context_defaults3 "officially" public

2011-10-12 Thread Anton Khirnov
Deprecate avcodec_get_context_defaults/avcodec_get_context_defaults2 --- avserver.c |4 ++-- libavcodec/avcodec.h | 16 ++-- libavcodec/options.c | 38 +++--- 3 files changed, 35 insertions(+), 23 deletions(-) diff --git a/avserver.c b

[libav-devel] [PATCH] Support for lossless and inter H264 4:2:2.

2011-10-12 Thread Ronald S. Bultje
Hi, attached patch isn't entirely complete, e.g. I believe mbaff + contrained intra pred is broken for 4:2:2 (we don't check each side edge, this requires extending the prediction modes a bit 422-specifically). Also, lossless is untested because JM fails to generate correct 422 lossless samples, s

Re: [libav-devel] [PATCH 14/15] AVOptions: bump minor and add APIchanges entry.

2011-10-12 Thread Luca Barbato
On 10/6/11 10:10 PM, Anton Khirnov wrote: --- Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 13/15] cmdutils/avtools: simplify show_help() by using av_opt_child_class_next()

2011-10-12 Thread Luca Barbato
On 10/6/11 10:10 PM, Anton Khirnov wrote: --- avconv.c | 44 avplay.c | 15 +++ avprobe.c |4 +--- cmdutils.c | 10 ++ cmdutils.h |6 ++ 5 files changed, 24 insertions(+), 55 deletions(-) Looks nice.

Re: [libav-devel] [PATCH 12/15] AVOptions: rename FF_OPT_TYPE_* => AV_OPT_TYPE_*

2011-10-12 Thread Luca Barbato
On 10/6/11 10:10 PM, Anton Khirnov wrote: --- Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] avconv: add presets

2011-10-12 Thread Janne Grunau
On Wed, Oct 12, 2011 at 04:23:42PM +0200, Diego Biurrun wrote: > On Wed, Oct 12, 2011 at 01:35:19PM +0100, alexan...@khirnov.net wrote: > > > > --- a/avconv.c > > +++ b/avconv.c > > +for (i = 0; i < FF_ARRAY_ELEMS(base) && ret; i++) { > > +if (!base[i]) > > +continue; > > +

Re: [libav-devel] [PATCH 15/15] AVOptions: add documentation.

2011-10-12 Thread Anton Khirnov
ping -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 14/15] AVOptions: bump minor and add APIchanges entry.

2011-10-12 Thread Anton Khirnov
ping -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 13/15] cmdutils/avtools: simplify show_help() by using av_opt_child_class_next()

2011-10-12 Thread Anton Khirnov
ping -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 12/15] AVOptions: rename FF_OPT_TYPE_* => AV_OPT_TYPE_*

2011-10-12 Thread Anton Khirnov
ping -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] avconv: add presets

2011-10-12 Thread Diego Biurrun
On Wed, Oct 12, 2011 at 01:35:19PM +0100, alexan...@khirnov.net wrote: > > --- a/avconv.c > +++ b/avconv.c > @@ -2966,15 +2968,62 @@ static void parse_forced_key_frames(char *kf, > OutputStream *ost, > > +while ((c = avio_r8(s)) && (c != '\n')) The second set of parentheses is unnecessary.

Re: [libav-devel] [PATCH] rv34: NEON optimised inverse transform functions

2011-10-12 Thread Måns Rullgård
Måns Rullgård writes: > Kostya Shishkov writes: > >> On Wed, Oct 12, 2011 at 03:05:52PM +0100, Måns Rullgård wrote: >>> Kostya Shishkov writes: >>> >>> > The patch looks OK though. >>> >>> No, it does not. >> >> Please elaborate, I also want to learn. > > I'll do a full review later. Which w

Re: [libav-devel] [PATCH] rv34: NEON optimised inverse transform functions

2011-10-12 Thread Måns Rullgård
Kostya Shishkov writes: > On Wed, Oct 12, 2011 at 03:05:52PM +0100, Måns Rullgård wrote: >> Kostya Shishkov writes: >> >> > The patch looks OK though. >> >> No, it does not. > > Please elaborate, I also want to learn. I'll do a full review later. -- Måns Rullgård m...@mansr.com

Re: [libav-devel] [PATCH] rv34: NEON optimised inverse transform functions

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 03:05:52PM +0100, Måns Rullgård wrote: > Kostya Shishkov writes: > > > The patch looks OK though. > > No, it does not. Please elaborate, I also want to learn. ___ libav-devel mailing list libav-devel@libav.org https://lists.lib

Re: [libav-devel] [PATCH] rv34: NEON optimised inverse transform functions

2011-10-12 Thread Måns Rullgård
Kostya Shishkov writes: > The patch looks OK though. No, it does not. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] rtpdec: Add ff_ prefix to all nonstatic symbols

2011-10-12 Thread Luca Barbato
On 10/12/11 2:37 PM, Martin Storsjö wrote: On Wed, 12 Oct 2011, Luca Barbato wrote: On 10/12/11 2:25 PM, Martin Storsjö wrote: Actually, you should be able to do what you want to do in feng with the public APIs already. What you want to do is RTP packetization and perhaps also sending the data

Re: [libav-devel] [PATCH] rv34: NEON optimised inverse transform functions

2011-10-12 Thread Kostya Shishkov
On Wed, Oct 12, 2011 at 03:46:08PM +0200, Janne Grunau wrote: > On Wed, Oct 05, 2011 at 07:03:52AM +0200, Kostya Shishkov wrote: > > On Tue, Oct 04, 2011 at 10:32:16PM +0200, Janne Grunau wrote: > > > +void ff_rv30dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) > > > +{ > > > +c->rv34_inv_tra

Re: [libav-devel] [PATCH] avconv: add presets

2011-10-12 Thread Luca Barbato
On 10/12/11 2:35 PM, alexan...@khirnov.net wrote: +static uint8_t *get_line(AVIOContext *s) +{ +AVIOContext *line; +uint8_t *buf; +char c; + +if (avio_open_dyn_buf(&line)< 0) { +av_log(NULL, AV_LOG_FATAL, "Could not alloc buffer for reading preset.\n"); +exit_pro

[libav-devel] [PATCH] rv34: NEON optimised inverse transform functions

2011-10-12 Thread Janne Grunau
On Wed, Oct 05, 2011 at 07:03:52AM +0200, Kostya Shishkov wrote: > On Tue, Oct 04, 2011 at 10:32:16PM +0200, Janne Grunau wrote: > > +void ff_rv30dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) > > +{ > > +c->rv34_inv_transform_tab[0] = ff_rv34_inv_transform_neon; > > +c->rv34_inv_transfo

Re: [libav-devel] [PATCH] rtpdec: Add ff_ prefix to all nonstatic symbols

2011-10-12 Thread Martin Storsjö
On Wed, 12 Oct 2011, Luca Barbato wrote: On 10/12/11 2:25 PM, Martin Storsjö wrote: Actually, you should be able to do what you want to do in feng with the public APIs already. What you want to do is RTP packetization and perhaps also sending the data over UDP, right? No =) I'd like to use th

[libav-devel] [PATCH] avconv: add presets

2011-10-12 Thread alexandra
From 3e7b15ac0672ba8895b442ffb8538ae50980c27a Mon Sep 17 00:00:00 2001 From: Alexandra Khirnova Date: Mon, 10 Oct 2011 11:52:13 +0100 Subject: [PATCH] avconv: add presets --- avconv.c| 76 ++- doc/avconv.texi | 17 2

Re: [libav-devel] [PATCH] rtpdec: Add ff_ prefix to all nonstatic symbols

2011-10-12 Thread Luca Barbato
On 10/12/11 2:25 PM, Martin Storsjö wrote: Actually, you should be able to do what you want to do in feng with the public APIs already. What you want to do is RTP packetization and perhaps also sending the data over UDP, right? No =) I'd like to use the rtp packetizers but keep the network part

Re: [libav-devel] [PATCH 1/2] flvenc: Write the right metadata entry count

2011-10-12 Thread Martin Storsjö
On Wed, 12 Oct 2011, Luca Barbato wrote: On 9/21/11 6:05 PM, Martin Storsjö wrote: On Wed, 21 Sep 2011, Alex Converse wrote: On Wed, Sep 21, 2011 at 7:14 AM, Martin Storsjö wrote: --- libavformat/flvenc.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) Based on

Re: [libav-devel] [PATCH] rtpdec: Add ff_ prefix to all nonstatic symbols

2011-10-12 Thread Martin Storsjö
On Wed, 12 Oct 2011, Luca Barbato wrote: On 10/12/11 1:54 PM, Martin Storsjö wrote: On Wed, 12 Oct 2011, Luca Barbato wrote: Ok, once we got enough time and will we should think about expose more rtp layer properly I'm afraid... Applied And yes, exposing parts of that might be valuable, bu

Re: [libav-devel] [PATCH] rtpdec: Add ff_ prefix to all nonstatic symbols

2011-10-12 Thread Luca Barbato
On 10/12/11 1:54 PM, Martin Storsjö wrote: On Wed, 12 Oct 2011, Luca Barbato wrote: On 10/12/11 1:44 PM, Martin Storsjö wrote: --- avserver.c | 4 ++-- libavformat/rtpdec.c | 16 libavformat/rtpdec.h | 24 libavformat/rtpproto.c | 8 libavformat/r

  1   2   >