Re: [libav-devel] [PATCH] configure: add POWER[5-7] support

2012-05-04 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: Also merge POWER3 and POWER4 configuration together with the additions. --- configure |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 1dc2e3e..ed1624e 100755 --- a/configure +++ b/configure

Re: [libav-devel] [PATCH] lavfi: add a function for copying properties from AVFilterBufferRef-AVFrame

2012-05-04 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: Based on a commit by Stefano Sabatini stefano.sabatini-l...@poste.it --- libavfilter/avfilter.c | 23 +++ libavfilter/avfilter.h |8 2 files changed, 31 insertions(+) What is it good for? -- Måns Rullgård

Re: [libav-devel] [PATCH] lavfi: add a function for copying properties from AVFilterBufferRef-AVFrame

2012-05-04 Thread Anton Khirnov
On Fri, 04 May 2012 12:58:02 +0100, Måns Rullgård m...@mansr.com wrote: Anton Khirnov an...@khirnov.net writes: Based on a commit by Stefano Sabatini stefano.sabatini-l...@poste.it --- libavfilter/avfilter.c | 23 +++ libavfilter/avfilter.h |8 2

Re: [libav-devel] [PATCH 3/3] aacps: NEON optimisations

2012-05-04 Thread Måns Rullgård
Måns Rullgård m...@mansr.com writes: Mans Rullgard m...@mansr.com writes: Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/aacpsdsp.c |3 + libavcodec/aacpsdsp.h |1 + libavcodec/arm/Makefile|6 +-

Re: [libav-devel] [PATCH] lavfi: add a function for copying properties from AVFilterBufferRef-AVFrame

2012-05-04 Thread Måns Rullgård
Anton Khirnov an...@khirnov.net writes: On Fri, 04 May 2012 12:58:02 +0100, Måns Rullgård m...@mansr.com wrote: Anton Khirnov an...@khirnov.net writes: Based on a commit by Stefano Sabatini stefano.sabatini-l...@poste.it --- libavfilter/avfilter.c | 23 +++

Re: [libav-devel] [PATCH] lavfi: add a function for copying properties from AVFilterBufferRef-AVFrame

2012-05-04 Thread Anton Khirnov
On Fri, 04 May 2012 13:18:25 +0100, Måns Rullgård m...@mansr.com wrote: Anton Khirnov an...@khirnov.net writes: On Fri, 04 May 2012 12:58:02 +0100, Måns Rullgård m...@mansr.com wrote: Anton Khirnov an...@khirnov.net writes: Based on a commit by Stefano Sabatini

[libav-devel] VideoLAN Dev Days 2012

2012-05-04 Thread Jean-Baptiste Kempf
Hello fellow-geeks and friends, Like last year, I plan to organize a small technical conference, at the end of the summer, in Paris, for us to gather, discuss and/or code. Like last year, this is a technical conference, not a blabla one. Like last year, all geeks of important projects on the

Re: [libav-devel] [PATCH] configure: add POWER[5-7] support

2012-05-04 Thread Sean McGovern
On Friday, May 4, 2012, Måns Rullgård m...@mansr.com wrote: Sean McGovern gsean...@gmail.com writes: Also merge POWER3 and POWER4 configuration together with the additions. --- configure |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/configure b/configure

Re: [libav-devel] [PATCH] configure: add POWER[5-7] support

2012-05-04 Thread Måns Rullgård
Sean McGovern gsean...@gmail.com writes: On Friday, May 4, 2012, Måns Rullgård m...@mansr.com wrote: Sean McGovern gsean...@gmail.com writes: Also merge POWER3 and POWER4 configuration together with the additions. --- configure |5 - 1 files changed, 4 insertions(+), 1

Re: [libav-devel] [vlc-devel] [dvblast-devel] VideoLAN Dev Days 2012

2012-05-04 Thread Rémi Denis-Courmont
On Fri, 4 May 2012 15:17:40 +0200, Jean-Paul Saman jpsa...@videolan.org wrote: Maybe invite some v4l2 kernel and pulseaudio devs? LinuxCon and LPC will follow the Linux Kernel Summit in San Diego and end on August 31st. That is the previous day... I understand the gesture, but that most probably

[libav-devel] NEON: performance comparison of fixed-point and float FFT

2012-05-04 Thread Orjan Friberg
Hi, Comparing the performance of fft-test and fft-fixed-test on a Cortex-A8 (with Neon support enabled) I only see a very small performance increase with the 16-bit fixed point version compared to the float version, regardless of the FFT size (64, 256, 4096). I didn't see any performance

Re: [libav-devel] NEON: performance comparison of fixed-point and float FFT

2012-05-04 Thread Måns Rullgård
Orjan Friberg o...@flatfrog.com writes: Hi, Comparing the performance of fft-test and fft-fixed-test on a Cortex-A8 (with Neon support enabled) I only see a very small performance increase with the 16-bit fixed point version compared to the float version, regardless of the FFT size (64,

Re: [libav-devel] NEON: performance comparison of fixed-point and float FFT

2012-05-04 Thread Orjan Friberg
On 05/04/2012 03:50 PM, Måns Rullgård wrote: The 16-bit FFT uses 32-bit intermediate values in many places, so it does not process twice as much per instruction. It also has to do a few shifts that the float version does not. It seems reasonable to me that these implementations are roughly the

Re: [libav-devel] VideoLAN Dev Days 2012

2012-05-04 Thread Diego Biurrun
On Fri, May 04, 2012 at 02:38:48PM +0200, Jean-Baptiste Kempf wrote: Hello fellow-geeks and friends, Like last year, I plan to organize a small technical conference, at the end of the summer, in Paris, for us to gather, discuss and/or code. Like last year, this is a technical conference,

[libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
From: Paul B Mahol one...@gmail.com Fixes crash in bug #1219. Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/zerocodec.c |4 1 file changed, 4 insertions(+) diff --git a/libavcodec/zerocodec.c b/libavcodec/zerocodec.c index 6c57e05..54a7e06 100644 ---

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Kostya Shishkov
On Fri, May 04, 2012 at 10:41:47AM -0400, Derek Buitenhuis wrote: From: Paul B Mahol one...@gmail.com Fixes crash in bug #1219. Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/zerocodec.c |4 1 file changed, 4 insertions(+) diff --git a/libavcodec/zerocodec.c

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
On 04/05/2012 10:44 AM, Kostya Shishkov wrote: nit: if (!prev) looks better to me in any case patch looks OK I agree, but I elected to leave the patch untouched. - Derek ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 04/05/2012 10:44 AM, Kostya Shishkov wrote: nit: if (!prev) looks better to me in any case patch looks OK I agree, but I elected to leave the patch untouched. Why? -- Måns Rullgård m...@mansr.com

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
On 04/05/2012 10:48 AM, Måns Rullgård wrote: I agree, but I elected to leave the patch untouched. Why? Modifying others'/existing patches for personal preferences is silly, in my opinion, is all. - Derek ___ libav-devel mailing list

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 04/05/2012 10:48 AM, Måns Rullgård wrote: I agree, but I elected to leave the patch untouched. Why? Modifying others'/existing patches for personal preferences is silly, in my opinion, is all. We have style rules which should be

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
On 04/05/2012 11:19 AM, Måns Rullgård wrote: We have style rules which should be adhered to, even if someone submits a patch in violation. There is no violation here. Such a case is not documented by our style rules. - Derek ___ libav-devel mailing

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 04/05/2012 11:19 AM, Måns Rullgård wrote: We have style rules which should be adhered to, even if someone submits a patch in violation. There is no violation here. Such a case is not documented by our style rules. You were asked to

[libav-devel] [PATCH] rtsp: Add content-type message header parsing

2012-05-04 Thread Jordi Ortiz
--- libavformat/rtsp.c |3 +++ libavformat/rtsp.h |5 + 2 files changed, 8 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 01fe350..a4a89bf 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -870,6 +870,9 @@ void ff_rtsp_parse_line(RTSPMessageHeader

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Kostya Shishkov
On Fri, May 04, 2012 at 04:29:21PM +0100, Måns Rullgård wrote: Derek Buitenhuis derek.buitenh...@gmail.com writes: On 04/05/2012 11:19 AM, Måns Rullgård wrote: We have style rules which should be adhered to, even if someone submits a patch in violation. There is no violation here.

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
On 04/05/2012 11:59 AM, Kostya Shishkov wrote: There is no violation here. Such a case is not documented by our style rules. There's nothing bad with making patch slightly more beautiful even if it's not yours. So, Derek, next time think of better reasons why the patch should be left as

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Diego Biurrun
On Fri, May 04, 2012 at 10:41:47AM -0400, Derek Buitenhuis wrote: Fixes crash in bug #1219. No such bug number. Please take care of such things when porting patches. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
I realized that as soon as I sent it. It's been fixed locally. - Derek On 04/05/2012 12:21 PM, Diego Biurrun wrote: No such bug number. Please take care of such things when porting patches. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] zerocodec: check if there is previous frame

2012-05-04 Thread Diego Biurrun
On Fri, May 04, 2012 at 11:21:45AM -0400, Derek Buitenhuis wrote: On 04/05/2012 11:19 AM, Måns Rullgård wrote: We have style rules which should be adhered to, even if someone submits a patch in violation. There is no violation here. Such a case is not documented by our style rules. We do

Re: [libav-devel] [PATCH] rtsp: Add content-type message header parsing

2012-05-04 Thread Luca Barbato
On 04/05/12 08:50, Jordi Ortiz wrote: --- libavformat/rtsp.c |3 +++ libavformat/rtsp.h |5 + 2 files changed, 8 insertions(+) Looks fine. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing

[libav-devel] [PATCH 1/2] tests: Mark some file-internal symbols as static.

2012-05-04 Thread Diego Biurrun
--- tests/rotozoom.c | 14 +++--- tests/videogen.c |8 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/rotozoom.c b/tests/rotozoom.c index 9ce45cd..9bba6e3 100644 --- a/tests/rotozoom.c +++ b/tests/rotozoom.c @@ -160,8 +160,8 @@ static void

[libav-devel] [PATCH 2/2] tests: Refactor rotozoom/videogen common code into a separate file.

2012-05-04 Thread Diego Biurrun
--- tests/rotozoom.c | 126 +-- tests/utils.c| 144 ++ tests/videogen.c | 129 + 3 files changed, 147 insertions(+), 252 deletions(-) create mode

Re: [libav-devel] [PATCH] test programs: don't ignore the return value of fwrite()

2012-05-04 Thread Diego Biurrun
On Thu, May 03, 2012 at 11:32:24PM -0400, Sean McGovern wrote: On 4/26/12, Sean McGovern gsean...@gmail.com wrote: --- tests/rotozoom.c | 15 --- tests/videogen.c | 15 --- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/tests/rotozoom.c

[libav-devel] [PATCH v2] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/zerocodec.c |4 1 file changed, 4 insertions(+) diff --git a/libavcodec/zerocodec.c b/libavcodec/zerocodec.c index 6c57e05..7a0ba34 100644 --- a/libavcodec/zerocodec.c +++

Re: [libav-devel] [PATCH 3/3] aacps: NEON optimisations

2012-05-04 Thread Luca Barbato
On 04/05/12 05:15, Måns Rullgård wrote: Måns Rullgård m...@mansr.com writes: Mans Rullgard m...@mansr.com writes: Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/aacpsdsp.c |3 + libavcodec/aacpsdsp.h |1 + libavcodec/arm/Makefile

Re: [libav-devel] [PATCH 1/2] tests: Mark some file-internal symbols as static.

2012-05-04 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- tests/rotozoom.c | 14 +++--- tests/videogen.c |8 2 files changed, 11 insertions(+), 11 deletions(-) LGTM, not that it matters much for internal-only tools like these. -- Måns Rullgård m...@mansr.com

Re: [libav-devel] [PATCH v2] zerocodec: check if there is previous frame

2012-05-04 Thread Kostya Shishkov
On Fri, May 04, 2012 at 12:32:43PM -0400, Derek Buitenhuis wrote: From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/zerocodec.c |4 1 file changed, 4 insertions(+) diff --git a/libavcodec/zerocodec.c b/libavcodec/zerocodec.c index

Re: [libav-devel] [PATCH 2/2] tests: Refactor rotozoom/videogen common code into a separate file.

2012-05-04 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- tests/rotozoom.c | 126 +-- tests/utils.c| 144 ++ tests/videogen.c | 129 + 3 files changed,

Re: [libav-devel] [PATCH v2] zerocodec: check if there is previous frame

2012-05-04 Thread Diego Biurrun
On Fri, May 04, 2012 at 12:32:43PM -0400, Derek Buitenhuis wrote: From: Paul B Mahol one...@gmail.com .. if there is _a_ previous .. --- a/libavcodec/zerocodec.c +++ b/libavcodec/zerocodec.c @@ -65,6 +65,10 @@ static int zerocodec_decode_frame(AVCodecContext *avctx, void *data,

Re: [libav-devel] [PATCH v2] zerocodec: check if there is previous frame

2012-05-04 Thread Derek Buitenhuis
On 04/05/2012 12:48 PM, Diego Biurrun wrote: I admittedly don't know the surrounding code, but the error message does not make much sense to me. Why is the lack of a previous frame an error condition? And when does this happen except on the first frame? ZeroCodec relies on the keyframe flag

Re: [libav-devel] [PATCH v2] zerocodec: check if there is previous frame

2012-05-04 Thread Mashiat Sarker Shakkhar
On 5/4/2012 10:54 PM, Derek Buitenhuis wrote: On 04/05/2012 12:48 PM, Diego Biurrun wrote: I admittedly don't know the surrounding code, but the error message does not make much sense to me. Why is the lack of a previous frame an error condition? And when does this happen except on the first

Re: [libav-devel] [PATCH] test programs: don't ignore the return value of fwrite()

2012-05-04 Thread Sean McGovern
On Friday, May 4, 2012, Diego Biurrun di...@biurrun.de wrote: On Thu, May 03, 2012 at 11:32:24PM -0400, Sean McGovern wrote: On 4/26/12, Sean McGovern gsean...@gmail.com wrote: --- tests/rotozoom.c | 15 --- tests/videogen.c | 15 --- 2 files changed, 24

[libav-devel] [PATCH] doc: clarify check for NULL pointer style

2012-05-04 Thread Luca Barbato
Our code should be terse and clear. --- doc/developer.texi |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index de64239..5b5e29f 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -73,6 +73,10 @@ const char

[libav-devel] [PATCH] celp filters: Do not read earlier than the start of the 'out' vector.

2012-05-04 Thread Alex Converse
--- libavcodec/celp_filters.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/libavcodec/celp_filters.c b/libavcodec/celp_filters.c index 25a6744..849cda4 100644 --- a/libavcodec/celp_filters.c +++ b/libavcodec/celp_filters.c @@ -133,9 +133,8 @@ void

Re: [libav-devel] [PATCH] doc: clarify check for NULL pointer style

2012-05-04 Thread Derek Buitenhuis
On 04/05/2012 1:04 PM, Luca Barbato wrote: +@samp{if (!p)} is correct; @samp{if (p == NULL)} and @samp{if (p != NULL)} s/is/are/ +not. Missing an 'are' in front? ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] celp filters: Do not read earlier than the start of the 'out' vector.

2012-05-04 Thread Luca Barbato
On 04/05/12 10:29, Alex Converse wrote: --- Seems fine lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] zerocodec: check if the previous frame is missing

2012-05-04 Thread Luca Barbato
From: Paul B Mahol one...@gmail.com ZeroCodec relies on the keyframe flag being set in the container, and prev is the previously decoded frame. A keyframe flags incorrectly set will lead to this condition. Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Luca Barbato

Re: [libav-devel] [PATCH] celp filters: Do not read earlier than the start of the 'out' vector.

2012-05-04 Thread Måns Rullgård
Alex Converse alex.conve...@gmail.com writes: --- libavcodec/celp_filters.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/libavcodec/celp_filters.c b/libavcodec/celp_filters.c index 25a6744..849cda4 100644 --- a/libavcodec/celp_filters.c +++

Re: [libav-devel] [PATCH] doc: clarify check for NULL pointer style

2012-05-04 Thread Luca Barbato
On 04/05/12 10:32, Derek Buitenhuis wrote: On 04/05/2012 1:04 PM, Luca Barbato wrote: +@samp{if (!p)} is correct; @samp{if (p == NULL)} and @samp{if (p != NULL)} s/is/are/ +not. Missing an 'are' in front? Willing to amend it? lu - still sleepy today apparently... -- Luca Barbato

Re: [libav-devel] [PATCH] avprobe: allow showing only one container/stream property.

2012-05-04 Thread Alex Converse
On Thu, May 3, 2012 at 10:38 PM, Anton Khirnov an...@khirnov.net wrote: From: Ronald S. Bultje rsbul...@gmail.com This is useful for writing unit tests. Signed-off-by: Anton Khirnov an...@khirnov.net ---  avprobe.c        |   68 ++  

Re: [libav-devel] [PATCH] configure: add POWER[5-7] support

2012-05-04 Thread Sean McGovern
On Friday, May 4, 2012, Måns Rullgård m...@mansr.com wrote: Sean McGovern gsean...@gmail.com writes: On Friday, May 4, 2012, Måns Rullgård m...@mansr.com wrote: Sean McGovern gsean...@gmail.com writes: Also merge POWER3 and POWER4 configuration together with the additions. --- Hi Michael

Re: [libav-devel] [libav-commits] rv34: set mb_num_left to 0 after finishing a frame

2012-05-04 Thread Reinhard Tartler
On Mon, Apr 30, 2012 at 1:22 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi Reinhard, On Sun, Apr 29, 2012 at 12:00 PM, Reinhard Tartler siret...@gmail.com wrote: Hi Ronald, unfortunately, this patch does not apply cleanly to the 0.8 branch. In order to have it for 0.8.2, I'd therefore

[libav-devel] [PATCH 1/2] rtpdec_h264: Add input size checks

2012-05-04 Thread Martin Storsjö
From: Ivan Kovtunov belev...@gmail.com This fixes crashes if given too short data packets. --- libavformat/rtpdec_h264.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 32a57d3..9a8f12c 100644 ---

[libav-devel] [PATCH 2/2] rtpdec_h264: Check the available data length before reading

2012-05-04 Thread Martin Storsjö
This makes sure the length is checked for STAP-A type packets. --- libavformat/rtpdec_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 9a8f12c..2f17768 100644 --- a/libavformat/rtpdec_h264.c +++

Re: [libav-devel] [PATCH 1/2] rtpdec_h264: Add input size checks

2012-05-04 Thread Luca Barbato
Martin Storsjö mar...@martin.st wrote: From: Ivan Kovtunov belev...@gmail.com This fixes crashes if given too short data packets. --- libavformat/rtpdec_h264.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_h264.c

[libav-devel] [PATCH 1/2] rtpdec_h264: Add input size checks

2012-05-04 Thread Martin Storsjö
From: Ivan Kovtunov belev...@gmail.com This fixes crashes if given too short data packets. --- libavformat/rtpdec_h264.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 32a57d3..51447f9 100644 ---

Re: [libav-devel] [libav-commits] aacsbr: Add a debug check to sbr_mapping.

2012-05-04 Thread Alex Converse
On Sun, Apr 29, 2012 at 11:58 AM, Reinhard Tartler siret...@gmail.com wrote: Hi Alex, unfortunately, this patch does not apply cleanly to the 0.8 branch. In order to have it for 0.8.2, I'd therefore require your assistance with this backport. This isn't applying cleanly because the reset

Re: [libav-devel] [PATCH 1/2] rtpdec_h264: Add input size checks

2012-05-04 Thread Luca Barbato
On 04/05/12 13:40, Martin Storsjö wrote: From: Ivan Kovtunov belev...@gmail.com This fixes crashes if given too short data packets. --- Looks fine. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list

[libav-devel] [PATCH 01/11] rtpdec_h264: Return proper error codes

2012-05-04 Thread Martin Storsjö
--- libavformat/rtpdec_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 8b56ada..f3793f5 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -272,7 +272,7 @@ static int

[libav-devel] [PATCH 02/11] rtpdec_h264: Remove useless memory corruption checks

2012-05-04 Thread Martin Storsjö
--- libavformat/rtpdec_h264.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index f3793f5..eb20397 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -53,8 +53,6 @@

[libav-devel] [PATCH 03/11] rtpdec_h264: Remove outdated/useless/incorrect comments

2012-05-04 Thread Martin Storsjö
RTCP is handled elsewhere, not in the depacketizer for an individual format. --- libavformat/rtpdec_h264.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index eb20397..d98be07 100644 ---

[libav-devel] [PATCH 04/11] rtpdec_h264: Remove a useless ifdef

2012-05-04 Thread Martin Storsjö
assert is a no-op if DEBUG isn't defined. --- libavformat/rtpdec_h264.c |2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index d98be07..399ca47 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -170,9 +170,7 @@

[libav-devel] [PATCH 05/11] rtpdec_h264: Convert commented out code into setting an unused variable

2012-05-04 Thread Martin Storsjö
It is worth keeping instead of removing, in case reading this bit becomes necessary at some later point. --- libavformat/rtpdec_h264.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 399ca47..505bc81 100644 ---

[libav-devel] [PATCH 06/11] rtpdec_h264: Clean up comments

2012-05-04 Thread Martin Storsjö
Convert C++ comments into C comments, clean up the comment content (remove trailing periods). --- libavformat/rtpdec_h264.c | 87 - 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c

[libav-devel] [PATCH 07/11] rtpdec_h264: Cosmetic cleanup

2012-05-04 Thread Martin Storsjö
Add/fix spacing, split long lines, align assignments where suitable. --- libavformat/rtpdec_h264.c | 105 ++--- 1 file changed, 52 insertions(+), 53 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index a567d3d..8ce5516

[libav-devel] [PATCH 08/11] rtpdec_h264: Cleanup debug packet type counting

2012-05-04 Thread Martin Storsjö
--- libavformat/rtpdec_h264.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 8ce5516..5abab79 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -57,6 +57,12 @@ struct

[libav-devel] [PATCH 09/11] rtpdec_h264: Make start_sequence a static const array

2012-05-04 Thread Martin Storsjö
--- libavformat/rtpdec_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 5abab79..1021d02 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -63,6 +63,8 @@ struct PayloadContext {

[libav-devel] [PATCH 10/11] rtpdec_h264: Replace sizeof(start_sequence) with a macro

2012-05-04 Thread Martin Storsjö
This makes the code slightly more readable at places where this is used a lot, although I guess this is very subjective. --- libavformat/rtpdec_h264.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/libavformat/rtpdec_h264.c

[libav-devel] [PATCH 11/11] rtpdec_h264: Reorder code blocks

2012-05-04 Thread Martin Storsjö
This removes one level of indentation. --- libavformat/rtpdec_h264.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 5ff03ee..f2dd06c 100644 --- a/libavformat/rtpdec_h264.c +++

Re: [libav-devel] [PATCH 06/11] rtpdec_h264: Clean up comments

2012-05-04 Thread Alex Converse
On Fri, May 4, 2012 at 3:06 PM, Martin Storsjö mar...@martin.st wrote: Convert C++ comments into C comments, clean up the comment content (remove trailing periods). Whats wrong with c99 comments? ---  libavformat/rtpdec_h264.c |   87 -  1 file

Re: [libav-devel] [PATCH 06/11] rtpdec_h264: Clean up comments

2012-05-04 Thread Martin Storsjö
On Fri, 4 May 2012, Alex Converse wrote: On Fri, May 4, 2012 at 3:06 PM, Martin Storsjö mar...@martin.st wrote: Convert C++ comments into C comments, clean up the comment content (remove trailing periods). Whats wrong with c99 comments? Hmm, I thought some of our coding style guidelines

Re: [libav-devel] [PATCH] qdm2: clip array indices returned by qdm2_get_vlc().

2012-05-04 Thread Ronald S. Bultje
Hi, On Wed, May 2, 2012 at 10:12 AM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com Prevents subsequent overreads when these numbers are used as indices in arrays. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org ---  

Re: [libav-devel] [PATCH 01/11] rtpdec_h264: Return proper error codes

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: --- libavformat/rtpdec_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Ok -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list

Re: [libav-devel] [PATCH 02/11] rtpdec_h264: Remove useless memory corruption checks

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: --- libavformat/rtpdec_h264.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing

Re: [libav-devel] [PATCH 03/11] rtpdec_h264: Remove outdated/useless/incorrect comments

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: RTCP is handled elsewhere, not in the depacketizer for an individual format. --- libavformat/rtpdec_h264.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) Ok -- Luca Barbato Gentoo/linux

Re: [libav-devel] [PATCH 04/11] rtpdec_h264: Remove a useless ifdef

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: assert is a no-op if DEBUG isn't defined. --- libavformat/rtpdec_h264.c |2 -- 1 file changed, 2 deletions(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel

Re: [libav-devel] [PATCH 07/11] rtpdec_h264: Cosmetic cleanup

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: Add/fix spacing, split long lines, align assignments where suitable. --- libavformat/rtpdec_h264.c | 105 ++--- 1 file changed, 52 insertions(+), 53 deletions(-) Ok. -- Luca Barbato Gentoo/linux

Re: [libav-devel] [PATCH 08/11] rtpdec_h264: Cleanup debug packet type counting

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: --- libavformat/rtpdec_h264.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list

Re: [libav-devel] [PATCH 09/11] rtpdec_h264: Make start_sequence a static const array

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: --- libavformat/rtpdec_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list

Re: [libav-devel] [PATCH 10/11] rtpdec_h264: Replace sizeof(start_sequence) with a macro

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: This makes the code slightly more readable at places where this is used a lot, although I guess this is very subjective. fine for me. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___

Re: [libav-devel] [PATCH 11/11] rtpdec_h264: Reorder code blocks

2012-05-04 Thread Luca Barbato
On 04/05/12 15:06, Martin Storsjö wrote: This removes one level of indentation. --- libavformat/rtpdec_h264.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

Re: [libav-devel] [PATCH 2/2] rtpdec_h264: Check the available data length before reading

2012-05-04 Thread Luca Barbato
On 04/05/12 12:48, Martin Storsjö wrote: This makes sure the length is checked for STAP-A type packets. --- libavformat/rtpdec_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Ok. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero

Re: [libav-devel] [PATCH 2/2] rtpdec_h264: Check the available data length before reading

2012-05-04 Thread Martin Storsjö
On Fri, 4 May 2012, Luca Barbato wrote: On 04/05/12 12:48, Martin Storsjö wrote: This makes sure the length is checked for STAP-A type packets. --- libavformat/rtpdec_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Ok. Thanks, pushed these two crash fixes. //

Re: [libav-devel] [PATCH 04/11] rtpdec_h264: Remove a useless ifdef

2012-05-04 Thread Martin Storsjö
On Fri, 4 May 2012, Luca Barbato wrote: On 04/05/12 15:06, Martin Storsjö wrote: assert is a no-op if DEBUG isn't defined. --- libavformat/rtpdec_h264.c |2 -- 1 file changed, 2 deletions(-) Ok. Pushed the cleanup patches up to this one, I'll do another version of the comment