[libav-devel] [PATCH 2/3] mpegts: Drop pointless casting of hex_dump_debug arguments

2012-10-01 Thread Diego Biurrun
--- libavformat/mpegts.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 2d9b8a8..4aabcd7 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -1381,7 +1381,7 @@ static void pmt_cb(MpegTSFilter *filter,

[libav-devel] [PATCH 1/3] wmadec: Adjust debug printf argument length modifier

2012-10-01 Thread Diego Biurrun
--- libavcodec/wmadec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c index 1f9ab61..79401e2 100644 --- a/libavcodec/wmadec.c +++ b/libavcodec/wmadec.c @@ -913,7 +913,7 @@ static int wma_decode_superframe(AVCodecContext *avctx,

[libav-devel] [PATCH 3/3] avformat: const correctness for av_hex_dump / av_hex_dump_log

2012-10-01 Thread Diego Biurrun
--- libavformat/avformat.h |4 ++-- libavformat/utils.c|7 --- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 134a38b..f9f39a6 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1539,7 +1539,7

Re: [libav-devel] [PATCH] avutil: add yuva422p and yuva444p formats

2012-10-01 Thread Luca Barbato
On 10/01/2012 04:36 AM, Ronald S. Bultje wrote: I remember trying this before, and somehow alpha in swscale was dependent on the colorspace being 420. Is that removed now? I.e. does this result in uninitialized reads when running make fate-lavfi under valgrind? Tested with valgrind and no

Re: [libav-devel] [PATCH 1/3] wmadec: Adjust debug printf argument length modifier

2012-10-01 Thread Luca Barbato
All 3 patches look fine. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] Opus encoder using libopus

2012-10-01 Thread Diego Biurrun
On Fri, Sep 28, 2012 at 11:16:09PM -0600, Nathan Caldwell wrote: Signed-off-by: Diego Biurrun di...@biurrun.de --- Add libopus configure dependency, add libavutil/common.h to libopus.c Changelog |2 +- configure |1 + doc/general.texi|2 +-

Re: [libav-devel] [PATCH] Opus encoder using libopus

2012-10-01 Thread Luca Barbato
On 10/01/2012 01:06 PM, Diego Biurrun wrote: Queued, will push in a few. \o/ lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] Opus encoder using libopus

2012-10-01 Thread Kostya Shishkov
On Mon, Oct 01, 2012 at 01:33:49PM +0200, Luca Barbato wrote: On 10/01/2012 01:06 PM, Diego Biurrun wrote: Queued, will push in a few. \o/ And I thought it meant in a few aeons. ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] avutil: add yuva444p10 pixel format

2012-10-01 Thread Luca Barbato
From: Paul B Mahol one...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavutil/pixdesc.c | 26 ++ libavutil/pixfmt.h| 3 ++- libswscale/utils.c| 2 ++ tests/ref/lavfi/pixdesc | 2 ++ tests/ref/lavfi/pixfmts_copy

Re: [libav-devel] FFv1.3 support

2012-10-01 Thread Peter B.
Quoting Luca Barbato lu_z...@gentoo.org: On 10/01/2012 12:07 AM, Ronald S. Bultje wrote: Hi, On Sun, Sep 30, 2012 at 1:00 PM, Peter B. p...@das-werkstatt.com wrote: +PIX_FMT_0RGB=0x123+4, /// packed RGB 8:8:8, 32bpp, 0RGB0RGB... +PIX_FMT_RGB0, /// packed RGB 8:8:8, 32bpp,

Re: [libav-devel] FFv1.3 support

2012-10-01 Thread Diego Biurrun
On Mon, Oct 01, 2012 at 03:55:31PM +0200, Peter B. wrote: Which would be the preferred way for patches in the future on this list? git send-email Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] avutil: add yuva444p10 pixel format

2012-10-01 Thread Ronald S. Bultje
Hi, On Mon, Oct 1, 2012 at 5:03 AM, Luca Barbato lu_z...@gentoo.org wrote: From: Paul B Mahol one...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavutil/pixdesc.c | 26 ++ libavutil/pixfmt.h| 3 ++- libswscale/utils.c

Re: [libav-devel] FFv1.3 support

2012-10-01 Thread Luca Barbato
On 10/01/2012 03:55 PM, Peter B. wrote: I've removed unused pix_fmts from my patch (0-padded RGB, for example) and added entries in pixdesc.c. It compiles correctly, so I assume there's no syntax error at least. Thanks, you are missing few bits in swscale, though. I also took the liberty to

Re: [libav-devel] [PATCH] avutil: add yuva444p10 pixel format

2012-10-01 Thread Luca Barbato
On 10/01/2012 05:23 PM, Ronald S. Bultje wrote: Hi, Why not add support for yuva{420,422}p10{be,le} also? And while at it, Why not add yuva{420,422,444}p9{be.le} at the same time? I started with 2 pixel formats I spotted in the question regarding ffv1.3 that I deemed interesting, nothing

Re: [libav-devel] FFv1.3 support

2012-10-01 Thread Peter B.
Quoting Luca Barbato lu_z...@gentoo.org: On 10/01/2012 03:55 PM, Peter B. wrote: I've removed unused pix_fmts from my patch (0-padded RGB, for example) and added entries in pixdesc.c. It compiles correctly, so I assume there's no syntax error at least. Thanks, you are missing few bits in

Re: [libav-devel] FFv1.3 support

2012-10-01 Thread Luca Barbato
On 10/01/2012 05:57 PM, Peter B. wrote: That would be great! Thank you very much! No problem, I hope to get the first ones working so you can copy over if the need arises. With FFv1.3 it's not only about additional colorspaces, but the main features of the new version include multithreading

Re: [libav-devel] FFv1.3 support

2012-10-01 Thread Peter B.
Quoting Luca Barbato lu_z...@gentoo.org: Those are more interesting to me, I prefer adding colorspaces only if the need arises. Understood :) The main question regarding rgb with more than 10 and less than 16 is where it is used. This was added due to a request from the national

[libav-devel] [PATCH 08/11] mpegaudioenc: use planar sample format

2012-10-01 Thread Justin Ruggles
--- Changed lavf-ffm FATE reference due to the change in sample_fmt, which is written in the ffm header. libavcodec/mpegaudioenc.c | 10 -- tests/ref/lavf/ffm|2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegaudioenc.c

Re: [libav-devel] FFv1.3 support

2012-10-01 Thread Luca Barbato
On 10/01/2012 06:22 PM, Peter B. wrote: Honestly, I'm not 100% sure about that, because that was coordinated directly between someone from the filmarchive and Georg Lippitsch who implemented the changes. He also modified DPX code as far as I know. I only saw 12 and 14 bits - no 13 so far...

[libav-devel] [PATCH] nut: KR formatting cosmetics

2012-10-01 Thread Luca Barbato
--- libavformat/nutdec.c | 21 +- libavformat/nutenc.c | 730 +++ 2 files changed, 401 insertions(+), 350 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 2d2c743..33aec77 100644 --- a/libavformat/nutdec.c +++

Re: [libav-devel] [PATCH 08/11] mpegaudioenc: use planar sample format

2012-10-01 Thread Ronald S. Bultje
Hi, On Tue, Sep 11, 2012 at 2:40 AM, Benjamin Larsson benja...@southpole.se wrote: On 09/11/2012 06:32 AM, Ronald S. Bultje wrote: Hi, On Sat, Aug 25, 2012 at 8:01 PM, Justin Ruggles justin.rugg...@gmail.com wrote: --- libavcodec/mpegaudioenc.c | 10 -- 1 files changed, 4

[libav-devel] [PATCH] msvc: Fix detection of VFW Avisynth required libs

2012-10-01 Thread Derek Buitenhuis
It should be vfw32.lib with MSVC. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- I know this can possibly lead to a double vfw32.lib, but I think it is harmless. Opinions welcome. --- configure |2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index

Re: [libav-devel] [PATCH] msvc: Fix detection of VFW Avisynth required libs

2012-10-01 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: It should be vfw32.lib with MSVC. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- I know this can possibly lead to a double vfw32.lib, but I think it is harmless. Opinions welcome. --- configure |2 ++ 1 file

Re: [libav-devel] [PATCH] msvc: Fix detection of VFW Avisynth required libs

2012-10-01 Thread Derek Buitenhuis
On 01/10/2012 3:47 PM, Måns Rullgård wrote: The mapping looks strange to me. Can you explain what's going on? The DLLs themselves are called avicap32.dll and avifil32.dll, and thats how MinGW creates its import libs. MSVC only has one lib for both: vfw32.lib (some of whose functions seem to

[libav-devel] [PATCH] libspeex: Add a private option for enabling VAD

2012-10-01 Thread Martin Storsjö
From: Dmitry Samonenko shreddingw...@gmail.com Speex detects non-speech periods and encodes them with just enough bits to reproduce the background noise, aka ``comfort noise generation''. --- libavcodec/libspeexenc.c |8 1 file changed, 8 insertions(+) diff --git

Re: [libav-devel] [PATCH] msvc: Fix detection of VFW Avisynth required libs

2012-10-01 Thread Måns Rullgård
Derek Buitenhuis derek.buitenh...@gmail.com writes: On 01/10/2012 3:47 PM, Måns Rullgård wrote: The mapping looks strange to me. Can you explain what's going on? The DLLs themselves are called avicap32.dll and avifil32.dll, and thats how MinGW creates its import libs. MSVC only has one lib

Re: [libav-devel] [PATCH] libspeex: Add a private option for enabling VAD

2012-10-01 Thread Diego Elio Pettenò
On 01/10/2012 13:02, Martin Storsjö wrote: +/* VAD is activated with VBR or can be turned on by itself */ +if (s-vad) + speex_encoder_ctl(s-enc_state, SPEEX_SET_VAD, s-vad); + If you always called this, with s-vad == 0, would it matter? -- Diego Elio Pettenò — Flameeyes

Re: [libav-devel] [PATCH] libspeex: Add a private option for enabling VAD

2012-10-01 Thread Martin Storsjö
On Mon, 1 Oct 2012, Diego Elio Pettenò wrote: On 01/10/2012 13:02, Martin Storsjö wrote: +/* VAD is activated with VBR or can be turned on by itself */ +if (s-vad) + speex_encoder_ctl(s-enc_state, SPEEX_SET_VAD, s-vad); + If you always called this, with s-vad == 0, would it

[libav-devel] [PATCH 1/4] xtea: Factorize the test code

2012-10-01 Thread Martin Storsjö
From: Michael Niedermayer michae...@gmx.at --- libavutil/xtea.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavutil/xtea.c b/libavutil/xtea.c index 7c3a14c..bf5db11 100644 --- a/libavutil/xtea.c +++ b/libavutil/xtea.c @@ -145,20 +145,19 @@ int

[libav-devel] [PATCH 2/4] xtea: Fix CBC mode when src=dst

2012-10-01 Thread Martin Storsjö
From: Giorgio Vazzana mywin...@gmail.com In CBC mode, when src=dst and we are decrypting a block different from the first one, we need to save the current block of ciphertext (which will constitute the initialization vector for the next block) before we overwrite it. --- libavutil/xtea.c |9

[libav-devel] [PATCH 3/4] xtea: Test inplace decryption

2012-10-01 Thread Martin Storsjö
From: Michael Niedermayer michae...@gmx.at Based on test code by: Giorgio Vazzana mywin...@gmail.com --- libavutil/xtea.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavutil/xtea.c b/libavutil/xtea.c index 41aed2b..bb1bf9e 100644 --- a/libavutil/xtea.c

[libav-devel] [PATCH 4/4] xtea: Move iv decrypt handling code into xtea_crypt_ecb()

2012-10-01 Thread Martin Storsjö
From: Michael Niedermayer michae...@gmx.at This simplifies things and avoids a temporary. --- libavutil/xtea.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavutil/xtea.c b/libavutil/xtea.c index bb1bf9e..988f1fb 100644 ---

Re: [libav-devel] [PATCH 1/4] xtea: Factorize the test code

2012-10-01 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: From: Michael Niedermayer michae...@gmx.at --- libavutil/xtea.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavutil/xtea.c b/libavutil/xtea.c index 7c3a14c..bf5db11 100644 --- a/libavutil/xtea.c +++

Re: [libav-devel] [PATCH 4/4] xtea: Move iv decrypt handling code into xtea_crypt_ecb()

2012-10-01 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: From: Michael Niedermayer michae...@gmx.at This simplifies things and avoids a temporary. --- libavutil/xtea.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavutil/xtea.c b/libavutil/xtea.c

[libav-devel] [PATCH 1/5] blowfish: Factorize testing into a separate function

2012-10-01 Thread Martin Storsjö
--- libavutil/blowfish.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavutil/blowfish.c b/libavutil/blowfish.c index 5df3dfc..5a0bc10 100644 --- a/libavutil/blowfish.c +++ b/libavutil/blowfish.c @@ -522,6 +522,18 @@ static const uint8_t

[libav-devel] [PATCH 2/5] blowfish: Test inplace ECB encryption/decryption

2012-10-01 Thread Martin Storsjö
--- libavutil/blowfish.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/blowfish.c b/libavutil/blowfish.c index 5a0bc10..f4ef953 100644 --- a/libavutil/blowfish.c +++ b/libavutil/blowfish.c @@ -546,6 +546,8 @@ int main(void) test_blowfish(ctx, tmp, plaintext,

[libav-devel] [PATCH 4/5] blowfish: Fix CBC decryption with dst==src

2012-10-01 Thread Martin Storsjö
--- libavutil/blowfish.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavutil/blowfish.c b/libavutil/blowfish.c index aeac644..7a571a8 100644 --- a/libavutil/blowfish.c +++ b/libavutil/blowfish.c @@ -388,15 +388,15 @@ void av_blowfish_crypt(AVBlowfish *ctx,

Re: [libav-devel] [PATCH 1/5] blowfish: Factorize testing into a separate function

2012-10-01 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: --- libavutil/blowfish.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavutil/blowfish.c b/libavutil/blowfish.c index 5df3dfc..5a0bc10 100644 --- a/libavutil/blowfish.c +++

[libav-devel] [PATCH] ARM: fix Thumb PIC on Apple

2012-10-01 Thread Mans Rullgard
LDR with register offset and PC as base register is not available in the Thumb instruction set so the addition must be done separately. Signed-off-by: Mans Rullgard m...@mansr.com --- libavutil/arm/asm.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/arm/asm.S

Re: [libav-devel] [PATCH 1/5] blowfish: Factorize testing into a separate function

2012-10-01 Thread Luca Barbato
On 10/01/2012 11:20 PM, Martin Storsjö wrote: --- libavutil/blowfish.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) ok ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 2/5] blowfish: Test inplace ECB encryption/decryption

2012-10-01 Thread Luca Barbato
On 10/01/2012 11:20 PM, Martin Storsjö wrote: --- libavutil/blowfish.c |2 ++ 1 file changed, 2 insertions(+) ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] nut: KR formatting cosmetics

2012-10-01 Thread Luca Barbato
On 10/01/2012 08:16 PM, Luca Barbato wrote: --- libavformat/nutdec.c | 21 +- libavformat/nutenc.c | 730 +++ 2 files changed, 401 insertions(+), 350 deletions(-) Wait for a saner one, uncrustify has problems with macros without ending ;

[libav-devel] [PATCH] nut: add do {} while (0) to GET_V

2012-10-01 Thread Luca Barbato
Make it consistent with the other function-like macros. --- libavformat/nutdec.c | 54 +++- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 2d2c743..6626734 100644 ---

Re: [libav-devel] [PATCH] ARM: fix Thumb PIC on Apple

2012-10-01 Thread Martin Storsjö
On Tue, 2 Oct 2012, Mans Rullgard wrote: LDR with register offset and PC as base register is not available in the Thumb instruction set so the addition must be done separately. Signed-off-by: Mans Rullgard m...@mansr.com --- libavutil/arm/asm.S | 4 +++- 1 file changed, 3 insertions(+), 1

[libav-devel] [PATCH 1/5] blowfish: Factorize testing into a separate function

2012-10-01 Thread Martin Storsjö
--- libavutil/blowfish.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/libavutil/blowfish.c b/libavutil/blowfish.c index 5df3dfc..35c546a 100644 --- a/libavutil/blowfish.c +++ b/libavutil/blowfish.c @@ -522,6 +522,25 @@ static const

Re: [libav-devel] [PATCH 5/5] blowfish: Test inplace CBC decryption/encryption

2012-10-01 Thread Martin Storsjö
On Tue, 2 Oct 2012, Martin Storsjö wrote: --- libavutil/blowfish.c |4 1 file changed, 4 insertions(+) diff --git a/libavutil/blowfish.c b/libavutil/blowfish.c index 7a571a8..1258e09 100644 --- a/libavutil/blowfish.c +++ b/libavutil/blowfish.c @@ -561,6 +561,10 @@ int main(void)