[libav-devel] [PATCH] file: Set the return value type for lseek to int64_t.

Attached patch fixes seeking to file offset exceeding 2G when int is defined as 32bit signed integer. This patch is similar with https://github.com/FFmpeg/FFmpeg/commit/d37044647f83f53a1cb711ea4655b944ff4af0e5but ffmpeg's one doesn't work on MinGW (not MinGW-w64) since MinGW ignores

Re: [libav-devel] [PATCH 2/2] Employ proper return values in case of missing features

On Tue, 9 Oct 2012, Diego Biurrun wrote: --- Some cases I'm not sure about: * libavformat/rtpdec_qt.c: replacing ENOSYS is hopefully OK This one is ok with me. // Martin ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] file: Set the return value type for lseek to int64_t.

On Tue, 9 Oct 2012, Yusuke Nakamura wrote: Attached patch fixes seeking to file offset exceeding 2G when int is defined as 32bit signed integer. This patch is similar withhttps://github.com/FFmpeg/FFmpeg/commit/d37044647f83f53a1cb711ea4655b944ff4 af0e5 but ffmpeg's one doesn't work on MinGW

Re: [libav-devel] [PATCH] rtp: Support packetization/depacketization of opus

On Tue, 9 Oct 2012, Luca Barbato wrote: On 10/09/2012 12:06 AM, Martin Storsjö wrote: On Tue, 9 Oct 2012, Martin Storsjö wrote: --- libavformat/rtpdec.c |7 +++ libavformat/rtpenc.c | 15 +++ libavformat/sdp.c|4 3 files changed, 26 insertions(+) diff --git

Re: [libav-devel] [PATCH] rtp: Support packetization/depacketization of opus

On 10/09/2012 10:28 AM, Martin Storsjö wrote: On Tue, 9 Oct 2012, Luca Barbato wrote: On 10/09/2012 12:06 AM, Martin Storsjö wrote: On Tue, 9 Oct 2012, Martin Storsjö wrote: --- libavformat/rtpdec.c |7 +++ libavformat/rtpenc.c | 15 +++ libavformat/sdp.c|4

[libav-devel] [PATCH 1/4] url: Don't treat slashes in query parameters as directory separators

From: Duncan Salerno duncan.sale...@gmail.com Strip off query parameters from the original url before applying the new relative path. --- libavformat/utils.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index

[libav-devel] [PATCH 2/4] url: Handle relative urls being just a new query string

From: Duncan Salerno duncan.sale...@gmail.com --- libavformat/utils.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 1fd0ba3..9d0049a 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3417,6 +3417,12 @@ void

[libav-devel] [PATCH 3/4] url: Handle relative urls starting with two slashes

From: Duncan Salerno duncan.sale...@gmail.com This is defined by RFC 3986 section 5.4.1 to be handled this way. --- libavformat/utils.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 9d0049a..ca52469 100644

[libav-devel] [PATCH 4/4] fate: Add tests of the ff_make_absolute_url function

--- libavformat/Makefile |3 ++- libavformat/url-test.c | 58 tests/Makefile |2 ++ tests/fate/libavformat.mak |5 tests/ref/fate/url | 13 ++ 5 files changed, 80 insertions(+), 1 deletion(-)

Re: [libav-devel] [PATCH 1/4] url: Don't treat slashes in query parameters as directory separators

On 10/09/2012 10:52 AM, Martin Storsjö wrote: From: Duncan Salerno duncan.sale...@gmail.com Strip off query parameters from the original url before applying the new relative path. --- libavformat/utils.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Seems fine.

[libav-devel] [PATCH] Use proper return values in case of missing features

--- Dropped changing oggparseskeleton.c, which needed a positive return value after av_log_missing_feature. libavcodec/aac_adtstoasc_bsf.c |4 ++-- libavcodec/aacdec.c|8 libavcodec/ac3dec.c|2 +- libavcodec/alsdec.c|4 ++--

[libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

--- Changed to not use % patterns in the AC-3 tests. tests/fate/ac3.mak | 39 +-- tests/fate/amrnb.mak | 10 ++ tests/fate/amrwb.mak | 12 ++-- tests/fate/atrac.mak |6 ++ tests/fate/audio.mak |7 +++ tests/fate/real.mak

Re: [libav-devel] [PATCH] build: link test programs only against static libs

On Mon, 8 Oct 2012, Mans Rullgard wrote: The test programs use internal symbols so cannot be linked against the shared libs. Linking against both shared and static is pointless and might do something strange depending on the linker. This changes the dependencies so the test programs are

Re: [libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

Diego Biurrun di...@biurrun.de writes: +fate-ac3-encode fate-eac3-encode: CMP = stddev +fate-ac3-encode fate-eac3-encode: REF = $(SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav +fate-ac3-encode fate-eac3-encode: CMP_SHIFT = -1024 +fate-ac3-encode fate-eac3-encode: SIZE_TOLERANCE =

[libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

--- Changed to not refactor FUZZ settings. tests/fate/ac3.mak | 39 +-- tests/fate/amrnb.mak | 10 ++ tests/fate/amrwb.mak | 12 ++-- tests/fate/atrac.mak |6 ++ tests/fate/audio.mak |4 ++-- tests/fate/real.mak |6

Re: [libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

Diego Biurrun di...@biurrun.de writes: --- Changed to not refactor FUZZ settings. [...] +fate-ac3-encode fate-eac3-encode: CMP = stddev +fate-ac3-encode fate-eac3-encode: REF = $(SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav +fate-ac3-encode fate-eac3-encode: CMP_SHIFT = -1024

[libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

--- Second try to not group FUZZ settings together... tests/fate/ac3.mak | 36 tests/fate/amrnb.mak | 10 ++ tests/fate/amrwb.mak | 12 ++-- tests/fate/atrac.mak |6 ++ tests/fate/audio.mak |4 ++-- tests/fate/real.mak |

Re: [libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

Diego Biurrun di...@biurrun.de writes: --- Second try to not group FUZZ settings together... [...] -FATE_AC3 += fate-ac3-fixed-encode +fate-ac3-encode fate-eac3-encode: CMP = stddev +fate-ac3-encode fate-eac3-encode: REF = $(SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav

[libav-devel] [PATCH 1/2] avcodec: free extended_data instead address of it

Fixes CID732173. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index bd80d7b..48d6348 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -322,7 +322,7 @@ static int audio_get_buffer(AVCodecContext

[libav-devel] [PATCH 2/2] rtpdec_mpeg4: au_headers is a single array, simple av_free is enough

Fixes CID700204. --- libavformat/rtpdec_mpeg4.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c index d3e0754..cc92c88 100644 --- a/libavformat/rtpdec_mpeg4.c +++ b/libavformat/rtpdec_mpeg4.c @@ -93,15 +93,7 @@

Re: [libav-devel] [PATCH 1/2] avcodec: free extended_data instead address of it

On Tue, Oct 09, 2012 at 02:29:48PM +0200, Janne Grunau wrote: Fixes CID732173. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index bd80d7b..48d6348 100644 --- a/libavcodec/utils.c +++

Re: [libav-devel] [PATCH 2/2] rtpdec_mpeg4: au_headers is a single array, simple av_free is enough

On Tue, Oct 09, 2012 at 02:29:49PM +0200, Janne Grunau wrote: Fixes CID700204. --- libavformat/rtpdec_mpeg4.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c index d3e0754..cc92c88 100644 ---

Re: [libav-devel] [PATCH 2/2] rtpdec_mpeg4: au_headers is a single array, simple av_free is enough

On Tue, 9 Oct 2012, Janne Grunau wrote: Fixes CID700204. --- libavformat/rtpdec_mpeg4.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c index d3e0754..cc92c88 100644 --- a/libavformat/rtpdec_mpeg4.c +++

[libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

--- ... and now w/o grouping CMP_SHIFT, SIZE_TOLERANCE and other potentially test-specific variables. tests/fate/ac3.mak | 30 ++ tests/fate/amrnb.mak | 10 ++ tests/fate/amrwb.mak | 12 ++-- tests/fate/atrac.mak |6 ++

Re: [libav-devel] [PATCH] avutil: Duplicate ff_log2_tab instead of sharing it across libs

On Thu, 4 Oct 2012, Diego Biurrun wrote: The table is so small that the space gain is not worth the performance overhead of cross-library access. --- Now with each duplicated table in a separate file. libavcodec/Makefile |1 + libavcodec/log2_tab.c |1 + libavutil/Makefile |

Re: [libav-devel] [PATCH 18/31] vorbisdec: use float planar sample format

On Fri, Sep 21, 2012 at 11:23:46AM -0400, Justin Ruggles wrote: --- libavcodec/vorbisdec.c | 28 1 files changed, 8 insertions(+), 20 deletions(-) LGTM ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 16/31] shorten: use planar sample format

On Fri, Sep 21, 2012 at 11:23:44AM -0400, Justin Ruggles wrote: --- libavcodec/shorten.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff --git a/libavcodec/shorten.c b/libavcodec/shorten.c index fb48070..1664a90 100644 --- a/libavcodec/shorten.c +++

Re: [libav-devel] [PATCH 19/31] wmadec: use float planar sample format output

On Fri, Sep 21, 2012 at 11:23:47AM -0400, Justin Ruggles wrote: --- libavcodec/wmadec.c | 65 ++- 1 files changed, 28 insertions(+), 37 deletions(-) looks OK but please check that it compiles fine with -DTRACE

Re: [libav-devel] [PATCH] fate: Refactor setting of environment variables for groups of tests

Diego Biurrun di...@biurrun.de writes: --- ... and now w/o grouping CMP_SHIFT, SIZE_TOLERANCE and other potentially test-specific variables. tests/fate/ac3.mak | 30 ++ tests/fate/amrnb.mak | 10 ++ tests/fate/amrwb.mak | 12 ++--

Re: [libav-devel] [PATCH 20/31] wmalossless: output in planar sample format

On Fri, Sep 21, 2012 at 11:23:48AM -0400, Justin Ruggles wrote: --- libavcodec/wmalosslessdec.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 56e9aad..300c66a 100644 ---

Re: [libav-devel] [PATCH 21/31] wmapro: use planar sample format

On Fri, Sep 21, 2012 at 11:23:49AM -0400, Justin Ruggles wrote: --- libavcodec/wmaprodec.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) LGTM ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 1/3] swfenc: error out for more than 1 audio or video stream

Prevents CID602000. --- libavformat/swfenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/swfenc.c b/libavformat/swfenc.c index 9de8b67..31f405d 100644 --- a/libavformat/swfenc.c +++ b/libavformat/swfenc.c @@ -186,6 +186,10 @@ static int swf_write_header(AVFormatContext

[libav-devel] [PATCH 2/3] matroskaenc: check cue point validity before reallocation

Prevents memory leak and possible access to freed memory. Fixes CID605744. --- libavformat/matroskaenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 3e32943..b37d10c 100644 --- a/libavformat/matroskaenc.c

[libav-devel] [PATCH 3/3] avconv: simplify memory allocation in copy_chapters

Make just a single reallocation per call instead of one reallocation per copied chapters. This fixes possible memory leaks on realloc failures. Also correct the allocation since it needs multiples of sizeof(AVChapter*) and not sizeof(AVChapter). Fixes CID700633 and CID700719. --- avconv_opt.c |

[libav-devel] [PATCH 1/1] af_channelmap: free old extended_data on reallocation

Prevents writes to freed memory and the leak of the old extended data. Fixes CID732303. --- libavfilter/af_channelmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index 3e945d6..405a9c2 100644 ---

[libav-devel] [PATCH 1/4] vc1dec: prevent memory leak on av_realloc error

--- libavcodec/vc1dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index df3a55a..13303dc 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -5364,9 +5364,10 @@ static int vc1_decode_frame(AVCodecContext

[libav-devel] [PATCH 2/4] vc1dec: prevent memory leak in error path

Fixes CID732271. --- libavcodec/vc1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 13303dc..d410875 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -5463,7 +5463,7 @@ static int vc1_decode_frame(AVCodecContext

[libav-devel] [PATCH 3/4] af_amix: prevent memory leak on error path

Fixes CID732272. --- libavfilter/af_amix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c index 202d675..a0b265f 100644 --- a/libavfilter/af_amix.c +++ b/libavfilter/af_amix.c @@ -285,8 +285,10 @@ static int

[libav-devel] [PATCH 4/4] af_resample: unref out_buf when avresample_convert returns 0

Fixes CID732273. --- libavfilter/af_resample.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_resample.c b/libavfilter/af_resample.c index 58a9b2a..c30d3d2 100644 --- a/libavfilter/af_resample.c +++ b/libavfilter/af_resample.c @@ -194,7 +194,7 @@ static int

Re: [libav-devel] unary minus operator applied to unsigned type, result still unsigned

On Thu, Aug 16, 2012 at 12:18 PM, Måns Rullgård m...@mansr.com wrote: Janne Grunau janne-li...@jannau.net writes: On 2012-08-15 10:33:26 +0100, Måns Rullgård wrote: Janne Grunau janne-li...@jannau.net writes: The real question here is why the hell those error codes are using MKTAG in

Re: [libav-devel] unary minus operator applied to unsigned type, result still unsigned

aviad rozenhek avia...@gmail.com writes: On Thu, Aug 16, 2012 at 12:18 PM, Måns Rullgård m...@mansr.com wrote: Janne Grunau janne-li...@jannau.net writes: On 2012-08-15 10:33:26 +0100, Måns Rullgård wrote: Janne Grunau janne-li...@jannau.net writes: The real question here is why the

[libav-devel] [PATCH] avconv: remove -same_quant

It has not worked for anything other than fringe codecs (asv1/2, mdec, mjpeg[b]) since about 2003 and nobody ever noticed or complained. This sufficiently proves that there are no users of this option who have a clue of what they are doing, so it is completely useless. --- Changelog |1

[libav-devel] [PATCH] lavc: split asv12 encoder/decoder

--- libavcodec/Makefile |8 +- libavcodec/asv.c| 95 libavcodec/asv.h| 67 ++ libavcodec/asv1.c | 668 --- libavcodec/asvdec.c | 325 + libavcodec/asvenc.c | 287 ++ 6

Re: [libav-devel] [PATCH 3/4] af_amix: prevent memory leak on error path

On Tue, 9 Oct 2012 17:08:42 +0200, Janne Grunau janne-li...@jannau.net wrote: Fixes CID732272. --- libavfilter/af_amix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c index 202d675..a0b265f 100644 ---

Re: [libav-devel] [PATCH 2/4] vc1dec: prevent memory leak in error path

On Tue, Oct 09, 2012 at 05:08:41PM +0200, Janne Grunau wrote: Fixes CID732271. --- libavcodec/vc1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 13303dc..d410875 100644 --- a/libavcodec/vc1dec.c +++

Re: [libav-devel] [PATCH 1/4] vc1dec: prevent memory leak on av_realloc error

On Tue, Oct 09, 2012 at 05:08:40PM +0200, Janne Grunau wrote: --- libavcodec/vc1dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index df3a55a..13303dc 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c

Re: [libav-devel] [PATCH 4/4] af_resample: unref out_buf when avresample_convert returns 0

On Tue, 9 Oct 2012 17:08:43 +0200, Janne Grunau janne-li...@jannau.net wrote: Fixes CID732273. --- libavfilter/af_resample.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_resample.c b/libavfilter/af_resample.c index 58a9b2a..c30d3d2 100644 ---

Re: [libav-devel] [PATCH 1/1] af_channelmap: free old extended_data on reallocation

On Tue, 9 Oct 2012 15:55:49 +0200, Janne Grunau janne-li...@jannau.net wrote: Prevents writes to freed memory and the leak of the old extended data. Fixes CID732303. --- libavfilter/af_channelmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH 1/3] swfenc: error out for more than 1 audio or video stream

On Tue, 9 Oct 2012 15:38:31 +0200, Janne Grunau janne-li...@jannau.net wrote: Prevents CID602000. --- libavformat/swfenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/swfenc.c b/libavformat/swfenc.c index 9de8b67..31f405d 100644 --- a/libavformat/swfenc.c

Re: [libav-devel] [PATCH 2/3] matroskaenc: check cue point validity before reallocation

On Tue, 9 Oct 2012 15:38:32 +0200, Janne Grunau janne-li...@jannau.net wrote: Prevents memory leak and possible access to freed memory. Fixes CID605744. --- libavformat/matroskaenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/matroskaenc.c

Re: [libav-devel] [PATCH 3/3] avconv: simplify memory allocation in copy_chapters

On Tue, 9 Oct 2012 15:38:33 +0200, Janne Grunau janne-li...@jannau.net wrote: Make just a single reallocation per call instead of one reallocation per copied chapters. This fixes possible memory leaks on realloc failures. Also correct the allocation since it needs multiples of

Re: [libav-devel] [PATCH 4/4] swscale: Do not make ff_ symbols globally visible.

On Thu, 04 Oct 2012 19:28:56 +0200, Diego Biurrun di...@biurrun.de wrote: --- libswscale/libswscale.v |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libswscale/libswscale.v b/libswscale/libswscale.v index c68f153..8b9a96a 100644 --- a/libswscale/libswscale.v

[libav-devel] [PATCH 1/1] af_resample: unref out_buf when avresample_convert returns 0

On 2012-10-09 18:15:49 +0200, Anton Khirnov wrote: On Tue, 9 Oct 2012 17:08:43 +0200, Janne Grunau janne-li...@jannau.net wrote: Fixes CID732273. --- libavfilter/af_resample.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_resample.c

[libav-devel] [PATCH 1/1] cmdutils_read_file: increment *size after writing the trailing \0

Fixes CID732166. --- cmdutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmdutils.c b/cmdutils.c index 3ae48e4..ac971df 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -1061,7 +1061,7 @@ int cmdutils_read_file(const char *filename, char **bufptr, size_t *size)

Re: [libav-devel] [PATCH] lavc: split asv12 encoder/decoder

On Tue, Oct 09, 2012 at 05:57:50PM +0200, Anton Khirnov wrote: --- libavcodec/Makefile |8 +- libavcodec/asv.c| 95 libavcodec/asv.h| 67 ++ libavcodec/asv1.c | 668 --- libavcodec/asvdec.c | 325

Re: [libav-devel] [PATCH] build: link test programs only against static libs

On Mon, Oct 08, 2012 at 08:39:39PM +0100, Mans Rullgard wrote: The test programs use internal symbols so cannot be linked against the shared libs. Linking against both shared and static is pointless and might do something strange depending on the linker. This changes the dependencies so the

Re: [libav-devel] [PATCH] build: link test programs only against static libs

Diego Biurrun di...@biurrun.de writes: On Mon, Oct 08, 2012 at 08:39:39PM +0100, Mans Rullgard wrote: The test programs use internal symbols so cannot be linked against the shared libs. Linking against both shared and static is pointless and might do something strange depending on the

Re: [libav-devel] [PATCH] Support for MSVC.

On Thu, Jun 14, 2012 at 1:59 AM, Ronald S. Bultje rsbul...@gmail.comwrote: Hi, see attached. It's kinda big, some parts can/should be done differently, but it's a starting point so let's start talking about how to get this in the right way. Some general comments: - only tested on 32bit so

Re: [libav-devel] [PATCH] avconv: remove -same_quant

On 10/09/2012 05:57 PM, Anton Khirnov wrote: It has not worked for anything other than fringe codecs (asv1/2, mdec, mjpeg[b]) since about 2003 and nobody ever noticed or complained. This sufficiently proves that there are no users of this option who have a clue of what they are doing, so it is

Re: [libav-devel] [PATCH 1/4] vc1dec: prevent memory leak on av_realloc error

On 10/09/2012 11:08 AM, Janne Grunau wrote: --- libavcodec/vc1dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index df3a55a..13303dc 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -5364,9 +5364,10 @@

Re: [libav-devel] [PATCH 1/4] vc1dec: prevent memory leak on av_realloc error

On 10/09/2012 12:13 PM, Kostya Shishkov wrote: On Tue, Oct 09, 2012 at 05:08:40PM +0200, Janne Grunau wrote: --- libavcodec/vc1dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index df3a55a..13303dc 100644 ---

Re: [libav-devel] [PATCH 1/1] af_resample: unref out_buf when avresample_convert returns 0

On Tue, 9 Oct 2012 18:57:48 +0200, Janne Grunau janne-li...@jannau.net wrote: On 2012-10-09 18:15:49 +0200, Anton Khirnov wrote: On Tue, 9 Oct 2012 17:08:43 +0200, Janne Grunau janne-li...@jannau.net wrote: Fixes CID732273. --- libavfilter/af_resample.c | 2 +- 1 file

Re: [libav-devel] [PATCH 1/1] cmdutils_read_file: increment *size after writing the trailing \0

On Tue, 9 Oct 2012 18:57:58 +0200, Janne Grunau janne-li...@jannau.net wrote: Fixes CID732166. --- cmdutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmdutils.c b/cmdutils.c index 3ae48e4..ac971df 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -1061,7 +1061,7

Re: [libav-devel] [PATCH 1/4] vc1dec: prevent memory leak on av_realloc error

On Tue, Oct 09, 2012 at 02:08:41PM -0400, mashiat.sar...@gmail.com wrote: On 10/09/2012 12:13 PM, Kostya Shishkov wrote: On Tue, Oct 09, 2012 at 05:08:40PM +0200, Janne Grunau wrote: --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -5364,9 +5364,10 @@ static int

Re: [libav-devel] [PATCH] Support for MSVC.

Hi, On Tue, Oct 9, 2012 at 10:33 AM, aviad rozenhek avia...@gmail.com wrote: On Thu, Jun 14, 2012 at 1:59 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, see attached. It's kinda big, some parts can/should be done differently, but it's a starting point so let's start talking about how

[libav-devel] [PATCH 2/4] http: use av_strlcpy instead of strcpy() without size checks

Fixes CID700730. --- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 43c6cbc..9666ca3 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -308,7 +308,7 @@ static int process_line(URLContext *h, char

[libav-devel] [PATCH 1/4] avfilter: correct memcpy size avfilter_copy_buf_props()

Does not make a difference in this case since sizeof(uint8_t*) == sizeof(uint8_t**). Fixes CID703814. --- libavfilter/buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffer.c b/libavfilter/buffer.c index c939388..439425a 100644 --- a/libavfilter/buffer.c

[libav-devel] [PATCH 3/4] g722enc: fix size argument in memset

Fixes CID700725. --- libavcodec/g722enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g722enc.c b/libavcodec/g722enc.c index cc87936..11d3f20 100644 --- a/libavcodec/g722enc.c +++ b/libavcodec/g722enc.c @@ -196,7 +196,7 @@ static void

[libav-devel] [PATCH 4/4] rtspdec: use av_strlcpy for writing into fixed size buffer

Fixes CID231347. --- libavformat/rtspdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index a891837..7476c45 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -436,7 +436,7 @@ static inline int

Re: [libav-devel] [PATCH 1/4] avfilter: correct memcpy size avfilter_copy_buf_props()

The set seems fine. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/4] g722enc: fix size argument in memset

On 10/09/2012 09:05 PM, Janne Grunau wrote: Fixes CID700725. --- libavcodec/g722enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g722enc.c b/libavcodec/g722enc.c index cc87936..11d3f20 100644 --- a/libavcodec/g722enc.c +++ b/libavcodec/g722enc.c @@

Re: [libav-devel] [PATCH 1/4] avfilter: correct memcpy size avfilter_copy_buf_props()

Janne Grunau janne-li...@jannau.net writes: Does not make a difference in this case since sizeof(uint8_t*) == sizeof(uint8_t**). Fixes CID703814. --- libavfilter/buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffer.c b/libavfilter/buffer.c index

Re: [libav-devel] unary minus operator applied to unsigned type, result still unsigned

On 10/09/2012 05:18 PM, Måns Rullgård wrote: That would have been my choice from the start. Fine by me shall we replace all the values for release 9 ? lu ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] build: link test programs only against static libs

On Tue, 9 Oct 2012, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Mon, Oct 08, 2012 at 08:39:39PM +0100, Mans Rullgard wrote: The test programs use internal symbols so cannot be linked against the shared libs. Linking against both shared and static is pointless and might do

[libav-devel] [PATCH] build: Don't pass DEP_LIBS as parameters to the linker

DEP_LIBS is part of $^, since DEP_LIBS is a dependency of the test tools. The libs, that originate in the FFLIBS variable, are added into FFEXTRALIBS already (normally in the form -lavutil), but via DEP_LIBS in the literal form as libavutil/libavutil.so. Previously, when building test tools, the

Re: [libav-devel] [PATCH 3/4] g722enc: fix size argument in memset

On 2012-10-09 21:19:55 +0200, Luca Barbato wrote: On 10/09/2012 09:05 PM, Janne Grunau wrote: Fixes CID700725. --- libavcodec/g722enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g722enc.c b/libavcodec/g722enc.c index cc87936..11d3f20 100644

Re: [libav-devel] [PATCH 3/4] g722enc: fix size argument in memset

On 10/09/2012 09:47 PM, Janne Grunau wrote: -memset(c-nodep_buf[i], 0, 2 * frontier * sizeof(*c-nodep_buf)); +memset(c-nodep_buf[i], 0, 2 * frontier * sizeof(*c-nodep_buf[i])); nodes[i][0] = c-node_buf[i] + frontier; nodes[i][0]-ssd = 0;

Re: [libav-devel] [PATCH 3/4] g722enc: fix size argument in memset

On Tue, 9 Oct 2012, Janne Grunau wrote: Fixes CID700725. --- libavcodec/g722enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g722enc.c b/libavcodec/g722enc.c index cc87936..11d3f20 100644 --- a/libavcodec/g722enc.c +++ b/libavcodec/g722enc.c @@ -196,7 +196,7

[libav-devel] [PATCH 1/3] segment: support applehttp style list

--- Should be ok now, Martin, did I overlook something else? libavformat/segment.c | 49 +++-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 8ac04e2..9a5 100644 ---

[libav-devel] [PATCH 2/3] mpegtsenc: set muxing type notification to verbose

--- libavformat/mpegtsenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 6facf47..29d83c6 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -624,10 +624,10 @@ static int

[libav-devel] [PATCH 3/3] libx264: make it less verbose

The information marked as informative is usually marked as verbose for all the other encoders. --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index f536f7f..f11d9a3 100644 --- a/libavcodec/libx264.c +++

[libav-devel] [PATCH 1/2] avfilter: fix graphparser memleaks on error paths

Fixes CID700635, CID700636 and CID732274. --- libavfilter/graphparser.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavfilter/graphparser.c b/libavfilter/graphparser.c index 3921189..04339c8 100644 --- a/libavfilter/graphparser.c +++

Re: [libav-devel] [PATCH 2/3] mpegtsenc: set muxing type notification to verbose

On 2012-10-09 22:13:36 +0200, Luca Barbato wrote: --- libavformat/mpegtsenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 6facf47..29d83c6 100644 --- a/libavformat/mpegtsenc.c +++

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 2012-10-09 22:13:37 +0200, Luca Barbato wrote: The information marked as informative is usually marked as verbose for all the other encoders. --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c

[libav-devel] [PATCH 1/5] vc1dec: Set chroma reference field from REFFIELD for 1REF field pictures

Interlaced field pictures can have one or two reference pictures, signaled by NUMREF syntax element. For single reference pictures, reference picture is determined by REFFIELD syntax element. --- libavcodec/vc1dec.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vc1dec.c

[libav-devel] [PATCH 2/5] vc1dec: Invoke edge emulation regardless of MV precision for 1-MV chroma

This is required due to the way VC-1 handles chroma pull-back which may end up causing negative chroma MV for zero luma MV. Edge emulation needs to be invoked in such cases. This problem only affects chroma Y motion vector. --- libavcodec/vc1dec.c |2 +- 1 file changed, 1 insertion(+), 1

[libav-devel] [PATCH 4/5] vc1dec: Set opposite to the correct value for 1REF field pictures

--- libavcodec/vc1dec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 491e200..40164cc 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -1458,10 +1458,16 @@ static inline void

[libav-devel] [PATCH 5/5] Double motion vector range for HPEL interlaced picture in proper place

The existing code is not in the right place and it should cover both interlaced frame and field pictures. --- libavcodec/vc1.c|5 + libavcodec/vc1dec.c |4 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 09/10/2012 4:13 PM, Luca Barbato wrote: The information marked as informative is usually marked as verbose for all the other encoders. --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) NAK. This is wrong. It makes the obtained bitrate unavailable during

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On Tue, Oct 9, 2012 at 1:39 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 09/10/2012 4:13 PM, Luca Barbato wrote: The information marked as informative is usually marked as verbose for all the other encoders. --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [libav-devel] [PATCH] build: Don't pass DEP_LIBS as parameters to the linker

Martin Storsjö mar...@martin.st writes: DEP_LIBS is part of $^, since DEP_LIBS is a dependency of the test tools. The libs, that originate in the FFLIBS variable, are added into FFEXTRALIBS already (normally in the form -lavutil), but via DEP_LIBS in the literal form as

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 2012-10-09 16:39:55 -0400, Derek Buitenhuis wrote: On 09/10/2012 4:13 PM, Luca Barbato wrote: The information marked as informative is usually marked as verbose for all the other encoders. --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) NAK.

Re: [libav-devel] [PATCH] build: Don't pass DEP_LIBS as parameters to the linker

On Tue, 9 Oct 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: DEP_LIBS is part of $^, since DEP_LIBS is a dependency of the test tools. The libs, that originate in the FFLIBS variable, are added into FFEXTRALIBS already (normally in the form -lavutil), but via DEP_LIBS in

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 10/09/2012 10:39 PM, Derek Buitenhuis wrote: On 09/10/2012 4:13 PM, Luca Barbato wrote: The information marked as informative is usually marked as verbose for all the other encoders. --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) NAK. This is

Re: [libav-devel] [PATCH 1/3] segment: support applehttp style list

On Tue, Oct 09, 2012 at 10:13:35PM +0200, Luca Barbato wrote: --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -252,14 +290,18 @@ static int seg_write_packet(AVFormatContext *s, AVPacket *pkt) if (seg-list) { -avio_printf(seg-pb, %s\n, oc-filename); +

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 09/10/2012 4:50 PM, Janne Grunau wrote: AV_LOG_INFO is probably the better match, especially since AV_LOG_INFO and X264_LOG_INFO are both the default log levels. Yes. If we want to complain about the chattiness, you should take it up with x264, and maybe have them amend it, instead of

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 10/09/2012 10:55 PM, Derek Buitenhuis wrote: If we want to complain about the chattiness, you should take it up with x264, and maybe have them amend it, instead of crippling useful output from our end. Since this patch as is everybody agrees shouldn't go anywhere, could we please focus,

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 09/10/2012 4:58 PM, Luca Barbato wrote: Since this patch as is everybody agrees shouldn't go anywhere, could we please focus, maybe, on your specific issue so I can give you a better solution overall? Right now, if you output to /dev/null (as you would do on a first pass), avconv will

Re: [libav-devel] [PATCH 3/3] libx264: make it less verbose

On 09/10/2012 5:01 PM, Derek Buitenhuis wrote: Right now, if you output to /dev/null (as you would do on a first pass), avconv will always report bitrate as 0. I think perhaps it is using filesize? Also note you cannot get video and audio bitrate separately. Only whole-file bitrate. - Derek

Re: [libav-devel] [PATCH] build: Don't pass DEP_LIBS as parameters to the linker

Martin Storsjö mar...@martin.st writes: On Tue, 9 Oct 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: DEP_LIBS is part of $^, since DEP_LIBS is a dependency of the test tools. The libs, that originate in the FFLIBS variable, are added into FFEXTRALIBS already (normally

  1   2   >