Re: [libav-devel] [PATCH 08/11] mpegaudioenc: allow planar or interleaved sample format as input

2012-10-10 Thread Anton Khirnov
On Sat, 6 Oct 2012 13:02:46 -0400, Justin Ruggles wrote: > --- > Supporting either sample format for this particular encoder is trivial > and does not require additional processing in either case. > > libavcodec/mpegaudioenc.c | 13 + > 1 files changed, 9 insertions(+), 4 deleti

Re: [libav-devel] [PATCH] sh4: add required #include, fix build

2012-10-10 Thread Kostya Shishkov
On Thu, Oct 11, 2012 at 03:13:35AM +0100, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > libavcodec/sh4/qpel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/sh4/qpel.c b/libavcodec/sh4/qpel.c > index 3242872..cb6cdf0 100644 > --- a/libavcodec/sh4/qpel.c > +++

[libav-devel] [PATCH] sh4: add required #include, fix build

2012-10-10 Thread Mans Rullgard
Signed-off-by: Mans Rullgard --- libavcodec/sh4/qpel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/sh4/qpel.c b/libavcodec/sh4/qpel.c index 3242872..cb6cdf0 100644 --- a/libavcodec/sh4/qpel.c +++ b/libavcodec/sh4/qpel.c @@ -21,6 +21,8 @@ * Foundation, Inc., 51 Franklin Stre

Re: [libav-devel] [PATCH 1/2] dsputil: macros should be upper case

2012-10-10 Thread Måns Rullgård
Luca Barbato writes: > On 10/11/2012 03:10 AM, Måns Rullgård wrote: >> Luca Barbato writes: > >>> /* dspfunc(avg_no_rnd_qpel, 1, 8); */ >> >> You didn't upper-case the commented out ones. >> > Probably they should be removed, we'll see tomorrow. Yes, most likely. -- Måns Rullgård m...@

Re: [libav-devel] [PATCH 1/2] dsputil: macros should be upper case

2012-10-10 Thread Luca Barbato
On 10/11/2012 03:10 AM, Måns Rullgård wrote: > Luca Barbato writes: >> /* dspfunc(avg_no_rnd_qpel, 1, 8); */ > > You didn't upper-case the commented out ones. > Probably they should be removed, we'll see tomorrow. ___ libav-devel mailing list li

Re: [libav-devel] [PATCH 1/2] dsputil: macros should be upper case

2012-10-10 Thread Måns Rullgård
Luca Barbato writes: > --- > libavcodec/dsputil.c | 58 > ++-- > 1 file changed, 29 insertions(+), 29 deletions(-) > > diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c > index 5c705ea..722afcf 100644 > --- a/libavcodec/dsputil.c > +++ b/li

Re: [libav-devel] [PATCH] dsputil: split out mlp dsp function

2012-10-10 Thread Luca Barbato
On 10/11/2012 03:01 AM, Måns Rullgård wrote: > Luca Barbato writes: > >> On 10/11/2012 02:49 AM, Måns Rullgård wrote: >>> Luca Barbato writes: >>> +void ff_mlpdsp_init_x86(MLPDSPContext* c) >>> >>> Misplaced * >>> >> >> Fixed locally, may I push the set? > > Set? This patch looks OK other

Re: [libav-devel] [PATCH] dsputil: split out mlp dsp function

2012-10-10 Thread Måns Rullgård
Luca Barbato writes: > On 10/11/2012 02:49 AM, Måns Rullgård wrote: >> Luca Barbato writes: >> >>> +void ff_mlpdsp_init_x86(MLPDSPContext* c) >> >> Misplaced * >> > > Fixed locally, may I push the set? Set? This patch looks OK otherwise, yes. I don't know of any others. -- Måns Rullgård

Re: [libav-devel] [PATCH] dsputil: split out mlp dsp function

2012-10-10 Thread Luca Barbato
On 10/11/2012 02:49 AM, Måns Rullgård wrote: > Luca Barbato writes: > >> +void ff_mlpdsp_init_x86(MLPDSPContext* c) > > Misplaced * > Fixed locally, may I push the set? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailma

Re: [libav-devel] [PATCH] dsputil: split out mlp dsp function

2012-10-10 Thread Måns Rullgård
Luca Barbato writes: > +void ff_mlpdsp_init_x86(MLPDSPContext* c) Misplaced * -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] dsputil: split out mlp dsp function

2012-10-10 Thread Luca Barbato
--- libavcodec/dsputil.c| 4 libavcodec/dsputil.h| 8 libavcodec/mlpdec.c | 6 +++--- libavcodec/mlpdsp.c | 7 --- libavcodec/x86/mlpdsp.c | 4 ++-- 5 files changed, 9 insertions(+), 20 deletions(-) diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c index 7

Re: [libav-devel] [PATCH 2/2] dsputil: split out mlp dsp function

2012-10-10 Thread Måns Rullgård
Luca Barbato writes: > diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c > index afd8f88..84a22f5 100644 > --- a/libavcodec/mlpdec.c > +++ b/libavcodec/mlpdec.c > @@ -27,12 +27,12 @@ > #include > > #include "avcodec.h" > -#include "dsputil.h" Yay, one less dependency on dsputil.h. > #i

[libav-devel] [PATCH 2/2] dsputil: split out mlp dsp function

2012-10-10 Thread Luca Barbato
--- libavcodec/dsputil.c| 4 libavcodec/dsputil.h| 8 libavcodec/mlpdec.c | 6 +++--- libavcodec/mlpdsp.c | 7 --- libavcodec/x86/mlpdsp.c | 4 ++-- 5 files changed, 9 insertions(+), 20 deletions(-) diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c index 7

[libav-devel] [PATCH 1/2] dsputil: macros should be upper case

2012-10-10 Thread Luca Barbato
--- libavcodec/dsputil.c | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c index 5c705ea..722afcf 100644 --- a/libavcodec/dsputil.c +++ b/libavcodec/dsputil.c @@ -2761,7 +2761,7 @@

Re: [libav-devel] [PATCH 1/1] averror: make error values proper negative values

2012-10-10 Thread Luca Barbato
On 10/11/2012 01:50 AM, Janne Grunau wrote: > On 2012-10-10 22:30:05 +0200, Janne Grunau wrote: >> Fixes stupid mistake in 25227c3a78fefd74bc6ea34032cd49ec8c8d9d85. >> --- >> libavutil/error.h | 30 +++--- >> 1 file changed, 15 insertions(+), 15 deletions(-) >> >> diff --gi

Re: [libav-devel] [PATCH 1/1] averror: make error values proper negative values

2012-10-10 Thread Janne Grunau
On 2012-10-10 22:30:05 +0200, Janne Grunau wrote: > Fixes stupid mistake in 25227c3a78fefd74bc6ea34032cd49ec8c8d9d85. > --- > libavutil/error.h | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/libavutil/error.h b/libavutil/error.h > index 3

Re: [libav-devel] [PATCH] x86: call remaining init functions under if (ARCH_X86), not if (HAVE_MMX)

2012-10-10 Thread Janne Grunau
On 2012-10-10 23:47:27 +0200, Diego Biurrun wrote: > --- > Now tested to work with --disable-mmx, which required reshuffling > OBJS/MMX-OBJS handling as well as a few ifdefs. > > libavcodec/dsputil.c |2 +- > libavcodec/dsputil.h |2 +- > libavcodec/dwt.c |

Re: [libav-devel] [RELEASE] planning for 0.9

2012-10-10 Thread Sean McGovern
On Wed, Oct 10, 2012 at 7:19 PM, Reinhard Tartler wrote: > Oh, ich it's really only signing the tarball, then i might find some time > tomorrow night. But Diego should be able for that as well. > > What about point releases? > > Greetings from Hollywood :-) > I haven't engaged anyone on the point

[libav-devel] [PATCH] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Diego Biurrun
--- Fixed placement of extern table declarations (for arm), they need to come before the arch-specific headers, as they are referenced there. libavcodec/Makefile|7 + libavcodec/arm/mathops.h | 24 libavcodec/inverse.c

Re: [libav-devel] [PATCH 3/3] build: do not use LIB as variable name

2012-10-10 Thread Martin Storsjö
On Wed, 10 Oct 2012, Mans Rullgard wrote: The Microsoft linker uses the LIB environment variable which clashes with a make variable of the same name. Signed-off-by: Mans Rullgard --- library.mak | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/library.mak b/library.mak

Re: [libav-devel] [PATCH 1/3] build: remove single-use variable THIS_LIB

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 11:06:58PM +0100, Mans Rullgard wrote: > Replace the singe use of THIS_LIB with its value. sing_l_e The whole set LGTM otherwise. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/

Re: [libav-devel] [PATCH 3/3] build: do not use LIB as variable name

2012-10-10 Thread Luca Barbato
On 10/11/2012 12:07 AM, Mans Rullgard wrote: > The Microsoft linker uses the LIB environment variable which > clashes with a make variable of the same name. > > Signed-off-by: Mans Rullgard > --- > library.mak | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Fine for me. __

Re: [libav-devel] [PATCH 2/3] build: whitespace cosmetics

2012-10-10 Thread Luca Barbato
On 10/11/2012 12:06 AM, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > library.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/liba

Re: [libav-devel] [PATCH 1/3] build: remove single-use variable THIS_LIB

2012-10-10 Thread Luca Barbato
On 10/11/2012 12:06 AM, Mans Rullgard wrote: > Replace the singe use of THIS_LIB with its value. > > Signed-off-by: Mans Rullgard > --- > library.mak | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Seems fine. ___ libav-devel mailing lis

Re: [libav-devel] [PATCH] build: remove references to unused EXTRAOBJS variable

2012-10-10 Thread Janne Grunau
On 2012-10-10 22:43:49 +0100, Måns Rullgård wrote: > This was part of a ghastly hack that is long since gone. > > Signed-off-by: Mans Rullgard > --- > library.mak | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/library.mak b/library.mak > index 4593b11..0a59476 1006

Re: [libav-devel] [PATCH] build: remove references to unused EXTRAOBJS variable

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 10:43:49PM +0100, Mans Rullgard wrote: > This was part of a ghastly hack that is long since gone. > > Signed-off-by: Mans Rullgard > --- > library.mak | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) OK Diego ___ li

[libav-devel] [PATCH 3/3] build: do not use LIB as variable name

2012-10-10 Thread Mans Rullgard
The Microsoft linker uses the LIB environment variable which clashes with a make variable of the same name. Signed-off-by: Mans Rullgard --- library.mak | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/library.mak b/library.mak index 9cf61e3..ec78707 100644 --- a/library

[libav-devel] [PATCH 2/3] build: whitespace cosmetics

2012-10-10 Thread Mans Rullgard
Signed-off-by: Mans Rullgard --- library.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.mak b/library.mak index 4d03479..9cf61e3 100644 --- a/library.mak +++ b/library.mak @@ -93,7 +93,7 @@ endef $(eval $(RULES)) $(EXAMPLES) $(TOOLS): $(DEP_LIBS) $(SUBDIR)$($(

[libav-devel] [PATCH 1/3] build: remove single-use variable THIS_LIB

2012-10-10 Thread Mans Rullgard
Replace the singe use of THIS_LIB with its value. Signed-off-by: Mans Rullgard --- library.mak | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/library.mak b/library.mak index 0a59476..4d03479 100644 --- a/library.mak +++ b/library.mak @@ -5,7 +5,6 @@ include $(SRC_PATH)/com

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Oct 10, 2012 at 09:13:13PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> > On Wed, Oct 10, 2012 at 09:01:14PM +0100, Måns Rullgård wrote: >> >> Diego Biurrun writes: >> >> > On Wed, Oct 10, 2012 at 09:55:17PM +0300, Martin Storsjö wrote: >> >> >> On Wed

[libav-devel] [PATCH] x86: call remaining init functions under if (ARCH_X86), not if (HAVE_MMX)

2012-10-10 Thread Diego Biurrun
--- Now tested to work with --disable-mmx, which required reshuffling OBJS/MMX-OBJS handling as well as a few ifdefs. libavcodec/dsputil.c |2 +- libavcodec/dsputil.h |2 +- libavcodec/dwt.c |2 +- libavcodec/x86/Makefile | 19 +--

[libav-devel] [PATCH] build: remove references to unused EXTRAOBJS variable

2012-10-10 Thread Mans Rullgard
This was part of a ghastly hack that is long since gone. Signed-off-by: Mans Rullgard --- library.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library.mak b/library.mak index 4593b11..0a59476 100644 --- a/library.mak +++ b/library.mak @@ -26,7 +26,7 @@ $(TESTOBJS):

Re: [libav-devel] [PATCH 1/1] averror: make error values proper negative values

2012-10-10 Thread Luca Barbato
On 10/10/2012 10:30 PM, Janne Grunau wrote: > Fixes stupid mistake in 25227c3a78fefd74bc6ea34032cd49ec8c8d9d85. > --- > libavutil/error.h | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > Sorry for not reading properly =_=; __

Re: [libav-devel] [PATCH] options_table: refs option is not snow-only

2012-10-10 Thread Janne Grunau
On 2012-10-10 22:30:57 +0200, Diego Biurrun wrote: > --- > libavcodec/options_table.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h > index 4b6d417..9e9de46 100644 > --- a/libavcodec/options_table.h > +++ b/l

[libav-devel] [PATCH] options_table: refs option is not snow-only

2012-10-10 Thread Diego Biurrun
--- libavcodec/options_table.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 4b6d417..9e9de46 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -347,7 +347,7 @@ static const AVOption

[libav-devel] [PATCH 1/1] averror: make error values proper negative values

2012-10-10 Thread Janne Grunau
Fixes stupid mistake in 25227c3a78fefd74bc6ea34032cd49ec8c8d9d85. --- libavutil/error.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavutil/error.h b/libavutil/error.h index 38f9824..61d5fb9 100644 --- a/libavutil/error.h +++ b/libavutil/e

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 09:13:13PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > On Wed, Oct 10, 2012 at 09:01:14PM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > On Wed, Oct 10, 2012 at 09:55:17PM +0300, Martin Storsjö wrote: > >> >> On Wed, 10 Oct 2012, Måns Rullgård wr

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Oct 10, 2012 at 09:01:14PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > On Wed, Oct 10, 2012 at 09:55:17PM +0300, Martin Storsjö wrote: >> >> On Wed, 10 Oct 2012, Måns Rullgård wrote: >> >> >Martin Storsjö writes: >> >> >>On MSVC, the LIB environ

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 09:01:14PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > On Wed, Oct 10, 2012 at 09:55:17PM +0300, Martin Storsjö wrote: > >> On Wed, 10 Oct 2012, Måns Rullgård wrote: > >> >Martin Storsjö writes: > >> >>On MSVC, the LIB environment variable is used to specify

Re: [libav-devel] [PATCH 1/1] avconv: remove bogus warning when using avconv -h without parameter

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > On 2012-10-10 19:48:04 +0100, Måns Rullgård wrote: >> Janne Grunau writes: >> >> > --- >> > avconv_opt.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/avconv_opt.c b/avconv_opt.c >> > index 9f30134..4445f65 100644 >> > --- a/avconv_opt

Re: [libav-devel] [PATCH 2/4] h263: avoid memcpys over array bound in motion vector caching for obmc

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > On 2012-10-10 19:44:15 +0100, Måns Rullgård wrote: >> Janne Grunau writes: >> >> > Fixes CID602232. >> > --- >> > libavcodec/mpegvideo_motion.c | 32 >> > 1 file changed, 20 insertions(+), 12 deletions(-) >> > >> > diff --git a/libavcodec

Re: [libav-devel] [PATCH 1/1] averror: explicitly define AVERROR_* values

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > +#define AVERROR_BSF_NOT_FOUND 0xb9acbd08 ///< Bitstream filter not found This doesn't work as intented. Error values are supposed to be negative, and that is a very positive value. -- Måns Rullgård m...@mansr.com ___ lib

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Oct 10, 2012 at 09:55:17PM +0300, Martin Storsjö wrote: >> On Wed, 10 Oct 2012, Måns Rullgård wrote: >> >Martin Storsjö writes: >> >>On MSVC, the LIB environment variable is used to specify the >> >>default paths for libraries. When this variable is set in the >>

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 09:55:17PM +0300, Martin Storsjö wrote: > On Wed, 10 Oct 2012, Måns Rullgård wrote: > >Martin Storsjö writes: > >>On MSVC, the LIB environment variable is used to specify the > >>default paths for libraries. When this variable is set in the > >>makefile, it overwrites the o

[libav-devel] [PATCH 1/1] avconv: remove bogus warning when using avconv -h without parameter

2012-10-10 Thread Janne Grunau
On 2012-10-10 19:48:04 +0100, Måns Rullgård wrote: > Janne Grunau writes: > > > --- > > avconv_opt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/avconv_opt.c b/avconv_opt.c > > index 9f30134..4445f65 100644 > > --- a/avconv_opt.c > > +++ b/avconv_opt.c > > @@ -

Re: [libav-devel] [PATCH 4/4] flashsv: propagate inflateReset() errors

2012-10-10 Thread Janne Grunau
On 2012-10-10 21:03:27 +0200, Luca Barbato wrote: > On 10/10/2012 07:57 PM, Janne Grunau wrote: > > Fixes CID717493. > > --- > > libavcodec/flashsv.c | 17 + > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c > > i

Re: [libav-devel] [PATCH 2/4] h263: avoid memcpys over array bound in motion vector caching for obmc

2012-10-10 Thread Janne Grunau
On 2012-10-10 19:44:15 +0100, Måns Rullgård wrote: > Janne Grunau writes: > > > Fixes CID602232. > > --- > > libavcodec/mpegvideo_motion.c | 32 > > 1 file changed, 20 insertions(+), 12 deletions(-) > > > > diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/

Re: [libav-devel] [PATCH 4/4] flashsv: propagate inflateReset() errors

2012-10-10 Thread Luca Barbato
On 10/10/2012 07:57 PM, Janne Grunau wrote: > Fixes CID717493. > --- > libavcodec/flashsv.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c > index 1f21c8b..84964d6 100644 > --- a/libavcodec/flashsv.c > +++ b/

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Luca Barbato
On 10/10/2012 07:49 PM, Martin Storsjö wrote: > On MSVC, the LIB environment variable is used to specify the > default paths for libraries. When this variable is set in the > makefile, it overwrites the original lib path variable for the > linker. > --- > This slipped me before, since the env varia

Re: [libav-devel] [PATCH 1/1] averror: explicitly define AVERROR_* values

2012-10-10 Thread Luca Barbato
On 10/10/2012 08:27 PM, Janne Grunau wrote: > --- > values are identical for binary compatibility > Ok. We might switch to more regular ones in release 10 maybe. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinf

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Martin Storsjö
On Wed, 10 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: On MSVC, the LIB environment variable is used to specify the default paths for libraries. When this variable is set in the makefile, it overwrites the original lib path variable for the linker. --- This slipped me before, since

Re: [libav-devel] [PATCH 1/1] avconv: remove bogus warning when using avconv -h withjout parameter

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > --- > avconv_opt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/avconv_opt.c b/avconv_opt.c > index 9f30134..4445f65 100644 > --- a/avconv_opt.c > +++ b/avconv_opt.c > @@ -1792,7 +1792,7 @@ void show_help_default(const char *opt, const char *arg

Re: [libav-devel] [PATCH 2/4] h263: avoid memcpys over array bound in motion vector caching for obmc

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > Fixes CID602232. > --- > libavcodec/mpegvideo_motion.c | 32 > 1 file changed, 20 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/mpegvideo_motion.c > index 22948e2..6833916 100644 > --- a/libavcod

Re: [libav-devel] [PATCH 1/4] fate: add h263 obmc vsynth tests

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > --- > tests/fate/vcodec.mak| 3 +++ > tests/ref/fate/vsynth1-h263-obmc | 4 > tests/ref/fate/vsynth2-h263-obmc | 4 > 3 files changed, 11 insertions(+) > create mode 100644 tests/ref/fate/vsynth1-h263-obmc > create mode 100644 tests/ref/fate/vsynth2

Re: [libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Måns Rullgård
Martin Storsjö writes: > On MSVC, the LIB environment variable is used to specify the > default paths for libraries. When this variable is set in the > makefile, it overwrites the original lib path variable for the > linker. > --- > This slipped me before, since the env variables are set up sligh

[libav-devel] [PATCH 1/1] avconv: remove bogus warning when using avconv -h withjout parameter

2012-10-10 Thread Janne Grunau
--- avconv_opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avconv_opt.c b/avconv_opt.c index 9f30134..4445f65 100644 --- a/avconv_opt.c +++ b/avconv_opt.c @@ -1792,7 +1792,7 @@ void show_help_default(const char *opt, const char *arg) const int per_file = OPT_SPEC | O

[libav-devel] [PATCH 1/1] averror: explicitly define AVERROR_* values

2012-10-10 Thread Janne Grunau
--- values are identical for binary compatibility libavutil/error.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavutil/error.h b/libavutil/error.h index 8ac355c..38f9824 100644 --- a/libavutil/error.h +++ b/libavutil/error.h @@ -45,21 +4

Re: [libav-devel] [PATCH 3/4] indeo4/5: remove constant parameter num_bands from wavelet recomposition

2012-10-10 Thread Kostya Shishkov
On Wed, Oct 10, 2012 at 07:57:52PM +0200, Janne Grunau wrote: > Fixes bogus uninitialized value compiler and coverity warnings. > --- > libavcodec/ivi_common.c | 4 ++-- > libavcodec/ivi_dsp.c| 5 +++-- > libavcodec/ivi_dsp.h| 6 ++ > 3 files changed, 7 insertions(+), 8 deletions(-) f

[libav-devel] [PATCH 4/4] flashsv: propagate inflateReset() errors

2012-10-10 Thread Janne Grunau
Fixes CID717493. --- libavcodec/flashsv.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c index 1f21c8b..84964d6 100644 --- a/libavcodec/flashsv.c +++ b/libavcodec/flashsv.c @@ -121,10 +121,11 @@ static av_cold int

[libav-devel] [PATCH 3/4] indeo4/5: remove constant parameter num_bands from wavelet recomposition

2012-10-10 Thread Janne Grunau
Fixes bogus uninitialized value compiler and coverity warnings. --- libavcodec/ivi_common.c | 4 ++-- libavcodec/ivi_dsp.c| 5 +++-- libavcodec/ivi_dsp.h| 6 ++ 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/ivi_common.c b/libavcodec/ivi_common.c index d1a86c

[libav-devel] [PATCH 2/4] h263: avoid memcpys over array bound in motion vector caching for obmc

2012-10-10 Thread Janne Grunau
Fixes CID602232. --- libavcodec/mpegvideo_motion.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/libavcodec/mpegvideo_motion.c b/libavcodec/mpegvideo_motion.c index 22948e2..6833916 100644 --- a/libavcodec/mpegvideo_motion.c +++ b/libavcodec

[libav-devel] [PATCH 1/4] fate: add h263 obmc vsynth tests

2012-10-10 Thread Janne Grunau
--- tests/fate/vcodec.mak| 3 +++ tests/ref/fate/vsynth1-h263-obmc | 4 tests/ref/fate/vsynth2-h263-obmc | 4 3 files changed, 11 insertions(+) create mode 100644 tests/ref/fate/vsynth1-h263-obmc create mode 100644 tests/ref/fate/vsynth2-h263-obmc diff --git a/tests/fate/v

[libav-devel] [PATCH] build: Rename the LIB variable for testprog targets

2012-10-10 Thread Martin Storsjö
On MSVC, the LIB environment variable is used to specify the default paths for libraries. When this variable is set in the makefile, it overwrites the original lib path variable for the linker. --- This slipped me before, since the env variables are set up slightly differently in my msvc/wine test

Re: [libav-devel] [PATCH] avio: introduce avio_closep

2012-10-10 Thread Luca Barbato
On 10/10/2012 04:02 PM, Luca Barbato wrote: > --- > Added apichange as requested by Anton Pushed, acknowledged on irc. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] segment: support applehttp style list

2012-10-10 Thread Luca Barbato
On 10/10/2012 06:41 PM, Martin Storsjö wrote: > On Wed, 10 Oct 2012, Luca Barbato wrote: > >> --- >> libavformat/segment.c | 85 >> +++ >> 1 file changed, 72 insertions(+), 13 deletions(-) > > Ok with me, assuming that it's tested. Tested and appare

Re: [libav-devel] [PATCH 2/2] segment: support applehttp style list

2012-10-10 Thread Martin Storsjö
On Wed, 10 Oct 2012, Luca Barbato wrote: --- libavformat/segment.c | 85 +++ 1 file changed, 72 insertions(+), 13 deletions(-) Ok with me, assuming that it's tested. // Martin ___ libav-devel mailing li

Re: [libav-devel] [PATCH 1/1] avconv: fix bitrate report when writing to /dev/null

2012-10-10 Thread Derek Buitenhuis
On 09/10/2012 6:12 PM, Luca Barbato wrote: > We might check that avio_tell doesn't error out for any reason. Agreed, but shouldn't that be a separate patch? - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/list

[libav-devel] [PATCH] avio: introduce avio_closep

2012-10-10 Thread Luca Barbato
--- Added apichange as requested by Anton doc/APIchanges| 3 +++ libavformat/avio.h| 15 +++ libavformat/aviobuf.c | 7 +++ libavformat/version.h | 4 ++-- 4 files changed, 27 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 76475da.

Re: [libav-devel] [libav-commits] a64multienc: change mc_frame_counter to unsigned

2012-10-10 Thread Måns Rullgård
"Janne Grunau " writes: > Module: libav > Branch: master > Commit: 706a559b30087f18ceb533be2c528ac2ff9d96ca > > Author:Janne Grunau > Committer: Janne Grunau > Date: Thu Sep 20 09:34:35 2012 + > > a64multienc: change mc_frame_counter to unsigned > > GCC cannot proof that c->mc_fram

Re: [libav-devel] [PATCH] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > --- > Renamed mathops.c --> mathtables.c. > > libavcodec/Makefile|7 + > libavcodec/arm/mathops.h | 24 > libavcodec/inverse.c |1 - > libavcodec/mathops.h

[libav-devel] [PATCH 2/2] segment: support applehttp style list

2012-10-10 Thread Luca Barbato
--- libavformat/segment.c | 85 +++ 1 file changed, 72 insertions(+), 13 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 8ac04e2..fd52835 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -37,6 +37,7 @@

[libav-devel] [PATCH 1/2] avio: introduce avio_closep

2012-10-10 Thread Luca Barbato
--- libavformat/avio.h| 15 +++ libavformat/aviobuf.c | 7 +++ libavformat/version.h | 4 ++-- 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index 96e8e1c..b6d3cb3 100644 --- a/libavformat/avio.h +++ b/libavformat/avio

[libav-devel] [PATCH] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Diego Biurrun
--- Renamed mathops.c --> mathtables.c. libavcodec/Makefile|7 + libavcodec/arm/mathops.h | 24 libavcodec/inverse.c |1 - libavcodec/mathops.h | 29 +

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Måns Rullgård writes: > Janne Grunau writes: > >> +void ff_rv40dsp_init_arm(RV34DSPContext *c, DSPContext* dsp) >> +{ >> +#if HAVE_NEON >> +int cpu_flags = av_get_cpu_flags(); >> + >> +if (have_neon(cpu_flags)) >> +ff_rv40dsp_init_neon(c); >> +#endif /* HAVE_NEON */ >> +} > > You

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > +void ff_rv40dsp_init_arm(RV34DSPContext *c, DSPContext* dsp) > +{ > +#if HAVE_NEON > +int cpu_flags = av_get_cpu_flags(); > + > +if (have_neon(cpu_flags)) > +ff_rv40dsp_init_neon(c); > +#endif /* HAVE_NEON */ > +} You don't need the #if here. -- Måns Rul

[libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Janne Grunau
From: Jean-Baptiste Kempf Assign NEON specific function pointers after runtime check via av_get_cpu_flags(). Signed-off-by: Janne Grunau --- libavcodec/arm/Makefile | 12 ++-- .../arm/{rv34dsp_init_neon.c => rv34dsp_init_arm.c} | 15 ++-

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > On 2012-10-10 11:54:11 +0100, Måns Rullgård wrote: >> Janne Grunau writes: >> >> > -void ff_rv40dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) >> > +static void ff_rv40dsp_init_neon(RV34DSPContext *c) >> > { >> > c->put_pixels_tab[0][ 1] = ff_put_rv40_qpel16_mc10

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Janne Grunau
On 2012-10-10 11:54:11 +0100, Måns Rullgård wrote: > Janne Grunau writes: > > > -void ff_rv40dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) > > +static void ff_rv40dsp_init_neon(RV34DSPContext *c) > > { > > c->put_pixels_tab[0][ 1] = ff_put_rv40_qpel16_mc10_neon; > > c->put_pixels_t

Re: [libav-devel] [PATCH] svq1: Drop a bunch of useless parentheses

2012-10-10 Thread Kostya Shishkov
On Wed, Oct 10, 2012 at 02:13:45PM +0200, Diego Biurrun wrote: > --- > libavcodec/svq1dec.c | 66 > +- > libavcodec/svq1enc.c | 26 ++-- > 2 files changed, 46 insertions(+), 46 deletions(-) looks less ugly to me :) _

Re: [libav-devel] [PATCH] svq1: K&R formatting cosmetics

2012-10-10 Thread Diego Biurrun
On Sat, Oct 06, 2012 at 06:32:24PM +0200, Diego Biurrun wrote: > --- > libavcodec/svq1.c |4 +- > libavcodec/svq1.h |8 +- > libavcodec/svq13.c | 77 ++-- > libavcodec/svq1_vlc.h | 231 +- > libavcodec/svq1dec.c| 1154 > ---

[libav-devel] [PATCH] svq1: Drop a bunch of useless parentheses

2012-10-10 Thread Diego Biurrun
--- libavcodec/svq1dec.c | 66 +- libavcodec/svq1enc.c | 26 ++-- 2 files changed, 46 insertions(+), 46 deletions(-) diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c index 1ca9b1d..8127e36 100644 --- a/libavcodec/svq1dec.

Re: [libav-devel] [PATCH] parseutils-test: do not print numerical error codes

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 12:51:09PM +0100, Mans Rullgard wrote: > The error codes differ between systems so printing the value makes > the fate test fail on some systems. > > Signed-off-by: Mans Rullgard > --- > libavutil/parseutils.c| 4 ++-- > tests/ref/fate/parseutils | 50 >

[libav-devel] [PATCH] parseutils-test: do not print numerical error codes

2012-10-10 Thread Mans Rullgard
The error codes differ between systems so printing the value makes the fate test fail on some systems. Signed-off-by: Mans Rullgard --- libavutil/parseutils.c| 4 ++-- tests/ref/fate/parseutils | 50 +++ 2 files changed, 27 insertions(+), 27 delet

Re: [libav-devel] [PATCH 1/4] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Oct 10, 2012 at 11:55:57AM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> > On Wed, Oct 10, 2012 at 11:31:40AM +0100, Måns Rullgård wrote: >> >> Diego Biurrun writes: >> >> > diff --git a/libavutil/inverse.c b/libavcodec/mathops.c >> >> > similarity inde

Re: [libav-devel] [PATCH 1/4] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 11:55:57AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > On Wed, Oct 10, 2012 at 11:31:40AM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > diff --git a/libavutil/inverse.c b/libavcodec/mathops.c > >> > similarity index 79% > >> > rename from libavu

Re: [libav-devel] [PATCH 1/4] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Oct 10, 2012 at 11:31:40AM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> > diff --git a/libavutil/inverse.c b/libavcodec/mathops.c >> > similarity index 79% >> > rename from libavutil/inverse.c >> > rename to libavcodec/mathops.c >> > index 5a5c490..45d0

Re: [libav-devel] [PATCH] avutil: Duplicate ff_log2_tab instead of sharing it across libs

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > On Wed, Oct 10, 2012 at 11:22:00AM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> > On Tue, Oct 09, 2012 at 03:48:39PM +0300, Martin Storsjö wrote: >> >> On Thu, 4 Oct 2012, Diego Biurrun wrote: >> >> >The table is so small that the space gain is not worth the >>

Re: [libav-devel] [PATCH 1/1] arm: call arm-specific rv34dsp init functions under if (ARCH_ARM)

2012-10-10 Thread Måns Rullgård
Janne Grunau writes: > -void ff_rv40dsp_init_neon(RV34DSPContext *c, DSPContext* dsp) > +static void ff_rv40dsp_init_neon(RV34DSPContext *c) > { > c->put_pixels_tab[0][ 1] = ff_put_rv40_qpel16_mc10_neon; > c->put_pixels_tab[0][ 3] = ff_put_rv40_qpel16_mc30_neon; > @@ -136,3 +137,11 @@

Re: [libav-devel] [PATCH 1/4] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 11:31:40AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > diff --git a/libavutil/inverse.c b/libavcodec/mathops.c > > similarity index 79% > > rename from libavutil/inverse.c > > rename to libavcodec/mathops.c > > index 5a5c490..45d06eb 100644 > > --- a/libavutil/i

Re: [libav-devel] [PATCH 1/4] Move avutil tables only used in libavcodec to libavcodec.

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > diff --git a/libavutil/inverse.c b/libavcodec/mathops.c > similarity index 79% > rename from libavutil/inverse.c > rename to libavcodec/mathops.c > index 5a5c490..45d06eb 100644 > --- a/libavutil/inverse.c > +++ b/libavcodec/mathops.c > @@ -1,7 +1,4 @@ > /* > - * Inverse

Re: [libav-devel] [PATCH] avutil: Duplicate ff_log2_tab instead of sharing it across libs

2012-10-10 Thread Diego Biurrun
On Wed, Oct 10, 2012 at 11:22:00AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > On Tue, Oct 09, 2012 at 03:48:39PM +0300, Martin Storsjö wrote: > >> On Thu, 4 Oct 2012, Diego Biurrun wrote: > >> >The table is so small that the space gain is not worth the > >> >performance overhead of cr

Re: [libav-devel] [PATCH] avutil: Duplicate ff_log2_tab instead of sharing it across libs

2012-10-10 Thread Måns Rullgård
Diego Biurrun writes: > On Tue, Oct 09, 2012 at 03:48:39PM +0300, Martin Storsjö wrote: >> On Thu, 4 Oct 2012, Diego Biurrun wrote: >> >The table is so small that the space gain is not worth the >> >performance overhead of cross-library access. >> >--- >> > >> >Now with each duplicated table in a

[libav-devel] [PATCH] avutil: Make ff_log2_tab public and give it an av_ prefix

2012-10-10 Thread Diego Biurrun
--- Alternative patch that makes the table public instead of duplicating it. libavcodec/aacps.c|2 +- libavcodec/tiertexseqv.c |2 +- libavcodec/xsubdec.c |2 +- libavcodec/xsubenc.c |2 +- libavformat/matroskadec.c |4 ++-- libavformat/rtsp.c|2

[libav-devel] [PATCH] avutil: Duplicate ff_log2_tab instead of sharing it across libs

2012-10-10 Thread Diego Biurrun
The table is so small that the space gain is not worth the performance overhead of cross-library access. --- Now dropping an instance into libavformat as well, which also accesses the table directly. libavcodec/Makefile |1 + libavcodec/log2_tab.c |1 + libavformat/Makefile|

Re: [libav-devel] [PATCH] avutil: Duplicate ff_log2_tab instead of sharing it across libs

2012-10-10 Thread Diego Biurrun
On Tue, Oct 09, 2012 at 03:48:39PM +0300, Martin Storsjö wrote: > On Thu, 4 Oct 2012, Diego Biurrun wrote: > >The table is so small that the space gain is not worth the > >performance overhead of cross-library access. > >--- > > > >Now with each duplicated table in a separate file. > > > >libavcode

Re: [libav-devel] [PATCH] build: sanitize linking of tools and test programs

2012-10-10 Thread Martin Storsjö
On Wed, 10 Oct 2012, Mans Rullgard wrote: This makes sure proper linker arguments are used for the tools and test programs when shared libraries are enabled. The tools are linked using the usual -l flag while for test programs the full name of the static library is used. Signed-off-by: Mans Ru