Re: [libav-devel] [PATCH 02/16] atrac3: simplify some loop indexing

2012-10-19 Thread Luca Barbato
On 10/19/2012 05:53 AM, Justin Ruggles wrote: --- libavcodec/atrac3.c | 60 +- 1 files changed, 30 insertions(+), 30 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 03/16] atrac3: use AVCodecContext.channels instead of keeping a private copy

2012-10-19 Thread Luca Barbato
On 10/19/2012 05:53 AM, Justin Ruggles wrote: --- libavcodec/atrac3.c | 41 - 1 files changed, 20 insertions(+), 21 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 04/16] atrac3: move the 'version' field from ATRAC3Context to where it is used

2012-10-19 Thread Luca Barbato
On 10/19/2012 05:53 AM, Justin Ruggles wrote: --- libavcodec/atrac3.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] avcodec: error out on init if a codec with CODEC_CAP_EXPERIMENTAL is requested

2012-10-19 Thread Luca Barbato
On 10/19/2012 06:58 AM, Nathan Caldwell wrote: and strict_std_compliance is not FF_COMPLIANCE_EXPERIMENTAL. This moves the check from avconv to avcodec_open2(). I like it AVERROR_EXPERIMENTAL isn't defined though. lu ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/3] avutil: Add AVERROR_EXPERIMENTAL

2012-10-19 Thread Luca Barbato
On 10/19/2012 06:59 AM, Nathan Caldwell wrote: --- doc/APIchanges |3 +++ libavutil/error.c |1 + libavutil/error.h |1 + libavutil/version.h |2 +- 4 files changed, 6 insertions(+), 1 deletion(-) Looks fine. ___

Re: [libav-devel] [PATCH] ffv1: import ffv1.3 support

2012-10-19 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 08:57:47AM +0200, Luca Barbato wrote: Code mainly written by Carl Eugen Hoyos, Michael Niedermayer, Paul B Mahol. --- Now with fixed encoder as well. (useless rant: it would be nice to have decoder patch separate from encoder and both of them apply to different

Re: [libav-devel] [PATCH] ffv1: import ffv1.3 support

2012-10-19 Thread Luca Barbato
On 10/19/2012 09:36 AM, Kostya Shishkov wrote: (useless rant: it would be nice to have decoder patch separate from encoder and both of them apply to different files) I'll make it less useless... lu - doing the extra mile =P ___ libav-devel mailing

Re: [libav-devel] [PATCH 07/16] atrac3: remove unused ATRAC3Context field, samples_per_channel

2012-10-19 Thread Luca Barbato
On 10/19/2012 05:53 AM, Justin Ruggles wrote: --- libavcodec/atrac3.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) Ok I guess. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 08/16] atrac3: move the 'samples_per_frame' field from ATRAC3Context to where it is used

2012-10-19 Thread Luca Barbato
On 10/19/2012 05:53 AM, Justin Ruggles wrote: --- libavcodec/atrac3.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 05/16] atrac3: move the 'delay' field from ATRAC3Context to where it is used

2012-10-19 Thread Luca Barbato
On 10/19/2012 05:53 AM, Justin Ruggles wrote: --- libavcodec/atrac3.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Martin Storsjö
The output of make fate-list is identical to before. This adds proper dependencies to the last tests that require zlib. --- The iff audio decoder test kept in this file, the iff tests now have proper individual dependencies, ENCDEC used for the two tests that need it. --- tests/fate/video.mak |

[libav-devel] [PATCH] mpeg4videodec: Disable frame multithreading for GMC, its not implemented at all

2012-10-19 Thread Martin Storsjö
From: Michael Niedermayer michae...@gmx.at This fixes race conditions in decoding MPEG-4 GMC files. --- libavcodec/mpegvideo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index d6f7af2..af9e040 100644 ---

Re: [libav-devel] [PATCH 06/16] atrac3: use AVCodecContext.block_align instead of keeping a private copy

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 30 +- 1 files changed, 13 insertions(+), 17 deletions(-) LGTM // Martin ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 09/16] atrac3: remove unused ATRAC3Context field, bit_rate

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index e8c94bb..00ec3c9 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -90,7 +90,6 @@ typedef

Re: [libav-devel] [PATCH 10/16] atrac3: move the 'frame_factor' field from ATRAC3Context to where it is used

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 00ec3c9..1b623f7 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -109,7 +109,6 @@

Re: [libav-devel] [PATCH 11/16] atrac3: separate window initialization from IMDCT initialization

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 1b623f7..6984ecf 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -174,7

Re: [libav-devel] [PATCH] mpeg4videodec: Disable frame multithreading for GMC, its not implemented at all

2012-10-19 Thread Luca Barbato
On 10/19/2012 10:24 AM, Martin Storsjö wrote: From: Michael Niedermayer michae...@gmx.at This fixes race conditions in decoding MPEG-4 GMC files. --- libavcodec/mpegvideo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Looks ok.

Re: [libav-devel] [PATCH 12/16] atrac3: initialize static tables in AVCodec.init_static_data()

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 53 ++- 1 files changed, 27 insertions(+), 26 deletions(-) LGTM // Martin ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 13/16] atrac3: use a half-size MDCT window

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index d15b710..b3e1593 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@

Re: [libav-devel] [PATCH 14/16] atrac3: use sizeof(variable) instead of sizeof(type)

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) LGTM // Martin ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 15/16] atrac3: remove unused ATRAC3Context field, sample_rate

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index c662015..28c72c7 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -90,7 +90,6 @@ typedef

Re: [libav-devel] [PATCH 16/16] atrac3: replace a calculation with FFALIGN()

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 28c72c7..343e31b 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -949,8 +949,7 @@ static

Re: [libav-devel] [PATCH 01/16] atrac3: cosmetics: pretty-printing and renaming

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 1057 +++ libavcodec/atrac3data.h | 98 +++-- 2 files changed, 571 insertions(+), 584 deletions(-) The commit also contains some minor refactorings that could be mentioned in

[libav-devel] ffv1.3 support

2012-10-19 Thread Luca Barbato
As Kostya asked here the proper split between decoder and encoder. I tested it encoding and decoding properly. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 2/3] ffv1: propagate errors

2012-10-19 Thread Luca Barbato
--- libavcodec/ffv1dec.c | 53 ++-- libavcodec/ffv1enc.c | 26 +- 2 files changed, 40 insertions(+), 39 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 6877b78..c05c3a0 100644 ---

Re: [libav-devel] [PATCH 13/16] atrac3: use a half-size MDCT window

2012-10-19 Thread Christophe Gisquet
Hi, 2012/10/19 Justin Ruggles justin.rugg...@gmail.com: -q-fdsp.vector_fmul(output, output, mdct_window, MDCT_SIZE); +q-fdsp.vector_fmul(output, output, mdct_window, 256); +q-dsp.vector_fmul_reverse(output + 256, output + 256, mdct_window, 256); What's the benefit? It looks like

Re: [libav-devel] [PATCH 2/3] ffv1: propagate errors

2012-10-19 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 12:16:34PM +0200, Luca Barbato wrote: --- libavcodec/ffv1dec.c | 53 ++-- libavcodec/ffv1enc.c | 26 +- 2 files changed, 40 insertions(+), 39 deletions(-) diff --git a/libavcodec/ffv1dec.c

Re: [libav-devel] [PATCH 13/16] atrac3: use a half-size MDCT window

2012-10-19 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 12:23:38PM +0200, Christophe Gisquet wrote: Hi, 2012/10/19 Justin Ruggles justin.rugg...@gmail.com: -q-fdsp.vector_fmul(output, output, mdct_window, MDCT_SIZE); +q-fdsp.vector_fmul(output, output, mdct_window, 256); +q-dsp.vector_fmul_reverse(output +

Re: [libav-devel] [PATCH 3/3] ffv1: import ffv1.3

2012-10-19 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 12:16:35PM +0200, Luca Barbato wrote: Code mainly written by Carl Eugen Hoyos, Michael Niedermayer and Paul B Mahol. I don't like log message and customs declaration is not correct. What code is mainly written by them and why they're ordered this way? ---

Re: [libav-devel] [PATCH 13/16] atrac3: use a half-size MDCT window

2012-10-19 Thread Christophe Gisquet
2012/10/19 Kostya Shishkov kostya.shish...@gmail.com: Have you considered memory savings here? Right, mdct_window is now half its original size (1KB less memory). Probably a win performance-wise. -- Christophe ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/2] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 02:43:05AM +0300, Martin Storsjö wrote: --- tests/fate/video.mak | 130 +- 1 file changed, 65 insertions(+), 65 deletions(-) Of all the possible files to work on you pick the one I'm doing? Diego

Re: [libav-devel] [PATCH 2/2] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Diego Biurrun wrote: On Fri, Oct 19, 2012 at 02:43:05AM +0300, Martin Storsjö wrote: --- tests/fate/video.mak | 130 +- 1 file changed, 65 insertions(+), 65 deletions(-) Of all the possible files to work on you pick the

Re: [libav-devel] [PATCH 3/3] ffv1: import ffv1.3

2012-10-19 Thread Luca Barbato
On 10/19/2012 12:30 PM, Kostya Shishkov wrote: I don't like log message and customs declaration is not correct. What code is mainly written by them and why they're ordered this way? Alphabetical, another run and I could drop this line since you are making me rewrite it little by little =P lu

Re: [libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: The output of make fate-list is identical to before. This adds proper dependencies to the last tests that require zlib. --- The iff audio decoder test kept in this file, the iff tests now have proper individual dependencies, ENCDEC used for the two

Re: [libav-devel] [PATCH] mpeg4videodec: Disable frame multithreading for GMC, its not implemented at all

2012-10-19 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: From: Michael Niedermayer michae...@gmx.at This fixes race conditions in decoding MPEG-4 GMC files. I don't think race condition is the proper term for what goes wrong here. -- Måns Rullgård m...@mansr.com

Re: [libav-devel] [PATCH] mpeg4videodec: Disable frame multithreading for GMC, its not implemented at all

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: From: Michael Niedermayer michae...@gmx.at This fixes race conditions in decoding MPEG-4 GMC files. I don't think race condition is the proper term for what goes wrong here. Removed this line locally, will

Re: [libav-devel] [PATCH] ffv1: import ffv1.3 support

2012-10-19 Thread Peter B.
Sorry, but I've slightly lost track... Which patches must now be applied to which code-tree in order to be able to test ffv1.3 support? I've tried applying the following patches to libav's git-head: 1) import ffv1.3 support (Couldn't find any patch labelled 1/3) 2) [PATCH 2/3] ffv1:

Re: [libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 11:12:52AM +0300, Martin Storsjö wrote: The output of make fate-list is identical to before. This adds proper dependencies to the last tests that require zlib. That's metainformation that has - IMO - no place in the log message. --- The iff audio decoder test kept

Re: [libav-devel] [PATCH] ffv1: import ffv1.3 support

2012-10-19 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 02:23:44PM +0200, Peter B. wrote: Sorry, but I've slightly lost track... Which patches must now be applied to which code-tree in order to be able to test ffv1.3 support? I've tried applying the following patches to libav's git-head: 1) import ffv1.3 support

Re: [libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Fri, Oct 19, 2012 at 11:12:52AM +0300, Martin Storsjö wrote: The output of make fate-list is identical to before. This adds proper dependencies to the last tests that require zlib. That's metainformation that has - IMO - no place in the log

[libav-devel] [PATCH] ARM: fix overreads in neon h264 chroma mc

2012-10-19 Thread Mans Rullgard
The loops were reading ahead one line, which could end up outside the buffer for reference blocks at the edge of the picture. Removing this readahead has no measurable performance impact. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/arm/h264cmc_neon.S | 86

[libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Martin Storsjö
The output of make fate-list is identical to before. --- Added individual demuxer deps for the cinepak tests, rechecked the rest of the multi-test-deps to make sure they were correct. --- tests/fate/video.mak | 146 +- 1 file changed, 73

Re: [libav-devel] [PATCH] ffv1: import ffv1.3 support

2012-10-19 Thread Luca Barbato
On 10/19/2012 02:23 PM, Peter B. wrote: Sorry, but I've slightly lost track... Which patches must now be applied to which code-tree in order to be able to test ffv1.3 support? This is a monolithic ffv1.3 patch that applies to the current tree. Since in review had been requested the ffv1

Re: [libav-devel] ffv1.3 support

2012-10-19 Thread Luca Barbato
On 10/19/2012 12:16 PM, Luca Barbato wrote: As Kostya asked here the proper split between decoder and encoder. I tested it encoding and decoding properly. Comments addressed here https://github.com/lu-zero/libav/tree/ffv1 to not burden the ml with large patches. lu

Re: [libav-devel] [PATCH 1/3] ffv1: split decoder and encoder

2012-10-19 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 12:16:33PM +0200, Luca Barbato wrote: --- libavcodec/Makefile |4 +- libavcodec/ffv1.c| 1612 +- libavcodec/ffv1.h| 184 ++ libavcodec/ffv1dec.c | 636 libavcodec/ffv1enc.c |

Re: [libav-devel] [PATCH] ARM: fix overreads in neon h264 chroma mc

2012-10-19 Thread Kostya Shishkov
On Fri, Oct 19, 2012 at 01:39:17PM +0100, Mans Rullgard wrote: The loops were reading ahead one line, which could end up outside the buffer for reference blocks at the edge of the picture. Removing this readahead has no measurable performance impact. Signed-off-by: Mans Rullgard

Re: [libav-devel] [PATCH 1/3] ffv1: split decoder and encoder

2012-10-19 Thread Luca Barbato
On 10/19/2012 03:29 PM, Kostya Shishkov wrote: -static const int8_t quant5_10bit[256] = { +const int8_t quant5_10bit[256] = { don't we have to prefix such names? We hide everything not matching av_/avpriv_ lu ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/3] ffv1: split decoder and encoder

2012-10-19 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 10/19/2012 03:29 PM, Kostya Shishkov wrote: -static const int8_t quant5_10bit[256] = { +const int8_t quant5_10bit[256] = { don't we have to prefix such names? We hide everything not matching av_/avpriv_ That only works in shared libs. Add a

[libav-devel] [PATCH] build: Drop OBJS declaration for non-existing PCM_DVD encoder

2012-10-19 Thread Diego Biurrun
--- libavcodec/Makefile |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index a63e2ba..e1787dd 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -433,7 +433,6 @@ OBJS-$(CONFIG_PCM_ALAW_DECODER) += pcm.o

Re: [libav-devel] [PATCH] build: Drop OBJS declaration for non-existing PCM_DVD encoder

2012-10-19 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: --- libavcodec/Makefile |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index a63e2ba..e1787dd 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -433,7 +433,6 @@

Re: [libav-devel] [PATCH 09/15] swscale: avoid pointless use of compound literals

2012-10-19 Thread Kostya Shishkov
On Thu, Oct 18, 2012 at 03:46:19PM +0200, Luca Barbato wrote: On 10/15/2012 05:11 AM, Mans Rullgard wrote: Some compilers (e.g. old gcc) have trouble with these. Signed-off-by: Mans Rullgard m...@mansr.com --- libswscale/swscale_unscaled.c | 17 + 1 file changed, 9

Re: [libav-devel] [PATCH 2/3] ac3dec: make downmix() take array of pointers to channel data

2012-10-19 Thread Kostya Shishkov
On Thu, Sep 13, 2012 at 08:22:02PM +0100, Mans Rullgard wrote: --- libavcodec/ac3dec.c | 14 +++-- libavcodec/ac3dec.h | 4 +++ libavcodec/ac3dsp.c | 2 +- libavcodec/ac3dsp.h | 2 +- libavcodec/x86/ac3dsp_init.c | 70

Re: [libav-devel] ffv1.3 support

2012-10-19 Thread Peter B.
I've compiled your github libav version including ffv1.3 and it seems that slicecrc is not yet implemented, correct? If you could quickly tell me which features/colorspaces should be working in your implementation, I could run my testsuite and report any findings. Thanks, Pb

Re: [libav-devel] [PATCH] build: add rule to generate preprocessed source files

2012-10-19 Thread Diego Biurrun
On Sat, Oct 13, 2012 at 12:17:28PM +0100, Mans Rullgard wrote: --- a/library.mak +++ b/library.mak @@ -15,12 +15,16 @@ $(SUBDIR)%-test.o: $(SUBDIR)%-test.c $(SUBDIR)%-test.o: $(SUBDIR)%.c $(COMPILE_C) +$(SUBDIR)%-test.i: $(SUBDIR)%.c + $(CC) $(CCFLAGS) $(CC_E) $ We have two

Re: [libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 03:41:09PM +0300, Martin Storsjö wrote: The output of make fate-list is identical to before. Thanks for mentioning it, but it's silly in a log message IMO. --- Added individual demuxer deps for the cinepak tests, rechecked the rest of the multi-test-deps to make sure

Re: [libav-devel] [PATCH 7/8] fate-vc1: add dependencies

2012-10-19 Thread Diego Biurrun
On Thu, Oct 18, 2012 at 03:25:50AM +0100, Mans Rullgard wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- tests/fate/microsoft.mak | 16 1 file changed, 8 insertions(+), 8 deletions(-) OK Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH] configure: Disable Snow decoder and encoder by default

2012-10-19 Thread Diego Biurrun
On Thu, Oct 18, 2012 at 10:11:50AM +0200, Diego Biurrun wrote: On Thu, Oct 18, 2012 at 12:41:59AM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: Snow has serious unfixed bugs and no real-world use. --- configure |2 ++ 1 files changed, 2 insertions(+), 0

Re: [libav-devel] [PATCH 16/16] atrac3: replace a calculation with FFALIGN()

2012-10-19 Thread Justin Ruggles
On 10/19/2012 04:42 AM, Martin Storsjö wrote: On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 28c72c7..343e31b 100644 --- a/libavcodec/atrac3.c +++

[libav-devel] [PATCH] fate: Add dependencies for WMA and WavPack tests

2012-10-19 Thread Diego Biurrun
--- tests/fate/wavpack.mak |2 +- tests/fate/wma.mak | 16 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/fate/wavpack.mak b/tests/fate/wavpack.mak index b615c9e..afc84d0 100644 --- a/tests/fate/wavpack.mak +++ b/tests/fate/wavpack.mak @@ -86,5

Re: [libav-devel] [PATCH 2/5] sp5xdec: fix off by 1 error causing a crash

2012-10-19 Thread Reinhard Tartler
On Thu, Oct 18, 2012 at 12:46 AM, Luca Barbato lu_z...@gentoo.org wrote: On 10/17/2012 11:31 PM, Reinhard Tartler wrote: From: Michael Niedermayer michae...@gmx.at Fixes Ticket1633 Found-by: Piotr Bandurski ami_st...@o2.pl Signed-off-by: Michael Niedermayer michae...@gmx.at (cherry picked

Re: [libav-devel] [PATCH 5/5] bmv_videodec: fix out of array read

2012-10-19 Thread Reinhard Tartler
On Thu, Oct 18, 2012 at 12:10 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 10/17/2012 05:31 PM, Reinhard Tartler wrote: From: Michael Niedermayer michae...@gmx.at Fixes Ticket1373 Signed-off-by: Michael Niedermayer michae...@gmx.at (cherry picked from commit

Re: [libav-devel] [PATCH 4/5] faxcompr: fix out of array read

2012-10-19 Thread Reinhard Tartler
On Thu, Oct 18, 2012 at 11:52 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Thu, Oct 18, 2012 at 10:49:41AM +0100, Måns Rullgård wrote: Kostya Shishkov kostya.shish...@gmail.com writes: On Wed, Oct 17, 2012 at 11:31:12PM +0200, Reinhard Tartler wrote: From: Michael Niedermayer

[libav-devel] [PATCH 2/2] svq3: cosmetics: Drop useless parentheses

2012-10-19 Thread Diego Biurrun
--- libavcodec/svq3.c | 122 ++-- 1 files changed, 61 insertions(+), 61 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 4f10e83..70604ff 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -164,10 +164,10 @@ void

Re: [libav-devel] [PATCH 3/5] escape124: fix integer overflow leading to excessive memory allocation

2012-10-19 Thread Reinhard Tartler
On Wed, Oct 17, 2012 at 11:59 PM, Måns Rullgård m...@mansr.com wrote: Reinhard Tartler siret...@gmail.com writes: On Wed, Oct 17, 2012 at 11:39 PM, Måns Rullgård m...@mansr.com wrote: Reinhard Tartler siret...@tauware.de writes: From: Michael Niedermayer michae...@gmx.at Fixes Ticket1629

Re: [libav-devel] [PATCH 1/5] mpegaudio_parser: reset state to prevent it to be random

2012-10-19 Thread Reinhard Tartler
On Wed, Oct 17, 2012 at 11:46 PM, Reinhard Tartler siret...@gmail.com wrote: On Wed, Oct 17, 2012 at 11:32 PM, Måns Rullgård m...@mansr.com wrote: Reinhard Tartler siret...@tauware.de writes: From: Michael Niedermayer michae...@gmx.at Fixes Ticket1718 Signed-off-by: Michael Niedermayer

Re: [libav-devel] [PATCH 16/16] atrac3: replace a calculation with FFALIGN()

2012-10-19 Thread Justin Ruggles
On 10/19/2012 04:42 AM, Martin Storsjö wrote: On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 28c72c7..343e31b 100644 --- a/libavcodec/atrac3.c +++

Re: [libav-devel] [PATCH] configure: separate option-arguments from options to POSIX commands

2012-10-19 Thread Diego Biurrun
On Sat, Oct 13, 2012 at 01:47:16PM +0300, Martin Storsjö wrote: On Sat, 13 Oct 2012, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: On Sat, 13 Oct 2012, Mans Rullgard wrote: POSIX says this about option syntax: If the SYNOPSIS of a standard utility shows an option with a

Re: [libav-devel] [PATCH 3/5] escape124: fix integer overflow leading to excessive memory allocation

2012-10-19 Thread Måns Rullgård
Reinhard Tartler siret...@gmail.com writes: Would the following do then? diff --git a/libavcodec/escape124.c b/libavcodec/escape124.c index 40224fb..5d050dc 100644 --- a/libavcodec/escape124.c +++ b/libavcodec/escape124.c @@ -48,7 +48,7 @@ typedef struct Escape124Context { CodeBook

Re: [libav-devel] [PATCH 14/15] build: allow targets to specify extra objects to link with executables

2012-10-19 Thread Diego Biurrun
On Mon, Oct 15, 2012 at 04:11:27AM +0100, Mans Rullgard wrote: This allows targets to include special objects when linking executables without including them in (shared) libraries. Signed-off-by: Mans Rullgard m...@mansr.com --- Makefile| 8 configure | 1 + library.mak |

Re: [libav-devel] [PATCH 2/2] avserver: remove daemon mode

2012-10-19 Thread Diego Biurrun
On Wed, Apr 25, 2012 at 02:08:54PM +0100, Mans Rullgard wrote: This code spews a multitude of warnings with glibc (unchecked return values), some of them possibly warranted. Furthermore, the deamonisation is not suitable for use with typical startup scripts as it does not provide the PID of

[libav-devel] [PATCH] configure: Group math functions into a separate variable

2012-10-19 Thread Diego Biurrun
This avoids some duplication when listing and testing for the functions. --- configure | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/configure b/configure index f892bfe..996c716 100755 --- a/configure +++

Re: [libav-devel] [PATCH] configure: Group math functions into a separate variable

2012-10-19 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: This avoids some duplication when listing and testing for the functions. --- configure | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) Good idea, but it conflicts with some of my

Re: [libav-devel] [PATCH] vorbisenc: simplify floor_classes[] table

2012-10-19 Thread Diego Biurrun
On Fri, Jul 22, 2011 at 10:24:58AM +0100, Måns Rullgård wrote: Mans Rullgard m...@mansr.com writes: This avoids an indirection in the table. Data size is slightly smaller on 64-bit systems, 8 bytes larger on 32-bit. --- a/libavcodec/vorbis_enc_data.h +++ b/libavcodec/vorbis_enc_data.h

[libav-devel] [PATCH 1/2] x86: Require an assembler able to cope with AVX instructions

2012-10-19 Thread Diego Biurrun
All modern assemblers have this capability. Older ones that do not produce code that crashes at runtime, so it's better to error out during the build process instead. --- configure |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure b/configure index

[libav-devel] [PATCH 2/2] build: Drop AVX assembly ifdefs

2012-10-19 Thread Diego Biurrun
An assembler able to cope with AVX instructions is now required. --- libavcodec/x86/dct32.asm|2 - libavcodec/x86/dsputil.asm |6 - libavcodec/x86/fft.asm |9 libavcodec/x86/h264_chromamc_10bit.asm |4 ---

Re: [libav-devel] [PATCH 16/16] atrac3: replace a calculation with FFALIGN()

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Justin Ruggles wrote: On 10/19/2012 04:42 AM, Martin Storsjö wrote: On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index

[libav-devel] FATE dependencies

2012-10-19 Thread Diego Biurrun
Good news everyone! Fine-grained dependency infrastructure for FATE tests has arrived. So all we need to do now is mark up all the FATE tests with their dependencies. Volunteers are welcome to help in the effort. It's not particularly difficult for most tests: Just run avprobe on the sample in

Re: [libav-devel] [PATCH] configure: Group math functions into a separate variable

2012-10-19 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 06:01:07PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: This avoids some duplication when listing and testing for the functions. --- configure | 55 +++ 1 files changed, 23

Re: [libav-devel] [PATCH] vorbisenc: simplify floor_classes[] table

2012-10-19 Thread Luca Barbato
On 07/22/2011 11:24 AM, Måns Rullgård wrote: Mans Rullgard m...@mansr.com writes: This avoids an indirection in the table. Data size is slightly smaller on 64-bit systems, 8 bytes larger on 32-bit. Signed-off-by: Mans Rullgard m...@mansr.com --- libavcodec/vorbis_enc_data.h | 12

Re: [libav-devel] [PATCH 1/5] mpegaudio_parser: reset state to prevent it to be random

2012-10-19 Thread Luca Barbato
On 10/19/2012 06:42 PM, Reinhard Tartler wrote: On Wed, Oct 17, 2012 at 11:46 PM, Reinhard Tartler siret...@gmail.com wrote: On Wed, Oct 17, 2012 at 11:32 PM, Måns Rullgård m...@mansr.com wrote: Reinhard Tartler siret...@tauware.de writes: From: Michael Niedermayer michae...@gmx.at Fixes

Re: [libav-devel] [PATCH 2/5] avutil/lzo: KR formatting cosmetics

2012-10-19 Thread Kostya Shishkov
On Thu, Oct 18, 2012 at 07:50:28PM +0200, Diego Biurrun wrote: --- libavutil/lzo.c | 96 ++ libavutil/lzo.h |2 +- 2 files changed, 54 insertions(+), 44 deletions(-) LGTM ___ libav-devel

Re: [libav-devel] [PATCH 3/5] avutil/mem: KR formatting cosmetics

2012-10-19 Thread Kostya Shishkov
On Thu, Oct 18, 2012 at 07:50:29PM +0200, Diego Biurrun wrote: --- libavutil/mem.c | 77 --- libavutil/mem.h |4 +- 2 files changed, 41 insertions(+), 40 deletions(-) LGTM ___ libav-devel

Re: [libav-devel] ffv1.3 support

2012-10-19 Thread Luca Barbato
On 10/19/2012 04:43 PM, Peter B. wrote: I've compiled your github libav version including ffv1.3 and it seems that slicecrc is not yet implemented, correct? If you could quickly tell me which features/colorspaces should be working in your implementation, I could run my testsuite and report

[libav-devel] [PATCH] lavc: remove stats_out from the options table.

2012-10-19 Thread Anton Khirnov
Since it is declared as a string AVOption, the generic freeing code attempts to free it on codec close. Some codecs might have already freed it elsewhere (or didn't even allocate it with av_malloc() in the first place), so this might lead to an invalid free. There is no point in having this field

[libav-devel] ffv1 improvements

2012-10-19 Thread Luca Barbato
Another round addressing hopefully all the comments. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 2/3] ffv1: propagate errors

2012-10-19 Thread Luca Barbato
--- libavcodec/ffv1dec.c | 53 ++-- libavcodec/ffv1enc.c | 26 +- 2 files changed, 40 insertions(+), 39 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 6877b78..f8c232f 100644 ---

[libav-devel] [PATCH] gitignore: ignore files created during a msvc build.

2012-10-19 Thread Hendrik Leppkes
exp files are created in every build and contain export information of the libraries. Both pdb and ilk are created during debug builds, and contain linking and debug information used by MSVC. --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index

Re: [libav-devel] [PATCH] gitignore: ignore files created during a msvc build.

2012-10-19 Thread Luca Barbato
On 10/19/12 10:07 PM, Hendrik Leppkes wrote: exp files are created in every build and contain export information of the libraries. Both pdb and ilk are created during debug builds, and contain linking and debug information used by MSVC. --- .gitignore | 3 +++ 1 file changed, 3

Re: [libav-devel] [PATCH] gitignore: ignore files created during a msvc build.

2012-10-19 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 10:11:16PM +0200, Luca Barbato wrote: On 10/19/12 10:07 PM, Hendrik Leppkes wrote: exp files are created in every build and contain export information of the libraries. Both pdb and ilk are created during debug builds, and contain linking and debug information used by

Re: [libav-devel] [PATCH 1/8] fate: add a dependency helper macro

2012-10-19 Thread Diego Biurrun
On Thu, Oct 18, 2012 at 03:25:44AM +0100, Mans Rullgard wrote: --- a/tests/Makefile +++ b/tests/Makefile @@ -33,6 +33,8 @@ ENCDEC2 = $(call ALLYES, $(firstword $(1))_ENCODER $(lastword $(1))_DECODER \ $(firstword $(2))_ENCODER $(lastword $(2))_DECODER \

Re: [libav-devel] [PATCH] configure: Group math functions into a separate variable

2012-10-19 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Fri, Oct 19, 2012 at 06:01:07PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: This avoids some duplication when listing and testing for the functions. --- configure | 55

Re: [libav-devel] [PATCH] vorbisenc: simplify floor_classes[] table

2012-10-19 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 07/22/2011 11:24 AM, Måns Rullgård wrote: Mans Rullgard m...@mansr.com writes: This avoids an indirection in the table. Data size is slightly smaller on 64-bit systems, 8 bytes larger on 32-bit. Signed-off-by: Mans Rullgard m...@mansr.com ---

Re: [libav-devel] [PATCH 2/2] fate: Add proper dependencies in qt.mak

2012-10-19 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Fri, Oct 19, 2012 at 01:53:34AM +0300, Martin Storsjö wrote: --- a/tests/fate/qt.mak +++ b/tests/fate/qt.mak @@ -1,50 +1,50 @@ -FATE_SAMPLES_AVCONV += fate-qdm2 +FATE_SAMPLES_AVCONV-$(call DEMDEC, MOV, QDM2) += fate-qdm2 fate-qdm2: CMD = pcm -i

Re: [libav-devel] [PATCH 1/8] fate: add a dependency helper macro

2012-10-19 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Thu, Oct 18, 2012 at 03:25:44AM +0100, Mans Rullgard wrote: --- a/tests/Makefile +++ b/tests/Makefile @@ -33,6 +33,8 @@ ENCDEC2 = $(call ALLYES, $(firstword $(1))_ENCODER $(lastword $(1))_DECODER \ $(firstword

Re: [libav-devel] [PATCH 1/2] x86: Require an assembler able to cope with AVX instructions

2012-10-19 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: All modern assemblers have this capability. Older ones that do not produce code that crashes at runtime, so it's better to error out during the build process instead. --- configure |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff

[libav-devel] [PATCH 2/2] avutil: reintroduce ff_sqrt_tab to restore ABI compatibility

2012-10-19 Thread Reinhard Tartler
Earlier versions of for instance of libavcodec expect this symbol to be present in libavutil. It can be removed at the next major bump. --- libavutil/mathematics.c | 13 + libavutil/version.h |3 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/mathematics.c

[libav-devel] Restore ABI compatibility in libavutil

2012-10-19 Thread Reinhard Tartler
These two patches unbreak at least avprobe and friends from the previous release. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 1/2] avutil: make some tables visible again

2012-10-19 Thread Reinhard Tartler
These tables are used for instance by older versions of libavcodec and need to remain visible until the next SONAME bump --- libavutil/libavutil.v |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v index e9f04cb..c955347 100644 ---

Re: [libav-devel] [PATCH 1/8] fate: add a dependency helper macro

2012-10-19 Thread Diego Biurrun
On Fri, Oct 19, 2012 at 10:28:30PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Thu, Oct 18, 2012 at 03:25:44AM +0100, Mans Rullgard wrote: --- a/tests/Makefile +++ b/tests/Makefile @@ -33,6 +33,8 @@ ENCDEC2 = $(call ALLYES, $(firstword $(1))_ENCODER $(lastword

Re: [libav-devel] [PATCH 15/15] build: Plan 9 support

2012-10-19 Thread Diego Biurrun
On Mon, Oct 15, 2012 at 04:11:28AM +0100, Mans Rullgard wrote: --- /dev/null +++ b/compat/plan9/main.c @@ -0,0 +1,16 @@ +int plan9_main(int argc, char **argv); + +#undef main +int main(int argc, char **argv) +{ +/* The setfcr() function in lib9 is broken, must use asm. */ +#ifdef

  1   2   >