Re: [libav-devel] [PATCH] rtmpprtoo: Use av_strlcat instead of strncat

2012-11-05 Thread Kostya Shishkov
On Mon, Nov 05, 2012 at 11:13:33AM +0200, Martin Storsjö wrote: --- libavformat/rtmpproto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 3ab2e57..8924fb3 100644 --- a/libavformat/rtmpproto.c +++

Re: [libav-devel] [PATCH] rtmpprtoo: Use av_strlcat instead of strncat

2012-11-05 Thread Martin Storsjö
On Mon, 5 Nov 2012, Kostya Shishkov wrote: On Mon, Nov 05, 2012 at 11:13:33AM +0200, Martin Storsjö wrote: --- libavformat/rtmpproto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 3ab2e57..8924fb3 100644 ---

Re: [libav-devel] [PATCH] rtmpprtoo: Use av_strlcat instead of strncat

2012-11-05 Thread Kostya Shishkov
On Mon, Nov 05, 2012 at 12:02:41PM +0200, Martin Storsjö wrote: On Mon, 5 Nov 2012, Kostya Shishkov wrote: On Mon, Nov 05, 2012 at 11:13:33AM +0200, Martin Storsjö wrote: --- libavformat/rtmpproto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH] rtmpprtoo: Use av_strlcat instead of strncat

2012-11-05 Thread Luca Barbato
On 11/5/12 10:13 AM, Martin Storsjö wrote: --- libavformat/rtmpproto.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) beside the typo looks ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 27/45] x86: vc1dsp: port to cpuflags

2012-11-05 Thread Diego Biurrun
On Fri, Nov 02, 2012 at 03:40:02PM +0100, Diego Biurrun wrote: On Wed, Aug 01, 2012 at 12:17:51AM +0200, Diego Biurrun wrote: --- libavcodec/x86/vc1dsp_yasm.asm | 75 --- 1 files changed, 38 insertions(+), 37 deletions(-) .. ping .. (this is

Re: [libav-devel] [PATCH] build: The A64 muxer depends on rawenc.o for ff_raw_write_packet()

2012-11-05 Thread Diego Biurrun
On Fri, Nov 02, 2012 at 11:37:35PM +0100, Diego Biurrun wrote: --- libavformat/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) OKed by Kostya on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] doc: git-howto: Leave reviewers time to react before pushing patches

2012-11-05 Thread Diego Biurrun
On Thu, Oct 25, 2012 at 08:28:36PM +0200, Diego Biurrun wrote: --- doc/git-howto.texi |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) This received a LGTM from Kostya on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] dirac: dwt and dsp extra functions

2012-11-05 Thread Diego Biurrun
On Sat, Nov 03, 2012 at 10:14:05PM +0100, Jordi Ortiz wrote: --- /dev/null +++ b/libavcodec/dirac_dwt.c @@ -0,0 +1,614 @@ + +static void vertical_compose53iL0(IDWTELEM *b0, IDWTELEM *b1, IDWTELEM *b2, + int width) indentation +static void

Re: [libav-devel] [PATCH] dsputil: make put/avg_pixels_l2/4_8 public

2012-11-05 Thread Diego Biurrun
On Sat, Nov 03, 2012 at 10:06:20PM +0100, Jordi Ortiz wrote: These modifications are (imho) the minimal needed for dirac. --- libavcodec/dsputil.c |8 libavcodec/dsputil.h |6 ++ 2 files changed, 14 insertions(+) Why is this comment part of the log message? Use

[libav-devel] [PATCH 8/9] FATE: rename FLAC tests from flac-* to flac-16-*

2012-11-05 Thread Justin Ruggles
This will distinguish FLAC 16-bit tests from FLAC tests with other bit depths. --- tests/fate/flac.mak | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak index dc49928..772ed3e 100644 ---

[libav-devel] [PATCH 9/9] FATE: add a 24-bit FLAC encoding test

2012-11-05 Thread Justin Ruggles
--- tests/fate/flac.mak |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak index 772ed3e..022be7a 100644 --- a/tests/fate/flac.mak +++ b/tests/fate/flac.mak @@ -5,6 +5,7 @@ FATE_FLAC += fate-flac-16-chmode-indep

Re: [libav-devel] [PATCH] x86inc: Set program_name and cpuflags_3dnowext outside of x86inc.asm

2012-11-05 Thread Loren Merritt
On Sat, 3 Nov 2012, Diego Biurrun wrote: On Sat, Nov 03, 2012 at 06:13:31AM +, Loren Merritt wrote: On Fri, 2 Nov 2012, Diego Biurrun wrote: This reduces the local difference to the x264 upstream version. --- Now also sets cpuflags_3dnowext locally, further reducing the difference.

Re: [libav-devel] [PATCH] x86: h264qpel: Only define mmxext QPEL functions if H264QPEL is enabled

2012-11-05 Thread Diego Biurrun
On Fri, Nov 02, 2012 at 06:26:26PM +0100, Diego Biurrun wrote: This fixes compilation with --disable-everything and components enabled. --- libavcodec/x86/h264_qpel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This receive a probably OK from Kostya on IRC. Diego

Re: [libav-devel] [PATCH 8/9] FATE: rename FLAC tests from flac-* to flac-16-*

2012-11-05 Thread Diego Biurrun
On Mon, Nov 05, 2012 at 12:50:50PM -0500, Justin Ruggles wrote: This will distinguish FLAC 16-bit tests from FLAC tests with other bit depths. --- tests/fate/flac.mak | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) OK --- a/tests/fate/flac.mak +++

Re: [libav-devel] [PATCH] fate: aac: Place LATM tests and general AAC tests in different groups

2012-11-05 Thread Janne Grunau
On 2012-10-22 17:51:35 +0200, Diego Biurrun wrote: --- tests/fate/aac.mak | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 9d52dae..0368798 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/aac.mak @@

Re: [libav-devel] [PATCH 9/9] FATE: add a 24-bit FLAC encoding test

2012-11-05 Thread Diego Biurrun
On Mon, Nov 05, 2012 at 12:51:04PM -0500, Justin Ruggles wrote: --- a/tests/fate/flac.mak +++ b/tests/fate/flac.mak @@ -5,6 +5,7 @@ FATE_FLAC += fate-flac-16-chmode-indep \ fate-flac-16-fixed \

Re: [libav-devel] [PATCH 11/12] fate: aac: cosmetics: Group AAC LATM tests together

2012-11-05 Thread Janne Grunau
On 2012-10-20 18:54:03 +0200, Diego Biurrun wrote: --- tests/fate/aac.mak | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 3b2d431..8c132d5 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/aac.mak @@

Re: [libav-devel] [PATCH 04/12] fate: atrac: Place atrac1 and atrac3 tests in different groups

2012-11-05 Thread Janne Grunau
On 2012-10-20 18:53:56 +0200, Diego Biurrun wrote: --- Separate atrac3 target added for convenience. tests/fate/atrac.mak | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index 08a6b25..fde4647 100644 ---

Re: [libav-devel] [PATCH] fate: Add dependencies for aac, alac, amrnb, amrwb, atrac tests

2012-11-05 Thread Janne Grunau
On 2012-10-22 17:50:40 +0200, Diego Biurrun wrote: --- tests/fate/aac.mak | 15 +-- tests/fate/alac.mak |2 +- tests/fate/amrnb.mak |2 +- tests/fate/amrwb.mak |2 +- tests/fate/atrac.mak | 12 +++- 5 files changed, 19 insertions(+), 14 deletions(-)

Re: [libav-devel] [PATCH 9/9] FATE: add a 24-bit FLAC encoding test

2012-11-05 Thread Justin Ruggles
On 11/05/2012 01:23 PM, Diego Biurrun wrote: On Mon, Nov 05, 2012 at 12:51:04PM -0500, Justin Ruggles wrote: --- a/tests/fate/flac.mak +++ b/tests/fate/flac.mak @@ -5,6 +5,7 @@ FATE_FLAC += fate-flac-16-chmode-indep \ fate-flac-16-fixed

[libav-devel] [PATCH] x86: h264: Remove 3dnow QPEL code

2012-11-05 Thread Diego Biurrun
From: Daniel Kang daniel.d.k...@gmail.com The only CPUs that have 3dnow and don't have mmxext are 12 years old. Moreover, AMD has dropped 3dnow extensions from newer CPUs. Signed-off-by: Diego Biurrun di...@biurrun.de --- Now skips more functions that are unused with 3dnow, plus drop some no

Re: [libav-devel] [PATCH 9/9] FATE: add a 24-bit FLAC encoding test

2012-11-05 Thread Diego Biurrun
On Mon, Nov 05, 2012 at 01:43:28PM -0500, Justin Ruggles wrote: On 11/05/2012 01:23 PM, Diego Biurrun wrote: On Mon, Nov 05, 2012 at 12:51:04PM -0500, Justin Ruggles wrote: --- a/tests/fate/flac.mak +++ b/tests/fate/flac.mak @@ -5,6 +5,7 @@ FATE_FLAC += fate-flac-16-chmode-indep

[libav-devel] [PATCH] x86: h264_intrapred: port to cpuflags

2012-11-05 Thread Diego Biurrun
--- Now with slightly reworked pred16.16_vertical8() as requested by Justin. libavcodec/x86/h264_intrapred.asm | 259 +++-- 1 files changed, 135 insertions(+), 124 deletions(-) diff --git a/libavcodec/x86/h264_intrapred.asm b/libavcodec/x86/h264_intrapred.asm

[libav-devel] [PATCH] fate: atrac: Place atrac1 and atrac3 tests in different groups

2012-11-05 Thread Diego Biurrun
--- Now with FATE_ATRAC_ALL variable as requested by Janne. tests/fate/atrac.mak | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index 08a6b25..39b788a 100644 --- a/tests/fate/atrac.mak +++

[libav-devel] [PATCH] fate: Add dependencies for aac, alac, amrnb, amrwb, atrac tests

2012-11-05 Thread Diego Biurrun
--- Fixed dependency for raw AAC test as pointed out by Janne. tests/fate/aac.mak | 11 --- tests/fate/alac.mak |2 +- tests/fate/amrnb.mak |2 +- tests/fate/amrwb.mak |2 +- tests/fate/atrac.mak |8 +--- 5 files changed, 16 insertions(+), 9 deletions(-) diff

[libav-devel] [PATCH] add 24-bit FLAC encoding to Changelog

2012-11-05 Thread Justin Ruggles
--- Changelog |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Changelog b/Changelog index e2c4273..f0a3814 100644 --- a/Changelog +++ b/Changelog @@ -58,6 +58,7 @@ version 9_beta1: - Opus decoder and encoder using libopus - remove -same_quant, it hasn't worked for years

[libav-devel] [PATCH] add 24-bit FLAC encoding to Changelog

2012-11-05 Thread Justin Ruggles
--- This time in the right place... Changelog |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Changelog b/Changelog index e2c4273..95a507f 100644 --- a/Changelog +++ b/Changelog @@ -5,6 +5,7 @@ version next: - metadata (INFO tag) support in WAV muxer - support for

[libav-devel] [PATCH] x86: h264_qpel: sign-extend stride argument in put_pixels16_sse2()

2012-11-05 Thread Diego Biurrun
--- This fixes the crash in fate-vp5 with the QPEL code converted to YASM. I'm sending this separately to not spam everybody with 100+kB patches. The patch is meant to be squashed into the QPEL yasmification. Possibly switching over more code to use ptrdiff_t for stride parameters is a better

Re: [libav-devel] [PATCH] x86: h264_qpel: sign-extend stride argument in put_pixels16_sse2()

2012-11-05 Thread Ronald S. Bultje
Hi, On Mon, Nov 5, 2012 at 1:22 PM, Diego Biurrun di...@biurrun.de wrote: --- This fixes the crash in fate-vp5 with the QPEL code converted to YASM. I'm sending this separately to not spam everybody with 100+kB patches. The patch is meant to be squashed into the QPEL yasmification. ; void

Re: [libav-devel] [PATCH] x86: h264_qpel: sign-extend stride argument in put_pixels16_sse2()

2012-11-05 Thread Diego Biurrun
On Mon, Nov 05, 2012 at 01:41:42PM -0800, Ronald S. Bultje wrote: On Mon, Nov 5, 2012 at 1:22 PM, Diego Biurrun di...@biurrun.de wrote: --- This fixes the crash in fate-vp5 with the QPEL code converted to YASM. I'm sending this separately to not spam everybody with 100+kB patches. The

Re: [libav-devel] [PATCH] x86: h264: Convert 8-bit QPEL inline assembly to YASM

2012-11-05 Thread Ronald S. Bultje
Hi, On Mon, Nov 5, 2012 at 10:48 AM, Diego Biurrun di...@biurrun.de wrote: +%macro QPEL8_H_LOWPASS_OP 1 +cglobal %1_h264_qpel8_h_lowpass, 4,5 ; dst, src, dstStride, srcStride +mov r4d, 8 Each and every single one of these needs a stride sign extension like you did in dsputil.asm.

Re: [libav-devel] [PATCH] add 24-bit FLAC encoding to Changelog

2012-11-05 Thread Reinhard Tartler
On Mon, Nov 5, 2012 at 9:38 PM, Justin Ruggles justin.rugg...@gmail.com wrote: --- This time in the right place... Changelog |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Changelog b/Changelog index e2c4273..95a507f 100644 --- a/Changelog +++ b/Changelog @@

Re: [libav-devel] [PATCH 6/6] x86: af_volume: add SSSE3/AVX-optimized s32 volume scaling

2012-11-05 Thread Justin Ruggles
On 10/02/2012 10:49 PM, Loren Merritt wrote: On Sat, 29 Sep 2012, Justin Ruggles wrote: +cglobal scale_samples_s32, 4,4,8, dst, src, len, volume +movdm4, volumem +pshufd m4, m4, 0 +movam5, [pq_128] +pxorm6, m6 +lea lenq,