Re: [libav-devel] [PATCH] apetag: fix error handling in ff_ape_parse_tag()

2012-11-21 Thread Anton Khirnov
On Wed, 14 Nov 2012 03:25:41 -0500, Xi Wang xi.w...@gmail.com wrote: The following error handling is broken due to signedness. int file_size; uint32_t tag_bytes; int64_t tag_start; ... tag_start = file_size - tag_bytes - APE_TAG_FOOTER_BYTES; if (tag_start 0) {

Re: [libav-devel] [PATCH] cdgraphics: fix incorrect vertical offset mask in cdg_scroll()

2012-11-21 Thread Anton Khirnov
On Wed, 14 Nov 2012 03:42:37 -0500, Xi Wang xi.w...@gmail.com wrote: The vertical offset mask 0x07 is suspicious. v_off = FFMIN(data[2] 0x07, CDG_BORDER_HEIGHT - 1); Note that v_off is up to 11 (CDG_BORDER_HEIGHT - 1), the correct mask should be 0x0F. Signed-off-by: Xi Wang

[libav-devel] [PATCH] flashsv: Drop unused function and struct parameters

2012-11-21 Thread Diego Biurrun
--- Now also drops the unused unp_size struct member. libavcodec/flashsv.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c index a155bef..2ba3264 100644 --- a/libavcodec/flashsv.c +++ b/libavcodec/flashsv.c @@ -45,7

Re: [libav-devel] [PATCH] flashsv: Drop unused function and struct parameters

2012-11-21 Thread Kostya Shishkov
On Wed, Nov 21, 2012 at 11:48:29AM +0100, Diego Biurrun wrote: --- Now also drops the unused unp_size struct member. libavcodec/flashsv.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) LGTM ___ libav-devel mailing list

Re: [libav-devel] [PATCH] id3v2: fix reading unsynchronized frames.

2012-11-21 Thread Luca Barbato
On 11/21/12 8:54 AM, Anton Khirnov wrote: Current code would incorrectly process e.g. 'ff 00 ff 00 ff' to 'ff ff ff', while it should be 'ff ff 00 ff'. Fixes Bug 395. Ok. ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 1/1] h264: reset has_b_frames after enabling low_delay from SPS

2012-11-21 Thread Janne Grunau
Hi, On 2012-11-16 18:14:29 -0800, Ronald S. Bultje wrote: On Fri, Nov 16, 2012 at 8:43 AM, Janne Grunau janne-li...@jannau.netwrote: Fixes a crash in fuzzed file nasa-8s2.ts_s20033 caused by a too large has_b_frames value. low_delay keeps getting re-enabled from the the presumely broken

[libav-devel] [PATCH] id3v2: fix reading unsynchronized frames.

2012-11-21 Thread Anton Khirnov
Current code would incorrectly process e.g. 'ff 00 ff 00 ff' to 'ff ff ff', while it should be 'ff ff 00 ff'. Fixes Bug 395. CC: libav-sta...@libav.org --- Now with properly working and more straightforward code --- libavformat/id3v2.c | 18 ++ 1 file changed, 10

Re: [libav-devel] [PATCH 1/1] h264: reset has_b_frames after enabling low_delay from SPS

2012-11-21 Thread Loren Merritt
On Wed, 21 Nov 2012, Janne Grunau wrote: On 2012-11-16 18:14:29 -0800, Ronald S. Bultje wrote: On Fri, Nov 16, 2012 at 8:43 AM, Janne Grunau janne-li...@jannau.netwrote: Fixes a crash in fuzzed file nasa-8s2.ts_s20033 caused by a too large has_b_frames value. low_delay keeps getting

Re: [libav-devel] [RFC PATCH 1/2] h264: set parameters from SPS whenever it changes

2012-11-21 Thread Janne Grunau
On 2012-11-16 21:02:43 -0800, Ronald S. Bultje wrote: Hi, On Fri, Nov 16, 2012 at 8:43 AM, Janne Grunau janne-li...@jannau.netwrote: I'm not entirely convinced that is the the correct/best way to fix the problem with this sample. It crashes in draw_edges_10_c because the image format

Re: [libav-devel] [PATCH 1/1] h264: reset has_b_frames after enabling low_delay from SPS

2012-11-21 Thread Janne Grunau
On 2012-11-21 13:14:34 +, Loren Merritt wrote: On Wed, 21 Nov 2012, Janne Grunau wrote: On 2012-11-16 18:14:29 -0800, Ronald S. Bultje wrote: So I'm going to have to wonder what happens to the delayed frames already cached in h-delayed_pics[]? Are they still output? yes,

Re: [libav-devel] [PATCH] id3v2: fix reading unsynchronized frames.

2012-11-21 Thread Luca Barbato
On 11/21/2012 02:07 PM, Anton Khirnov wrote: Current code would incorrectly process e.g. 'ff 00 ff 00 ff' to 'ff ff ff', while it should be 'ff ff 00 ff'. Fixes Bug 395. CC: libav-sta...@libav.org --- Now with properly working and more straightforward code Which part wasn't working? lu

Re: [libav-devel] [PATCH 1/1] h264: reset has_b_frames after enabling low_delay from SPS

2012-11-21 Thread Ronald S. Bultje
Hi, On Wed, Nov 21, 2012 at 5:37 AM, Janne Grunau janne-li...@jannau.netwrote: On 2012-11-21 13:14:34 +, Loren Merritt wrote: On Wed, 21 Nov 2012, Janne Grunau wrote: On 2012-11-16 18:14:29 -0800, Ronald S. Bultje wrote: So I'm going to have to wonder what happens to the

Re: [libav-devel] [PATCH 1/1] h264: reset has_b_frames after enabling low_delay from SPS

2012-11-21 Thread Janne Grunau
On 2012-11-21 09:13:27 -0800, Ronald S. Bultje wrote: On Wed, Nov 21, 2012 at 5:37 AM, Janne Grunau janne-li...@jannau.netwrote: On 2012-11-21 13:14:34 +, Loren Merritt wrote: On Wed, 21 Nov 2012, Janne Grunau wrote: On 2012-11-16 18:14:29 -0800, Ronald S. Bultje wrote: So

[libav-devel] [PATCH] riff: Make ff_riff_tags static and move under appropriate #ifdef

2012-11-21 Thread Diego Biurrun
The table is not used outside the file. --- libavformat/riff.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavformat/riff.c b/libavformat/riff.c index f44feff..11e2a64 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -367,13 +367,6

Re: [libav-devel] [PATCH 1/1] h264: reset has_b_frames after enabling low_delay from SPS

2012-11-21 Thread Ronald S. Bultje
Hi, On Wed, Nov 21, 2012 at 12:29 PM, Janne Grunau janne-li...@jannau.netwrote: On 2012-11-21 09:13:27 -0800, Ronald S. Bultje wrote: On Wed, Nov 21, 2012 at 5:37 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-11-21 13:14:34 +, Loren Merritt wrote: On Wed, 21 Nov 2012,