Re: [libav-devel] [PATCH] dsputil: x86: Convert some inline asm to yasm

2013-01-22 Thread Daniel Kang
On Tue, Jan 22, 2013 at 5:10 PM, Diego Biurrun wrote: > On Tue, Jan 22, 2013 at 04:40:34PM -0500, Daniel Kang wrote: >> --- a/libavcodec/x86/dsputil_avg_template.c >> +++ b/libavcodec/x86/dsputil_avg_template.c >> @@ -24,781 +24,32 @@ >> >> //FIXME the following could be optimized too ... >> +sta

Re: [libav-devel] [PATCH 2/2] Separate h264 qpel from dsputil

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 10:26 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 22, 2013 at 8:49 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Fri, Jan 18, 2013 at 2:37 PM, Diego Biurrun wrote: >> [..] >> >> This patch doesn't convert sh4 and ppc. I can do ppc, I don't have >> access to a sh4

Re: [libav-devel] [PATCH 2/2] Separate h264 qpel from dsputil

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 8:49 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jan 18, 2013 at 2:37 PM, Diego Biurrun wrote: > [..] > > This patch doesn't convert sh4 and ppc. I can do ppc, I don't have > access to a sh4 cross-compilation environment. And arm also. I've just fixed ppc, I'll fix

Re: [libav-devel] [PATCH 2/2] Separate h264 qpel from dsputil

2013-01-22 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 2:37 PM, Diego Biurrun wrote: [..] This patch doesn't convert sh4 and ppc. I can do ppc, I don't have access to a sh4 cross-compilation environment. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.li

Re: [libav-devel] [PATCH] vorbisdsp: convert x86 simd functions from inline asm to yasm.

2013-01-22 Thread Loren Merritt
On Mon, 21 Jan 2013, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > --- > libavcodec/x86/Makefile | 1 + > libavcodec/x86/dsputil_mmx.c| 3 -- > libavcodec/x86/dsputil_mmx.h| 2 - > libavcodec/x86/vorbisdsp.asm| 83 > + > li

Re: [libav-devel] [PATCH] dsputil: x86: Convert some inline asm to yasm

2013-01-22 Thread Luca Barbato
On 22/01/13 22:40, Daniel Kang wrote: > Specifically dsputil_avg_template.c and mpeg4 qpel dsputil: x86: Convert mpeg4 qpel and dsputil avg to yasm Maybe? > --- > Remove some cosmetic changes > --- > libavcodec/x86/dsputil.asm| 988 > + > libavcodec

Re: [libav-devel] [PATCH] vp3dsp: don't do aligned reads on input.

2013-01-22 Thread Luca Barbato
On 22/01/13 21:45, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > The input is not guarenteed to be aligned. guaranteed > --- > libavcodec/vp3dsp.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c > index 1883099.

Re: [libav-devel] [PATCH 2/2] arm: Add mathops.h to ARCH_HEADERS list

2013-01-22 Thread Luca Barbato
On 21/01/13 10:16, Diego Biurrun wrote: > It is an arch-specific header not suitable for standalone compilation. > --- > > This fixes "make checkheaders" on ARM. > > libavcodec/arm/Makefile |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Ok. __

Re: [libav-devel] [PATCH] vp3dsp: don't do aligned reads on input.

2013-01-22 Thread Martin Storsjö
On Tue, 22 Jan 2013, Ronald S. Bultje wrote: From: "Ronald S. Bultje" The input is not guarenteed to be aligned. --- libavcodec/vp3dsp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c index 1883099..0ce6b81 100644 --- a/liba

Re: [libav-devel] [PATCH] dsputil: x86: Convert some inline asm to yasm

2013-01-22 Thread Diego Biurrun
On Tue, Jan 22, 2013 at 04:40:34PM -0500, Daniel Kang wrote: > --- a/libavcodec/x86/dsputil_avg_template.c > +++ b/libavcodec/x86/dsputil_avg_template.c > @@ -24,781 +24,32 @@ > > //FIXME the following could be optimized too ... > +static void DEF(ff_put_no_rnd_pixels16_x2)(uint8_t *block, const

Re: [libav-devel] [PATCH 2/2] flac: add channel layout masks for streams with 7 or 8 channels.

2013-01-22 Thread Justin Ruggles
On 01/22/2013 03:53 PM, Tim Walker wrote: > They were added to the latest FLAC specification: > https://git.xiph.org/?p=flac-website.git;a=commit;h=65c199a2 > --- > libavcodec/flac.c|6 -- > libavcodec/version.h |2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --

Re: [libav-devel] [PATCH 1/2] flac: don't check the number of channels before setting the channel layout.

2013-01-22 Thread Justin Ruggles
On 01/22/2013 03:53 PM, Tim Walker wrote: > This is unnecessary, as ff_flac_set_channel_layout can handle any number of > channels. > --- > libavcodec/flac_parser.c |2 +- > libavcodec/flacdec.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/fla

[libav-devel] [PATCH 2/2] flac: add channel layout masks for streams with 7 or 8 channels.

2013-01-22 Thread Tim Walker
They were added to the latest FLAC specification: https://git.xiph.org/?p=flac-website.git;a=commit;h=65c199a2 --- libavcodec/flac.c|6 -- libavcodec/version.h |2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/flac.c b/libavcodec/flac.c index 32b28d0.

[libav-devel] [PATCH 1/2] flac: don't check the number of channels before setting the channel layout.

2013-01-22 Thread Tim Walker
This is unnecessary, as ff_flac_set_channel_layout can handle any number of channels. --- libavcodec/flac_parser.c |2 +- libavcodec/flacdec.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/flac_parser.c b/libavcodec/flac_parser.c index 3d8e17f..ee92e

[libav-devel] [PATCH] vp3dsp: don't do aligned reads on input.

2013-01-22 Thread Ronald S. Bultje
From: "Ronald S. Bultje" The input is not guarenteed to be aligned. --- libavcodec/vp3dsp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c index 1883099..0ce6b81 100644 --- a/libavcodec/vp3dsp.c +++ b/libavcodec/vp3dsp.c @@ -

Re: [libav-devel] [PATCH 6/6] mlp_parser: cosmetics: re-indent.

2013-01-22 Thread Justin Ruggles
On 12/31/2012 09:33 AM, Tim Walker wrote: > --- > libavcodec/mlp_parser.h | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) ok -Justin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/li

Re: [libav-devel] [PATCH 5/6] mlp: implement support for AVCodecContext.request_channel_layout.

2013-01-22 Thread Justin Ruggles
On 12/31/2012 09:33 AM, Tim Walker wrote: > Also wrap usage of AVCodecContext.request_channels in FF_API_REQUEST_CHANNELS > directives. > --- > libavcodec/mlp_parser.c | 29 +++-- > libavcodec/mlpdec.c | 18 ++ > 2 files changed, 37 insertions(+), 1

Re: [libav-devel] [PATCH 1/2] arm: Add some missing header #includes

2013-01-22 Thread Diego Biurrun
On Mon, Jan 21, 2013 at 10:16:02AM +0100, Diego Biurrun wrote: > --- > > This is a preliminary to make the DCTELEM patch work on ARM. > > libavcodec/arm/h264pred_init_arm.c |1 + > libavcodec/arm/vp3dsp_init_arm.c |1 + > libavcodec/arm/vp8dsp_init_arm.c |1 + > libavcodec/arm/vp

Re: [libav-devel] [PATCH] dirac decoder

2013-01-22 Thread Jordi Ortiz
Thanks for the review On 21/01/13 22:55, Diego Biurrun wrote: > Thanks for getting back to this decoder! > > On Mon, Jan 21, 2013 at 08:25:39PM +0100, Jordi Ortiz wrote: >> --- >> Use VideoDSPContext.emulated_edge_mc() instead of ff_emultated_edge_mc_8() >> Use the ff_get_buffer() wrapper. >> >>

[libav-devel] [PATCH] dsputil: remove one array dimension from avg_no_rnd_pixels_tab.

2013-01-22 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libavcodec/alpha/dsputil_alpha.c | 8 libavcodec/arm/dsputil_init_neon.c | 8 libavcodec/dsputil.c | 2 +- libavcodec/dsputil.h | 2 +- libavcodec/sh4/dsputil_align.c | 8 libavcodec/sparc/dsputil_vis.

Re: [libav-devel] [PATCH] dsputil: remove one array dimension from avg_no_rnd_pixels_tab.

2013-01-22 Thread Diego Biurrun
On Tue, Jan 22, 2013 at 11:12:16AM -0800, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > --- > libavcodec/dsputil.c | 2 +- > libavcodec/dsputil.h | 2 +- > libavcodec/vc1dec.c | 2 +- > libavcodec/x86/dsputil_mmx.c | 22 +++--- > 4 files chang

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 7:11 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 22, 2013 at 4:00 AM, Diego Biurrun wrote: >> On Mon, Jan 21, 2013 at 06:02:38PM -0800, Ronald S. Bultje wrote: >>> >>> --- a/libavcodec/dsputil.h >>> +++ b/libavcodec/dsputil.h >>> @@ -281,15 +281,15 @@ typedef st

[libav-devel] [PATCH] dsputil: remove one array dimension from avg_no_rnd_pixels_tab.

2013-01-22 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libavcodec/dsputil.c | 2 +- libavcodec/dsputil.h | 2 +- libavcodec/vc1dec.c | 2 +- libavcodec/x86/dsputil_mmx.c | 22 +++--- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/dsputil.c b/libavco

[libav-devel] [PATCH] dsputil: remove 9/10 bits hpel functions.

2013-01-22 Thread Ronald S. Bultje
From: "Ronald S. Bultje" These are never used. --- libavcodec/dsputil.c | 31 - libavcodec/dsputil_template.c | 64 --- 2 files changed, 54 insertions(+), 41 deletions(-) diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Luca Barbato
On 22/01/13 18:14, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 22, 2013 at 8:59 AM, Diego Elio Pettenò > wrote: >> On 22/01/2013 03:02, Ronald S. Bultje wrote: >>> >>> This is never used. >> >> This has a strange effect on the other avg_pixels8_* functions, me and >> Luca have been looking into

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 7:49 AM, Diego Biurrun wrote: > On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: >> On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun wrote: >> > On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: >> >> On Mon, Jan 21, 2013 at 4:04 PM, Die

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 8:59 AM, Diego Elio Pettenò wrote: > On 22/01/2013 03:02, Ronald S. Bultje wrote: >> >> This is never used. > > This has a strange effect on the other avg_pixels8_* functions, me and > Luca have been looking into it today — it's not bad, but if we can > stagger this a

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Diego Elio Pettenò
On 22/01/2013 03:02, Ronald S. Bultje wrote: > > This is never used. This has a strange effect on the other avg_pixels8_* functions, me and Luca have been looking into it today — it's not bad, but if we can stagger this a moment, we might be able to figure it out properly. -- Diego Elio Pettenò

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Diego Biurrun
On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: > On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun wrote: > > On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: > >> On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun wrote: > >> > It does not help as an abstraction and

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun wrote: > On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: >> On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun wrote: >> > It does not help as an abstraction and adds dsputil dependencies. >> >> I like the commit. I do want to add,

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 4:00 AM, Diego Biurrun wrote: > On Mon, Jan 21, 2013 at 06:02:38PM -0800, Ronald S. Bultje wrote: >> >> --- a/libavcodec/dsputil.h >> +++ b/libavcodec/dsputil.h >> @@ -281,15 +281,15 @@ typedef struct DSPContext { >> >> /** >> * Halfpel motion compensation w

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Diego Biurrun
On Mon, Jan 21, 2013 at 06:02:38PM -0800, Ronald S. Bultje wrote: > > --- a/libavcodec/dsputil.h > +++ b/libavcodec/dsputil.h > @@ -281,15 +281,15 @@ typedef struct DSPContext { > > /** > * Halfpel motion compensation with no rounding (a+b)>>1. > - * this is an array[2][4] of moti

Re: [libav-devel] [PATCH] dnxhdenc: fix invalid reads in dnxhd_mb_var_thread().

2013-01-22 Thread Kostya Shishkov
On Tue, Jan 22, 2013 at 12:04:56PM +0100, Anton Khirnov wrote: > Do not assume that frame dimensions are mod16 (or that height is mod32 > for interlaced). > --- > libavcodec/dnxhdenc.c| 27 --- > tests/ref/vsynth/vsynth1-dnxhd-1080i |4 ++-- > tests/re

[libav-devel] [PATCH] dnxhdenc: fix invalid reads in dnxhd_mb_var_thread().

2013-01-22 Thread Anton Khirnov
Do not assume that frame dimensions are mod16 (or that height is mod32 for interlaced). --- libavcodec/dnxhdenc.c| 27 --- tests/ref/vsynth/vsynth1-dnxhd-1080i |4 ++-- tests/ref/vsynth/vsynth2-dnxhd-1080i |4 ++-- 3 files changed, 28 insertions(+)

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Luca Barbato
On 22/01/13 10:53, Diego Biurrun wrote: > On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: >> On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun wrote: >>> It does not help as an abstraction and adds dsputil dependencies. >> >> I like the commit. I do want to add, though, that you're

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Diego Biurrun
On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: > On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun wrote: > > It does not help as an abstraction and adds dsputil dependencies. > > I like the commit. I do want to add, though, that you're not actually > practically removing the dspu