Re: [libav-devel] [PATCH] mov: Allow more than one keyframe per trun

2015-09-07 Thread Anton Khirnov
Quoting Martin Storsjö (2015-09-05 19:33:39) > The previous restriction was partially designed to fix certain > (broken) samples from bug 215. There should be no restriction on the > number of keyframes per fragment or trun. > So what happens now to those broken samples? -- Anton Khirnov

Re: [libav-devel] [PATCH] mov: Allow more than one keyframe per trun

2015-09-07 Thread Anton Khirnov
Quoting Martin Storsjö (2015-09-07 09:29:52) > On Mon, 7 Sep 2015, Anton Khirnov wrote: > > > Quoting Martin Storsjö (2015-09-05 19:33:39) > >> The previous restriction was partially designed to fix certain > >> (broken) samples from bug 215. There should be no restriction on the > >> number of

Re: [libav-devel] [PATCH 1/4] lavu: extend size of the AVPixFmtDescriptor.flags field

2015-09-07 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-09-02 18:59:37) > From: wm4 > > Signed-off-by: Vittorio Giovara > --- > I updated the lavu version reported to 55 (not sure if it was intentionally > left to 54 to mark the "unstable" tree phase). > Vittorio > >

Re: [libav-devel] ABI compatiblity with ffmpeg

2015-09-07 Thread Anton Khirnov
Quoting Ganesh Ajjanagadde (2015-09-06 22:56:57) > Hi all, > > I am speaking on behalf of ffmpeg here regarding the question of ABI > compatibility with ffmpeg. Recent patch: > https://ffmpeg.org/pipermail/ffmpeg-devel/2015-September/178480.html > and other discussion reflects a change in policy

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-09-02 18:59:40) > Applications can now detect rgb/yuv/gray/mono color types just > by looking at pixdesc.flags. Can't you do it already by checking that the pixfmt is single component and not rgb? -- Anton Khirnov ___

Re: [libav-devel] [PATCH] mov: Allow more than one keyframe per trun

2015-09-07 Thread Martin Storsjö
On Mon, 7 Sep 2015, Anton Khirnov wrote: Quoting Martin Storsjö (2015-09-05 19:33:39) The previous restriction was partially designed to fix certain (broken) samples from bug 215. There should be no restriction on the number of keyframes per fragment or trun. So what happens now to those

[libav-devel] [PATCH] asfdec: add more checks for size left in asf packet buffer

2015-09-07 Thread Alexandra Hájková
--- libavformat/asfdec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index b7b8d6c..a39f6d4 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -1141,7 +1141,7 @@ static int

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Hendrik Leppkes
On Mon, Sep 7, 2015 at 1:11 PM, Vittorio Giovara wrote: > On Mon, Sep 7, 2015 at 1:10 PM, Hendrik Leppkes wrote: >> On Mon, Sep 7, 2015 at 12:59 PM, Niels Möller wrote: >>> Vittorio Giovara

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Hendrik Leppkes
On Mon, Sep 7, 2015 at 11:44 AM, Vittorio Giovara wrote: > On Mon, Sep 7, 2015 at 9:13 AM, Anton Khirnov wrote: >> Quoting Vittorio Giovara (2015-09-02 18:59:40) >>> Applications can now detect rgb/yuv/gray/mono color types just >>> by looking at

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-09-07 14:20:20) > On Mon, Sep 7, 2015 at 2:06 PM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2015-09-07 13:54:02) > >> On Mon, Sep 7, 2015 at 1:12 PM, Hendrik Leppkes > >> wrote: > >> >> by that reasoning we should

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Luca Barbato
On 07/09/15 13:12, Hendrik Leppkes wrote: > On Mon, Sep 7, 2015 at 1:11 PM, Vittorio Giovara > wrote: >> On Mon, Sep 7, 2015 at 1:10 PM, Hendrik Leppkes wrote: >>> On Mon, Sep 7, 2015 at 12:59 PM, Niels Möller wrote:

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Luca Barbato
On 07/09/15 12:59, Niels Möller wrote: > Vittorio Giovara writes: > >> if (desc->flags & AV_PIX_FMT_FLAG_GRAY) >> >> is much simpler, more concise, and more correct than >> >> if ((desc->nb_components == 1 || (desc->nb_components == 2 && >> desc->flags &

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Luca Barbato
On 07/09/15 14:27, Anton Khirnov wrote: > Ideally though we would transition to something like Kostya's > pixformaton thing, with an explicit descriptor field that would tell you > whether the colorspace is YUV, RGB or whatever. I'll get something along those lines "soonish" (depending on how

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Luca Barbato
On 07/09/15 09:13, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-09-02 18:59:40) >> Applications can now detect rgb/yuv/gray/mono color types just >> by looking at pixdesc.flags. > > Can't you do it already by checking that the pixfmt is single component > and not rgb? > It is more

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Vittorio Giovara
On Mon, Sep 7, 2015 at 9:13 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-09-02 18:59:40) >> Applications can now detect rgb/yuv/gray/mono color types just >> by looking at pixdesc.flags. > > Can't you do it already by checking that the pixfmt is single component >

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Vittorio Giovara
On Mon, Sep 7, 2015 at 1:12 PM, Hendrik Leppkes wrote: >> by that reasoning we should drop AV_PIX_FMT_FLAG_RGB and just do >> >> if (strstr(pix_fmt, "rgb") || strstr(pix_fmt, "bgr")) >> >> sometimes you need redundant data for consistency and for simpler >> interfaces,

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Vittorio Giovara
On Mon, Sep 7, 2015 at 2:06 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-09-07 13:54:02) >> On Mon, Sep 7, 2015 at 1:12 PM, Hendrik Leppkes wrote: >> >> by that reasoning we should drop AV_PIX_FMT_FLAG_RGB and just do >> >> >> >> if

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Hendrik Leppkes
On Mon, Sep 7, 2015 at 12:59 PM, Niels Möller wrote: > Vittorio Giovara writes: > >> if (desc->flags & AV_PIX_FMT_FLAG_GRAY) >> >> is much simpler, more concise, and more correct than >> >> if ((desc->nb_components == 1 || (desc->nb_components ==

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Vittorio Giovara
On Mon, Sep 7, 2015 at 1:10 PM, Hendrik Leppkes wrote: > On Mon, Sep 7, 2015 at 12:59 PM, Niels Möller wrote: >> Vittorio Giovara writes: >> >>> if (desc->flags & AV_PIX_FMT_FLAG_GRAY) >>> >>> is much simpler, more concise,

Re: [libav-devel] [PATCH] asfdec: add more checks for size left in asf packet buffer

2015-09-07 Thread Hendrik Leppkes
On Mon, Sep 7, 2015 at 12:08 PM, Alexandra Hájková wrote: > --- > libavformat/asfdec.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c > index b7b8d6c..f7d8859 100644 > ---

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Vittorio Giovara
On Mon, Sep 7, 2015 at 2:27 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-09-07 14:20:20) >> On Mon, Sep 7, 2015 at 2:06 PM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2015-09-07 13:54:02) >> >> On Mon, Sep 7, 2015 at 1:12 PM, Hendrik

Re: [libav-devel] ABI compatiblity with ffmpeg

2015-09-07 Thread Ganesh Ajjanagadde
On Mon, Sep 7, 2015 at 12:06 AM, Anton Khirnov wrote: > > Quoting Ganesh Ajjanagadde (2015-09-06 22:56:57) > > Hi all, > > > > I am speaking on behalf of ffmpeg here regarding the question of ABI > > compatibility with ffmpeg. Recent patch: > >

[libav-devel] [PATCH] codec_desc: Add missing DXV entry

2015-09-07 Thread Vittorio Giovara
--- reported by nevcariel. vittorio libavcodec/codec_desc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 0919a89..c1be40b 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -1155,6 +1155,13 @@ static const

Re: [libav-devel] [PATCH] codec_desc: Add missing DXV entry

2015-09-07 Thread Luca Barbato
On 07/09/15 17:02, Vittorio Giovara wrote: > --- > reported by nevcariel. > vittorio > > libavcodec/codec_desc.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index 0919a89..c1be40b 100644 > --- a/libavcodec/codec_desc.c >

Re: [libav-devel] ABI compatiblity with ffmpeg

2015-09-07 Thread James Almer
On 9/6/2015 5:56 PM, Ganesh Ajjanagadde wrote: > Hi all, > > I am speaking on behalf of ffmpeg here regarding the question of ABI Speaking on behalf of the project would have at least required asking other devs if they were ok with that first. > compatibility with ffmpeg. Recent patch: >

[libav-devel] [PATCH] asfdec: add more checks for size left in asf packet buffer

2015-09-07 Thread Alexandra Hájková
--- libavformat/asfdec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index b7b8d6c..f7d8859 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -1141,7 +1141,7 @@ static int

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Vittorio Giovara
On Mon, Sep 7, 2015 at 12:06 PM, Hendrik Leppkes wrote: > On Mon, Sep 7, 2015 at 11:44 AM, Vittorio Giovara > wrote: >> On Mon, Sep 7, 2015 at 9:13 AM, Anton Khirnov wrote: >>> Quoting Vittorio Giovara (2015-09-02 18:59:40)

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Niels Möller
Vittorio Giovara writes: > if (desc->flags & AV_PIX_FMT_FLAG_GRAY) > > is much simpler, more concise, and more correct than > > if ((desc->nb_components == 1 || (desc->nb_components == 2 && > desc->flags & AV_PIX_FMT_FLAG_ALPHA) && !(desc->flags & >

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-09-07 13:54:02) > On Mon, Sep 7, 2015 at 1:12 PM, Hendrik Leppkes wrote: > >> by that reasoning we should drop AV_PIX_FMT_FLAG_RGB and just do > >> > >> if (strstr(pix_fmt, "rgb") || strstr(pix_fmt, "bgr")) > >> > >> sometimes you need redundant

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread Luca Barbato
On 07/09/15 14:06, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-09-07 13:54:02) >> On Mon, Sep 7, 2015 at 1:12 PM, Hendrik Leppkes wrote: by that reasoning we should drop AV_PIX_FMT_FLAG_RGB and just do if (strstr(pix_fmt, "rgb") || strstr(pix_fmt,

Re: [libav-devel] [PATCH 4/4] lavu: Add grayscale pixel format flag

2015-09-07 Thread wm4
On Mon, 07 Sep 2015 12:59:52 +0200 ni...@lysator.liu.se (Niels Möller) wrote: > Vittorio Giovara writes: > > > if (desc->flags & AV_PIX_FMT_FLAG_GRAY) > > > > is much simpler, more concise, and more correct than > > > > if ((desc->nb_components == 1 ||