Re: [libav-devel] [PATCH 01/12] lavfi: add a frame_rate field to AVFilterLink.

Thanks for the patches, all pushed. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] avcodec: fix doxy placement

Quoting Vittorio Giovara (2015-11-08 20:01:27) > On Sun, Nov 8, 2015 at 2:29 PM, Anton Khirnov wrote: > > --- > > libavcodec/avcodec.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index e368d6b..b274ecd 100644 >

Re: [libav-devel] [PATCH 016/264] mxfenc: always assume long gop

Quoting Kieran Kunhya (2015-11-09 00:03:53) > On 8 November 2015 at 20:31, Derek Buitenhuis > wrote: > > On 11/8/2015 7:57 PM, Anton Khirnov wrote: > >> Checking the codec context parameters to find out this information is > >> far too unreliable to be useful, so it is safer to assume B-frames are

Re: [libav-devel] [PATCH 007/264] libx264: export CPB props side data

Quoting Derek Buitenhuis (2015-11-08 21:36:45) > On 11/8/2015 7:57 PM, Anton Khirnov wrote: > > --- > > libavcodec/libx264.c | 8 > > 1 file changed, 8 insertions(+) > > Missing libx265.c? It does not seem to support a VBV/HRD compliant mode. Or at least it does not access max/min bitra

Re: [libav-devel] [PATCH 001/264] avpacket: add a function for wrapping existing data as side data

Quoting Kieran Kunhya (2015-11-09 00:03:19) > > pkt->side_data = av_realloc(pkt->side_data, > > (elems + 1) * sizeof(*pkt->side_data)); > > Would a linked list be better? (I'm not sure) > Well, it's too late to make this decision, the struct already exists.

Re: [libav-devel] [PATCH 4/6] qsvenc: support more RC methods

Quoting Hendrik Leppkes (2015-11-08 16:45:25) > On Sun, Nov 8, 2015 at 3:31 PM, Anton Khirnov wrote: > > --- > > libavcodec/qsvenc.c | 117 > > > > libavcodec/qsvenc.h | 9 +++- > > 2 files changed, 108 insertions(+), 18 deletions(-) > > > >

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

Quoting Vittorio Giovara (2015-11-08 21:25:17) > On Sun, Nov 8, 2015 at 9:16 PM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2015-11-08 21:08:36) > >> On Sun, Nov 8, 2015 at 9:01 PM, Anton Khirnov wrote: > >> > Quoting Vittorio Giovara (2015-11-08 20:45:57) > >> >> On Sun, Nov 8, 2015 at 8

Re: [libav-devel] [PATCH 005/264] libopenh264enc: export CPB props side data

On Sun, Nov 8, 2015 at 8:57 PM, Anton Khirnov wrote: > --- > libavcodec/internal.h | 5 + > libavcodec/libopenh264enc.c | 9 + > libavcodec/utils.c | 26 ++ > 3 files changed, 40 insertions(+) > > diff --git a/libavcodec/internal.h b/libavcodec

Re: [libav-devel] [PATCH 016/264] mxfenc: always assume long gop

On 8 November 2015 at 20:31, Derek Buitenhuis wrote: > On 11/8/2015 7:57 PM, Anton Khirnov wrote: >> Checking the codec context parameters to find out this information is >> far too unreliable to be useful, so it is safer to assume B-frames are >> always present. >> --- >> libavformat/mxfenc.c |

Re: [libav-devel] [PATCH 001/264] avpacket: add a function for wrapping existing data as side data

> pkt->side_data = av_realloc(pkt->side_data, > (elems + 1) * sizeof(*pkt->side_data)); Would a linked list be better? (I'm not sure) Kieran ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org

Re: [libav-devel] [PATCH 014/264] lavc: export Dirac parsing API used by the ogg demuxer as public

On Sun, Nov 8, 2015 at 8:57 PM, Anton Khirnov wrote: > Also, stop using AVCodecContext for storing the stream parameters. > --- > configure | 4 +- > doc/APIchanges | 4 +- > libavcodec/Makefile | 2 + > libavcodec/dirac.c | 223 > +++

Re: [libav-devel] [PATCH 007/264] libx264: export CPB props side data

On 11/8/2015 7:57 PM, Anton Khirnov wrote: > --- > libavcodec/libx264.c | 8 > 1 file changed, 8 insertions(+) Missing libx265.c? - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] TEP ][: Part 1: Preliminaries

On Sun, Nov 8, 2015 at 8:57 PM, Anton Khirnov wrote: > Hi, > The Time Has Come. yay > To simplify review, I will send the set in smallish batches. This one > contains some preparatory work. 1-13 were previewed on the list, I have no objections to them -- Vittorio __

Re: [libav-devel] [PATCH 016/264] mxfenc: always assume long gop

On 11/8/2015 7:57 PM, Anton Khirnov wrote: > Checking the codec context parameters to find out this information is > far too unreliable to be useful, so it is safer to assume B-frames are > always present. > --- > libavformat/mxfenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Isn't

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

On Sun, Nov 8, 2015 at 9:16 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-11-08 21:08:36) >> On Sun, Nov 8, 2015 at 9:01 PM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2015-11-08 20:45:57) >> >> On Sun, Nov 8, 2015 at 8:33 PM, Anton Khirnov wrote: >> >> > Quoting Vittorio Gi

Re: [libav-devel] [PATCH 016/264] mxfenc: always assume long gop

On 08/11/15 20:57, Anton Khirnov wrote: > Checking the codec context parameters to find out this information is > far too unreliable to be useful, so it is safer to assume B-frames are > always present. > --- > libavformat/mxfenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Might

Re: [libav-devel] [PATCH 015/264] h264: derive the delay from the level when it's not present

On 08/11/15 20:57, Anton Khirnov wrote: > Fall back to maximum DPB size if the level is unknown. > > This should be more spec-compliant and does not depend on the caller > setting has_b_frames before opening the decoder. > --- > libavcodec/h264.c| 14 ++ > libavcodec/h264_ps.c | 3

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

Quoting Vittorio Giovara (2015-11-08 21:08:36) > On Sun, Nov 8, 2015 at 9:01 PM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2015-11-08 20:45:57) > >> On Sun, Nov 8, 2015 at 8:33 PM, Anton Khirnov wrote: > >> > Quoting Vittorio Giovara (2015-11-08 20:26:36) > >> >> On Sun, Nov 8, 2015 at 3

Re: [libav-devel] [PATCH 002/264] lavc: add stream-global packet side data

On 08/11/15 20:57, Anton Khirnov wrote: > This is similar to what is done for AVStream. > --- > doc/APIchanges | 5 +++-- > libavcodec/avcodec.h | 10 ++ > libavcodec/utils.c | 9 - > 3 files changed, 21 insertions(+), 3 deletions(-) > Ok. _

Re: [libav-devel] [PATCH 001/264] avpacket: add a function for wrapping existing data as side data

On 08/11/15 20:57, Anton Khirnov wrote: > --- > doc/APIchanges| 4 +++- > libavcodec/avcodec.h | 16 > libavcodec/avpacket.c | 38 -- > libavcodec/version.h | 2 +- > 4 files changed, 48 insertions(+), 12 deletions(-) > Fine for me

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

On 08/11/15 21:08, Vittorio Giovara wrote: > Anyway this thread is not the right place for discussion, and > notwithstanding the above, I'd say 4 codecs over 350+ (or 117+ if you > consider encoders only) is a very small number. As the current status, that patch seems fine. We can discuss a bit a

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

On Sun, Nov 8, 2015 at 9:01 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-11-08 20:45:57) >> On Sun, Nov 8, 2015 at 8:33 PM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2015-11-08 20:26:36) >> >> On Sun, Nov 8, 2015 at 3:31 PM, Anton Khirnov wrote: >> >> > --- >> >> > libavc

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

Quoting Vittorio Giovara (2015-11-08 20:45:57) > On Sun, Nov 8, 2015 at 8:33 PM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2015-11-08 20:26:36) > >> On Sun, Nov 8, 2015 at 3:31 PM, Anton Khirnov wrote: > >> > --- > >> > libavcodec/qsvenc.c | 52 > >> >

[libav-devel] [PATCH 016/264] mxfenc: always assume long gop

Checking the codec context parameters to find out this information is far too unreliable to be useful, so it is safer to assume B-frames are always present. --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c inde

[libav-devel] [PATCH 014/264] lavc: export Dirac parsing API used by the ogg demuxer as public

Also, stop using AVCodecContext for storing the stream parameters. --- configure | 4 +- doc/APIchanges | 4 +- libavcodec/Makefile | 2 + libavcodec/dirac.c | 223 libavcodec/dirac.h | 33

[libav-devel] [PATCH 006/264] libvpxenc: export CPB props side data

--- libavcodec/libvpxenc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 563117f..bff83ac 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -220,6 +220,7 @@ static av_cold int vpx_init(AVCodecContext *avct

[libav-devel] [PATCH 015/264] h264: derive the delay from the level when it's not present

Fall back to maximum DPB size if the level is unknown. This should be more spec-compliant and does not depend on the caller setting has_b_frames before opening the decoder. --- libavcodec/h264.c| 14 ++ libavcodec/h264_ps.c | 33 + 2 files changed,

[libav-devel] [PATCH 011/264] qsvenc: export CPB props side data

--- libavcodec/qsvenc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index d17ceaa..3a13c47 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -142,6 +142,8 @@ static int init_video_param(AVCodecContext *avctx, QSVEncContext

[libav-devel] [PATCH 003/264] avconv: pass the global codec side data to the muxer

--- avconv.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/avconv.c b/avconv.c index 7334851..57a3718 100644 --- a/avconv.c +++ b/avconv.c @@ -1602,6 +1602,28 @@ static int init_output_stream(OutputStream *ost, char *error, int error_len) exit_program(1)

[libav-devel] [PATCH] TEP ][: Part 1: Preliminaries

Hi, The Time Has Come. For those who forgot what TEP2 is, a short summary: 1) AVCodecContext is a struct that stores * stream parameters * decoder or encoder options * decoder or encoder state 2) AVCodecContext is used by the demuxers to export stream parameters and by the muxers to

[libav-devel] [PATCH 005/264] libopenh264enc: export CPB props side data

--- libavcodec/internal.h | 5 + libavcodec/libopenh264enc.c | 9 + libavcodec/utils.c | 26 ++ 3 files changed, 40 insertions(+) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 500511d..24d28e2 100644 --- a/libavcodec/internal

[libav-devel] [PATCH 008/264] mpegvideo_enc: export CPB props side data

--- libavcodec/mpegvideo_enc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index ab4fb32..70f3303 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -241,6 +241,7 @@ static void mpv_encode_defaults(Mp

[libav-devel] [PATCH 013/264] mpegenc: use the CPB props side data

Do not access the encoder options, since it makes no sense when the AVStream codec context is not the encoding context. --- libavformat/mpegenc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c index 33eaefd..ac5a83

[libav-devel] [PATCH 001/264] avpacket: add a function for wrapping existing data as side data

--- doc/APIchanges| 4 +++- libavcodec/avcodec.h | 16 libavcodec/avpacket.c | 38 -- libavcodec/version.h | 2 +- 4 files changed, 48 insertions(+), 12 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index d301bd5..8c1228

[libav-devel] [PATCH 009/264] mpegvideo_enc: export vbv_delay in side data

Deprecate AVCodecContext.vbv_delay --- libavcodec/avcodec.h | 5 + libavcodec/mpegvideo_enc.c | 13 + libavcodec/version.h | 3 +++ 3 files changed, 21 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 0417309..8ed625f 100644 --- a/libavcod

[libav-devel] [PATCH 012/264] movenc: use the CPB props side data

Do not access the encoder options, since it makes no sense when the AVStream codec context is not the encoding context. --- libavformat/movenc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 572e781..49de2aa 1006

[libav-devel] [PATCH 007/264] libx264: export CPB props side data

--- libavcodec/libx264.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index bcbdf84..99dbab6 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -351,6 +351,7 @@ static int convert_pix_fmt(enum AVPixelFormat pix_fmt) static av

[libav-devel] [PATCH 004/264] lavc: add a packet side data type for VBV-like parameters

--- doc/APIchanges | 1 + libavcodec/avcodec.h | 54 libavcodec/utils.c | 14 ++ 3 files changed, 69 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 6ea75e5..56ca0d4 100644 --- a/doc/APIchanges +++ b/doc/AP

[libav-devel] [PATCH 002/264] lavc: add stream-global packet side data

This is similar to what is done for AVStream. --- doc/APIchanges | 5 +++-- libavcodec/avcodec.h | 10 ++ libavcodec/utils.c | 9 - 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 8c12284..6ea75e5 100644 --- a/doc/APIc

[libav-devel] [PATCH 010/264] nvenc: export CPB props side data

--- libavcodec/nvenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 3f19ed0..2035480 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -559,6 +559,7 @@ static int nvenc_setup_encoder(AVCodecContext *avctx) NVENCContext *c

Re: [libav-devel] [PATCH 4/4] lavf: deprecate compute_pkt_fields2

On Sun, Nov 8, 2015 at 8:44 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-11-08 20:39:18) >> On Sun, Nov 8, 2015 at 8:30 PM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2015-11-08 20:19:05) >> >> On Sun, Nov 8, 2015 at 11:54 AM, Anton Khirnov wrote: >> >> > All encoders set p

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

On Sun, Nov 8, 2015 at 8:33 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-11-08 20:26:36) >> On Sun, Nov 8, 2015 at 3:31 PM, Anton Khirnov wrote: >> > --- >> > libavcodec/qsvenc.c | 52 >> > ++- >> > libavcodec/qsvenc.h | 28 ++

Re: [libav-devel] [PATCH 4/4] lavf: deprecate compute_pkt_fields2

Quoting Vittorio Giovara (2015-11-08 20:39:18) > On Sun, Nov 8, 2015 at 8:30 PM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2015-11-08 20:19:05) > >> On Sun, Nov 8, 2015 at 11:54 AM, Anton Khirnov wrote: > >> > All encoders set pts and dts properly now (and have been doing that for > >> >

Re: [libav-devel] [PATCH 4/4] lavf: deprecate compute_pkt_fields2

On Sun, Nov 8, 2015 at 8:30 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-11-08 20:19:05) >> On Sun, Nov 8, 2015 at 11:54 AM, Anton Khirnov wrote: >> > All encoders set pts and dts properly now (and have been doing that for >> > a while), so there is no good reason to do any timestamp

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

Quoting Vittorio Giovara (2015-11-08 20:26:36) > On Sun, Nov 8, 2015 at 3:31 PM, Anton Khirnov wrote: > > --- > > libavcodec/qsvenc.c | 52 > > ++- > > libavcodec/qsvenc.h | 28 + > > libavcodec/qsvenc_h264.c | 16 +

Re: [libav-devel] [PATCH 4/4] lavf: deprecate compute_pkt_fields2

Quoting Vittorio Giovara (2015-11-08 20:19:05) > On Sun, Nov 8, 2015 at 11:54 AM, Anton Khirnov wrote: > > All encoders set pts and dts properly now (and have been doing that for > > a while), so there is no good reason to do any timestamp guessing in the > > muxer. > > --- > > libavformat/avform

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

On Sun, Nov 8, 2015 at 3:31 PM, Anton Khirnov wrote: > --- > libavcodec/qsvenc.c | 52 > ++- > libavcodec/qsvenc.h | 28 + > libavcodec/qsvenc_h264.c | 16 +++ > libavcodec/qsvenc_hevc.c | 1 + > libav

Re: [libav-devel] [PATCH 4/4] lavf: deprecate compute_pkt_fields2

On Sun, Nov 8, 2015 at 11:54 AM, Anton Khirnov wrote: > All encoders set pts and dts properly now (and have been doing that for > a while), so there is no good reason to do any timestamp guessing in the > muxer. > --- > libavformat/avformat.h | 8 ++ > libavformat/internal.h | 12 >

Re: [libav-devel] [PATCH 2/2] aiff: Fix demuxing of G.726

On Sat, Nov 7, 2015 at 1:13 PM, Luca Barbato wrote: > On 07/11/15 00:35, Vittorio Giovara wrote: >> From: Carl Eugen Hoyos >> >> Bug-id: ticket #1973 >> --- >> libavformat/aiff.h| 2 +- >> libavformat/aiffdec.c | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/lib

Re: [libav-devel] [PATCH] lavc: Deprecate rtp_callback field

On Sun, Nov 8, 2015 at 1:30 PM, Anton Khirnov wrote: > Quoting Andreas Cadhalpun (2015-11-07 17:34:15) >> On 07.11.2015 14:52, Luca Barbato wrote: >> > On 07/11/15 00:08, Andreas Cadhalpun wrote: >> > >> >> 1: >> >> https://sources.debian.net/src/opal/3.10.10~dfsg2-1/plugins/video/H.263-1998/h263

Re: [libav-devel] [PATCH] avcodec: fix doxy placement

On Sun, Nov 8, 2015 at 2:29 PM, Anton Khirnov wrote: > --- > libavcodec/avcodec.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index e368d6b..b274ecd 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@

[libav-devel] [PATCH] lavf: document that passing valid timestamps to muxers is now mandatory

Also, extend the documentation about setting timestamps. --- libavformat/avformat.h | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index e441486..57fcbf5 100644 --- a/libavformat/avformat.h +++ b/li

Re: [libav-devel] [PATCH] avio: Add avio_check2

On 08/11/15 16:43, Anton Khirnov wrote: > Ok, now that sounds like a real use case. But that's really only applies > to img2dec (which is itself a hack that should go away eventually, but I > digress), not to avconv. So, unless there are other arguments, I would > keep this private. We should depr

Re: [libav-devel] [PATCH 4/6] qsvenc: support more RC methods

On Sun, Nov 8, 2015 at 3:31 PM, Anton Khirnov wrote: > --- > libavcodec/qsvenc.c | 117 > > libavcodec/qsvenc.h | 9 +++- > 2 files changed, 108 insertions(+), 18 deletions(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > inde

Re: [libav-devel] [PATCH] avio: Add avio_check2

Quoting Luca Barbato (2015-11-08 16:30:39) > On 08/11/15 15:58, Anton Khirnov wrote: > > Quoting Luca Barbato (2015-11-08 15:45:56) > >> On 08/11/15 15:36, Anton Khirnov wrote: > >>> If it's only for img2dec internal usage then it does not need to be > >>> public. And it should be in the same set a

Re: [libav-devel] [PATCH] avio: Add avio_check2

On 08/11/15 15:58, Anton Khirnov wrote: > Quoting Luca Barbato (2015-11-08 15:45:56) >> On 08/11/15 15:36, Anton Khirnov wrote: >>> If it's only for img2dec internal usage then it does not need to be >>> public. And it should be in the same set as the patch that actually uses >>> it. Just adding a

Re: [libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

On 08/11/15 15:31, Anton Khirnov wrote: > --- > libavcodec/qsvenc.c | 52 > ++- > libavcodec/qsvenc.h | 28 + > libavcodec/qsvenc_h264.c | 16 +++ > libavcodec/qsvenc_hevc.c | 1 + > libavcodec/qsvenc_m

Re: [libav-devel] [PATCH] avio: Add avio_check2

Quoting Luca Barbato (2015-11-08 15:45:56) > On 08/11/15 15:36, Anton Khirnov wrote: > > If it's only for img2dec internal usage then it does not need to be > > public. And it should be in the same set as the patch that actually uses > > it. Just adding a function without anything using it is bad.

Re: [libav-devel] [PATCH 4/6] qsvenc: support more RC methods

On 08/11/15 15:31, Anton Khirnov wrote: > --- > libavcodec/qsvenc.c | 117 > > libavcodec/qsvenc.h | 9 +++- > 2 files changed, 108 insertions(+), 18 deletions(-) > Looks good ___ libav-devel mai

Re: [libav-devel] [PATCH 3/6] qsvenc: factor out common options

On 08/11/15 15:31, Anton Khirnov wrote: > --- > libavcodec/qsvenc.h | 9 + > libavcodec/qsvenc_h264.c | 10 ++ > libavcodec/qsvenc_hevc.c | 9 + > libavcodec/qsvenc_mpeg2.c | 9 + > 4 files changed, 13 insertions(+), 24 deletions(-) > Looks good. _

Re: [libav-devel] [PATCH 2/6] qsvenc: fix setting maxrate for VBR

On 08/11/15 15:31, Anton Khirnov wrote: > --- > libavcodec/qsvenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index 11c862c..7e5c11e 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -338,7 +338,7 @@ stat

Re: [libav-devel] [PATCH 1/6] qsvenc: print the actual video parameters used by MSDK

On 08/11/15 15:31, Anton Khirnov wrote: > --- > libavcodec/qsvenc.c | 255 > > libavcodec/qsvenc.h | 11 +++ > 2 files changed, 266 insertions(+) > Ok. ___ libav-devel mailing list libav-devel@lib

Re: [libav-devel] [PATCH] avio: Add avio_check2

On 08/11/15 15:36, Anton Khirnov wrote: > If it's only for img2dec internal usage then it does not need to be > public. And it should be in the same set as the patch that actually uses > it. Just adding a function without anything using it is bad. avio_check() exists and it is unreliable. It is us

Re: [libav-devel] [PATCH] avcodec: fix doxy placement

On 08/11/15 14:29, Anton Khirnov wrote: > --- > libavcodec/avcodec.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/4] lavf: factor out freeing an AVStream

On 08/11/15 11:54, Anton Khirnov wrote: > It will be needed in other functions. > --- > libavformat/utils.c | 58 > ++--- > 1 file changed, 33 insertions(+), 25 deletions(-) > Ok. ___ libav-devel mailin

Re: [libav-devel] [PATCH 4/4] lavf: deprecate compute_pkt_fields2

On 08/11/15 11:54, Anton Khirnov wrote: > All encoders set pts and dts properly now (and have been doing that for > a while), so there is no good reason to do any timestamp guessing in the > muxer. > --- > libavformat/avformat.h | 8 ++ > libavformat/internal.h | 12 > libavformat/mu

Re: [libav-devel] [PATCH] avio: Add avio_check2

Quoting Luca Barbato (2015-11-08 15:31:01) > On 08/11/15 13:26, Anton Khirnov wrote: > > Quoting Luca Barbato (2015-11-05 19:19:36) > >> Works as avio_check() but let you pass additional parameters. > > > > What is the use case for this? > > > > img2dec currently fails if some endpoint requires

Re: [libav-devel] [PATCH 2/4] avconv: set packet duration for CFR video streams

On 08/11/15 11:54, Anton Khirnov wrote: > --- > avconv.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/avconv.c b/avconv.c > index 493f9d2..7334851 100644 > --- a/avconv.c > +++ b/avconv.c > @@ -279,6 +279,11 @@ static void write_frame(AVFormatContext *s, AVPacket > *pkt, OutputS

Re: [libav-devel] [PATCH 1/4] lavf: initialize cur_dts to AV_NOPTS_VALUE for muxing

On 08/11/15 11:54, Anton Khirnov wrote: > The reasoning for setting it to zero only applies to demuxing. > --- > libavformat/utils.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > Possibly Ok. lu ___ libav-devel mailing list l

[libav-devel] [PATCH 4/6] qsvenc: support more RC methods

--- libavcodec/qsvenc.c | 117 libavcodec/qsvenc.h | 9 +++- 2 files changed, 108 insertions(+), 18 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 7e5c11e..4a44b53 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/q

[libav-devel] [PATCH 5/6] qsvenc: expose additional encoding options

--- libavcodec/qsvenc.c | 52 ++- libavcodec/qsvenc.h | 28 + libavcodec/qsvenc_h264.c | 16 +++ libavcodec/qsvenc_hevc.c | 1 + libavcodec/qsvenc_mpeg2.c | 1 + 5 files changed, 97 insertions(+), 1 del

[libav-devel] [PATCH 3/6] qsvenc: factor out common options

--- libavcodec/qsvenc.h | 9 + libavcodec/qsvenc_h264.c | 10 ++ libavcodec/qsvenc_hevc.c | 9 + libavcodec/qsvenc_mpeg2.c | 9 + 4 files changed, 13 insertions(+), 24 deletions(-) diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h index 89fa03a..c30

[libav-devel] [PATCH 2/6] qsvenc: fix setting maxrate for VBR

--- libavcodec/qsvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 11c862c..7e5c11e 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -338,7 +338,7 @@ static int init_video_param(AVCodecContext *avctx, QSVEncCont

[libav-devel] [PATCH 6/6] doc/encoders: document the QSV option mappings

--- doc/encoders.texi | 88 +++ 1 file changed, 88 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 3b6f7df..315c901 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -834,4 +834,92 @@ by commas (,). See kvazaar doc

Re: [libav-devel] [PATCH] avio: Add avio_check2

On 08/11/15 13:26, Anton Khirnov wrote: > Quoting Luca Barbato (2015-11-05 19:19:36) >> Works as avio_check() but let you pass additional parameters. > > What is the use case for this? > img2dec currently fails if some endpoint requires specific protocol options, possibly I can just replace it w

[libav-devel] [PATCH 1/6] qsvenc: print the actual video parameters used by MSDK

--- libavcodec/qsvenc.c | 255 libavcodec/qsvenc.h | 11 +++ 2 files changed, 266 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index d17ceaa..11c862c 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -37,6 +

[libav-devel] [PATCH] avcodec: fix doxy placement

--- libavcodec/avcodec.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index e368d6b..b274ecd 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -699,11 +699,11 @@ typedef struct RcOverride{ * interlaced motion es

Re: [libav-devel] [PATCH] lavc: Deprecate rtp_callback field

Quoting Andreas Cadhalpun (2015-11-07 17:34:15) > On 07.11.2015 14:52, Luca Barbato wrote: > > On 07/11/15 00:08, Andreas Cadhalpun wrote: > > > >> 1: > >> https://sources.debian.net/src/opal/3.10.10~dfsg2-1/plugins/video/H.263-1998/h263-1998.cxx/?hl=600#L600 > > > > Downstream dropped it since

Re: [libav-devel] [PATCH] avio: Add avio_check2

Quoting Luca Barbato (2015-11-05 19:19:36) > Works as avio_check() but let you pass additional parameters. What is the use case for this? -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav

[libav-devel] [PATCH 4/4] lavf: deprecate compute_pkt_fields2

All encoders set pts and dts properly now (and have been doing that for a while), so there is no good reason to do any timestamp guessing in the muxer. --- libavformat/avformat.h | 8 ++ libavformat/internal.h | 12 libavformat/mux.c | 77

[libav-devel] [PATCH 3/4] lavf: factor out freeing an AVStream

It will be needed in other functions. --- libavformat/utils.c | 58 ++--- 1 file changed, 33 insertions(+), 25 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 1fe7c6f..734f83f 100644 --- a/libavformat/utils.c +++ b/libavfor

[libav-devel] [PATCH 1/4] lavf: initialize cur_dts to AV_NOPTS_VALUE for muxing

The reasoning for setting it to zero only applies to demuxing. --- libavformat/utils.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 42f60d5..1fe7c6f 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -25

[libav-devel] [PATCH 2/4] avconv: set packet duration for CFR video streams

--- avconv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/avconv.c b/avconv.c index 493f9d2..7334851 100644 --- a/avconv.c +++ b/avconv.c @@ -279,6 +279,11 @@ static void write_frame(AVFormatContext *s, AVPacket *pkt, OutputStream *ost) uint8_t *sd = av_packet_get_side_data(p