Re: [libav-devel] [PATCH] Fix libgsm header detection

2013-01-20 Thread Brad Smith
On Mon, Jan 21, 2013 at 03:06:03AM +0100, Luca Barbato wrote: > On 21/01/13 02:33, Brad Smith wrote: > > On Sun, Jan 20, 2013 at 08:33:34PM +0100, Luca Barbato wrote: > >> On 20/01/13 16:36, Brad Smith wrote: > >>> On Sun, Jan 20, 2013 at 07:09:31AM -0500, Brad Smi

Re: [libav-devel] [PATCH] Fix libgsm header detection

2013-01-20 Thread Brad Smith
On Sun, Jan 20, 2013 at 08:33:34PM +0100, Luca Barbato wrote: > On 20/01/13 16:36, Brad Smith wrote: > > On Sun, Jan 20, 2013 at 07:09:31AM -0500, Brad Smith wrote: > >> The following diff is to fix the detection of the libgsm header in the > >> standard location.

Re: [libav-devel] [PATCH] Fix libgsm header detection

2013-01-20 Thread Brad Smith
On Sun, Jan 20, 2013 at 08:33:34PM +0100, Luca Barbato wrote: > On 20/01/13 16:36, Brad Smith wrote: > > On Sun, Jan 20, 2013 at 07:09:31AM -0500, Brad Smith wrote: > >> The following diff is to fix the detection of the libgsm header in the > >> standard location.

Re: [libav-devel] [PATCH] Fix libgsm header detection

2013-01-20 Thread Brad Smith
On Mon, Jan 21, 2013 at 01:32:44AM +0100, Diego Biurrun wrote: > On Sun, Jan 20, 2013 at 07:09:31AM -0500, Brad Smith wrote: > > The following diff is to fix the detection of the libgsm header in the > > standard location. OpenBSD/FreeBSD/NetBSD only provide the header in > >

Re: [libav-devel] [PATCH] Fix libgsm header detection

2013-01-20 Thread Brad Smith
On Sun, Jan 20, 2013 at 07:09:31AM -0500, Brad Smith wrote: > The following diff is to fix the detection of the libgsm header in the > standard location. OpenBSD/FreeBSD/NetBSD only provide the header in > the standard location and are patching Libav/FFmpeg to allow the libgsm > to

[libav-devel] [PATCH] Fix libgsm header detection

2013-01-20 Thread Brad Smith
The following diff is to fix the detection of the libgsm header in the standard location. OpenBSD/FreeBSD/NetBSD only provide the header in the standard location and are patching Libav/FFmpeg to allow the libgsm to build. Some OS's based on Linux provide a symlink but when I looked around almost al

[libav-devel] [PATCH] configure: support Bitrig OS

2012-08-27 Thread Brad Smith
--- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5a626b2..3a4d1aa 100755 --- a/configure +++ b/configure @@ -2581,7 +2581,7 @@ case $target_os in oss_indev_extralibs="-lossaudio" oss_outdev_extralibs="-lossaudio"

Re: [libav-devel] [PATCH] configure: Fix shared library handling for OpenBSD

2012-08-26 Thread Brad Smith
On Mon, Aug 27, 2012 at 12:30:22AM +0200, Diego Biurrun wrote: > On Sun, Aug 26, 2012 at 04:23:06PM -0400, Brad Smith wrote: > > --- a/configure > > +++ b/configure > > @@ -2590,6 +2590,8 @@ case $target_os in > > enable pic > > disable sym

[libav-devel] [PATCH] configure: Fix shared library handling for OpenBSD

2012-08-26 Thread Brad Smith
--- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 12052c0..5a626b2 100755 --- a/configure +++ b/configure @@ -2590,6 +2590,8 @@ case $target_os in enable pic disable symver SHFLAGS='-shared' +SLIBN

Re: [libav-devel] [PATCH] Xiph CELT decoder using libcelt.

2011-10-24 Thread Brad
On 24/10/11 5:12 PM, Måns Rullgård wrote: Brad writes: On 24/10/11 3:41 PM, Diego Biurrun wrote: The second is for compatibility with some crappy Unix clone that people still for some reason care about and that lacks this standard error code, possibly macos. Do you mean OS X or not? If

Re: [libav-devel] [PATCH] Xiph CELT decoder using libcelt.

2011-10-24 Thread Brad
On 24/10/11 3:41 PM, Diego Biurrun wrote: The second is for compatibility with some crappy Unix clone that people still for some reason care about and that lacks this standard error code, possibly macos. Do you mean OS X or not? If yes, which version? Only Solaris and Linux seem to have the

Re: [libav-devel] [PATCH] configure: simplify -rpath-link linker flag

2011-07-04 Thread Brad
On 04/07/11 8:50 PM, Diego Biurrun wrote: On Tue, Jul 05, 2011 at 01:43:44AM +0100, Måns Rullgård wrote: Diego Biurrun writes: Lists of ':'-separated directories can be passed to -rpath-link directly. Is this a new linker feature? If it was added after 2.18 we should not use it. I also s

Re: [libav-devel] [PATCH 2/2] avdevice: unbreak bktr.c compilation after recent BSD CPP flags cleanups

2011-05-14 Thread Brad
On 14/05/11 11:15 AM, Reinhard Tartler wrote: Am Samstag, den 14.05.2011, 11:08 -0400 schrieb Brad: On 14/05/11 10:26 AM, Reinhard Tartler wrote: This partly reverts 046f081b46c8479820409cf8f530b988221bd15b for libavdevoce/bktr.c. While _XOPEN_SOURCE and _NETBSD_SOURCE can be dropped

Re: [libav-devel] [PATCH 2/2] avdevice: unbreak bktr.c compilation after recent BSD CPP flags cleanups

2011-05-14 Thread Brad
On 14/05/11 10:26 AM, Reinhard Tartler wrote: This partly reverts 046f081b46c8479820409cf8f530b988221bd15b for libavdevoce/bktr.c. While _XOPEN_SOURCE and _NETBSD_SOURCE can be dropped, _BSD_SOURCE is still needed. --- libavdevice/bktr.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

Re: [libav-devel] FATE review

2011-05-12 Thread Brad
On 12/05/11 11:30 AM, Diego Biurrun wrote: * sparc64 / openbsd This configuration adds --disable-pthreads to the configure line. Why? OpenBSD ports has never built any arch without pthreads and this is definitely not necessary. Also I'm not sure how to contact the person whom maintains th

Re: [libav-devel] [PATCH] Fix compilation under FreeBSD

2011-04-30 Thread Brad
On 30/04/11 5:58 PM, Ronald S. Bultje wrote: Hi, On Sat, Apr 30, 2011 at 10:54 AM, Brad wrote: This isn't specific to just FreeBSD but all BSD and derived OS's. .e.g. FreeBSD, OpenBSD, NetBSD, DragonFly and OS X. FYI, OSX builds fine with vanilla libav (?). Ronald Seems to dep

Re: [libav-devel] [PATCH] Fix compilation under FreeBSD

2011-04-30 Thread Brad
On 30/04/11 6:01 PM, Brad wrote: On 30/04/11 5:58 PM, Ronald S. Bultje wrote: Hi, On Sat, Apr 30, 2011 at 10:54 AM, Brad wrote: This isn't specific to just FreeBSD but all BSD and derived OS's. .e.g. FreeBSD, OpenBSD, NetBSD, DragonFly and OS X. FYI, OSX builds fine with van

Re: [libav-devel] [PATCH] Fix compilation under FreeBSD

2011-04-30 Thread Brad
On 30/04/11 1:03 PM, Diogo Franco wrote: FreeBSD, unlike (whatever OS the default -D are trying to fix), defines every symbol by default; conformance defines are supposed to restrict FreeBSD's definitions to only the requested specification. Fix this by defining conformance flags only when we ar

Re: [libav-devel] [PATCH] allow overiding grep used by patchcheck

2011-04-15 Thread Brad
On Fri, 15 Apr 2011, 04:56:14 EDT, Luca Barbato wrote: > On 04/15/2011 01:05 AM, Brad wrote: > > There were no further comments after this.. > > I'm not sure if moving to posix grep would make the patch unnecessary or > not. The patch looks ok for me, if you don&#x

Re: [libav-devel] [PATCH] allow overiding grep used by patchcheck

2011-04-14 Thread Brad
On 27/03/11 9:34 PM, Brad wrote: On 27/03/11 9:25 PM, Måns Rullgård wrote: Brad writes: pathcheck has the binary names called by the script hardcoded which makes it a pain when you need to override the binaries being called to point to a copy of GNU grep. So make it easier. While at it, why

Re: [libav-devel] [PATCH] OpenBSD/PowerPC compilation fix for libavutil ff_get_cpu_flags_ppc()

2011-04-09 Thread Brad
On 02/04/11 6:46 PM, Brad wrote: On 02/04/11 6:40 PM, Måns Rullgård wrote: Brad writes: On 02/04/11 6:25 PM, Ronald S. Bultje wrote: Hi, On Sat, Apr 2, 2011 at 2:37 PM, Luca Barbato wrote: On 04/02/2011 11:16 PM, Brad wrote: When attempting to re-enable the AltiVec support it was noticed

[libav-devel] Fix parser: mark av_parser_parse() for removal on next major bump

2011-04-06 Thread Brad
Fix the breakage introduced with this commit.. diff --git a/libavcodec/parser.c b/libavcodec/parser.c index 0c69b91..3ba3e9c 100644 --- a/libavcodec/parser.c +++ b/libavcodec/parser.c @@ -105,7 +105,7 @@ void ff_fetch_timestamp(AVCodecParserContext *s, int off, int remove){ } } -#if LIBA

Re: [libav-devel] [PATCH] OpenBSD/PowerPC compilation fix for libavutil ff_get_cpu_flags_ppc()

2011-04-02 Thread Brad
On 02/04/11 6:40 PM, Måns Rullgård wrote: Brad writes: On 02/04/11 6:25 PM, Ronald S. Bultje wrote: Hi, On Sat, Apr 2, 2011 at 2:37 PM, Luca Barbato wrote: On 04/02/2011 11:16 PM, Brad wrote: When attempting to re-enable the AltiVec support it was noticed that we need to undefine

Re: [libav-devel] [PATCH] OpenBSD/PowerPC compilation fix for libavutil ff_get_cpu_flags_ppc()

2011-04-02 Thread Brad
On 02/04/11 6:25 PM, Ronald S. Bultje wrote: Hi, On Sat, Apr 2, 2011 at 2:37 PM, Luca Barbato wrote: On 04/02/2011 11:16 PM, Brad wrote: When attempting to re-enable the AltiVec support it was noticed that we need to undefine _POSIX_C_SOURCE to appease the headers for ff_get_cpu_flags_ppc

[libav-devel] [PATCH] OpenBSD/PowerPC compilation fix for libavutil ff_get_cpu_flags_ppc()

2011-04-02 Thread Brad
When attempting to re-enable the AltiVec support it was noticed that we need to undefine _POSIX_C_SOURCE to appease the headers for ff_get_cpu_flags_ppc() to be able to compile. diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c index 85c1f2c..6b122ed 100644 --- a/libavutil/ppc/cpu.c +++ b/

[libav-devel] [PATCH] sndio bug fix

2011-03-29 Thread Brad
Since the code already supports both little- and big-endian audio for recording, do not fail just because the endianness is not what we expect. diff --git a/libavdevice/sndio_common.c b/libavdevice/sndio_common.c index 60b7970..56c37c7 100644 --- a/libavdevice/sndio_common.c +++ b/libavdevice/snd

Re: [libav-devel] [PATCH] allow overiding grep used by patchcheck

2011-03-27 Thread Brad
On 27/03/11 9:25 PM, Måns Rullgård wrote: Brad writes: pathcheck has the binary names called by the script hardcoded which makes it a pain when you need to override the binaries being called to point to a copy of GNU grep. So make it easier. While at it, why don't you update it to use

[libav-devel] [PATCH] allow overiding grep used by patchcheck

2011-03-27 Thread Brad
pathcheck has the binary names called by the script hardcoded which makes it a pain when you need to override the binaries being called to point to a copy of GNU grep. So make it easier. diff --git a/tools/patcheck b/tools/patcheck index 5416603..fd2d4e6 100755 --- a/tools/patcheck +++ b/tools/

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-26 Thread Brad
On Sat, Mar 26, 2011 at 10:46:55PM +0100, Anton Khirnov wrote: > It'd be nice if the name contained sndio. > Also those long longs should probably be int64_t An updated diff.. >From 8e793925edfcd5038578816b259f994fbaf88fb0 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Wed, 23

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-25 Thread Brad
On Fri, 25 Mar 2011, 09:44:51 EDT, Ronald S. Bultje wrote: > Hi, > > On Thu, Mar 24, 2011 at 11:12 PM, Brad wrote: > > On 24/03/11 7:44 PM, Ronald S. Bultje wrote: > > > > +    s->buffer = av_malloc(s->buffer_size); > > > > +    if (!s->bu

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-24 Thread Brad
An updated diff. >From cbdd2a6b259eb4112fb680724072777a98fb1d66 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Wed, 23 Mar 2011 18:22:19 -0400 Subject: [PATCH] sndio support for playback and record --- Changelog |1 + configure |6 ++ doc/indevs.t

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-24 Thread Brad
On 24/03/11 7:44 PM, Ronald S. Bultje wrote: This error msg could be improved. Why did it fail to open? Is there something like errno? The API doesn't provide such information. It just failed to open the device. +if (!sio_setpar(hdl,&par) || !sio_getpar(hdl,&par)) { +av_log(s1, AV

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-24 Thread Brad
On 24/03/11 7:20 PM, Diego Biurrun wrote: On Wed, Mar 23, 2011 at 06:53:53PM -0400, Brad wrote: On Wed, Mar 23, 2011 at 12:48:23PM +0100, Diego Biurrun wrote: You should also #include stdint.h, you use uint8_t. The sndio.h header already brings in the appropriate header. This is non

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-24 Thread Brad
On Wed, 23 Mar 2011, 18:53:53 EDT, Brad wrote: > Updated diff. > > > From: Brad Smith > Date: Wed, 23 Mar 2011 18:22:19 -0400 > Subject: [PATCH] sndio support for playback and record Can this latest revision please be commited? -- This message has been scanned for vir

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-23 Thread Brad
On Wed, Mar 23, 2011 at 12:48:23PM +0100, Diego Biurrun wrote: > You should also #include stdint.h, you use uint8_t. The sndio.h header already brings in the appropriate header. Updated diff. >From 1caf5e149f8802c706fd21e1607a0d154ece11ac Mon Sep 17 00:00:00 2001 From: Brad Smith Dat

Re: [libav-devel] [PATCH] Add support for sndio to libavdevice

2011-03-23 Thread Brad
On Wed, 23 Mar 2011, 07:48:23 EDT, Diego Biurrun wrote: > > @@ -1433,6 +1434,8 @@ jack_indev_deps="jack_jack_h" > > oss_outdev_deps_any="soundcard_h sys_soundcard_h" > > +sndio_indev_deps="sndio_h" > > +sndio_outdev_deps="sndio_h" > > v4l_indev_deps="linux_videodev_h" > > alphabetical order Can