Re: [libav-devel] [PATCH 2/3] Move wmv idct to its own DSP context.

2013-01-20 Thread Ronald S. Bultje
Hi, On Sun, Jan 20, 2013 at 9:03 AM, Diego Biurrun di...@biurrun.de wrote: On Sat, Jan 19, 2013 at 01:52:24PM -0800, Ronald S. Bultje wrote: --- a/libavcodec/dsputil.c +++ b/libavcodec/dsputil.c @@ -2488,90 +2488,6 @@ static void vector_clip_int32_c(int32_t *dst, const int32_t *src, int32_t

Re: [libav-devel] Memory allocators (overkill solutions to realloc)

2013-01-19 Thread Ronald S. Bultje
Hi, On Sat, Jan 19, 2013 at 6:38 AM, Janne Grunau janne-li...@jannau.net wrote: On 2013-01-19 14:29:27 +0100, Luca Barbato wrote: Between yesterday and today I started playing and integrating some known memory allocators that provide a mean to have a realigned malloc. Here some numbers from

Re: [libav-devel] [PATCH] mpegvideo: fix loop condition in draw_line()

2013-01-19 Thread Ronald S. Bultje
Hi, On Sat, Jan 19, 2013 at 10:21 AM, Xi Wang xi.w...@gmail.com wrote: The loop condition `x = ex' is incorrect. It should be `x = ex'. This bug was introduced in commit c65dfac4 mpegvideo.c: KR formatting and cosmetics. Signed-off-by: Xi Wang xi.w...@gmail.com ---

[libav-devel] [PATCH 1/3] Use wmv2 IDCT for wmv2 fate tests.

2013-01-19 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/wmv2enc.c | 4 tests/fate-run.sh | 3 ++- tests/fate/vcodec.mak | 5 +++-- tests/ref/vsynth/vsynth1-wmv2 | 8 tests/ref/vsynth/vsynth2-wmv2 | 6 +++--- 5 files changed, 16 insertions(+), 10

[libav-devel] [PATCH 2/3] Move wmv idct to its own DSP context.

2013-01-19 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This allows us to remove FF_IDCT_WMV2, which serves no practical purpose other than to be able to select the WMV2 IDCT for MPEG (or vice versa) and get corrupt output. --- libavcodec/Makefile | 4 +- libavcodec/dsputil.c | 89

[libav-devel] [PATCH 3/3] Put FF_IDCT_{VP3, H264, CAVS, BINK, EA, WMV2} under FF_API_IDCT.

2013-01-19 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This allows us to get rid of them on the next major bump. All of the above are functionally irrelevant, and most of them are unused, except the vp3 one, which is used wrongly in the bfin arch optimizations. --- libavcodec/avcodec.h | 10

Re: [libav-devel] [PATCH 1/3] Use wmv2 IDCT for wmv2 fate tests.

2013-01-19 Thread Ronald S. Bultje
Hi, On Sat, Jan 19, 2013 at 12:48 PM, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/wmv2enc.c | 4 tests/fate-run.sh | 3 ++- tests/fate/vcodec.mak | 5 +++-- tests/ref/vsynth/vsynth1-wmv2 | 8

Re: [libav-devel] [PATCH 1/3] Use wmv2 IDCT for wmv2 fate tests.

2013-01-19 Thread Ronald S. Bultje
Hi, On Sat, Jan 19, 2013 at 1:05 PM, Diego Biurrun di...@biurrun.de wrote: On Sat, Jan 19, 2013 at 12:48:43PM -0800, Ronald S. Bultje wrote: --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -128,6 +128,7 @@ enc_dec(){ dec_fmt=$5 dec_opt=$6 +ddc_opt=$8 encfile

Re: [libav-devel] [PATCH 1/3] Use wmv2 IDCT for wmv2 fate tests.

2013-01-19 Thread Ronald S. Bultje
Hi, On Sat, Jan 19, 2013 at 1:12 PM, Luca Barbato lu_z...@gentoo.org wrote: On 19/01/13 22:08, Ronald S. Bultje wrote: THIS PROVES THAT THE CHANGES TO THE FATE RESULT ARE CORRECT ALL CHANGES IN THIS PATCH EXCEPT THE FATE REF CHANGES ARE UNDONE IN PATCH 2 Everybody on irc knows, and everybody

[libav-devel] [PATCH 1/3] Use wmv2 IDCT for wmv2 fate tests.

2013-01-19 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/wmv2enc.c | 4 tests/fate-run.sh | 3 ++- tests/fate/vcodec.mak | 5 +++-- tests/ref/seek/vsynth2-wmv2 | 28 ++-- tests/ref/vsynth/vsynth1-wmv2 | 8 tests/ref/vsynth

Re: [libav-devel] [PATCH 2/3] Move wmv idct to its own DSP context.

2013-01-19 Thread Ronald S. Bultje
Hi, On Sat, Jan 19, 2013 at 1:25 PM, Diego Biurrun di...@biurrun.de wrote: On Sat, Jan 19, 2013 at 12:48:44PM -0800, Ronald S. Bultje wrote: --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -410,10 +410,10 @@ OBJS-$(CONFIG_WMAVOICE_DECODER)+= wmavoice.o \ OBJS

[libav-devel] [PATCH 2/3] Move wmv idct to its own DSP context.

2013-01-19 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This allows us to remove FF_IDCT_WMV2, which serves no practical purpose other than to be able to select the WMV2 IDCT for MPEG (or vice versa) and get corrupt output. --- libavcodec/Makefile | 4 +- libavcodec/dsputil.c | 89

[libav-devel] [PATCH] Move vector_fmul_add from dsputil to avfloatdsp.

2013-01-19 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/aacsbr.c | 10 +- libavcodec/arm/dsputil_init_neon.c | 3 --- libavcodec/arm/dsputil_neon.S | 27 --- libavcodec/dsputil.c| 7 --- libavcodec/dsputil.h

[libav-devel] [PATCH] Remove FF_IDCT_BINK.

2013-01-18 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The value is write-only and has no functional relevance. --- libavcodec/avcodec.h | 1 - libavcodec/bink.c| 1 - 2 files changed, 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 09b9b42..8326bad 100644 --- a/libavcodec

[libav-devel] [PATCH] Remove FF_IDCT_VP3.

2013-01-18 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The value is never used, except for bfin architectures to assign a vp3-specific IDCT to DSPContext-idct, which makes no sense at all, since the vp3 idct is located in VP3DSPContext. Someone with access to bfin might want to fix up bfin/ to do the correct

[libav-devel] [PATCH] Remove FF_IDCT_H264.

2013-01-18 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The value is never used. --- libavcodec/avcodec.h | 1 - libavcodec/options_table.h | 1 - 2 files changed, 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index e7ae195..7d4ecf0 100644 --- a/libavcodec/avcodec.h +++ b

Re: [libav-devel] [PATCH] Remove FF_IDCT_BINK.

2013-01-18 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 9:09 AM, Anton Khirnov an...@khirnov.net wrote: On Fri, 18 Jan 2013 08:12:41 -0800, Ronald S. Bultje rsbul...@gmail.com wrote: From: Ronald S. Bultje rsbul...@gmail.com The value is write-only and has no functional relevance. --- libavcodec/avcodec.h | 1

Re: [libav-devel] [PATCH 1/1] vp3: integrate clear_blocks with idct of previous block.

2013-01-18 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 7:43 AM, Janne Grunau janne-li...@jannau.net wrote: From: Ronald S. Bultje rsbul...@gmail.com with added arm asm from me. Janne ---8--- This is identical to what e.g. vp8 does, and prevents the function call overhead (plus dependency on dsputil

[libav-devel] [PATCH] Put FF_IDCT_{VP3, H264, CAVS, BINK} under FF_API_IDCT.

2013-01-18 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This allows us to get rid of them on the next major bump. All of the above are functionally irrelevant, and most of them are unused, except the vp3 one, which is used wrongly in the bfin arch optimizations. --- libavcodec/avcodec.h | 6

Re: [libav-devel] [PATCH] h264idct: Replace duplicate scan8 table by appropriate #include

2013-01-18 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 2:05 PM, Diego Biurrun di...@biurrun.de wrote: --- libavcodec/h264idct_template.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/libavcodec/h264idct_template.c b/libavcodec/h264idct_template.c index 554483c..3e53589

Re: [libav-devel] [PATCH 1/2] dsputil: drop non-compliant fast qpel mc functions

2013-01-18 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 2:37 PM, Diego Biurrun di...@biurrun.de wrote: From: Mans Rullgard m...@mansr.com Signed-off-by: Diego Biurrun di...@biurrun.de --- Rebased on top of HEAD. libavcodec/dsputil.c | 16 - libavcodec/dsputil.h |3 --

Re: [libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-18 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 4:24 PM, Loren Merritt lor...@u.washington.edu wrote: On Fri, 18 Jan 2013, Vitor Sessak wrote: On Wed, Jan 16, 2013 at 1:58 AM, Ronald S. Bultje rsbul...@gmail.com wrote: +INIT_XMM sse +cglobal vorbis_inverse_coupling, 3, 3, 6, mag, ang, block_size

Re: [libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-18 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 5:07 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Fri, Jan 18, 2013 at 4:24 PM, Loren Merritt lor...@u.washington.edu wrote: On Fri, 18 Jan 2013, Vitor Sessak wrote: On Wed, Jan 16, 2013 at 1:58 AM, Ronald S. Bultje rsbul...@gmail.com wrote

Re: [libav-devel] [RFC] [PATCH 2/2] x86: vp3dsp: Separate VP3-specific inline asm functions from dsputil

2013-01-17 Thread Ronald S. Bultje
Hi, On Thu, Jan 17, 2013 at 1:45 AM, Diego Biurrun di...@biurrun.de wrote: --- This is a quick idea I had to give Daniel another small, separate piece of dsputil inline assembly to work on w/o having to fiddle with the C code. The vp3dsp_template ugliness will go away the moment this is

[libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-17 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/x86/Makefile | 3 +- libavcodec/x86/dsputil_mmx.c| 3 -- libavcodec/x86/dsputil_mmx.h| 2 - libavcodec/x86/vorbisdsp.asm| 84 + libavcodec/x86/vorbisdsp_init.c | 71

[libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-17 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Conveniently (together with Justin's earlier patches), this makes our vorbis decoder entirely independent of dsputil. (Untested on ppc/arm.) --- libavcodec/Makefile | 2 +- libavcodec/arm/Makefile | 3 ++ libavcodec/arm

[libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-17 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/x86/Makefile | 1 + libavcodec/x86/dsputil_mmx.c| 3 -- libavcodec/x86/dsputil_mmx.h| 2 - libavcodec/x86/vorbisdsp.asm| 84 + libavcodec/x86/vorbisdsp_init.c | 73

[libav-devel] [PATCH] Change block_size type from int to intptr_t.

2013-01-17 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This saves one instruction in the x86-64 assembly. --- libavcodec/arm/vorbisdsp_init_arm.c | 3 ++- libavcodec/ppc/vorbisdsp_altivec.c | 2 +- libavcodec/vorbis.h | 2 +- libavcodec/vorbisdec.c | 2 +- libavcodec/vorbisdsp.h

Re: [libav-devel] [PATCH] lavc: Move vector_fmul_add to AVFloatDSPContext

2013-01-17 Thread Ronald S. Bultje
Hi, On Thu, Jan 17, 2013 at 2:15 AM, Reinhard Tartler siret...@gmail.com wrote: On Thu, Jan 17, 2013 at 11:11 AM, Martin Storsjö mar...@martin.st wrote: On Thu, 17 Jan 2013, Reinhard Tartler wrote: On Wed, Jan 16, 2013 at 7:08 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Jan 16

Re: [libav-devel] [PATCH] float_dsp: Add #ifdef HAVE_INLINE_ASM around vector_fmul_window

2013-01-17 Thread Ronald S. Bultje
Hi, On Thu, Jan 17, 2013 at 8:59 AM, Martin Storsjö mar...@martin.st wrote: This fixes builds on 64bit MSVC. --- libavutil/x86/float_dsp_init.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) LGTM. Ronald ___ libav-devel mailing

Re: [libav-devel] [PATCH] lavc: Move vector_fmul_add to AVFloatDSPContext

2013-01-17 Thread Ronald S. Bultje
Hi, On Jan 17, 2013 12:29 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/17/2013 11:28 AM, Ronald S. Bultje wrote: Hi, On Thu, Jan 17, 2013 at 2:15 AM, Reinhard Tartler siret...@gmail.com wrote: On Thu, Jan 17, 2013 at 11:11 AM, Martin Storsjö mar...@martin.st wrote: On Thu

Re: [libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-17 Thread Ronald S. Bultje
Hi, On Thu, Jan 17, 2013 at 12:52 PM, Luca Barbato lu_z...@gentoo.org wrote: On 17/01/13 21:37, Justin Ruggles wrote: On 01/17/2013 11:25 AM, Ronald S. Bultje wrote: +cglobal vorbis_inverse_coupling, 3, 3, 6, mag, ang, block_size +movsxdifnidnblock_sizeq, block_sized I assume you'll

[libav-devel] [PATCH] Remove put_no_rnd_pixels_l2 function pointer for w=16 from dsputil.

2013-01-17 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The function is never used. --- libavcodec/dsputil.c | 3 +-- libavcodec/dsputil.h | 2 +- libavcodec/dsputil_template.c | 4 libavcodec/vp3.c | 2 +- libavcodec/vp56.c | 6 +++--- 5 files changed, 6

Re: [libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-16 Thread Ronald S. Bultje
Hi, On Jan 16, 2013 8:10 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/15/2013 08:00 PM, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/x86/Makefile | 3 +- libavcodec/x86/vorbisdsp.asm| 84

Re: [libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-16 Thread Ronald S. Bultje
Hi, On Jan 16, 2013 9:10 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/16/2013 11:44 AM, Ronald S. Bultje wrote: Hi, On Jan 16, 2013 8:10 AM, Justin Ruggles justin.rugg...@gmail.com mailto:justin.rugg...@gmail.com wrote: On 01/15/2013 08:00 PM, Ronald S. Bultje wrote

Re: [libav-devel] [PATCH] lavc: Move vector_fmul_add to AVFloatDSPContext

2013-01-16 Thread Ronald S. Bultje
Hi, On Jan 16, 2013 9:43 AM, Luca Barbato lu_z...@gentoo.org wrote: On 16/01/13 11:46, Luca Barbato wrote: From: Ronald S. Bultje rsbul...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased and compile-tested on arm and powerpc. Will be pushed in a while

Re: [libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-16 Thread Ronald S. Bultje
Hi, On Jan 16, 2013 9:46 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/16/2013 12:18 PM, Ronald S. Bultje wrote: Hi, On Jan 16, 2013 9:10 AM, Justin Ruggles justin.rugg...@gmail.com mailto:justin.rugg...@gmail.com wrote: On 01/16/2013 11:44 AM, Ronald S. Bultje wrote

Re: [libav-devel] [PATCH] lavc: Move vector_fmul_add to AVFloatDSPContext

2013-01-16 Thread Ronald S. Bultje
Hi, On Jan 16, 2013 10:01 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/16/2013 12:46 PM, Ronald S. Bultje wrote: Hi, On Jan 16, 2013 9:43 AM, Luca Barbato lu_z...@gentoo.org mailto:lu_z...@gentoo.org wrote: On 16/01/13 11:46, Luca Barbato wrote: From: Ronald S. Bultje

[libav-devel] [PATCH] h264: add 3 pixels below for subpixel filter wait position.

2013-01-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com If the motion vector is at a subpixel position, we need 3 pixels below the motion vector's wholepel position available, not 2, since the MC filter is a sixtap filter for the hpel position, and then a bilin filter for the qpel position. This patch fixes

Re: [libav-devel] [PATCH 1/2] Move vector_fmul_window() from DSPContext to AVFloatDSPContext.

2013-01-15 Thread Ronald S. Bultje
Hi, On Tue, Jan 15, 2013 at 7:22 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/06/2013 11:47 PM, Justin Ruggles wrote: --- Someone will need to test PPC and ARM to make sure it builds and passes FATE. The patch mostly just moves code around, but I may have overlooked something or

Re: [libav-devel] [PATCH 2/2] x86: float_dsp: port vector_fmul_window() from inline asm to yasm

2013-01-15 Thread Ronald S. Bultje
Hi, On Tue, Jan 15, 2013 at 7:22 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/06/2013 11:47 PM, Justin Ruggles wrote: Did not port the 3dnowext version. Added an AVX version. Used SSE2 instead of SSE to save 2 instructions when loading/reversing by using pshufd instead of shufps.

[libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Conveniently (together with Justin's earlier patches), this makes our vorbis decoder entirely independent of dsputil. (Untested on ppc/arm.) --- libavcodec/Makefile | 2 +- libavcodec/arm/Makefile | 3 ++ libavcodec/arm

Re: [libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-15 Thread Ronald S. Bultje
Hi, On Tue, Jan 15, 2013 at 3:10 PM, Diego Biurrun di...@biurrun.de wrote: +#include libavutil/common.h +#include vorbisdsp.h +#include vorbis.h Only vorbisdsp.h is needed. Uhm, no. You've not tested your own suggestions. Once tested, please send counter-patches (which you've by then

[libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/x86/Makefile | 3 +- libavcodec/x86/vorbisdsp.asm| 84 + libavcodec/x86/vorbisdsp_init.c | 70 +++--- 3 files changed, 91 insertions(+), 66 deletions

[libav-devel] [PATCH] Convert vorbisdsp x86 functions from inline asm to yasm.

2013-01-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/x86/Makefile | 3 +- libavcodec/x86/vorbisdsp.asm| 84 + libavcodec/x86/vorbisdsp_init.c | 71 +++--- 3 files changed, 91 insertions(+), 67 deletions

[libav-devel] [PATCH] Change block_size type from int to intptr_t.

2013-01-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This saves one instruction in the x86-64 assembly. --- libavcodec/arm/vorbisdsp_init_neon.c | 3 ++- libavcodec/ppc/vorbisdsp_altivec.c | 2 +- libavcodec/vorbis.h | 2 +- libavcodec/vorbisdec.c | 2 +- libavcodec

Re: [libav-devel] [PATCH] lavc: Move vector_fmul_window to AVFloatDSPContext

2013-01-15 Thread Ronald S. Bultje
Hi, On Tue, Jan 15, 2013 at 5:57 PM, Luca Barbato lu_z...@gentoo.org wrote: From: Justin Ruggles justin.rugg...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Build tested on arm and ppc. libavcodec/aacdec.c | 36 - libavcodec/ac3dec.c

[libav-devel] [PATCH] vp3: integrate clear_blocks with idct of previous block.

2013-01-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This is identical to what e.g. vp8 does, and prevents the function call overhead (plus dependency on dsputil for this particular function). Arm assembly is unconverted because I don't understand too much of it. --- libavcodec/ppc/vp3dsp_altivec.c | 2

[libav-devel] [PATCH] Move vector_fmul_add from dsputil to avfloatdsp.

2013-01-15 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/aacsbr.c | 10 +- libavcodec/arm/dsputil_init_neon.c | 3 --- libavcodec/arm/dsputil_neon.S | 27 --- libavcodec/dsputil.c| 7 --- libavcodec/dsputil.h

Re: [libav-devel] [PATCH] h264: don't clobber mmco opcode tables for non-first slice headers.

2013-01-14 Thread Ronald S. Bultje
Hi, On Mon, Jan 14, 2013 at 6:11 AM, Luca Barbato lu_z...@gentoo.org wrote: On 14/01/13 06:46, Ronald S. Bultje wrote: libavcodec/h264.c | 12 - libavcodec/h264.h | 5 +- libavcodec/h264_refs.c | 143 ++--- 3 files changed, 114

Re: [libav-devel] [PATCH] h264: fix ff_generate_sliding_window_mmcos() prototype.

2013-01-14 Thread Ronald S. Bultje
Hi, On Mon, Jan 14, 2013 at 11:21 AM, Anton Khirnov an...@khirnov.net wrote: It's been returning an error value since bad446e251405dc250c3cbee199072e083a1e4b9 Also check for the errors it returns. --- libavcodec/h264.c |3 ++- libavcodec/h264.h |2 +-

Re: [libav-devel] [PATCH v4] yadif: x86: fix build for compilers without aligned stack

2013-01-13 Thread Ronald S. Bultje
Hi, On Sun, Jan 13, 2013 at 8:57 AM, Daniel Kang daniel.d.k...@gmail.com wrote: Manually load registers to avoid using 8 registers with compilers that do not align the stack (e.g. MSVC). --- Now with named args. --- libavfilter/x86/yadif.asm | 56

Re: [libav-devel] [PATCH 1/2] lavc: return an error on failure in init_get_bits

2013-01-13 Thread Ronald S. Bultje
Hi, On Sun, Jan 13, 2013 at 1:42 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 01/13/2013 04:06 PM, Luca Barbato wrote: The function can fail internally and using the returned context results in segfaults. CC: libav-sta...@libav.org --- libavcodec/get_bits.h | 13 + 1

[libav-devel] [PATCH] h264: don't clobber mmco opcode tables for non-first slice headers.

2013-01-13 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Clobbering these tables will temporarily clobber the template used as a basis for other threads to start decoding from. If the other decoding thread updates from the template right at that moment, subsequent threads will get invalid (or, usually, none

[libav-devel] [PATCH] h264: don't clobber mmco opcode tables for non-first slice headers.

2013-01-13 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Clobbering these tables will temporarily clobber the template used as a basis for other threads to start decoding from. If the other decoding thread updates from the template right at that moment, subsequent threads will get invalid (or, usually, none

Re: [libav-devel] [EVIL/PATCH] The Evil Plan, part I

2013-01-12 Thread Ronald S. Bultje
Hi, On Tue, Jan 8, 2013 at 6:34 AM, Anton Khirnov an...@khirnov.net wrote: 2) mpegvideo is still not properly converted and thus is not contained in this set. The problem is mostly in the encoding part, which uses some ugly tricks to emulate refcounting. Also h264 -- while it passes

Re: [libav-devel] [EVIL/PATCH] The Evil Plan, part I

2013-01-12 Thread Ronald S. Bultje
Hi, On Wed, Jan 9, 2013 at 5:24 AM, Kieran Kunhya kier...@ob-encoder.com wrote: mpeg-specific crap, most probably useless = remove: int8_t *qscale_table; int qstride; int qscale_type; uint8_t *mbskip_table; int16_t (*motion_val[2])[2];

Re: [libav-devel] [PATCH v2] yadif: x86: fix building with automatic stack alignment

2013-01-12 Thread Ronald S. Bultje
Hi, On Sat, Jan 12, 2013 at 12:03 PM, Daniel Kang daniel.d.k...@gmail.com wrote: Manually reload registers to avoid trying to use 8 registers when compilers that do not align the stack. MSVC among those. [..] -adddstq, mmsize/2 -add prevq, mmsize/2 -addcurq,

Re: [libav-devel] [PATCH 0/5] tablegen: Portability Fixes

2013-01-12 Thread Ronald S. Bultje
Hi, On Sat, Jan 12, 2013 at 5:13 PM, Luca Barbato lu_z...@gentoo.org wrote: On 13/01/13 01:57, Derek Buitenhuis wrote: These will surely be controversial. Specifically, the 2nd patch. Better ideas welcome (shove it in the converter is not a better idea in this particular case). The patch

Re: [libav-devel] Consistently manage realloc (Was: [PATCH] oggparsevorbis: use av_realloc consistently)

2013-01-10 Thread Ronald S. Bultje
Hi, On Thu, Jan 10, 2013 at 11:33 AM, Luca Barbato lu_z...@gentoo.org wrote: On 10/01/13 20:12, Dale Curtis wrote: From: Paweł Hajdan, Jr phaj...@google.com Memory passed to av_realloc cannot be allocated using memalign. From realloc(3): The realloc() function changes the size of the

Re: [libav-devel] [PATCH 3/3] x86: Add a yasm based function for emms

2013-01-09 Thread Ronald S. Bultje
Hi, On Wed, Jan 9, 2013 at 12:57 PM, Martin Storsjö mar...@martin.st wrote: This is a fallback for cases where building with yasm enabled, but the compiler doesn't support inline asm (or it is disabled by the user), and the compiler doesn't support the _mm_empty intrinsic (like gcc, if the

Re: [libav-devel] [PATCH 2/3] x86inc: Allow setting a define to produce non-hidden functions

2013-01-09 Thread Ronald S. Bultje
Hi, On Wed, Jan 9, 2013 at 12:57 PM, Martin Storsjö mar...@martin.st wrote: This feels like a horrible hack, a better suggestion is welcome... --- libavutil/x86/x86inc.asm |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) This should be sent to x264 first. Don't make our

Re: [libav-devel] [PATCH 2/3] x86inc: Add cvisible macro for C functions with public prefix

2013-01-09 Thread Ronald S. Bultje
Hi, On Wed, Jan 9, 2013 at 2:27 PM, Diego Biurrun di...@biurrun.de wrote: --- libavutil/x86/x86inc.asm | 41 - libavutil/x86/x86util.asm |1 + 2 files changed, 29 insertions(+), 13 deletions(-) x86inc.asm changes need to go to x264 first.

Re: [libav-devel] [PATCH 1/3] x86inc: Rename program_name to private_prefix

2013-01-09 Thread Ronald S. Bultje
Hi, On Wed, Jan 9, 2013 at 2:27 PM, Diego Biurrun di...@biurrun.de wrote: --- libavutil/x86/x86inc.asm | 10 +- libavutil/x86/x86util.asm |2 +- libswscale/x86/input.asm |8 3 files changed, 10 insertions(+), 10 deletions(-) x86inc.asm changes need to go to

Re: [libav-devel] [PATCH v3] YADIF: Port inline assembly to YASM

2013-01-08 Thread Ronald S. Bultje
Hi, On Tue, Jan 8, 2013 at 10:27 AM, Luca Barbato lu_z...@gentoo.org wrote: On 08/01/13 17:50, Luca Barbato wrote: On 08/01/13 17:27, Daniel Kang wrote: --- This actually passes 32/64 bit Linux and 32 bit Windows. Linux/amd64 with yasm-1.2 still fails. More information: gcc-4.6.2

Re: [libav-devel] [PATCH 20/23] pthread: make ff_thread_release_buffer idempotent.

2013-01-07 Thread Ronald S. Bultje
Hi, On Jan 7, 2013 4:24 AM, Anton Khirnov an...@khirnov.net wrote: I.e. don't do anything on already released frames. --- libavcodec/pthread.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/pthread.c b/libavcodec/pthread.c index cd330fc..751fca8 100644 ---

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Ronald S. Bultje
Hi, On Sat, Jan 5, 2013 at 9:01 AM, Daniel Kang daniel.d.k...@gmail.com wrote: --- a/libavfilter/x86/yadif.c +++ b/libavfilter/x86/yadif.c @@ -26,49 +26,34 @@ #include libavcodec/x86/dsputil_mmx.h #include libavfilter/yadif.h -#if HAVE_INLINE_ASM +#if HAVE_YASM DECLARE_ASM_CONST(16,

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Ronald S. Bultje
Hi, actual asm now: On Sat, Jan 5, 2013 at 9:01 AM, Daniel Kang daniel.d.k...@gmail.com wrote: +%macro CHECK 2 +movu m2, [curq+mrefsq+%1] +movu m3, [curq+prefsq+%2] +mova m4, m2 +mova m5, m2 +pxor m4, m3 +pavgb m5, m3 pxor m4, m2, m3

Re: [libav-devel] [PATCH] pthread/mpegvideo: detect and block attempts to init frames after setup.

2013-01-03 Thread Ronald S. Bultje
Hi, On Thu, Jan 3, 2013 at 3:03 PM, Reinhard Tartler siret...@tauware.de wrote: From: Michael Niedermayer michae...@gmx.at This fixes race conditions that ultimately lead to memory corruption. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer

Re: [libav-devel] [PATCH] pthread/mpegvideo: detect and block attempts to init frames after setup.

2013-01-03 Thread Ronald S. Bultje
Hi, On Thu, Jan 3, 2013 at 3:34 PM, Reinhard Tartler siret...@gmail.com wrote: On Fri, Jan 4, 2013 at 12:24 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Thu, Jan 3, 2013 at 3:03 PM, Reinhard Tartler siret...@tauware.de wrote: From: Michael Niedermayer michae...@gmx.at This fixes

Re: [libav-devel] h264: support frame parameter changes during frame-mt

2013-01-02 Thread Ronald S. Bultje
Hi, On Tue, Jan 1, 2013 at 4:22 PM, Luca Barbato lu_z...@gentoo.org wrote: On 30/12/12 01:07, Janne Grunau wrote: On 2012-12-29 02:06:40 +0100, Rafaël Carré wrote: Le 26/12/2012 01:41, Janne Grunau a écrit : Before the commit it was only probed once? When does it get probed? in the

Re: [libav-devel] [PATCH] snow: use VideoDSPContext

2012-12-29 Thread Ronald S. Bultje
Hi, On Sat, Dec 29, 2012 at 9:07 AM, Luca Barbato lu_z...@gentoo.org wrote: It was left over from the initial conversion. --- libavcodec/snow.c | 3 ++- libavcodec/snow.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) OK. Ronald ___

Re: [libav-devel] [PATCH] libavcodec/utils: Add braces to shut up gcc warnings

2012-12-28 Thread Ronald S. Bultje
Hi, On Fri, Dec 28, 2012 at 12:21 PM, Luca Barbato lu_z...@gentoo.org wrote: On 28/12/12 19:15, Diego Biurrun wrote: libavcodec/utils.c:1050:5: warning: missing braces around initializer [-Wmissing-braces] libavcodec/utils.c:1314:5: warning: missing braces around initializer

Re: [libav-devel] [PATCH 1/1] mpegvideo: initialize videodsp with correct pixel depth

2012-12-25 Thread Ronald S. Bultje
Hi, On Tue, Dec 25, 2012 at 3:41 PM, Janne Grunau janne-li...@jannau.net wrote: Fixes decoding of 9/10 bit per pixel h264 videos as reported in https://bugzilla.libav.org/show_bug.cgi?id=404 . --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Can you confirm

Re: [libav-devel] [PATCH 2/2] Separate h264 qpel from dsptuil

2012-12-25 Thread Ronald S. Bultje
On Tue, Dec 25, 2012 at 8:01 AM, Diego Biurrun di...@biurrun.de wrote: On Sun, Dec 09, 2012 at 12:32:30AM +, Mans Rullgard wrote: --- libavcodec/Makefile| 1 + libavcodec/dsputil.c | 27 -- libavcodec/dsputil.h | 3 - libavcodec/dsputil_template.c |

Re: [libav-devel] [PATCH] lavc: introduce VideoDSPContext

2012-12-20 Thread Ronald S. Bultje
Hi, On Dec 20, 2012 4:33 AM, Luca Barbato lu_z...@gentoo.org wrote: On 12/18/2012 08:30 PM, Luca Barbato wrote: The latest patch probably is still pending in the ml, I amended the latest set of comments and I'd push it soon if nobody has other issues to be fixed. No, nothing in queue,

Re: [libav-devel] [PATCH 1/1] h264: fix sps parsing for SVC and CAVLC 4:4:4 Intra profiles

2012-12-19 Thread Ronald S. Bultje
Hi, On Dec 19, 2012 4:41 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-19 13:16:14 +0100, Hendrik Leppkes wrote: On Wed, Dec 19, 2012 at 9:38 AM, Janne Grunau janne-li...@jannau.net wrote: From: Galland gallan...@gmail.com Fixes bug 396. CC: libav-sta...@libav.org

Re: [libav-devel] [PATCH 1/1] h264: increase dist_scale_factor for up to 32 references

2012-12-18 Thread Ronald S. Bultje
Hi, On Mon, Dec 17, 2012 at 10:55 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-17 18:24:37 -0800, Ronald S. Bultje wrote: Hi, On Dec 17, 2012 1:02 PM, Janne Grunau janne-li...@jannau.net wrote: Compute dist_scale_factor_field only for MBAFF since that is the only case

Re: [libav-devel] [PATCH] mkv: add support for the VP9 tag

2012-12-18 Thread Ronald S. Bultje
Hi, On Mon, Dec 17, 2012 at 8:16 PM, Luca Barbato lu_z...@gentoo.org wrote: On 12/16/12 2:09 AM, Luca Barbato wrote: From: Tom Finegan tomfine...@chromium.org +AV_CODEC_ID_VP9, Ping I had already said OK - if you add a big phat warning saying this is experimental and a non-stable

Re: [libav-devel] [PATCH] lavc: introduce VideoDSPContext

2012-12-18 Thread Ronald S. Bultje
) contains a VideoDSPContext. Every user (encoder and decoder) of MpegEncContext will use videodsp. It is not possible to use mpegvideo while not using videodsp. --- /dev/null +++ b/libavcodec/videodsp_template.c @@ -0,0 +1,92 @@ +/* + * Copyright (C) 2012 Ronald S. Bultje This seems to be mostly

Re: [libav-devel] [PATCH 1/1] h264: increase dist_scale_factor for up to 32 references

2012-12-18 Thread Ronald S. Bultje
Hi, On Tue, Dec 18, 2012 at 8:20 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-18 07:30:03 -0800, Ronald S. Bultje wrote: Hi, On Mon, Dec 17, 2012 at 10:55 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-17 18:24:37 -0800, Ronald S. Bultje wrote: Hi, On Dec 17

Re: [libav-devel] [PATCH 1/1] mpegvideo: allocate scratch buffers after linesize is known

2012-12-18 Thread Ronald S. Bultje
Hi, On Mon, Dec 17, 2012 at 11:24 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-13 17:58:04 +0100, Janne Grunau wrote: Since we can't know which stride a custom get_buffer() implementation is going to use we have to allocate this scratch buffers after the linesize is known. It was

Re: [libav-devel] [PATCH 1/1] h264: support frame parameter changes during frame-mt

2012-12-18 Thread Ronald S. Bultje
Hi, On Mon, Dec 17, 2012 at 1:34 PM, Janne Grunau janne-li...@jannau.net wrote: -if (h != h0 || (HAVE_THREADS h-s.avctx-active_thread_type FF_THREAD_FRAME)) { -av_log_missing_feature(s-avctx, - Width/height changing with threads, 0); +

Re: [libav-devel] [PATCH 1/1] mpegvideo: increase edge_emu_buffer size for VC1

2012-12-18 Thread Ronald S. Bultje
Hi, On Tue, Dec 18, 2012 at 2:06 PM, Janne Grunau janne-li...@jannau.net wrote: The VC1 decoder uses edge_emu_buffer simultaneously for luma and chroma and needs more space. That was not a problem before f1d8763a02b5fce since the size for edge_emu_buffer was always calculated with 2 byte per

Re: [libav-devel] [PATCH 2/3] h264: clear picture copies when unreferencing them

2012-12-18 Thread Ronald S. Bultje
Hi, On Mon, Dec 17, 2012 at 11:56 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-17 18:27:17 -0800, Ronald S. Bultje wrote: Hi, On Dec 17, 2012 1:41 PM, Janne Grunau janne-li...@jannau.net wrote: Copy a neighbouring frame/field from the list as error resilience measure since

[libav-devel] [PATCH] Merge latest x86inc.asm fixes with x264.

2012-12-18 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavutil/x86/x86inc.asm | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 60d05f4..2617cdf 100644 --- a/libavutil/x86/x86inc.asm +++ b

Re: [libav-devel] [PATCH 1/1] h264: increase dist_scale_factor for up to 32 references

2012-12-17 Thread Ronald S. Bultje
Hi, On Dec 17, 2012 1:02 PM, Janne Grunau janne-li...@jannau.net wrote: Compute dist_scale_factor_field only for MBAFF since that is the only case in which it is used. The patch also increases an array size - why? Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/3] h264: clear picture copies when unreferencing them

2012-12-17 Thread Ronald S. Bultje
Hi, On Dec 17, 2012 1:41 PM, Janne Grunau janne-li...@jannau.net wrote: Copy a neighbouring frame/field from the list as error resilience measure since the decoder assumes frame data pointers of known reference to be valid. Prevents stale references in ref_list in the fuzzed sample

Re: [libav-devel] [PATCH 3/3] h264: prevent decoding of slice NALs in extradata

2012-12-17 Thread Ronald S. Bultje
Hi, On Dec 17, 2012 1:41 PM, Janne Grunau janne-li...@jannau.net wrote: It is not posible to call get_buffer during frame-mt codec initialization. Libavformat might pass huge amounts of data as extradata after parsing broken files. The 'extradata' for the fuzzed sample

Re: [libav-devel] [PATCH 13/15] h264: break after error if enough NALs were seen in decode_nal_units

2012-12-17 Thread Ronald S. Bultje
Hi, On Dec 12, 2012 12:31 PM, Janne Grunau janne-li...@jannau.net wrote: --- libavcodec/h264.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 8847f1f..35cc800 100644 --- a/libavcodec/h264.c +++

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-16 Thread Ronald S. Bultje
Hi, On Sun, Dec 16, 2012 at 5:52 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-14 17:12:05 -0800, Ronald S. Bultje wrote: Hi, On Fri, Dec 14, 2012 at 8:56 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-14 08:32:14 -0800, Ronald S. Bultje wrote: Hi, On Dec 14

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-16 Thread Ronald S. Bultje
Hi, On Sun, Dec 16, 2012 at 1:49 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-16 12:36:56 -0800, Ronald S. Bultje wrote: On Sun, Dec 16, 2012 at 5:52 AM, Janne Grunau janne-li...@jannau.net wrote: Nasm also fails on '%1 %+ SUFFIX' with empty SUFFIX in cpuid.asm

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-16 Thread Ronald S. Bultje
Hi, On Sun, Dec 16, 2012 at 9:33 AM, Luca Barbato lu_z...@gentoo.org wrote: +void ff_videodsp_init_x86(VideoDSPContext *ctx, int bpc) [..] +{ +#if HAVE_YASM +int mm_flags = av_get_cpu_flags(); + +#if ARCH_X86_32 +if (bpc = 8 mm_flags AV_CPU_FLAG_MMX) { +

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-15 Thread Ronald S. Bultje
Hi, On Sat, Dec 15, 2012 at 9:15 AM, Janne Grunau janne-li...@jannau.net wrote: Everything quoted without remarks looks ok, I haven't looked at the x86 asm. I guess only tested on x86? Yes. The emulated edge asm is a move so it needs no review. Review of the prefetch x86 asm would be nice,

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-15 Thread Ronald S. Bultje
Hi, On Sat, Dec 15, 2012 at 2:20 PM, Diego Biurrun di...@biurrun.de wrote: On Sat, Dec 15, 2012 at 09:46:02AM -0800, Ronald S. Bultje wrote: --- /dev/null +++ b/libavcodec/arm/videodsp_arm.S @@ -0,0 +1,33 @@ +@ +@ ARMv4 optimized DSP utils +@ Copyright (c) 2004 AGAWA Koji i (AT) atty (DOT

Re: [libav-devel] [PATCH 1/2] mkv: support vp9 tag

2012-12-15 Thread Ronald S. Bultje
Hi, On Sat, Dec 15, 2012 at 2:28 PM, Luca Barbato lu_z...@gentoo.org wrote: From: Tom Finegan tomfine...@chromium.org --- Maybe is a bit early but since files are cropping already might be good to have it. libavcodec/avcodec.h | 1 + libavformat/matroska.c | 1 + 2 files changed, 2

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-14 Thread Ronald S. Bultje
Hi, On Dec 14, 2012 3:30 AM, Janne Grunau janne-li...@jannau.net wrote: Arguments on the stack are handled properly and functions can use more than arguments than the 7 registers available on x86_32. Fixes nasm build, yasm would fail too if it would error out on %error instead of just

Re: [libav-devel] [PATCH 2/2] vp56: release frames on error

2012-12-14 Thread Ronald S. Bultje
Hi, On Dec 14, 2012 12:59 AM, Luca Barbato lu_z...@gentoo.org wrote: Fixes CVE-2012-2783 CC: libav-sta...@libav.org --- libavcodec/vp56.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp56.c b/libavcodec/vp56.c index 6779ffb..5bd0a1a 100644 ---

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

2012-12-14 Thread Ronald S. Bultje
Hi, On Fri, Dec 14, 2012 at 8:56 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-14 08:32:14 -0800, Ronald S. Bultje wrote: Hi, On Dec 14, 2012 3:30 AM, Janne Grunau janne-li...@jannau.net wrote: Arguments on the stack are handled properly and functions can use more than

Re: [libav-devel] [PATCH 1/1] h264-mt: handle NAL_DPAs before calling ff_thread_finish_setup

2012-12-14 Thread Ronald S. Bultje
Hi, On Fri, Dec 14, 2012 at 2:33 PM, Janne Grunau janne-li...@jannau.net wrote: Hi, On 2012-12-12 16:20:50 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 12:30 PM, Janne Grunau janne-li...@jannau.net wrote: --- libavcodec/h264.c | 13 - libavcodec/h264.h | 1

<    1   2   3   4   5   6   7   8   9   10   >