Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-18 Thread Diego Biurrun
On Sat, Dec 15, 2012 at 02:31:51PM -0800, Ronald S. Bultje wrote: > On Sat, Dec 15, 2012 at 2:20 PM, Diego Biurrun wrote: > > On Sat, Dec 15, 2012 at 09:46:02AM -0800, Ronald S. Bultje wrote: > >> --- /dev/null > >> +++ b/libavcodec/arm/videodsp_arm.S > >> @@ -0,0 +1,33 @@ > >> +@ > >> +@ ARMv4 op

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-16 Thread Ronald S. Bultje
Hi, On Sun, Dec 16, 2012 at 9:33 AM, Luca Barbato wrote: > +void ff_videodsp_init_x86(VideoDSPContext *ctx, int bpc) [..] > +{ > +#if HAVE_YASM > +int mm_flags = av_get_cpu_flags(); > + > +#if ARCH_X86_32 > +if (bpc <= 8 && mm_flags & AV_CPU_FLAG_MMX) { > +c->emulated_edge_mc = em

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-16 Thread Justin Ruggles
On 12/15/2012 12:46 PM, Ronald S. Bultje wrote: > - > -#define PREFETCH(name, op) \ > -static void name(void *mem, int stride, int h) \ > -{ \ > -const uint8_t *p = mem; \ > -do {

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-15 Thread Ronald S. Bultje
Hi, On Sat, Dec 15, 2012 at 2:20 PM, Diego Biurrun wrote: > On Sat, Dec 15, 2012 at 09:46:02AM -0800, Ronald S. Bultje wrote: >> --- /dev/null >> +++ b/libavcodec/arm/videodsp_arm.S >> @@ -0,0 +1,33 @@ >> +@ >> +@ ARMv4 optimized DSP utils >> +@ Copyright (c) 2004 AGAWA Koji >> + >> +#include "c

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-15 Thread Diego Biurrun
On Sat, Dec 15, 2012 at 09:46:02AM -0800, Ronald S. Bultje wrote: > --- /dev/null > +++ b/libavcodec/arm/videodsp_arm.S > @@ -0,0 +1,33 @@ > +@ > +@ ARMv4 optimized DSP utils > +@ Copyright (c) 2004 AGAWA Koji > + > +#include "config.h" > +#include "libavutil/arm/asm.S" > + > +#if HAVE_ARMV5TE_EXT

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-15 Thread Diego Biurrun
On Fri, Dec 14, 2012 at 10:09:45PM -0800, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Move some functions from dsputil. The idea is that videodsp contains > functions that are useful for a large and varied set of video decoders. > Currently, it contains emulated_edge_mc() and prefetch(

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-15 Thread Ronald S. Bultje
Hi, On Sat, Dec 15, 2012 at 9:15 AM, Janne Grunau wrote: > Everything quoted without remarks looks ok, I haven't looked at > the x86 asm. I guess only tested on x86? Yes. The emulated edge asm is a move so it needs no review. Review of the prefetch x86 asm would be nice, since it's a move from i

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-11 Thread Diego Biurrun
On Mon, Dec 10, 2012 at 08:56:57PM -0800, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Move some functions from dsputil. The idea is that videodsp contains > functions that are useful for a large and varied set of video decoders. > Currently, it contains emulated_edge_mc() and prefetch(

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-11 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > Move some functions from dsputil. The idea is that videodsp contains > functions that are useful for a large and varied set of video decoders. > Currently, it contains emulated_edge_mc() and prefetch(). This allows > vp8.c to be compiled

Re: [libav-devel] [PATCH] Add a VideoDSPContext with core video DSP functions.

2012-12-10 Thread Luca Barbato
On 12/11/12 5:56 AM, Ronald S. Bultje wrote: From: "Ronald S. Bultje" Move some functions from dsputil. The idea is that videodsp contains functions that are useful for a large and varied set of video decoders. Currently, it contains emulated_edge_mc() and prefetch(). This allows vp8.c to be co