Re: [libav-devel] [PATCH 2/4] lmlm4: K&R formatting cosmetics

2014-09-23 Thread Diego Biurrun
On Tue, Sep 23, 2014 at 10:29:58AM -0400, Gabriel Dume wrote: > --- > libavformat/lmlm4.c | 51 ++- > 1 file changed, 26 insertions(+), 25 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@

Re: [libav-devel] [PATCH 1/4] concat: K&R formatting cosmetics

2014-09-23 Thread Diego Biurrun
On Tue, Sep 23, 2014 at 10:29:57AM -0400, Gabriel Dume wrote: > --- > libavformat/concat.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/

Re: [libav-devel] [PATCH 3/4] m4vdec: K&R formatting cosmetics

2014-09-23 Thread Diego Biurrun
On Tue, Sep 23, 2014 at 10:29:59AM -0400, Gabriel Dume wrote: > --- > libavformat/m4vdec.c | 31 ++- > 1 file changed, 18 insertions(+), 13 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://l

Re: [libav-devel] VDD meeting notes

2014-09-23 Thread Diego Biurrun
On Tue, Sep 23, 2014 at 11:27:28PM +0100, Vittorio Giovara wrote: > On Sun, Sep 21, 2014 at 12:43 PM, Andrew Kelley wrote: > > more things to remove? > > is there any reason to keep lavf/gopher.c besides compatibility with a > time machine? Heh, at VDD we had a few jokes over beers about this.

Re: [libav-devel] [PATCH] fate: Switch ra4-288 test from framecrc() to pcm()

2014-09-24 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 01:51:54PM +0200, Katerina Barone-Adesi wrote: > The decoder is float-based and the test needs to allow for some fuzz. > --- > tests/fate/real.mak | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM Diego ___ libav-d

Re: [libav-devel] [PATCH 2/2] rtpenc: HEVC/H.265 support

2014-09-24 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 03:24:57PM +0300, Martin Storsjö wrote: > > --- a/Changelog > +++ b/Changelog > @@ -5,6 +5,7 @@ version : > - aliases and defaults for Ogg subtypes (opus, spx) > - HEVC/H.265 RTP payload format (draft v6) depacketizer > - avplay now exits by default at the end of playbac

Re: [libav-devel] [PATCH 1/2] libavformat: Move avc mp4 startcode parsing to a shared file

2014-09-24 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 03:24:56PM +0300, Martin Storsjö wrote: > --- > libavformat/avc.c | 17 + > libavformat/avc.h | 3 +++ > libavformat/rtpenc_h264.c | 19 ++- > 3 files changed, 22 insertions(+), 17 deletions(-) LGTM Diego __

Re: [libav-devel] [PATCH 6/8] vdpau: add av_vdpau_bind_context()

2014-09-24 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 12:03:24PM +0300, Rémi Denis-Courmont wrote: > This function provides an explicit VDPAU device and VDPAU driver to > libavcodec, so that the application is relieved from codec specifics > and VdpDevice life cycle management. > > A stub flags parameter is added for future ex

Re: [libav-devel] [PATCH 5/8] vdpau: force reinitialization when output resolution changes

2014-09-24 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 12:03:23PM +0300, Rémi Denis-Courmont wrote: > --- a/libavcodec/vdpau.c > +++ b/libavcodec/vdpau.c > @@ -76,6 +76,9 @@ int ff_vdpau_common_init(AVCodecContext *avctx, > VdpDecoderProfile profile, > uint32_t width = (avctx->coded_width + 1) & ~1; > uint32_t height

Re: [libav-devel] [PATCH 1/8] vdpau: add helper for VDPAU to libav error codes conversion

2014-09-24 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 12:03:19PM +0300, Rémi Denis-Courmont wrote: > --- a/libavcodec/vdpau.c > +++ b/libavcodec/vdpau.c > @@ -38,6 +38,30 @@ > +static int vdpau_error(VdpStatus status) > +{ > +switch (status) { > +case VDP_STATUS_OK: > +return 0; > +case VDP_STATU

Re: [libav-devel] [PATCH 2/2] fate: Add VC-1 interlaced test

2014-09-24 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 05:27:46PM +0200, Tim Walker wrote: > On 21 Sep 2014, at 18:16, Hendrik Leppkes wrote: > > On Sun, Sep 21, 2014 at 5:16 PM, Tim Walker wrote: > >> --- a/tests/fate/microsoft.mak > >> +++ b/tests/fate/microsoft.mak > >> @@ -53,6 +53,9 @@ fate-vc1_sa10143: CMD = framecrc -i

[libav-devel] [PATCH] fate: Switch ra4-288 test from framecrc() to pcm()

2014-09-24 Thread Diego Biurrun
From: Katerina Barone-Adesi The decoder is float-based and the test needs to allow for some fuzz. Signed-off-by: Diego Biurrun --- Now removes the obsoleted framecrc reference file. tests/fate/real.mak| 4 ++- tests/ref/fate/ra4-288 | 73

Re: [libav-devel] [PATCH] hwaccel: Call ->get_format again if hwaccel init fails

2014-09-25 Thread Diego Biurrun
On Thu, Sep 25, 2014 at 10:27:15AM +0200, Luca Barbato wrote: > From: Rémi Denis-Courmont > > This allows the application to fallback to another hwaccel, or more to fall back on Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.li

[libav-devel] [PATCH 0/8] some DCA refactorings

2014-09-25 Thread Diego Biurrun
dec.c is decreased by roughly one third. The typedef patches can (and probably should) be squashed together when pushing, I split them as they are a pain to review otherwise. Diego Biurrun (8): caf: Give context structure a consistent name avformat: Don't anonymously typedef structs avco

[libav-devel] [PATCH 7/8] dca: Remove trace debugging code

2014-09-25 Thread Diego Biurrun
--- libavcodec/dcadec.c | 147 +--- 1 file changed, 1 insertion(+), 146 deletions(-) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index 298cd4e..c4e31eb 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -53,8 +53,6 @@ # incl

[libav-devel] [PATCH 6/8] dca: Return more informative error codes

2014-09-25 Thread Diego Biurrun
--- libavcodec/dca_exss.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/dca_exss.c b/libavcodec/dca_exss.c index 6d15886..26595cb 100644 --- a/libavcodec/dca_exss.c +++ b/libavcodec/dca_exss.c @@ -95,7 +95,7 @@ static int dca_exss_parse_asset_header(DC

[libav-devel] [PATCH 3/8] avcodec: Don't anonymously typedef structs

2014-09-25 Thread Diego Biurrun
--- libavcodec/aacpsy.c | 2 +- libavcodec/ac3dec.c | 2 +- libavcodec/alac.c | 2 +- libavcodec/alsdec.c | 8 libavcodec/amrwbdec.c | 2 +- libavcodec/ansi.c | 2 +- libavcodec/atrac1.c | 4 ++-- libavcodec/avs.c

[libav-devel] [PATCH 5/8] dca: Split code for handling the EXSS extension off into a separate file

2014-09-25 Thread Diego Biurrun
--- libavcodec/Makefile | 2 +- libavcodec/dca.h | 149 + libavcodec/dca_exss.c | 322 libavcodec/dca_exss.h | 28 libavcodec/dcadec.c | 441 +- 5 files changed, 502 insertions(+),

[libav-devel] [PATCH 2/8] avformat: Don't anonymously typedef structs

2014-09-25 Thread Diego Biurrun
--- libavformat/adtsenc.c| 2 +- libavformat/aiffdec.c| 2 +- libavformat/aiffenc.c| 2 +- libavformat/anm.c| 4 ++-- libavformat/ape.c| 4 ++-- libavformat/asfdec.c | 2 +- libavformat/asfenc.c | 2

[libav-devel] [PATCH 1/8] caf: Give context structure a consistent name

2014-09-25 Thread Diego Biurrun
--- libavformat/cafdec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index 0034f00..4489eb2 100644 --- a/libavformat/cafdec.c +++ b/libavformat/cafdec.c @@ -46,7 +46,7 @@ typedef struct { int64_t data_start;

[libav-devel] [PATCH 4/8] Don't anonymously typedef structs

2014-09-25 Thread Diego Biurrun
--- avprobe.c | 4 ++-- libavutil/file.c | 2 +- libavutil/parseutils.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/avprobe.c b/avprobe.c index c7b3d39..1e43c4b 100644 --- a/avprobe.c +++ b/avprobe.c @@ -84,14 +84,14 @@ typedef enum { OBJECT

[libav-devel] [PATCH 8/8] dca: Move all tables into dcadata.h

2014-09-25 Thread Diego Biurrun
--- libavcodec/dcadata.h | 89 libavcodec/dcadec.c | 89 2 files changed, 89 insertions(+), 89 deletions(-) diff --git a/libavcodec/dcadata.h b/libavcodec/dcadata.h index 7c37d3a..8be4475 10

Re: [libav-devel] [PATCH 1/3] vc1: use logical operation instead of bitwise for coded_inter

2014-09-25 Thread Diego Biurrun
On Thu, Sep 25, 2014 at 06:47:04PM +0200, Tim Walker wrote: > This appears to be the intended behavior. > --- > libavcodec/vc1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) vc1: Use logical instead of bitwise or for coded_inter Diego ___

Re: [libav-devel] [PATCH 2/3] vc1: use logical operation instead of bitwise for twomv

2014-09-25 Thread Diego Biurrun
On Thu, Sep 25, 2014 at 06:47:05PM +0200, Tim Walker wrote: > From: Michael Niedermayer > > CC: libav-sta...@libav.org > Signed-off-by: Michael Niedermayer > Signed-off-by: Tim Walker > --- > libavcodec/vc1dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) vc1: Use logical inst

[libav-devel] [PATCH] pcm-dvd: Move a variable to a smaller scope

2014-09-26 Thread Diego Biurrun
This avoids an unused variable warning on big-endian systems. --- libavcodec/pcm-dvd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/pcm-dvd.c b/libavcodec/pcm-dvd.c index 0872d29..791df54 100644 --- a/libavcodec/pcm-dvd.c +++ b/libavcodec/pcm-dvd.c @@ -154,21

Re: [libav-devel] [PATCH 2/2] mlpdec: support TrueHD streams with an Atmos substream

2014-09-26 Thread Diego Biurrun
On Fri, Sep 26, 2014 at 01:49:21PM +0200, Hendrik Leppkes wrote: > The fourth substream is being discarded, since its not raw audio data, > but an encoded Atmos stream which needs a specialized decoder. > > Fixes decoding of the true hd stream from Transformers\ -\ Age\ of\ > Extinction\ 2014\ 10

Re: [libav-devel] [PATCH 1/2] mlpdec: support major sync headers with optional extension blocks

2014-09-26 Thread Diego Biurrun
On Fri, Sep 26, 2014 at 01:49:20PM +0200, Hendrik Leppkes wrote: > --- a/libavcodec/mlp_parser.c > +++ b/libavcodec/mlp_parser.c > @@ -119,6 +119,23 @@ static uint64_t truehd_layout(int chanmap) > > +static int ff_mlp_get_major_sync_size(const uint8_t * buf, int bufsize) > +{ > +int has_exten

Re: [libav-devel] [PATCH] avutil: clean description of channel layouts

2014-09-26 Thread Diego Biurrun
On Tue, Sep 23, 2014 at 02:38:18PM +0200, Marc-Antoine Arnaud wrote: > --- a/libavutil/channel_layout.c > +++ b/libavutil/channel_layout.c > @@ -70,34 +70,33 @@ static const struct { > } channel_layout_map[] = { > -{ "3.0", 3, AV_CH_LAYOUT_SURROUND }, > -{ "3.0(back)", 3, AV_CH

Re: [libav-devel] [PATCH 1/8] vdpau: add helper for VDPAU to libav error codes conversion

2014-09-26 Thread Diego Biurrun
On Wed, Sep 24, 2014 at 11:29:03AM +0200, Luca Barbato wrote: > > The set seems fine to me, if nobody beats me I'd add to my queue and > merge it with the rest of the pending stuff. Set queued. I'll fix some nits and push it on Monday as I need to run out now and will be away over the weekend.

Re: [libav-devel] [PATCH 2/6] pixdesc: return color properties names

2014-09-26 Thread Diego Biurrun
On Fri, Sep 26, 2014 at 05:22:35PM +0100, Vittorio Giovara wrote: > --- a/libavutil/pixdesc.c > +++ b/libavutil/pixdesc.c > @@ -1700,3 +1727,34 @@ enum AVPixelFormat av_pix_fmt_swap_endianness(enum > AVPixelFormat pix_fmt) > + > +const char *av_color_range_name(enum AVColorRange range) > +{ > +

[libav-devel] [PATCH] configure: Place all temporary files in one separate directory

2014-09-26 Thread Diego Biurrun
This reduces TMPDIR pollution and possibly avoids race conditions with temporary files that are not atomically created. Based on a patch from Michał Górny . --- Now uses "mktemp -d" if available. configure | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/config

Re: [libav-devel] [PATCH] download: Reorder the sections and update the explanations

2014-11-08 Thread Diego Biurrun
On Sat, Oct 25, 2014 at 08:13:23PM +0200, Luca Barbato wrote: > --- a/src/download > +++ b/src/download > @@ -1,21 +1,122 @@ > > +Libav Releases > + > + > +At quasi-regular intervals Libav makes releases that represent snapshots of > Libav semi-regular > +Users and downstream developers that wi

Re: [libav-devel] [PATCH 3/6] xcbgrab: assign variable after checking pointer

2014-12-17 Thread Diego Biurrun
On Wed, Dec 17, 2014 at 03:19:41PM +0100, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 1254668 > --- > libavdevice/xcbgrab.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) xcbgrab: Move NULL check before pointer dereference sounds better as a log msg to me.

Re: [libav-devel] [PATCH 1/6] rtsp: check ffurl_get_file_handle() return value

2014-12-17 Thread Diego Biurrun
On Wed, Dec 17, 2014 at 03:19:39PM +0100, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 717844 > --- > libavformat/rtsp.c | 4 > 1 file changed, 4 insertions(+) probably OK Diego ___ libav-devel mailing list libav-devel@libav.

Re: [libav-devel] [PATCH 4/6] takdec: check av_samples_get_buffer_size() return value

2014-12-17 Thread Diego Biurrun
On Wed, Dec 17, 2014 at 03:19:42PM +0100, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 747734 > --- > libavcodec/takdec.c | 2 ++ > 1 file changed, 2 insertions(+) Should be OK. Diego ___ libav-devel mailing list libav-devel@libav

Re: [libav-devel] [PATCH 5/6] vf_pad: always check av_expr_parse_and_eval() return value

2014-12-17 Thread Diego Biurrun
On Wed, Dec 17, 2014 at 03:19:43PM +0100, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 703624 > --- > libavfilter/vf_pad.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) Should be OK. Diego ___ libav-devel

Re: [libav-devel] [PATCH 6/6] vf_scale: check av_expr_parse_and_eval() return value

2014-12-17 Thread Diego Biurrun
On Wed, Dec 17, 2014 at 03:19:44PM +0100, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 703625 > --- > libavfilter/vf_scale.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Should be OK, could be squashed with 5/6. Diego __

Re: [libav-devel] [PATCH 1/2] imgconvert: check memory allocations and propgate errors

2014-12-18 Thread Diego Biurrun
On Wed, Dec 17, 2014 at 04:01:45PM +0100, Vittorio Giovara wrote: > --- > libavcodec/imgconvert.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) prop_A_gate Diego ___ libav-devel mailing list libav-devel@libav.org https://lis

Re: [libav-devel] [PATCH] libavformat: Add a muxer wrapping mpegts encoding into RTP

2014-12-18 Thread Diego Biurrun
On Thu, Dec 18, 2014 at 12:10:36PM +0200, Martin Storsjö wrote: > --- /dev/null > +++ b/libavformat/rtpenc_mpegts.c > @@ -0,0 +1,165 @@ > + > +#include "avformat.h" > +#include "libavutil/mathematics.h" nit: canonical header order > +for (i = 0; i < s->nb_streams; i++) { > +AVStream*

Re: [libav-devel] [PATCH 3/3] rtp: Initial H.261 support

2014-12-18 Thread Diego Biurrun
On Thu, Dec 18, 2014 at 12:29:55PM +0200, Martin Storsjö wrote: > --- /dev/null > +++ b/libavformat/rtpdec_h261.c > @@ -0,0 +1,202 @@ > + > +#include "avformat.h" > +#include "rtpdec_formats.h" > +#include "libavcodec/get_bits.h" nit: header ordering > +static int h261_handle_packet(AVFormatConte

[libav-devel] [PATCH 1/2] ffv1: Drop unnecessary casts and const qualifiers to match function signatures

2014-12-18 Thread Diego Biurrun
libavcodec/ffv1dec.c:898:36: warning: cast discards ‘const’ qualifier from pointer target type --- libavcodec/ffv1dec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 50b220f..4349af5 100644 --- a/libavcodec/ffv1dec.c

[libav-devel] [PATCH 2/2] ffv1: const correctness for encode_rgb_frame()

2014-12-18 Thread Diego Biurrun
libavcodec/ffv1enc.c:922:53: warning: passing argument 5 of ‘encode_rgb_frame’ discards ‘const’ qualifier from pointer target type --- libavcodec/ffv1enc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 9363

Re: [libav-devel] [PATCH] arm: NEON optimized FIR audio resampling

2015-01-07 Thread Diego Biurrun
On Sun, Dec 28, 2014 at 04:50:02PM +0100, Peter Meerwald wrote: > > diff --git a/libavresample/arm/Makefile b/libavresample/arm/Makefile > index 60f3f6d..a7c2d22 100644 > --- a/libavresample/arm/Makefile > +++ b/libavresample/arm/Makefile > @@ -1,5 +1,7 @@ > -OBJS += arm/audio_convert_init.o

Re: [libav-devel] [PATCH] libavcodec: Add an OpenH264 encoder wrapper

2015-01-07 Thread Diego Biurrun
On Sun, Jan 04, 2015 at 08:53:02PM +0200, Martin Storsjö wrote: > Compared to existing, common opensource H264 encoders, this can be open source H.264 > --- > Changelog | 1 + > configure | 4 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs

Re: [libav-devel] [PATCH] configure: Remap -L to -libpath for msvc

2015-01-07 Thread Diego Biurrun
On Sat, Jan 03, 2015 at 12:57:55AM +0200, Martin Storsjö wrote: > This allows using libraries that are detected via pkg-config with > msvc. (The libraries themselves may have to be built with MSVC > though.) > --- > configure | 1 + > 1 file changed, 1 insertion(+) OK I'd uppercase MSVC everywhe

Re: [libav-devel] [PATCH 2/3] lavf: Add DSS demuxer

2015-01-07 Thread Diego Biurrun
On Fri, Dec 19, 2014 at 12:59:16AM +0100, Vittorio Giovara wrote: > --- > This version fixes the stack corruption when parsing the date string. > Vittorio > > Changelog| 2 +- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/dss.c| 34

Re: [libav-devel] [PATCH 1/3] lavc: Add DSS_SP decoder

2015-01-07 Thread Diego Biurrun
On Fri, Dec 19, 2014 at 12:59:15AM +0100, Vittorio Giovara wrote: > > Changelog | 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/dss_sp.c | 791 > +++

Re: [libav-devel] [PATCH] png: improve signature check

2015-01-13 Thread Diego Biurrun
On Tue, Jan 13, 2015 at 01:53:48PM +0100, Vittorio Giovara wrote: > Return proper error code, print and error message and add missing an_ > parenthesis. Parenthes_e_s, the 'i' denotes the singular. > --- a/libavcodec/pngdec.c > +++ b/libavcodec/pngdec.c > @@ -415,9 +415,10 @@ static int decode_

Re: [libav-devel] [PATCH] h264_cabac: Break infinite loops

2015-01-13 Thread Diego Biurrun
On Tue, Jan 13, 2015 at 02:43:32PM +0200, Martin Storsjö wrote: > --- a/libavcodec/h264_cabac.c > +++ b/libavcodec/h264_cabac.c > @@ -1712,7 +1712,7 @@ decode_cabac_residual_internal(H264Context *h, int16_t > *block, > \ > if( coeff_abs >= 15 ) { \ > int j = 0; \ > -

Re: [libav-devel] [PATCH] aea: Return proper error code on invalid header

2015-01-16 Thread Diego Biurrun
Hey, welcome back :) On Thu, Jan 15, 2015 at 06:20:03PM +0530, Nidhi Makhijani wrote: > --- > libavformat/aea.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.o

Re: [libav-devel] [PATCH] vmdvideo: Prevent writing over the frame buffer

2015-01-19 Thread Diego Biurrun
On Mon, Jan 19, 2015 at 01:32:14PM +0100, Luca Barbato wrote: > --- a/libavcodec/vmdvideo.c > +++ b/libavcodec/vmdvideo.c > @@ -245,6 +245,12 @@ static int rle_region(VmdVideoContext *s, GetByteContext > *gb, > len = bytestream2_get_byte(gb); > if (len & 0x80) { >

Re: [libav-devel] [PATCH 4/5] h264_parser: restore a comment lost in 0268a54

2015-01-20 Thread Diego Biurrun
On Tue, Jan 20, 2015 at 09:07:55AM +0100, Anton Khirnov wrote: > --- > libavcodec/h264_parser.c | 1 + > 1 file changed, 1 insertion(+) I hear that shortening hashes to 7 digits is considered too little these days, maybe make it a habit to use 10? Patchset looks OKish to me at a glance. Diego _

Re: [libav-devel] [PATCH] doc/platform: Reference only MSYS2 and MinGW-w64

2015-01-20 Thread Diego Biurrun
On Mon, Jan 19, 2015 at 06:48:21PM +, Derek Buitenhuis wrote: > --- a/doc/platform.texi > +++ b/doc/platform.texi > @@ -91,9 +91,9 @@ For information about compiling Libav on OS/2 see > > @section Native Windows compilation using MinGW or MinGW-w64 > > -Libav can be built to run natively o

Re: [libav-devel] [PATCH 3/5] aacdec: Support for ER AAC in LATM

2015-01-24 Thread Diego Biurrun
On Thu, Jan 22, 2015 at 11:04:39AM -0800, Alex Converse wrote: > From: espes > > --- > libavcodec/aacdec.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) Could we have a real name instead of "espes"? Diego ___ libav-devel m

Re: [libav-devel] [PATCH 5/5] aacdec: Support for ER AAC ELD 480.

2015-01-24 Thread Diego Biurrun
On Thu, Jan 22, 2015 at 11:04:41AM -0800, Alex Converse wrote: > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -91,7 +91,8 @@ OBJS-$(CONFIG_WMA_FREQS) += wma_freqs.o > OBJS-$(CONFIG_AAC_DECODER) += aacdec.o aactab.o aacsbr.o aacps.o > \ > -

Re: [libav-devel] [PATCH 4/7] hevc: add hwaccel hooks

2015-01-24 Thread Diego Biurrun
On Sat, Jan 24, 2015 at 03:14:05PM +0100, Hendrik Leppkes wrote: > --- a/libavcodec/hevc_refs.c > +++ b/libavcodec/hevc_refs.c > @@ -340,6 +354,7 @@ static HEVCFrame *generate_missing_ref(HEVCContext *s, > int poc) > > +if (!s->avctx->hwaccel) { > if (!s->sps->pixel_shift) { >

Re: [libav-devel] [PATCH 2/7] hevc: store the escaped/raw bitstream in HEVCNAL

2015-01-24 Thread Diego Biurrun
On Sat, Jan 24, 2015 at 03:14:03PM +0100, Hendrik Leppkes wrote: > --- a/libavcodec/hevc.c > +++ b/libavcodec/hevc.c > @@ -2657,8 +2657,8 @@ static int extract_rbsp(const uint8_t *src, int length, > #endif /* HAVE_FAST_UNALIGNED */ > > if (i >= length - 1) { // no escaped 0 > -nal->

Re: [libav-devel] [PATCH 6/7] Add DXVA2 HEVC HWAccel

2015-01-24 Thread Diego Biurrun
On Sat, Jan 24, 2015 at 03:14:07PM +0100, Hendrik Leppkes wrote: > --- a/configure > +++ b/configure > @@ -1519,6 +1519,7 @@ TYPES_LIST=" > struct_sockaddr_sa_len > struct_sockaddr_storage > struct_v4l2_frmivalenum_discrete > +DXVA_PicParams_HEVC alphabetical order please > @@

Re: [libav-devel] [PATCH 3/5] aacdec: Support for ER AAC in LATM

2015-01-25 Thread Diego Biurrun
On Sun, Jan 25, 2015 at 08:40:04PM +1100, espes wrote: > On 25 January 2015 at 17:40, Diego Biurrun wrote: > > > > Could we have a real name instead of "espes"? > > Niel van der Westhuizen Thanks. Diego ___ libav

Re: [libav-devel] [PATCH 2/3] Fixed a typo

2015-01-25 Thread Diego Biurrun
On Sun, Jan 25, 2015 at 12:32:50PM +0100, Andreas Unterweger wrote: > From 35b64b53602752928f929e880e6a27923bc6e6ea Mon Sep 17 00:00:00 2001 > From: Andreas Unterweger > Date: Sun, 25 Jan 2015 12:18:05 +0100 > Subject: [PATCH 2/3] Fixed a typo > > --- > doc/examples/transcode_aac.c | 2 +- > 1 f

Re: [libav-devel] [PATCH v2 3/6] aacdec: Support for ER AAC in LATM

2015-01-27 Thread Diego Biurrun
On Tue, Jan 27, 2015 at 05:54:00PM -0800, Alex Converse wrote: > --- a/libavcodec/aacdec.c > +++ b/libavcodec/aacdec.c > @@ -3235,8 +3235,18 @@ static int latm_decode_frame(AVCodecContext *avctx, > void *out, > +if (err < 0) > +return err; Indentation is off, you'll want to fix be

Re: [libav-devel] [PATCH v2 6/6] fate: Add a test for AAC ELD480.

2015-01-28 Thread Diego Biurrun
On Tue, Jan 27, 2015 at 05:54:03PM -0800, Alex Converse wrote: > The source is er_eld_2100np_48_ep0.mp4 from the official test set. > --- > tests/fate/aac.mak | 4 > 1 file changed, 4 insertions(+) Can you send me the samples? I'll upload them. Diego ___

Re: [libav-devel] [PATCH] xiph: const-ify parameters

2015-01-28 Thread Diego Biurrun
On Thu, Jan 29, 2015 at 01:01:39AM +, Vittorio Giovara wrote: > Fix -Wincompatible-pointer-types-discards-qualifiers warnings. > --- > libavcodec/vorbis_parser.c | 2 +- > libavcodec/xiph.c | 8 +--- > libavcodec/xiph.h | 5 +++-- > 3 files changed, 9 insertions(+), 6 del

Re: [libav-devel] [PATCH 5/5] aacdec: Support for ER AAC ELD 480.

2015-01-31 Thread Diego Biurrun
On Mon, Jan 26, 2015 at 11:28:55AM +0100, Anton Khirnov wrote: > Quoting Alex Converse (2015-01-25 08:14:10) > > On Jan 24, 2015 10:44 PM, "Diego Biurrun" wrote: > > > On Thu, Jan 22, 2015 at 11:04:41AM -0800, Alex Converse wrote: > > > > --- a/liba

[libav-devel] [PATCH] opus: Factor out imdct15 into a standalone component

2015-01-31 Thread Diego Biurrun
It will be reused by the AAC decoder. --- This is only compile-tested on x86_32. I'd appreciate if somebody could test it on aarch64 and push, I'll be offline again for the next 2-3 days. configure | 2 ++ libavcodec/Makefile

Re: [libav-devel] [PATCH] ogg: Provide an option to offset the serial number

2015-01-31 Thread Diego Biurrun
On Sun, Feb 01, 2015 at 01:23:48AM +0100, Luca Barbato wrote: > The ogg serial number doubles as codec id and sequence > value for concatenated samples. Ogg > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@ -504,6 +504,11 @@ is 1 second. A value of 0 will fill all segments, making > pages as

Re: [libav-devel] [PATCH] opencv: Check kernel_str livecycle

2015-01-31 Thread Diego Biurrun
On Sun, Feb 01, 2015 at 02:02:05AM +0100, Luca Barbato wrote: > The string might or might not be set depending if there > are args and in case of error it must be free nonetheless. freeD Diego ___ libav-devel mailing list libav-devel@libav.org https://l

Re: [libav-devel] [PATCH] mov: Implement parsing of the "HandlerName" from the MP4 HDLR atom

2015-02-01 Thread Diego Biurrun
On Sun, Feb 01, 2015 at 02:12:53AM +0100, Vittorio Giovara wrote: > This atom typically is used for a track title. The handler name is stored > as a pascal string in the QT specs (first byte is the length of the string), Pascal > A second length check based on the first character is added to avoi

[libav-devel] [PATCH] opus: Factor out imdct15 into a standalone component

2015-02-01 Thread Diego Biurrun
It will be reused by the AAC decoder. --- Changed the struct name to uppercase. Still needs testing on aarch64. configure | 2 ++ libavcodec/Makefile| 4 +-- libavcodec/aarch64/Makefile| 4 +-- .

Re: [libav-devel] [PATCH] opus: Factor out imdct15 into a standalone component

2015-02-02 Thread Diego Biurrun
On Sun, Feb 01, 2015 at 12:51:41PM +0100, Janne Grunau wrote: > On 2015-02-01 11:08:17 +0100, Diego Biurrun wrote: > > It will be reused by the AAC decoder. > > --- > > > > Changed the struct name to uppercase. > > > > Still needs testing on aarch64. >

[libav-devel] [PATCH] Ignore generated file tools/sidxindex.

2015-02-02 Thread Diego Biurrun
--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 19bb757..e225866 100644 --- a/.gitignore +++ b/.gitignore @@ -59,4 +59,5 @@ /tools/pktdumper /tools/probetest /tools/qt-faststart +/tools/sidxindex /tools/trasher -- 2.1.0 ___

[libav-devel] [PATCH] rangecoder: const correctness for ff_init_range_decoder()

2015-02-02 Thread Diego Biurrun
--- ff_init_range_encoder() does not take a const parameter, so I believe this is the right solution. libavcodec/rangecoder.c | 6 ++ libavcodec/rangecoder.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/rangecoder.c b/libavcodec/rangecoder.c index af0a8c0

Re: [libav-devel] [PATCH] configure: Add a dependency on vc1_decoder from vc1_parser

2015-02-02 Thread Diego Biurrun
On Sun, Feb 01, 2015 at 05:26:26PM +0200, Martin Storsjö wrote: > This fixes builds with vc1_parser enabled without vc1_decoder. All > the vc1_decoder object files were included in the vc1_parser line > in libavcodec/Makefile before, but architecture specific object files > for vc1_decoder were not

Re: [libav-devel] [PATCH v2 1/5] g722: Split out g722_qmf_apply() function into g722dsp.c

2015-02-02 Thread Diego Biurrun
On Mon, Feb 02, 2015 at 11:49:26AM +0100, Peter Meerwald wrote: > Signed-off-by: Peter Meerwald > > --- > > v2: > license statement in g722dsp.c (Timothy) Not quite, you copy and pasted only part of the standard license header. > --- a/libavcodec/g722dec.c > +++ b/libavcodec/g722dec.c > @@ -12

Re: [libav-devel] [PATCH v2 4/5] g722: Split out computation of band->s_zero and unroll code

2015-02-02 Thread Diego Biurrun
On Mon, Feb 02, 2015 at 11:49:29AM +0100, Peter Meerwald wrote: > --- a/libavcodec/g722.c > +++ b/libavcodec/g722.c > @@ -71,6 +71,35 @@ const int16_t ff_g722_low_inv_quant6[64] = { > > +static inline void s_zero(int cur_diff, struct G722Band *band) { { on the next line for K&R style > +int

Re: [libav-devel] [PATCH] configure: Add a dependency on vc1_decoder from vc1_parser

2015-02-02 Thread Diego Biurrun
On Mon, Feb 02, 2015 at 01:01:38PM +0200, Martin Storsjö wrote: > On Mon, 2 Feb 2015, Diego Biurrun wrote: > >On Sun, Feb 01, 2015 at 05:26:26PM +0200, Martin Storsjö wrote: > >>This fixes builds with vc1_parser enabled without vc1_decoder. All > >>the vc1_decoder object

Re: [libav-devel] [PATCH 1/2] siff: Report correctly impossible packet sizes

2015-02-02 Thread Diego Biurrun
On Mon, Feb 02, 2015 at 03:18:43AM +0100, Luca Barbato wrote: > Bug-Id: CID 1258461 > CC: libav-sta...@libav.org > --- > libavformat/siff.c | 4 > 1 file changed, 4 insertions(+) correctly report Diego ___ libav-devel mailing list libav-devel@liba

Re: [libav-devel] [PATCH 2/2] cosmetics: Refactor siff

2015-02-02 Thread Diego Biurrun
On Mon, Feb 02, 2015 at 03:18:44AM +0100, Luca Barbato wrote: > --- > libavformat/siff.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) I'd suggest siff: K&R formatting cosmetics no real refactoring is taking place. Diego

Re: [libav-devel] [PATCH v2 5/5] g722: Add ARM NEON implementation for g722_apply_qmf()

2015-02-02 Thread Diego Biurrun
On Mon, Feb 02, 2015 at 11:49:30AM +0100, Peter Meerwald wrote: > Signed-off-by: Peter Meerwald > > --- > > v2: > drop unnecessary constants (yes, they were for as asm version of s_zero which > turned out not worthwhile) (Martin) > fix NEON register clobbering, use d16 instead of d8 as per AAPC

Re: [libav-devel] [PATCH 38/64] h264: remove some remnants of data partitioning

2015-02-02 Thread Diego Biurrun
On Thu, Jan 29, 2015 at 04:47:53PM +0100, Anton Khirnov wrote: > h264: remove more data partitioning remnants > --- > libavcodec/h264.c | 15 --- > libavcodec/h264.h | 10 ++ > libavcodec/h264_cavlc.c | 6 +++--- > libavcodec/h264_slice.c | 6 ++ > 4 files cha

Re: [libav-devel] [PATCH 2/2] cosmetics: Refactor siff

2015-02-03 Thread Diego Biurrun
On Mon, Feb 02, 2015 at 03:18:44AM +0100, Luca Barbato wrote: > --- > libavformat/siff.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) This is incomplete. I'll send a better patch soonish. Diego ___ libav-devel mailing lis

[libav-devel] [PATCH 2/2] siff: Return more meaningful error values

2015-02-03 Thread Diego Biurrun
--- libavformat/siff.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/libavformat/siff.c b/libavformat/siff.c index 3a74c81..cf71514 100644 --- a/libavformat/siff.c +++ b/libavformat/siff.c @@ -76,7 +76,7 @@ static int create_audio_stream(

[libav-devel] [PATCH 1/2] siff: K&R formatting cosmetics

2015-02-03 Thread Diego Biurrun
--- libavformat/siff.c | 81 +++--- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/libavformat/siff.c b/libavformat/siff.c index 8ba7c60..3a74c81 100644 --- a/libavformat/siff.c +++ b/libavformat/siff.c @@ -21,10 +21,11 @@ #includ

Re: [libav-devel] [PATCH 1/3] lavc: Add DSS_SP decoder

2015-02-03 Thread Diego Biurrun
On Tue, Feb 03, 2015 at 06:44:16PM +0100, Oleksij Rempel wrote: > Am 07.01.2015 um 22:24 schrieb Diego Biurrun: > > On Fri, Dec 19, 2014 at 12:59:15AM +0100, Vittorio Giovara wrote: > >> > >> Changelog | 1 + > >> libavcodec/Makefile | 1 +

Re: [libav-devel] Regarding contributing to libav

2015-02-04 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 02:44:52AM +0530, Himangi Saraogi wrote: > Hey, Hi Himangi! > I am an undergraduate student from India. I have some previous experience > working on the linux kernel and was looking at some new open source > projects to contribute to. As a part of some college projects, I

Re: [libav-devel] [PATCH] Canopus HQX decoder

2015-02-04 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 02:21:28PM +, Vittorio Giovara wrote: > Based on work by Kostya Shishkov . > --- > Changelog |1 + > libavcodec/Makefile|1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h |1 + > libavcodec/code

Re: [libav-devel] [PATCH 1/4] graphparser: check av_get_token() memory error

2015-02-04 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 02:20:58PM +, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 1267891 > --- > libavfilter/graphparser.c | 2 ++ > 1 file changed, 2 insertions(+) > --- a/libavfilter/graphparser.c > +++ b/libavfilter/graphparser.c > @@ -62,6 +62,8 @@ static char *pars

Re: [libav-devel] [PATCH 2/4] avplay: check video_thread() av_frame_alloc() allocation

2015-02-04 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 02:20:59PM +, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 1267893 > --- > avplay.c | 3 +++ > 1 file changed, 3 insertions(+) avplay: Check memory allocation inside video_thread() OK Diego ___ libav-d

Re: [libav-devel] [PATCH 3/4] avconv: check rc_override memory allocation

2015-02-04 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 02:21:00PM +, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > Bug-Id: CID 1265719 > --- > avconv_opt.c | 4 > 1 file changed, 4 insertions(+) OK Diego ___ libav-devel mailing list libav-devel@libav.org https://li

Re: [libav-devel] [PATCH 4/4] avplay: check format allocation

2015-02-04 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 02:21:01PM +, Vittorio Giovara wrote: > --- a/avplay.c > +++ b/avplay.c > @@ -2257,6 +2257,11 @@ static int decode_thread(void *arg) > global_video_state = is; > > ic = avformat_alloc_context(); > +if (!ic) { > +av_log(NULL, AV_LOG_FATAL, "Could n

Re: [libav-devel] [PATCH 2/3] lavf: Add DSS demuxer

2015-02-04 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 09:27:42AM +0100, Oleksij Rempel wrote: > Signed-off-by: Oleksij Rempel > Signed-off-by: Luca Barbato > Signed-off-by: Vittorio Giovara > --- > Changelog| 2 +- > doc/general.texi | 1 + > libavformat/Makefile | 1 + > libavformat/allfor

Re: [libav-devel] [PATCH 1/3] lavc: Add DSS_SP decoder

2015-02-05 Thread Diego Biurrun
On Wed, Feb 04, 2015 at 09:27:41AM +0100, Oleksij Rempel wrote: > --- a/Changelog > +++ b/Changelog > @@ -12,6 +12,7 @@ version : > - VP8 in Ogg demuxing > - OpenH264 encoder wrapper > - Support DNx100 (960x720@8) > +- DSS_SP decoder "DSS SP" I guess. > --- a/libavcodec/codec_desc.c > +++ b/li

Re: [libav-devel] [PATCH] lavf: document the codec context initialization

2015-02-05 Thread Diego Biurrun
On Thu, Dec 04, 2014 at 07:09:40PM +, Vittorio Giovara wrote: > --- a/libavformat/avformat.h > +++ b/libavformat/avformat.h > @@ -198,6 +198,10 @@ > * that the timebase actually used by the muxer can be different, as will > be > * described later). > + * - It is advised to manually ini

Re: [libav-devel] [PATCH 4/4] avplay: check format allocation

2015-02-05 Thread Diego Biurrun
On Thu, Feb 05, 2015 at 01:08:48PM +, Vittorio Giovara wrote: > On Wed, Feb 4, 2015 at 7:49 PM, Diego Biurrun wrote: > > On Wed, Feb 04, 2015 at 02:21:01PM +, Vittorio Giovara wrote: > >> --- a/avplay.c > >> +++ b/avplay.c > >> @@ -2257,6 +2257,11 @

[libav-devel] [PATCH] vdpau: Adjust necessary #includes for vdpau_internal.h

2015-02-05 Thread Diego Biurrun
--- This seemed to work and fix "make checkheaders" for Himangi. Untested, please somebody push that can verify it works... libavcodec/vdpau_internal.h | 5 +++-- libavcodec/vdpau_mpeg12.c | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/vdpau_internal.h b/libav

Re: [libav-devel] [PATCH] qdm2: Return meaningful error codes

2015-02-05 Thread Diego Biurrun
Good job on your first patch! On Thu, Feb 05, 2015 at 11:46:41PM +0530, Himangi Saraogi wrote: > --- a/libavcodec/qdm2.c > +++ b/libavcodec/qdm2.c > @@ -1778,18 +1778,18 @@ static av_cold int qdm2_decode_init(AVCodecContext > *avctx) > > if (extradata[7] == 'C') { > //s->is_qdmc =

[libav-devel] [PATCH] hmac: Explicitly convert types at function pointer assignment

2015-02-05 Thread Diego Biurrun
This fixes a number of "assignment from incompatible pointer type" warnings. --- libavutil/hmac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavutil/hmac.c b/libavutil/hmac.c index f87728e..1a02415 100644 --- a/libavutil/hmac.c +++ b/libavutil/hmac.c @@ -53,17

Re: [libav-devel] [PATCH 1/3] qdm2: Use avpriv_report_missing_feature()

2015-02-05 Thread Diego Biurrun
On Fri, Feb 06, 2015 at 01:49:11AM +0530, Himangi Saraogi wrote: > --- a/libavcodec/qdm2.c > +++ b/libavcodec/qdm2.c > @@ -1776,8 +1776,8 @@ static av_cold int qdm2_decode_init(AVCodecContext > *avctx) > if (extradata_size < 12) { > -av_log(avctx, AV_LOG_ERROR, "not enough extradata (

Re: [libav-devel] [PATCH 2/3] qdm2: Return meaningful error codes

2015-02-05 Thread Diego Biurrun
On Fri, Feb 06, 2015 at 01:49:29AM +0530, Himangi Saraogi wrote: > --- a/libavcodec/qdm2.c > +++ b/libavcodec/qdm2.c > @@ -1778,18 +1778,18 @@ static av_cold int qdm2_decode_init(AVCodecContext > *avctx) > if (extradata[7] == 'C') { > //s->is_qdmc = 1; > av_log(avctx, AV_LOG

Re: [libav-devel] [PATCH 3/3] qdm2: Remove SAMPLES_NEEDED macros and use avpriv_request_sample()

2015-02-05 Thread Diego Biurrun
On Fri, Feb 06, 2015 at 01:49:48AM +0530, Himangi Saraogi wrote: > --- > Not quite sure if the messages are alright. No. Look at libavutil/log.c for the implementation of avpriv_request_sample and git-grep around to see what other such function calls look like and how you should structure the cal

<    6   7   8   9   10   11   12   13   14   15   >