Re: [libav-devel] [PATCH 1/2] dca: Move syncword definitions to a separate header

2015-03-03 Thread Diego Biurrun
On Wed, Feb 25, 2015 at 03:28:13PM +0100, Diego Biurrun wrote: > --- > libavcodec/dca.c | 11 ++- > libavcodec/dca.h | 9 - > libavcodec/dca_exss.c | 1 + > libavcodec/dca_parser.c| 9 + > libavcodec/dc

Re: [libav-devel] [PATCH] pcxenc: Return more meaningful error codes

2015-03-04 Thread Diego Biurrun
On Fri, Feb 27, 2015 at 05:22:03AM +0530, Himangi Saraogi wrote: > --- a/libavcodec/pcxenc.c > +++ b/libavcodec/pcxenc.c > @@ -176,7 +176,7 @@ static int pcx_encode_frame(AVCodecContext *avctx, > AVPacket *pkt, > if ((written = pcx_rle_encode(buf, buf_end - buf, >

Re: [libav-devel] [PATCH 1/2] vorbis: Use a local codebook variable

2015-03-04 Thread Diego Biurrun
On Tue, Mar 03, 2015 at 11:11:19AM +0100, Luca Barbato wrote: > Makes the code a little simpler. > --- > libavcodec/vorbisdec.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Sure, if you prefer. Diego ___ libav-devel mailing list libav

Re: [libav-devel] [PATCH] rtpdec: experimental VP9 depacketizer (draft 0)

2015-03-04 Thread Diego Biurrun
On Wed, Mar 04, 2015 at 12:33:31AM +0100, Thomas Volkert wrote: > --- /dev/null > +++ b/libavformat/rtpdec_vp9.c > @@ -0,0 +1,294 @@ > +if (has_ss_data) { > +avpriv_report_missing_feature(ctx, "VP9 scalability structure data"); > +return AVERROR(ENOSYS); > +} > + > +if (

Re: [libav-devel] [PATCH] pcxenc: Return more meaningful error codes

2015-03-04 Thread Diego Biurrun
On Wed, Mar 04, 2015 at 09:14:04PM +0530, Himangi Saraogi wrote: > --- > libavcodec/pcxenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailma

Re: [libav-devel] [PATCH] arm: Suppress tags about used cpu arch and extensions

2015-03-05 Thread Diego Biurrun
On Thu, Mar 05, 2015 at 12:41:21AM +0200, Martin Storsjö wrote: > --- a/configure > +++ b/configure > @@ -3869,6 +3870,11 @@ if enabled_any arm aarch64 || enabled_all ppc altivec > && enabled asm; then > .func test > .endfunc > EOF > + > +# llvm's integrated assembler supports .object_arch

Re: [libav-devel] why there is no pulse audio output in libavdevice?

2015-03-05 Thread Diego Biurrun
On Thu, Mar 05, 2015 at 05:39:17PM +0800, Aihua Zhao wrote: > I noticed that there is pulse audio input in libavdevice, but not for pulse > audio output. > > What’s the reason for it? Nobody wrote one. Presumably because the person that created the input had no need for an output. Patches welco

Re: [libav-devel] [PATCH] libopenh264enc: Add support for building with OpenH264 1.4

2015-03-05 Thread Diego Biurrun
On Thu, Mar 05, 2015 at 01:59:21PM +0200, Martin Storsjö wrote: > --- a/libavcodec/libopenh264enc.c > +++ b/libavcodec/libopenh264enc.c > @@ -39,6 +39,8 @@ typedef struct SVCContext { > > +#define OPENH264_VER(maj, min) ((OPENH264_MAJOR > (maj)) || (OPENH264_MAJOR > == (maj) && OPENH264_MINOR >=

Re: [libav-devel] [PATCH] arm: Suppress tags about used cpu arch and extensions

2015-03-05 Thread Diego Biurrun
On Thu, Mar 05, 2015 at 12:20:23PM +0200, Martin Storsjö wrote: > --- a/configure > +++ b/configure > @@ -3921,6 +3922,11 @@ ra .dn d0.i16 > .unreq ra > EOF > > +# llvm's integrated assembler supports .object_arch from llvm 3.5 > +enabled arm && test "$objformat" = elf && check_as < as_

Re: [libav-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-05 Thread Diego Biurrun
On Thu, Feb 19, 2015 at 01:54:20PM +0530, Himangi Saraogi wrote: > --- a/libavcodec/tiffenc.c > +++ b/libavcodec/tiffenc.c > @@ -166,14 +166,14 @@ static int encode_strip(TiffEncoderContext *s, const > int8_t *src, > if (compress(dst, &zlen, src, n) != Z_OK) { > av_log(s->avc

Re: [libav-devel] [PATCH 2/2] dca: Support for XLL (lossless extension)

2015-03-05 Thread Diego Biurrun
On Mon, Mar 02, 2015 at 10:42:27PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-02-25 15:28:14) > > From: Niels Möller > > +return AVERROR_INVALIDDATA; > > +} else { > > +

Re: [libav-devel] [PATCH 2/2] dca: Support for XLL (lossless extension)

2015-03-06 Thread Diego Biurrun
On Mon, Mar 02, 2015 at 10:42:27PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-02-25 15:28:14) > > From: Niels Möller > > > > --- > > Review questions from last round addressed. > > The commit message and the changelog still claim it's lossles

Re: [libav-devel] [PATCH] TDSC decoder

2015-03-07 Thread Diego Biurrun
On Sat, Mar 07, 2015 at 09:03:10AM +, Vittorio Giovara wrote: > --- /dev/null > +++ b/libavcodec/tdsc.c > @@ -0,0 +1,585 @@ > +/* > + * TDSC decoder What does TDCS stand for? > +/** > + * @file > + * TDSC decoder > + * > + * Fourcc: TSDC > + * > + * Codec is very simple: > + * it codes pictu

Re: [libav-devel] [PATCH] configure: Move the .object_arch check to the right place

2015-03-07 Thread Diego Biurrun
On Sat, Mar 07, 2015 at 05:41:04PM +0200, Martin Storsjö wrote: > --- > This is where it was in the patch that was approved, even if I ended > up pushing an older version. > --- > configure | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) OK Diego __

[libav-devel] [PATCH 2/3] lavf: Explicitly convert types at function pointer assignment

2015-03-10 Thread Diego Biurrun
This fixes a number of "assignment from incompatible pointer type" warnings. --- libavformat/avio.c| 4 +++- libavformat/aviobuf.c | 4 +++- libavformat/swfenc.c | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index f68994c..ff74

[libav-devel] [PATCH 1/3] hmac: Explicitly convert types at function pointer assignment

2015-03-10 Thread Diego Biurrun
This fixes a number of "assignment from incompatible pointer type" warnings. --- libavutil/hmac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavutil/hmac.c b/libavutil/hmac.c index f87728e..1a02415 100644 --- a/libavutil/hmac.c +++ b/libavutil/hmac.c @@ -53,17

[libav-devel] [PATCH 3/3] Drop a number of pointless casts

2015-03-10 Thread Diego Biurrun
All these casts do not avoid warnings, so there is no point in obfuscating the code. --- This of course exchanges of the type warning: cast discards ‘const’ qualifier from pointer target type for warnings of the type warning: assignment discards ‘const’ qualifier from pointer target type s

Re: [libav-devel] [PATCH 57/63] h264: use the main H264Context as the parent for all slice contexts

2015-03-10 Thread Diego Biurrun
On Fri, Mar 06, 2015 at 01:24:34PM +0100, Anton Khirnov wrote: > --- a/libavcodec/h264_slice.c > +++ b/libavcodec/h264_slice.c > @@ -1726,8 +1694,8 @@ int ff_h264_decode_slice_header(H264Context *h, > H264SliceContext *sl, H264Contex > > -h0->last_slice_type = slice_type; > -sl->slice_nu

Re: [libav-devel] [PATCH 61/63] h264: use a smaller struct for the ref lists

2015-03-10 Thread Diego Biurrun
On Fri, Mar 06, 2015 at 01:24:38PM +0100, Anton Khirnov wrote: > --- a/libavcodec/h264.h > +++ b/libavcodec/h264.h > @@ -393,7 +404,7 @@ typedef struct H264SliceContext { > unsigned int ref_count[2]; ///< counts frames or fields, > depending on current mb mode > unsigned int lis

[libav-devel] [PATCH] configure: Mark qsv subsystem as not selectable on the command line

2015-03-11 Thread Diego Biurrun
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1ea6b9d..aaa34b4 100755 --- a/configure +++ b/configure @@ -1238,7 +1238,6 @@ SUBSYSTEM_LIST=" lzo mdct network -qsv rdft " @@ -1598,6 +1597,7 @@ CONFIG_EXTRA="

Re: [libav-devel] [PATCH 2/2] dca: Support for XLL (lossless extension)

2015-03-11 Thread Diego Biurrun
On Sun, Mar 08, 2015 at 03:27:52PM +0100, Niels Möller wrote: > Anton Khirnov writes: > >> +return AVERROR_INVALIDDATA; > >> +} else { > >> +unsigned c, r; > >> + for (c = i = 0; c < s->xll_channels; c++, i += chset->chann

Re: [libav-devel] [PATCH 2/2] dca: Support for XLL (lossless extension)

2015-03-11 Thread Diego Biurrun
On Wed, Mar 11, 2015 at 01:23:23PM +0100, Niels Möller wrote: > Diego Biurrun writes: > > > #define DCA_XLL_DMIX_NCOEFFS_MAX (18) > > > > typedef struct XllChSetSubHeader { > > int channels; ///< number of channels in channel set

Re: [libav-devel] [PATCH 2/2] dca: Support for XLL (lossless extension)

2015-03-11 Thread Diego Biurrun
On Wed, Mar 11, 2015 at 02:32:57PM +0100, Niels Möller wrote: > Diego Biurrun writes: > > > I don't see that saving our skin, what if chset->downmix_ncoeffs is equal > > to DCA_XLL_DMIX_NCOEFFS_MAX? Why shouldn't it overflow on the second > > iteration if

Re: [libav-devel] [PATCH 1/3] hmac: Explicitly convert types at function pointer assignment

2015-03-12 Thread Diego Biurrun
On Wed, Mar 11, 2015 at 07:39:43PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-03-10 21:38:46) > > This fixes a number of "assignment from incompatible pointer type" warnings. > > --- a/libavutil/hmac.c > > +++ b/libavutil/hmac.c > > @@ -53,17

[libav-devel] [PATCH] dca: Support for XLL (lossless extension)

2015-03-12 Thread Diego Biurrun
From: Niels Möller --- I see no more issues, I just want to run this through Oracle, once the TDSC decoder is through. - Replaced some array size magic numbers with defines. - Simplified logic flow in a few parts. - Refactored dca_get_dmix_coeff() and dca_get_inv_dmix_coeff(). - comment improvem

Re: [libav-devel] [PATCH] matroskadec: Check memory allocation

2015-03-12 Thread Diego Biurrun
On Thu, Mar 12, 2015 at 12:33:31PM +, Vittorio Giovara wrote: > --- > libavformat/matroskadec.c | 4 > 1 file changed, 4 insertions(+) There's another leak on line 1711. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.li

Re: [libav-devel] [PATCH] fomats: Check memory allocations

2015-03-12 Thread Diego Biurrun
On Thu, Mar 12, 2015 at 03:34:32PM +, Vittorio Giovara wrote: > --- > libavfilter/formats.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) fo_R_mats Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.o

Re: [libav-devel] [PATCH] matroskadec: Check memory allocations

2015-03-12 Thread Diego Biurrun
On Thu, Mar 12, 2015 at 01:04:09PM +, Vittorio Giovara wrote: > CC: libav-sta...@libav.org > --- > libavformat/matroskadec.c | 6 ++ > 1 file changed, 6 insertions(+) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.l

Re: [libav-devel] [PATCH] dca: Support for XLL (lossless extension)

2015-03-12 Thread Diego Biurrun
On Thu, Mar 12, 2015 at 04:54:01PM +0100, Niels Möller wrote: > Diego Biurrun writes: > > I see no more issues, I just want to run this through Oracle, once the > > TDSC decoder is through. > > Thanks for taking care of this! No issues so far, but let's wait until

Re: [libav-devel] [PATCH] dca: Support for XLL (lossless extension)

2015-03-12 Thread Diego Biurrun
On Thu, Mar 12, 2015 at 07:41:42PM +0100, Niels Möller wrote: > Diego Biurrun writes: > > > I'll go for the return AVERROR, as in the attached patch, OK? > > > > Diego > > > > From 9df2aee21df40cb6376a325da8ba8a731884fafb Mon Sep 17 00:00:00 2001 >

Re: [libav-devel] [PATCH] dca: Support for XLL (lossless extension)

2015-03-12 Thread Diego Biurrun
On Thu, Mar 12, 2015 at 07:41:47PM +0100, Luca Barbato wrote: > On 12/03/15 19:35, Diego Biurrun wrote: > >On Thu, Mar 12, 2015 at 04:54:01PM +0100, Niels Möller wrote: > >>Diego Biurrun writes: > >>>I see no more issues, I just want to run this through Oracle,

Re: [libav-devel] [PATCH] lavf: Replace the ASF demuxer

2015-03-12 Thread Diego Biurrun
On Thu, Mar 12, 2015 at 05:47:29PM +0100, Alexandra Hájková wrote: > --- a/libavformat/asfenc.c > +++ b/libavformat/asfenc.c > @@ -30,162 +30,28 @@ > #undef NDEBUG > #include > > +typedef struct ASFStream { > +int num; > +unsigned char seq; > +/* use for reading */ > +AVPacket

Re: [libav-devel] [PATCH 1/3] pnm: Check the height as well

2015-03-13 Thread Diego Biurrun
On Fri, Mar 13, 2015 at 02:21:23AM +0100, Luca Barbato wrote: > Avoid spurious dimension check messages that the parser might trigger. > --- a/libavcodec/pnm.c > +++ b/libavcodec/pnm.c > @@ -140,6 +140,8 @@ int ff_pnm_decode_header(AVCodecContext *avctx, > PNMContext * const s) > return A

[libav-devel] [PATCH 2/3] dca: Support for XLL (lossless extension)

2015-03-13 Thread Diego Biurrun
From: Niels Möller --- Changes since last round: - XLL disabled by default. - Return error on too many downmix coefficients This has survived Oracle, so it's good to go IMO and will hit the tree very soon, barring last minute comments/objections. Changelog | 1 + doc/general.te

[libav-devel] [PATCH 3/3] fate: Add test for DCA XLL

2015-03-13 Thread Diego Biurrun
--- tests/fate/audio.mak | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak index 1551f1b..bc107c5 100644 --- a/tests/fate/audio.mak +++ b/tests/fate/audio.mak @@ -16,11 +16,19 @@ fate-binkaudio: $(FATE_BINKAUDIO-yes) FATE_SAM

[libav-devel] [PATCH 1/3] dca: Mark syncword constants unsigned; they do not fit in 32-bit signed int

2015-03-13 Thread Diego Biurrun
--- enums are mapped to plain int, so this is maybe not enough. Better suggestions welcome. libavcodec/dca_syncwords.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/dca_syncwords.h b/libavcodec/dca_syncwords.h index 5abd480..07b60e0 100

[libav-devel] [PATCH] configure: Disable shift operator precedence warnings with MSVC

2015-03-16 Thread Diego Biurrun
--- This one appears to add little signal, but a lot of noise. configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 05608f4..f6c9bec 100755 --- a/configure +++ b/configure @@ -2736,7 +2736,7 @@ msvc_flags(){ -Wall)

Re: [libav-devel] [PATCH] dca: Read params->pancABIT0[param_index] only if part0 is set

2015-03-16 Thread Diego Biurrun
On Mon, Mar 16, 2015 at 10:34:26PM +0100, Luca Barbato wrote: > From: Niels Möller > > Prevent a spuriour read from uninitialized memory. spuriou_S Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav

Re: [libav-devel] [PATCH] x86: Put COPY3_IF_LT under HAVE_6REGS

2015-03-16 Thread Diego Biurrun
On Mon, Mar 16, 2015 at 11:32:24AM +0100, Luca Barbato wrote: > It uses 6 registers, unbreaks building on hardened x86 system. > > Bug-Id: gentoo/541930 > CC: libav-sta...@libav.org > --- > > Now with the needed header (failed at git commit --amend -a again) > > libavcodec/x86/mathops.h | 5 +++

Re: [libav-devel] [PATCH] lavf: Do not list mov-only codecs in riff tags

2015-03-17 Thread Diego Biurrun
On Mon, Mar 16, 2015 at 11:58:29AM +, Vittorio Giovara wrote: > From: Carl Eugen Hoyos > > Instead check for all mov code-points when demuxing avi > and print a warning if a video codec is found like this. > > Signed-off-by: Vittorio Giovara > --- > libavformat/Makefile | 2 +- > libavfor

Re: [libav-devel] [PATCH] mov: Work around esds parsing for TSCC2

2015-03-17 Thread Diego Biurrun
On Mon, Mar 16, 2015 at 11:58:37AM +, Vittorio Giovara wrote: > TSCC2 seems to put esds atom despite not containing MPEG-4 video. put? Maybe "use" or "add"? > Although lavf mov demuxer properly detects codec id as TSCC2, it still > tries to parse esds and since it's no MPEG-4 video it resets

Re: [libav-devel] [PATCH] fate: Move tdsc in the appropriate screen capture file

2015-03-17 Thread Diego Biurrun
On Mon, Mar 16, 2015 at 01:19:34PM +, Vittorio Giovara wrote: > On Mon, Mar 16, 2015 at 1:09 PM, Vittorio Giovara > wrote: > > --- > > tests/fate/screen.mak | 3 +++ > > tests/fate/video.mak | 3 --- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > Move *to* the appropriate... OK w

Re: [libav-devel] [PATCH] fate: Add test for tscc2 in mov

2015-03-17 Thread Diego Biurrun
On Mon, Mar 16, 2015 at 01:22:35PM +, Vittorio Giovara wrote: > --- a/tests/fate/screen.mak > +++ b/tests/fate/screen.mak > @@ -44,6 +44,9 @@ fate-tscc: $(FATE_TSCC) > FATE_SAMPLES_AVCONV-$(call DEMDEC, AVI, TSCC2) += fate-tscc2 > fate-tscc2: CMD = framecrc -i $(TARGET_SAMPLES)/tscc/tsc2_16bp

Re: [libav-devel] [PATCH] lavf: Do not list mov-only codecs in riff tags

2015-03-19 Thread Diego Biurrun
On Tue, Mar 17, 2015 at 12:55:25PM +0100, Luca Barbato wrote: > On 17/03/15 12:25, Diego Biurrun wrote: > >On Mon, Mar 16, 2015 at 11:58:29AM +, Vittorio Giovara wrote: > >>From: Carl Eugen Hoyos > >> > >>Instead check for all mov code-points when demux

Re: [libav-devel] [PATCH] fate: Add test for tscc2 in mov

2015-03-19 Thread Diego Biurrun
On Wed, Mar 18, 2015 at 12:48:18AM +, Vittorio Giovara wrote: > Rename the existing tscc2 test. > --- > tests/fate/screen.mak| 10 -- > tests/ref/fate/tscc2 | 33 - > tests/ref/fate/tscc2-avi | 33 + > tests/ref/fa

[libav-devel] [PATCH] h264_parser: Rename close() to h264_close()

2015-10-31 Thread Diego Biurrun
At least on AIX it conflicts with the close() libc function from unistd.h. --- This should hopefully fix a bunch of failing FATE instances. libavcodec/h264_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index f4

Re: [libav-devel] [PATCH] h264_parser: Rename close() to h264_close()

2015-11-01 Thread Diego Biurrun
On Sat, Oct 31, 2015 at 05:01:42PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 31, 2015 at 12:54 PM, Luca Barbato wrote: > > On 31/10/15 17:23, Diego Biurrun wrote: > >> --- a/libavcodec/h264_parser.c > >> +++ b/libavcodec/h264_parser.c > >> @@ -5

Re: [libav-devel] [PATCH] avresample: Document a little better avresample_open

2015-11-04 Thread Diego Biurrun
On Wed, Nov 04, 2015 at 09:17:24AM +0100, Luca Barbato wrote: > Bug-Id: 911 > --- > libavresample/avresample.h | 4 > 1 file changed, 4 insertions(+) avresample: Document avresample_open() a little better OK Diego ___ libav-devel mailing list lib

Re: [libav-devel] [PATCH 3/3] x86: ac3dsp: replace inline asm for in-decoder downmixing with standalone asm

2015-11-04 Thread Diego Biurrun
On Sun, Nov 01, 2015 at 09:16:22PM -0300, James Almer wrote: > On 10/28/2015 11:38 AM, Diego Biurrun wrote: > > --- /dev/null > > +++ b/libavcodec/x86/ac3dsp_downmix.asm > > @@ -0,0 +1,199 @@ > > +cglobal ac3_downmix_%1_to_%2, > > 3,in_channels+1,total_mmregs,0-m

Re: [libav-devel] [PATCH] fate: add test for ASF

2015-11-24 Thread Diego Biurrun
On Thu, Nov 19, 2015 at 02:32:16PM +0100, Alexandra Hájková wrote: > --- a/tests/fate/microsoft.mak > +++ b/tests/fate/microsoft.mak > @@ -64,3 +64,8 @@ fate-vc1: $(FATE_VC1-yes) > > FATE_SAMPLES_AVCONV-$(CONFIG_ASF_DEMUXER) += fate-asf-repldata > fate-asf-repldata: CMD = framecrc -i $(TARGET_S

Re: [libav-devel] [PATCH v3 1/3] configure: ObjC support

2015-11-26 Thread Diego Biurrun
On Mon, Nov 23, 2015 at 05:08:49PM -0500, Alexandre Lision wrote: > From: Luca Barbato > > Assumes that the C compiler and the ObjC compiler do match for now > (default for OSX) and adds the ability to add ObjC-specific cflags > (e.g. -fobjc-arc). The character mumbojumbo ObjC stands for Objecti

Re: [libav-devel] [PATCH v3 2/3] avfoundation: basic working implementation

2015-11-26 Thread Diego Biurrun
On Mon, Nov 23, 2015 at 05:08:50PM -0500, Alexandre Lision wrote: > --- a/configure > +++ b/configure > @@ -4557,6 +4559,11 @@ check_header linux/fb.h > check_header linux/videodev2.h > check_struct linux/videodev2.h "struct v4l2_frmivalenum" discrete > > +check_header AVFoundation/AVFoundation

Re: [libav-devel] [PATCH] doc: Disable deprecation warnings in the option printer

2015-11-26 Thread Diego Biurrun
On Thu, Nov 26, 2015 at 03:59:06PM +0100, Luca Barbato wrote: > --- > doc/print_options.c | 3 +++ > 1 file changed, 3 insertions(+) I tried adding this to options_table.h at some point, but that did not work. This much simpler solution does, thanks. Diego __

Re: [libav-devel] [PATCH 7/7] build: Move -Wcast-qual to the extra_warnings

2015-11-26 Thread Diego Biurrun
On Thu, Nov 26, 2015 at 05:17:31PM +0100, Luca Barbato wrote: > --- a/configure > +++ b/configure > @@ -4658,13 +4658,12 @@ check_cflags -Wall > check_cflags -Wdisabled-optimization > check_cflags -Wpointer-arith > check_cflags -Wredundant-decls > -check_cflags -Wcast-qual > check_cflags -Wwrit

Re: [libav-devel] [PATCH 2/7] avpicture: Suppress warning from deprecated code

2015-11-26 Thread Diego Biurrun
On Thu, Nov 26, 2015 at 05:17:26PM +0100, Luca Barbato wrote: > --- > libavcodec/avpicture.c | 3 +++ > libavcodec/imgconvert.c | 5 + > 2 files changed, 8 insertions(+) Yes, makes sense. Diego ___ libav-devel mailing list libav-devel@libav.org ht

Re: [libav-devel] [PATCH 6/6] hevcdsp: add x86 SIMD for MC

2015-11-27 Thread Diego Biurrun
On Wed, Nov 18, 2015 at 02:28:46PM +0100, Anton Khirnov wrote: > --- /dev/null > +++ b/libavcodec/x86/hevc_mc.asm > @@ -0,0 +1,843 @@ > --- a/libavcodec/x86/hevcdsp_init.c > +++ b/libavcodec/x86/hevcdsp_init.c > @@ -45,27 +45,271 @@ LFC_FUNCS(uint8_t, 10) > + > +#if ARCH_X86_64 > +#define QPEL_FUNC

Re: [libav-devel] [PATCH 6/6] hevcdsp: add x86 SIMD for MC

2015-11-30 Thread Diego Biurrun
On Mon, Nov 30, 2015 at 09:23:12AM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-11-27 14:59:09) > > On Wed, Nov 18, 2015 at 02:28:46PM +0100, Anton Khirnov wrote: > > > --- /dev/null > > > +++ b/libavcodec/x86/hevc_mc.asm > > > @@ -0,0

Re: [libav-devel] [PATCH 6/6] hevcdsp: add x86 SIMD for MC

2015-11-30 Thread Diego Biurrun
On Mon, Nov 30, 2015 at 10:41:14AM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-11-30 10:35:03) > > On Mon, Nov 30, 2015 at 09:23:12AM +0100, Anton Khirnov wrote: > > > Quoting Diego Biurrun (2015-11-27 14:59:09) > > > > On Wed, Nov 18, 2015 at 02:28:4

Re: [libav-devel] [PATCH] configure: Add -framework CoreVideo when building the avfoundation indev

2015-12-01 Thread Diego Biurrun
On Tue, Dec 01, 2015 at 10:15:30AM +0200, Martin Storsjö wrote: > This fixes builds with --disable-vda, which previously failed with > undefined references to CVImageBuffer* and CVPixelBuffer* functions. > --- a/configure > +++ b/configure > @@ -4564,7 +4564,7 @@ check_struct linux/videodev2.h "str

Re: [libav-devel] [PATCH] configure: Replace `pr` since it is not provided by busybox

2015-12-02 Thread Diego Biurrun
On Thu, Nov 26, 2015 at 11:41:26AM +0100, Luca Barbato wrote: > From: Kylie McClain > > While pr is a valid POSIX.1 command, its usage in configure > is a little borderline and is possible to replace it with > printf. > > --- > > The time spent by configure is pretty much the same or less, much

Re: [libav-devel] [PATCH] configure: Replace `pr` since it is not provided by busybox

2015-12-02 Thread Diego Biurrun
On Wed, Dec 02, 2015 at 12:33:27PM +0100, Diego Biurrun wrote: > On Thu, Nov 26, 2015 at 11:41:26AM +0100, Luca Barbato wrote: > > --- a/configure > > +++ b/configure > > @@ -343,7 +343,11 @@ log(){ > > > > log_file(){ > > log BEGIN $1 > &

Re: [libav-devel] [PATCH] matroskadec: Fix sample_aspect_ratio for stereo matroska content

2015-12-04 Thread Diego Biurrun
On Wed, Dec 02, 2015 at 06:13:18PM -0500, Vittorio Giovara wrote: > --- a/libavformat/matroskadec.c > +++ b/libavformat/matroskadec.c > @@ -1525,6 +1525,30 @@ static int matroska_parse_flac(AVFormatContext *s, > > +static void mkv_stereo_mode_display_mul(int stereo_mode, int *h_width, int > *h_h

Re: [libav-devel] [PATCH] swfdec: support compressed swf

2015-12-04 Thread Diego Biurrun
On Wed, Dec 02, 2015 at 06:41:00PM -0500, Vittorio Giovara wrote: > > --- a/libavformat/swfdec.c > +++ b/libavformat/swfdec.c > @@ -61,6 +67,39 @@ static int swf_probe(AVProbeData *p) > > +#if CONFIG_ZLIB > +static int zlib_refill(void *opaque, uint8_t *buf, int buf_size) size_t buf_size? The

Re: [libav-devel] [PATCH] configure: Replace `pr` since it is not provided by busybox

2015-12-04 Thread Diego Biurrun
On Wed, Dec 02, 2015 at 03:21:58PM +0100, Luca Barbato wrote: > From: Kylie McClain > > While pr is a valid POSIX.1 command, its usage in configure > is a little borderline and is possible to replace it with > printf. While pr is a valid POSIX.1 command, it is not available on some systems and c

Re: [libav-devel] [PATCH 7/7] build: Move -Wcast-qual to the extra_warnings

2015-12-04 Thread Diego Biurrun
On Thu, Nov 26, 2015 at 06:54:26PM +0100, Luca Barbato wrote: > On 26/11/15 18:40, Diego Biurrun wrote: > > On Thu, Nov 26, 2015 at 05:17:31PM +0100, Luca Barbato wrote: > >> --- a/configure > >> +++ b/configure > >> @@ -4658,13 +4658,12 @@ check_cflags

Re: [libav-devel] [PATCH 2/2] aacdec: fix aac_static_table_init() prototype

2015-12-06 Thread Diego Biurrun
On Sun, Dec 06, 2015 at 11:02:49AM +0100, Anton Khirnov wrote: > --- > libavcodec/aacdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK I have the same locally in a large branch that eliminates almost all compiler warnings, btw. Diego __

Re: [libav-devel] [PATCH] diracdec: Move strides to bytes, and pointer types to uint8_t.

2015-12-06 Thread Diego Biurrun
On Sun, Dec 06, 2015 at 12:36:24PM +, Kieran Kunhya wrote: > Start templating functions for move to support 10-bit > Parts of this patch were written by Rostislav Pehlivanov > --- a/libavcodec/diracdec.c > +++ b/libavcodec/diracdec.c > @@ -507,6 +479,38 @@ static inline int coeff_unpack_golomb(

[libav-devel] [PATCH 2/2] h264_refs: Remove broken trace debug code

2015-12-11 Thread Diego Biurrun
--- libavcodec/h264_refs.c | 16 1 file changed, 16 deletions(-) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index 46b51e0..00b96d7 100644 --- a/libavcodec/h264_refs.c +++ b/libavcodec/h264_refs.c @@ -167,22 +167,6 @@ static void h264_initialise_ref_list(H264Cont

[libav-devel] [PATCH 1/2] lavc: Add missing #includes for ff_dlog()

2015-12-11 Thread Diego Biurrun
--- libavcodec/ac3enc.c | 1 + libavcodec/mpegaudiodecheader.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index b10767a..da141e1 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc.c @@ -42,6 +42,7 @@ #include "ac3dsp.h" #incl

Re: [libav-devel] [PATCH] [RFC] get_bits: Support max_depth > 2 in GET_RL_VLC_INTERNAL

2015-12-14 Thread Diego Biurrun
On Sun, Dec 13, 2015 at 09:26:17PM +, Kieran Kunhya wrote: > On 13 December 2015 at 19:21, Luca Barbato wrote: > > > > Where do you need it? > > The author of the code tells me it is needed for the large VLCs in Cineform. You are not the author? But you just submitted it as such.. Diego __

[libav-devel] [PATCH 6/6] Use avpriv_request_sample() where appropriate

2015-12-17 Thread Diego Biurrun
--- libavcodec/flicvideo.c | 14 +++--- libavcodec/roqvideodec.c | 3 +-- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/libavcodec/flicvideo.c b/libavcodec/flicvideo.c index 3a59543..c331909 100644 --- a/libavcodec/flicvideo.c +++ b/libavcodec/flicvideo.c @@ -116,7 +11

[libav-devel] [PATCH 1/6] webp: Treat data_size greater than INT_MAX as invalid

2015-12-17 Thread Diego Biurrun
--- libavcodec/webp.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index c475744..7826cab 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1309,10 +1309,8 @@ static int vp8_lossy_decode_frame(AVCodecContext *avctx, AVFra

[libav-devel] [PATCH 2/6] rtpdec_jpeg: Coalesce redundant error checks

2015-12-17 Thread Diego Biurrun
--- libavformat/rtpdec_jpeg.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index 3bee0b2..15324bf 100644 --- a/libavformat/rtpdec_jpeg.c +++ b/libavformat/rtpdec_jpeg.c @@ -228,12 +228,6 @@ static int jpeg_parse_packet(AVFormatConte

[libav-devel] [PATCH 4/6] Remove stray line breaks from avpriv_{report_missing_feature|request_samples}

2015-12-17 Thread Diego Biurrun
--- libavcodec/exr.c | 3 +-- libavcodec/ivi.c | 2 +- libavformat/lxfdec.c | 2 +- libavformat/rtpdec_hevc.c | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index cdcdd7c..0d0ff36 100644 --- a/libavcodec/exr.c +++

[libav-devel] [PATCH 5/6] Use avpriv_report_missing_feature() where appropriate

2015-12-17 Thread Diego Biurrun
--- libavcodec/aacdec.c | 3 +-- libavcodec/alac.c | 8 libavcodec/bmp.c| 3 ++- libavcodec/fraps.c | 4 +--- libavcodec/g2meet.c | 11 +-- libavcodec/g723_1enc.c | 3 ++- libavcodec/h264_ps.c| 5 ++--- libavcodec/h

[libav-devel] [PATCH 3/6] Use correct printf conversion specifiers for unsigned types

2015-12-17 Thread Diego Biurrun
--- libavcodec/fraps.c| 2 +- libavcodec/txd.c | 4 ++-- libavformat/rtpdec_jpeg.c | 2 +- libavformat/rtpdec_xiph.c | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/fraps.c b/libavcodec/fraps.c index eb61c70..c4ec23e 100644 --- a/libavcodec/frap

Re: [libav-devel] [PATCH] h264: improve behaviour with invalid reference lists

2015-12-18 Thread Diego Biurrun
On Fri, Dec 18, 2015 at 09:49:16AM +0100, Anton Khirnov wrote: > --- > Thanks to Martin for telling me about the problem. The sample is > http://files.1f0.de/samples/h264refframeregression.mp4 > > I wonder if we should add a FATE test for this. The file is invalid, but we > probably still want it

Re: [libav-devel] [PATCH 5/6] Use avpriv_report_missing_feature() where appropriate

2015-12-22 Thread Diego Biurrun
On Thu, Dec 17, 2015 at 10:28:58AM -0500, Vittorio Giovara wrote: > On Thu, Dec 17, 2015 at 7:28 AM, Diego Biurrun wrote: > > --- a/libavcodec/alac.c > > +++ b/libavcodec/alac.c > > @@ -266,7 +266,7 @@ static int decode_element(AVCodecContext *avctx, > > A

Re: [libav-devel] [libav-commits] lavc: Deprecate coder_type and its symbols

2016-01-03 Thread Diego Biurrun
On Mon, Dec 07, 2015 at 05:43:07PM +0100, Vittorio Giovara wrote: > Module: libav > Branch: master > Commit: be00ec832c519427cd92218abac77dafdc1d5487 > > Author:Vittorio Giovara > Committer: Vittorio Giovara > Date: Mon Nov 30 12:17:31 2015 -0500 > > lavc: Deprecate coder_type and its

Re: [libav-devel] [PATCH] Cineform HD Decoder:

2016-01-04 Thread Diego Biurrun
On Mon, Jan 04, 2016 at 12:04:08AM +, Kieran Kunhya wrote: > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -212,6 +212,7 @@ OBJS-$(CONFIG_CDGRAPHICS_DECODER) += cdgraphics.o > OBJS-$(CONFIG_CDXL_DECODER)+= cdxl.o > OBJS-$(CONFIG_CINEPAK_DECODER) += cinepa

Re: [libav-devel] [PATCH 1/2] asfdec_o: only set asf_pkt->data_size after sanity checks

2016-01-05 Thread Diego Biurrun
On Tue, Jan 05, 2016 at 04:09:09PM +0100, Andreas Cadhalpun wrote: > On 05.01.2016 14:32, Luca Barbato wrote: > > On 05/01/16 13:25, Andreas Cadhalpun wrote: > >> Otherwise invalid values are used unchecked in the next run. > >> This can cause NULL pointer dereferencing. > >> > >> Signed-off-by: An

Re: [libav-devel] [PATCH 1/2] asfdec_o: only set asf_pkt->data_size after sanity checks

2016-01-06 Thread Diego Biurrun
On Tue, Jan 05, 2016 at 05:51:56PM +0100, Andreas Cadhalpun wrote: > On 05.01.2016 16:30, Diego Biurrun wrote: > > The demuxer worked perfectly with all available samples at the time, > > better in fact with some samples. It has received some improvements > > since. Remind

Re: [libav-devel] [PATCH 1/2] asfdec_o: only set asf_pkt->data_size after sanity checks

2016-01-06 Thread Diego Biurrun
On Wed, Jan 06, 2016 at 12:22:08PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-01-06 12:03:40) > > On Tue, Jan 05, 2016 at 05:51:56PM +0100, Andreas Cadhalpun wrote: > > > On 05.01.2016 16:30, Diego Biurrun wrote: > > > > The demuxer worked perfectly wit

Re: [libav-devel] [PATCH] Cineform HD Decoder:

2016-01-12 Thread Diego Biurrun
On Sun, Jan 10, 2016 at 12:31:17AM +, Kieran Kunhya wrote: > > Unchecked mallocs cause global warming, please think of the planet. > > > >> +l_h[i][0] = tmp[i]; > >> +l_h[i][1] = tmp[i] + 2 * w8 * h8; > >> +//l_h[i][2] = ll2; > >> +l_h[i][3] = tmp[i]; > >> +

[libav-devel] [PATCH 02/10] x86: build: Group all encoder objects together

2016-01-18 Thread Diego Biurrun
--- libavcodec/x86/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile index d5bd22f..4afd0a7 100644 --- a/libavcodec/x86/Makefile +++ b/libavcodec/x86/Makefile @@ -74,7 +74,6 @@ YASM-OBJS-$(CONFIG_AC3DSP) +

[libav-devel] [PATCH 06/10] x86: Use *_FAST/*_SLOW CPU feature detection macros where appropriate

2016-01-18 Thread Diego Biurrun
--- libavcodec/x86/ac3dsp_init.c | 13 - libavcodec/x86/h264_qpel.c | 11 ++- libavcodec/x86/lpc.c | 2 +- libavcodec/x86/vp8dsp_init.c | 4 ++-- 4 files changed, 17 insertions(+), 13 deletions(-) diff --git a/libavcodec/x86/ac3dsp_init.c b/libavcodec/x86/ac3dsp_in

[libav-devel] [PATCH 04/10] x86: hpeldsp: Use EXTERNAL_SSE2_FAST where appropriate

2016-01-18 Thread Diego Biurrun
--- libavcodec/x86/hpeldsp_init.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index 9ca2505..ac766ab 100644 --- a/libavcodec/x86/hpeldsp_init.c +++ b/libavcodec/x86/hpeldsp_init.c @@ -230,15 +230,

[libav-devel] [PATCH 05/10] x86: hpeldsp: Drop unused function parameters

2016-01-18 Thread Diego Biurrun
--- libavcodec/x86/hpeldsp_init.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index ac766ab..fdfe542 100644 --- a/libavcodec/x86/hpeldsp_init.c +++ b/libavcodec/x86/hpeldsp_init.c @@ -159,7 +159,

[libav-devel] [PATCH 07/10] x86: Add SSSE3_SLOW CPU flag and related convenience macros

2016-01-18 Thread Diego Biurrun
--- libavutil/cpu.h | 1 + libavutil/x86/cpu.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/libavutil/cpu.h b/libavutil/cpu.h index d640e79..3a6699a 100644 --- a/libavutil/cpu.h +++ b/libavutil/cpu.h @@ -38,6 +38,7 @@ #define AV_CPU_FLAG_SSE3SLOW 0x2000 ///< SSE3 supported,

[libav-devel] [PATCH 09/10] x86: cpu: Detect Conroe CPUs and their slow shuffle unit

2016-01-18 Thread Diego Biurrun
From: Fiona Glaser --- libavutil/x86/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/x86/cpu.c b/libavutil/x86/cpu.c index e7647dc..7cc9896 100644 --- a/libavutil/x86/cpu.c +++ b/libavutil/x86/cpu.c @@ -221,6 +221,12 @@ int ff_get_cpu_flags_x86(void) * functio

[libav-devel] [PATCH 10/10] x86: huffyuv: Use EXTERNAL_SSSE3_FAST convenience macro where appropriate

2016-01-18 Thread Diego Biurrun
--- libavcodec/x86/huffyuvdsp.asm| 4 ++-- libavcodec/x86/huffyuvdsp_init.c | 10 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/huffyuvdsp.asm b/libavcodec/x86/huffyuvdsp.asm index e7536da..692162b 100644 --- a/libavcodec/x86/huffyuvdsp.asm +++ b/lib

[libav-devel] [PATCH 03/10] x86: hpeldsp: Split off VP3-specific bits into a separate file

2016-01-18 Thread Diego Biurrun
--- libavcodec/x86/Makefile | 2 + libavcodec/x86/hpeldsp.asm| 89 -- libavcodec/x86/hpeldsp.h | 4 ++ libavcodec/x86/hpeldsp_init.c | 25 ++--- libavcodec/x86/hpeldsp_vp3.asm| 111 ++ liba

[libav-devel] [PATCH 01/10] x86: ac3dsp: Drop forward declaration for nonexisting function

2016-01-18 Thread Diego Biurrun
--- libavcodec/x86/ac3dsp_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/x86/ac3dsp_init.c b/libavcodec/x86/ac3dsp_init.c index cd638b9..23f0162 100644 --- a/libavcodec/x86/ac3dsp_init.c +++ b/libavcodec/x86/ac3dsp_init.c @@ -47,7 +47,6 @@ void ff_float_to_fixed24_sse2 (int32

[libav-devel] [PATCH 08/10] x86: cpu: Factor out CPU family check for Intel CPUs

2016-01-18 Thread Diego Biurrun
--- libavutil/x86/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/x86/cpu.c b/libavutil/x86/cpu.c index 098ccf7..e7647dc 100644 --- a/libavutil/x86/cpu.c +++ b/libavutil/x86/cpu.c @@ -200,8 +200,8 @@ int ff_get_cpu_flags_x86(void) } } -

Re: [libav-devel] [PATCH 09/10] x86: cpu: Detect Conroe CPUs and their slow shuffle unit

2016-01-18 Thread Diego Biurrun
On Mon, Jan 18, 2016 at 04:38:27PM +0100, Diego Biurrun wrote: > From: Fiona Glaser > > --- > libavutil/x86/cpu.c | 6 ++ > 1 file changed, 6 insertions(+) > > --- a/libavutil/x86/cpu.c > +++ b/libavutil/x86/cpu.c > @@ -221,6 +221,12 @@ in

Re: [libav-devel] [PATCH 03/10] x86: hpeldsp: Split off VP3-specific bits into a separate file

2016-01-18 Thread Diego Biurrun
On Mon, Jan 18, 2016 at 04:50:18PM +0100, Hendrik Leppkes wrote: > On Mon, Jan 18, 2016 at 4:38 PM, Diego Biurrun wrote: > > --- > > libavcodec/x86/Makefile | 2 + > > libavcodec/x86/hpeldsp.asm| 89 -- > > libavcodec/x

Re: [libav-devel] [PATCH 224/265] avidec: switch to codecpar

2016-01-18 Thread Diego Biurrun
On Mon, Jan 18, 2016 at 08:14:15PM +0100, Anton Khirnov wrote: > --- a/libavformat/avidec.c > +++ b/libavformat/avidec.c > @@ -1555,7 +1554,7 @@ static int avi_read_seek(AVFormatContext *s, int > stream_index, > > -//assert(st2->codec->block_align); > +//assert(st2->codecpar->blo

Re: [libav-devel] [PATCH 07/10] x86: Add SSSE3_SLOW CPU flag and related convenience macros

2016-01-19 Thread Diego Biurrun
On Mon, Jan 18, 2016 at 11:24:38PM -0300, James Almer wrote: > On 1/18/2016 12:38 PM, Diego Biurrun wrote: > > --- > > libavutil/cpu.h | 1 + > > libavutil/x86/cpu.h | 6 ++ > > Missing minor version bump. > > > --- a/libavutil/cpu.h > >

Re: [libav-devel] [PATCH 03/10] x86: hpeldsp: Split off VP3-specific bits into a separate file

2016-01-19 Thread Diego Biurrun
On Mon, Jan 18, 2016 at 04:50:18PM +0100, Hendrik Leppkes wrote: > On Mon, Jan 18, 2016 at 4:38 PM, Diego Biurrun wrote: > > --- /dev/null > > +++ b/libavcodec/x86/hpeldsp_vp3_init.c > > @@ -0,0 +1,54 @@ > > + > > +#include "libavutil/attributes.h" &g

[libav-devel] [PATCH] x86: Add SSSE3_SLOW CPU flag and related convenience macros

2016-01-19 Thread Diego Biurrun
--- Added APIchanges entry, version bump and use a non-conflicting flag value. doc/APIchanges | 3 +++ libavutil/cpu.h | 1 + libavutil/version.h | 2 +- libavutil/x86/cpu.h | 6 ++ 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

<    8   9   10   11   12   13   14   15   16   17   >