Re: [libav-devel] tests missing from FATE

2012-01-26 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 03:54:14PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: Recently the topic of adding some or all test programs to FATE that are not already part of FATE came up. Here's an overview of all those test programs not yet in FATE with some quick

[libav-devel] [PATCH] libavutil: Remove pointless rational test program.

2012-01-26 Thread Diego Biurrun
--- libavutil/Makefile |2 +- libavutil/rational.c | 25 - 2 files changed, 1 insertions(+), 26 deletions(-) diff --git a/libavutil/Makefile b/libavutil/Makefile index 4139744..96f8532 100644 --- a/libavutil/Makefile +++ b/libavutil/Makefile @@ -76,7 +76,7 @@

Re: [libav-devel] [PATCH] 8bps: KR formatting cosmetics

2012-01-26 Thread Diego Biurrun
On Thu, Jan 26, 2012 at 07:21:15PM +, Paul B Mahol wrote: --- libavcodec/8bps.c | 230 ++-- 1 files changed, 115 insertions(+), 115 deletions(-) Looks good at a glance, so queued. I might add a few small fixes before pushing if I notice

Re: [libav-devel] [PATCH 1/4] nsvdec: Check av_malloc(string_size)

2012-01-27 Thread Diego Biurrun
On Thu, Jan 26, 2012 at 05:27:13PM -0800, Alex Converse wrote: From: Michael Niedermayer michae...@gmx.at This can easily be NULL as string_size can be 2g in a damaged file. 2GB I assume - please amend the log message. Diego ___ libav-devel mailing

Re: [libav-devel] [PATCH] png: move functions to their own dspcontext.

2012-01-27 Thread Diego Biurrun
On Fri, Jan 27, 2012 at 07:54:36AM +0800, Ronald S. Bultje wrote: Also convert to yasm, add a loop to add_png_paeth_pred() to handle the case where bpp4 (e.g. RGB48), and add a SSE2 version for add_bytes_l2(). I'm with Mans on this one, the patch would benefit from splitting. --- /dev/null

[libav-devel] patch review (was: Re: [PATCH] libspeexenc: use AVSampleFormat instead of deprecated/removed SampleFormat)

2012-01-27 Thread Diego Biurrun
On Fri, Jan 27, 2012 at 04:40:14PM +, Måns Rullgård wrote: Paul B Mahol one...@gmail.com writes: On 1/27/12, Justin Ruggles justin.rugg...@gmail.com wrote: Fixes build with --enable-libspeex --- libavcodec/libspeexenc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [libav-devel] [PATCH] lavf: default .ogg encoding to vorbis instead of flac

2014-02-07 Thread Diego Biurrun
On Fri, Feb 07, 2014 at 03:41:34PM -0500, Andrew Kelley wrote: --- a/libavformat/oggenc.c +++ b/libavformat/oggenc.c @@ -616,7 +616,15 @@ AVOutputFormat ff_ogg_muxer = { +#ifdef CONFIG_LIBVORBIS_ENCODER +.audio_codec = AV_CODEC_ID_VORBIS, +#else .audio_codec =

Re: [libav-devel] [PATCH 1/1] x86: use the inline int8x8_fmul_int32 only if inline SSE2 is availbale

2014-02-08 Thread Diego Biurrun
On Sat, Feb 08, 2014 at 11:52:19AM +0100, Janne Grunau wrote: Fixes compilation with MSVC. Also does not rely on on earlier config.h include but include it directly. on on? May I suggest Oracle, which has an MSVC instance on it? --- a/libavcodec/x86/dca.h +++ b/libavcodec/x86/dca.h @@

Re: [libav-devel] [PATCH 1/1] x86: use the inline int8x8_fmul_int32 only if inline SSE2 is availbale

2014-02-08 Thread Diego Biurrun
On Sat, Feb 08, 2014 at 11:52:19AM +0100, Janne Grunau wrote: --- a/libavcodec/x86/dca.h +++ b/libavcodec/x86/dca.h @@ -18,7 +18,9 @@ -#if ARCH_X86_64 +#include config.h + +#if ARCH_X86_64 HAVE_SSE2_INLINE # include libavutil/x86/asm.h # include libavutil/mem.h Why is this

Re: [libav-devel] [PATCH 1/5] g2meet: rename FRAME_INFO to more appropriate DISPLAY_INFO

2014-02-08 Thread Diego Biurrun
On Sat, Feb 08, 2014 at 02:34:52PM +0100, Maxim Poliakovski wrote: Signed-off-by: Kostya Shishkov kostya.shish...@gmail.com --- libavcodec/g2meet.c |8 1 file changed, 4 insertions(+), 4 deletions(-) The author is incorrect. Diego ___

Re: [libav-devel] [PATCH] vp8: fix PPC assembly and bilinear C code to work if src_stride != dst_stride.

2014-02-08 Thread Diego Biurrun
On Sat, Feb 08, 2014 at 02:38:53PM +, Janne Grunau wrote: On 2014-02-06 12:05:16 +0100, Diego Biurrun wrote: On Thu, Feb 06, 2014 at 08:28:44AM +0100, Anton Khirnov wrote: On Wed, 5 Feb 2014 15:32:59 +0100, Diego Biurrun di...@biurrun.de wrote: On Wed, Feb 05, 2014 at 09:59:45AM

Re: [libav-devel] [PATCH 1/5] g2meet: rename FRAME_INFO to more appropriate DISPLAY_INFO

2014-02-08 Thread Diego Biurrun
On Sat, Feb 08, 2014 at 03:47:59PM +0100, Kostya Shishkov wrote: On Sat, Feb 08, 2014 at 02:58:48PM +0100, Diego Biurrun wrote: On Sat, Feb 08, 2014 at 02:34:52PM +0100, Maxim Poliakovski wrote: Signed-off-by: Kostya Shishkov kostya.shish...@gmail.com --- libavcodec/g2meet.c |8

Re: [libav-devel] [PATCH 7/9] tiff: use a better name and enum values for PhotometricInterpretation

2014-02-09 Thread Diego Biurrun
On Sat, Feb 08, 2014 at 05:04:04PM -0500, Justin Ruggles wrote: --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -447,20 +447,31 @@ static int tiff_decode_tag(TiffContext *s) +avpriv_report_missing_feature(s-avctx, + Unimplemented

Re: [libav-devel] [PATCH 1/5] ffv1: Remove unnecessary header

2014-02-09 Thread Diego Biurrun
On Sun, Feb 09, 2014 at 07:28:13PM +0100, Luca Barbato wrote: --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -29,11 +29,9 @@ #include libavutil/opt.h #include libavutil/imgutils.h -#include libavutil/timer.h This is required for the commented-out START/STOP_TIMER macros. I'd say

Re: [libav-devel] [PATCH 2/5] ffv1: Reorder headers

2014-02-09 Thread Diego Biurrun
On Sun, Feb 09, 2014 at 07:28:14PM +0100, Luca Barbato wrote: --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -25,17 +25,18 @@ -#include libavutil/pixdesc.h #include libavutil/crc.h #include libavutil/opt.h #include libavutil/imgutils.h +#include libavutil/pixdesc.h order

Re: [libav-devel] [PATCH 1/1] build: fix make examples when EXESUF is not empty

2014-02-10 Thread Diego Biurrun
build: fix examples compilation when EXESUF is not empty On Mon, Feb 10, 2014 at 12:47:17AM +0100, Janne Grunau wrote: From: Christophe Gisquet christophe.gisq...@gmail.com Due to a wrong substitution doc/examples is not added as prerequisite as a for the objects of the example programs.

Re: [libav-devel] [PATCH 5/5] wip: fate: FFv1 testcases

2014-02-10 Thread Diego Biurrun
On Sun, Feb 09, 2014 at 07:28:17PM +0100, Luca Barbato wrote: From: Peter B p...@das-werkstatt.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- I'm assuming this is not meant to be pushed right now? --- /dev/null +++ b/tests/fate/ffv1.mak @@ -0,0 +1,314 @@ +# This Makefile checks

Re: [libav-devel] [PATCH] dcadsp: move test out of loop and dspize

2014-02-10 Thread Diego Biurrun
On Sun, Feb 09, 2014 at 02:33:42PM +0100, Christophe Gisquet wrote: --- a/libavcodec/arm/dcadsp_init_arm.c +++ b/libavcodec/arm/dcadsp_init_arm.c @@ -53,6 +53,45 @@ void ff_synth_filter_float_neon(FFTContext *imdct, +#if HAVE_NEON_INLINE HAVE_ASM_MOD_Y + +static inline void

Re: [libav-devel] [PATCH 4/5] ffv1: frame threading

2014-02-10 Thread Diego Biurrun
On Sun, Feb 09, 2014 at 07:28:16PM +0100, Luca Barbato wrote: --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -353,6 +354,43 @@ static int decode_slice(AVCodecContext *c, void *arg) +memcpy(pdst, psrc, sizeof(*pdst)); +pdst-state = NULL; +

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-10 Thread Diego Biurrun
On Sat, Feb 08, 2014 at 08:59:33PM -0500, Andrew Kelley wrote: --- a/doc/filters.texi +++ b/doc/filters.texi @@ -467,6 +467,80 @@ To fix a 5.1 WAV improperly encoded in AAC's native channel order + +@item attacks +@item decays +Set list of times in seconds for each channel over which the

Re: [libav-devel] [PATCH] libavfilter: example audio filtering program

2014-02-11 Thread Diego Biurrun
The build system still needs some love regarding Doxygen, looking into it... On Mon, Feb 10, 2014 at 09:23:40PM +0100, Anton Khirnov wrote: --- /dev/null +++ b/doc/examples/filter_audio.c @@ -0,0 +1,362 @@ + +/** + * @file + * libavfilter API use example. usage + * @example

Re: [libav-devel] [PATCH] libavformat/mpegts: expose raw packet size

2014-02-11 Thread Diego Biurrun
On Fri, Jan 31, 2014 at 02:48:11PM -0200, Leandro Dorileo wrote: We cannot easily determine if an mpeg TS's packet size is DVHS, FEC or so on, for that we need to expose the internal raw_packet_size field. Change-Id: I3eb179703b62748ae8bec6bd85a50760c0bc6d84 What's this Change-Id thing?

Re: [libav-devel] [PATCH 2/2] lavfi doxy: add buffer{src, sink}.h to the main lavfi doxy group

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 07:15:05AM +0100, Anton Khirnov wrote: --- libavfilter/buffersink.h | 11 +++ libavfilter/buffersrc.h | 11 +++ 2 files changed, 22 insertions(+) OK Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/2] buffersink: document special error codes returned from av_buffersink_get_frame

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 07:15:04AM +0100, Anton Khirnov wrote: --- a/libavfilter/buffersink.h +++ b/libavfilter/buffersink.h @@ -86,6 +90,9 @@ int av_buffersink_get_frame(AVFilterContext *ctx, AVFrame *frame); * frame will contain exactly nb_samples audio samples, except at

Re: [libav-devel] dca xll aka DTS-HD Master Audio

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 08:52:12AM +0100, Niels Möller wrote: A couple of questions: * the libavcodec/dcadec.c file look a bit different in ffmpeg and libav, and ffmpeg includes handling of the XXCH extension. I'm not yet familiar enough with dca to say how related this is to xll, but

Re: [libav-devel] dca xll aka DTS-HD Master Audio

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 01:57:58PM +0100, Niels Möller wrote: Diego Biurrun di...@biurrun.de writes: On Tue, Feb 11, 2014 at 08:52:12AM +0100, Niels Möller wrote: A couple of questions: * the libavcodec/dcadec.c file look a bit different in ffmpeg and libav, and ffmpeg includes

Re: [libav-devel] [PATCH] libavformat/mpegts: expose raw packet size

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 02:40:49PM +0100, Luca Barbato wrote: On 11/02/14 14:37, Leandro Dorileo wrote: Diego Biurrun wrote: On Fri, Jan 31, 2014 at 02:48:11PM -0200, Leandro Dorileo wrote: We cannot easily determine if an mpeg TS's packet size is DVHS, FEC or so on, for that we need

Re: [libav-devel] [PATCH] Add libx265 encoder

2014-02-11 Thread Diego Biurrun
I believe this also warrants a docs update. On Tue, Feb 11, 2014 at 06:39:28PM +, Derek Buitenhuis wrote: --- /dev/null +++ b/libavcodec/libx265.c @@ -0,0 +1,279 @@ + +#include libavutil/internal.h +#include libavutil/common.h +#include libavutil/opt.h +#include libavutil/pixdesc.h

Re: [libav-devel] [PATCH] Add libx265 encoder

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 07:46:41PM +, Derek Buitenhuis wrote: On 2/11/2014 7:37 PM, Diego Biurrun wrote: +memset(x265pic_out, 0, sizeof(x265pic_out)); x265_picture x265pic_out = { 0 }; Causes additional compiler warnings with gcc and clang: /home/daemon404/dev/l/libav

[libav-devel] [PATCH 5/5] build: doxy: Include code examples in Doxygen documentation

2014-02-11 Thread Diego Biurrun
--- doc/Makefile | 4 ++-- library.mak | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/Makefile b/doc/Makefile index cf3fbab..c629783 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -19,7 +19,7 @@ DOC_EXAMPLES-$(CONFIG_OUTPUT_EXAMPLE) += output

[libav-devel] [PATCH 4/5] doxygen: Set EXAMPLE_PATH from within doxy-wrapper.sh

2014-02-11 Thread Diego Biurrun
This allows using the libav source path as the example path. --- doc/Doxyfile| 3 +-- doc/doxy-wrapper.sh | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/Doxyfile b/doc/Doxyfile index 349db1a..58f7dfb 100644 --- a/doc/Doxyfile +++ b/doc/Doxyfile @@ -639,8 +639,7

[libav-devel] [PATCH 1/5] Doxyfile: Only set HTML_{HEADER|FOOTER|STYLESHEET} from doxy_wrapper.sh

2014-02-11 Thread Diego Biurrun
--- doc/Doxyfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/Doxyfile b/doc/Doxyfile index ae65478..349db1a 100644 --- a/doc/Doxyfile +++ b/doc/Doxyfile @@ -794,13 +794,13 @@ HTML_FILE_EXTENSION= .html # each generated HTML page. If it is left blank doxygen

[libav-devel] [PATCH 3/5] build: Do not pass HTML snippets and stylesheet as input to Doxygen

2014-02-11 Thread Diego Biurrun
These files are referenced elsewhere and only generate warnings if presented to Doxygen as input files. --- doc/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/Makefile b/doc/Makefile index e92e72f..cf3fbab 100644 --- a/doc/Makefile +++ b/doc/Makefile @@

[libav-devel] [PATCH 2/5] doc/examples: misc Doxygen markup improvements

2014-02-11 Thread Diego Biurrun
Add properly formatted @example tag and fix Doxygen syntax. --- doc/examples/output.c| 4 ++-- doc/examples/transcode_aac.c | 5 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/examples/output.c b/doc/examples/output.c index 06fdf50..3be85de 100644 ---

Re: [libav-devel] [PATCH] libavfilter: example audio filtering program

2014-02-11 Thread Diego Biurrun
On Mon, Feb 10, 2014 at 09:23:40PM +0100, Anton Khirnov wrote: Based on a patch by Andrew Kelley superjo...@gmail.com --- configure |2 + doc/Makefile|3 +- doc/examples/filter_audio.c | 362 +++ 3 files

Re: [libav-devel] [PATCH 1/5] Doxyfile: Only set HTML_{HEADER|FOOTER|STYLESHEET} from doxy_wrapper.sh

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 09:45:20PM +0100, Luca Barbato wrote: On 11/02/14 21:39, Diego Biurrun wrote: --- doc/Doxyfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) why that? It's redundant and confusing. Diego ___ libav-devel

Re: [libav-devel] [PATCH v2] Add libx265 encoder

2014-02-11 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 08:35:13PM +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- Changelog | 1 + LICENSE| 2 +- configure | 7 ++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 +

[libav-devel] [PATCH 2/2] buffersrc: Have function parameter names match between .c and .h file

2014-02-11 Thread Diego Biurrun
This fixes two related Doxygen warnings. Also document one parameter. --- libavfilter/buffersrc.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavfilter/buffersrc.h b/libavfilter/buffersrc.h index c6f7ff9..0f9d93a 100644 --- a/libavfilter/buffersrc.h +++

[libav-devel] [PATCH 1/2] log: Have function parameter names match between .c and .h file

2014-02-11 Thread Diego Biurrun
This fixes two related Doxygen warnings. --- libavutil/log.c | 8 libavutil/log.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavutil/log.c b/libavutil/log.c index 7d574f6..3cc811b 100644 --- a/libavutil/log.c +++ b/libavutil/log.c @@ -94,20 +94,20 @@

Re: [libav-devel] [PATCH] libavfilter: example audio filtering program

2014-02-12 Thread Diego Biurrun
On Wed, Feb 12, 2014 at 07:30:57AM +0100, Anton Khirnov wrote: On Tue, 11 Feb 2014 21:44:34 +0100, Diego Biurrun di...@biurrun.de wrote: On Mon, Feb 10, 2014 at 09:23:40PM +0100, Anton Khirnov wrote: Based on a patch by Andrew Kelley superjo...@gmail.com --- configure

Re: [libav-devel] [PATCH] h264: Report the missing PPS and SPS index

2014-02-12 Thread Diego Biurrun
On Wed, Feb 12, 2014 at 03:44:27PM +0100, Luca Barbato wrote: --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -261,13 +261,13 @@ static inline int parse_nal_units(AVCodecParserContext *s, if (!h-pps_buffers[pps_id]) { av_log(h-avctx,

[libav-devel] [PATCH] build: doxy: Include code examples in Doxygen documentation

2014-02-12 Thread Diego Biurrun
--- Now without stray Make warnings. doc/Makefile | 2 +- library.mak | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/Makefile b/doc/Makefile index cf3fbab..6af8116 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -57,7 +57,7 @@ $(DOCS) doc/doxy/html: | doc/

Re: [libav-devel] [PATCH 1/3] h264: print values in case of error

2014-02-13 Thread Diego Biurrun
On Thu, Feb 13, 2014 at 12:47:27AM +0100, Vittorio Giovara wrote: Also uniform error style and drop redudant information. to uniform as a verb only means to put into a uniform (clothing), so I suggest make consistent here. redu_n_dant --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@

Re: [libav-devel] [PATCH 2/2] configure: link only avconv against -lvpdau if needed

2014-02-13 Thread Diego Biurrun
On Thu, Feb 13, 2014 at 12:57:50AM +0100, Janne Grunau wrote: Write all LIBS-$program variables to config.mak. Bug-Id: 635 --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) The log message does not really match the patch, this is much more general than just

Re: [libav-devel] [PATCH 2/2] configure: link only avconv against -lvpdau if needed

2014-02-13 Thread Diego Biurrun
On Thu, Feb 13, 2014 at 12:26:50PM +0100, Janne Grunau wrote: On 2014-02-13 12:14:46 +0100, Diego Biurrun wrote: On Thu, Feb 13, 2014 at 12:57:50AM +0100, Janne Grunau wrote: --- a/configure +++ b/configure @@ -4453,6 +4454,13 @@ get_version(){ +print_program_libs

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-14 Thread Diego Biurrun
On Mon, Feb 10, 2014 at 11:43:52AM -0500, Andrew Kelley wrote: On Mon, Feb 10, 2014 at 7:13 AM, Diego Biurrun di...@biurrun.de wrote: On Sat, Feb 08, 2014 at 08:59:33PM -0500, Andrew Kelley wrote: +int chan, i, av_uninit(dindex), oindex, av_uninit(count); The av_uninit look fishy

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-14 Thread Diego Biurrun
On Fri, Feb 14, 2014 at 02:56:46AM -0500, Andrew Kelley wrote: This patch adds the `compand` audio filter from ffmpeg master branch (currently at 7f0f47b3df) adapted to work with libav. The following changes are made: * use float instead of double * use strtok_r instead of av_strtok *

Re: [libav-devel] [PATCH 1/5] Doxyfile: Only set HTML_{HEADER|FOOTER|STYLESHEET} from doxy_wrapper.sh

2014-02-14 Thread Diego Biurrun
On Tue, Feb 11, 2014 at 09:39:38PM +0100, Diego Biurrun wrote: [...] ping all other patches in the set Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/5] doxygen: Set EXAMPLE_PATH from within doxy-wrapper.sh

2014-02-14 Thread Diego Biurrun
On Fri, Feb 14, 2014 at 11:26:44AM +0100, Luca Barbato wrote: On 11/02/14 21:39, Diego Biurrun wrote: This allows using the libav source path as the example path. Imperative form please. Not sure what you mean by imperative form ... Diego

Re: [libav-devel] [PATCH] build: doxy: Include code examples in Doxygen documentation

2014-02-14 Thread Diego Biurrun
On Fri, Feb 14, 2014 at 11:25:58AM +0100, Luca Barbato wrote: On 12/02/14 15:58, Diego Biurrun wrote: --- a/doc/Makefile +++ b/doc/Makefile @@ -57,7 +57,7 @@ $(DOCS) doc/doxy/html: | doc/ $(DOC_EXAMPLES:%$(EXESUF)=%.o): | doc/examples OBJDIRS += doc/examples -DOXY_INPUT

Re: [libav-devel] [PATCH][RFC] vf_interlace: deprecate lowpass option

2014-02-14 Thread Diego Biurrun
On Fri, Feb 14, 2014 at 06:01:44AM +0100, Vittorio Giovara wrote: --- Turning off the lowpass filter while interlacing is a terrible idea as it can easily gernerate terrible results; the effect would be similar to decimating vertically by dropping the odd lines. So I propose to remove this

Re: [libav-devel] [PATCH][RFC] vf_interlace: deprecate lowpass option

2014-02-14 Thread Diego Biurrun
On Fri, Feb 14, 2014 at 12:47:20PM +0100, Anton Khirnov wrote: On Fri, 14 Feb 2014 06:01:44 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Turning off the lowpass filter while interlacing is a terrible idea as it can easily gernerate terrible results; the effect would be

Re: [libav-devel] [PATCH][RFC] vf_interlace: deprecate lowpass option

2014-02-14 Thread Diego Biurrun
On Fri, Feb 14, 2014 at 03:59:18PM +0100, Anton Khirnov wrote: On Fri, 14 Feb 2014 12:56:46 +0100, Diego Biurrun di...@biurrun.de wrote: On Fri, Feb 14, 2014 at 12:47:20PM +0100, Anton Khirnov wrote: On Fri, 14 Feb 2014 06:01:44 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote

[libav-devel] [PATCH 1/2] Move all example programs to doc/examples

2014-02-15 Thread Diego Biurrun
--- configure | 4 doc/Makefile | 4 +++- libavcodec/api-example.c = doc/examples/avcodec.c| 2 +- libavformat/metadata-example.c = doc/examples/metadata.c | 2 +- libavcodec/Makefile

[libav-devel] [PATCH 2/2] build: Drop support for building examples in library directories

2014-02-15 Thread Diego Biurrun
All the examples live below doc/examples/ now. --- common.mak | 1 - doc/doxy-wrapper.sh | 2 +- doc/examples/avcodec.c | 2 +- doc/examples/metadata.c | 2 +- doc/examples/output.c| 2 +- doc/examples/transcode_aac.c | 2 +- library.mak

Re: [libav-devel] [PATCH 1/2] Move all example programs to doc/examples

2014-02-15 Thread Diego Biurrun
On Sat, Feb 15, 2014 at 06:06:23PM +0100, Luca Barbato wrote: On 15/02/14 16:58, Diego Biurrun wrote: --- configure | 4 doc/Makefile | 4 +++- libavcodec/api-example.c = doc/examples

Re: [libav-devel] [PATCH] vf_interlace: deprecate lowpass option

2014-02-16 Thread Diego Biurrun
On Sun, Feb 16, 2014 at 08:09:01PM +0100, Vittorio Giovara wrote: On Sunday, February 16, 2014, Diego Biurrun di...@biurrun.de wrote: On Sat, Feb 15, 2014 at 06:40:57PM +0100, Vittorio Giovara wrote: --- a/libavfilter/vf_interlace.c +++ b/libavfilter/vf_interlace.c @@ -44,7 +44,9

Re: [libav-devel] [PATCH] Move all example programs to doc/examples

2014-02-16 Thread Diego Biurrun
On Sun, Feb 16, 2014 at 09:40:34PM +0100, Diego Biurrun wrote: Also drop support for building examples in library directories. --- Both previous patches squashed together now. common.mak| 1 - configure

[libav-devel] [PATCH] doc: Fix project name typo

2014-02-16 Thread Diego Biurrun
--- doc/general.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/general.texi b/doc/general.texi index bb2fcf3..6bc7fda 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -112,7 +112,7 @@ to enable it. @float note x265 is under the GNU Public License Version 2

[libav-devel] [PATCH] doxygen: Add a bunch of missing function parameter descriptions

2014-02-16 Thread Diego Biurrun
--- Maybe this could be split in several parts, maybe not. libavcodec/avcodec.h | 2 ++ libavcodec/avfft.h | 2 ++ libavformat/avformat.h | 16 libavformat/avio.h | 6 ++ 4 files changed, 26 insertions(+) diff --git a/libavcodec/avcodec.h

Re: [libav-devel] [PATCH 4/4] h264: use avpriv_request_sample for choma_format_idc

2014-02-16 Thread Diego Biurrun
On Sun, Feb 16, 2014 at 11:08:45PM +0100, Vittorio Giovara wrote: --- libavcodec/h264_ps.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ch_R_oma Diego ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] doxygen: Replace @parblock syntax with manual linebreaks

2014-02-16 Thread Diego Biurrun
@parblock is only supported in very recent Doxygen versions. --- libavformat/avformat.h | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 0b8fca2..49c11ca 100644 --- a/libavformat/avformat.h +++

Re: [libav-devel] [PATCH] atomics: Check dependencies for enabling threading at the configure stage

2014-02-17 Thread Diego Biurrun
On Fri, Dec 27, 2013 at 11:41:36AM +0200, Martin Storsjö wrote: On Fri, 27 Dec 2013, Diego Biurrun wrote: On Thu, Dec 26, 2013 at 07:42:05PM +0200, Martin Storsjö wrote: On Wed, 25 Dec 2013, Diego Biurrun wrote: --- Disregard the previous version, which was completely broken. configure

[libav-devel] [PATCH] atomics: Check dependencies for enabling threading at the configure stage

2014-02-17 Thread Diego Biurrun
--- Now without a silly leftover line in configure. configure | 2 +- libavutil/atomic.c | 6 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 292da47..cb566c0 100755 --- a/configure +++ b/configure @@ -1606,7 +1606,7 @@

Re: [libav-devel] [PATCH] atomics: Check dependencies for enabling threading at the configure stage

2014-02-17 Thread Diego Biurrun
On Mon, Feb 17, 2014 at 03:31:20PM +0200, Martin Storsjö wrote: On Mon, 17 Feb 2014, Diego Biurrun wrote: --- a/configure +++ b/configure @@ -1606,7 +1606,7 @@ atomics_gcc_if=sync_val_compare_and_swap atomics_suncc_if=atomic_cas_ptr machine_rw_barrier atomics_win32_if=MemoryBarrier

[libav-devel] [PATCH] atomics: Check dependencies for enabling threading at the configure stage

2014-02-17 Thread Diego Biurrun
--- Now setting explicit dependencies for w32threads. configure | 1 + libavutil/atomic.c | 6 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 292da47..841c39a 100755 --- a/configure +++ b/configure @@ -1606,6 +1606,7 @@

Re: [libav-devel] [PATCH] atomics: Check dependencies for enabling threading at the configure stage

2014-02-17 Thread Diego Biurrun
On Mon, Feb 17, 2014 at 05:53:32PM +0200, Martin Storsjö wrote: On Mon, 17 Feb 2014, Diego Biurrun wrote: On Mon, Feb 17, 2014 at 03:31:20PM +0200, Martin Storsjö wrote: On Mon, 17 Feb 2014, Diego Biurrun wrote: Doing this kinda gives you a circular dependency, enabling 'threads' requires

Re: [libav-devel] [PATCH 1/5] configure: miscellaneous cosmetics

2014-02-17 Thread Diego Biurrun
On Sat, Dec 21, 2013 at 04:24:35PM +0100, Diego Biurrun wrote: On Fri, Dec 13, 2013 at 08:04:57PM +0100, Diego Biurrun wrote: On Sat, Nov 02, 2013 at 05:21:49PM +0100, Diego Biurrun wrote: Sort lists of components. Sort function checks and group them in more sensible blocks. Add some

Re: [libav-devel] [PATCH 1/2] Announce the creation of the 10 branch and release of beta 1.

2014-02-18 Thread Diego Biurrun
On Tue, Feb 18, 2014 at 12:34:40PM +0100, Anton Khirnov wrote: --- src/download | 22 ++ src/news | 16 2 files changed, 38 insertions(+) Thanks for beating me to it. --- a/src/download +++ b/src/download @@ -198,6 +198,28 @@ selected changes

Re: [libav-devel] [PATCH 1/2] doc: Sort the muxer documentation

2014-02-18 Thread Diego Biurrun
On Tue, Feb 18, 2014 at 05:51:18PM +0100, Luca Barbato wrote: Keep the sections alphabetically sorted. --- doc/muxers.texi | 334 1 file changed, 167 insertions(+), 167 deletions(-) This does not look alphabetical to me. Diego

Re: [libav-devel] [PATCH 2/2] nut: experimental pipe and broadcast mode

2014-02-18 Thread Diego Biurrun
On Tue, Feb 18, 2014 at 05:51:19PM +0100, Luca Barbato wrote: --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -369,6 +369,20 @@ Alternatively you can write the command as: +@section nut + +@table @option +@item -nut_flags @var{flags} +Modify the nut muxing behaviour in specific ways:

[libav-devel] [PATCH] gitignore: Add all examples below doc/examples

2014-02-18 Thread Diego Biurrun
--- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 01d93b9..2333950 100644 --- a/.gitignore +++ b/.gitignore @@ -32,6 +32,8 @@ /doc/avoptions_codec.texi /doc/avoptions_format.texi /doc/doxy/html/ +/doc/examples/avcodec +/doc/examples/metadata

[libav-devel] [PATCH] Give IDCT matrix transpose macro a more descriptive name

2014-02-18 Thread Diego Biurrun
This also avoids a macro name clash and related warning on ARM. --- libavcodec/vp56.c: In function ‘ff_vp56_init’: libavcodec/vp56.c:667:0: warning: T redefined [enabled by default] In file included from libavcodec/vp56.h:237:0, from libavcodec/vp56.c:30:

Re: [libav-devel] [PATCH] doc: Name the MOV muxer as it should be called

2014-02-19 Thread Diego Biurrun
On Tue, Feb 18, 2014 at 10:04:13PM +0100, Luca Barbato wrote: The section name is the muxer, not the format. --- Mixed up f4f with f4v, thanks to Martin to telling me which is which. doc/muxers.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) OK I guess. Diego

Re: [libav-devel] [PATCH 1/2] doc: Sort the muxer documentation

2014-02-19 Thread Diego Biurrun
On Tue, Feb 18, 2014 at 09:59:54PM +0100, Luca Barbato wrote: Keep the sections alphabetically sorted. --- doc/muxers.texi | 334 1 file changed, 167 insertions(+), 167 deletions(-) This does not look sorted to me. Diego

Re: [libav-devel] [PATCH] bugreports: Make apparent where the bugtracker is

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 11:44:43AM +0100, Luca Barbato wrote: --- a/src/bugreports +++ b/src/bugreports @@ -1,4 +1,9 @@ +p +Bugs and feature requests are tracked using +a href=http://bugzilla.libav.org;bugzilla/a. B_ugzilla Keep the trailing / for URL correctness. --- a/src/contact +++

Re: [libav-devel] [PATCH] vf_interlace: deprecate lowpass option

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 03:15:40AM +0100, Vittorio Giovara wrote: --- a/doc/filters.texi +++ b/doc/filters.texi @@ -1426,7 +1426,8 @@ a float number which specifies chroma temporal strength, defaults to Simple interlacing filter from progressive contents. This interleaves upper (or

Re: [libav-devel] [PATCH] hevc: Always consider fatal VLC NALU type mismatch

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 12:02:05AM +0100, Luca Barbato wrote: Sample-Id: 1667-google Reported-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/hevc.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) Always

Re: [libav-devel] [PATCH 1/2] doc: Sort the muxer documentation

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 01:17:44PM +0100, Luca Barbato wrote: On 19/02/14 12:11, Diego Biurrun wrote: On Tue, Feb 18, 2014 at 09:59:54PM +0100, Luca Barbato wrote: Keep the sections alphabetically sorted. --- doc/muxers.texi | 334

Re: [libav-devel] [PATCH] vf_interlace: deprecate lowpass option

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 01:52:30PM +0100, Tim Walker wrote: On 19 Feb 2014, at 12:23, Diego Biurrun di...@biurrun.de wrote: This is ungrammatical, choose one of to avoid twitter effect_s and reduce moire patterns. to avoid _the_ twitter effect and reduce moire patterns

Re: [libav-devel] [PATCH] hevc: Always consider fatal VLC NALU type mismatch

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 01:50:25PM +0100, Tim Walker wrote: On 19 Feb 2014, at 12:24, Diego Biurrun di...@biurrun.de wrote: On Wed, Feb 19, 2014 at 12:02:05AM +0100, Luca Barbato wrote: Sample-Id: 1667-google Reported-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta

[libav-devel] [PATCH] threads: Check w32threads dependencies at the configure stage

2014-02-19 Thread Diego Biurrun
Also add warning comment about threading implementations without matching atomics implementation to the atomics fallback implementation. --- configure | 1 + libavutil/atomic.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [libav-devel] [PATCH] threads: Check w32threads dependencies at the configure stage

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 04:02:31PM +0200, Martin Storsjö wrote: On Wed, 19 Feb 2014, Diego Biurrun wrote: --- a/libavutil/atomic.c +++ b/libavutil/atomic.c @@ -97,8 +97,10 @@ void *avpriv_atomic_ptr_cas(void * volatile *ptr, void *oldval, void *newval) -#else +#else /* HAVE_THREADS

[libav-devel] [PATCH 2/2] build: Do not redundantly specifiy H.263-related object files for MSMPEG4v*

2014-02-19 Thread Diego Biurrun
These are already covered through dependencies specified in configure. --- libavcodec/Makefile | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 7b50c27..f975f16 100644 --- a/libavcodec/Makefile +++

[libav-devel] [PATCH 1/2] build: The MPEG-4 video parser depends on h263dsp

2014-02-19 Thread Diego Biurrun
The dependency is indirect through the h263/mpegvideo code. CC: libav-sta...@libav.org --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 841c39a..07fa54d 100755 --- a/configure +++ b/configure @@ -1845,7 +1845,7 @@

Re: [libav-devel] [PATCH 2/4] avconv: remove a write-only variable

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 09:06:09PM +0100, Anton Khirnov wrote: --- avconv.c |1 - avconv.h |1 - 2 files changed, 2 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/7] configure: Add usan to the toolchain

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 10:43:07PM +0100, Luca Barbato wrote: clang-3.4 and gcc-4.9 have it. --- configure | 10 ++ 1 file changed, 10 insertions(+) configure: Add usan to the toolchain presets patch OK Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/7] hevc: Remove undefined behaviour

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 10:43:08PM +0100, Luca Barbato wrote: --- libavcodec/hevcpred_template.c | 43 ++ 1 file changed, 23 insertions(+), 20 deletions(-) Please elaborate what is undefined here. Diego ___

Re: [libav-devel] [PATCH 5/7] hevc: Remove undefined behaviour

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 10:43:11PM +0100, Luca Barbato wrote: --- libavcodec/hevcdsp_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Again, please elaborate what is undefined. Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 6/7] hevc: Remove an undefined behaviour from get_pcm

2014-02-19 Thread Diego Biurrun
On Wed, Feb 19, 2014 at 10:43:12PM +0100, Luca Barbato wrote: --- libavcodec/hevc_filter.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) Please elaborate what is undefined here. Diego ___ libav-devel mailing list

[libav-devel] [PATCH 2/5] bit_depth_template: Use file name as multiple inclusion guard

2014-02-20 Thread Diego Biurrun
--- libavcodec/bit_depth_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/bit_depth_template.c b/libavcodec/bit_depth_template.c index 37d02ad..8fc826b 100644 --- a/libavcodec/bit_depth_template.c +++ b/libavcodec/bit_depth_template.c @@ -22,7 +22,7 @@

[libav-devel] [PATCH 1/5] svq3: Adjust #endif comment

2014-02-20 Thread Diego Biurrun
--- libavcodec/svq3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/svq3.h b/libavcodec/svq3.h index 8c67a23..a20e620 100644 --- a/libavcodec/svq3.h +++ b/libavcodec/svq3.h @@ -24,4 +24,4 @@ void ff_svq3_luma_dc_dequant_idct_c(int16_t *output, int16_t *input, int

[libav-devel] [PATCH 4/5] avcodec: Consistently name encoder init functions foo_encode_init

2014-02-20 Thread Diego Biurrun
--- libavcodec/a64multienc.c | 6 +++--- libavcodec/dvenc.c | 4 ++-- libavcodec/libvorbis.c | 5 ++--- libavcodec/rawenc.c | 4 ++-- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git a/libavcodec/a64multienc.c b/libavcodec/a64multienc.c index 11d6e2c..786074f 100644 ---

[libav-devel] [PATCH 3/5] x86: dsputil: Use correct file name as multiple inclusion guard

2014-02-20 Thread Diego Biurrun
--- libavcodec/x86/dsputil_x86.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/x86/dsputil_x86.h b/libavcodec/x86/dsputil_x86.h index c8615b2..c003cee 100644 --- a/libavcodec/x86/dsputil_x86.h +++ b/libavcodec/x86/dsputil_x86.h @@ -19,8 +19,8 @@ *

[libav-devel] [PATCH 5/5] mpeg4video_parser: Drop pointless av_-prefix from static function

2014-02-20 Thread Diego Biurrun
--- libavcodec/mpeg4video_parser.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpeg4video_parser.c b/libavcodec/mpeg4video_parser.c index a5689aa..246bb9c 100644 --- a/libavcodec/mpeg4video_parser.c +++ b/libavcodec/mpeg4video_parser.c @@ -71,9 +71,8 @@

[libav-devel] [PATCH] configure: Add missing dependency of Snow decoder on videodsp

2014-02-21 Thread Diego Biurrun
--- This applies to the 9 branch only. Done for completeness, not that anybody cares... configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6ab04ae..d2b4122 100755 --- a/configure +++ b/configure @@ -1562,7 +1562,7 @@

[libav-devel] [PATCH] libvorbis: Give consistent names to all functions, structs, and defines

2014-02-21 Thread Diego Biurrun
--- libavcodec/libvorbis.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavcodec/libvorbis.c b/libavcodec/libvorbis.c index 545aa72..4b4caaa 100644 --- a/libavcodec/libvorbis.c +++ b/libavcodec/libvorbis.c @@ -43,11 +43,11 @@ *

Re: [libav-devel] [PATCH] libvorbis: Give consistent names to all functions, structs, and defines

2014-02-21 Thread Diego Biurrun
On Fri, Feb 21, 2014 at 12:34:41PM +0200, Martin Storsjö wrote: On Fri, 21 Feb 2014, Diego Biurrun wrote: --- libavcodec/libvorbis.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) Why does this commit message not state the most important fact

Re: [libav-devel] [PATCH 2/7] x86: dcadsp: implement SSE lfe_dir

2014-02-24 Thread Diego Biurrun
On Sat, Feb 22, 2014 at 07:59:17PM +0100, Janne Grunau wrote: --- a/libavcodec/x86/dcadsp.asm +++ b/libavcodec/x86/dcadsp.asm @@ -88,3 +88,90 @@ INT8X8_FMUL_INT32 INIT_XMM sse4 INT8X8_FMUL_INT32 + +; %1=v0/v1 %2=in1 %3=in2 +%macro FIR_LOOP 2-3 +.loop%1: +%define va m1

Re: [libav-devel] [PATCH 4/7] x86: synth filter float: implement SSE2 version

2014-02-24 Thread Diego Biurrun
On Sat, Feb 22, 2014 at 07:59:19PM +0100, Janne Grunau wrote: --- a/libavcodec/x86/dcadsp.asm +++ b/libavcodec/x86/dcadsp.asm @@ -175,3 +175,157 @@ cglobal dca_lfe_fir%1, 3,3,6-%1, out, in, cf0 + +INIT_XMM sse2 +%macro INNER_LOOP 1 +; reading backwards: ptr1=synth_buf+j+i

<    5   6   7   8   9   10   11   12   13   14   >