Re: [libav-devel] [PATCH 2/2] Add support for building shared libraries with MSVC

2012-10-13 Thread Martin Storsjö
On Sat, 13 Oct 2012, Martin Storsjö wrote: diff --git a/library.mak b/library.mak index b365935..318fe86 100644 --- a/library.mak +++ b/library.mak @@ -19,6 +19,7 @@ $(SUBDIR)x86/%.o: $(SUBDIR)x86/%.asm $(DEPYASM) $(YASMFLAGS) -I $( $(@:.o=.d) $(YASM) $(YASMFLAGS) -I $( This

[libav-devel] [PATCH 1/2] configure: Split out msvc as a separate target OS

2012-10-13 Thread Martin Storsjö
The name mingw32 as target OS is both misleading, and very little of the target OS specific settings actually match. Since the target OS default is set based on uname, the default (which on MSYS is set to mingw) is overridden by --toolchain=msvc. --- configure | 12 1 file changed,

[libav-devel] [PATCH 2/2] Add support for building shared libraries with MSVC

2012-10-13 Thread Martin Storsjö
From: "Ronald S. Bultje" This requires the makedef perl script by Derek, from the c89-to-c99 repo. That scripts produces a .def file, listing the symbols to be exported, based on the gcc version scripts and the built object files. To properly load non-function symbols from DLL files, the data sy

Re: [libav-devel] [PATCH 1/2] configure: Split out msvc as a separate target OS

2012-10-13 Thread Martin Storsjö
On Sat, 13 Oct 2012, Hendrik Leppkes wrote: On Sat, Oct 13, 2012 at 9:43 PM, Martin Storsjö wrote: The name mingw32 as target OS is both misleading, and very little of the target OS specific settings actually match. Since the target OS default is set based on uname, the default (which on

Re: [libav-devel] [PATCH 2/2] Add support for building shared libraries with MSVC

2012-10-13 Thread Martin Storsjö
On Sat, 13 Oct 2012, Dave Yeo wrote: On 10/13/12 10:23 am, Martin Storsjö wrote: This requires the makedef perl script by Derek, which probably will go into the c99-to-c89 repo. That scripts produces a .def file, listing the symbols to be exported, based on the gcc version scripts and the

Re: [libav-devel] [PATCH 2/2] Add support for building shared libraries with MSVC

2012-10-13 Thread Martin Storsjö
On Sat, 13 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: @@ -2930,6 +2944,9 @@ build the shared libraries as well. To only build the shared libraries specify EOF exit 1; fi +if enabled_all msvc static shared; then +die "Cannot build shared and static libraries at the

Re: [libav-devel] [PATCH 2/2] Add support for building shared libraries with MSVC

2012-10-14 Thread Martin Storsjö
On Sat, 13 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: +#if CONFIG_SHARED && defined(_WIN32) && !defined(COMPILING_avcodec) +#define avcodec_exportdata __declspec(dllimport) +#else +#define avcodec_exportdata +#endif I want to think about this some more. Any fur

Re: [libav-devel] [PATCH 01/15] configure: simplify get_version() function

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: awk alone can do this, no need for grep. Signed-off-by: Mans Rullgard --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 700e99d..3bb8fff 100755 --- a/configure +++ b/configure @@ -3775,7 +3775,

Re: [libav-devel] [PATCH 02/15] configure: simplify argument handling in check_ld

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: Use the existing filter functions instead of open-coding the separation of general flags and libraries. Signed-off-by: Mans Rullgard --- configure | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 3bb

Re: [libav-devel] [PATCH 03/15] build: simplify enabling of compat objects

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: Add a configure function to pull in a compat object and set up redirects in one operation. This avoids duplicating conditions across configure and makefiles. Signed-off-by: Mans Rullgard --- configure | 15 +++ libavutil/Makefile |

Re: [libav-devel] [PATCH 04/15] Include sys/time.h before sys/resource.h

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: Some systems require sys/time.h being explicitly included before sys/resource.h. The configure check already does this. Signed-off-by: Mans Rullgard --- avconv.c | 1 + cmdutils.c | 1 + 2 files changed, 2 insertions(+) diff --git a/avconv.c b/avconv

Re: [libav-devel] [PATCH 05/15] network: #include stdint.h in network.h

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: This header uses various types provided by stdint.h without explicitly including it. Signed-off-by: Mans Rullgard --- libavformat/network.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/network.h b/libavformat/network.h index 19c5a92..

Re: [libav-devel] [PATCH 06/15] network: add fallbacks for INADDR_LOOPBACK and INET_ADDRSTRLEN

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: Signed-off-by: Mans Rullgard --- libavformat/network.h | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/network.h b/libavformat/network.h index da9d926..5160767 100644 --- a/libavformat/network.h +++ b/libavformat/network.h @@ -188

Re: [libav-devel] [PATCH 07/15] network: use getservbyport() only if available

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: The absence of this function will only give a less informative string back from our fallback implementation of getnameinfo(). Signed-off-by: Mans Rullgard --- configure| 2 ++ libavformat/os_support.c | 2 ++ 2 files changed, 4 insertions

Re: [libav-devel] [PATCH 08/15] libm: add fallbacks for various single-precision functions

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: Signed-off-by: Mans Rullgard --- configure | 16 libavcodec/aacps_tablegen.h | 1 + libavutil/libm.h| 40 3 files changed, 57 insertions(+) LGTM // Martin _

Re: [libav-devel] [PATCH 10/15] fate: improve md5sum utility selection

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: The 'md5sum' command is used with the -b flag so the presence test must also use this flag. Signed-off-by: Mans Rullgard --- tests/md5.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/md5.sh b/tests/md5.sh index 4b95127..0b38

Re: [libav-devel] [PATCH 11/15] tiny_psnr: check for specified sample size less than 1

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: A zero or negative sample size is impossible and should be reported as an error. Signed-off-by: Mans Rullgard --- tests/tiny_psnr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tiny_psnr.c b/tests/tiny_psnr.c index 5db2662..

Re: [libav-devel] [PATCH 15/15] build: Plan 9 support

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: diff --git a/configure b/configure index 0acaf3e..25e2e83 100755 --- a/configure +++ b/configure @@ -956,7 +956,7 @@ apply(){ cp_if_changed(){ cmp -s "$1" "$2" && echo "$2 is unchanged" && return mkdir -p "$(dirname $2)" -cp -f "$1" "$2" +

Re: [libav-devel] [PATCH 03/15] build: simplify enabling of compat objects

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: On Mon, 15 Oct 2012, Mans Rullgard wrote: Add a configure function to pull in a compat object and set up redirects in one operation. This avoids duplicating conditions across configure and makefiles. Signed-off-by: Mans

Re: [libav-devel] [PATCH 15/15] build: Plan 9 support

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: On Mon, 15 Oct 2012, Mans Rullgard wrote: diff --git a/configure b/configure index 0acaf3e..25e2e83 100755 --- a/configure +++ b/configure @@ -956,7 +956,7 @@ apply(){ cp_if_changed(){ cmp -s "$1" "$2&

Re: [libav-devel] [PATCH 15/15] build: Plan 9 support

2012-10-15 Thread Martin Storsjö
On Mon, 15 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: On Mon, 15 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: On Mon, 15 Oct 2012, Mans Rullgard wrote: +add_cppflags -I${source_path}/compat/plan9 \ + -D_C99_SNPRINTF_EXTENSION

Re: [libav-devel] [PATCH 2/2] Add support for building shared libraries with MSVC

2012-10-17 Thread Martin Storsjö
On Mon, 15 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: On Sat, 13 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: +#if CONFIG_SHARED && defined(_WIN32) && !defined(COMPILING_avcodec) +#define avcodec_exportdata __declspec(dllimport) +#else +#define av

Re: [libav-devel] [PATCH] Riff: fix linking when muxers are disabled

2012-10-17 Thread Martin Storsjö
On Wed, 17 Oct 2012, Jean-Baptiste Kempf wrote: --- libavformat/riff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/riff.c b/libavformat/riff.c index d591aa8..0db2486 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -374,7 +374,6 @@ const char ff_riff

Re: [libav-devel] [PATCH] riff: Move functions around to be covered by appropriate #ifdefs

2012-10-17 Thread Martin Storsjö
On Wed, 17 Oct 2012, Diego Biurrun wrote: This fixes compilation with --disable-muxers. --- libavformat/riff.c | 158 ++-- 1 files changed, 79 insertions(+), 79 deletions(-) Ok with me. // Martin ___ l

[libav-devel] [PATCH] aviobuf: Remove a senseless ifdef in avio_seek

2012-10-17 Thread Martin Storsjö
This seemed to assume that one never used writing avio unless muxers or networking was enabled. This ifdef is a remnant since 8fa641f8. --- libavformat/aviobuf.c |2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index da836c6..15d132d 100644 ---

[libav-devel] [PATCH 2/4] gxf: Add a local copy of the relevant parts of the frame rate table

2012-10-18 Thread Martin Storsjö
This avoids having to share this table across the library boundaries. This shared table used to be problematic, if always declaring all exported data symbols with the dllimport attribute (even while building that same library), since it needs to be a link-time constant when it is used in AVCodec d

[libav-devel] [PATCH 3/4] avcodec: Rename avpriv_frame_rate_tab to ff_mpeg12_frame_rate_tab

2012-10-18 Thread Martin Storsjö
This table doesn't need to be shared with libavformat any longer. Add mpeg12 to the name to make it less ambiguous, while renaming it. --- libavcodec/cavsdec.c |4 ++-- libavcodec/dirac.c|2 +- libavcodec/mpeg12.c |8 libavcodec/mpeg12data.c

[libav-devel] [PATCH 4/4] Add support for building shared libraries with MSVC

2012-10-18 Thread Martin Storsjö
This requires the makedef perl script by Derek, from the c89-to-c99 repo. That scripts produces a .def file, listing the symbols to be exported, based on the gcc version scripts and the built object files. To properly load non-function symbols from DLL files, the data symbol declarations need to h

[libav-devel] [PATCH 4/4] Add support for building shared libraries with MSVC

2012-10-18 Thread Martin Storsjö
This requires the makedef perl script by Derek, from the c89-to-c99 repo. That scripts produces a .def file, listing the symbols to be exported, based on the gcc version scripts and the built object files. To properly load non-function symbols from DLL files, the data symbol declarations need to h

[libav-devel] [PATCH] changelog: Mention the MSVC DLL support

2012-10-18 Thread Martin Storsjö
Also retroactively add a changelog entry to the 9beta1 list for general MSVC support, which was present there already. --- Changelog |2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 9e5ee87..c3d55c1 100644 --- a/Changelog +++ b/Changelog @@ -3,6 +3,7 @@ releases

Re: [libav-devel] [PATCH 14/15] build: allow targets to specify extra objects to link with executables

2012-10-18 Thread Martin Storsjö
On Mon, 15 Oct 2012, Mans Rullgard wrote: This allows targets to include special objects when linking executables without including them in (shared) libraries. Signed-off-by: Mans Rullgard --- Makefile| 8 configure | 1 + library.mak | 2 +- 3 files changed, 6 insertions(+), 5 del

[libav-devel] [PATCH] avformat: Fix references to the removed function av_write_header in comments

2012-10-18 Thread Martin Storsjö
--- libavformat/avformat.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index f9f39a6..8af007e 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -653,7 +653,7 @@ typedef struct AVStream { * of whi

[libav-devel] [PATCH 1/4] rtp: Update the check for distinguishing between RTP and RTCP

2012-10-18 Thread Martin Storsjö
Also add enums for more RTCP packet types, according to the IANA list of registered types. --- libavformat/rtp.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libavformat/rtp.h b/libavformat/rtp.h index b01caeb..6df4ed4 100644 --- a/libavformat/rtp.h +++ b/

[libav-devel] [PATCH 2/4] rtsp: Vertically align a constant definition

2012-10-18 Thread Martin Storsjö
--- libavformat/rtsp.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h index d16c98c..55326e9 100644 --- a/libavformat/rtsp.h +++ b/libavformat/rtsp.h @@ -390,7 +390,7 @@ typedef struct RTSPState { #define RTSP_FLAG_FILTER_SRC 0x1

[libav-devel] [PATCH 3/4] rtsp: Make sure the ret variable is initialized in all cases

2012-10-18 Thread Martin Storsjö
--- libavformat/rtsp.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index df27218..159f97b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1796,7 +1796,8 @@ int ff_rtsp_fetch_packet(AVFormatContext *s, AVPacket *pkt)

[libav-devel] [PATCH 4/4] rtsp: Allow setting the reordering buffer size via an AVOption

2012-10-18 Thread Martin Storsjö
--- libavformat/rtsp.c | 16 ++-- libavformat/rtsp.h |5 + 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 159f97b..bbe08e6 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -74,6 +74,9 @@ { "audio",

Re: [libav-devel] [PATCH 4/4] rtsp: Allow setting the reordering buffer size via an AVOption

2012-10-18 Thread Martin Storsjö
On Thu, 18 Oct 2012, Luca Barbato wrote: On 10/18/2012 04:08 PM, Martin Storsjö wrote: +#define RTSP_REORDERING_OPTS() \ why () ? Mostly for consistency with the other option macros (that take parameters). // Martin___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/2] avutil: remove inline av_log2 from public API

2012-10-18 Thread Martin Storsjö
On Thu, 18 Oct 2012, Mans Rullgard wrote: This removes inline av_log2 and av_log2_16bit from the public API, instead exporting them as regular functions. In-tree code still gets the inline and otherwise optimised variants. Signed-off-by: Mans Rullgard --- No change to linked into avconv. ---

[libav-devel] [PATCH 1/2] fate: Add proper dependencies in lossless-video.mak

2012-10-18 Thread Martin Storsjö
The output of make fate-list is identical to before. --- tests/fate/lossless-video.mak | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/fate/lossless-video.mak b/tests/fate/lossless-video.mak index 5055730..06b6dd5 100644 --- a/tests/fate/lossless-video.

[libav-devel] [PATCH 2/2] fate: Add proper dependencies in qt.mak

2012-10-18 Thread Martin Storsjö
The output of make fate-list is identical to before. --- tests/fate/qt.mak | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tests/fate/qt.mak b/tests/fate/qt.mak index b2b9500..79155f5 100644 --- a/tests/fate/qt.mak +++ b/tests/fate/qt.mak @@

[libav-devel] [PATCH 1/2] fate: Move fate-iff-fibonacci to audio.mak

2012-10-18 Thread Martin Storsjö
This tests an audio codec, not a video codec. After this, the test is no longer a part of the fate-iff group though. --- tests/fate/audio.mak |3 +++ tests/fate/video.mak |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak inde

[libav-devel] [PATCH 2/2] fate: Add proper dependencies for the tests in video.mak

2012-10-18 Thread Martin Storsjö
The output of make fate-list is identical to before. This adds proper dependencies to the last tests that require zlib. --- tests/fate/video.mak | 130 +- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/tests/fate/video.mak b/tests/

[libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Martin Storsjö
The output of make fate-list is identical to before. This adds proper dependencies to the last tests that require zlib. --- The iff audio decoder test kept in this file, the iff tests now have proper individual dependencies, ENCDEC used for the two tests that need it. --- tests/fate/video.mak |

[libav-devel] [PATCH] mpeg4videodec: Disable frame multithreading for GMC, its not implemented at all

2012-10-19 Thread Martin Storsjö
From: Michael Niedermayer This fixes race conditions in decoding MPEG-4 GMC files. --- libavcodec/mpegvideo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index d6f7af2..af9e040 100644 --- a/libavcodec/mpegvideo.c +++ b/

Re: [libav-devel] [PATCH 06/16] atrac3: use AVCodecContext.block_align instead of keeping a private copy

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 30 +- 1 files changed, 13 insertions(+), 17 deletions(-) LGTM // Martin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mai

Re: [libav-devel] [PATCH 09/16] atrac3: remove unused ATRAC3Context field, bit_rate

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index e8c94bb..00ec3c9 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -90,7 +90,6 @@ typedef struct

Re: [libav-devel] [PATCH 10/16] atrac3: move the 'frame_factor' field from ATRAC3Context to where it is used

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 00ec3c9..1b623f7 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -109,7 +109,6 @@ t

Re: [libav-devel] [PATCH 11/16] atrac3: separate window initialization from IMDCT initialization

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 1b623f7..6984ecf 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -174,7 +1

Re: [libav-devel] [PATCH 12/16] atrac3: initialize static tables in AVCodec.init_static_data()

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 53 ++- 1 files changed, 27 insertions(+), 26 deletions(-) LGTM // Martin ___ libav-devel mailing list libav-devel@libav.org https:

Re: [libav-devel] [PATCH 13/16] atrac3: use a half-size MDCT window

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index d15b710..b3e1593 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -39

Re: [libav-devel] [PATCH 14/16] atrac3: use sizeof(variable) instead of sizeof(type)

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) LGTM // Martin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav

Re: [libav-devel] [PATCH 15/16] atrac3: remove unused ATRAC3Context field, sample_rate

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index c662015..28c72c7 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -90,7 +90,6 @@ typedef stru

Re: [libav-devel] [PATCH 16/16] atrac3: replace a calculation with FFALIGN()

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 28c72c7..343e31b 100644 --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -949,8 +949,7 @@ static av_c

Re: [libav-devel] [PATCH 01/16] atrac3: cosmetics: pretty-printing and renaming

2012-10-19 Thread Martin Storsjö
On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c | 1057 +++ libavcodec/atrac3data.h | 98 +++-- 2 files changed, 571 insertions(+), 584 deletions(-) The commit also contains some minor refactorings that could be mentioned in

Re: [libav-devel] [PATCH 2/2] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Diego Biurrun wrote: On Fri, Oct 19, 2012 at 02:43:05AM +0300, Martin Storsjö wrote: --- tests/fate/video.mak | 130 +- 1 file changed, 65 insertions(+), 65 deletions(-) Of all the possible files to work on you pick the

Re: [libav-devel] [PATCH] mpeg4videodec: Disable frame multithreading for GMC, its not implemented at all

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Måns Rullgård wrote: Martin Storsjö writes: From: Michael Niedermayer This fixes race conditions in decoding MPEG-4 GMC files. I don't think "race condition" is the proper term for what goes wrong here. Removed this line locally, will push later. T

[libav-devel] [PATCH] fate: Add proper dependencies for the tests in video.mak

2012-10-19 Thread Martin Storsjö
The output of make fate-list is identical to before. --- Added individual demuxer deps for the cinepak tests, rechecked the rest of the multi-test-deps to make sure they were correct. --- tests/fate/video.mak | 146 +- 1 file changed, 73 insertions(

Re: [libav-devel] [PATCH 16/16] atrac3: replace a calculation with FFALIGN()

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Justin Ruggles wrote: On 10/19/2012 04:42 AM, Martin Storsjö wrote: On Thu, 18 Oct 2012, Justin Ruggles wrote: --- libavcodec/atrac3.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c index 28c72c7

Re: [libav-devel] Restore ABI compatibility in libavutil

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Reinhard Tartler wrote: These two patches unbreak at least avprobe and friends from the previous release. FWIW, these two patches, tested together with Måns' av_log2() cleanup from yesterday, work just fine in a MSVC DLL build. So OK from my part. // Martin_

Re: [libav-devel] [PATCH 1/2] doc/platform: Move a caveat down to the notes section

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis --- doc/platform.texi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/platform.texi b/doc/platform.texi index 3bb9f79..6adba1e 100644 --- a/doc/platform.texi +++ b/doc/platform.texi

Re: [libav-devel] [PATCH 2/2] doc/platform: Add info on shared builds with MSVC

2012-10-19 Thread Martin Storsjö
On Fri, 19 Oct 2012, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis --- doc/platform.texi | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/doc/platform.texi b/doc/platform.texi index 6adba1e..0598fca 100644 --- a/doc/platform.texi +++ b/doc/platform.texi

Re: [libav-devel] [PATCH v2] avutil: reintroduce ff_sqrt_tab to restore ABI compatibility

2012-10-20 Thread Martin Storsjö
On Sat, 20 Oct 2012, Reinhard Tartler wrote: Earlier versions of for instance libavcodec expect this symbol to be present in libavutil. It can be removed at the next major bump. --- libavcodec/mathtables.c |3 +++ libavutil/mathematics.c | 13 + libavutil/version.h |3 +++

[libav-devel] [PATCH] avutil: Add a copy of ff_sqrt_tab back into avutil to restore ABI compatibility

2012-10-20 Thread Martin Storsjö
Earlier versions of for instance of libavcodec expect this symbol to be present in libavutil. This commit can be reverted after the next major bump. New shared builds of avcodec will link to the internal copy of the table within that library, so those builds won't rely on this table being present

Re: [libav-devel] [PATCH 1/2] avutil: make some tables visible again

2012-10-20 Thread Martin Storsjö
On Fri, 19 Oct 2012, Reinhard Tartler wrote: These tables are used for instance by older versions of libavcodec and need to remain visible until the next SONAME bump --- libavutil/libavutil.v |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/libavutil.v b/libavutil/

[libav-devel] [PATCH 1/2] rtsp: Update a comment to the current filename scheme

2012-10-21 Thread Martin Storsjö
--- libavformat/rtsp.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h index 2812fcb..043b67a 100644 --- a/libavformat/rtsp.h +++ b/libavformat/rtsp.h @@ -424,7 +424,7 @@ typedef struct RTSPStream { int sdp_payload_type; /**<

[libav-devel] [PATCH 2/2] rtpdec: Don't pass a non-AVClass pointer as log context

2012-10-21 Thread Martin Storsjö
The log context is assumed to start with an AVClass pointer. There is no other suitable log context available in the function, and refactoring all callers to pass one is overkill just for the uncommon out of memory situation. --- libavformat/rtpdec.c |2 +- 1 file changed, 1 insertion(+), 1 de

Re: [libav-devel] [PATCH 01/16] atrac3: cosmetics: pretty-printing and renaming

2012-10-22 Thread Martin Storsjö
On Sat, 20 Oct 2012, Justin Ruggles wrote: also does some minor refactoring. --- libavcodec/atrac3.c | 1059 +++ libavcodec/atrac3data.h | 98 +++-- 2 files changed, 572 insertions(+), 585 deletions(-) LGTM // Martin

Re: [libav-devel] [PATCH 27/45] libilbc: set channel layout

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: --- libavcodec/libilbc.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/libilbc.c b/libavcodec/libilbc.c index a93285c..2812061 100644 --- a/libavcodec/libilbc.c +++ b/libavcodec/libilbc.c @@ -21,6 +21,7 @@ #i

Re: [libav-devel] [PATCH 24/45] gsmdec: always set channel layout and sample rate at initialization

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: Only mono 8kHz is supported. --- libavcodec/gsmdec.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/gsmdec.c b/libavcodec/gsmdec.c index a5e0d7d..14b7e03 100644 --- a/libavcodec/gsmdec.c +++ b/libavcodec/gsmde

Re: [libav-devel] [PATCH 23/45] libgsmdec: always set channel layout and sample rate at initialization

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: Only mono 8kHz is supported. --- libavcodec/libgsm.c | 18 +- 1 files changed, 5 insertions(+), 13 deletions(-) diff --git a/libavcodec/libgsm.c b/libavcodec/libgsm.c index e6d435b..afed710 100644 --- a/libavcodec/libgsm.c +++ b/libavc

Re: [libav-devel] [PATCH 04/45] amrnbdec: set channels, channel_layout, and sample_rate

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: Only mono 8kHz is supported. --- libavcodec/amrnbdec.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libavcodec/amrnbdec.c b/libavcodec/amrnbdec.c index 2cb06a6..cc318ac 100644 --- a/libavcodec/amrnbdec.c +++ b/libavcodec/

Re: [libav-devel] [PATCH 05/45] amrwbdec: set channels, channel_layout, and sample_rate

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: Only mono 16kHz is supported. --- libavcodec/amrwbdec.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libavcodec/amrwbdec.c b/libavcodec/amrwbdec.c index 5cc96ab..7cac883 100644 --- a/libavcodec/amrwbdec.c +++ b/libavcodec

Re: [libav-devel] [PATCH 06/45] g722dec: set channel layout at initialization instead of validating it

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: --- libavcodec/g722dec.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/g722dec.c b/libavcodec/g722dec.c index ea06ce0..3364850 100644 --- a/libavcodec/g722dec.c +++ b/libavcodec/g722dec.c @@ -34,6 +34,7 @@ *

Re: [libav-devel] [PATCH 28/45] libopencore-amr: set channel layout for amr-nb or if not set by the user

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: --- libavcodec/libopencore-amr.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/libopencore-amr.c b/libavcodec/libopencore-amr.c index 9a543b4..dcee34d 100644 --- a/libavcodec/libopencore-amr.c +++ b/libavcod

Re: [libav-devel] [PATCH 29/45] nellymoserdec: set channels to 1

2012-10-23 Thread Martin Storsjö
On Tue, 23 Oct 2012, Justin Ruggles wrote: --- libavcodec/nellymoserdec.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavcodec/nellymoserdec.c b/libavcodec/nellymoserdec.c index fce184a..f17e9fd 100644 --- a/libavcodec/nellymoserdec.c +++ b/libavcodec/nellymoserdec.

Re: [libav-devel] [PATCH 28/45] libopencore-amr: set channel layout for amr-nb or if not set by the user

2012-10-24 Thread Martin Storsjö
On Wed, 24 Oct 2012, Justin Ruggles wrote: On 10/23/2012 06:13 PM, Martin Storsjö wrote: On Tue, 23 Oct 2012, Justin Ruggles wrote: --- libavcodec/libopencore-amr.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/libopencore-amr.c b/libavcodec

[libav-devel] [PATCH] smoothstreamingenc: Don't assume streams start from timestamp 0

2012-10-24 Thread Martin Storsjö
Also use dts instead of pts for deciding where to split fragments. --- libavformat/smoothstreamingenc.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c index 69d555f..1ed675a 100644 --- a/libavforma

Re: [libav-devel] [PATCH 04/45] amrnbdec: set channels, channel_layout, and sample_rate

2012-10-24 Thread Martin Storsjö
On Wed, 24 Oct 2012, Justin Ruggles wrote: Only mono 8kHz is supported. --- libavcodec/amrnbdec.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/libavcodec/amrnbdec.c b/libavcodec/amrnbdec.c index 2cb06a6..2196645 100644 --- a/libavcodec/amrnbdec.c +++ b/libav

Re: [libav-devel] [PATCH 05/45] amrwbdec: set channels, channel_layout, and sample_rate

2012-10-24 Thread Martin Storsjö
On Wed, 24 Oct 2012, Justin Ruggles wrote: Only mono 16kHz is supported. --- libavcodec/amrwbdec.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/libavcodec/amrwbdec.c b/libavcodec/amrwbdec.c index 5cc96ab..3b9ca05 100644 --- a/libavcodec/amrwbdec.c +++ b/liba

Re: [libav-devel] [PATCH 28/45] libopencore-amr: set channel layout for amr-nb or if not set by the user

2012-10-24 Thread Martin Storsjö
On Wed, 24 Oct 2012, Justin Ruggles wrote: --- libavcodec/libopencore-amr.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/libopencore-amr.c b/libavcodec/libopencore-amr.c index 9a543b4..a754d52 100644 --- a/libavcodec/libopencore-amr.c +++ b/liba

[libav-devel] [PATCH] build: Install optionally-installed headers as well

2012-10-25 Thread Martin Storsjö
This makes sure the previously always installed public header lzo.h is installed if the LZO functionality is enabled. --- library.mak |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.mak b/library.mak index cbfa0d4..b069c44 100644 --- a/library.mak +++ b/library.mak @

[libav-devel] [PATCH] build: Install optionally-installed headers as well

2012-10-25 Thread Martin Storsjö
This makes sure the previously always installed public header lzo.h is installed if the LZO functionality is enabled. --- common.mak |1 + 1 file changed, 1 insertion(+) diff --git a/common.mak b/common.mak index dd9f4cb..c4d2999 100644 --- a/common.mak +++ b/common.mak @@ -23,6 +23,7 @@ HOST

[libav-devel] [PATCH] build: Include HEADERS-yes in the HEADERS variable

2012-10-25 Thread Martin Storsjö
This makes sure the previously always installed public header lzo.h is installed if the LZO functionality is enabled. --- Makefile |2 +- common.mak |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 07df538..1f73a0a 100644 --- a/Makefile +++ b/

[libav-devel] [PATCH 1/2] lpc: Add a function for calculating reflection coefficients

2012-10-26 Thread Martin Storsjö
The existing function ff_lpc_calc_coefs does this, but doesn't return the reflection coefficients, only the lpc coefficients. --- libavcodec/lpc.c | 18 ++ libavcodec/lpc.h |3 +++ 2 files changed, 21 insertions(+) diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c index 126db

[libav-devel] [PATCH 2/2] avcodec: Add a RFC 3389 comfort noise codec

2012-10-26 Thread Martin Storsjö
This isn't too useful as a normal codec, but can be used in voip style applications. The decoder updates the noise generator parameters when a packet is given to it for decoding, but if called with an empty packet, it generates more noise according to the last parameters. --- References: https://t

Re: [libav-devel] [PATCH 2/2] avcodec: Add a RFC 3389 comfort noise codec

2012-10-26 Thread Martin Storsjö
On Fri, 26 Oct 2012, Diego Biurrun wrote: On Fri, Oct 26, 2012 at 11:13:49PM +0300, Martin Storsjö wrote: --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -129,6 +129,8 @@ OBJS-$(CONFIG_CLJR_DECODER)+= cljr.o OBJS-$(CONFIG_CLJR_ENCODER)+= cljr.o OBJS

Re: [libav-devel] [PATCH 2/8] lavu: add av_ctz() for trailing zero bit count

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Justin Ruggles wrote: --- doc/APIchanges |3 +++ libavutil/common.h |4 libavutil/intmath.h | 41 + libavutil/version.h |2 +- 4 files changed, 49 insertions(+), 1 deletions(-) diff --git a/doc/APIchanges b/doc/AP

Re: [libav-devel] [PATCH 06/11] network: use HAVE_THREADS instead of local hack

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Mans Rullgard wrote: HAVE_THREADS is set in config.h if pthreads or w32threads is available, which presumably the proper condition here. Also fixes undefined behaviour in preprocessor directives. Signed-off-by: Mans Rullgard --- libavformat/network.c | 14 ++ 1

Re: [libav-devel] [PATCH 07/11] udp: use socklen_t where appropriate

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Mans Rullgard wrote: getsockname() takes a pointer to socklen_t which is not necessarily int. Signed-off-by: Mans Rullgard --- libavformat/udp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index e848ecd..373a

Re: [libav-devel] [PATCH 03/11] af_channelmap: remove stray enum declaration

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Mans Rullgard wrote: Signed-off-by: Mans Rullgard --- libavfilter/af_channelmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index 8c49d10..f70b481 100644 --- a/libavfilter/af_channelmap.c +++ b/libavfilter/af

Re: [libav-devel] [PATCH 08/11] avserver: use socklen_t where appropriate

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Mans Rullgard wrote: Various socket functions expect a pointer to socklen_t which is not necessarily int. Signed-off-by: Mans Rullgard --- avserver.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/avserver.c b/avserver.c index 994edcd..f9d85d8

Re: [libav-devel] [PATCH 04/11] avio: fix pointer type mismatches in avio_enum_protocols()

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Mans Rullgard wrote: Signed-off-by: Mans Rullgard --- libavformat/avio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 45ee866..a43b241 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@

Re: [libav-devel] [PATCH 09/11] amrwbdec: fix invalid pointer arithmetic

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Mans Rullgard wrote: Subtracting a (positive) value from the address of an array violates C99 section 6.5.6: If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not

Re: [libav-devel] [PATCH 10/11] h264: fix invalid pointer arithmetic

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Mans Rullgard wrote: Subtracting a (positive) value from the address of an array violates C99 section 6.5.6: If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not

Re: [libav-devel] [PATCH 1/8] flacenc: use a separate buffer for byte-swapping for MD5 checksum on big-endian

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Justin Ruggles wrote: This is much faster than calculating the MD5 one sample at a time. --- libavcodec/flacenc.c | 37 - 1 files changed, 28 insertions(+), 9 deletions(-) LGTM // Martin ___

Re: [libav-devel] [PATCH 8/8] FATE: add a 24-bit FLAC encoding test

2012-10-27 Thread Martin Storsjö
On Sat, 27 Oct 2012, Justin Ruggles wrote: The existing tests are renamed to fate-flac-16-* to allow different rules for 16-bit and 24-bit tests. --- This will require upload of the 24-bit reference wav file to fate-suite. tests/fate/flac.mak | 31 +++ 1 files chang

[libav-devel] [PATCH 1/3] lpc: Add a function for calculating reflection coefficients from autocorrelation coefficients

2012-10-27 Thread Martin Storsjö
From: Justin Ruggles --- libavcodec/lpc.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/libavcodec/lpc.h b/libavcodec/lpc.h index cbee46f..0e54f0d 100644 --- a/libavcodec/lpc.h +++ b/libavcodec/lpc.h @@ -111,6 +111,37 @@ void ff_lpc_end(LPCContext *s); #

[libav-devel] [PATCH 2/3] lpc: Add a function for calculating reflection coefficients from samples

2012-10-27 Thread Martin Storsjö
--- Is there any point in having this function, or should the caller just call these three functions manually? --- libavcodec/lpc.c | 12 libavcodec/lpc.h |3 +++ 2 files changed, 15 insertions(+) diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c index 126dbc1..2093e7e 100644 --

[libav-devel] [PATCH 3/3] avcodec: Add a RFC 3389 comfort noise codec

2012-10-27 Thread Martin Storsjö
This isn't too useful as a normal codec, but can be used in voip style applications. The decoder updates the noise generator parameters when a packet is given to it for decoding, but if called with an empty packet, it generates more noise according to the last parameters. --- References: https://t

[libav-devel] [PATCH 1/2] rtpdec: Cosmetic cleanup

2012-10-27 Thread Martin Storsjö
Mainly clean up the RTP statistics code, plus a few other obviously misindentend lines. Remove some useless comments, de-doxygenize some comments, add spacing around operators. --- libavformat/rtpdec.c | 106 -- 1 file changed, 51 insertions(+), 55

<    1   2   3   4   5   6   7   8   9   10   >