On Mon, Apr 02, 2012 at 07:43:11AM -0700, Brennan T Vincent
wrote:
> You are correct, of course. I had added those lines before I fully
> understood how the code worked, and forgotten to remove them. I have
> updated my patch and formatted it correctly.
Pushed, thanks for this!
Miklos
_
> Or, for files that are static in a distributed LO (i.e. not modified
> at installation. even less at run-time), process them into source
> code that set up the structures as much as possible at compile-time
> already?
Even better!
There seems to be a lot currently dynamic data, that could be
d
On Tuesday 03 of April 2012, Enrico Weigelt wrote:
> Hi,
>
> > I don't want to spoil the fun much for you :) , but I expect the
> > number of
> > string allocations to go down when RTL_CONSTASCII_* stops being used
> > in favor
> > of string literals, and further down after whenever I get to
> >
Hello all,
I am struggling a bit to get various colour buttons (e.g.
font/background/border colour) working as split buttons, so that the last used
colour can be applied again right away. See fdo45671 for more details on the
specific buttons/wishes.
For a lot of buttons I have succeeded to con
> > Just curious: what's the big difference between rtl::OUString and
> > std::string ?
>
> http://lists.freedesktop.org/archives/libreoffice/2012-March/028485.html
> (and
> click the next message link a couple of times).
Okay. Do situations where std::string doesnt suffice happen that often,
> Okay. Do situations where std::string doesnt suffice happen that often,
> that we need to OUString virtually everywhere ?
You aren't telling us anything we don't know already. Sure, stopping
using UTF-16 strings in situations where it is just ASCII anyway that
is handled is one thing we want to
On 04/02/2012 11:06 PM, Michael Meeks wrote:
Digging through the string logs, trying to make sense of the extremely
intense thrash around this SINGLETON/ stuff, I was curious to get rather
deep stacks, cf. appended trace.
AFAICS the purpose of this code is mostly to turn a pretty
Hi,
> Yes, this is indeed a bit of a tragedy. The relevant UNO types and
> services bootstrapping code is very old, and concepts are tightly
> knit together there, and whenever you want to change something you risk
> backwards incompatibility.
Backwards compatibility to whom ? Binaries ? Source
Hi Enrico,
On Tue, 2012-04-03 at 05:15 +0200, Enrico Weigelt wrote:
> > What would be ultimately nice would be to rid ourselves of this
> > XRegistry 'stuff' and have a simple XML file, read into some simple
> > structures, and added to a couple of hashes for the common lookup
> > patterns we
On 02/04/12 23:11, Miklos Vajna wrote:
> On Mon, Apr 02, 2012 at 08:20:18PM +0200, Dézsi Szabolcs
> wrote:
>>> Not sure if you noticed that the RotationDescriptor service is
>>> deprecated, just in case you plan to spend too much time on it. ;)
>>
>>
>> Yes, I noticed it, I think I have to use Tr
Hi,
See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=04cae9ec1e1f04833b06fe9f24e23cfaf5265599
Trivial patch, regression from 3.4. I'm attaching a backport to 3.5, as
we don't have a testsuite there.
Thanks,
Miklos
>From 13ea3153a56cc028b6de4c340449caff1283e063 Mon Sep 17 00:00:00 200
On 03/04/12 11:22, Miklos Vajna wrote:
> Hi,
>
> See
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=04cae9ec1e1f04833b06fe9f24e23cfaf5265599
>
> Trivial patch, regression from 3.4. I'm attaching a backport to 3.5, as
> we don't have a testsuite there.
pushed to libreoffice-3-5
http:/
On Tue, 2012-04-03 at 00:54 +0200, Eike Rathke wrote:
> Hmm.. a year ago Martin Hosken introduced char.txt and commented out the
> use of SpacingMark and Prepend according to UAX #29 updates, along with
> changes in breakiterator script identification. So we already have the
> changed behavior sin
> uhm... i'm not that familiar with drawing layer stuff, but there are 2
> different kinds of images in Writer, one is directly implemented in
> Writer, and the other is from svx/drawing objects (and thus works the
> same way in all applications). each of these 2 different kinds of
> images has f
Hi Olivier,
Looks lovely - do push such nice but simple patches yourself without
review :-)
ATB,
Michael.
--
michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Bug 35673 depends on bug 36482, which changed state.
Bug 36482 Summary: PDF EXPORT Options dialog missing - in relation with user
profile of previous (...) version
https://bugs.freedesktop.org/show_bug.cgi?id=36482
What|Old Valu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
done
Em 03-04-2012 07:08, Michael Meeks escreveu:
> Hi Olivier,
>
> Looks lovely - do push such nice but simple patches yourself without
> review :-)
>
> ATB,
>
> Michael.
>
- --
Olivier Hallot
Founder, Board of Directo
Hi Enrico,
On Tue, 2012-04-03 at 11:04 +0200, Enrico Weigelt wrote:
> > Yes, this is indeed a bit of a tragedy. The relevant UNO types and
> > services bootstrapping code is very old, and concepts are tightly
> > knit together there, and whenever you want to change something you risk
> > backward
On Tuesday 03 of April 2012, Daniel Bankston [danthedev] wrote:
> Hello, everyone,
>
> I have attached my patches for EasyHack Bug 46610.
Looks good to me, I only removed the return's at the end of function, as they
are superfluous in void functions. Pushed, thank you.
> I identified that the r
Hi Stephan,
On Tue, 2012-04-03 at 10:41 +0200, Stephan Bergmann wrote:
> Yes, this is indeed a bit of a tragedy. The relevant UNO types and
> services bootstrapping code is very old, and concepts are tightly knit
Thanks for your lovely detailed write-up, I'm just editing it into the
st
On Tuesday 03 of April 2012, Lubos Lunak wrote:
> On Tuesday 03 of April 2012, Daniel Bankston [danthedev] wrote:
> > Hello, everyone,
> >
> > I have attached my patches for EasyHack Bug 46610.
>
> Looks good to me, I only removed the return's at the end of function, as
> they are superfluous in v
On 04/03/2012 01:57 PM, Michael Meeks wrote:
On Tue, 2012-04-03 at 10:41 +0200, Stephan Bergmann wrote:
That way, you have a chance of surviving the process. But you also
pile up guilt.
Lol :-) well, we managed to keep it going, despite the guilt pile
somehow :-) I guess in this case
Hi Winfried,
On 2012-04-03 at 10:08 +0200, Winfried Donkers wrote:
> The 'split button' is a derived SfxToolBoxControl which triggers an
> Execute function when the colour is chosen from the colour palette and
> triggers a virtual Select function when the left half of the button
> (last used colo
Hi Rob,
On 2012-04-03 at 00:07 +0200, Rob Snelders wrote:
> I have created 2 little patches. The first one is to start on the bug
> fdo#46390.
> The other patch solves also some build-errors I got when turning on the
> debug-mode. Also is rRequestData removed. It isn't defined in the class
> a
Hi Tomáš,
On Tuesday, 2012-04-03 00:54:22 +0200, Eike Rathke wrote:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=43084e8b30c101a44510b7a8267d5c2b316a17bb
Could you check if that works with your ICU 4.9 build and if so commit
it to the 3-5 branch?
Thanks
Eike
--
LibreOffice Calc
Hi,
just to get a feeling for string treatment:
Could this
+ m_pDoc->InsertTab(0,
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("Sheet1")));
+ m_pDoc->InsertTab(1,
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("Sheet2")));
(now having Lubos' patch) be written as
+ m_pDoc->InsertTa
Hi
I'm working my way through the codebase, translating the easy stuff.
What is the cleanest translation of this:
Reference< graphic::XGraphicProvider > xGraphProv(
xFact->createInstance(
C2U("com.sun.star.graphic.GraphicProvider")), uno::UNO_QUERY_THROW );
Hi,
I'm currently working on adding categories to the transitions viewable
in the Impress GUI (https://bugs.freedesktop.org/show_bug.cgi?id=36946).
I'm not sure how best to assign categories to the transitions. The list
of transitions is in xml/transitions.xml, which is loaded by
source/core
Hello all,
I'm not sure whether this is the correct list, sorry if not :-)
I notice that in daily build for Windows, three extensions are not
shown in Extension Manager, maybe actually not working.
Bug report at https://bugs.freedesktop.org/show_bug.cgi?id=48243
All 3 problematic extensions are
https://bugs.freedesktop.org/show_bug.cgi?id=37361
Bug 37361 depends on bug 47406, which changed state.
Bug 47406 Summary: Almost all graphics that have internal circuits are not
rending correctly.
https://bugs.freedesktop.org/show_bug.cgi?id=47406
What|Old Value
Thanks, Christina for doing wonderful job with the SVG stuff. I pushed
this one to master.
Cheers
Fridrich
On 01/04/12 21:29, Chr. Rossmanith wrote:
> Hi,
>
> this patch is a correction for the calculation of transformation
> matrices for skewX and skewY. With the patch applied the SVG test fil
In we have:
/** Wrap C++ const_cast, reinterpret_cast and static_cast expressions in
macros to keep code portable to old compilers (since most compilers still
lack RTTI support, dynamic_cast is not included here).
*/
#ifdef __cplusplus
#if defined SAL_W32 || defined SOLARIS || defined LI
After the discussions yesterday and looking at some already existing
apps, I think i have developed a plan to move forward with being able
to read and just open documents for starters.
I was thinking instead of providing the user with the whole Directory
tree, what do you guys think of giving
Hi,
On Tuesday, 2012-04-03 15:08:41 +0200, Eike Rathke wrote:
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=43084e8b30c101a44510b7a8267d5c2b316a17bb
>
> Could you check if that works with your ICU 4.9 build and if so commit
> it to the 3-5 branch?
Needed some backporting love, sti
On Tue, 2012-04-03 at 20:53 +0700, Korrawit Pruegsanusak wrote:
> I'm not sure whether this is the correct list, sorry if not :-)
Yep - regressions on master vs. the last release are of interest to
hackers to catch quickly, so - certainly here is a good place :-)
Thanks !
Based on this:
noel@ubuntu:~/libo$ git grep const_cast | wc -l
1986
noel@ubuntu:~/libo$ git grep reinterpret_cast | wc -l
3944
noel@ubuntu:~/libo$ git grep static_cast | wc -l
21179
I think we can safely say that no-one cares about using those old compilers.
Disclaimer: http://www.peralex.com
On 04/03/2012 03:11 PM, Noel Grandin wrote:
I'm working my way through the codebase, translating the easy stuff.
What is the cleanest translation of this:
Reference< graphic::XGraphicProvider > xGraphProv(
xFact->createInstance( C2U("com.sun.star.graphic.GraphicProvider")),
uno::UNO_QUERY_THROW
On 04/03/2012 04:12 PM, Tor Lillqvist wrote:
And why do we test the OS here anyway, shouldn't we be testing the
compiler and perhaps compiler version?
We didn't have/know about such fancy macros back when the crude
approximation OS => specific compiler worked oh so well for us.
Should this
> Yes.
Done, https://bugs.freedesktop.org/show_bug.cgi?id=48253
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Thanks a lot :) :) My first contribution :) Yeay ! ...
I would now like to know about my project specification . I had written
a mail about this to Mr. Thorsten Behrens about this , but I received no
reply .. can someone please tell me a way to contact him ... I have some
ideas with me t
On Tuesday 03 of April 2012, Tor Lillqvist wrote:
> (SAL_REINTERPRET_CAST is not used anywhere, says opengrok, so that can
> be binned outright.)
Stuff from sal/ is public API, so you should not remove anything from there
or you might break backwards compatibility for somebody (the fix is trivia
Hello,
I've committed all changes related to the macros and all the different
tinderbox compilers have already compiled fine, so I consider the experiment
successful.
As of now, there should be no need to use either of these macros.
OString/OUString now have overloads that handle string li
On Tue, 2012-04-03 at 17:52 +0200, Lubos Lunak wrote:
> On Tuesday 03 of April 2012, Tor Lillqvist wrote:
> > (SAL_REINTERPRET_CAST is not used anywhere, says opengrok, so that can
> > be binned outright.)
>
> Stuff from sal/ is public API, so you should not remove anything from there
> or you
On Tuesday 03 of April 2012, Michael Meeks wrote:
> On Tue, 2012-04-03 at 17:52 +0200, Lubos Lunak wrote:
> > On Tuesday 03 of April 2012, Tor Lillqvist wrote:
> > > (SAL_REINTERPRET_CAST is not used anywhere, says opengrok, so that can
> > > be binned outright.)
> >
> > Stuff from sal/ is public
On Tuesday 03 of April 2012, Lubos Lunak wrote:
> On Tuesday 03 of April 2012, Michael Meeks wrote:
> > On Tue, 2012-04-03 at 17:52 +0200, Lubos Lunak wrote:
> > > On Tuesday 03 of April 2012, Tor Lillqvist wrote:
> > > > (SAL_REINTERPRET_CAST is not used anywhere, says opengrok, so that
> > > > ca
On 03/04/12 18:36, Lubos Lunak wrote:
> On Tuesday 03 of April 2012, Lubos Lunak wrote:
>> On Tuesday 03 of April 2012, Michael Meeks wrote:
>>> On Tue, 2012-04-03 at 17:52 +0200, Lubos Lunak wrote:
On Tuesday 03 of April 2012, Tor Lillqvist wrote:
> (SAL_REINTERPRET_CAST is not used anywh
Don't we have a macro for marking these kinds of things as deprecated?
> is there some macro that is defined by LO build system for which we can
> assume that nobody outside of LO uses it? we could wrap the deprecated
> cruft in an #ifndef now, and remove it for LO4.
>
__
OK, I re-introduced SAL_REINTERPRET_CAST.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Christopher this is userful, but in a way you are jumping the gun here.
Tor and I discussed yesterday on a good place to start, and I agree with
him at this point its best to get something to where we can just open
the files.
As in my original email I am wondering if its worth making it easy
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Rainer Bielefeld changed:
What|Removed |Added
Depends on|40948 |
--
Configure bugmail: https://bugs.
https://bugs.freedesktop.org/show_bug.cgi?id=37361
Rainer Bielefeld changed:
What|Removed |Added
Depends on||40948
--
Configure bugmail: https://
Hi all!
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33599
I think I know where is the problem. In
sw/source/ui/docvw/SidebarTxtControl.cxx function SidebarTxtControl::LoseFocus.
There's a call for mrSidebarWin.UpdateData(); In this function it checks
whether there was any modification t
>I think I know where is the problem.
I think I know where the problem is. <- Sorry for the mistakes, i don't know
why i make them :)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.
Hi Lubos,
On Tuesday, 2012-04-03 18:17:27 +0200, Lubos Lunak wrote:
> I've committed all changes related to the macros and all the different
> tinderbox compilers have already compiled fine, so I consider the experiment
> successful.
Great, thanks!
A big step towards more readable and less i
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Rainer Bielefeld changed:
What|Removed |Added
Depends on|38067 |
--
Configure bugmail: https://bugs.
Hi David,
cpputools/prj/makefile.mk was missing in my patch, and this broke the
build, fixed:
David
Original Message
Subject:Re: [PATCH][REVIEW] gbuild conversion: module cpputools
Date: Mon, 02 Apr 2012 22:32:28 +0200
From: David Ostrovsky
To: David Tardon
Hi all
I need HTTPS connection and SSL support in my python extension
Unfortunatelly, it seems that python provided in libro 3.5.1 is not
ready for this
$ /opt/libreoffice3.5/program/python
Python 2.6.1 (r261:67515, Mar 5 2012, 18:19:36)
[GCC 4.2.4] on linux2
Type "help", "copyright", "credi
Hi,
Up to the present we don't have objections about the adopted LO
licensing model, therefore we also can state:
All of the code contributed to LibreOffice owned by Mandriva both now
and in the future can be licensed under the MPL/LGPLv3+ dual license.
Thanks
Rafael Cabral
Mandriva
__
I forward this mail from one of my co workers :
Hi,
Up to the present we don't have objections about the adopted LO
licensing model, therefore we also can state:
All of the code contributed to LibreOffice owned by Mandriva both now
and in the future can be licensed under the MPL/LGPLv3+ dual li
Hi all,
I just pushed my rework of ValueSet key navigation to master. Main
differences from the old one are:
* No more vertical wrap-around
* Last item can be easily displayed also when on a shorter row
ALso, the general behavior should be more consistent. NoneItem, if
present, is still sel
Hi Stephan,
thanks for the very informative long post!
Some time ago we discussed something along the lines of modernizing rdb
related code.
I wrote an IDL parser and the java generator unoidl2java is getting
almost complete. I have a few small patches lined up but I'd like to
get the java gene
Lubos Lunak wrote:
> Looks good to me, I only removed the return's at the end of function, as
> they
> are superfluous in void functions. Pushed, thank you.
Oops, I guess I got too robotic in that respect when I was changing the
return statements. Thanks.
> It seems to me you are correct. I've
https://bugs.freedesktop.org/show_bug.cgi?id=37361
dal...@psykax.com changed:
What|Removed |Added
Depends on||46071
--- Comment #262 from dal...@ps
On Wed, Apr 04, 2012 at 12:50:47AM +0200, David Ostrovsky wrote:
> Hi David,
>
> thank you for your comments. Here is another try.
> As you haven't merged feature/gbuild_components branch to master
> I let "gb_Executable_add_api" in place:
Good,
I will look at the patch and push it (with appropr
Hullo List,
What's the correct venue to report something so minor as this typo?
As of 1:00am -0400 today, the current /download/ page on libreoffice.org
has this text:
"Handy ressources"
My email client has kindly suggested 'resources' from its English
dictionary.
Cheers,
Kevin
_
Hey,
> just to get a feeling for string treatment:
>
> Could this
>
> + m_pDoc->InsertTab(0,
> rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("Sheet1")));
> + m_pDoc->InsertTab(1,
> rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("Sheet2")));
>
> (now having Lubos' patch) be written as
>
> + m_pD
Hey,
2012/4/2 karthik padmanabhan :
> Hi ,
>
> I'm submitting a patch for the easy hack 39749. I have written one test that
> tests the RenameTable() function in ScDocFunc class
Pushed with some minor tweaks.
You have still tabs in your patch. Please check in your editor
settings how to automati
I had looked at think free office, which I know doesnt support ODF but I
am using it more for the UI look. What I noted is that it displays all
the directories in ones devices.
I was thinking instead of doing that, When loading it would some how
index the location of all files and just display
> Please check in your editor
> settings how to automatically replace tabs with 4 spaces.
Not always 4, but 1..4 spaces, the right number so that the following
character is at a multiple of four characters from the start of the
line.
Also, whether that is the correct thing to do for a source file
On 04/03/2012 11:13 PM, Tomas Hlavaty wrote:
Some time ago we discussed something along the lines of modernizing rdb
related code.
I wrote an IDL parser and the java generator unoidl2java is getting
almost complete. I have a few small patches lined up but I'd like to
get the java generator as f
70 matches
Mail list logo
