Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-18 Thread Noel Power
Hi August, On 17/11/11 16:52, August Sodora wrote: a minor fix ) So, what I suggest is to mail the patch to me/list and I will test/integrate it ( already I fear some manual merging will be necessary as Everything is pushed to the branch feature/line-numbers-in-basicIDE. I have added a

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-14 Thread Noel Power
On 11/11/11 20:42, Michael Meeks wrote: SvtMiscOptions aMiscOptions; const bool bExperimentalMode = aMiscOptions.IsExperimentalMode(); Should get that for you to switch on; Noel - do you think that's enough ?:-) or do you really want the setting for this so it can be turned

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-14 Thread Noel Power
On 11/11/11 19:56, Noel Power wrote: On 11/11/11 19:25, August Sodora wrote: [...] Also, is there a consensus on how the option to hide/display line numbers should be added? Currently I'm trying to add a page to the options dialog in cui but I suppose it will really only have one option for

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-14 Thread Noel Power
On 14/11/11 17:17, Noel Power wrote: ok, since let me try and help with this, I am trying to add the menu and some supporting code to tie that in, when I have it done I hope you can take the patch and look at dynamically displaying/undisplaying the linenumbers. Perhaps as a start you could

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Noel Power
On 10/11/11 03:02, August Sodora wrote: Hello, I've attached a patch that attempts to add line numbers to the basic ide. I believe it is mostly correct, although I am seeing a couple of rendering issues that I haven't been able to track down yet. First, the scrollbar seems to jump around and

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread August Sodora
There are a couple problems as you mention with this patch, however I do think that this is *really* useful land certainly something that I would have liked to see at times. However sometimes I think the line numbers can just be annoying ;-) so I think definitely this should be configurable

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Noel Power
On 11/11/11 16:09, Noel Power wrote: On 10/11/11 03:02, August Sodora wrote: Hello, I've attached a patch that attempts to add line numbers to the basic ide. I believe it is mostly correct, although I am seeing a couple of rendering issues that I haven't been able to track down yet. First, the

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Noel Power
On 11/11/11 16:30, August Sodora wrote: There are a couple problems as you mention with this patch, however I do think that this is *really* useful land certainly something that I would have liked to see at times. However sometimes I think the line numbers can just be annoying ;-) so I

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Noel Power
On 11/11/11 16:50, Noel Power wrote: On 11/11/11 16:30, August Sodora wrote: I'd love to but I'm not exactly sure how. Currently I have it as a local branch. haha, yes, well not being much of a git guru myself I can't recall offhand what the command are for that, let me try and find out what

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread August Sodora
Ok, I've adjusted the patch to include the fix you provided (thanks!!). I only have two more stumbling blocks at this point. First, I don't have a account to commit with; would you mind creating a branch for this in the meantime? Also, is there a consensus on how the option to hide/display line

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Noel Power
On 11/11/11 19:25, August Sodora wrote: First, I don't have a account to commit with; you should think about asking for commit access, in the meantime I can add the feature branch for you ( but please remind me next week 'cause probably I will forget between now and then ) Also, is there a

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Michael Meeks
On Fri, 2011-11-11 at 11:30 -0500, August Sodora wrote: Of course :-) I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Markus Mohrhard
Hey, to make it easier for everyone I pushed it to a feature branch. The new feature branch for this is: feature/line-numbers-in-basicIDE. As soon as you get your commit access by Michael, you can work on this branch without to worry about the master branch too much. Markus

Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-11 Thread Cor Nouws
August Sodora wrote (11-11-11 17:30) Of course :-) I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first configurable thing about

[Libreoffice] [PATCH] Added line numbers to the basic ide

2011-11-09 Thread August Sodora
Hello, I've attached a patch that attempts to add line numbers to the basic ide. I believe it is mostly correct, although I am seeing a couple of rendering issues that I haven't been able to track down yet. First, the scrollbar seems to jump around and flicker a lot more than it does without this