Re: [Libusbx-devel] Improved logging v2

2013-06-30 Thread Ludovic Rousseau
2013/6/27 Tim Roberts : > Hans de Goede wrote: >> You're right, and I'm sorry. I guess I'm to much of a rero person sometimes. >> >> Although win32 is far from my specialty I think the attach patch should fix >> it. Any chance you could give it a try? > > This is micro-optimization, of course, but

Re: [Libusbx-devel] Improved logging v2

2013-06-30 Thread Xiaofan Chen
On Sun, Jun 30, 2013 at 7:45 AM, Pete Batard wrote: > https://github.com/libusbx/libusbx/commit/7b893cc7cee185c0bf771166ca61a05b32800556 > should now fix the cywgin issue, as well as sort our gettimeofday() > usage for all the Windows compilers. It also includes the missing "%s" > reported earlier

Re: [Libusbx-devel] Improved logging v2

2013-06-30 Thread Xiaofan Chen
On Sun, Jun 30, 2013 at 4:28 PM, Xiaofan Chen wrote: > On Sun, Jun 30, 2013 at 7:45 AM, Pete Batard wrote: >> Once more, given the amount of changes that have been pushed since RC1, >> I would strongly suggest that we declare RC2 and push the 1.0.16 >> milestone (due tomorrow [1]) by one week (wh

[Libusbx-devel] Possible alignment issues with struct libusb_transfer buffer pointer

2013-06-30 Thread Paul Fertser
Hi, After I tried including libusb.h via an additional local header, I've stumpled upon a build failure (this is for libusbx HEAD but the same can be seen with plain libusb): In file included from libusb_dummy.h:2:0, from libusb1_common.h:25, from libusb1_common.

Re: [Libusbx-devel] Improved logging v2

2013-06-30 Thread Pete Batard
On 2013.06.30 08:58, Ludovic Rousseau wrote: > 2013/6/27 Tim Roberts : >> This is micro-optimization, of course, but it would be more efficient to >> do this instead: >> fputs(str, stderr); > > I also agree. Maybe Pete missed your email. Oops, my bad. Apologies to Tim for missing his mail, an