Hi,
spotted by gcc 4.3, in libvirt 0.4.0, xen_unified.c:xenUnifiedDomainSuspend()
if (priv-opened[i]
which should probably be:
if (priv-opened[XEN_UNIFIED_HYPERVISOR_OFFSET]
because it is outside of the loop, and the other indices in that
if ().
--- src/xen_unified.c 2008/01/28
On Sun, Jan 27, 2008 at 08:32:10PM +, Daniel P. Berrange wrote:
As mentioned in this thread:
http://www.redhat.com/archives/libvir-list/2008-January/msg00475.html
The code for calculating block devices numbers has a number of flaws.
This patch fixes the flaws and adds a comprehensive
Hi,
I received the error
In file included from libvirt.c:32:
internal.h: At top level:
internal.h:177: error: expected specifier-qualifier-list before
'pthread_mutex_t'
In order to fix this problem, I installed the 'pthreads' package on my MinGW.
Then added include pthread.h in src/internal.h
Jim Meyering [EMAIL PROTECTED] wrote:
Nice patch!
...
Here's a patch that removes that and fixes the two typos:
[and if you want to tighten up the xstr*-based parsing, this
means there's one fewer use to change]
Whoops. That patch was buggy.
This one actually passes the tests:
---
Gabriel Kaufmann wrote:
In order to fix this problem, I installed the ‘pthreads’ package on my
MinGW.
Then added include pthread.h in src/internal.h
Is this the right action?
Yes, I think so. This sounds like a regression.
Rich.
--
Emerging Technologies, Red Hat -
On Mon, Jan 28, 2008 at 11:25:12PM +0100, Marcus Meissner wrote:
Hi,
spotted by gcc 4.3, in libvirt 0.4.0, xen_unified.c:xenUnifiedDomainSuspend()
if (priv-opened[i]
which should probably be:
if (priv-opened[XEN_UNIFIED_HYPERVISOR_OFFSET]
because it is outside of the loop, and
Once I had a static virsh binary, I ran this:
cd src valgrind --leak-check=full ./virsh --connect \
test://$PWD/../docs/testnode.xml list
which exposed some leaks.
I fixed them like this:
Plug test-related leaks.
* src/test.c (testLoadNetwork): Free forwardDev.
Atsushi SAKAI wrote:
Hi,
I succeed test (2) but failed (1).
I think this is reasonable for virsh on Windows.
Interesting ... what was the error message when you did:
virsh.exe -c test:///default list
Anyway currently(from 1/21) pthread is used on hash.c
It requires pthread-win32 for
On Tue, Jan 29, 2008 at 01:09:40PM +, John Levon wrote:
On Tue, Jan 15, 2008 at 03:47:58AM +, John Levon wrote:
I have an old HVM guest defined in 3.0.4, and now I'm running 3.1.2 and
libvirt 0.4.0. The config looks like this:
Dan (Berrange) has looked at this somewhat. He feels
On Tue, Jan 29, 2008 at 11:32:04AM +0900, Hiroyuki Kaguchi wrote:
There are two logic error and a unnecessary else-statement
in virHashRemoveSet function.
This patch fix the following.
(1/3) The logic error that use released memory area.
(2/3) The logic error that doesn't remove elements.
On Fri, Jan 25, 2008 at 11:17:44PM +0100, Jim Meyering wrote:
Add framework for code style- and syntax-checking rules.
Almost all tests are initially disabled via the list in Makefile.cfg.
* Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free.
Omit names of files that automake includes
On Fri, Jan 25, 2008 at 11:16:15PM +0100, Jim Meyering wrote:
The first patch simply removes the useless if tests.
Following it, I introduce a make syntax-check framework
similar to what I use in coreutils. In it, most tests
are disabled, except the new one that tests for the unnecessary
On Tue, Jan 29, 2008 at 11:44:50AM +0100, Jim Meyering wrote:
Once I had a static virsh binary, I ran this:
cd src valgrind --leak-check=full ./virsh --connect \
test://$PWD/../docs/testnode.xml list
which exposed some leaks.
I fixed them like this:
Plug test-related
Sebastian Reitenbach wrote:
Hi,
I am running sles10sp1 x86_64. I try to get xen 3.1.0 running on it, as I
need a feature not in 3.0.4.
Configure works well, but when it comes to compilation, then it fails with
the following reason:
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../gnulib/lib
On Tue, Jan 29, 2008 at 04:58:26PM +0100, Guido Guenther wrote:
Hi,
attached patch drops the assumption that a non-root user has read access
to the guest OSes partition - he doesn't need to since all interaction
is handled via libvirt and giving the user read access for a simple MBR
block
On Tue, Jan 29, 2008 at 05:01:17PM +0100, Jim Meyering wrote:
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim Meyering wrote:
I tried to build static binaries in the usual libtool way,
via configure --disable-shared and got some link errors
due to the tests linking only with
Hi,
attached patch drops the assumption that a non-root user has read access
to the guest OSes partition - he doesn't need to since all interaction
is handled via libvirt and giving the user read access for a simple MBR
block read test seems like overkill. Please apply if appropriate, patch
is
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim Meyering wrote:
I tried to build static binaries in the usual libtool way,
via configure --disable-shared and got some link errors
due to the tests linking only with shared-lib-related files.
Here's the fix:
Avoid link errors with
Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
...
build-aux/find-unnecessary-if-before-free | 41 +++
build-aux/vc-list-files | 50 +++
The build-aux directory currently only contains auto-generated files.
If its not too much pain, can we put these 2
On Tue, Jan 29, 2008 at 04:41:30PM +0100, Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
...
build-aux/find-unnecessary-if-before-free | 41 +++
build-aux/vc-list-files | 50 +++
The build-aux directory currently only contains auto-generated files.
Daniel P. Berrange [EMAIL PROTECTED] wrote:
...
build-aux/find-unnecessary-if-before-free | 41 +++
build-aux/vc-list-files | 50 +++
The build-aux directory currently only contains auto-generated files.
If its not too much pain, can we put these 2 helpers into scripts/
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Fri, Jan 25, 2008 at 11:18:22PM +0100, Jim Meyering wrote:
Enable the duplicate-the test; fix violations
* Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
* docs/virsh.pod: Remove a duplicate the.
* libvirt.spec.in: Likewise.
*
Jim Meyering wrote:
I tried to build static binaries in the usual libtool way,
via configure --disable-shared and got some link errors
due to the tests linking only with shared-lib-related files.
Here's the fix:
Avoid link errors with configure --disable-shared.
*
On Fri, Jan 25, 2008 at 11:18:22PM +0100, Jim Meyering wrote:
Enable the duplicate-the test; fix violations
* Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
* docs/virsh.pod: Remove a duplicate the.
* libvirt.spec.in: Likewise.
* virsh.1: Likewise.
Signed-off-by: Jim Meyering
Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Fri, Jan 25, 2008 at 11:17:09PM +0100, Jim Meyering wrote:
Given code like if (foo) free (foo); remove the useless if (foo) part.
Likewise, given if (foo != NULL) free (foo); remove the useless if test.
ACK - already
Jim Meyering wrote:
Checking for violations in libvirt exposed a few new ones in gnulib.
This fixes those and also pulls in a few unrelated changes.
ACK.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Fri, Jan 25, 2008 at 11:17:09PM +0100, Jim Meyering wrote:
Given code like if (foo) free (foo); remove the useless if (foo) part.
Likewise, given if (foo != NULL) free (foo); remove the useless if test.
ACK - already reviewed the previous
Jim Meyering wrote:
Enable the config.h-requiring test; fix violations
Use config.h, not config.h, per autoconf documentation.
* Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
* .x-sc_require_config_h: New file, to list exempted files.
* Makefile.am (EXTRA_DIST): Add
Daniel P. Berrange wrote:
On Fri, Jan 25, 2008 at 11:18:22PM +0100, Jim Meyering wrote:
Enable the duplicate-the test; fix violations
* Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
* docs/virsh.pod: Remove a duplicate the.
* libvirt.spec.in: Likewise.
* virsh.1: Likewise.
Daniel P. Berrange [EMAIL PROTECTED] wrote:
...
-suspended domain to now be eligible for scheduling by the the underlying
+suspended domain to now be eligible for scheduling by the underlying
hypervisor.
.IP \fBttyconsole\fR \fIdomain-id\fR 4
.IX Item ttyconsole domain-id
This probably
On Fri, Jan 25, 2008 at 11:23:55PM +0100, Jim Meyering wrote:
Enabling these is easy, since they test for things for which
there are no violations.
ACK, Both sensible checks
Dan
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules:
Gabriel Kaufmann wrote:
I tool libvirt-0.dll and I am using it in VC.
In order to do this, I had to dynamically load the DLL and map all its
functions.
This is somewhat outside my experience. My best suggestion (guess) is
to try adding __declspec(dllexport) around some libvirt functions to
On Fri, Jan 25, 2008 at 11:22:51PM +0100, Jim Meyering wrote:
Enable the assert.h-checking test; fix violations.
* Makefile.cfg (local-checks-to-skip)
[sc_prohibit_assert_without_use]: Enable.
* qemud/mdns.c: Don't include assert.h; no uses of assert here.
* qemud/qemud.c: Likewise.
*
Hi,
I am running sles10sp1 x86_64. I try to get xen 3.1.0 running on it, as I
need a feature not in 3.0.4.
Configure works well, but when it comes to compilation, then it fails with
the following reason:
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../gnulib/lib -I../gnulib/lib -I../include
On Fri, Jan 25, 2008 at 11:22:04PM +0100, Jim Meyering wrote:
This ensures that files with translatable strings
are listed in po/POTFILES.in.
Currently it checks only the error function.
Obviously we'll have to add a few more here, but I'll
do that separately.
Enable the
On Fri, Jan 25, 2008 at 11:20:18PM +0100, Jim Meyering wrote:
Checking for violations in libvirt exposed a few new ones in gnulib.
This fixes those and also pulls in a few unrelated changes.
ACK.
Dan
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=-
On Tue, Jan 15, 2008 at 03:47:58AM +, John Levon wrote:
I have an old HVM guest defined in 3.0.4, and now I'm running 3.1.2 and
libvirt 0.4.0. The config looks like this:
Dan (Berrange) has looked at this somewhat. He feels (probably rightly)
that it's xend's bug. However these versions
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
---BeginMessage---
That's it!
Richard W.M. Jones wrote:
My bridge section looks like this:
interface type='bridge'
source dev='br0'/
target dev='vnet7'/
mac address=11:22:33:44:EE:FC/
/interface
Do I need to create the vnet7 device before hand? I thought this might be
something libvirt created
On Tue, Jan 29, 2008 at 05:57:51PM +, Richard W.M. Jones wrote:
Richard W.M. Jones wrote:
My bridge section looks like this:
interface type='bridge'
source dev='br0'/
target dev='vnet7'/
mac address=11:22:33:44:EE:FC/
/interface
Do I need to create the
Jim Meyering wrote:
Enabling these is easy, since they test for things for which
there are no violations.
ACK.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE,
Jim Meyering wrote:
Enable the assert.h-checking test; fix violations.
* Makefile.cfg (local-checks-to-skip)
[sc_prohibit_assert_without_use]: Enable.
* qemud/mdns.c: Don't include assert.h; no uses of assert here.
* qemud/qemud.c: Likewise.
* qemud/remote.c: Likewise.
ACK - nice one.
I'd be
Jim Meyering wrote:
This ensures that files with translatable strings
are listed in po/POTFILES.in.
Currently it checks only the error function.
Obviously we'll have to add a few more here, but I'll
do that separately.
Good catch ... ACK.
Rich.
--
Emerging Technologies, Red Hat -
I tried to build static binaries in the usual libtool way,
via configure --disable-shared and got some link errors
due to the tests linking only with shared-lib-related files.
Here's the fix:
Avoid link errors with configure --disable-shared.
* tests/Makefile.am (LDADDS): Add
Gabriel Kaufmann wrote:
Hi,
I'm still unable to build (see output files attached). This is from the sources
I downloaded from ftp://libvirt.org/libvirt/libvirt-cvs-snapshot.tar.gz
When running configure I get a popup error message that libconf-2.dll is
missing. Looking at MinGW site, I
Daniel P. Berrange wrote:
Can you edit the src/xen_internal.c file and in the xenHypervisorGetDomInfo()
method, add a printf() for the 'domain_flags' flags variable. IMHO the
way we deal with this isn't quite correct. We merely mask out the high
bits and then switch on the resulting value.
Gabriel Kaufmann wrote:
I want to be able to connect to the Xen server using libvirt [...]
And yes, connecting to a remote Xen server from Windows should work. At
least, it does for me. The server must be running libvirtd, and you
will need to specify a remote connection URI such as
Russ Blaine wrote:
Daniel P. Berrange wrote:
Can you edit the src/xen_internal.c file and in the
xenHypervisorGetDomInfo()
method, add a printf() for the 'domain_flags' flags variable. IMHO the
way we deal with this isn't quite correct. We merely mask out the high
bits and then switch on the
On Tue, Jan 29, 2008 at 10:01:35AM -0800, Russ Blaine wrote:
Daniel P. Berrange wrote:
Can you edit the src/xen_internal.c file and in the
xenHypervisorGetDomInfo()
method, add a printf() for the 'domain_flags' flags variable. IMHO the
way we deal with this isn't quite correct. We merely
Jim Meyering wrote:
Given code like if (foo) free (foo); remove the useless if (foo) part.
Likewise, given if (foo != NULL) free (foo); remove the useless if test.
ACK.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley
Hi,
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Sebastian Reitenbach wrote:
Hi,
I am running sles10sp1 x86_64. I try to get xen 3.1.0 running on it, as
I
need a feature not in 3.0.4.
Configure works well, but when it comes to compilation, then it fails
with
the following
On Tue, Jan 29, 2008 at 11:44:30AM +0100, Jim Meyering wrote:
I tried to build static binaries in the usual libtool way,
via configure --disable-shared and got some link errors
due to the tests linking only with shared-lib-related files.
Here's the fix:
Avoid link errors with
On Fri, Jan 25, 2008 at 11:17:09PM +0100, Jim Meyering wrote:
Given code like if (foo) free (foo); remove the useless if (foo) part.
Likewise, given if (foo != NULL) free (foo); remove the useless if test.
ACK - already reviewed the previous version of it.
Dan
--
|=- Red Hat, Engineering,
Jim Meyering wrote:
Once I had a static virsh binary, I ran this:
cd src valgrind --leak-check=full ./virsh --connect \
test://$PWD/../docs/testnode.xml list
which exposed some leaks.
I fixed them like this:
Plug test-related leaks.
* src/test.c (testLoadNetwork):
Hi,
I changed some of the XML for a qemu virtual machine. The original
file was generated by virt-manager, but I wanted to use bridged
networking as described in the documentation on the libvirt website. Is
there something I need to for my xml changes to show up in the virtual
machine?
On Tue, Jan 29, 2008 at 11:20:06AM -0500, Maxwell Bottiger wrote:
Hi,
I changed some of the XML for a qemu virtual machine. The original
file was generated by virt-manager, but I wanted to use bridged
networking as described in the documentation on the libvirt website. Is
there
On Mon, Jan 28, 2008 at 12:07:22PM +0100, Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
As mentioned in this thread:
http://www.redhat.com/archives/libvir-list/2008-January/msg00475.html
The code for calculating block devices numbers has a number of flaws.
This patch
Daniel P. Berrange [EMAIL PROTECTED] wrote:
...
Should be hda hdp actually :-)
Oh, right :-)
It looks fine, now.
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Jan 29, 2008 at 11:32:04AM +0900, Hiroyuki Kaguchi wrote:
There are two logic error and a unnecessary else-statement
in virHashRemoveSet function.
Hum, I will have to double check, I cleaned up something in libxml2
recently which may have been similar.
This patch fix the following.
Host is Solaris, guest is WinXP.
Richard W.M. Jones wrote:
Russ Blaine wrote:
Daniel P. Berrange wrote:
Can you edit the src/xen_internal.c file and in the
xenHypervisorGetDomInfo()
method, add a printf() for the 'domain_flags' flags variable. IMHO the
way we deal with this isn't quite
Daniel P. Berrange wrote:
What hypervisor version are you running. I'm struggling to see the codepath
in the hypervisor 'getdomaininfo' call which could lead to domain_flags
being zero. AFAICT, as well as the HVM flags, there must always be at
least one other bit set.
This is opensolaris 81
Thank you very much for your help. I have submitted a bugzilla report
asking to update the documentation to fix the bridging XML problem, as
well as perhaps look at the associated error message.
At this point I have my ethernet bridge br0 configured with the IP
192.168.1.23 and my host network
Would you give me a comment on this patch? If not, please apply it.
tablet and mouse are set as a value of the
/local/domain/domid/image/hvm/usbdevice,
but libvirt expects usbdevice and usbmouse as a value.
This causes the following.
If a USB device is attached by virt-manager,
the USB
FYI I've just checked this in:
Let make syntax-check pass.
* .x-sc_avoid_if_before_free: Exempt ChangeLog.
* tests/statstest.c: Include config.h, not config.h.
diff --git a/.x-sc_avoid_if_before_free b/.x-sc_avoid_if_before_free
index 627dcdf..f83ae7b 100644
---
64 matches
Mail list logo
