Re: [Libvir] Please add RSS for libvirt updates.

2008-02-21 Thread Atsushi SAKAI
Hi, Ryan One question as just for confirmation, Does the libvirt git repository synchonize to the CVS repository? Thanks Atsushi SAKAI Atsushi SAKAI <[EMAIL PROTECTED]> wrote: > Thanks! > > Its very helpful > > Thanks > Atsushi SAKAI > > Ryan Scott <[EMAIL PROTECTED]> wrote: > > > Atsushi

Re: [Libvir] Please add RSS for libvirt updates.

2008-02-21 Thread Atsushi SAKAI
Thanks! Its very helpful Thanks Atsushi SAKAI Ryan Scott <[EMAIL PROTECTED]> wrote: > Atsushi SAKAI wrote: > > Hi, > > > > I have a request about libvirt updates. > > Currently I am checking software updates by seeing > > RSS reader. > > Of course, > > mercurial(hg) and git creates RSS feeds

Re: [Libvir] Please add RSS for libvirt updates.

2008-02-21 Thread Ryan Scott
Atsushi SAKAI wrote: Hi, I have a request about libvirt updates. Currently I am checking software updates by seeing RSS reader. Of course, mercurial(hg) and git creates RSS feeds. But CVS does not create such kind of feeds. I hope some day libvirt adds RSS feeds by using cvs2rss etc. http:

[Libvir] Please add RSS for libvirt updates.

2008-02-21 Thread Atsushi SAKAI
Hi, I have a request about libvirt updates. Currently I am checking software updates by seeing RSS reader. Of course, mercurial(hg) and git creates RSS feeds. But CVS does not create such kind of feeds. I hope some day libvirt adds RSS feeds by using cvs2rss etc. http://laughingmeme.org/cvs2rs

Re: [Libvir] 1/4 Additions to the public API

2008-02-21 Thread Daniel Veillard
On Thu, Feb 21, 2008 at 10:21:09PM +, Daniel P. Berrange wrote: > On Thu, Feb 21, 2008 at 05:13:51PM -0500, Daniel Veillard wrote: > > On Thu, Feb 21, 2008 at 08:56:17PM +, Richard W.M. Jones wrote: > > > This just adds the four new functions to the public API. > > [...] > > > +/** > > > +

Re: [Libvir] [PATCH]: Make iSCSI login actually work

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 05:27:17PM -0500, Chris Lalancette wrote: > Hello, > I mentioned this before, but this patch must have been dropped when Dan > committed storage stuff to CVS. In order for iSCSI login to work properly, > you > must properly --sendtargets before trying to login, otherw

[Libvir] [PATCH]: Make iSCSI login actually work

2008-02-21 Thread Chris Lalancette
Hello, I mentioned this before, but this patch must have been dropped when Dan committed storage stuff to CVS. In order for iSCSI login to work properly, you must properly --sendtargets before trying to login, otherwise your logins will fail. This patch just adds a --sendtargets command righ

Re: [Libvir] 1/4 Additions to the public API

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 05:13:51PM -0500, Daniel Veillard wrote: > On Thu, Feb 21, 2008 at 08:56:17PM +, Richard W.M. Jones wrote: > > This just adds the four new functions to the public API. > [...] > > +/** > > + * virNetworkDHCPHostMapping: > > + * > > + * hostname mappings are returned by v

Re: [Libvir] 1/4 Additions to the public API

2008-02-21 Thread Daniel Veillard
On Thu, Feb 21, 2008 at 08:56:17PM +, Richard W.M. Jones wrote: > This just adds the four new functions to the public API. [...] > +/** > + * virNetworkDHCPHostMapping: > + * > + * hostname mappings are returned by virNetworkListDHCPHostMapping. > + */ > +typedef struct _virNetworkDHCPHostMappi

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 02:04:31PM -0800, Dan Smith wrote: > DL> Right. For a container, would be the only member of > DL> as well right? At the moment, I don't know of anything else that > DL> we will be adding to . > > No, contains lots of stuff, just none of it applies to a > container :)

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Dan Smith
DL> Right. For a container, would be the only member of DL> as well right? At the moment, I don't know of anything else that DL> we will be adding to . No, contains lots of stuff, just none of it applies to a container :) From the perspective of a consumer of the interface, there is only one

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Dave Leskovec
Dan Smith wrote: > DL> That makes sense to me. I guess I'd lean towards leaving > DL> in the container block since a container isn't really starting a > DL> new os image. Perhaps Dan Smith has some comments on this... > > Oh I *always* have some comments... :) > > From the above example, woul

[Libvir] 4/4 virsh

2008-02-21 Thread Richard W.M. Jones
This adds four new subcommands to virsh allowing you to control the new functionality. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in

[Libvir] 3/4 Remote driver

2008-02-21 Thread Richard W.M. Jones
This implements the changes in the client & server ends of the remote driver. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England a

[Libvir] 2/4 QEMU driver

2008-02-21 Thread Richard W.M. Jones
This patch implements the QEMU driver part of the change. We run dnsmasq with the extra --dhcp-hostsfile=... parameter, and then include functions to read and write this file. When the file changes we send SIGHUP to dnsmasq. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjone

[Libvir] 1/4 Additions to the public API

2008-02-21 Thread Richard W.M. Jones
This just adds the four new functions to the public API. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company

[Libvir] [Discussion] 0/4 Implement DHCP host mappings for virtual networks

2008-02-21 Thread Richard W.M. Jones
This is a series of patches to implement DHCP IP & hostname mappings for libvirt virtual networks. ** NOTE: This patch is not to be applied. There is some memory corruption bug which I'm still tracking down. What this patch allows you to do is to create a table of IP address to host (define

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Dan Smith
DL> That makes sense to me. I guess I'd lean towards leaving DL> in the container block since a container isn't really starting a DL> new os image. Perhaps Dan Smith has some comments on this... Oh I *always* have some comments... :) From the above example, would be the only member of , right

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Dave Leskovec
Daniel P. Berrange wrote: On Wed, Feb 20, 2008 at 10:24:18PM -0800, Dave Leskovec wrote: A sample XML format that can be used to define a linux container domain: TestContainer3 /usr/sbin/container_i

[Libvir] Re: default hypervisor selection

2008-02-21 Thread Anthony Liguori
Daniel Veillard wrote: - if /proc/xen doesn't exist (on linux, or /dev/xen on Solaris) well we should not do that we are pretty sure we will get an error when trying to connect - if /proc/vz is present, well it's very likely that if the kernel has been compiled with OpenVZ s

Re: [Libvir] [PATCH] Rewrite openvzSetUUID.

2008-02-21 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > So here's that same patch without the useless fseek: > > diff --git a/src/openvz_conf.c b/src/openvz_conf.c > index a274223..2e7b153 100644 I've committed that change: Rewrite openvzSetUUID. * src/openvz_conf.c (openvzSetUUID): Rewrite to

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Dave Leskovec
Daniel P. Berrange wrote: On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: This patch contains the base linux container support * new switch --with-lxc to enable support (off by default) Any reason this can't be on-by-default ? I know OpenVZ is off by default but I'd li

Re: Fwd: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo

2008-02-21 Thread Daniel Veillard
On Thu, Feb 21, 2008 at 09:38:21PM +0300, Anton Protopopov wrote: > >Oops, forgot the list... >-- Forwarded message -- >From: Anton Protopopov <[EMAIL PROTECTED]> >Date: 21.02.2008 21:25 >Subject: Re: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo >T

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Dave Leskovec
Hi Jim, Thanks for the comments. I'll go back to attaching patches rather than putting them inline and make the other suggested changes. -- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/ma

Fwd: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo

2008-02-21 Thread Anton Protopopov
Oops, forgot the list... -- Forwarded message -- From: Anton Protopopov <[EMAIL PROTECTED]> Date: 21.02.2008 21:25 Subject: Re: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo To: [EMAIL PROTECTED] I think, that if pnext = &vm; and *pnext = calloc(...); then vm

Re: [Libvir] [PATCH] Handle failed openvzLocateConfDir.

2008-02-21 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: ... > Here's the corrected patch: > > Handle failed openvzLocateConfDir. > * src/openvz_conf.c (openvzLocateConfDir, openvzGetVPSUUID): > (openvzSetUUID): Don't dereference NULL upon failure. Committed. -- Libvir-list mailing list Libvir-l

Re: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo

2008-02-21 Thread Daniel Veillard
On Thu, Feb 21, 2008 at 08:59:01PM +0300, Anton Protopopov wrote: > >Hi, >the patch is now in attachement.. >I think, that the statement >if (!vm) > vm = *pnext; >will never be executed: in the first pass, we have already check this >a few lines before; in

[Libvir] [PATCH] Useless statement in openvzGetVPSInfo

2008-02-21 Thread Anton Protopopov
Hi, the patch is now in attachement.. I think, that the statement if (!vm) vm = *pnext; will never be executed: in the first pass, we have already check this a few lines before; in next passes, vm remains the same... Anton diff --git a/src/openvz_conf.c b/src/openvz_conf.c index 79d1

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Mark McLoughlin
On Thu, 2008-02-21 at 15:40 +, Daniel P. Berrange wrote: > > Yes, you'd be trying to merge overlapping namespaces, but some ideas > > on > > that front: > > > > - If you simply prevent someone defining a VM using the same name as > > an existing VM defined via another driver, tha

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Daniel Veillard
On Thu, Feb 21, 2008 at 02:36:10PM +, Daniel P. Berrange wrote: > On Thu, Feb 21, 2008 at 09:26:38AM -0500, Daniel Veillard wrote: > > What do people think ? I would be tempted to provide a patch to change > > do_open() behaviour on linux in the case name is NULL or "", and > > then check wha

Re: [Libvir] default hypervisor selection

2008-02-21 Thread John Levon
On Thu, Feb 21, 2008 at 09:26:38AM -0500, Daniel Veillard wrote: > I guess on Solaris an easy heuristic would allow to pick the right > hypervisor by default too. /dev/xen isn't quite right as it can exist even when not booted into dom0. # cat /dev/xen/domcaps control_d This should do it, thoug

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 03:26:08PM +, Mark McLoughlin wrote: > On Thu, 2008-02-21 at 14:57 +, Daniel P. Berrange wrote: > > On Thu, Feb 21, 2008 at 02:51:20PM +, Richard W.M. Jones wrote: > > > > > > I'm mostly with Dan Berrange here. Surely an environment variable is > > > the right

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Mark McLoughlin
On Thu, 2008-02-21 at 14:57 +, Daniel P. Berrange wrote: > On Thu, Feb 21, 2008 at 02:51:20PM +, Richard W.M. Jones wrote: > > > > I'm mostly with Dan Berrange here. Surely an environment variable is > > the right thing to do, and then later we can add some advanced probing > > if the env

Re: [libvir] [PATCH] Double free in openvzGetVPSInfo

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 03:20:41PM +, Richard W.M. Jones wrote: > On Thu, Feb 21, 2008 at 06:07:48PM +0300, Anton Protopopov wrote: > > Hi, > > without this openvzGetVPSInfo() will cause "double free" when parse bad > > (i.e., > > really bad or empty) output from vzlist. > > Patch applied, th

Re: [libvir] [PATCH] Double free in openvzGetVPSInfo

2008-02-21 Thread Richard W.M. Jones
On Thu, Feb 21, 2008 at 06:07:48PM +0300, Anton Protopopov wrote: > Hi, > without this openvzGetVPSInfo() will cause "double free" when parse bad (i.e., > really bad or empty) output from vzlist. Patch applied, thanks. Can you send patches as attachments next time please. That one had the spaces

[libvir] [PATCH] Double free in openvzGetVPSInfo

2008-02-21 Thread Anton Protopopov
Hi, without this openvzGetVPSInfo() will cause "double free" when parse bad (i.e., really bad or empty) output from vzlist. diff --git a/src/openvz_conf.c b/src/openvz_conf.c index 482de82..0bc7084 100644 --- a/src/openvz_conf.c +++ b/src/openvz_conf.c @@ -536,7 +536,6 @@ openvzGetVPSInfo(virConne

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 02:51:20PM +, Richard W.M. Jones wrote: > > I'm mostly with Dan Berrange here. Surely an environment variable is > the right thing to do, and then later we can add some advanced probing > if the environment variable alone doesn't satisfy users. > > The only problem I

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Richard W.M. Jones
I'm mostly with Dan Berrange here. Surely an environment variable is the right thing to do, and then later we can add some advanced probing if the environment variable alone doesn't satisfy users. The only problem I see is making the NULL case unpredictable or introducing unreproducible bugs. B

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 10:24:18PM -0800, Dave Leskovec wrote: > The following set of patches add the first batch of linux container > support to libvirt. The work is not complete but I wanted to start > getting some of this out for comments. This set of patches supports the > following: > >

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 02:40:07PM +, Daniel P. Berrange wrote: > On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: > > This patch contains the base linux container support > > > > * new switch --with-lxc to enable support (off by default) > > Any reason this can't be on-by-defau

Re: [Libvir] [RFC] 3/3 Driver functions for linux container support

2008-02-21 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 10:28:36PM -0800, Dave Leskovec wrote: > This patch contains the new files lxc_driver.c and lxc_driver.h Looks fine to me. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/

Re: [Libvir] [RFC] 2/3 Config functions for managing linux containers

2008-02-21 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 10:25:11PM -0800, Dave Leskovec wrote: > This patch contains the new files lxc_conf.c and lxc_conf.h This looks pretty good to me - you follow all our coding conventions and use all the appropriate utility / helper functions. Only thing I ca nfind to comment on so far is:

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: > This patch contains the base linux container support > > * new switch --with-lxc to enable support (off by default) Any reason this can't be on-by-default ? I know OpenVZ is off by default but I'd like to see that on by default too

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Dan Smith
DV> What do people think ? I would be tempted to provide a patch to DV> change do_open() behaviour on linux in the case name is NULL or DV> "", and then check what hypervisor might be present and running, This has been bugging me recently as well, so I'm definitely in favor of a change. Is there

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 09:26:38AM -0500, Daniel Veillard wrote: > While going though the ovirt installation steps I got annoyed with > the need to add "-c qemu:///system" each time we are trying to start a > virsh command if using KVM. The dfault setup is basically to assume > a Xen hypervisor i

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Daniel Veillard
On Thu, Feb 21, 2008 at 11:11:40AM +0100, Jim Meyering wrote: > Dave Leskovec <[EMAIL PROTECTED]> wrote: > > The following set of patches add the first batch of linux container > > support to libvirt. The work is not complete but I wanted to start > > getting some of this out for comments. This s

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Daniel Veillard
On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: > This patch contains the base linux container support Looks fine to me, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED]

[Libvir] default hypervisor selection

2008-02-21 Thread Daniel Veillard
While going though the ovirt installation steps I got annoyed with the need to add "-c qemu:///system" each time we are trying to start a virsh command if using KVM. The dfault setup is basically to assume a Xen hypervisor if the URI is not specified, this is glued in the do_open internal opening

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Jim Meyering
Dave Leskovec <[EMAIL PROTECTED]> wrote: > The following set of patches add the first batch of linux container > support to libvirt. The work is not complete but I wanted to start > getting some of this out for comments. This set of patches supports > the following: Hi Dave, Something (your mai

Re: [Libvir] [RFC] 3/3 Driver functions for linux container support

2008-02-21 Thread Richard W.M. Jones
Looks good. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903 -- Libvir-list m

Re: [Libvir] [RFC] 2/3 Config functions for managing linux containers

2008-02-21 Thread Richard W.M. Jones
The code looks sensible, and its self-contained so +1. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Richard W.M. Jones
This patch all looks sensible. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 0379890