Re: [libvirt] [libvirt-tck 3/3] Add test case for daemon hook testing

2010-10-19 Thread Osier
- Daniel P. Berrange berra...@redhat.com wrote: On Mon, Oct 18, 2010 at 07:18:09AM +0800, Osier Yang wrote: Validate daemon hook is invocated correctly while start, restart, stop, reload libvirtd --- scripts/hooks/051-daemon-hook.t | 156 +++

Re: [libvirt] [libvirt-tck 2/3] Add module for hooks testing

2010-10-19 Thread Osier
updated patches attached.. adopted 'Slurp' in function 'compare_log' instead of using $/. :-) and add 'Slurp' requirement in 'Build.pl' - Osier - Osier jy...@redhat.com wrote: - Daniel P. Berrange berra...@redhat.com wrote: On Mon, Oct 18, 2010 at 07:18:08AM +0800, Osier Yang

Re: [libvirt] [libvirt-tck 3/3] Add test case for daemon hook testing

2010-10-19 Thread Osier
attach updated patch for daemon hook testing.. replaced cat with slurp, corrected typos. - Osier - Osier jy...@redhat.com wrote: - Daniel P. Berrange berra...@redhat.com wrote: On Mon, Oct 18, 2010 at 07:18:09AM +0800, Osier Yang wrote: Validate daemon hook is invocated

[libvirt] [PATCH 2/2] root_squash saga: virFileOperation may fail with EPERM

2010-10-19 Thread Dan Kenigsberg
Over root-squashing nfs, when virFileOperation() is called as uid==0, it may fail with EACCES, but also with EPERM, due to virFileOperationNoFork()'s failed attemp to chown a writable file. qemudDomainSaveFlag() should expect this case, too. --- src/qemu/qemu_driver.c |6 +++--- 1 files

[libvirt] [PATCH 1/2] initgroups() in qemudOpenAsUID()

2010-10-19 Thread Dan Kenigsberg
qemudOpenAsUID is intended to open a file with the credentials of a specified uid. Current implementation fails if the file is accessible to one of uid's groups but not owned by uid. This patch replaces the supplementary group list that the child process inherited from libvirtd with the default

Re: [libvirt] [PATCH] initgroups() in qemudOpenAsUID()

2010-10-19 Thread Dan Kenigsberg
On Mon, Oct 18, 2010 at 01:21:05AM -0400, Laine Stump wrote: On 10/17/2010 04:58 PM, Dan Kenigsberg wrote: qemudOpenAsUID is intended to open a file with the credentials of a specified uid. Current implementation fails if the file is accessible to one of uid's groups but not owned by uid.

Re: [libvirt] [PATCH] nwfilter: changes to rules in VM-host table

2010-10-19 Thread Daniel Veillard
On Thu, Oct 14, 2010 at 01:29:31PM -0400, Stefan Berger wrote: In the table built for traffic coming from the VM going to the host make the following changes: - don't ACCEPT the packets but do a 'RETURN' and let the host-specific firewall rules in subsequent rules evaluate whether the

[libvirt] virConnectClose question

2010-10-19 Thread Radek Hladik
Hello, I did find out that in some cases virConnectClose does not close the connection at all. It only returns -1 which by the documentation means error: Returns: 0 in case of success or -1 in case of error. But there is no other indication of what error it is. I am almost sure that it is

[libvirt] libvirt library binary name for linux

2010-10-19 Thread arnaud.champion
?Hi, I'm currently working on .Net / Mono bindings of libvirt. I know that under windows environment, the libvirt library binary is named libvirt-0.dll, what is it under linux ? I suppose libvirt.so, but I can't find it... Arnaud-- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread arnaud.champion
?Okay, I have found it, it's libvirt.so.0 I have also a libvirt.so.0.8.2, I suppose libvirt.so.0 is a link this. Another question, in my bindings I need the strdup function (pinvoked) and under windows, strdup is in msvcrt.dll, but where it is under linux ? Best regards, Arnaud From:

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Justin Clift
On 10/19/2010 10:16 PM, arnaud.champ...@devatom.fr wrote: ?Okay, I have found it, it's libvirt.so.0 I have also a libvirt.so.0.8.2, I suppose libvirt.so.0 is a link this. Another question, in my bindings I need the strdup function (pinvoked) and under windows, strdup is in msvcrt.dll, but

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Eric Blake
On 10/19/2010 06:07 AM, Justin Clift wrote: I'm not sure which library file the code is in though. For most things it's not needed. glibc (that is, libc.so, which is pretty much universally linked in to every other program already). You don't need to add -lc to your compiler line, at any

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread arnaud.champion
?I have tried libc.so and it doesn't contains _strdup, amybe it's strdup instead I will try. Anyway I have a little question (a windowsian question :) ). Under windows I have a tool named depends.exe with it, I can sse what is exposed thru a dll, is there any equivalent under linux ? Arnaud

Re: [libvirt] [PATCH] Update docs for memory parameters and memtune command

2010-10-19 Thread Daniel Veillard
On Mon, Oct 18, 2010 at 02:38:19PM +0530, Nikunj A. Dadhania wrote: Hi Matthias, Here goes the updated patch. From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com docs/formatdomain.html.in: Add memtune element details, added min_guarantee src/libvirt.c: Update virDomainGetMemoryParameters

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread arnaud.champion
?Okay, I have found it, I must use libc.so.6 and the function name is strdup not _strdup... So, it push to an other questions : Is libc.so.6 present on any linux distro ? (I use a fedora 13 here) Arnaud -- From: arnaud.champ...@devatom.fr Sent:

Re: [libvirt] [PATCH] memtune: Add min_guarantee to the virsh tool

2010-10-19 Thread Daniel Veillard
On Mon, Oct 18, 2010 at 03:02:55PM +0530, Nikunj A. Dadhania wrote: Hi, I am adding the min_guarantee to the memtune command with this patch. I have tested this at the virsh tool level. This parameter is not supported by QEMU or LXC. Can be used by ESX and in future by other hypervisors.

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Justin Clift
On 10/19/2010 11:25 PM, arnaud.champ...@devatom.fr wrote: ?I have tried libc.so and it doesn't contains _strdup, amybe it's strdup instead I will try. Anyway I have a little question (a windowsian question :) ). Under windows I have a tool named depends.exe with it, I can sse what is exposed

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Justin Clift
On 10/19/2010 11:31 PM, arnaud.champ...@devatom.fr wrote: ?Okay, I have found it, I must use libc.so.6 and the function name is strdup not _strdup... So, it push to an other questions : Is libc.so.6 present on any linux distro ? (I use a fedora 13 here) It's a very standard library.

Re: [libvirt] [PATCH] memtune: Add min_guarantee to the virsh tool

2010-10-19 Thread Matthias Bolte
2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com: Hi, I am adding the min_guarantee to the memtune command with this patch. I have tested this at the virsh tool level. This parameter is not supported by QEMU or LXC. Can be used by ESX and in future by other hypervisors. Nikunj

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Alejandro Mery
On Tue, Oct 19, 2010 at 14:57, Justin Clift jcl...@redhat.com wrote: On 10/19/2010 11:31 PM, arnaud.champ...@devatom.fr wrote: ?Okay, I have found it, I must use libc.so.6 and the function name is strdup not _strdup... So, it push to an other questions : Is libc.so.6 present on any linux

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread arnaud.champion
?Ok, good news -- From: Justin Clift jcl...@redhat.com Sent: Tuesday, October 19, 2010 2:57 PM To: arnaud.champ...@devatom.fr Cc: Eric Blake ebl...@redhat.com; libvir-list@redhat.com Subject: Re: [libvirt] libvirt library binary name for linux On

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Justin Clift
On 10/20/2010 12:03 AM, Alejandro Mery wrote: snip It's a very standard library. Sometimes it is libc.so.6, on older Linux's, it can be libc.so.5. You are generally safe to use it. :) why does he need to know it? It only helps to ruin portability. Heh. At a guess, Arnaud is looking like

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread arnaud.champion
?Well, as I have said I work on .Net/Mono bindings. To make bindings, we use largely the marshaling methods of .Net/Mono. I was working on bindings virConnectOpenAuth, so I have de marshal virConnectCredential struct, these kind of thing. Matthias Bolte help me a lot to make all the process

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread arnaud.champion
Yes I know that it is not good for portability and I plan to remove the use of strdup (and libc) by using custom marshaling, I was just making a test. -- From: Justin Clift jcl...@redhat.com Sent: Tuesday, October 19, 2010 3:11 PM To: Alejandro

Re: [libvirt] [PATCH 2/2] root_squash saga: virFileOperation may fail with EPERM

2010-10-19 Thread Daniel Veillard
On Tue, Oct 19, 2010 at 12:11:07PM +0200, Dan Kenigsberg wrote: Over root-squashing nfs, when virFileOperation() is called as uid==0, it may fail with EACCES, but also with EPERM, due to virFileOperationNoFork()'s failed attemp to chown a writable file. qemudDomainSaveFlag() should expect

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files

2010-10-19 Thread Daniel Veillard
On Mon, Oct 18, 2010 at 10:37:31AM -0600, Eric Blake wrote: On 10/18/2010 10:22 AM, Laine Stump wrote: + + if (result == NULL) { + virReportOOMError(); + goto cleanup; + } + + cleanup: Is that last goto necessary, since the label is reached next anyways? Maybe this is a defensive

Re: [libvirt] [PATCH v3] introduce VIR_CLOSE to be used rather than close()

2010-10-19 Thread Daniel Veillard
On Fri, Oct 15, 2010 at 06:06:26PM -0400, Stefan Berger wrote: V3: - many small nits addressed V2: - following Eric's suggestions and picking up his code suggestions Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am

Re: [libvirt] [PATCH] memtune: Add min_guarantee to the virsh tool

2010-10-19 Thread Daniel Veillard
On Tue, Oct 19, 2010 at 03:00:21PM +0200, Matthias Bolte wrote: 2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com: Hi, I am adding the min_guarantee to the memtune command with this patch. I have tested this at the virsh tool level. This parameter is not supported by QEMU or LXC.

Re: [libvirt] [PATCH v3] introduce VIR_CLOSE to be used rather than close()

2010-10-19 Thread Eric Blake
On 10/19/2010 07:34 AM, Daniel Veillard wrote: On Fri, Oct 15, 2010 at 06:06:26PM -0400, Stefan Berger wrote: V3: - many small nits addressed V2: - following Eric's suggestions and picking up his code suggestions Since bugs due to double-closed file descriptors are difficult to

Re: [libvirt] [PATCH 4/4] Fix symbol exports remove duplicated libvirt_util.la linkage

2010-10-19 Thread Daniel Veillard
On Thu, Oct 14, 2010 at 03:45:01PM +0100, Daniel P. Berrange wrote: On Thu, Oct 14, 2010 at 04:22:29PM +0200, Daniel Veillard wrote: On Tue, Oct 12, 2010 at 06:32:18PM +0100, Daniel P. Berrange wrote: From: Miloslav Trmač m...@redhat.com The libvirt_util.la library was mistakenly

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Eric Blake
[Would you mind changing your style to avoid top-posting?] On 10/19/2010 06:31 AM, arnaud.champ...@devatom.fr wrote: ?Okay, I have found it, I must use libc.so.6 and the function name is strdup not _strdup... Windows prefixes all system functions with _, Linux does not. strdup() is required

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Eric Blake
On 10/19/2010 07:13 AM, arnaud.champ...@devatom.fr wrote: ?Well, as I have said I work on .Net/Mono bindings. To make bindings, we use largely the marshaling methods of .Net/Mono. I was working on bindings virConnectOpenAuth, so I have de marshal virConnectCredential struct, these kind of

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Justin Clift
On 10/19/2010 02:29 AM, arnaud.champ...@devatom.fr wrote: ?Hi justin, here is a xls that I use to keep advance of bindings. In the .xls file, in the Types tab, it looks like virStoragePool and virStorageVol are both in there two times. ? -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH v4] introduce VIR_CLOSE to be used rather than close()

2010-10-19 Thread Stefan Berger
V4: - pushing #include ignore-value.h into files.h V3: - many small nits addressed V2: - following Eric's suggestions and picking up his code suggestions Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the

Re: [libvirt] [PATCHv2 00/14] vcpu - distinguish maximum from current

2010-10-19 Thread Daniel Veillard
On Wed, Oct 13, 2010 at 11:53:56AM -0600, Eric Blake wrote: Version 1 had ACKs on most of the patches, but raised several points (not the least of which was a lack of testing). I've now done more testing on xen than on qemu, so there may still be some qemu quirks. Version 2 of the patch

Re: [libvirt] [PATCH v3] introduce VIR_CLOSE to be used rather than close()

2010-10-19 Thread Daniel Veillard
On Tue, Oct 19, 2010 at 07:53:47AM -0600, Eric Blake wrote: On 10/19/2010 07:34 AM, Daniel Veillard wrote: On Fri, Oct 15, 2010 at 06:06:26PM -0400, Stefan Berger wrote: V3: - many small nits addressed V2: - following Eric's suggestions and picking up his code suggestions

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Matthias Bolte
2010/10/19 Eric Blake ebl...@redhat.com: On 10/19/2010 07:13 AM, arnaud.champ...@devatom.fr wrote: ?Well, as I have said I work on .Net/Mono bindings. To make bindings, we use largely the marshaling methods of .Net/Mono. I was working on bindings virConnectOpenAuth, so I have de marshal

Re: [libvirt] libvirt library binary name for linux

2010-10-19 Thread Eric Blake
On 10/19/2010 08:23 AM, Matthias Bolte wrote: strdup() is nothing more than malloc() followed by strcpy(); See [1] for more details. When I understood Arnaud correctly then passing the result of Marshal.StringToHGlobalAuto() directly as cred.result didn't work, but passing the result from

Re: [libvirt] [PATCH v4] introduce VIR_CLOSE to be used rather than close()

2010-10-19 Thread Stefan Berger
On 10/19/2010 10:16 AM, Eric Blake wrote: On 10/19/2010 08:08 AM, Stefan Berger wrote: There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. ACK with a couple of nits: Index:

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Justin Clift
On 10/20/2010 01:32 AM, arnaud.champ...@devatom.fr wrote: ?You are right, my mistake :) You'll find an update version attached to this mail. There is some new columns in the xls. Sample Code refer the name of the sample code project (the name is the same for Mono on .Net) Test .Net/Windows

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread arnaud.champion
?Why not, no problem for me. -- From: Justin Clift jcl...@redhat.com Sent: Tuesday, October 19, 2010 4:36 PM To: arnaud.champ...@devatom.fr Cc: libvir-list@redhat.com Subject: Re: [libvirt] C# bindings (Was: First patch) On 10/20/2010 01:32 AM,

[libvirt] [PATCH] proxy: Fix undefined reference to virClose

2010-10-19 Thread Matthias Bolte
Add src/util/files.c to libvirt_proxy_SOURCES. --- proxy/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 4716683..c9859a0 100644 --- a/proxy/Makefile.am +++ b/proxy/Makefile.am @@ -15,6 +15,7 @@ libexec_PROGRAMS =

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files

2010-10-19 Thread Matthias Bolte
2010/10/19 Daniel Veillard veill...@redhat.com: On Mon, Oct 18, 2010 at 10:37:31AM -0600, Eric Blake wrote: On 10/18/2010 10:22 AM, Laine Stump wrote: + + if (result == NULL) { + virReportOOMError(); + goto cleanup; + } + + cleanup: Is that last goto necessary, since the label is

Re: [libvirt] [PATCH] proxy: Fix undefined reference to virClose

2010-10-19 Thread Daniel Veillard
On Tue, Oct 19, 2010 at 04:46:15PM +0200, Matthias Bolte wrote: Add src/util/files.c to libvirt_proxy_SOURCES. --- proxy/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 4716683..c9859a0 100644 ---

Re: [libvirt] [PATCH] proxy: Fix undefined reference to virClose

2010-10-19 Thread Eric Blake
On 10/19/2010 08:46 AM, Matthias Bolte wrote: Add src/util/files.c to libvirt_proxy_SOURCES. --- proxy/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 4716683..c9859a0 100644 --- a/proxy/Makefile.am +++

Re: [libvirt] Need review of new vswitch concept info for technical accuracy

2010-10-19 Thread Stefan Berger
On 10/16/2010 03:01 PM, Justin Clift wrote: Hi all, Working on the Foundation Concepts for virtual switches at the moment. Does anyone have time/inclination to check over the concept graphics thus far, for technical accuracy? Especially the Routing mode and Non-routing mode ones, as I'm not

Re: [libvirt] [PATCH] proxy: Fix undefined reference to virClose

2010-10-19 Thread Matthias Bolte
2010/10/19 Eric Blake ebl...@redhat.com: On 10/19/2010 08:46 AM, Matthias Bolte wrote: Add src/util/files.c to libvirt_proxy_SOURCES. ---  proxy/Makefile.am |    1 +  1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 4716683..c9859a0

[libvirt] [PATCH] build: avoid false positive syntax-check failure

2010-10-19 Thread Eric Blake
* .x-sc_po_check: Exclude docs directory. --- Pushing this under the build-breaker rule. The docs directory is never compiled, and thus never processed by xgettext, and thus should be exempt from 'make syntax-check' looking for _(). .x-sc_po_check |1 + 1 files changed, 1 insertions(+), 0

Re: [libvirt] virConnectClose question

2010-10-19 Thread Matthias Bolte
2010/10/19 Radek Hladik ra...@eadresa.cz: Hello,        I did find out that in some cases virConnectClose does not close the connection at all. It only returns -1 which by the documentation means error: Returns: 0 in case of success or -1 in case of error. Check virGetLastError() for the

[libvirt] [PATCH] virsh: consolidate memtune docs

2010-10-19 Thread Eric Blake
* tools/virsh.pod (memtune): Drop second copy, fill to 80 columns, enhance wording. --- Seeing memtune twice in the man page is a bit confusing. This patch doesn't touch the pending issue of whether --min_guarantee makes sense, or should be deleted before it becomes a pre-mature API addition.

Re: [libvirt] process= support for 'qemu-kvm -name' [Bug 576950]

2010-10-19 Thread Daniel Veillard
On Mon, Oct 18, 2010 at 06:17:14PM -0400, John Morrissey wrote: On Mon, Oct 18, 2010 at 06:58:34PM +0100, Daniel P. Berrange wrote: On Mon, Oct 18, 2010 at 01:45:12PM -0400, John Morrissey wrote: Unfortunately, qemu uses prctl() to set the process title, which has a limit of 16

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Matthias Bolte
2010/10/18 arnaud.champ...@devatom.fr: The class library expose the LibvirtBindings namespace. This namespace expose all needed types (enum, struct). It also expose 2 main classes : libVirt and libvirtError. The libVirt class expose all  interfaces of the libvirt library to handle virtualized

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread arnaud.champion
The idea was to stick to libvirt API documentation which contain a libvirt part and a virError part. Types are used everywhere that's why they are at a upper level (LibvirtBindings). In fact, libVirt and libvirtError are in the LibvirtBindings, as they are classes. This is useful to clean the

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Alejandro Mery
On 19/10/10 17:58, arnaud.champ...@devatom.fr wrote: The idea was to stick to libvirt API documentation which contain a libvirt part and a virError part. Types are used everywhere that's why they are at a upper level (LibvirtBindings). In fact, libVirt and libvirtError are in the

Re: [libvirt] [PATCH] Change/create solution and project for Visual Studio and MonoDevelop for C# bindings

2010-10-19 Thread Matthias Bolte
2010/10/19 arnaud.champ...@devatom.fr: Hi, here are 2 patches for C# libvirt bindings. These patches create a new solution/project couple for Visual Studio 2010 with also a sample code and a solution/project couple for MonoDevelop with a sample code also. The sample code have been tested

Re: [libvirt] [PATCH v4 12/13] Adding memtune command to virsh tool

2010-10-19 Thread Eric Blake
On 10/08/2010 06:16 AM, Nikunj A. Dadhania wrote: +static int +cmdMemtune(vshControl *ctl, const vshCmd *cmd) +{ +virDomainPtr dom; +int hard_limit, soft_limit, swap_hard_limit; This is inherently limited to 32 bits. +hard_limit = vshCommandOptInt(cmd,

[libvirt] [PATCH] virsh: improve help text where integers are expected

2010-10-19 Thread Eric Blake
* tools/virsh.c (opts_freecell, opts_memtune, opts_vcpupin) (opts_setvcpus, opts_setmaxmem, opts_setmem) (opts_migrate_setmaxdowntime): Use VSH_OT_INT when only an integer is expected. --- I've pushed the virsh.pod cleanup. Also, should memtune be changed to use VSH_OT_INT rather than

[libvirt] [PATCH] virsh: fix range of memtune command

2010-10-19 Thread Eric Blake
* tools/virsh.c (cmdMemtune): Use long long for memory sizes. Simplify allocation, and plug memory leak. --- tools/virsh.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index cd4485f..4f41c6f 100644 --- a/tools/virsh.c

Re: [libvirt] [PATCH] virsh: fix range of memtune command

2010-10-19 Thread Eric Blake
On 10/19/2010 10:46 AM, Eric Blake wrote: * tools/virsh.c (cmdMemtune): Use long long for memory sizes. Simplify allocation, and plug memory leak. --- tools/virsh.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c

Re: [libvirt] [PATCH] virsh: improve help text where integers are expected

2010-10-19 Thread Eric Blake
On 10/19/2010 10:40 AM, Eric Blake wrote: * tools/virsh.c (opts_freecell, opts_memtune, opts_vcpupin) (opts_setvcpus, opts_setmaxmem, opts_setmem) (opts_migrate_setmaxdowntime): Use VSH_OT_INT when only an integer is expected. --- @@ -2583,7 +2583,7 @@ static const vshCmdInfo info_vcpupin[] = {

[libvirt] [PATCH] Fix compile errors in remote.c and newly added audit code

2010-10-19 Thread Matthias Bolte
--- I pushed this under the trivial complie error fix rule :) Matthias daemon/remote.c |4 ++-- src/util/virtaudit.c |4 ++-- src/util/virtaudit.h |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 44609c7..75df9b5

[libvirt] KVM Forum 2010: videos online [was Re: KVM Forum 2010: presentations online]

2010-10-19 Thread Chris Wright
* Chris Wright (chr...@redhat.com) wrote: We were also able to video the speakers, and will send a note when the videos are available. (and thanks again to Andrew Cathrow for making this happen) I don't think a note went out yet. The videos are available as well. thanks, -chris --

Re: [libvirt] [PATCH] Fix compile errors in remote.c and newly added audit code

2010-10-19 Thread Eric Blake
On 10/19/2010 11:06 AM, Matthias Bolte wrote: --- I pushed this under the trivial complie error fix rule :) Thanks. @@ -80,7 +80,7 @@ void virAuditSend(const char *file ATTRIBUTE_UNUSED, const char *func, size_t li void virAuditSend(const char *file ATTRIBUTE_UNUSED, const char *func,

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Justin Clift
On 10/20/2010 01:32 AM, arnaud.champ...@devatom.fr wrote: ?You are right, my mistake :) You'll find an update version attached to this mail. There is some new columns in the xls. Ok, how's this? http://justinclift.fedorapeople.org/csharp/csharp.html -- libvir-list mailing list

Re: [libvirt] virConnectClose question

2010-10-19 Thread Radek Hladik
Dne 19.10.2010 17:32, Matthias Bolte napsal(a): 2010/10/19 Radek Hladikra...@eadresa.cz: Hello, I did find out that in some cases virConnectClose does not close the connection at all. It only returns -1 which by the documentation means error: Returns: 0 in case of success or -1 in case

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Eric Blake
On 10/19/2010 11:49 AM, Justin Clift wrote: On 10/20/2010 01:32 AM, arnaud.champ...@devatom.fr wrote: ?You are right, my mistake :) You'll find an update version attached to this mail. There is some new columns in the xls. Ok, how's this?

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Justin Clift
On 10/20/2010 04:57 AM, Eric Blake wrote: snip Ok, how's this? http://justinclift.fedorapeople.org/csharp/csharp.html Can we also include a sample program using the bindings, as is done in http://justinclift.fedorapeople.org/csharp/python.html and

Re: [libvirt] virConnectClose question

2010-10-19 Thread Matthias Bolte
2010/10/19 Radek Hladik ra...@eadresa.cz: Dne 19.10.2010 17:32, Matthias Bolte napsal(a): 2010/10/19 Radek Hladikra...@eadresa.cz: Hello,        I did find out that in some cases virConnectClose does not close the connection at all. It only returns -1 which by the documentation means

[libvirt] [PATCH] Don't let daemon-conf test fail when auditing is disabled

2010-10-19 Thread Matthias Bolte
--- tests/daemon-conf |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tests/daemon-conf b/tests/daemon-conf index 0e756d4..921e589 100755 --- a/tests/daemon-conf +++ b/tests/daemon-conf @@ -86,6 +86,10 @@ fi # Replace the invalid host_uuid with one that is valid: sed

Re: [libvirt] [PATCH] Don't fail lxc domain start when memory controller support is missing

2010-10-19 Thread Guido Günther
On Mon, Oct 18, 2010 at 10:11:51AM +0100, Daniel P. Berrange wrote: On Fri, Oct 15, 2010 at 06:05:10PM +0200, Guido Günther wrote: On Fri, Oct 15, 2010 at 10:15:02AM +0200, Guido Günther wrote: Hi, starting of lxc domains currently fails if memory controller support is disabled in the

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Justin Clift
On 10/20/2010 05:08 AM, Justin Clift wrote: On 10/20/2010 04:57 AM, Eric Blake wrote: snip Ok, how's this? http://justinclift.fedorapeople.org/csharp/csharp.html Can we also include a sample program using the bindings, as is done in http://justinclift.fedorapeople.org/csharp/python.html and

Re: [libvirt] [PATCH] Don't let daemon-conf test fail when auditing is disabled

2010-10-19 Thread Eric Blake
On 10/19/2010 12:34 PM, Matthias Bolte wrote: --- tests/daemon-conf |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tests/daemon-conf b/tests/daemon-conf index 0e756d4..921e589 100755 --- a/tests/daemon-conf +++ b/tests/daemon-conf @@ -86,6 +86,10 @@ fi # Replace

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread arnaud.champion
?Well, it's really nice -- From: Justin Clift jcl...@redhat.com Sent: Tuesday, October 19, 2010 7:49 PM To: arnaud.champ...@devatom.fr Cc: libvir-list@redhat.com Subject: Re: [libvirt] C# bindings (Was: First patch) On 10/20/2010 01:32 AM,

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread arnaud.champion
?Well, I can make a little sample, with virConnectOpen instead of virConnectOpenAuth, because virConnectOpenAuth cannot work without callback handling, that's why it's larger. But I will be tomorrow ;) it's time to sleep for me. -- From: Justin

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Justin Clift
On 10/20/2010 06:57 AM, arnaud.champ...@devatom.fr wrote: ?Well, it's really nice Thanks. I'll submit that, so it at least gets online. We can add an example and updates later. :) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] C# bindings (Was: First patch)

2010-10-19 Thread Justin Clift
On 10/20/2010 06:59 AM, arnaud.champ...@devatom.fr wrote: ?Well, I can make a little sample, with virConnectOpen instead of virConnectOpenAuth, because virConnectOpenAuth cannot work without callback handling, that's why it's larger. But I will be tomorrow ;) it's time to sleep for me. Not a

[libvirt] [PATCH] nwfilter: avoid direction enforcment for certain types of rules

2010-10-19 Thread Stefan Berger
Avoid the enforcement of direction if - icmp rules specify the type/code information - the 'skipMatch' variable is set to 'true' Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c === ---

Re: [libvirt] [PATCH] nwfilter: avoid direction enforcment for certain types of rules

2010-10-19 Thread Eric Blake
On 10/19/2010 02:05 PM, Stefan Berger wrote: Avoid the enforcement of direction if - icmp rules specify the type/code information - the 'skipMatch' variable is set to 'true' Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c

Re: [libvirt] [PATCHv2] docs: added initial page for c# binding, with links to it

2010-10-19 Thread Daniel Veillard
On Wed, Oct 20, 2010 at 07:04:19AM +1100, Justin Clift wrote: Adds a new page for the C# language bindings being developed by Arnaud Champion. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ACK Daniel -- Daniel Veillard | libxml Gnome XML

Re: [libvirt] [PATCHv2] docs: added initial page for c# binding, with links to it

2010-10-19 Thread Eric Blake
On 10/19/2010 02:04 PM, Justin Clift wrote: Adds a new page for the C# language bindings being developed by Arnaud Champion. ACK. +h2Usage/h2 + +p + The class library exposes thebLibvirtBindings/b namespace. + This namespace exposes all of the needed types (enum, struct), +

Re: [libvirt] [PATCHv2] docs: added initial page for c# binding, with links to it

2010-10-19 Thread Justin Clift
On 10/20/2010 07:17 AM, Eric Blake wrote: snip This may need editing as we clean up the bindings to have shorter names (in the style of the python or Java bindings where virConn and virDomain are object names, and can thus be omitted from function names that operate on those objects), as well as

Re: [libvirt] [PATCHv2] docs: added initial page for c# binding, with links to it

2010-10-19 Thread Justin Clift
On 10/20/2010 07:14 AM, Daniel Veillard wrote: On Wed, Oct 20, 2010 at 07:04:19AM +1100, Justin Clift wrote: Adds a new page for the C# language bindings being developed by Arnaud Champion. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ACK Thanks

Re: [libvirt] [PATCH] nwfilter: changes to rules in VM-host table

2010-10-19 Thread Stefan Berger
On 10/19/2010 06:31 AM, Daniel Veillard wrote: On Thu, Oct 14, 2010 at 01:29:31PM -0400, Stefan Berger wrote: In the table built for traffic coming from the VM going to the host make the following changes: - don't ACCEPT the packets but do a 'RETURN' and let the host-specific firewall rules

Re: [libvirt] [PATCH] nwfilter: avoid direction enforcment for certain types of rules

2010-10-19 Thread Stefan Berger
On 10/19/2010 04:14 PM, Eric Blake wrote: On 10/19/2010 02:05 PM, Stefan Berger wrote: Avoid the enforcement of direction if - icmp rules specify the type/code information - the 'skipMatch' variable is set to 'true' Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c

[libvirt] ruby-libvirt and rubygems.org

2010-10-19 Thread Peter Fern
Hi all, Looking at the ruby-libvirt repository, I can see a 0.2.0 version was tagged in June of this year, however the latest version available on rubygems.org is still 0.1.0 from 2008. Would it be possible for the current maint (Chris?) to take ownership of the gem on rubygems, and push the

Re: [libvirt] [PATCH] memtune: Add min_guarantee to the virsh tool

2010-10-19 Thread Nikunj A. Dadhania
On Tue, 19 Oct 2010 15:00:21 +0200, Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com: Hi, I am adding the min_guarantee to the memtune command with this patch. I have tested this at the virsh tool level. This parameter is not

Re: [libvirt] [PATCH] memtune: Add min_guarantee to the virsh tool

2010-10-19 Thread Nikunj A. Dadhania
On Tue, 19 Oct 2010 15:49:05 +0200, Daniel Veillard veill...@redhat.com wrote: On Tue, Oct 19, 2010 at 03:00:21PM +0200, Matthias Bolte wrote: 2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com: [...] tools/virsh.c: Add new memory tunable min_guarantee, currently the user would be