On 11/04/2010 06:57 AM, Stefan Berger wrote:
V2:
- forgot to convert two more function that were hidden in #defines
- small nits
In a first step I am converting the netlink message construction in
macvtap code to use libnl. It's pretty much a 1:1 conversion except
that now the message
On 11/11/2010 03:56 PM, Stefan Berger wrote:
On 11/11/2010 03:41 PM, Laine Stump wrote:
All the other RNG files in libvirt are enclosed withingrammer. This
commit makes the syntactical changes necessary to make network.rng fit
that pattern. (This is the first step in adding some data type
On 11/11/2010 03:53 PM, Stefan Berger wrote:
On 11/11/2010 03:41 PM, Laine Stump wrote:
This commit is whitespace changes only, do avoid obscuring actual code
changes.
I trust you on this. ACK.
Thanks for the vote of confidence :-)
Pushed.
--
libvir-list mailing list
On 11/11/2010 05:07 PM, Eric Blake wrote:
On 11/11/2010 02:57 PM, Laine Stump wrote:
name=pattern(((25[0-5])|(1[0-9]{2})|(2[0-4][0-9])|([0-9]{1,2}))\.){3}((25[0-5])|(1[0-9]{2})|(2[0-4][0-9])|([0-9]{1,2}))/param
This allows 01.1.1.1 (leading zero looks unusual in an IPv4 address). I
would
On 12/11/2010, at 9:38 AM, Osier Yang wrote:
looks pretty good, though missed net-info, it still need to be ACKed.. :-)
Yeah, trying out the net-info patch is on my list of things to try today (time
dependant). :)
The code looked pretty straight forward from a visual inspection, so I'm not
- Justin Clift jcl...@redhat.com wrote:
On 12/11/2010, at 9:38 AM, Osier Yang wrote:
looks pretty good, though missed net-info, it still need to be
ACKed.. :-)
Yeah, trying out the net-info patch is on my list of things to try
today (time dependant). :)
great
just note: I didn't
Hi,
I'm a libvirt user, I encountered a problem when I use the libvirt java
bindings, could you please help me take a look？ Thanks in advance! Any
suggestions from anyone of you will be very appreciated.
Here is my scenario:
Remote access machine A is a RHEL 5.4 workstation with the command
On 11/08/2010 07:40 PM, Osier Yang wrote:
snip
+{desc, Returns basic information about the network},
Probably better to make it clear that it's about a virtual
network, rather than any other kind of network.
Maybe Returns basic information about a virtual network?
(or something similar)
On 11/12/2010 02:57 AM, Laine Stump wrote:
On 11/04/2010 06:57 AM, Stefan Berger wrote:
V2:
- forgot to convert two more function that were hidden in #defines
- small nits
In a first step I am converting the netlink message construction in
macvtap code to use libnl. It's pretty much a
-V2:
- adapting patch due to changes in the same file by another patch
In a second step I am converting the netlink send/receive functions to
use libnl.
I tested this with 802.1Qbg profiles and my test server and did not see
a regression.
Caveat: The online documentation of libnl talks about
V2:
- rebasing the patch following changes to the same file by another
patch
In a second step I am converting the netlink send/receive functions to
use libnl.
I tested this with 802.1Qbg profiles and my test server and did not see
a regression.
Caveat: The online documentation of libnl talks
2010/11/11 Eric Blake ebl...@redhat.com:
On 11/11/2010 11:55 AM, Matthias Bolte wrote:
---
src/qemu/qemu_conf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 9974cf4..92797f1 100644
--- a/src/qemu/qemu_conf.c
+++
This makes the storage driver fail when the connection is
opened with the VIR_CONNECT_RO flag, resulting in a read-only
connection with no storage driver.
---
src/phyp/phyp_driver.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/phyp/phyp_driver.c
2010/11/12 Feng Dan Liu liufe...@cn.ibm.com:
Hi,
I'm a libvirt user, I encountered a problem when I use the libvirt java
bindings, could you please help me take a look? Thanks in advance! Any
suggestions from anyone of you will be very appreciated.
I finished the code using libvirt java
On Fri, Nov 12, 2010 at 02:03:34PM +0100, Matthias Bolte wrote:
This makes the storage driver fail when the connection is
opened with the VIR_CONNECT_RO flag, resulting in a read-only
connection with no storage driver.
---
src/phyp/phyp_driver.c |4 +---
1 files changed, 1
2010/11/12 Daniel P. Berrange berra...@redhat.com:
On Fri, Nov 12, 2010 at 02:03:34PM +0100, Matthias Bolte wrote:
This makes the storage driver fail when the connection is
opened with the VIR_CONNECT_RO flag, resulting in a read-only
connection with no storage driver.
---
On Fri, Nov 12, 2010 at 02:29:09PM +0100, Laurent Léonard wrote:
Le dimanche 31 octobre 2010 00:40:36, jcl...@redhat.com a écrit :
Can we put out a 0.8.5.1 release quickly, one with this patch applied?
On 31/10/2010, at 9:36 AM, Diego Elio Pettenò flamee...@gmail.com wrote:
Il giorno
On 13/11/2010, at 12:29 AM, Laurent Léonard wrote:
Any idea when a 0.8.5.1 (without broken Xen support) will be released ?
It'll be 0.8.6 in about 2-3 weeks (end of the month). :)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2010/11/10 Daniel P. Berrange berra...@redhat.com:
On Tue, Nov 09, 2010 at 01:41:43PM -0500, John Morrissey wrote:
On Wed, Oct 20, 2010 at 10:34:00AM +0200, Daniel Veillard wrote:
Looks just fine, applied and pushed !
Was just working on some changes for qemu; looking at this fresh made me
On Tuesday 27 July 2010 20:42:01 Matthias Bolte wrote:
We'll need to move the VMX handling code from src/esx to src/util,
because drivers are not allowed to depend on each other.
That should be possible, but will require some refactoring, because
this code is currently closely entangled with
On 11/12/2010 06:03 AM, Matthias Bolte wrote:
This makes the storage driver fail when the connection is
opened with the VIR_CONNECT_RO flag, resulting in a read-only
connection with no storage driver.
---
src/phyp/phyp_driver.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
On Monday 23 August 2010 17:27:46 Jean-Baptiste Rouault wrote:
On Monday 23 August 2010 14:51:51 you wrote:
On Thu, Aug 19, 2010 at 05:12:36PM +0200, Jean-Baptiste Rouault wrote:
Hello all,
I'd like to add support for save and restore to the OpenVZ and
VirtualBox drivers because I
On Fri, Nov 12, 2010 at 08:24:53AM -0700, Eric Blake wrote:
On 11/12/2010 06:03 AM, Matthias Bolte wrote:
This makes the storage driver fail when the connection is
opened with the VIR_CONNECT_RO flag, resulting in a read-only
connection with no storage driver.
---
This patch series started out as an attempt to fix the seriously
painful problem with iSCSI targets automatically logging in
whenever the network came online. In the process of fixing this
alot of other cruft is cleaned up
docs/schemas/storagepool.rng |5
src/conf/storage_conf.c
The XML docs describe a 'port' attribute for the
storage source host element, but the parser never
handled it.
* docs/schemas/storagepool.rng: Define port attribute
* src/conf/storage_conf.c: Add missing parsing/formatting
of host port number
* src/conf/storage_conf.h: Remove bogus/unused
The Linux iSCSI initiator toolchain has the dubious feature that
if you ever run the 'sendtargets' command to merely query what
targets are available from a server, the results will be recorded
in /var/lib/iscsi. Any time the '/etc/init.d/iscsi' script runs
in the future, it will then
The code generating XML for storage pool source discovery is
hardcoded to only allow a hostname and optional port number.
Refactor this code to make it easier to add support for extra
parameters.
* tools/virsh.c: Refactor XML generator
---
tools/virsh.c | 26 ++
1 files
Allow an iSCSI initiator IQN to be set with the XML for the
find-storage-pool-sources-as virsh command
* tools/virsh.c: Add iSCSI IQN support
---
tools/virsh.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 6fc1b47..69a42e8
The following series of patches are adding significant
extra functionality to the iSCSI driver. THe current
internal helper methods are not sufficiently flexible
to cope with these changes. This patch refactors the
code to avoid needing to have a virStoragePoolObjPtr
instance as a parameter,
Since the previous patch added support for parsing the output of
the 'sendtargets' command, it is now trivial to support the
storage pool discovery API.
Given a hostname and optional portnumber and initiator IQN,
the code can return a full list of storage pool source docs,
each one representing a
When libvirt starts up all storage pools default to the inactive
state, even if the underlying storage is already active on the
host. This introduces a new API into the internal storage backend
drivers that checks whether a storage pool is already active. If
the pool is active at libvirtd startup,
The SCSI volumes currently get a name like '17:0:0:1' based
on $host:$bus:$target:$lun. The names are intended to be unique
per pool and stable across pool restarts. The inclusion of the
$host component breaks this, because the $host number for iSCSI
pools is dynamically allocated by the kernel at
virsh was not checking for a error code when listing storage
volumes. So when listing volumes in a pool that was shutoff,
no output was displayed
* tools/virsh.c: Fix error handling when listing volumes
---
tools/virsh.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git
Many operations are not valid on inactive storage pools. The
storage driver is currently returning VIR_ERR_INTERNAL_ERROR
in these cases, rather than the more suitable error code
VIR_ERR_OPERATION_INVALID
* src/storage/storage_driver.c: Fix error code when pool
is not active
---
The find-storage-pool-sources-as command takes two arguments,
a hostname and a port number. For some reason the code would
also then look for a port number appended to the hostname
string by searching for ':'. This totally breaks if the user
gives an IPv6 address, and is redundant, since you can
Similarly to deprecating close(), I am now deprecating fclose() and
introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE().
Most of the files are opened in read-only mode, so usage of
VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write
mode already had the fclose() 0 check and I
Similarly to deprecating close(), I am now deprecating fclose() and
introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE().
Most of the files are opened in read-only mode, so usage of
VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write
mode already had the fclose() 0 check and I
On 11/12/2010 09:38 AM, Stefan Berger wrote:
Similarly to deprecating close(), I am now deprecating fclose() and
introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE().
Most of the files are opened in read-only mode, so usage of
VIR_FORCE_CLOSE() seemed appropriate. Others that are opened in write
Using temporary location links for the moment, until we get a
proper place to store the files on the libvirt.org server.
---
docs/sitemap.html.in |4 ++
docs/virshcmdref.html.in | 92 ++
2 files changed, 96 insertions(+), 0 deletions(-)
On 11/12/2010 09:58 AM, Justin Clift wrote:
Using temporary location links for the moment, until we get a
proper place to store the files on the libvirt.org server.
---
docs/sitemap.html.in |4 ++
docs/virshcmdref.html.in | 92
++
2
On 13/11/2010, at 4:06 AM, Eric Blake wrote:
On 11/12/2010 09:58 AM, Justin Clift wrote:
Using temporary location links for the moment, until we get a
proper place to store the files on the libvirt.org server.
---
docs/sitemap.html.in |4 ++
docs/virshcmdref.html.in | 92
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
The XML docs describe a 'port' attribute for the
storage source host element, but the parser never
handled it.
* docs/schemas/storagepool.rng: Define port attribute
* src/conf/storage_conf.c: Add missing parsing/formatting
of host port
---
docs/virshcmdref.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/virshcmdref.html.in b/docs/virshcmdref.html.in
index f965ba0..a5a7554 100644
--- a/docs/virshcmdref.html.in
+++ b/docs/virshcmdref.html.in
@@ -43,7 +43,7 @@
h2a
On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote:
The SCSI volumes currently get a name like '17:0:0:1' based
on $host:$bus:$target:$lun. The names are intended to be unique
per pool and stable across pool restarts. The inclusion of the
$host component breaks this, because
On 11/12/2010 10:15 AM, Matthias Bolte wrote:
HACKING | 602
+-
A lot of this diff is whitespace; the rest looks like it is pulling in
missed bits. Overall, it looks pretty decent; and it's certainly more
maintainable!
Patch 1
On Fri, Nov 12, 2010 at 04:22:35PM +, Daniel P. Berrange wrote:
The following series of patches are adding significant
extra functionality to the iSCSI driver. THe current
internal helper methods are not sufficiently flexible
to cope with these changes. This patch refactors the
code to
On 11/12/2010 11:58 AM, Eric Blake wrote:
On 11/12/2010 09:38 AM, Stefan Berger wrote:
Similarly to deprecating close(), I am now deprecating fclose() and
introduce VIR_FORCE_FCLOSE() and VIR_FCLOSE().
Most of the files are opened in read-only mode, so usage of
VIR_FORCE_CLOSE() seemed
On 11/12/2010 10:47 AM, Stefan Berger wrote:
-if (list)
-fclose(list);
-else
-VIR_FORCE_CLOSE(fd);
+VIR_FORCE_FCLOSE(list);
+VIR_FORCE_CLOSE(fd);
You just introduced a double close. list was created via fdopen(fd),
:-( In that case, what about wrapping
On 11/12/2010 05:22 PM, Daniel P. Berrange wrote:
src/storage/storage_backend_mpath.c | 20 +++
src/storage/storage_backend_scsi.c| 25
Not related to your patch, but these two drivers are undocumented.
Paolo
--
libvir-list mailing list
On 13/11/2010, at 4:37 AM, Justin Clift wrote:
---
docs/virshcmdref.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/virshcmdref.html.in b/docs/virshcmdref.html.in
index f965ba0..a5a7554 100644
--- a/docs/virshcmdref.html.in
+++
On 11/12/2010 10:15 AM, Matthias Bolte wrote:
2010/11/11 Eric Blake ebl...@redhat.com:
On 11/11/2010 01:39 PM, Matthias Bolte wrote:
Tweak pre tags in docs/hacking.html.in to achieve proper
indentation of their plaintext representation.
Also use more b/i/code tags in docs/hacking.html.in.
---
docs/csharp.html.in | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/docs/csharp.html.in b/docs/csharp.html.in
index dc67d7c..45ff35a 100644
--- a/docs/csharp.html.in
+++ b/docs/csharp.html.in
@@ -174,7 +174,7 @@ git clone
On Sat, Nov 13, 2010 at 03:58:39AM +1100, Justin Clift wrote:
Using temporary location links for the moment, until we get a
proper place to store the files on the libvirt.org server.
---
docs/sitemap.html.in |4 ++
docs/virshcmdref.html.in | 92
On 13/11/2010, at 5:15 AM, Justin Clift wrote:
---
docs/csharp.html.in | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/docs/csharp.html.in b/docs/csharp.html.in
index dc67d7c..45ff35a 100644
--- a/docs/csharp.html.in
+++ b/docs/csharp.html.in
Pushing
On 13/11/2010, at 5:20 AM, Daniel P. Berrange wrote:
On Sat, Nov 13, 2010 at 03:58:39AM +1100, Justin Clift wrote:
Using temporary location links for the moment, until we get a
proper place to store the files on the libvirt.org server.
---
docs/sitemap.html.in |4 ++
Currently libvirt doesn't confirm whether the guest has responded to the
disk removal request. In some cases this can leave the guest with
continued access to the device while the mgmt layer believes that it has
been removed. With a recent qemu monitor command[1] we can
deterministically revoke
On 31/10/2010, at 1:39 AM, arnaud.champ...@devatom.fr wrote:
Hi Justin,
I have sended a patch today. Here is the coverage which come with.
Thanks Arnaud, just pushed the update to the website.
Should be viewable online pretty soon. :)
Regards and best wishes,
Justin Clift
--
libvir-list
On 11/12/2010 05:22 PM, Daniel P. Berrange wrote:
+{
+const char *cmdargv[] = {
+/lib/udev/scsi_id,
+--replace-whitespace,
+--whitelisted,
+--device, dev,
+NULL
+};
Does this needs to be /lib/udev/scsi_id -gud dev for RHEL5
compatibility?
On Fri, Nov 12, 2010 at 10:21:16AM -0700, Eric Blake wrote:
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
The XML docs describe a 'port' attribute for the
storage source host element, but the parser never
handled it.
* docs/schemas/storagepool.rng: Define port attribute
*
On Fri, Nov 12, 2010 at 12:39:57PM -0500, Dave Allan wrote:
On Fri, Nov 12, 2010 at 04:22:35PM +, Daniel P. Berrange wrote:
The following series of patches are adding significant
extra functionality to the iSCSI driver. THe current
internal helper methods are not sufficiently flexible
On Fri, Nov 12, 2010 at 12:37:41PM -0500, Dave Allan wrote:
On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote:
The SCSI volumes currently get a name like '17:0:0:1' based
on $host:$bus:$target:$lun. The names are intended to be unique
per pool and stable across pool
On Fri, Nov 12, 2010 at 07:32:05PM +0100, Paolo Bonzini wrote:
On 11/12/2010 05:22 PM, Daniel P. Berrange wrote:
+{
+const char *cmdargv[] = {
+/lib/udev/scsi_id,
+--replace-whitespace,
+--whitelisted,
+--device, dev,
+NULL
+};
Does this
2010/11/12 Eric Blake ebl...@redhat.com:
On 11/12/2010 10:15 AM, Matthias Bolte wrote:
2010/11/11 Eric Blake ebl...@redhat.com:
On 11/11/2010 01:39 PM, Matthias Bolte wrote:
Tweak pre tags in docs/hacking.html.in to achieve proper
indentation of their plaintext representation.
Also use more
tools/console.c depends on daemon/event.h.
---
tools/Makefile.am |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index b686045..921d621 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -54,6 +54,7 @@ virsh_CFLAGS =
On Fri, Nov 12, 2010 at 06:37:36PM +, Daniel P. Berrange wrote:
On Fri, Nov 12, 2010 at 12:39:57PM -0500, Dave Allan wrote:
On Fri, Nov 12, 2010 at 04:22:35PM +, Daniel P. Berrange wrote:
The following series of patches are adding significant
extra functionality to the iSCSI
On Fri, Nov 12, 2010 at 12:37:41PM -0500, Dave Allan wrote:
On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote:
The SCSI volumes also get a 'key' field based on the fully
qualified volume path. All SCSI volumes have a unique serial
available in hardware which can be
On 11/12/2010 07:45 PM, Daniel P. Berrange wrote:
On Fri, Nov 12, 2010 at 07:32:05PM +0100, Paolo Bonzini wrote:
On 11/12/2010 05:22 PM, Daniel P. Berrange wrote:
+{
+const char *cmdargv[] = {
+/lib/udev/scsi_id,
+--replace-whitespace,
+--whitelisted,
+
On Fri, Nov 12, 2010 at 08:06:32PM +0100, Paolo Bonzini wrote:
On 11/12/2010 07:45 PM, Daniel P. Berrange wrote:
On Fri, Nov 12, 2010 at 07:32:05PM +0100, Paolo Bonzini wrote:
On 11/12/2010 05:22 PM, Daniel P. Berrange wrote:
+{
+const char *cmdargv[] = {
+/lib/udev/scsi_id,
+
On Sat, Nov 13, 2010 at 05:22:56AM +1100, Justin Clift wrote:
On 13/11/2010, at 5:20 AM, Daniel P. Berrange wrote:
On Sat, Nov 13, 2010 at 03:58:39AM +1100, Justin Clift wrote:
Using temporary location links for the moment, until we get a
proper place to store the files on the libvirt.org
On Fri, Nov 12, 2010 at 06:43:39PM +, Daniel P. Berrange wrote:
On Fri, Nov 12, 2010 at 12:37:41PM -0500, Dave Allan wrote:
On Fri, Nov 12, 2010 at 04:22:43PM +, Daniel P. Berrange wrote:
The SCSI volumes currently get a name like '17:0:0:1' based
on $host:$bus:$target:$lun. The
On 11/12/2010 11:54 AM, Matthias Bolte wrote:
tools/console.c depends on daemon/event.h.
---
tools/Makefile.am |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index b686045..921d621 100644
--- a/tools/Makefile.am
+++
On 11/12/2010 10:59 AM, Eric Blake wrote:
+syntax-check: $(top_srcdir)/HACKING
Move this line into cfg.mk. Since 'make syntax-check' can only
activated if you use GNU make (because it is only specified in
maint.mk), we should hide any dependencies added to it inside our
customization of
boostrap.conf lists gzip as build dependency. bootstrap then tries to
get it's version number using a get_version() function that executes
'gzio --version' and tries to parse the result.
The sed expression expects the version number to contain a dot as gzip
outputs it on Linux:
$ gzip --version
This also fixes configure problems on FreeBSD, as test doesn't
understand '==' there.
---
configure.ac |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index f691c27..66237e1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -269,9 +269,9 @@
[adding bug-gnulib]
On 11/12/2010 01:24 PM, Matthias Bolte wrote:
boostrap.conf lists gzip as build dependency. bootstrap then tries to
get it's version number using a get_version() function that executes
'gzio --version' and tries to parse the result.
The sed expression expects the version
On 11/12/2010 01:50 PM, Matthias Bolte wrote:
This also fixes configure problems on FreeBSD, as test doesn't
understand '==' there.
---
configure.ac |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
I'm surprised 'make syntax-check' isn't catching these. Maybe I can
whip that
Eric Blake pointed out a deficiency in this regex when it was
copy-pasted into network.rng. This is just propogating the fix back to
its origin.
---
docs/schemas/interface.rng |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/schemas/interface.rng
On 11/12/2010 01:59 PM, Eric Blake wrote:
On 11/12/2010 01:50 PM, Matthias Bolte wrote:
This also fixes configure problems on FreeBSD, as test doesn't
understand '==' there.
---
configure.ac |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
I'm surprised 'make syntax-check'
On 11/12/2010 02:14 PM, Laine Stump wrote:
Eric Blake pointed out a deficiency in this regex when it was
copy-pasted into network.rng. This is just propogating the fix back to
its origin.
---
docs/schemas/interface.rng |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
2010/11/12 Eric Blake ebl...@redhat.com:
On 11/12/2010 11:54 AM, Matthias Bolte wrote:
tools/console.c depends on daemon/event.h.
---
tools/Makefile.am | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index b686045..921d621
On 11/12/2010 02:35 PM, Paul Eggert wrote:
On 11/12/2010 12:50 PM, Eric Blake wrote:
+ s/^\([0-9]\{1,\}\(\.[.a-z0-9-]*\)\)*.*/\1/
Surely that is a typo. The *\)\)* should be a *\)*\).
Aargh - I tested on one machine, but committed on another. Typo is now
fixed.
--
Eric Blake
2010/11/12 Eric Blake ebl...@redhat.com:
On 11/12/2010 01:50 PM, Matthias Bolte wrote:
This also fixes configure problems on FreeBSD, as test doesn't
understand '==' there.
---
configure.ac | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
I'm surprised 'make syntax-check'
于 2010年11月12日 19:34, Justin Clift 写道:
On 11/08/2010 07:40 PM, Osier Yang wrote:
snip
+{desc, Returns basic information about the network},
Probably better to make it clear that it's about a virtual
network, rather than any other kind of network.
Maybe Returns basic information about a
* src/qemu/qemu_monitor_text.c (qemuMonitorTextChangeMedia)
---
src/qemu/qemu_monitor_text.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
index 2552111..64ec57b 100644
--- a/src/qemu/qemu_monitor_text.c
+++
84 matches
Mail list logo
