Re: [libvirt] [PATCH v2] virsh: Print error if specified bandwidth is invalid for blockjob

2011-08-23 Thread Osier Yang
于 2011年08月22日 21:52, Eric Blake 写道: It's strange that the command fails but without any error if one specifies as not a number. Pushed. Osier -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Substitute VIR_ERR_NO_SUPPORT with VIR_ERR_OPERATION_INVALID

2011-08-23 Thread Osier Yang
于 2011年08月22日 21:54, Eric Blake 写道: On 08/22/2011 08:12 AM, Osier Yang wrote: * src/qemu/qemu_monitor_text.c: Error like this function is not supported by the connection driver is confused obviously. --- src/qemu/qemu_monitor_text.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

[libvirt] problem of escaped scancodes

2011-08-23 Thread Lai Jiangshan
Hi, Daniel P. Berrange, Our user found that some keycode can not be handled well when they try to map other keycode to xt_kbd keycode, when xt_kbd keycode is an escaped scancode. The xt_kbd keycode http://git.gnome.org/browse/gtk-vnc/plain/src/keymaps.csv are come from x86_keycodes[] of

[libvirt] [PATCH 0/8] Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
Error code VIR_ERR_NO_SUPPORT will be translated to this function is not supported by the connection driver, however, it's used across the whole projects, this patch is trying to cleanup all the improper use in the source tree. The modification can be grouped to 3 following groups: 1) The error

[libvirt] [PATCH 6/8] storage: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
--- src/storage/storage_backend.c | 12 ++-- src/storage/storage_backend_disk.c|2 +- src/storage/storage_backend_fs.c |2 +- src/storage/storage_backend_logical.c |2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git

[libvirt] [PATCH 5/8] remote: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
--- src/remote/remote_driver.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index e5bfa4b..28f333b 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -2928,7 +2928,7 @@ static int

[libvirt] [PATCH 3/8] nodeinfo: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
--- src/nodeinfo.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index cae2564..b21e555 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -629,7 +629,7 @@ int nodeGetInfo(virConnectPtr conn ATTRIBUTE_UNUSED,

[libvirt] [PATCH 7/8] test: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
--- src/test/test_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index b3e24b4..3dfe305 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4082,7 +4082,7 @@

[libvirt] [PATCH 4/8] qemu: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
* src/qemu/qemu_command.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_CONFIG_UNSUPPORTED/ * src/qemu/qemu_driver.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID/ * src/qemu/qemu_process.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID/ --- src/qemu/qemu_command.c |4 ++-- src/qemu/qemu_driver.c |

[libvirt] [PATCH 2/8] lxc: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID/ Special case is changes on lxcDomainInterfaceStats, if it's not implemented on the platform, prints error like: lxcError(VIR_ERR_OPERATION_INVALID, %s, _(interface stats not implemented on this platform)); As the function is

[libvirt] [PATCH 1/8] conf: Cleanup improper use of VIR_ERR_NO_SUPPORT in node_device_conf

2011-08-23 Thread Osier Yang
--- src/conf/node_device_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 548bbff..4803e2a 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1277,7 +1277,7 @@

[libvirt] [PATCH 8/8] xen: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
--- src/xen/xen_hypervisor.c |4 ++-- src/xen/xend_internal.c | 26 +- src/xen/xm_internal.c|3 ++- src/xenxs/xen_sxpr.c |4 ++-- 4 files changed, 19 insertions(+), 18 deletions(-) diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Stefan Hajnoczi
On Wed, Aug 10, 2011 at 11:08 PM, Eric Blake ebl...@redhat.com wrote: disk snapshot: the state of a virtual disk used at a given time; once a snapshot exists, then it is possible to track a delta of changes that have happened since that time. Did you go into details of the delta API anywhere?

[libvirt] [test-API][PATCH] Fix the missing ret variable problem

2011-08-23 Thread Wayne Sun
--- repos/remoteAccess/tls_setup.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/repos/remoteAccess/tls_setup.py b/repos/remoteAccess/tls_setup.py index 80d6b42..4e7f24e 100644 --- a/repos/remoteAccess/tls_setup.py +++ b/repos/remoteAccess/tls_setup.py @@ -343,6

Re: [libvirt] RFC: managing pci passthrough usage of sriov VFs via a new network forward type

2011-08-23 Thread Gerhard Stenzel
On Mon, 2011-08-22 at 05:17 -0400, Laine Stump wrote: For some reason beyond my comprehension, the designers of SRIOV ethernet cards decided that the virtual functions (VF) of the card (each VF corresponds to an ethernet device, e.g. eth10) should each be given a new+different+random MAC

Re: [libvirt] RFC: managing pci passthrough usage of sriov VFs via a new network forward type

2011-08-23 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 05:17:25AM -0400, Laine Stump wrote: For some reason beyond my comprehension, the designers of SRIOV ethernet cards decided that the virtual functions (VF) of the card (each VF corresponds to an ethernet device, e.g. eth10) should each be given a new+different+random

[libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-23 Thread Daniel P. Berrange
I was at the KVM Forum / LinuxCon last week and there were many interesting things discussed which are relevant to ongoing libvirt development. Here was the list that caught my attention. If I have missed any, fill in the gaps - Sandbox/container KVM. The Solaris port of KVM puts QEMU

Re: [libvirt] RFC: managing pci passthrough usage of sriov VFs via a new network forward type

2011-08-23 Thread D. Herrendoerfer
On Aug 23, 2011, at 12:50 PM, Daniel P. Berrange wrote: [...snip...] This makes using SRIOV VFs via PCI passthrough very unpalatable. The problem can be solved by setting the MAC address of the ethernet device prior to assigning it to the guest, but of course the hostdev element used to

Re: [libvirt] Draft document about source control for type of pools

2011-08-23 Thread Daniel P. Berrange
On Wed, Aug 17, 2011 at 12:53:00PM +0800, Lei Li wrote: Hi Daniel, The last version of my patch fixed bug #611823 prohibit pools with duplicate storage, you gave some comments that should do check by source info instead of target path I used. These days I view the code and existing

Re: [libvirt] RFC: managing pci passthrough usage of sriov VFs via a new network forward type

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 01:53:42PM +0200, D. Herrendoerfer wrote: On Aug 23, 2011, at 12:50 PM, Daniel P. Berrange wrote: [...snip...] This makes using SRIOV VFs via PCI passthrough very unpalatable. The problem can be solved by setting the MAC address of the ethernet device prior to

Re: [libvirt] [PATCH 2/3] qemu: Introduce job queue size limit

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 16, 2011 at 06:39:11PM +0200, Michal Privoznik wrote: This patch creates an optional BeginJob queue size limit. When active, all other attempts above level will fail. To set this feature assign desired value to max_queued variable in qemu.conf. Setting it to 0 turns it off. ---

Re: [libvirt] [PATCH 1/3] daemon: Create priority workers pool

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 16, 2011 at 06:39:10PM +0200, Michal Privoznik wrote: This patch annotates APIs with low or high priority. In low set MUST be all APIs which might eventually access monitor (and thus block indefinitely). Other APIs may be marked as high priority. However, some must be (e.g.

Re: [libvirt] ignore vs. error when inappropriate or unrecognized attributes/elements are present in XML

2011-08-23 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 01:52:07PM -0400, Laine Stump wrote: On 08/22/2011 09:10 AM, Eric Blake wrote: On 08/22/2011 01:36 AM, Laine Stump wrote: The problem I was *really* trying to point out is that of a keymap attribute being given *at all* when type is something other than spice or vnc.

Re: [libvirt] [PATCH] qemu: Allow graceful domain destroy

2011-08-23 Thread Michal Privoznik
On 22.08.2011 20:31, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 05:33:12PM +0100, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 09:29:56AM -0600, Eric Blake wrote: On 08/22/2011 09:21 AM, Daniel P. Berrange wrote: If we had a separate API for sending 'quit' on the monitor, then the

[libvirt] Libvirt 0.9.4rc2 + qemu 0.15 VNC/TLS not working

2011-08-23 Thread Radek Hladik
Hi all, I am trying new versions of software for my libvirt/qemu farm. I upgraded libvirt to 0.9.3 and I had problems with loading certificates for libvirt itself (probably GNUTLS related). Upgrade to 0.9.4rc2 solved the problem. Now I am trying to upgrade qemu (from 0.12.5) to 0.15. I

Re: [libvirt] [PATCH 3/3] qemu: Deal with stucked qemu on daemon startup

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 16, 2011 at 06:39:12PM +0200, Michal Privoznik wrote: If libvirt daemon gets restarted and there is (at least) one unresponsive qemu, the startup procedure hangs up. This patch creates one thread per vm in which we try to reconnect to monitor. Therefore, blocking in one thread will

Re: [libvirt] [PATCH] qemu: Allow graceful domain destroy

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 02:36:02PM +0200, Michal Privoznik wrote: On 22.08.2011 20:31, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 05:33:12PM +0100, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 09:29:56AM -0600, Eric Blake wrote: On 08/22/2011 09:21 AM, Daniel P. Berrange wrote:

Re: [libvirt] [PATCH] virsh: Do not try to free domain if it is NULL

2011-08-23 Thread Eric Blake
On 08/22/2011 09:54 PM, Osier Yang wrote: Without these patch, there will be error like below if domain is NULL. error: invalid domain pointer in virDomainFree Which is useless. --- tools/virsh.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) -out: -

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Eric Blake
On 08/23/2011 03:52 AM, Stefan Hajnoczi wrote: On Wed, Aug 10, 2011 at 11:08 PM, Eric Blakeebl...@redhat.com wrote: disk snapshot: the state of a virtual disk used at a given time; once a snapshot exists, then it is possible to track a delta of changes that have happened since that time. Did

Re: [libvirt] [PATCH] virsh: Do not try to free domain if it is NULL

2011-08-23 Thread Osier Yang
于 2011年08月23日 21:34, Eric Blake 写道: Without these patch, there will be error like below if domain is NULL. error: invalid domain pointer in virDomainFree Which is useless. Pushed with the style changed. Osier -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 0/8] Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
于 2011年08月23日 17:39, Osier Yang 写道: Error code VIR_ERR_NO_SUPPORT will be translated to this function is not supported by the connection driver, however, it's used across the whole projects, this patch is trying to cleanup all the improper use in the source tree. The modification can be grouped

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Eric Blake
On 08/23/2011 04:28 AM, Stefan Hajnoczi wrote: I forgot to ask the obvious question: I am writing a backup program that is using the new snapshot APIs. A snapshot has been created, how do I read out the data from the snapshot? Here's how to access the data in the snapshot, at least for the

Re: [libvirt] [PATCH 0/8] Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Eric Blake
On 08/23/2011 07:45 AM, Osier Yang wrote: 于 2011年08月23日 17:39, Osier Yang 写道: Error code VIR_ERR_NO_SUPPORT will be translated to this function is not supported by the connection driver, however, it's used across the whole projects, this patch is trying to cleanup all the improper use in the

Re: [libvirt] [PATCH 0/8] Cleanup improper VIR_ERR_NO_SUPPORT use

2011-08-23 Thread Osier Yang
于 2011年08月23日 21:52, Eric Blake 写道: On 08/23/2011 07:45 AM, Osier Yang wrote: 于 2011年08月23日 17:39, Osier Yang 写道: Error code VIR_ERR_NO_SUPPORT will be translated to this function is not supported by the connection driver, however, it's used across the whole projects, this patch is trying to

Re: [libvirt] problem of escaped scancodes

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 03:32:51PM +0800, Lai Jiangshan wrote: Hi, Daniel P. Berrange, Our user found that some keycode can not be handled well when they try to map other keycode to xt_kbd keycode, when xt_kbd keycode is an escaped scancode. The xt_kbd keycode

Re: [libvirt] [RFC] NUMA topology specification

2011-08-23 Thread Daniel P. Berrange
On Fri, Aug 19, 2011 at 12:05:43PM +0530, Bharata B Rao wrote: Hi, qemu supports specification of NUMA topology on command line using -numa option. -numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node] I see that there is no way to specify such NUMA topology in libvirt XML. Are there

Re: [libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-23 Thread Eric Blake
On 08/19/2011 03:58 PM, Eric Blake wrote: Adds an optional element todomainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. @@ -11044,6 +0,19 @@ virDomainSnapshotDefParseString(const char *xmlStr,

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/22/2011 03:25 PM, Anthony Liguori wrote: On 08/22/2011 01:22 PM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 12:25:25PM -0500, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 11:29:12AM -0500, Anthony Liguori wrote: I don't think

Re: [libvirt] [PATCH] qemu: Report error if qemu monitor command not found for BlockJob

2011-08-23 Thread Adam Litke
On 08/22/2011 10:04 PM, Osier Yang wrote: Hi, Adam I likes the idea to wrap the checking as a function seperately, but the function won't work well if the command is help info, though we don't have a use of help info yet. My point is since the function is intending to work for all the

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Anthony Liguori
On 08/23/2011 09:26 AM, Corey Bryant wrote: On 08/22/2011 03:25 PM, Anthony Liguori wrote: On 08/22/2011 01:22 PM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 12:25:25PM -0500, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 11:29:12AM

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 2:48 PM, Eric Blake ebl...@redhat.com wrote: On 08/23/2011 04:28 AM, Stefan Hajnoczi wrote: I forgot to ask the obvious question: I am writing a backup program that is using the new snapshot APIs.  A snapshot has been created, how do I read out the data from the

Re: [libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-23 Thread Eric Blake
On 08/19/2011 03:58 PM, Eric Blake wrote: Adds an optional element todomainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. Another couple of problems. +static int +disksorter(const void *a, const void *b)

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 2:40 PM, Eric Blake ebl...@redhat.com wrote: On 08/23/2011 03:52 AM, Stefan Hajnoczi wrote: On Wed, Aug 10, 2011 at 11:08 PM, Eric Blakeebl...@redhat.com  wrote: disk snapshot: the state of a virtual disk used at a given time; once a snapshot exists, then it is

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Eric Blake
On 08/23/2011 09:12 AM, Stefan Hajnoczi wrote: Hmm...so there is no abstraction. I still need to understand what the underlying snapshot implementation does and what its limitations are. We're still trying to get to that point. A while ago, I posted an RFC for adding virStorageVolSnapshot*

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/22/2011 02:39 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: On 08/22/2011 01:25 PM, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 11:29:12AM -0500, Anthony Liguori

Re: [libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 12:15 PM, Daniel P. Berrange berra...@redhat.com wrote: I was at the KVM Forum / LinuxCon last week and there were many interesting things discussed which are relevant to ongoing libvirt development. Here was the list that caught my attention. If I have missed any, fill

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: On 08/22/2011 02:39 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: On 08/22/2011 01:25 PM, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange

Re: [libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 04:24:46PM +0100, Stefan Hajnoczi wrote: On Tue, Aug 23, 2011 at 12:15 PM, Daniel P. Berrange berra...@redhat.com wrote: I was at the KVM Forum / LinuxCon last week and there were many interesting things discussed which are relevant to ongoing libvirt development.

Re: [libvirt] [RFC 01/12] Add various USB devices QEMU_CAPS

2011-08-23 Thread Daniel P. Berrange
On Sun, Aug 21, 2011 at 10:01:12PM +0300, Marc-André Lureau wrote: --- src/qemu/qemu_capabilities.c | 31 +++ src/qemu/qemu_capabilities.h | 10 ++ tests/qemuhelptest.c | 13 ++--- 3 files changed, 51 insertions(+), 3 deletions(-)

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 4:18 PM, Eric Blake ebl...@redhat.com wrote: On 08/23/2011 09:12 AM, Stefan Hajnoczi wrote: I think we simply cannot expose all this complexity to users.  Each application would have to support the many different cases.  Libvirt needs to tie this stuff together and

Re: [libvirt] [RFC 05/12] USB devices gain a new USB address child element

2011-08-23 Thread Daniel P. Berrange
On Sun, Aug 21, 2011 at 10:01:16PM +0300, Marc-André Lureau wrote: --- docs/schemas/domain.rng| 14 + src/conf/domain_conf.c | 62 +++- src/conf/domain_conf.h | 10 +++

Re: [libvirt] [RFC 03/12] Add a new controller type 'usb' with optionnal 'model'

2011-08-23 Thread Daniel P. Berrange
On Sun, Aug 21, 2011 at 10:01:14PM +0300, Marc-André Lureau wrote: diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index dbfc7d9..4168504 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -83,6 +83,24 @@ VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST,

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 17:26, schrieb Daniel P. Berrange: On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: On 08/22/2011 02:39 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: On 08/22/2011 01:25 PM, Anthony Liguori wrote: On

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Eric Blake
On 08/23/2011 09:35 AM, Stefan Hajnoczi wrote: On Tue, Aug 23, 2011 at 4:18 PM, Eric Blakeebl...@redhat.com wrote: On 08/23/2011 09:12 AM, Stefan Hajnoczi wrote: I think we simply cannot expose all this complexity to users. Each application would have to support the many different cases.

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: Am 23.08.2011 17:26, schrieb Daniel P. Berrange: On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: On 08/22/2011 02:39 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryantcor...@linux.vnet.ibm.com

Re: [libvirt] [PATCH 1/3] daemon: Create priority workers pool

2011-08-23 Thread Michal Privoznik
On 23.08.2011 14:23, Daniel P. Berrange wrote: On Tue, Aug 16, 2011 at 06:39:10PM +0200, Michal Privoznik wrote: This patch annotates APIs with low or high priority. In low set MUST be all APIs which might eventually access monitor (and thus block indefinitely). Other APIs may be marked as

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 04:51:31PM +0100, Daniel P. Berrange wrote: On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: Am 23.08.2011 17:26, schrieb Daniel P. Berrange: On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: On 08/22/2011 02:39 PM, Blue Swirl wrote:

[libvirt] [PATCH v2 34/26] snapshot: add disks to snapshot xml

2011-08-23 Thread Eric Blake
Adds an optional element to domainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. domainsnapshot ... disks disk name='vda' snapshot='no'/ disk name='vdb' snapshot='internal'/ disk name='vdc'

Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/23/2011 11:50 AM, Kevin Wolf wrote: Am 23.08.2011 17:26, schrieb Daniel P. Berrange: On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: On 08/22/2011 02:39 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: On

Re: [libvirt] [RFC 06/12] Add USB companion controllers support

2011-08-23 Thread Daniel P. Berrange
On Sun, Aug 21, 2011 at 10:01:17PM +0300, Marc-André Lureau wrote: Companion controllers take an extra 'master' attribute to associate them. --- docs/formatdomain.html.in | 20 + docs/schemas/domain.rng| 15 +++

[libvirt] [PATCH] maint: fix comment typos

2011-08-23 Thread Eric Blake
* src/qemu/qemu_driver.c (qemuDomainSaveInternal): Fix typo. * src/conf/domain_event.c (virDomainEventDispatchMatchCallback): Likewise. * daemon/libvirtd.c (daemonRunStateInit): Likewise. * src/lxc/lxc_container.c (lxcContainerChildMountSort): Likewise. * src/util/virterror.c (virCopyError,

[libvirt] [PATCH 41/26] snapshot: wire up live qemu disk snapshots

2011-08-23 Thread Eric Blake
Lots of earlier patches led up to this point - the qemu snapshot_blkdev monitor command can now be controlled by libvirt! Well, insofar as SELinux doesn't prevent qemu from open(O_CREAT) on the files. There's still some followup work before things work with SELinux enforcing, but this patch is

Re: [libvirt] [PATCH 3/3] qemu: Deal with stucked qemu on daemon startup

2011-08-23 Thread Michal Privoznik
On 23.08.2011 14:42, Daniel P. Berrange wrote: On Tue, Aug 16, 2011 at 06:39:12PM +0200, Michal Privoznik wrote: If libvirt daemon gets restarted and there is (at least) one unresponsive qemu, the startup procedure hangs up. This patch creates one thread per vm in which we try to reconnect to

[libvirt] [PATCH 3/3 v2] qemu: Deal with stucked qemu on daemon startup

2011-08-23 Thread Michal Privoznik
If libvirt daemon gets restarted and there is (at least) one unresponsive qemu, the startup procedure hangs up. This patch creates one thread per vm in which we try to reconnect to monitor. Therefore, blocking in one thread will not affect other APIs. --- src/qemu/qemu_driver.c | 23 +

[libvirt] [PATCH 1/3 v2] daemon: Create priority workers pool

2011-08-23 Thread Michal Privoznik
This patch annotates APIs with low or high priority. In low set MUST be all APIs which might eventually access monitor (and thus block indefinitely). Other APIs may be marked as high priority. However, some must be (e.g. domainDestroy). For high priority calls (HPC), there is new thread pool

Re: [libvirt] Libvirt 0.9.4rc2 + qemu 0.15 VNC/TLS not working

2011-08-23 Thread Radek Hladik
Dne 23.8.2011 14:36, Radek Hladik napsal(a): I am thinking whether there is not a problem with monitor setting something after the machine starts. Libvirt does the same with password, so maybe it does something with TLS I tried to remove the VNC password from guest XML and TLS is working. So

Re: [libvirt] Curl/HTTP block device

2011-08-23 Thread Radek Hladik
Dne 16.8.2011 20:13, Daniel P. Berrange napsal(a): On Tue, Aug 16, 2011 at 11:02:23AM -0600, Eric Blake wrote: On 08/12/2011 04:31 AM, Radek Hladik wrote: Hi, I've noticed newer version of curl in last qemu changelog. It seems that its needed for curl block device. Unfortunatelly, I was not

Re: [libvirt] [PATCH 35/26] snapshot: also support disks by path

2011-08-23 Thread Eric Blake
On 08/19/2011 09:08 PM, Eric Blake wrote: I got confused when 'virsh domblkinfo dom disk' required the path to a disk (which can be ambiguous, since a single file can back multiple disks), rather than the unambiguous target device name that I was using in disk snapshots. So, in true developer

[libvirt] [PATCH] lxc: do not require 'ifconfig' or 'ipconfig' in container

2011-08-23 Thread Scott Moser
Currently, the lxc implementation invokes 'ip' and 'ifconfig' commands inside a container using 'virRun'. That has the side effect of requiring those commands to be present and to function in a manner consistent with the usage. Some small roots (such as ttylinux) may not have 'ip' or 'ifconfig'.

Re: [libvirt] [PATCH 38/26] snapshot: make it possible to audit external snapshot

2011-08-23 Thread Eric Blake
On 08/22/2011 01:51 PM, Eric Blake wrote: Snapshots alter the set of disk image files opened by qemu, so they must be audited. But they don't involve a full disk definition structure, just the new filename. Make the next patch easier by refactoring the audit routines to just operate on file

[libvirt] [PATCH] esx: Refactor a repeated string in the generator

2011-08-23 Thread Matthias Bolte
--- src/esx/esx_vi_generator.py | 24 +--- 1 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py index 239ec73..8a128df 100755 --- a/src/esx/esx_vi_generator.py +++ b/src/esx/esx_vi_generator.py @@ -1817,17

Re: [libvirt] [PATCH] esx: Refactor a repeated string in the generator

2011-08-23 Thread Eric Blake
On 08/23/2011 03:18 PM, Matthias Bolte wrote: --- src/esx/esx_vi_generator.py | 24 +--- 1 files changed, 13 insertions(+), 11 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list

Re: [libvirt] [PATCH] esx: Refactor a repeated string in the generator

2011-08-23 Thread Matthias Bolte
2011/8/23 Eric Blake ebl...@redhat.com: On 08/23/2011 03:18 PM, Matthias Bolte wrote: ---  src/esx/esx_vi_generator.py |   24 +---  1 files changed, 13 insertions(+), 11 deletions(-) ACK. Thanks, pushed. -- Matthias Bolte http://photron.blogspot.com -- libvir-list

[libvirt] [PATCH] esx: Use $(PYTHON) instead of the shebang to run the generator

2011-08-23 Thread Matthias Bolte
--- src/Makefile.am |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8fe7120..5ba189c 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -812,8 +812,9 @@ endif BUILT_SOURCES += $(ESX_DRIVER_GENERATED)

Re: [libvirt] [PATCH] esx: Use $(PYTHON) instead of the shebang to run the generator

2011-08-23 Thread Eric Blake
On 08/23/2011 03:42 PM, Matthias Bolte wrote: --- src/Makefile.am |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8fe7120..5ba189c 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -812,8 +812,9 @@ endif BUILT_SOURCES

Re: [libvirt] [PATCH 38/26] snapshot: make it possible to audit external snapshot

2011-08-23 Thread Eric Blake
On 08/23/2011 02:44 PM, Eric Blake wrote: On 08/22/2011 01:51 PM, Eric Blake wrote: Snapshots alter the set of disk image files opened by qemu, so they must be audited. But they don't involve a full disk definition structure, just the new filename. Make the next patch easier by refactoring the

[libvirt] [PATCHv2 41/26] snapshot: wire up live qemu disk snapshots

2011-08-23 Thread Eric Blake
Lots of earlier patches led up to this point - the qemu snapshot_blkdev monitor command can now be controlled by libvirt! Well, insofar as SELinux doesn't prevent qemu from open(O_CREAT) on the files. There's still some followup work before things work with SELinux enforcing, but this patch is

[libvirt] [PATCH 42/26] snapshot: refactor qemu file opening

2011-08-23 Thread Eric Blake
In a SELinux or root-squashing NFS environment, libvirt has to go through some hoops to create a new file that qemu can then open() by name. Snapshots are a case where we want to guarantee an empty file that qemu can open, so refactor some existing code to make it easier to reuse in the next

[libvirt] [PATCH 43/26] snapshot: use SELinux and lock manager with external snapshots

2011-08-23 Thread Eric Blake
With this, it is now possible to create external snapshots even when SELinux is enforcing, and to protect the new file with a lock manager. * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateSingleDiskActive): Create and register new file with proper permissions and locks.

Re: [libvirt] [RFC 09/12] RFC: Don't reserve slot 1 if a USB controller is defined there

2011-08-23 Thread Wen Congyang
At 08/22/2011 03:01 AM, Marc-André Lureau Write: --- src/qemu/qemu_command.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9ea4b7c..d25f34f 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH] reserve slot 1 on pci bus0

2011-08-23 Thread Wen Congyang
After supporting multi function pci device, we only reserve function 1 on slot 1. The user can use the other function on slot 1 in the xml config file. We should detect this wrong usage. --- src/qemu/qemu_command.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff

Re: [libvirt] [RFC 09/12] RFC: Don't reserve slot 1 if a USB controller is defined there

2011-08-23 Thread Wen Congyang
At 08/24/2011 09:42 AM, Wen Congyang Write: At 08/22/2011 03:01 AM, Marc-André Lureau Write: --- src/qemu/qemu_command.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9ea4b7c..d25f34f 100644 ---

[libvirt] XML files

2011-08-23 Thread Derek
Hi Folks, I'm running KVM on Debian squeeze. I have some requirements on a new VM to provide customised BIOS vendor/product strings, from my experience so far this is accomplish with the sysinfo/smbios support. So I have added these to the XML file for my VM. I found 'virsh edit' is the