Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Christophe Fergeau
Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683 --- If this looks correct I'll have a look at libvirt-glib and libvirt-gobject

Re: [libvirt] [PATCH] qemu: Fix deadlock when qemuDomainOpenConsole cleans up a connection

2012-04-11 Thread Peter Krempa
On 04/10/2012 05:43 PM, Eric Blake wrote: On 04/10/2012 07:29 AM, Peter Krempa wrote: The new safe console handling introduced a possibility to deadlock the qemu driver when a new console connection forcibly disconnects a previous console stream that belongs to an already closed connection.

[libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS

2012-04-11 Thread Michal Privoznik
If dynamic_ownership is off and we are creating a file on NFS we force chown. This will fail as chown/chmod are not supported on NFS. However, with no dynamic_ownership we are not required to do any chown. --- src/qemu/qemu_driver.c | 10 -- 1 files changed, 8 insertions(+), 2

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Daniel P. Berrange
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683 --- If

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Christophe Fergeau
On Wed, Apr 11, 2012 at 10:24:42AM +0100, Daniel P. Berrange wrote: On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Guido Günther
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683 --- If

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Daniel P. Berrange
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote: On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered by

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Christophe Fergeau
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote: On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered by

Re: [libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-11 Thread Guido Günther
On Tue, Apr 10, 2012 at 09:36:57PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:29:59PM +0200, Guido Günther wrote: otherwise the build fails with: $ CCLD conn-test ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to

Re: [libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-11 Thread Daniel P. Berrange
On Wed, Apr 11, 2012 at 01:54:27PM +0200, Guido Günther wrote: On Tue, Apr 10, 2012 at 09:36:57PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:29:59PM +0200, Guido Günther wrote: otherwise the build fails with: $ CCLD conn-test

Re: [libvirt] USB redirection support

2012-04-11 Thread Christophe Fergeau
On Fri, Apr 06, 2012 at 02:51:35PM +0200, Christophe Fergeau wrote: Hey, This patch series adds the needed classes for apps to be able to use USB redirection. I've followed http://hansdegoede.livejournal.com/11084.html and added all the API needed to be able to get the same XML. However,

[libvirt] Add USB controller support

2012-04-11 Thread Christophe Fergeau
Hey, Here is the second version of the patch series implementing USB controller support in libvirt-gconfig. There's a bug fixed in GVirConfigDomainAddressUsb creation (type=usb was missing) as well as a few small bug fixes/changes in the test program. I also added an additional patch implementing

[libvirt] [libvirt-gconfig PATCHv2 03/14] Add GVirConfigDomainControllerUsb boilerplate

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-domain-controller-usb.c| 72 .../libvirt-gconfig-domain-controller-usb.h| 66 ++ libvirt-gconfig/libvirt-gconfig.h |3 +-

[libvirt] [libvirt-gconfig PATCHv2 01/14] Add GVirConfigDomainController skeleton

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-domain-controller.c| 50 .../libvirt-gconfig-domain-controller.h| 63 libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-gconfig PATCHv2 04/14] Add gvir_config_domain_controller_usb_set_model

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c | 13 + libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h | 15 +++ libvirt-gconfig/libvirt-gconfig.sym |2 ++ 3 files changed, 30 insertions(+) diff --git

[libvirt] [libvirt-gconfig PATCHv2 05/14] Implement gvir_config_domain_controller_usb_set_master

2012-04-11 Thread Christophe Fergeau
--- .../libvirt-gconfig-domain-controller-usb.c| 21 .../libvirt-gconfig-domain-controller-usb.h|3 +++ libvirt-gconfig/libvirt-gconfig.sym|1 + 3 files changed, 25 insertions(+) diff --git

[libvirt] [libvirt-gconfig PATCHv2 02/14] Implement gvir_config_domain_controller_[gs]et_index

2012-04-11 Thread Christophe Fergeau
--- .../libvirt-gconfig-domain-controller.c| 29 .../libvirt-gconfig-domain-controller.h|4 +++ libvirt-gconfig/libvirt-gconfig.sym|2 ++ 3 files changed, 35 insertions(+) diff --git

[libvirt] [libvirt-gconfig PATCHv2 12/14] Implement gvir_config_domain_redirdev_set_address

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-redirdev.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-redirdev.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym |1 + 3 files changed, 13 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c

[libvirt] [libvirt-gconfig PATCHv2 11/14] Implement GVirConfigDomainAddressUsb

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-domain-address-usb.c | 96 .../libvirt-gconfig-domain-address-usb.h | 71 +++ libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-gconfig PATCHv2 13/14] test-domain-create: set an address for redirdev devices

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 46 +++- 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index cdee883..b6d8813 100644 ---

[libvirt] [libvirt-gconfig PATCHv2 06/14] test-domain-create: add USB controller creation

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index 4ee33aa..7be9fc2 100644 --- a/libvirt-gconfig/tests/test-domain-create.c

[libvirt] [libvirt-gconfig PATCHv2 07/14] Add GVirConfigDomainAddress abstract type

2012-04-11 Thread Christophe Fergeau
This is an abstract type which will be the base class for device addresses. --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-domain-address.c | 50 + libvirt-gconfig/libvirt-gconfig-domain-address.h | 63 ++

[libvirt] [libvirt-gconfig PATCHv2 10/14] Improve USB device creation in test-domain-create

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 54 +++- 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index 7be9fc2..cdee883 100644 ---

[libvirt] [libvirt-gconfig PATCHv2 09/14] Implement gvir_config_domain_controller_set_address

2012-04-11 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-controller.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-controller.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym |1 + 3 files changed, 13 insertions(+) diff --git

[libvirt] [libvirt-gconfig PATCHv2 08/14] Implement GVirConfigDomainAddressPci

2012-04-11 Thread Christophe Fergeau
It already has the needed setters. --- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-domain-address-pci.c | 124 .../libvirt-gconfig-domain-address-pci.h | 78 libvirt-gconfig/libvirt-gconfig.h

[libvirt] [test-API PATCH 0/4]Add feature to check case file before running

2012-04-11 Thread Guannan Ren
The set of patches add a new feature to examine testcase config file before running it. The framework will do the job on behalf of testcase, so test writer will release from the work. Usage: In testcase, it only needs to define two global tuple variables required_params are the mandatory

[libvirt] [test-API PATCH 2/4] cfgcheck: new class implement testcase config file checking

2012-04-11 Thread Guannan Ren
casecfgcheck.py --- casecfgcheck.py | 66 +++ 1 files changed, 66 insertions(+), 0 deletions(-) create mode 100644 casecfgcheck.py diff --git a/casecfgcheck.py b/casecfgcheck.py new file mode 100644 index 000..3c4696d --- /dev/null

[libvirt] [test-API PATCH 1/4] filter: new class for filter or extract data

2012-04-11 Thread Guannan Ren
activityfilter.py --- activityfilter.py | 74 + 1 files changed, 74 insertions(+), 0 deletions(-) create mode 100644 activityfilter.py diff --git a/activityfilter.py b/activityfilter.py new file mode 100644 index 000..d99d690 ---

[libvirt] [test-API PATCH 4/4] main: rename to Main class and use class Filter CaseCfgCheck

2012-04-11 Thread Guannan Ren
libvirt-test-api.py --- libvirt-test-api.py | 52 ++ 1 files changed, 23 insertions(+), 29 deletions(-) diff --git a/libvirt-test-api.py b/libvirt-test-api.py index d4ce4f2..877104c 100644 --- a/libvirt-test-api.py +++ b/libvirt-test-api.py

[libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Christophe Fergeau
This function is a helper function which adds all the needed devices for working USB support in the guest. This can be done manually, but is a bit tedious, hence this helper. --- libvirt-gconfig/libvirt-gconfig-domain.c | 41

[libvirt] [test-API PATCH 3/4] proxy: improve it to support testcase options checking

2012-04-11 Thread Guannan Ren
--- proxy.py | 78 ++--- 1 files changed, 48 insertions(+), 30 deletions(-) diff --git a/proxy.py b/proxy.py index 3cd31bd..990e1f0 100644 --- a/proxy.py +++ b/proxy.py @@ -20,7 +20,6 @@ import exception - class Proxy(object):

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Guido Günther
On Wed, Apr 11, 2012 at 01:41:38PM +0200, Christophe Fergeau wrote: On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote: On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue,

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Guido Günther
On Wed, Apr 11, 2012 at 12:30:05PM +0100, Daniel P. Berrange wrote: On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote: On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue,

[libvirt] numad: Convert node list to cpumap before affinity setting

2012-04-11 Thread Osier Yang
Previous patches on numad made mistake with thinking numad will return CPUs list (numad document says CPUs list one place, and node list another place. :( Please see the patches' commit message for the details. Osier Yang (3) numad: Convert node list to cpumap before setting affinity numad:

[libvirt] [PATCH 1/3] numad: Convert node list to cpumap before setting affinity

2012-04-11 Thread Osier Yang
Instead of returning a CPUs list, numad returns NUMA node list instead, this patch is to convert the node list to cpumap before affinity setting. Otherwise, the domain processes will be pinned only to CPU[$numa_cell_num], which will cause significiant performance losing. Also because numad will

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Marc-André Lureau
On Wed, Apr 11, 2012 at 3:48 PM, Christophe Fergeau cferg...@redhat.com wrote: +void gvir_config_domain_setup_default_usb_controllers(GVirConfigDomain *domain) I suggest it takes an enum, such as CONFIG_DOMAIN_SETUP_USB_CONTROLLERS_ICH9 or USB2 regards -- Marc-André Lureau -- libvir-list

[libvirt] [PATCH 2/3] numad: Ignore cpuset if placement is auto

2012-04-11 Thread Osier Yang
As explained in previous patch, numad will balance the affinity dynamically, so reflecting the cpuset from numad at the first time doesn't make much case, and may just could cause confusion. --- docs/formatdomain.html.in | 10 +- src/conf/domain_conf.c| 28

Re: [libvirt] [PATCH] qemu: optimize JSON event handler lookup

2012-04-11 Thread Eric Blake
On 04/10/2012 06:53 PM, Wen Congyang wrote: At 04/11/2012 06:47 AM, Eric Blake Wrote: Probably in the noise, but this will let us scale more efficiently as we recognize ever more qemu events. * src/qemu/qemu_monitor_json.c (eventHandlers): Sort. (eventSearch): New helper function.

Re: [libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS

2012-04-11 Thread Eric Blake
On 04/11/2012 03:17 AM, Michal Privoznik wrote: If dynamic_ownership is off and we are creating a file on NFS we force chown. This will fail as chown/chmod are not supported on NFS. However, with no dynamic_ownership we are not required to do any chown. --- src/qemu/qemu_driver.c | 10

[libvirt] [PATCH 3/3] qemu: Avoid the memory allocation and freeing

2012-04-11 Thread Osier Yang
--- src/qemu/qemu_process.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0bf743b..7a48c12 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1759,23 +1759,19 @@ static char *

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Marc-André Lureau
On Wed, Apr 11, 2012 at 5:29 PM, Christophe Fergeau cferg...@redhat.com wrote: What would _USB2 do? Add an _EHCI controller, plus either _PIIX3_UHCI or _PIIX4_UHCI? From what I remember Hans told me, all the 4 ehci + uhci companions controllers are needed for a proper USB2 setup. I suggest an

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Christophe Fergeau
On Wed, Apr 11, 2012 at 06:01:42PM +0200, Marc-André Lureau wrote: On Wed, Apr 11, 2012 at 5:29 PM, Christophe Fergeau cferg...@redhat.com wrote: What would _USB2 do? Add an _EHCI controller, plus either _PIIX3_UHCI or _PIIX4_UHCI? From what I remember Hans told me, all the 4 ehci + uhci

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Daniel P. Berrange
On Wed, Apr 11, 2012 at 06:01:42PM +0200, Marc-André Lureau wrote: On Wed, Apr 11, 2012 at 5:29 PM, Christophe Fergeau cferg...@redhat.com wrote: What would _USB2 do? Add an _EHCI controller, plus either _PIIX3_UHCI or _PIIX4_UHCI? From what I remember Hans told me, all the 4 ehci + uhci

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Christophe Fergeau
On Wed, Apr 11, 2012 at 05:19:33PM +0100, Daniel P. Berrange wrote: The concept of 'default usb controllers' seems very policy based to me different hypervisors will have different views of this. So IMHO we should not add this API I'm fine with dropping the patch. My feeling was that this

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Marc-André Lureau
On Wed, Apr 11, 2012 at 6:19 PM, Daniel P. Berrange berra...@redhat.com wrote: The concept of 'default usb controllers' seems very policy based to me different hypervisors will have different views of this. This is a helper, it is not imposing any policy, but giving you sane default setup for

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-11 Thread Christophe Fergeau
On Wed, Apr 11, 2012 at 04:29:28PM +0200, Marc-André Lureau wrote: On Wed, Apr 11, 2012 at 3:48 PM, Christophe Fergeau cferg...@redhat.com wrote: +void gvir_config_domain_setup_default_usb_controllers(GVirConfigDomain *domain) I suggest it takes an enum, such as

Re: [libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS

2012-04-11 Thread Eric Blake
On 04/11/2012 08:41 AM, Eric Blake wrote: On 04/11/2012 03:17 AM, Michal Privoznik wrote: If dynamic_ownership is off and we are creating a file on NFS we force chown. This will fail as chown/chmod are not supported on NFS. However, with no dynamic_ownership we are not required to do any

Re: [libvirt] [PATCH] storage backend: Add RBD (RADOS Block Device) support

2012-04-11 Thread Wido den Hollander
Hi, On 03/30/2012 11:04 AM, Wido den Hollander wrote: This patch adds support for a new storage backend with RBD support. RBD is the RADOS Block Device and is part of the Ceph distributed storage system. It comes in two flavours: Qemu-RBD and Kernel RBD, this storage backend only supports

Re: [libvirt] [PATCHv4 02/18] blockjob: add API for async virDomainBlockJobAbort

2012-04-11 Thread Eric Blake
On 04/10/2012 03:30 PM, Eric Blake wrote: Okay, as I understand it, the only qemu binary that has a synchronous block_job_cancel command is the version that is part of RHEL6.2. So any compatibility code to allow for a synchronous block_job_cancel command in qemu would only ever make a

Re: [libvirt] Add USB controller support

2012-04-11 Thread Marc-André Lureau
Hi On Wed, Apr 11, 2012 at 3:48 PM, Christophe Fergeau cferg...@redhat.com wrote: Here is the second version of the patch series implementing USB controller support in libvirt-gconfig. There's a bug fixed in GVirConfigDomainAddressUsb creation (type=usb was missing) as well as a few small bug

Re: [libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS

2012-04-11 Thread Laine Stump
ACK to the idea, but NACK to the exact placement of the fix. On 04/11/2012 05:17 AM, Michal Privoznik wrote: If dynamic_ownership is off and we are creating a file on NFS we force chown. This will fail as chown/chmod are not supported on NFS. However, with no dynamic_ownership we are not

[libvirt] [PATCH 0/5] fix block job bugs relative to upstream qemu

2012-04-11 Thread Eric Blake
The following 5 patches are ready for review and application to libvirt now, since they correspond to features that are currently in the qemu 1.1 tree. (I've split these less-controversial parts from v4 of my larger storage migration series [1]; so that this series has no dependency on the

[libvirt] [PATCH 1/5] blockjob: add qemu capabilities related to block pull jobs

2012-04-11 Thread Eric Blake
RHEL 6.2 was released with an early version of block jobs, which only worked on the qed file format, where the commands were spelled with underscore (contrary to QMP style), and where 'block_job_cancel' was synchronous and did not trigger an event. qemu 1.1 has fixed these short-comings [1][2]:

[libvirt] [PATCH 3/5] blockjob: optimize JSON event handler lookup

2012-04-11 Thread Eric Blake
Probably in the noise, but this will let us scale more efficiently as we recognize ever more qemu events. * src/qemu/qemu_monitor_json.c (eventHandlers): Sort. (eventSearch): New helper function. (qemuMonitorJSONIOProcessEvent): Optimize event lookup. --- src/qemu/qemu_monitor_json.c | 54

[libvirt] [PATCH 5/5] blockjob: allow for fast-finishing job

2012-04-11 Thread Eric Blake
In my testing, I was able to provoke an odd block pull failure: $ virsh blockpull dom vda --bandwidth 1 error: Requested operation is not valid: No active operation on device: drive-virtio-disk0 merely by using gdb to artifically wait to do the block job set speed until after the pull had

[libvirt] [PATCH 2/5] blockjob: add API for async virDomainBlockJobAbort

2012-04-11 Thread Eric Blake
From: Adam Litke a...@us.ibm.com Block job cancellation can take a while. Now that upstream qemu 1.1 has asynchronous block cancellation, we want to expose that to the user. Therefore, the following updates are made to the virDomainBlockJob API: A new block job event type

[libvirt] [PATCH 4/5] blockjob: wire up qemu async virDomainBlockJobAbort

2012-04-11 Thread Eric Blake
Without the VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC flag, libvirt will internally poll using qemu's query-block-jobs API and will not return until the operation has been completed. API users are advised that this operation is unbounded and further interaction with the domain during this period may

Re: [libvirt] [PATCH 1/5] blockjob: add qemu capabilities related to block pull jobs

2012-04-11 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 05:40:34PM -0600, Eric Blake wrote: RHEL 6.2 was released with an early version of block jobs, which only worked on the qed file format, where the commands were spelled with underscore (contrary to QMP style), and where 'block_job_cancel' was synchronous and did not

Re: [libvirt] [PATCH 2/5] blockjob: add API for async virDomainBlockJobAbort

2012-04-11 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 05:40:35PM -0600, Eric Blake wrote: From: Adam Litke a...@us.ibm.com Block job cancellation can take a while. Now that upstream qemu 1.1 has asynchronous block cancellation, we want to expose that to the user. Therefore, the following updates are made to the

Re: [libvirt] [PATCH 3/5] blockjob: optimize JSON event handler lookup

2012-04-11 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 05:40:36PM -0600, Eric Blake wrote: Probably in the noise, but this will let us scale more efficiently as we recognize ever more qemu events. s/ever/even/ * src/qemu/qemu_monitor_json.c (eventHandlers): Sort. (eventSearch): New helper function.

Re: [libvirt] [PATCH 4/5] blockjob: wire up qemu async virDomainBlockJobAbort

2012-04-11 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 05:40:37PM -0600, Eric Blake wrote: Without the VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC flag, libvirt will internally poll using qemu's query-block-jobs API and will not return until the operation has been completed. API users are advised that this operation is unbounded and

Re: [libvirt] [PATCH 5/5] blockjob: allow for fast-finishing job

2012-04-11 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 05:40:38PM -0600, Eric Blake wrote: In my testing, I was able to provoke an odd block pull failure: $ virsh blockpull dom vda --bandwidth 1 error: Requested operation is not valid: No active operation on device: drive-virtio-disk0 merely by using gdb to

Re: [libvirt] [PATCH 1/5] blockjob: add qemu capabilities related to block pull jobs

2012-04-11 Thread Eric Blake
On 04/11/2012 07:09 PM, Daniel Veillard wrote: On Wed, Apr 11, 2012 at 05:40:34PM -0600, Eric Blake wrote: RHEL 6.2 was released with an early version of block jobs, which only worked on the qed file format, where the commands were spelled with underscore (contrary to QMP style), and where

Re: [libvirt] [PATCH 1/5] blockjob: add qemu capabilities related to block pull jobs

2012-04-11 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 08:17:11PM -0600, Eric Blake wrote: On 04/11/2012 07:09 PM, Daniel Veillard wrote: On Wed, Apr 11, 2012 at 05:40:34PM -0600, Eric Blake wrote: RHEL 6.2 was released with an early version of block jobs, which only worked on the qed file format, where the commands were

[libvirt] [libvirt-glib] Getter/setter for disk source's startupPolicy attribute

2012-04-11 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26 + libvirt-gconfig/libvirt-gconfig-domain-disk.h |9 libvirt-gconfig/libvirt-gconfig.sym |3 ++ 3 files changed, 38 insertions(+), 0

Re: [libvirt] [PATCH 4/5] blockjob: wire up qemu async virDomainBlockJobAbort

2012-04-11 Thread Eric Blake
On 04/11/2012 07:26 PM, Daniel Veillard wrote: On Wed, Apr 11, 2012 at 05:40:37PM -0600, Eric Blake wrote: Without the VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC flag, libvirt will internally poll using qemu's query-block-jobs API and will not return until the operation has been completed. API users

Re: [libvirt] [test-API PATCH 1/5] test-API: Destroy the class for utils.py

2012-04-11 Thread Guannan Ren
On 04/10/2012 03:34 PM, Osier Yang wrote: IMHO there is not any benifit to use class in a utils script, except you have to construct the object again and again in scripts. :-) Incidental cleanups: * s/parser_uri/parse_uri/ * s/#this/# This/ * Useless comments on the top are removed.

Re: [libvirt] [test-API PATCH 3/5] test-API: Substitute utils.Utils with utils

2012-04-11 Thread Guannan Ren
On 04/10/2012 03:34 PM, Osier Yang wrote: $ for i in $(find . -type f -name *.py); do \ sed -i -e 's/utils\.Utils()/utils/g' $i; \ done --- repos/domain/cpu_affinity.py |2 +- utils/xmlgenerator.py| 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-)

Re: [libvirt] [test-API PATCH 2/5] test-API: Remove the codes used to construct utils object

2012-04-11 Thread Guannan Ren
On 04/10/2012 03:34 PM, Osier Yang wrote: $ for i in $(find . -type f -name *.py); do \ sed -i -e '/util *= *utils\.Utils()/d' $i; \ done --- repos/domain/attach_disk.py|1 - repos/domain/attach_interface.py |1 -

Re: [libvirt] [PATCH 5/5] blockjob: allow for fast-finishing job

2012-04-11 Thread Eric Blake
On 04/11/2012 07:29 PM, Daniel Veillard wrote: On Wed, Apr 11, 2012 at 05:40:38PM -0600, Eric Blake wrote: In my testing, I was able to provoke an odd block pull failure: $ virsh blockpull dom vda --bandwidth 1 error: Requested operation is not valid: No active operation on device:

Re: [libvirt] [test-API PATCH 4/5] test-API: Substitue util. with utils.

2012-04-11 Thread Guannan Ren
On 04/10/2012 03:34 PM, Osier Yang wrote: $ for i in $(find . -type f -name *.py); do \ sed -i -e 's/util\./utils\./g' $i; \ done --- repos/domain/attach_disk.py|4 +- repos/domain/attach_interface.py |4 +-

Re: [libvirt] [test-API PATCH 5/5] testcase: remove useless utils import

2012-04-11 Thread Guannan Ren
On 04/10/2012 03:34 PM, Osier Yang wrote: --- repos/domain/autostart.py|1 - repos/domain/blkstats.py |1 - repos/domain/console_mutex.py|1 - repos/domain/domain_blkinfo.py |1 - repos/domain/domain_id.py