[libvirt] Bug:libvirtd boot up blocked in NAT network setup

2012-09-05 Thread Wenchao Xia
Hello, guys I met a strange problem in libvirt+kvm massive deployment case. What shows is that libvirtd will not respond to any virsh calls, with debug I found that libvirtd was blocked at the step to setup default nat network, that is command "iptables -table nat x". In terminal, I found c

Re: [libvirt] [PATCH v0] qemu: Add sandbox support.

2012-09-05 Thread Daniel Veillard
On Thu, Sep 06, 2012 at 02:27:19PM +0800, Daniel Veillard wrote: > On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote: > > QEMU (since 1.2-rc0) supports setting up a syscall whitelist through > > libseccomp on linux kernel from 3.5-rc1. This is enabled by specifying > > -sandbox on on qemu c

Re: [libvirt] [PATCH v0] qemu: Add sandbox support.

2012-09-05 Thread Daniel Veillard
On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote: > QEMU (since 1.2-rc0) supports setting up a syscall whitelist through > libseccomp on linux kernel from 3.5-rc1. This is enabled by specifying > -sandbox on on qemu command line. > > This patch detects this capability by searching for -sa

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-05 Thread Kamezawa Hiroyuki
(2012/09/06 14:32), liguang wrote: Hello, Eric & Daniel 在 2012-09-05三的 11:08 -0600,Eric Blake写道: On 09/05/2012 02:48 AM, Daniel P. Berrange wrote: I really don't like the general design of this patch, even ignoring all the code bugs. I think this entire patch is really just a solution in sear

Re: [libvirt] [PATCH] pci: Save and restore each devices/functions behind the bus

2012-09-05 Thread Daniel Veillard
On Mon, Sep 03, 2012 at 04:57:01PM +0800, Osier Yang wrote: > Previously it refuses to do the secondary bus reset as long as > there is(are) devices/functions behind the same bus, regardless > of whether the devices/functions are being used or not. And it > only save and restore the device itself's

Re: [libvirt] [RFC PATCH v1 2/2] tests: Add tests for gluster protocol based network disks support

2012-09-05 Thread Harsh Bora
On 09/05/2012 07:05 PM, Jiri Denemark wrote: On Thu, Aug 23, 2012 at 16:31:52 +0530, Harsh Prateek Bora wrote: Signed-off-by: Harsh Prateek Bora --- tests/qemuargv2xmltest.c | 1 + .../qemuxml2argv-disk-drive-network-gluster.args | 1 + .../qemuxml2argv-disk-d

Re: [libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

2012-09-05 Thread Daniel Veillard
On Tue, Sep 04, 2012 at 04:35:24PM -0400, Kyle Mestery wrote: > Add the ability to migrate per-port data on Open vSwitch > ports during qemu live migration. A controller can use this > to store data relating to each port, and have it migrated > with the virtual machine and populated on the destinat

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-05 Thread liguang
Hello, Eric & Daniel 在 2012-09-05三的 11:08 -0600,Eric Blake写道: > On 09/05/2012 02:48 AM, Daniel P. Berrange wrote: > >>> > >>> I really don't like the general design of this patch, even > >>> ignoring all the code bugs. I think this entire patch is > >>> really just a solution in search of a proble

Re: [libvirt] [RFC PATCH v1 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-09-05 Thread Harsh Bora
On 09/05/2012 07:03 PM, Jiri Denemark wrote: On Thu, Aug 23, 2012 at 16:31:51 +0530, Harsh Prateek Bora wrote: Qemu accepts gluster protocol as supported storage backend beside others. This patch allows users to specify disks on gluster backends like this:

[libvirt] [PATCH V5] support offline migration

2012-09-05 Thread liguang
original migration did not aware of offline case, so, add code to support offline migration quietly (did not disturb original migration) by pass VIR_MIGRATE_OFFLINE flag to migration APIs, and migration process will not puzzeled by domain offline and exit unexpectly. these changes did not take care

Re: [libvirt] [PATCHv6 0/2] Implementation of virConnectListAllDomains() for esx and hyperv

2012-09-05 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 05:36:51PM +0200, Peter Krempa wrote: > Yet another respin updated and rebased to current head. > > Both drivers are compile tested but I don't have the infrastructure do a > functional test. > > Peter Krempa (2): > hyperv: Add implementation for virConnectListAllDomains

Re: [libvirt] [PATCH v2 0/4] Add cpu hotplug support to libvirt.

2012-09-05 Thread Tang Chen
Hi Daniel, On 09/05/2012 05:43 PM, Daniel P. Berrange wrote: Your patch appears to work in some limited scenarios, but more generally it will fail to work, and resulted in undesirable behaviour. Consider for example, if libvirtd is configured thus: cd /sys/fs/cgroup/cpuset mkdir demo

Re: [libvirt] [RFC] [PATCH v2 1/6] add configure option --with-fuse for libvirt

2012-09-05 Thread Gao feng
于 2012年09月05日 20:42, Daniel P. Berrange 写道: > On Wed, Sep 05, 2012 at 05:41:40PM +0800, Gao feng wrote: >> Hi Daniel & Glauber >> >> 于 2012年07月31日 17:27, Daniel P. Berrange 写道: >>> Hi Gao, >>> >>> I'm wondering if you are planning to attend the Linux Plumbers Conference >>> in San Diego at the end

[libvirt] [PATCH] build: improved handling of , BSD

2012-09-05 Thread Eric Blake
FreeBSD and OpenBSD have a that is not self-contained; and mingw lacks the header altogether. But gnulib has just taken care of that for us, so we might as well simplify our code. In the process, I got a syntax-check failure if we don't also take the gnulib execinfo module. * .gnulib: Update to

Re: [libvirt] broken OpenBSD [was: [PATCH] Include some extra headers needed for OpenBSD.]

2012-09-05 Thread Eric Blake
On 09/04/2012 11:23 AM, Jasper Lievisse Adriaanse wrote: > On Tue, Sep 04, 2012 at 11:08:30AM -0600, Eric Blake wrote: >> [adding gnulib] >> >> Ouch. The POSIX definition of doesn't include any interface >> that needs to use struct sockaddr. Which OpenBSD extension function is >> triggering thi

[libvirt] [PATCH 4/2] build: avoid test failure when sasl was not compiled in

2012-09-05 Thread Eric Blake
On systems without cyrus-sasl-devel available (I happened to be in that situation on my FreeBSD testing), this test fails rather miserably: TEST: libvirtdconftest .!!...! 39 FAIL FAIL: libvirtdconftest with verbose output showing things like: 39) Test corr

Re: [libvirt] [PATCH 0/2] Fix 'make' issues on OpenBSD.

2012-09-05 Thread Eric Blake
On 09/05/2012 12:02 PM, Eric Blake wrote: > Pushing both under the build-breaker rule. 'make check' still > fails some gnulib tests on OpenBSD, but that's not quite as > severe. Shoot; I was thinking too much about Jasper's patches. I was actually testing on FreeBSD, not OpenBSD, for these parti

Re: [libvirt] [PATCH] build: require netcf-0.2.2 when installing on Fedora18+

2012-09-05 Thread Laine Stump
On 09/04/2012 01:17 PM, Eric Blake wrote: > On 09/04/2012 11:10 AM, Laine Stump wrote: >> A previous patch forced libnl-3 and netcf-0.2.2 (which itself requires >> libnl-3) when *building* for Fedora 18+ (and RHEL 7+), but the >> install-time Requires: for netcf has always been implicit due to >> l

Re: [libvirt] [PATCH] network: prevent infinite hang if ovs-vswitchd isn't running

2012-09-05 Thread Laine Stump
On 09/05/2012 02:28 PM, Kyle Mestery (kmestery) wrote: > On Sep 5, 2012, at 1:24 PM, Laine Stump wrote: >> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=852984 >> >> If a network or interface is configured to use Open vSwitch, but >> ovs-vswitchd (the Open vSwitch database service) isn't r

[libvirt] [PATCH 3/2] build: avoid check-symfile on non-Linux

2012-09-05 Thread Eric Blake
I tested both OpenBSD and cygwin; both failed 'make check' with: GENcheck-symfile Can't return outside a subroutine at ./check-symfile.pl line 13. Perl requires 'exit 77' instead of 'return 77' in that context, but even with that tweak, the build still fails, since the exit code of 77 is on

Re: [libvirt] [PATCH] network: prevent infinite hang if ovs-vswitchd isn't running

2012-09-05 Thread Kyle Mestery (kmestery)
On Sep 5, 2012, at 1:24 PM, Laine Stump wrote: > This fixes https://bugzilla.redhat.com/show_bug.cgi?id=852984 > > If a network or interface is configured to use Open vSwitch, but > ovs-vswitchd (the Open vSwitch database service) isn't running, the > ovs-vsctl add-port/del-port commands will hang

[libvirt] [PATCH] network: prevent infinite hang if ovs-vswitchd isn't running

2012-09-05 Thread Laine Stump
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=852984 If a network or interface is configured to use Open vSwitch, but ovs-vswitchd (the Open vSwitch database service) isn't running, the ovs-vsctl add-port/del-port commands will hang indefinitely rather than returning an error. There is a

[libvirt] [PATCH 1/2] build: avoid warnings from gcc 4.2.1

2012-09-05 Thread Eric Blake
OpenBSD ships with gcc 4.2.1, which annoyingly treats all format strings as though they were also attribute((nonnull)). The two concepts are orthogonal, though, as evidenced by the number of spurious warnings it generates on uses where we know that virReportError specifically handles NULL instead

[libvirt] [PATCH 0/2] Fix 'make' issues on OpenBSD.

2012-09-05 Thread Eric Blake
Pushing both under the build-breaker rule. 'make check' still fails some gnulib tests on OpenBSD, but that's not quite as severe. Eric Blake (2): build: avoid warnings from gcc 4.2.1 build: don't fail when xsltproc is missing docs/Makefile.am| 9 + m4/virt-compile-warnin

[libvirt] [PATCH 2/2] build: don't fail when xsltproc is missing

2012-09-05 Thread Eric Blake
On a machine without xsltproc, the build failed with: Scripting search.php /usr/local/bin/bash: line 1: search.php.tmp: No such file or directory rm: ./search.php: No such file or directory Regression introduced in commit 28183590. * docs/Makefile.am (%.php): Skip in the same conditions when the

Re: [libvirt] VM Migration with IEEE802.1Qbh and IEEE802.1Qbg

2012-09-05 Thread Laine Stump
On 09/04/2012 11:14 AM, Laine Stump wrote: > On 09/04/2012 04:29 AM, Martin Kletzander wrote: >> There should be one more option in case the is specified >> in the guest's . According to the docs [2], when no "type=" >> is specified for the element, this should be >> auto-completed on the domain

Re: [libvirt] [PATCH] Fix adding ports to OVS bridges without VLAN tags

2012-09-05 Thread Laine Stump
On 09/04/2012 05:03 PM, Kyle Mestery (kmestery) wrote: > On Aug 31, 2012, at 9:09 AM, Daniel Veillard wrote: >> On Fri, Aug 31, 2012 at 01:32:34PM +, Kyle Mestery (kmestery) wrote: >>> On Aug 30, 2012, at 10:23 PM, Daniel Veillard wrote: On Thu, Aug 30, 2012 at 04:38:06PM -0400, Kyle Meste

Re: [libvirt] [PATCH] qemu: don't pin all the cpus

2012-09-05 Thread Martin Kletzander
On 09/05/2012 07:11 PM, Michal Privoznik wrote: > On 04.09.2012 16:23, Martin Kletzander wrote: >> This is another fix for the emulator-pin series. When going through >> the cputune pinning settings, the current code is trying to pin all >> the CPUs, even when not all of them are specified. This ca

Re: [libvirt] [PATCH] maint: avoid doubled name in syntax check failures

2012-09-05 Thread Eric Blake
On 09/05/2012 01:04 AM, Martin Kletzander wrote: > On 09/05/2012 01:41 AM, Eric Blake wrote: >> Based on a similar gnulib patch; use of $(_sc_search_regexp) >> already injects $(ME) into any output messages, so a failure >> of these rules would look like this, pre-patch: >> >> ./config.status: ./co

Re: [libvirt] [PATCH 09/10 v5] list: Use virConnectListAllStoragePools in virsh

2012-09-05 Thread Laine Stump
On 09/05/2012 12:52 PM, Eric Blake wrote: > On 09/05/2012 12:36 AM, Osier Yang wrote: >> +++ b/tools/virsh-pool.c >> @@ -36,6 +36,7 @@ >> #include "memory.h" >> #include "util.h" >> #include "xml.h" >> +#include "conf/storage_conf.h" > I'm not sure if virsh is supposed to be able to use conf/*.

Re: [libvirt] [PATCH] build: use re-entrant functions in virsh

2012-09-05 Thread Eric Blake
On 09/05/2012 12:52 AM, Martin Kletzander wrote: > On 09/05/2012 01:36 AM, Eric Blake wrote: >> Today's patches pointed out that virsh was still using localtime(), >> which is not thread-safe, even though virsh is definitely >> multi-threaded. >> >> * cfg.mk (exclude_file_name_regexp--sc_prohibit_n

Re: [libvirt] [PATCH] qemu: don't pin all the cpus

2012-09-05 Thread Michal Privoznik
On 04.09.2012 16:23, Martin Kletzander wrote: > This is another fix for the emulator-pin series. When going through > the cputune pinning settings, the current code is trying to pin all > the CPUs, even when not all of them are specified. This causes error > in the subsequent function which, of cou

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-05 Thread Eric Blake
On 09/05/2012 02:48 AM, Daniel P. Berrange wrote: >>> >>> I really don't like the general design of this patch, even >>> ignoring all the code bugs. I think this entire patch is >>> really just a solution in search of a problem. Offline migration >>> is already possible with existing libvirt APIs:

Re: [libvirt] [PATCH 09/10 v5] list: Use virConnectListAllStoragePools in virsh

2012-09-05 Thread Eric Blake
On 09/05/2012 10:52 AM, Eric Blake wrote: >> +for (i = 0; i < npoolTypes; i++) { >> +if ((poolType = virStoragePoolTypeFromString(poolTypes[i])) < >> 0) { >> +vshError(ctl, "%s", _("Invalid pool type")); > > Hmm. What happens if we add new pool types in the f

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-05 Thread Dave Allan
On Wed, Sep 05, 2012 at 09:48:22AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 05, 2012 at 08:51:05AM +0800, liguang wrote: > > 在 2012-09-04二的 12:12 +0100,Daniel P. Berrange写道: > > > On Mon, Sep 03, 2012 at 02:23:24PM +0800, liguang wrote: > > > > allow migration even domain isn't active by > >

Re: [libvirt] [PATCH 10/10] python: Expose virStorageListAllStoragePools to python binding

2012-09-05 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: > The implementation is done manually as the generator does not support > wrapping lists of C pointers into Python objects. Given the number of times we've made comments like this in the overall series, I can't help but wonder if it is worth teaching the g

Re: [libvirt] [PATCH 09/10 v5] list: Use virConnectListAllStoragePools in virsh

2012-09-05 Thread Eric Blake
On 09/05/2012 12:36 AM, Osier Yang wrote: > tools/virsh-pool.c: > * vshStoragePoolSorter to sort the pool list by pool name. > > * struct vshStoragePoolList to present the pool list, pool info > is collected by list->poolinfo if 'details' is specified by > user. > > * vshStoragePool

Re: [libvirt] [PATCH 08/10] list: Change MATCH for common use in virsh

2012-09-05 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: > Move definition of MATCH from virsh-domain-monitor.c into > virsh.h for further use. > --- > tools/virsh-domain-monitor.c |2 -- > tools/virsh.h|2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) > Not quite right. > +++

Re: [libvirt] [PATCH 06/10] list: Add helper to convert strings separated by ', ' to array

2012-09-05 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: > tools/virsh.c: New helper function vshStringToArray. > tools/virsh.h: Declare vshStringToArray. > tools/virsh-domain.c: use the helper in cmdUndefine. > --- > tools/virsh-domain.c | 19 ++- > tools/virsh.c| 44

Re: [libvirt] [PATCH 07/10] virsh: Fix the wrong doc for pool-list

2012-09-05 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: > The storage pool's management doesn't relate with a domain, it > probably was an intention, but not achieved yet. And the fact > is only active pools are listed by default. > --- > tools/virsh.pod |9 - > 1 files changed, 4 insertions(+), 5 d

Re: [libvirt] [PATCH 05/10] list: Implement listAllStoragePools for test driver

2012-09-05 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: > src/test/test_driver.c: Implement listAllStoragePools > --- > src/test/test_driver.c | 17 + > 1 files changed, 17 insertions(+), 0 deletions(-) > > @@ -5662,6 +5678,7 @@ static virStorageDriver testStorageDriver = { > .listPools

Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

2012-09-05 Thread Laine Stump
On 09/05/2012 07:55 AM, Gene Czarcinski wrote: > On 09/04/2012 11:12 AM, Eric Blake wrote: >> On 08/22/2012 11:47 AM, Eric Blake wrote: >>> On 08/22/2012 11:39 AM, Eric Blake wrote: On 08/22/2012 10:59 AM, Gene Czarcinski wrote: > As I said in a previous message, dnsmasq is forwarding a nu

[libvirt] 100+ misspellings

2012-09-05 Thread Jim Meyering
Hello, In case someone is interested in weeding out the inevitable false positives, here is a slightly filtered list of misspelled words in libvirt, as detected by the misspellings program from here: http://github.com/lyda/misspell-check Here's the output from this command: misspellings $(git

Re: [libvirt] [RFC PATCH v1 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-09-05 Thread Eric Blake
On 09/05/2012 09:08 AM, Bharata B Rao wrote: > On Wed, Sep 5, 2012 at 7:03 PM, Jiri Denemark wrote: >>> @@ -1042,6 +1043,13 @@ >>> >>> >>> >>> + >>> + >>> +socket >

Re: [libvirt] [RFC PATCH v1 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-09-05 Thread Bharata B Rao
On Wed, Sep 5, 2012 at 7:03 PM, Jiri Denemark wrote: >> @@ -1042,6 +1043,13 @@ >> >> >> >> + >> + >> +socket >> +unix >> +

Re: [libvirt] [PATCH 0/6 v4] Atomic API to list secrets

2012-09-05 Thread Eric Blake
On 09/05/2012 09:03 AM, Peter Krempa wrote: > The series looks fine and I'm giving ACK if you fix problems pointed out > in the patches or other that may emerge. > > This API is a nice unification to the listing approach as there are no > "inactive" secrets there's no race this would fix. Additio

Re: [libvirt] [PATCH] [trivial] Fix spelling mistake

2012-09-05 Thread Eric Blake
On 09/05/2012 08:49 AM, Philipp Hahn wrote: > provably -> probably > > Signed-off-by: Philipp Hahn > --- > cfg.mk |2 +- > src/libvirt.c |2 +- > tools/virsh.pod |2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cfg.mk b/cfg.mk > index 4cdfd1b..8f

Re: [libvirt] [PATCH 0/6 v4] Atomic API to list secrets

2012-09-05 Thread Peter Krempa
The series looks fine and I'm giving ACK if you fix problems pointed out in the patches or other that may emerge. This API is a nice unification to the listing approach as there are no "inactive" secrets there's no race this would fix. Peter -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 1/6] list: Define new API virConnectListAllSecrets

2012-09-05 Thread Eric Blake
On 09/05/2012 12:28 AM, Osier Yang wrote: > This is to list the secret objects. No flags are supported Any reason we aren't allowing a filter on ephemeral=yes/no and private=yes/no from the secret XML? That is, I think you can usefully introduce two sets of filters based on those two binary prope

Re: [libvirt] [PATCH 6/6] virsh: Remove unused vshNameSorter

2012-09-05 Thread Peter Krempa
On 09/05/12 08:28, Osier Yang wrote: vshNameSorter now is not used anymore. Remove it. --- tools/virsh.c |9 - tools/virsh.h |1 - 2 files changed, 0 insertions(+), 10 deletions(-) Yep, this function isn't used after all the changes. ACK. Peter -- libvir-list mailing lis

[libvirt] [PATCH] [trivial] Fix spelling mistake

2012-09-05 Thread Philipp Hahn
provably -> probably Signed-off-by: Philipp Hahn --- cfg.mk |2 +- src/libvirt.c |2 +- tools/virsh.pod |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 4cdfd1b..8fd9462 100644 --- a/cfg.mk +++ b/cfg.mk @@ -379,7 +379,7 @@ sc_proh

Re: [libvirt] [PATCH 5/6] list: Expose virConnectListAllSecrets to Python binding

2012-09-05 Thread Peter Krempa
On 09/05/12 08:28, Osier Yang wrote: The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: Implementation for listAllSecrets. python/libvirt-overri

Re: [libvirt] [PATCH 4/6] list: Expose virConnectListAllSecrets to Python binding

2012-09-05 Thread Peter Krempa
On 09/05/12 08:28, Osier Yang wrote: The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: Implementation for listAllSecrets. python/libvirt-overri

Re: [libvirt] [PATCH 3/6] list: Implement listAllSecrets

2012-09-05 Thread Peter Krempa
On 09/05/12 08:28, Osier Yang wrote: Simply returns the object list. No filtering. src/secret/secret_driver.c: Implement listAllSecrets --- src/secret/secret_driver.c | 59 +++- 1 files changed, 58 insertions(+), 1 deletions(-) diff --git a/src/secre

Re: [libvirt] NFS over RDMA small block DIRECT_IO bug

2012-09-05 Thread Avi Kivity
On 09/04/2012 03:04 PM, Myklebust, Trond wrote: > On Tue, 2012-09-04 at 11:31 +0200, Andrew Holway wrote: >> Hello. >> >> # Avi Kivity avi(a)redhat recommended I copy kvm in on this. It would also >> seem relevent to libvirt. # >> >> I have a Centos 6.2 server and Centos 6.2 client. >> >> [root

Re: [libvirt] [PATCH 2/6] list: Implement RPC calls for virConnectListAllSecrets

2012-09-05 Thread Peter Krempa
On 09/05/12 08:28, Osier Yang wrote: The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllSecrets. * src/remote/remote_driver.c: Add remote driver handle

Re: [libvirt] [RFC PATCH v1 2/2] tests: Add tests for gluster protocol based network disks support

2012-09-05 Thread Jiri Denemark
On Thu, Aug 23, 2012 at 16:31:52 +0530, Harsh Prateek Bora wrote: > > Signed-off-by: Harsh Prateek Bora > --- > tests/qemuargv2xmltest.c | 1 + > .../qemuxml2argv-disk-drive-network-gluster.args | 1 + > .../qemuxml2argv-disk-drive-network-gluster.xml| 33 > +++

Re: [libvirt] [PATCH 1/6] list: Define new API virConnectListAllSecrets

2012-09-05 Thread Peter Krempa
On 09/05/12 08:28, Osier Yang wrote: This is to list the secret objects. No flags are supported include/libvirt/libvirt.h.in: Declare enum virConnectListAllSecretFlags and virConnectListAllSecrets. python/generator.py: Skip auto-generating src/driver.h: (virDrvConn

Re: [libvirt] [RFC PATCH v1 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-09-05 Thread Jiri Denemark
On Thu, Aug 23, 2012 at 16:31:51 +0530, Harsh Prateek Bora wrote: > Qemu accepts gluster protocol as supported storage backend beside others. > This patch allows users to specify disks on gluster backends like this: > > > > > > > > > > Note: In the

[libvirt] [PATCHv2 0/3] Add range checking for scheduler tunables

2012-09-05 Thread Peter Krempa
This series adds range checking to cpu scheduler tunables when changed using the API. V2 contains a new patch that avoids changing all tunables from virsh when setting just a single one. Peter Krempa (3): qemu: clean up qemuSetSchedulerParametersFlags() qemu: Add range checking for scheduler t

[libvirt] [PATCHv2 1/3] qemu: clean up qemuSetSchedulerParametersFlags()

2012-09-05 Thread Peter Krempa
This patch tries to clean the code up a little bit and shorten very long lines. The apparent semantic change from moving the condition before calling the setter function is a non-issue here as the setter function is a no-op when called with both arguments zero. --- Diff to v1: - enhanced commit me

[libvirt] [PATCHv1 3/3] virsh: Update only changed scheduler tunables

2012-09-05 Thread Peter Krempa
When setting the cpu tunables in virsh you are able to update only one of them. Virsh while doing the update updated all of the tunables with old values except for the one changed. This is unfortunate as it: a) might overwrite some other change by a race condition (unprobable) b) fails with range

[libvirt] [PATCHv2 2/3] qemu: Add range checking for scheduler tunables when changed by API

2012-09-05 Thread Peter Krempa
The quota and period tunables for cpu scheduler accept only a certain range of values. When changing the live configuration invalid values get rejected. This check is not performed when changing persistent config. This patch adds a separate range check, that improves error messages when changing l

Re: [libvirt] [RFC] [PATCH v2 1/6] add configure option --with-fuse for libvirt

2012-09-05 Thread Daniel P. Berrange
On Wed, Sep 05, 2012 at 05:41:40PM +0800, Gao feng wrote: > Hi Daniel & Glauber > > 于 2012年07月31日 17:27, Daniel P. Berrange 写道: > > Hi Gao, > > > > I'm wondering if you are planning to attend the Linux Plumbers Conference > > in San Diego at the end of August ? Glauber is going to be giving a ta

Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

2012-09-05 Thread Gene Czarcinski
On 09/04/2012 11:12 AM, Eric Blake wrote: On 08/22/2012 11:47 AM, Eric Blake wrote: On 08/22/2012 11:39 AM, Eric Blake wrote: On 08/22/2012 10:59 AM, Gene Czarcinski wrote: As I said in a previous message, dnsmasq is forwarding a number of queries upstream that should not be done. There still

Re: [libvirt] [Libguestfs] compile libguestfs 1.19.35

2012-09-05 Thread Daniel P. Berrange
On Wed, Sep 05, 2012 at 12:46:26PM +0100, Richard W.M. Jones wrote: > [The context for libvirt users is how to let people do > 'make install' without having conflicts with installed copies > of packages.] > > On Wed, Sep 05, 2012 at 07:39:37AM -0400, Whit Blauvelt wrote: > > On Wed, Sep 05, 2012 a

Re: [libvirt] [Libguestfs] compile libguestfs 1.19.35

2012-09-05 Thread Richard W.M. Jones
On Wed, Sep 05, 2012 at 12:46:26PM +0100, Richard W.M. Jones wrote: > [The context for libvirt users is how to let people do > 'make install' without having conflicts with installed copies > of packages.] > > On Wed, Sep 05, 2012 at 07:39:37AM -0400, Whit Blauvelt wrote: > > On Wed, Sep 05, 2012 a

Re: [libvirt] [Libguestfs] compile libguestfs 1.19.35

2012-09-05 Thread Richard W.M. Jones
[The context for libvirt users is how to let people do 'make install' without having conflicts with installed copies of packages.] On Wed, Sep 05, 2012 at 07:39:37AM -0400, Whit Blauvelt wrote: > On Wed, Sep 05, 2012 at 08:07:09AM +0100, Richard W.M. Jones wrote: > > > It is possible to run 'make

Re: [libvirt] [PATCH 0/7 v4] Atomic API to list networks

2012-09-05 Thread Osier Yang
Public git repo for easy reviewing (patches for all of the APIs are applied). git://github.com/OsierYang/libvirt.git On 2012年09月04日 23:55, Osier Yang wrote: v3 - v4: - Just rebase on top, and split the API from the big set Osier Yang (7): list: Define new API virConnectListAllNetworks

[libvirt] [PATCH 3/6] parallels: return up-to-date info about domains

2012-09-05 Thread Dmitry Guryanov
Use parallelsGetDomain/'s in functions for domain lookup and information obtaining. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 185 +++-- 1 files changed, 95 insertions(+), 90 deletions(-) diff --git a/src/parallels/parallels_driver.c

[libvirt] [PATCH 5/6] parallels: don't use stored domains list in parallelsDomainDefineXML

2012-09-05 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 40 +++-- 1 files changed, 16 insertions(+), 24 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 1f6dcef..72e32ff 100644 --- a/src/parallels

[libvirt] [PATCH 4/6] parallels: don't track domain state in global domains list

2012-09-05 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 101 ++ 1 files changed, 16 insertions(+), 85 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index de3d53f..1f6dcef 100644 --- a/src/parallel

[libvirt] [PATCH 1/2] parallels: remove unused member 'os' from parallelsDomObj

2012-09-05 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_utils.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_utils.h b/src/parallels/parallels_utils.h index 082ee75..6a27003 100644 --- a/src/parallels/parallels_utils.h +++ b/src/parallels/pa

[libvirt] [PATCH 1/6] parallels: return a new list of domains from parallelsLoadDomains

2012-09-05 Thread Dmitry Guryanov
Make parallelsLoadDomains more useful, so that it will not touch list in global _parallelsConn structure, but allocate and return a new one instead. So it can be used later, when you need the up-to-date list of VMs instead of the one stored in _parallelsConn structure. Also rename parallelsLoadDo

[libvirt] [PATCH 0/6] parallels: get rid of cached domains list in driver

2012-09-05 Thread Dmitry Guryanov
The goal of this patch series is to get rid of cached domains list. Someone can create several connections to libvirt or change something (start VM or change parameters) using native tools. In such case first connection will not get any info about those changes. There is no way to check, if the cac

[libvirt] [PATCH 2/2] parallels: fix memory allocation

2012-09-05 Thread Dmitry Guryanov
size of videos array must be increased. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 06a75b3..c14f616 100644 --- a/src/parall

[libvirt] [PATCH 2/6] parallels: rename uuidstr to __uuidstr in macro

2012-09-05 Thread Dmitry Guryanov
Rename the variable in macro to avoid warnings "declaration of 'uuidstr' shadows a previous local" in the future. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/parallels/parallels_driver

[libvirt] [PATCH 6/6] parallels: remove domains list from _parallelsConn structure

2012-09-05 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c |5 - src/parallels/parallels_utils.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 72e32ff..96a8ab1 100644 --- a/src/

Re: [libvirt] [PATCH v2 0/4] Add cpu hotplug support to libvirt.

2012-09-05 Thread Daniel P. Berrange
On Wed, Sep 05, 2012 at 05:19:22PM +0800, Tang Chen wrote: > Hi Viktor, > > On 09/05/2012 04:54 PM, Viktor Mihajlovski wrote: > >I posted a comment some time ago about that. If you do not mount the > >cpuset controller, i.e for RHEL 6 you delete the cpuset line from > >/etc/cgconfig, the CPU affin

Re: [libvirt] [PATCH v2 0/4] Add cpu hotplug support to libvirt.

2012-09-05 Thread Daniel P. Berrange
On Wed, Sep 05, 2012 at 01:32:12PM +0800, Tang Chen wrote: > Hi Srivatsa, Daniel, > > Thank you very much for all the comments. :) > > On 09/05/2012 04:57 AM, Srivatsa S. Bhat wrote: > >I had posted a Linux kernel patchset[1] some time ago to expose another > >file so that we can distinguish betw

Re: [libvirt] [RFC] [PATCH v2 1/6] add configure option --with-fuse for libvirt

2012-09-05 Thread Gao feng
Hi Daniel & Glauber 于 2012年07月31日 17:27, Daniel P. Berrange 写道: > Hi Gao, > > I'm wondering if you are planning to attend the Linux Plumbers Conference > in San Diego at the end of August ? Glauber is going to be giving a talk > on precisely the subject of virtualizing /proc in containers which

[libvirt] S4 event, states and caveats

2012-09-05 Thread Martin Kletzander
Hi everybody, I'm going to add support for S4 event for libvirt and I'm thinking for a while now how to do that, so I'd like to discuss this here on the list before doing something wrong and mainly to eliminate bothering you guys with reviews of PATCH v5 etc. QEMU emits SUSPEND_DISK event before

Re: [libvirt] [PATCH] Remove explicit dependency on ceph RPM

2012-09-05 Thread Jiri Denemark
On Wed, Sep 05, 2012 at 09:00:20 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The libvirt storage driver uses librbd.so for its functionality. > RPM will automatically add a dependency on the library, so there > is no need to have an explicit dependency on the ceph RPM itself

[libvirt] [libvirt-designer][PATCH 2/4] domain: Introduce disk support

2012-09-05 Thread Michal Privoznik
Let users add either files or devices as disks to domains. --- libvirt-designer/libvirt-designer-domain.c | 244 libvirt-designer/libvirt-designer-domain.h |7 + libvirt-designer/libvirt-designer.sym |3 + 3 files changed, 254 insertions(+), 0 deletions(-

[libvirt] [libvirt-designer][PATCH 0/4] Basic disk & interface support

2012-09-05 Thread Michal Privoznik
with small example called virtxml Michal Privoznik (4): Load osinfo DB on init domain: Introduce disk support examples: Create an example of usage program domain: Introduce interface support .gitignore |1 + Makefile.am

[libvirt] [libvirt-designer][PATCH 4/4] domain: Introduce interface support

2012-09-05 Thread Michal Privoznik
Let users add NICs to domains. --- examples/virtxml.c | 96 libvirt-designer/libvirt-designer-domain.c | 53 +++ libvirt-designer/libvirt-designer-domain.h |3 + libvirt-designer/libvirt-designer.sym |1 + 4 files ch

[libvirt] [libvirt-designer][PATCH 3/4] examples: Create an example of usage program

2012-09-05 Thread Michal Privoznik
--- .gitignore |1 + Makefile.am |2 +- configure.ac |6 +- examples/Makefile.am | 23 examples/virtxml.c | 334 ++ 5 files changed, 364 insertions(+), 2 deletions(-) create mode 100644 examples/Makef

[libvirt] [libvirt-designer][PATCH 1/4] Load osinfo DB on init

2012-09-05 Thread Michal Privoznik
as we need this DB later to find an OS or hypervisor and supported devices. --- libvirt-designer/Makefile.am |1 + libvirt-designer/libvirt-designer-domain.c |5 +++- libvirt-designer/libvirt-designer-internal.h | 30 ++ libvirt-designer/libvirt-

Re: [libvirt] [PATCH v2 0/4] Add cpu hotplug support to libvirt.

2012-09-05 Thread Tang Chen
Hi Viktor, On 09/05/2012 04:54 PM, Viktor Mihajlovski wrote: I posted a comment some time ago about that. If you do not mount the cpuset controller, i.e for RHEL 6 you delete the cpuset line from /etc/cgconfig, the CPU affinity isn't controlled by cgroups any more but uses the old mechanism, whi

[libvirt] Libvir JNA report SIGSEGV

2012-09-05 Thread Benjamin Wang (gendwang)
Hi, I try to verify the JNA with concurrent situation but meet some problems. The following is my example code: public static void testcase1() throws LibvirtException { Connect conn=null; Connect conn1=null; //connect to the hypervisor conn = new Connect

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-05 Thread Daniel P. Berrange
On Mon, Sep 03, 2012 at 02:23:24PM +0800, liguang wrote: > allow migration even domain isn't active by > inserting some stubs to tunnel migration path. > > Signed-off-by: liguang > --- > src/qemu/qemu_driver.c|2 +- > src/qemu/qemu_migration.c | 181 > +++

Re: [libvirt] [PATCH v2 0/4] Add cpu hotplug support to libvirt.

2012-09-05 Thread Viktor Mihajlovski
On 09/05/2012 07:32 AM, Tang Chen wrote: 4) Make libvirt not use cpuset cgroup. - For now, seems impossable. sched_setaffinity() behaves properly, which assumes the repluged cpu is the same one unpluged before. (am I right ?) But with cgroup's control, we cannot resolve th

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-05 Thread Daniel P. Berrange
On Wed, Sep 05, 2012 at 08:51:05AM +0800, liguang wrote: > 在 2012-09-04二的 12:12 +0100,Daniel P. Berrange写道: > > On Mon, Sep 03, 2012 at 02:23:24PM +0800, liguang wrote: > > > allow migration even domain isn't active by > > > inserting some stubs to tunnel migration path. > > > > > > Signed-off-by:

[libvirt] [PATCH] Remove explicit dependency on ceph RPM

2012-09-05 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The libvirt storage driver uses librbd.so for its functionality. RPM will automatically add a dependency on the library, so there is no need to have an explicit dependency on the ceph RPM itself. This allows newer Fedora distros to avoid pulling in the huge ceph RPM, in

Re: [libvirt] [PATCH] maint: avoid doubled name in syntax check failures

2012-09-05 Thread Martin Kletzander
On 09/05/2012 01:41 AM, Eric Blake wrote: > Based on a similar gnulib patch; use of $(_sc_search_regexp) > already injects $(ME) into any output messages, so a failure > of these rules would look like this, pre-patch: > > ./config.status: ./config.status: use virStrToLong_*, not strtol variants >