Re: [libvirt] [V2 PATCH 0/3] Transport Open vSwitch per-port data during live migration

2012-09-14 Thread Kyle Mestery (kmestery)
On Sep 14, 2012, at 9:04 PM, Laine Stump wrote: > On 09/14/2012 03:01 PM, Kyle Mestery wrote: >> This series of commits has the end goal of allowing per-port data stored >> in the Open vSwitch DB to be transported during live migration. This is >> done by first providing a generic infrastructure fo

Re: [libvirt] [V2 PATCH 0/3] Transport Open vSwitch per-port data during live migration

2012-09-14 Thread Laine Stump
On 09/14/2012 03:01 PM, Kyle Mestery wrote: > This series of commits has the end goal of allowing per-port data stored > in the Open vSwitch DB to be transported during live migration. This is > done by first providing a generic infrastructure for transporting network > data, adding some utility fu

Re: [libvirt] [PATCH 1/3] qemu_migration: Add hooks to transport network data during migration

2012-09-14 Thread Laine Stump
On 09/14/2012 12:38 PM, Kyle Mestery wrote: > Add the ability for the Qemu V3 migration protocol to > include transporting network configuration. A generic > framework is proposed with this patch to allow for the > transfer of opaque data. > > Signed-off-by: Kyle Mestery > --- > src/qemu/qemu_mig

Re: [libvirt] [PATCH v2 1/4] config: Introduce for SPICE graphics

2012-09-14 Thread Eric Blake
[adding qemu] On 09/14/2012 11:47 AM, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 07:34:50PM +0200, Michal Privoznik wrote: >> With this element users will control how SPICE >> server behaves upon migration. For now, there's >> just one attribute 'seamless' turning seamless >> migration on

Re: [libvirt] [PATCH] build: fix missing include

2012-09-14 Thread Eric Blake
On 10/14/2012 09:01 AM, Dwight Engen wrote: Your computer is a month in the future! Amazing. I hope you don't mind that I told git to use today's date > virNWFilterSnoopAdjustPoll() uses a struct pollfd but poll.h is never included > nwfilter/nwfilter_dhcpsnoop.c:1297: error: 'struct pollfd' de

Re: [libvirt] [PATCH 6/7 v6] virsh: Don't motify the const string

2012-09-14 Thread Peter Krempa
On 09/14/12 18:21, Osier Yang wrote: This improve helper vshStringToArray to accept const string as argument instead. To not convert the const string when using vshStringToArray, and thus avoid motifying it. --- tools/virsh-domain.c |7 +++ tools/virsh-pool.c |3 ++- tools/virsh

[libvirt] [PATCH 3/3] qemu_migration: Transport OVS per-port data during live migration

2012-09-14 Thread Kyle Mestery
Transport Open vSwitch per-port data during live migration by using the utility functions virNetDevOpenvswitchGetMigrateData() and virNetDevOpenvswitchSetMigrateData(). Signed-off-by: Kyle Mestery --- src/qemu/qemu_migration.c | 23 +++ 1 file changed, 19 insertions(+), 4 del

[libvirt] [PATCH 1/3] Add hooks to transport network data during migration

2012-09-14 Thread Kyle Mestery
Add the ability for the Qemu V3 migration protocol to include transporting network configuration. A generic framework is proposed with this patch to allow for the transfer of opaque data. Signed-off-by: Kyle Mestery --- src/qemu/qemu_migration.c | 276

[libvirt] [V2 PATCH 0/3] Transport Open vSwitch per-port data during live migration

2012-09-14 Thread Kyle Mestery
This series of commits has the end goal of allowing per-port data stored in the Open vSwitch DB to be transported during live migration. This is done by first providing a generic infrastructure for transporting network data, adding some utility functions specific to Open vSwitch, and hooking the tw

[libvirt] [PATCH 2/3] openvswitch: Add utility functions for getting and setting OVS per-port data

2012-09-14 Thread Kyle Mestery
Add utility functions for Open vSwitch to both save per-port data before a live migration, and restore the per-port data after a live migration. Signed-off-by: Kyle Mestery --- src/libvirt_private.syms| 2 ++ src/util/virnetdevopenvswitch.c | 71 +

Re: [libvirt] [PATCH v2 0/4] qemu SPICE migration

2012-09-14 Thread Doug Goldstein
On Fri, Sep 14, 2012 at 12:34 PM, Michal Privoznik wrote: > With the latest qemu, we are a step closer to seamless migration. > However, libvirt needs to lend a helping hand. > OT: But this made me think. Do we need to expose SPICE support via capabilities? And potentially VNC? -- Doug Goldste

Re: [libvirt] [PATCH v2 1/4] config: Introduce for SPICE graphics

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 07:34:50PM +0200, Michal Privoznik wrote: > With this element users will control how SPICE > server behaves upon migration. For now, there's > just one attribute 'seamless' turning seamless > migration on/off/default. Ewww, no. This information is a related to a API operati

[libvirt] [PATCH v2 1/4] config: Introduce for SPICE graphics

2012-09-14 Thread Michal Privoznik
With this element users will control how SPICE server behaves upon migration. For now, there's just one attribute 'seamless' turning seamless migration on/off/default. --- docs/formatdomain.html.in | 10 ++ docs/schemas/domaincommon.rng | 11 +++ src/conf/domain_conf.c

[libvirt] [PATCH v2 3/4] qemu: Create SPICE migration test

2012-09-14 Thread Michal Privoznik
to reflect new extension. --- .../qemuxml2argv-graphics-spice-migration.args |7 .../qemuxml2argv-graphics-spice-migration.xml | 36 tests/qemuxml2argvtest.c |4 ++ 3 files changed, 47 insertions(+), 0 deletions(-) create mod

[libvirt] [PATCH v2 4/4] qemu: wait for SPICE to migrate

2012-09-14 Thread Michal Privoznik
Recently, there have been some improvements made to qemu so it supports seamless migration or something very close to it. However, it requires libvirt interaction. Once qemu is migrated, the SPICE server needs to send its internal state to the destination. Once it's done, it fires SPICE_MIGRATE_COM

[libvirt] [PATCH v2 0/4] qemu SPICE migration

2012-09-14 Thread Michal Privoznik
With the latest qemu, we are a step closer to seamless migration. However, libvirt needs to lend a helping hand. Michal Privoznik (4): config: Introduce for SPICE graphics qemu: Implement new seamless attribute qemu: Create SPICE migration test qemu: wait for SPICE to migrate docs/forma

[libvirt] [PATCH v2 2/4] qemu: Implement new seamless attribute

2012-09-14 Thread Michal Privoznik
This requires adding "seamless-migration='on|off'" to the qemu command line. It is turned on by default (if not running on ancient qemu that doesn't support this). --- src/qemu/qemu_capabilities.c |3 +++ src/qemu/qemu_capabilities.h |1 + src/qemu/qemu_command.c | 14 ++

[libvirt] [PATCH RFC] network: define new API virNetworkUpdate

2012-09-14 Thread Laine Stump
This patch adds a new public API virNetworkUpdate that will permit updating an existing network configuration without requiring that the network be destroyed/restarted for the changes to take effect. --- an example of use: to add a dhcp host entry to network "net", you would do this: virNetw

Re: [libvirt] [PATCH 0/3] Transport Open vSwitch per-port data during live migration

2012-09-14 Thread Kyle Mestery (kmestery)
I found an issue with this patch when migrating VMs without OVS interfaces. I'm fixing that issue now, and will be posting V2 of this series soon. On Sep 14, 2012, at 11:38 AM, Kyle Mestery wrote: > This series of commits has the end goal of allowing per-port data stored > in the Open vSwitch DB

Re: [libvirt] [PATCH 1/2] build: allow building with newer glibc-headers and -O0

2012-09-14 Thread Christophe Fergeau
On Fri, Sep 14, 2012 at 11:05:05AM -0600, Eric Blake wrote: > On 09/12/2012 09:42 AM, Christophe Fergeau wrote: > > Fix copied from libvirt, commit by Eric Blake. > > > > glibc 2.15 (on Fedora 17) coupled with explicit disabling of > > optimization during development dies a painful death: > > > >

Re: [libvirt] [PATCH 1/2] build: allow building with newer glibc-headers and -O0

2012-09-14 Thread Eric Blake
On 09/12/2012 09:42 AM, Christophe Fergeau wrote: > Fix copied from libvirt, commit by Eric Blake. > > glibc 2.15 (on Fedora 17) coupled with explicit disabling of > optimization during development dies a painful death: > > /usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires >

[libvirt] [PATCH 0/3] Transport Open vSwitch per-port data during live migration

2012-09-14 Thread Kyle Mestery
This series of commits has the end goal of allowing per-port data stored in the Open vSwitch DB to be transported during live migration. This is done by first providing a generic infrastructure for transporting network data, adding some utility functions specific to Open vSwitch, and hooking the tw

[libvirt] [PATCH 2/3] openvswitch: Add utility functions for getting and setting OVS per-port data

2012-09-14 Thread Kyle Mestery
Add utility functions for Open vSwitch to both save per-port data before a live migration, and restore the per-port data after a live migration. Signed-off-by: Kyle Mestery --- src/libvirt_private.syms| 2 ++ src/util/virnetdevopenvswitch.c | 71 +

[libvirt] [PATCH 3/3] qemu_migration: Transport OVS per-port data during live migration

2012-09-14 Thread Kyle Mestery
Transport Open vSwitch per-port data during live migration by using the utility functions virNetDevOpenvswitchGetMigrateData() and virNetDevOpenvswitchSetMigrateData(). Signed-off-by: Kyle Mestery --- src/qemu/qemu_migration.c | 23 +-- 1 file changed, 21 insertions(+), 2 del

[libvirt] [PATCH 1/3] qemu_migration: Add hooks to transport network data during migration

2012-09-14 Thread Kyle Mestery
Add the ability for the Qemu V3 migration protocol to include transporting network configuration. A generic framework is proposed with this patch to allow for the transfer of opaque data. Signed-off-by: Kyle Mestery --- src/qemu/qemu_migration.c | 260

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-14 Thread Shradha Shah
On 09/14/2012 12:05 PM, Laine Stump wrote: > On 09/13/2012 06:16 AM, Shradha Shah wrote: >> On 09/11/2012 08:07 PM, Laine Stump wrote: >>> If so, one issue I have is that one of the devices (the >>> pci-passthrough?) doesn't have its guest-side PCI address visible >>> anywhere in the guest's XML, d

[libvirt] [PATCH 6/7 v6] virsh: Don't motify the const string

2012-09-14 Thread Osier Yang
This improve helper vshStringToArray to accept const string as argument instead. To not convert the const string when using vshStringToArray, and thus avoid motifying it. --- tools/virsh-domain.c |7 +++ tools/virsh-pool.c |3 ++- tools/virsh.c| 10 ++ tools/virsh.h

Re: [libvirt] [PATCH 6/7 v5] virsh: Don't motify the const string

2012-09-14 Thread Osier Yang
On 2012年09月14日 21:32, Peter Krempa wrote: On 09/13/12 08:56, Osier Yang wrote: This improve helper vshStringToArray to accept const string as s/improve/improves/ argument instead. To not convert the const string when using vshStringToArray, and thus avoid motifying it. I'd write the last s

Re: [libvirt] [PATCH 1/2] build: allow building with newer glibc-headers and -O0

2012-09-14 Thread Michal Privoznik
On 12.09.2012 17:42, Christophe Fergeau wrote: > Fix copied from libvirt, commit by Eric Blake. > > glibc 2.15 (on Fedora 17) coupled with explicit disabling of > optimization during development dies a painful death: > > /usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires > co

Re: [libvirt] [libvirt-designer][PATCH v2 3/4] virtxml: Detect platform from libvirt connection URI

2012-09-14 Thread Christophe Fergeau
Looks good, ACK (would have been easier to review with the load_osinfo changes in a separate patch, this would have halved the size of the patch doing real code changes I think). Christophe On Thu, Sep 13, 2012 at 04:04:30PM +0200, Michal Privoznik wrote: > as in nearly all cases users will insta

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Daniel Veillard
On Fri, Sep 14, 2012 at 05:36:10PM +0200, Wido den Hollander wrote: > On 09/14/2012 04:59 PM, Daniel Veillard wrote: [...] > >http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.pom > >doesn't seems to have any section though ... > > > > Hmm, indeed. That's

Re: [libvirt] [PATCH 04/23] Fix 3 broken test cases which were mistakenly raising errors

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 09:49:29AM -0600, Eric Blake wrote: > On 09/14/2012 09:20 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Several test cases were mistakenly raising errors due to the > > QEMU_CAPS_KVM flag being missed. > > --- > > tests/qemuxml2argvtest.c | 6 +++---

Re: [libvirt] [PATCH 04/23] Fix 3 broken test cases which were mistakenly raising errors

2012-09-14 Thread Eric Blake
On 09/14/2012 09:51 AM, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 09:49:29AM -0600, Eric Blake wrote: >> On 09/14/2012 09:20 AM, Daniel P. Berrange wrote: >>> From: "Daniel P. Berrange" >>> >>> Several test cases were mistakenly raising errors due to the >>> QEMU_CAPS_KVM flag being miss

Re: [libvirt] [PATCH 06/23] Add missing 'goto error' in QEMU command line building

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 09:50:26AM -0600, Eric Blake wrote: > On 09/14/2012 09:20 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > If reporting case of a binary not supporting KVM or kQEMU, libvirt > > forgot to jump to the error branch for cleanup > > --- > > src/qemu/qemu_c

Re: [libvirt] [libvirt-designer][PATCH v2 4/4] Implement resources setting

2012-09-14 Thread Christophe Fergeau
On Thu, Sep 13, 2012 at 04:04:31PM +0200, Michal Privoznik wrote: > Users can choose between minimum and recommended values > for VCPU count and amount of RAM. Moreover, recommended > values should inherit defaults from the minimum. > --- > examples/virtxml.c | 12 >

Re: [libvirt] [PATCH 06/23] Add missing 'goto error' in QEMU command line building

2012-09-14 Thread Eric Blake
On 09/14/2012 09:20 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > If reporting case of a binary not supporting KVM or kQEMU, libvirt > forgot to jump to the error branch for cleanup > --- > src/qemu/qemu_command.c | 2 ++ > 1 file changed, 2 insertions(+) My ACK from last time

Re: [libvirt] [PATCH 04/23] Fix 3 broken test cases which were mistakenly raising errors

2012-09-14 Thread Eric Blake
On 09/14/2012 09:20 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Several test cases were mistakenly raising errors due to the > QEMU_CAPS_KVM flag being missed. > --- > tests/qemuxml2argvtest.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > +++ b/tests/qemu

Re: [libvirt] [PATCH 05/23] Fix initialization of virCommandPtr when creating QEMU argv

2012-09-14 Thread Eric Blake
On 09/14/2012 09:20 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > If the qemuBuildCommandLine method raised an error before the > virCommandPtr instance was created, the local var would not > be initialized, resulting in a possible SEGV in the error > cleanup branch. Also add som

Re: [libvirt] [libvirt-designer][PATCH v2 2/4] virtxml: Detect OS from given ISO

2012-09-14 Thread Christophe Fergeau
Hey, Looks good, a few cosmetic comments below, On Thu, Sep 13, 2012 at 04:04:29PM +0200, Michal Privoznik wrote: > In some cases telling OS version is redundant as ISO image > with specified OS is passed some arguments later as disk. > Don't require --os then. > --- > examples/virtxml.c | 110

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Wido den Hollander
On 09/14/2012 04:59 PM, Daniel Veillard wrote: On Fri, Sep 14, 2012 at 04:18:21PM +0200, Wido den Hollander wrote: On 09/13/2012 02:19 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10,

Re: [libvirt] [libvirt-designer][PATCH v2 1/4] virtxml: Init variables

2012-09-14 Thread Christophe Fergeau
On Thu, Sep 13, 2012 at 04:04:28PM +0200, Michal Privoznik wrote: > to avoid their uninitialized usage. ACK, I've sent a similar patch but forgot --subject-prefix for some reason... https://www.redhat.com/archives/libvir-list/2012-September/msg00804.html Let's use yours. Christophe > --- > exam

[libvirt] [PATCH 10/23] Remove xenner support

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 158 +-- 1 file changed, 47 insertions(+), 111 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 7f8a311..262bbdf 10

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Daniel Veillard
On Fri, Sep 14, 2012 at 04:18:21PM +0200, Wido den Hollander wrote: > On 09/13/2012 02:19 PM, Daniel Veillard wrote: > >On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: > >>On 09/10/2012 03:23 PM, Daniel Veillard wrote: > >>>On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Holl

[libvirt] [PATCH 21/23] Move command/event capabilities detection out of QEMU monitor code

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The qemuMonitorSetCapabilities() API is used to initialize the QMP protocol capabilities. It has since been abused to initialize some libvirt internal capabilities based on command/event existance too. Move the latter code out into qemuCapsProbeQMP() in the QEMU capabil

[libvirt] [PATCH 23/23] Add support for detecting capablities using QMP commands

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Start a QEMU process using $QEMU -S -no-user-config -nodefconfig -nodefaults \ -nographic -M none -qmp stdio and talk QMP over stdio to discover what capabilities the binary supports. This works for QEMU 1.2.0 or later and for older QEMU automatically fall

[libvirt] [PATCH 07/23] Remove probing of machine types when canonicalizing XML

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When XML for a new guest is received, the machine type is immediately canonicalized into the version specific name. This involves probing QEMU for supported machine types. Replace this probing with a lookup of the machine types in the (hopefully cached) qemuCapsPtr obje

[libvirt] [PATCH 12/23] Add a qemuMonitorGetVersion() method for QMP query-version command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetVersion() method to support invocation of the 'query-version' JSON monitor command. No HMP equivalent is provided, since this will only be used for QEMU >= 1.2 Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor.c | 24 ++

[libvirt] [PATCH 16/23] Add a qemuMonitorGetEvents() method for QMP query-events command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetEvents() method to support invocation of the 'query-events' JSON monitor command. No HMP equivalent is required, since this will only be used when JSON is available The existing qemuMonitorJSONCheckEvents() method is refactored to use this new m

[libvirt] [PATCH 18/23] Add a qemuMonitorGetObjectProps() method for QMP device-list-properties command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetObjectProps() method to support invocation of the 'device-list-properties' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU >= 1.2 Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor.c

[libvirt] [PATCH 11/23] Refactor guest init to support qemu-system-i386 binary too

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 163 +++ 1 file changed, 89 insertions(+), 74 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 262bbdf..ef7f266 100

[libvirt] [PATCH 06/23] Add missing 'goto error' in QEMU command line building

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If reporting case of a binary not supporting KVM or kQEMU, libvirt forgot to jump to the error branch for cleanup --- src/qemu/qemu_command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index fd37c31..56bb1b3

[libvirt] [PATCH 09/23] Make qemuCapsProbeMachineTypes & qemuCapsProbeCPUModels static

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The qemuCapsProbeMachineTypes & qemuCapsProbeCPUModels methods do not need to be invoked directly anymore. Make them static and refactor them to directly populate the qemuCapsPtr object Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 238

[libvirt] [PATCH 04/23] Fix 3 broken test cases which were mistakenly raising errors

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Several test cases were mistakenly raising errors due to the QEMU_CAPS_KVM flag being missed. --- tests/qemuxml2argvtest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 0ab1e54..d2594

[libvirt] [PATCH 20/23] Remove some unused includes in QEMU code

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The qemu monitor does not require qemu_conf.h, and the qemu capabilities code actually wants bitmap.h Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_monitor.c | 1 - src/qemu/qemu_monitor.h | 1 - 3 files changed, 1

[libvirt] [PATCH 19/23] Add a qemuMonitorGetTargetArch() method for QMP query-target command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetTargetArch() method to support invocation of the 'query-target' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU >= 1.2 Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor.c | 21 ++

[libvirt] [PATCH 14/23] Add a qemuMonitorGetCPUDefinitions method for QMP query-cpu-definitions command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetCPUDefinitions() method to support invocation of the 'query-cpu-definitions' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU >= 1.2 Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor.c

[libvirt] [PATCH 01/23] Add a qemu capabilities cache manager

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Introduce a qemuCapsCachePtr object to provide a global cache of capabilities for QEMU binaries. The cache auto-populates on first request for capabilities about a binary, and will auto-refresh if the binary has changed since a previous cache was populated Signed-off-b

[libvirt] [PATCH 17/23] Add a qemuMonitorGetObjectTypes() method for QMP qom-list-types command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetObjectTypes() method to support invocation of the 'qom-list' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU >= 1.2 Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor.c | 22 +

[libvirt] [PATCH 08/23] Remove probing of CPU models when launching QEMU guests

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When launching a QEMU guest the binary is probed to discover the list of supported CPU names. Remove this probing with a simple lookup of CPU models in the qemuCapsPtr object. This avoids another invocation of the QEMU binary during the startup path. As a nice benefit

[libvirt] [PATCH 13/23] Add a qemuMonitorGetMachines() method for QMP query-machines command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetMachines() method to support invocation of the 'query-machines' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU >= 1.2 Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor.c | 30 +

[libvirt] [PATCH 22/23] Refactor qemuCapsParseDeviceStr to work from data tables

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently the qemuCapsParseDeviceStr method has a bunch of open coded string searches/comparisons to detect devices and their properties. Soon this data will be obtained from QMP queries instead of -device help output. Maintaining the list of device and properties in tw

[libvirt] [PATCH 15/23] Add a qemuMonitorGetCommands() method for QMP query-commands command

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a new qemuMonitorGetCPUCommands() method to support invocation of the 'query-cpu-definitions' JSON monitor command. No HMP equivalent is required, since this will only be used when JSON is available The existing qemuMonitorJSONCheckCommands() method is refactored t

[libvirt] [PATCH 02/23] Switch over to use cache for building QEMU capabilities

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When building up a virCapsPtr instance, the QEMU driver was copying the list of machine types across from the previous virCapsPtr instance, if the QEMU binary had not changed. Replace this ad-hoc caching of data with use of the new qemuCapsCache global cache. Signed-of

[libvirt] [PATCH 03/23] Remove probing of flags when launching QEMU guests

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Remove all use of the existing APIs for querying QEMU capability flags. Instead obtain a qemuCapsPtr object from the global cache. This avoids the execution of 'qemu -help' (and related commands) when launching new guests. Signed-off-by: Daniel P. Berrange --- src/qe

[libvirt] [PATCH 00/23 v2] Add support for detecting QEMU capabilities via QMP

2012-09-14 Thread Daniel P. Berrange
This is a followup to https://www.redhat.com/archives/libvir-list/2012-September/msg00643.html As of QEMU 1.2 libvirt is supposed to stop parsing -help and instead use various QMP commands to detect capabilities. Before we can do this, the current QEMU capabilities code needs a serious cleanup

[libvirt] [PATCH 05/23] Fix initialization of virCommandPtr when creating QEMU argv

2012-09-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If the qemuBuildCommandLine method raised an error before the virCommandPtr instance was created, the local var would not be initialized, resulting in a possible SEGV in the error cleanup branch. Also add some debugging of the method params --- src/qemu/qemu_command.c

Re: [libvirt] [PATCHv2 3/4] qemu: add -sandbox to command line if requested

2012-09-14 Thread Corey Bryant
On 09/12/2012 04:03 AM, Ján Tomko wrote: --- src/qemu/qemu_command.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a83d6de..c50c306 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c

[libvirt] [PATCH] build: fix missing include

2012-09-14 Thread Dwight Engen
virNWFilterSnoopAdjustPoll() uses a struct pollfd but poll.h is never included nwfilter/nwfilter_dhcpsnoop.c:1297: error: 'struct pollfd' declared inside parameter list --- src/nwfilter/nwfilter_dhcpsnoop.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/nwfilter/nwfi

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Daniel Veillard
On Fri, Sep 14, 2012 at 04:18:21PM +0200, Wido den Hollander wrote: > On 09/13/2012 02:19 PM, Daniel Veillard wrote: > >On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: > >>On 09/10/2012 03:23 PM, Daniel Veillard wrote: > >>>On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Holl

[libvirt] [PATCH 2/6] node_memory: Wire up the RPC protocol

2012-09-14 Thread Osier Yang
* src/rpc/gendispatch.pl: (virNodeSetMemoryParameters is the the special one which needs a connection object as the first argument, improve the generator to support it). * daemon/remote.c: (Implement the server side handler for virDomainGetMemoryParameters) * src/remote/remote_driver.c: (Impl

Re: [libvirt] [Qemu-devel] [PATCH v4 0/5] Per-guest configurable user/group for QEMU processes

2012-09-14 Thread Corey Bryant
On 09/14/2012 09:51 AM, Daniel P. Berrange wrote: On Fri, Sep 14, 2012 at 09:31:26AM -0400, Corey Bryant wrote: On 09/14/2012 04:40 AM, Daniel P. Berrange wrote: On Tue, Sep 11, 2012 at 02:13:38PM -0400, Corey Bryant wrote: Are there any other requirements that need to be taken care of to

[libvirt] [PATCH 5/6] node_memory: Expose the APIs to virsh

2012-09-14 Thread Osier Yang
New command node-memory-tune to get/set the node memory parameters, only two parameters are allowed to set (pages_to_scan, and sleep_millisecs, see documents in this patch for more details). Example of node-memory-tune's output: Shared memory: pages_to_scan 100 sleep_millisecs 2

[libvirt] [PATCH 6/6] node_memory: Expose the APIs to Python bindings

2012-09-14 Thread Osier Yang
* python/libvirt-override-api.xml: (Add document to describe the APIs). * python/libvirt-override.c: (Implement the API wrappers manually) --- python/libvirt-override-api.xml | 13 python/libvirt-override.c | 125 +++ 2 files changed, 138 inserti

[libvirt] [PATCH 3/6] node_memory: Implement the internal APIs

2012-09-14 Thread Osier Yang
Only implemented for linux platform. * src/nodeinfo.h: (Declare node{Get,Set}MemoryParameters) * src/nodeinfo.c: (Implement node{Get,Set}MemoryParameters) * src/libvirt_private.syms: (Export those two new internal APIs to private symbols) --- src/libvirt_private.syms |2 + src/nodeinfo.c

[libvirt] [PATCH 0/6 v3] New APIs to get/set node memory tunables

2012-09-14 Thread Osier Yang
v1: https://www.redhat.com/archives/libvir-list/2012-September/msg00517.html v1 - v2: * Rename virNode{Get,Set}SharedMemoryParameters to virNode{Get,Set}MemoryParameters, in case of we could add more node memory tunables in future. v2 - v3: * Add prefix "shm_" to the shared memory pa

[libvirt] [PATCH 1/6] node_memory: Define the APIs to get/set memory parameters

2012-09-14 Thread Osier Yang
* include/libvirt/libvirt.h.in: (Add macros for the param fields, declare the APIs). * src/driver.h: (New methods for the driver struct) * src/libvirt.c: (Implement the public APIs) * src/libvirt_public.syms: (Export the public symbols) --- include/libvirt/libvirt.h.in | 63 +++

[libvirt] [PATCH 4/6] node_memory: Support get/set memory parameters for drivers

2012-09-14 Thread Osier Yang
Including QEMU, LXC, UML, XEN drivers. --- src/lxc/lxc_driver.c |2 ++ src/qemu/qemu_driver.c |2 ++ src/uml/uml_driver.c |2 ++ src/xen/xen_driver.c |3 +++ 4 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index ff11c

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Daniel Veillard
On Fri, Sep 14, 2012 at 04:01:55PM +0200, Wido den Hollander wrote: > On 09/13/2012 02:19 PM, Daniel Veillard wrote: [...] > >>Come to think of it, a 0.4.9 release under MIT would however be > >>preferable for CloudStack 4.0. > > > > Okay, you get it, it's out, can you check maven is working, > >

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Wido den Hollander
On 09/13/2012 02:19 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote: On 09/10/2012 02:29 PM, Daniel Veillard wrote: any idea how to

[libvirt] [PATCHv2] svirt: Label serial sockets (RHBZ#853393).

2012-09-14 Thread Richard W.M. Jones
From: "Richard W.M. Jones" libvirt skips labelling these, for unknown reasons. This breaks libguestfs. Adding this and some SELinux rules (RHBZ#857453) fixes everything for me. --- src/security/security_selinux.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/secu

Re: [libvirt] [PATCH] svirt: Label serial sockets (RHBZ#853393).

2012-09-14 Thread Richard W.M. Jones
On Fri, Sep 14, 2012 at 02:40:39PM +0100, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 02:31:44PM +0100, Richard W.M. Jones wrote: > > From: "Richard W.M. Jones" > > > > libvirt skips labelling these, for unknown reasons. This breaks > > libguestfs. Adding this and some SELinux rules (RH

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Wido den Hollander
On 09/13/2012 02:19 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote: On 09/10/2012 02:29 PM, Daniel Veillard wrote: any idea how to

Re: [libvirt] [PATCH 7/7 v5] list: Use virConnectListAllNodeDevices in virsh

2012-09-14 Thread Peter Krempa
On 09/13/12 08:59, Osier Yang wrote: tools/virsh-nodedev.c: * vshNodeDeviceSorter to sort node devices by name * vshNodeDeviceListFree to free the node device objects list. * vshNodeDeviceListCollect to collect the node device objects, trying to use new API first, fall back to old

Re: [libvirt] [Qemu-devel] [PATCH v4 0/5] Per-guest configurable user/group for QEMU processes

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 09:31:26AM -0400, Corey Bryant wrote: > > > On 09/14/2012 04:40 AM, Daniel P. Berrange wrote: > >On Tue, Sep 11, 2012 at 02:13:38PM -0400, Corey Bryant wrote: > >>Are there any other requirements that need to be taken care of to > >>enable execution of QEMU guests under se

Re: [libvirt] [PATCH] svirt: Label serial sockets (RHBZ#853393).

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 02:31:44PM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > libvirt skips labelling these, for unknown reasons. This breaks > libguestfs. Adding this and some SELinux rules (RHBZ#857453) fixes > everything for me. > --- > src/security/security_selinux.c

Re: [libvirt] [Qemu-devel] [PATCH v4 0/5] Per-guest configurable user/group for QEMU processes

2012-09-14 Thread Corey Bryant
On 09/14/2012 04:40 AM, Daniel P. Berrange wrote: On Tue, Sep 11, 2012 at 02:13:38PM -0400, Corey Bryant wrote: Are there any other requirements that need to be taken care of to enable execution of QEMU guests under separate unprivileged user IDs (ie. DAC isolation)? At this point, this patch

[libvirt] [PATCH] svirt: Label serial sockets (RHBZ#853393).

2012-09-14 Thread Richard W.M. Jones
From: "Richard W.M. Jones" libvirt skips labelling these, for unknown reasons. This breaks libguestfs. Adding this and some SELinux rules (RHBZ#857453) fixes everything for me. --- src/security/security_selinux.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git

Re: [libvirt] [PATCH 6/7 v5] virsh: Don't motify the const string

2012-09-14 Thread Peter Krempa
On 09/13/12 08:56, Osier Yang wrote: This improve helper vshStringToArray to accept const string as s/improve/improves/ argument instead. To not convert the const string when using vshStringToArray, and thus avoid motifying it. I'd write the last sentence as: This avoids modifying const str

Re: [libvirt] [PATCH] qemu: fix uninitialized variable in qemuParseCommandLine

2012-09-14 Thread Osier Yang
On 2012年09月14日 20:55, Osier Yang wrote: On 2012年09月14日 20:50, Ján Tomko wrote: Newly added if branch for kvm_pv_eoi did not set the ret variable. --- src/qemu/qemu_command.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c i

Re: [libvirt] [PATCH 1/5] list: Define new API virConnectListAllSecrets

2012-09-14 Thread Peter Krempa
On 09/14/12 11:47, Peter Krempa wrote: On 09/14/12 10:38, Osier Yang wrote: This is to list the secret objects. No flags are supported This statement isn't accurate as you added filtering flags. include/libvirt/libvirt.h.in: Declare enum virConnectListAllSecretFlags

Re: [libvirt] [PATCH 1/7 v5] list: Define new API virConnectListAllNodeDevices

2012-09-14 Thread Peter Krempa
On 09/13/12 08:54, Osier Yang wrote: This is to list the node device objects, supports to filter the results by capability types. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNodeDeviceFlags and virConnectListAllNodeDevices. python/generator.py: Skip

Re: [libvirt] [PATCH] qemu: fix uninitialized variable in qemuParseCommandLine

2012-09-14 Thread Osier Yang
On 2012年09月14日 20:50, Ján Tomko wrote: Newly added if branch for kvm_pv_eoi did not set the ret variable. --- src/qemu/qemu_command.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ec825bc..d0c8e22 100644 --- a

[libvirt] [PATCH] qemu: fix uninitialized variable in qemuParseCommandLine

2012-09-14 Thread Ján Tomko
Newly added if branch for kvm_pv_eoi did not set the ret variable. --- src/qemu/qemu_command.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ec825bc..d0c8e22 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qem

Re: [libvirt] [PATCH 11/20] Introduce a API for creating QEMU capabilities for a binary

2012-09-14 Thread Daniel P. Berrange
On Thu, Sep 13, 2012 at 10:31:09AM -0600, Eric Blake wrote: > On 09/11/2012 08:11 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Introduce a qemuCapsNewForBinary() API which creates a new > > QEMU capabilities object, populated with data relating to > > a specific QEMU binar

Re: [libvirt] [PATCH 5/5] list: Use virConnectListAllSecrets in virsh

2012-09-14 Thread Peter Krempa
On 09/14/12 10:38, Osier Yang wrote: This introduce four new options for secret-list, to filter the s/introduce/introduces/ returned secrets by whether it's ephemeral or not, and/or by whether it's private or not. * tools/virsh-secret.c: (New helper vshSecretSorter, vshSecretListFree, and

Re: [libvirt] [PATCH v4 6/9] use virBitmap to store cpumask info.

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 03:47:01PM +0800, Hu Tao wrote: > --- > src/conf/domain_conf.c | 24 +--- > src/conf/domain_conf.h |3 +-- > src/lxc/lxc_controller.c | 14 ++ > src/parallels/parallels_driver.c |3 +-- > src/qemu/qemu_

Re: [libvirt] [PATCH v4 9/9] remove virDomainCpuSetFormat and virDomainCpuSetParse

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 03:47:04PM +0800, Hu Tao wrote: > virBitmap is recommanded to store cpuset info, and > virBitmapFormat/virBitmapParse can do the format/parse > jobs. > --- > src/conf/domain_conf.c | 196 > -- > src/conf/domain_conf.h |7

Re: [libvirt] [PATCH v4 8/9] use virBitmap to store nodeinfo.

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 03:47:03PM +0800, Hu Tao wrote: > --- > src/nodeinfo.c | 26 +++--- > src/nodeinfo.h |6 +++--- > src/qemu/qemu_driver.c | 19 --- > 3 files changed, 26 insertions(+), 25 deletions(-) ACK Daniel -- |: http://be

Re: [libvirt] [PATCH v4 7/9] use virBitmap to store cells' cpumask info.

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 03:47:02PM +0800, Hu Tao wrote: > --- > src/conf/cpu_conf.c | 17 ++--- > src/conf/cpu_conf.h |3 ++- > src/qemu/qemu_command.c | 43 +++ > 3 files changed, 15 insertions(+), 48 deletions(-) ACK Daniel --

Re: [libvirt] [PATCH v4 5/9] use virBitmap to store numa nodemask info.

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 03:47:00PM +0800, Hu Tao wrote: > --- > src/conf/domain_conf.c | 24 +--- > src/conf/domain_conf.h |2 +- > src/lxc/lxc_controller.c | 25 > src/parallels/parallels_driver.c |2 +- > src/qemu/qemu_cgroup.c

  1   2   >