Re: [libvirt] RFC: Check if the host device is assignable earlier

2012-09-25 Thread Osier Yang
On 2012年09月25日 00:32, Eric Blake wrote: On 09/23/2012 10:29 PM, Osier Yang wrote: Hi, I think we already got enough bugs which are about try to assign a host device, then it fails for not assignable, clearly this try and then fails approach is not nice. The reason for not assignable can be

Re: [libvirt] [libvirt-designer][PATCH v2] Create manpage for virtxml

2012-09-25 Thread Michal Privoznik
On 24.09.2012 17:40, Christophe Fergeau wrote: ACK Christophe Thanks. I've pushed the whole set. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Update how to compile with -Werror

2012-09-25 Thread Jiri Denemark
On Mon, Sep 24, 2012 at 18:44:34 -0500, Doug Goldstein wrote: --enable-compile-warnings=error has been renamed to --enable-werror so update the HACKING and the hacking.html to reflect that. --- docs/hacking.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH v9] support offline migration

2012-09-25 Thread liguang
original migration did not aware of offline case, so, try to support offline migration quietly (did not disturb original migration) by pass VIR_MIGRATE_OFFLINE flag to migration APIs if only the domain is really inactive, and migration process will not puzzled by domain offline and exit

Re: [libvirt] [PATCH v3] qemu: wait for SPICE to migrate

2012-09-25 Thread Michal Privoznik
On 20.09.2012 13:29, Michal Privoznik wrote: Recently, there have been some improvements made to qemu so it supports seamless migration or something very close to it. However, it requires libvirt interaction. Once qemu is migrated, the SPICE server needs to send its internal state to the

[libvirt] [PATCH 2/2] Test for QEMU 1.0.1 help screen parsing added

2012-09-25 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman dmi...@daynix.com --- tests/qemuhelpdata/qemu-1.0.1| 261 +++ tests/qemuhelpdata/qemu-1.0.1-device | 138 ++ tests/qemuhelptest.c | 73 ++ 3 files changed, 472 insertions(+) create

[libvirt] [PATCH 1/2] Incorrect help screen parsing for QEMU 1.0.1 package fixed

2012-09-25 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman dmi...@daynix.com --- src/qemu/qemu_capabilities.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ae26967..d2580b6 100644 --- a/src/qemu/qemu_capabilities.c +++

[libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Dmitry Fleytman
This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard To QEMU emulator version 1.0,1 (qemu-kvm-1.0.1), Copyright (c) 2003-2008 Fabrice Bellard Comma in version

Re: [libvirt] [libvirt-glib] Don't call g_set_error with a NULL format string

2012-09-25 Thread Christophe Fergeau
Ping? On Wed, Sep 12, 2012 at 04:22:04PM +0200, Christophe Fergeau wrote: From: Jovanka Gulicoska jovanka.gulico...@gmail.com The format string passed to g_set_error cannot be NULL or a runtime warning will be printed. --- libvirt-gobject/libvirt-gobject-stream.c | 6 -- 1 file

Re: [libvirt] [PATCH] storage: Add timeout for iscsi volume's stable path discovery

2012-09-25 Thread Osier Yang
On 2012年09月25日 00:42, Eric Blake wrote: On 09/24/2012 02:44 AM, Osier Yang wrote: It might need some time till the LUN's stable path shows up on initiator host, and although the time window is not foreseeable, as a better than nothing fix, this patch adds timeout for the stable path discovery

Re: [libvirt] [libvirt-glib] Add a few more getters/setters to VNC/SPICE configuration

2012-09-25 Thread Christophe Fergeau
Ping? On Wed, Sep 12, 2012 at 03:55:25PM +0200, Christophe Fergeau wrote: Hey, This patch series implements a few more getters/setters for GVirConfigDomainGraphicsVnc and GVirConfigDomainGraphicsSpice. They will be useful in GNOME Boxes as the same is currently achieved through XPath use.

Re: [libvirt] [PATCH] Update how to compile with -Werror

2012-09-25 Thread Martin Kletzander
On 09/25/2012 09:38 AM, Jiri Denemark wrote: On Mon, Sep 24, 2012 at 18:44:34 -0500, Doug Goldstein wrote: --enable-compile-warnings=error has been renamed to --enable-werror so update the HACKING and the hacking.html to reflect that. --- docs/hacking.html.in |2 +- 1 files changed, 1

Re: [libvirt] [PATCH v2 1/2] security: also parse user/group names instead of just IDs for DAC labels

2012-09-25 Thread Peter Krempa
On 09/20/12 23:07, Marcelo Cerri wrote: The DAC driver is missing parsing of group and user names for DAC labels and currently just parses uid and gid. This patch extends it to support names, so the following security label definition is now valid: seclabel type='static' model='dac'

Re: [libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-09-25 Thread Christophe Fergeau
Ping? Can this patch go as is, or do we want to go all the way to switching to GInitable as Marc-André suggested in http://www.mail-archive.com/libvir-list@redhat.com/msg59538.html ? Christophe On Tue, Jul 24, 2012 at 05:49:21PM +0200, Christophe Fergeau wrote: For objects with a subtype

Re: [libvirt] [PATCH] Update how to compile with -Werror

2012-09-25 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 11:16:32 +0200, Martin Kletzander wrote: On 09/25/2012 09:38 AM, Jiri Denemark wrote: On Mon, Sep 24, 2012 at 18:44:34 -0500, Doug Goldstein wrote: --enable-compile-warnings=error has been renamed to --enable-werror so update the HACKING and the hacking.html to

Re: [libvirt] [PATCH v2 2/2] doc: update description about security labels on formatdomain.html

2012-09-25 Thread Peter Krempa
On 09/20/12 23:07, Marcelo Cerri wrote: This patch adds a brief description about labels for each security driver. --- docs/formatdomain.html.in | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) ACK. Peter -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] Update how to compile with -Werror

2012-09-25 Thread Martin Kletzander
On 09/25/2012 11:23 AM, Jiri Denemark wrote: On Tue, Sep 25, 2012 at 11:16:32 +0200, Martin Kletzander wrote: On 09/25/2012 09:38 AM, Jiri Denemark wrote: On Mon, Sep 24, 2012 at 18:44:34 -0500, Doug Goldstein wrote: --enable-compile-warnings=error has been renamed to --enable-werror so

Re: [libvirt] [PATCH] Update how to compile with -Werror

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 09:38:42AM +0200, Jiri Denemark wrote: On Mon, Sep 24, 2012 at 18:44:34 -0500, Doug Goldstein wrote: --enable-compile-warnings=error has been renamed to --enable-werror so update the HACKING and the hacking.html to reflect that. --- docs/hacking.html.in |2 +-

Re: [libvirt] TSC scaling interface to management

2012-09-25 Thread Daniel P. Berrange
On Wed, Sep 12, 2012 at 12:39:39PM -0300, Marcelo Tosatti wrote: HW TSC scaling is a feature of AMD processors that allows a multiplier to be specified to the TSC frequency exposed to the guest. KVM also contains provision to trap TSC (KVM: Infrastructure for software and hardware based

Re: [libvirt] [PATCH V1 1/2] nwfilter: Add names for more l4 protocols

2012-09-25 Thread Stefan Berger
On 09/10/2012 12:58 PM, Stefan Berger wrote: Did anyone have time to look at these 2 patches ? Stefan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC] [PATCH v3 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-09-25 Thread Daniel P. Berrange
On Mon, Sep 24, 2012 at 12:43:42PM -0600, Eric Blake wrote: On 09/24/2012 12:24 PM, Doug Goldstein wrote: On Mon, Sep 10, 2012 at 9:54 PM, Gao feng gaof...@cn.fujitsu.com wrote: add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc. With help from

Re: [libvirt] [PATCH v1 2/2] command: Change virCommandAddEnv so it replaces existing environment variables.

2012-09-25 Thread Richard W.M. Jones
On Mon, Sep 24, 2012 at 02:24:23PM -0600, Eric Blake wrote: On 09/24/2012 02:16 PM, Richard W.M. Jones wrote: Unfortunately this patch does not fix the bug, but it now fails in a different, and stranger way: libvir: error : libvirtd quit during handshake: Input/output error In this

Re: [libvirt] [PATCHv2] qemu: Avoid holding the driver lock in trivial snapshot API's

2012-09-25 Thread Michal Privoznik
On 24.09.2012 22:45, Peter Krempa wrote: In most of the snapshot API's there's no need to hold the driver lock the whole time. This patch adds helper functions that get the domain object in functions that don't require the driver lock and simplifies call paths from snapshot-related API's.

Re: [libvirt] [libvirt-glib] Don't call g_set_error with a NULL format string

2012-09-25 Thread Michal Privoznik
On 12.09.2012 16:22, Christophe Fergeau wrote: From: Jovanka Gulicoska jovanka.gulico...@gmail.com The format string passed to g_set_error cannot be NULL or a runtime warning will be printed. --- libvirt-gobject/libvirt-gobject-stream.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [libvirt] [libvirt-glib 4/4] config: Add a few GVirConfigDomainGraphicsSpice getters

2012-09-25 Thread Michal Privoznik
On 12.09.2012 15:55, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 16 libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Michal Privoznik
On 12.09.2012 15:55, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++

Re: [libvirt] [libvirt-glib 3/4] config: Add a few GVirConfigDomainGraphicsVnc getters

2012-09-25 Thread Michal Privoznik
On 12.09.2012 15:55, Christophe Fergeau wrote: --- .../libvirt-gconfig-domain-graphics-vnc.c | 24 ++ .../libvirt-gconfig-domain-graphics-vnc.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym| 3 +++ 3 files changed, 30 insertions(+)

Re: [libvirt] [libvirt-glib 2/4] config: Add 2 more setters to GVirConfigDomainDisplayVnc

2012-09-25 Thread Michal Privoznik
On 12.09.2012 15:55, Christophe Fergeau wrote: Implement gvir_config_domain_graphics_vnc_set_listen and gvir_config_domain_graphics_vnc_set_socket. --- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 19 +++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 6

Re: [libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-09-25 Thread Michal Privoznik
On 25.09.2012 11:21, Christophe Fergeau wrote: Ping? Can this patch go as is, or do we want to go all the way to switching to GInitable as Marc-André suggested in http://www.mail-archive.com/libvir-list@redhat.com/msg59538.html ? Christophe I think your approach is good, however

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Christophe Fergeau
On Tue, Sep 25, 2012 at 02:07:39PM +0200, Michal Privoznik wrote: Hey, libvirt supports listen on IP address or a network and I think we need to distinguish these. As I understand it, to listen on an IP address or a network, you'd use a listen child node to the graphics node. This patch sets

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Michal Privoznik
On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard To QEMU emulator version 1.0,1 (qemu-kvm-1.0.1), Copyright

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Dmitry Fleytman
Hi, Michal, This is qemu 1.0.1 rpm from fc17. Sent from my iPad On Sep 25, 2012, at 2:49 PM, Michal Privoznik mpriv...@redhat.com wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Michal Privoznik
On 25.09.2012 14:47, Christophe Fergeau wrote: On Tue, Sep 25, 2012 at 02:07:39PM +0200, Michal Privoznik wrote: Hey, libvirt supports listen on IP address or a network and I think we need to distinguish these. As I understand it, to listen on an IP address or a network, you'd use a

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Christophe Fergeau
On Tue, Sep 25, 2012 at 03:04:47PM +0200, Michal Privoznik wrote: On 25.09.2012 14:47, Christophe Fergeau wrote: It seems it's not necessarily an IP address but this can be a hostname if the .rng is to be trusted. I had in the back of my mind the possibility of adding _set_listen_address

Re: [libvirt] [PATCH 07/12] Split priority conversion from virLogOutputToSyslog

2012-09-25 Thread Daniel P. Berrange
On Thu, Sep 20, 2012 at 08:24:06PM +0200, Miloslav Trmač wrote: No change in functionality; the newly separated virLogPrioritySyslog function will be used by the next patch. Signed-off-by: Miloslav Trmač m...@redhat.com --- src/util/logging.c | 36 +--- 1

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Michal Privoznik
On 25.09.2012 15:01, Dmitry Fleytman wrote: Hi, Michal, This is qemu 1.0.1 rpm from fc17. Yup, it's a bug. A typo to be exact. Here is the build: http://koji.fedoraproject.org/koji/buildinfo?buildID=344872 and if you'd download and unpack .src.rpm and subsequently qemu-kvm-1.0.1.tar.gz

Re: [libvirt] [PATCH 00/12] Structured syslog (Lumberjack/CEE) support

2012-09-25 Thread Daniel P. Berrange
On Thu, Sep 20, 2012 at 08:23:59PM +0200, Miloslav Trmač wrote: This patch set adds structured syslog support to libvirt. In short, the idea is to embed JSON in a syslog record. This format is used in a new log output type called syslog/json. Example syslog/json record (line-wrapped for

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Dmitry Fleytman
Since this rpm released already, should fix be made anyway? Should it just treat that comma as a dot (current fix is a little bit more sophisticated)? On Tue, Sep 25, 2012 at 3:45 PM, Michal Privoznik mpriv...@redhat.comwrote: On 25.09.2012 15:01, Dmitry Fleytman wrote: Hi, Michal, This

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 04:03:35PM +0200, Dmitry Fleytman wrote: Since this rpm released already, should fix be made anyway? No, the QEMU update should be unpushed, or obsoleted by a new one that works. Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [PATCH 06/12] Pass the raw log message to each virLogOutputFunc

2012-09-25 Thread Daniel P. Berrange
On Thu, Sep 20, 2012 at 08:24:05PM +0200, Miloslav Trmač wrote: In addition to the preformatted text line, pass the raw message as well, to allow the output functions to use a different output format. This patch only changes the interface and callers, an output function that takes advantage

Re: [libvirt] [PATCH 09/12] Add a JSON properties parameter to virLog{, V}Message

2012-09-25 Thread Daniel P. Berrange
On Thu, Sep 20, 2012 at 08:24:08PM +0200, Miloslav Trmač wrote: ... and update all users. No change in functionality, the parameter will be used in later patches. Signed-off-by: Miloslav Trmač m...@redhat.com --- src/uml/uml_conf.c | 2 +- src/util/logging.c | 13 +

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 02:47:30PM +0200, Christophe Fergeau wrote: On Tue, Sep 25, 2012 at 02:07:39PM +0200, Michal Privoznik wrote: Hey, libvirt supports listen on IP address or a network and I think we need to distinguish these. As I understand it, to listen on an IP address or a

Re: [libvirt] [RFC] [PATCH v3 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-09-25 Thread Daniel P. Berrange
On Mon, Sep 24, 2012 at 10:36:16AM +0800, Gao feng wrote: 于 2012年09月17日 13:04, Gao feng 写道: 于 2012年09月11日 10:54, Gao feng 写道: add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc. With help from Daniel Signed-off-by: Gao feng

Re: [libvirt] [PATCH 00/12]

2012-09-25 Thread Daniel P. Berrange
On Wed, Sep 12, 2012 at 05:28:53PM +0100, Daniel P. Berrange wrote: An update of https://www.redhat.com/archives/libvir-list/2012-August/msg00618.html Mostly this is a rebase to latest GIT. Alot of the questions raised with review last time bogged down on whether the APIs were design in

Re: [libvirt] [PATCH 00/23 v2] Add support for detecting QEMU capabilities via QMP

2012-09-25 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 04:20:50PM +0100, Daniel P. Berrange wrote: This is a followup to https://www.redhat.com/archives/libvir-list/2012-September/msg00643.html As of QEMU 1.2 libvirt is supposed to stop parsing -help and instead use various QMP commands to detect capabilities. Before

Re: [libvirt] [PATCH] Update how to compile with -Werror

2012-09-25 Thread Eric Blake
On 09/25/2012 03:30 AM, Martin Kletzander wrote: On 09/25/2012 11:23 AM, Jiri Denemark wrote: On Tue, Sep 25, 2012 at 11:16:32 +0200, Martin Kletzander wrote: On 09/25/2012 09:38 AM, Jiri Denemark wrote: On Mon, Sep 24, 2012 at 18:44:34 -0500, Doug Goldstein wrote:

Re: [libvirt] [PATCHv2] qemu: Avoid holding the driver lock in trivial snapshot API's

2012-09-25 Thread Peter Krempa
On 09/25/12 13:44, Michal Privoznik wrote: On 24.09.2012 22:45, Peter Krempa wrote: In most of the snapshot API's there's no need to hold the driver lock the whole time. This patch adds helper functions that get the domain object in functions that don't require the driver lock and simplifies

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Christophe Fergeau
On Tue, Sep 25, 2012 at 03:32:10PM +0100, Daniel P. Berrange wrote: I wonder if we should simply not expose an API for the listen= attribute at all. Only have APIs for reading/writing the listen elements [...] IOW, I don't think applications should need to care about the listen= attribute at

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Eric Blake
On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0

Re: [libvirt] [PATCH] Update how to compile with -Werror

2012-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2012 at 10:11 AM, Eric Blake ebl...@redhat.com wrote: On 09/25/2012 03:30 AM, Martin Kletzander wrote: On 09/25/2012 11:23 AM, Jiri Denemark wrote: On Tue, Sep 25, 2012 at 11:16:32 +0200, Martin Kletzander wrote: On 09/25/2012 09:38 AM, Jiri Denemark wrote: On Mon, Sep 24,

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2012 at 7:49 AM, Michal Privoznik mpriv...@redhat.com wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package Version line changed from QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman wrote: This patch fixes incorrect help screen parsing for QEMU 1.0.1 package

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: On 25.09.2012 10:58, Dmitry Fleytman

Re: [libvirt] [PATCH 00/23 v2] Add support for detecting QEMU capabilities via QMP

2012-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2012 at 10:03 AM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Sep 14, 2012 at 04:20:50PM +0100, Daniel P. Berrange wrote: This is a followup to https://www.redhat.com/archives/libvir-list/2012-September/msg00643.html As of QEMU 1.2 libvirt is supposed to stop

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-25 Thread Eric Blake
On 09/25/2012 11:01 AM, Daniel P. Berrange wrote: I agree, it smells very much like a QEMU/distro bug to me. It is an upstream bug: https://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02527.html Distros should probably be backporting that particular patch, but there's still the

Re: [libvirt] [PATCH v3] qemu: wait for SPICE to migrate

2012-09-25 Thread Daniel P. Berrange
On Thu, Sep 20, 2012 at 01:29:21PM +0200, Michal Privoznik wrote: Recently, there have been some improvements made to qemu so it supports seamless migration or something very close to it. However, it requires libvirt interaction. Once qemu is migrated, the SPICE server needs to send its

[libvirt] [PATCH v3 00/20] Add support for detecting QEMU capabilities via QM

2012-09-25 Thread Daniel P. Berrange
This is an update to: https://www.redhat.com/archives/libvir-list/2012-September/msg01051.html Changes in v3: - Already merged patches dropped - Rebased to latest git -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 11/20] Add a qemuMonitorGetCPUDefinitions method for QMP query-cpu-definitions command

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new qemuMonitorGetCPUDefinitions() method to support invocation of the 'query-cpu-definitions' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU = 1.2 Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH v3 19/20] Refactor qemuCapsParseDeviceStr to work from data tables

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently the qemuCapsParseDeviceStr method has a bunch of open coded string searches/comparisons to detect devices and their properties. Soon this data will be obtained from QMP queries instead of -device help output. Maintaining the list of device

[libvirt] [PATCH v3 10/20] Add a qemuMonitorGetMachines() method for QMP query-machines command

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new qemuMonitorGetMachines() method to support invocation of the 'query-machines' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU = 1.2 Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH v3 12/20] Add a qemuMonitorGetCommands() method for QMP query-commands command

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new qemuMonitorGetCPUCommands() method to support invocation of the 'query-cpu-definitions' JSON monitor command. No HMP equivalent is required, since this will only be used when JSON is available The existing qemuMonitorJSONCheckCommands()

[libvirt] [PATCH v3 18/20] Move command/event capabilities detection out of QEMU monitor code

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The qemuMonitorSetCapabilities() API is used to initialize the QMP protocol capabilities. It has since been abused to initialize some libvirt internal capabilities based on command/event existance too. Move the latter code out into qemuCapsProbeQMP()

[libvirt] [PATCH v3 13/20] Add a qemuMonitorGetEvents() method for QMP query-events command

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new qemuMonitorGetEvents() method to support invocation of the 'query-events' JSON monitor command. No HMP equivalent is required, since this will only be used when JSON is available The existing qemuMonitorJSONCheckEvents() method is refactored

[libvirt] [PATCH v3 02/20] Switch over to use cache for building QEMU capabilities

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When building up a virCapsPtr instance, the QEMU driver was copying the list of machine types across from the previous virCapsPtr instance, if the QEMU binary had not changed. Replace this ad-hoc caching of data with use of the new qemuCapsCache global

[libvirt] [PATCH v3 16/20] Add a qemuMonitorGetTargetArch() method for QMP query-target command

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new qemuMonitorGetTargetArch() method to support invocation of the 'query-target' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU = 1.2 Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH v3 14/20] Add a qemuMonitorGetObjectTypes() method for QMP qom-list-types command

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new qemuMonitorGetObjectTypes() method to support invocation of the 'qom-list' JSON monitor command. No HMP equivalent is required, since this will only be present for QEMU = 1.2 Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH v3 01/20] Add a qemu capabilities cache manager

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Introduce a qemuCapsCachePtr object to provide a global cache of capabilities for QEMU binaries. The cache auto-populates on first request for capabilities about a binary, and will auto-refresh if the binary has changed since a previous cache was

[libvirt] [PATCH v3 17/20] Remove some unused includes in QEMU code

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The qemu monitor does not require qemu_conf.h, and the qemu capabilities code actually wants bitmap.h Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_monitor.c | 1 -

[libvirt] [PATCH v3 03/20] Remove probing of flags when launching QEMU guests

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Remove all use of the existing APIs for querying QEMU capability flags. Instead obtain a qemuCapsPtr object from the global cache. This avoids the execution of 'qemu -help' (and related commands) when launching new guests. Signed-off-by: Daniel P.

[libvirt] [PATCH v3 09/20] Add a qemuMonitorGetVersion() method for QMP query-version command

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new qemuMonitorGetVersion() method to support invocation of the 'query-version' JSON monitor command. No HMP equivalent is provided, since this will only be used for QEMU = 1.2 Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH v3 05/20] Remove probing of CPU models when launching QEMU guests

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When launching a QEMU guest the binary is probed to discover the list of supported CPU names. Remove this probing with a simple lookup of CPU models in the qemuCapsPtr object. This avoids another invocation of the QEMU binary during the startup path.

[libvirt] [PATCH v3 20/20] Add support for detecting capablities using QMP commands

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Start a QEMU process using $QEMU -S -no-user-config -nodefconfig -nodefaults \ -nographic -M none -qmp stdio and talk QMP over stdio to discover what capabilities the binary supports. This works for QEMU 1.2.0 or later and for older QEMU

[libvirt] [PATCH v3 08/20] Refactor guest init to support qemu-system-i386 binary too

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_capabilities.c | 163 +++ 1 file changed, 89 insertions(+), 74 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v3 07/20] Remove xenner support

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_capabilities.c | 158 +-- 1 file changed, 47 insertions(+), 111 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v3 06/20] Make qemuCapsProbeMachineTypes qemuCapsProbeCPUModels static

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The qemuCapsProbeMachineTypes qemuCapsProbeCPUModels methods do not need to be invoked directly anymore. Make them static and refactor them to directly populate the qemuCapsPtr object Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [RFC] [PATCH v3 2/6] add fuse support for libvirt lxc

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 11, 2012 at 10:54:48AM +0800, Gao feng wrote: this patch addes fuse support for libvirt lxc. we can use fuse filesystem to generate sysinfo dynamically, So we can isolate /proc/meminfo,cpuinfo and so on through fuse filesystem. we mount fuse filesystem for every container.the

Re: [libvirt] [RFC] [PATCH v3 5/6] make /proc/meminfo isolate with host through fuse

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 11, 2012 at 10:54:51AM +0800, Gao feng wrote: with this patch,container's meminfo will be shown based on containers' mem cgroup. Right now,it's impossible to virtualize all values in meminfo, I collect some values such as MemTotal,MemFree,Cached,Active,

Re: [libvirt] [RFC] [PATCH v3 5/6] make /proc/meminfo isolate with host through fuse

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 11, 2012 at 10:54:51AM +0800, Gao feng wrote: with this patch,container's meminfo will be shown based on containers' mem cgroup. Right now,it's impossible to virtualize all values in meminfo, I collect some values such as MemTotal,MemFree,Cached,Active,

[libvirt] [PATCHv7.7 9/9] blockjob: relabel entire existing chain

2012-09-25 Thread Eric Blake
When using block copy to pivot over to a new chain, the backing files for the new chain might still need labeling (particularly if the user passes --reuse-ext with a relative backing file name). Relabeling a file that is already labeled won't hurt, so this just labels the entire chain at the

Re: [libvirt] [PATCH v3 01/20] Add a qemu capabilities cache manager

2012-09-25 Thread Eric Blake
On 09/25/2012 11:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a qemuCapsCachePtr object to provide a global cache of capabilities for QEMU binaries. The cache auto-populates on first request for capabilities about a binary, and will auto-refresh if

Re: [libvirt] [PATCH v3 01/20] Add a qemu capabilities cache manager

2012-09-25 Thread Doug Goldstein
On Tue, Sep 25, 2012 at 12:59 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a qemuCapsCachePtr object to provide a global cache of capabilities for QEMU binaries. The cache auto-populates on first request for capabilities about a

Re: [libvirt] [PATCH v3 01/20] Add a qemu capabilities cache manager

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 01:43:30PM -0600, Eric Blake wrote: On 09/25/2012 11:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a qemuCapsCachePtr object to provide a global cache of capabilities for QEMU binaries. The cache auto-populates on first

[libvirt] [PATCH] Fix start of containers with custom root filesystem

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com A prefix change to unmount the SELinux filesystem broke starting of LXC containers with a custom root filesystem Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_container.c | 5 - 1 file changed, 4 insertions(+), 1

[libvirt] [PATCH] Simplify some redundant locking while unref'ing objects

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com There is no need to hold the mutex when unref'ing virObject instances Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/conf/domain_conf.c | 4 +--- src/qemu/qemu_driver.c | 4 ++-- src/rpc/virnetserver.c | 3 --- 3 files changed, 3

[libvirt] [PATCH] Convert virLXCMonitor to use virObject

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Remove custom reference counting from virLXCMonitor, using virObject instead Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_monitor.c | 63 +-- src/lxc/lxc_monitor.h | 4 +---

[libvirt] [PATCH 4/5] Move virProcessKill into virprocess.{h,c}

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com There are a number of process related functions spread across multiple files. Start to consolidate them by creating a virprocess.{c,h} file Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/Makefile.am | 1 +

[libvirt] [PATCH 0/5] Consolidate all code for process interaction

2012-09-25 Thread Daniel P. Berrange
This series pulls a handful of functions out of command.c and util.c, into virprocess.c, in preparation for adding new process management functions. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/5] Rename virCommandTranslateStatus to virProcessTranslateStatus

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virCommand prefix was inappropriate because the API does not use any virCommandPtr object instance. This API closely related to waitpid/exit, so use virProcess as the prefix Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH 1/5] Rename virKillProcess to virProcessKill

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Changing naming to follow the convention of object followed by action Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_agent.c | 2 +- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_process.c | 2 +- src/uml/uml_driver.c|

[libvirt] [PATCH 5/5] Move virProcess{Kill, Abort, TranslateStatus} into virprocess.{c, h}

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Continue consolidation of process functions by moving some helpers out of command.{c,h} into virprocess.{c,h} Signed-off-by: Daniel P. Berrange berra...@redhat.com --- daemon/libvirtd.c| 1 + daemon/remote.c | 1 + po/POTFILES.in

[libvirt] [PATCH 2/5] Rename virPid{Abort, Wait} to virProcess{Abort, Wait}

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Change Pid to Process to align with the virProcessKill API naming prefix Signed-off-by: Daniel P. Berrange berra...@redhat.com --- daemon/libvirtd.c| 2 +- src/libvirt_private.syms | 4 ++-- src/lxc/lxc_container.c | 4 ++--

[libvirt] [PATCH] Remove pointless virLXCProcessMonitorDestroy method

2012-09-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Asynchronously setting priv-mon to NULL was pointless, just remove the destroy callback entirely. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_process.c | 15 --- 1 file changed, 15 deletions(-) diff --git

Re: [libvirt] [PATCH 1/5] Rename virKillProcess to virProcessKill

2012-09-25 Thread Eric Blake
On 09/25/2012 02:28 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Changing naming to follow the convention of object followed by action Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_agent.c | 2 +- src/qemu/qemu_monitor.c | 2 +-

Re: [libvirt] [PATCH 3/5] Rename virCommandTranslateStatus to virProcessTranslateStatus

2012-09-25 Thread Eric Blake
On 09/25/2012 02:28 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virCommand prefix was inappropriate because the API does not use any virCommandPtr object instance. This API closely related to waitpid/exit, so use virProcess as the prefix Signed-off-by:

Re: [libvirt] [PATCH] Fix start of containers with custom root filesystem

2012-09-25 Thread Eric Blake
On 09/25/2012 02:26 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com A prefix change to unmount the SELinux filesystem broke starting of LXC containers with a custom root filesystem Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH 2/5] Rename virPid{Abort, Wait} to virProcess{Abort, Wait}

2012-09-25 Thread Eric Blake
On 09/25/2012 02:28 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Change Pid to Process to align with the virProcessKill API naming prefix Signed-off-by: Daniel P. Berrange berra...@redhat.com --- daemon/libvirtd.c| 2 +- src/libvirt_private.syms |

Re: [libvirt] [PATCH] Convert virLXCMonitor to use virObject

2012-09-25 Thread Eric Blake
On 09/25/2012 02:28 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Remove custom reference counting from virLXCMonitor, using virObject instead Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_monitor.c | 63

Re: [libvirt] [PATCH 4/5] Move virProcessKill into virprocess.{h, c}

2012-09-25 Thread Eric Blake
On 09/25/2012 02:28 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com There are a number of process related functions spread across multiple files. Start to consolidate them by creating a virprocess.{c,h} file Signed-off-by: Daniel P. Berrange berra...@redhat.com

Re: [libvirt] [PATCH 5/5] Move virProcess{Kill, Abort, TranslateStatus} into virprocess.{c, h}

2012-09-25 Thread Eric Blake
On 09/25/2012 02:28 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Continue consolidation of process functions by moving some helpers out of command.{c,h} into virprocess.{c,h} Signed-off-by: Daniel P. Berrange berra...@redhat.com --- daemon/libvirtd.c

  1   2   >