[libvirt] [PATCH] Fix three minor typos

2013-11-25 Thread Yuri Chornoivan
0001-Fix-three-minor-typos.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [test-API][PATCH] Add blockjob related cases

2013-11-25 Thread Guannan Ren
On 2013年11月26日 11:49, Jincheng Miao wrote: Add: * repos/domain/blkstatsflags.py * repos/domain/block_iotune.py * repos/domain/block_peek.py * repos/domain/block_resize.py * repos/domain/domain_blkio.py * cases/basic_blockjob.conf Modify: replace virsh commands to calling api in

Re: [libvirt] [libvirt-test-API][PATCH] Fix utils.exec_cmd output problem

2013-11-25 Thread Guannan Ren
On 2013年11月26日 09:32, Jincheng Miao wrote: ping gren - Original Message - As described before, this patch should be : --- utils/utils.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/utils/utils.py b/utils/utils.py index 147c1ef..ec09c33 100644 --- a/utils

Re: [libvirt] [PATCHv6 2/5] Add hostdev passthrough common library

2013-11-25 Thread Chunyan Liu
2013/11/26 Jim Fehlig > Jim Fehlig wrote: > > Chunyan Liu wrote: > > > >> Add hostdev passthrough common library so that it could be shared by > all drivers > >> and maintain a global hostdev state. > >> > >> > > > > Hi Chunyan, > > > > Looks like you addressed all of Daniel's comments from v5. O

[libvirt] Entering freeze for 1.2.0, rc1 available

2013-11-25 Thread Daniel Veillard
So as planned we are entering freeze for libvirt-1.2.0, I just tagged the git trees - plural as we now use libvirt-python separate git for this binding - and pushed tarballs and rpms to the usual place at: ftp://libvirt.org/libvirt/ it did allows a correct update at the rpm level for me and

[libvirt] [test-API][PATCH] Add blockjob related cases

2013-11-25 Thread Jincheng Miao
Add: * repos/domain/blkstatsflags.py * repos/domain/block_iotune.py * repos/domain/block_peek.py * repos/domain/block_resize.py * repos/domain/domain_blkio.py * cases/basic_blockjob.conf Modify: replace virsh commands to calling api in test function * repos/domain/blkstats.py * rep

Re: [libvirt] [PATCHv6 4/5] Change qemu driver to use hostdev common library

2013-11-25 Thread Jim Fehlig
Chunyan Liu wrote: > Change qemu driver to use hostdev common library instead of APIs in > qemu_hostdev.[ch] > > Signed-off-by: Chunyan Liu > --- > po/POTFILES.in |1 - > src/Makefile.am |1 - > src/qemu/qemu_command.c |1 - > src/qemu/qemu_conf.h|9 +- > src/

Re: [libvirt] [PATCHv6 1/5] Add a hostdev PCI backend type

2013-11-25 Thread Jim Fehlig
Laine Stump wrote: > On 11/22/2013 11:08 PM, Jim Fehlig wrote: > >> Chunyan Liu wrote: >> >>> Add VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN. For legacy xen, it will use >>> "pciback" as >>> stub driver. >>> >>> >> Sorry for the long delay in helping review these patches. I finally have

Re: [libvirt] [libvirt-test-API][PATCH] Fix utils.exec_cmd output problem

2013-11-25 Thread Jincheng Miao
ping gren - Original Message - > As described before, this patch should be : > > --- > utils/utils.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/utils/utils.py b/utils/utils.py > index 147c1ef..ec09c33 100644 > --- a/utils/utils.py > +++ b/utils/utils.

Re: [libvirt] [PATCHv6 2/5] Add hostdev passthrough common library

2013-11-25 Thread Jim Fehlig
Jim Fehlig wrote: > Chunyan Liu wrote: > >> Add hostdev passthrough common library so that it could be shared by all >> drivers >> and maintain a global hostdev state. >> >> > > Hi Chunyan, > > Looks like you addressed all of Daniel's comments from v5. One bug fix > and a few additional

Re: [libvirt] [PATCH 0/4] Expose FSFreeze/FSThaw within the guest as commands

2013-11-25 Thread Tomoki Sekiyama
Any comments? On 11/18/13 11:38 , "Tomoki Sekiyama" wrote: >Currently FSFreeze and FSThaw are supported by qemu guest agent and they >are >used internally in snapshot-create command with --quiesce option. >However, when users want to utilize the native snapshot feature of storage >devices (such

[libvirt] [PATCH] storage: don't read storage volumes in nonblock mode

2013-11-25 Thread Eric Blake
Commit 348b4e2 introduced a potential problem (thankfully not in any release): we are attempting to use virFileReadHeaderFD() on a file that was opened with O_NONBLOCK. While this shouldn't be a problem in practice (because O_NONBLOCK typically doesn't affect regular or block files, and fifos and

Re: [libvirt] [PATCHv5 1/4] net-dhcp-leases: Implement the public APIs

2013-11-25 Thread Nehal J Wani
On Tue, Nov 26, 2013 at 2:35 AM, Nehal J Wani wrote: > Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC > and virNetworkDHCPLeaseFree. > > * virNetworkGetDHCPLeases: returns the dhcp leases information for a given > virtual network. > > For DHCPv4, the informatio

[libvirt] [PATCHv5 3/4] net-dhcp-leases: Private implementation inside network

2013-11-25 Thread Nehal J Wani
By querying the driver for the path of the custom leases file for the given virtual network and parsing it to retrieve info. src/network/bridge_driver.c: * Implement networkGetDHCPLeases * Implement networkGetDHCPLeasesForMAC * Implement networkGetDHCPLeasesHelper --- src/network/bridge_driver.c

[libvirt] [PATCHv5 2/4] net-dhcp-leases: Implement the remote protocol

2013-11-25 Thread Nehal J Wani
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC daemon/remote.c * Define remoteSerializeNetworkDHCPLeases, remoteDispatchNetworkGetDHCPLeases * Define remoteDispatchNetworkGetDHCPLeasesForMAC * Define helper function remoteSerializeDHCPLease src

[libvirt] [PATCHv5 4/4] net-dhcp-leases: Add virsh support

2013-11-25 Thread Nehal J Wani
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network 2. Retrieve leases info for given network interface tools/virsh-domain-monitor.c * Introduce new command : net-dhcp-lease

[libvirt] [PATCHv5 1/4] net-dhcp-leases: Implement the public APIs

2013-11-25 Thread Nehal J Wani
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC and virNetworkDHCPLeaseFree. * virNetworkGetDHCPLeases: returns the dhcp leases information for a given virtual network. For DHCPv4, the information returned: - Network Interface Name - Expiry Time - MAC add

[libvirt] [PATCHv5 0/4] Introduce APIs to extract DHCP leases info

2013-11-25 Thread Nehal J Wani
This API returns the leases information stored in the DHCP leases file of dnsmasq for a given virtual network. It contacts the bridge network driver, which parses a custom leases file created by libvirt. It supports two methods: 1. Return info for all network interfaces connected to a given vi

Re: [libvirt] [PATCHv4 8/8] storage: probe qcow2 volumes in gluster pool

2013-11-25 Thread Eric Blake
On 11/25/2013 08:59 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:30PM -0700, Eric Blake wrote: >> Putting together pieces from previous patches, it is now possible >> for 'virsh vol-dumpxml --pool gluster volname' to report metadata >> about a qcow2 file stored on gluster. The bac

Re: [libvirt] [PATCHv4 7/8] storage: improve handling of symlinks in gluster

2013-11-25 Thread Eric Blake
On 11/25/2013 08:57 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:29PM -0700, Eric Blake wrote: >> With this patch, dangling and looping symlinks are silently >> ignored, while links to files and directories are treated the >> same as the underlying file or directory. This is the s

Re: [libvirt] [PATCHv4 6/8] storage: improve allocation stats reported on gluster files

2013-11-25 Thread Eric Blake
On 11/25/2013 08:57 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:28PM -0700, Eric Blake wrote: >> We already had code for handling allocation different than >> capacity for sparse files; we just had to wire it up to be >> used when inspecting gluster images. >> >> * src/storage/sto

Re: [libvirt] [PATCHv4 5/8] storage: improve directory support in gluster pool

2013-11-25 Thread Eric Blake
On 11/25/2013 08:56 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:27PM -0700, Eric Blake wrote: > >> diff --git a/tests/storagevolxml2xmlin/vol-gluster-dir.xml >> b/tests/storagevolxml2xmlin/vol-gluster-dir.xml >> new file mode 100644 >> index 000..bd20a6a >> --- /dev/null >>

Re: [libvirt] [PATCHv4 4/8] storage: add network-dir as new storage volume type

2013-11-25 Thread Eric Blake
On 11/25/2013 08:54 AM, Daniel P. Berrange wrote: >>> VIR_ENUM_IMPL(virStorageVol, >>>VIR_STORAGE_VOL_LAST, >>> - "file", "block", "dir", "network") >>> + "file", "block", "dir", "network", "network-dir") >> >> I've got to say I really don't like this nam

[libvirt] [PATCH RFC 6/6] RFC: qemu: snapshot: Add support for external active snapshots on gluster

2013-11-25 Thread Peter Krempa
This is a basic implementation of snapshots on gluster. Many things are lacking, especially cleanup after a failed snapshot. --- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 9 src/qemu/qemu_driver.c | 106 3 files changed, 10

[libvirt] [PATCH RFC 4/6] RFC: snapshot: Add support for specifying snapshot disk backing type

2013-11-25 Thread Peter Krempa
Add support for specifying various types when doing snapshots. This will later allow to do snapshots on network backed volumes. RFC: This patch is lacking tests and domain schema touch up. --- src/conf/snapshot_conf.c | 9 src/qemu/qemu_driver.c | 56 +++---

[libvirt] [PATCH RFC 3/6] qemu: snapshots: Declare supported and unsupported snapshot configs

2013-11-25 Thread Peter Krempa
Currently the snapshot code did not check if it actually supports snapshots on various disk backends for domains. To avoid future problems add checkers that whitelist the supported configurations. --- src/qemu/qemu_driver.c | 264 +++-- 1 file changed, 2

[libvirt] [PATCH RFC 2/6] qemu: snapshot: Add functions similar to disk source pool translation

2013-11-25 Thread Peter Krempa
To avoid future pain, add placeholder functions to get the actual snapshot disk type. --- src/qemu/qemu_conf.c | 23 +++ src/qemu/qemu_conf.h | 6 ++ 2 files changed, 29 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 1192d23..4ccca1f 100644 -

[libvirt] [PATCH RFC 5/6] RFC: conf: snapshot: Parse more snapshot information

2013-11-25 Thread Peter Krempa
Add fields to hold information about network volumes for snapshots. RFC: Missing schema and tests. --- src/conf/snapshot_conf.c | 12 src/conf/snapshot_conf.h | 15 +-- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/sn

[libvirt] [PATCH RFC 0/6] Add support for snapshots on gluster.

2013-11-25 Thread Peter Krempa
This series has to be applied on top of the refactoring series sent earlier today. First 3 patches are additional fixes that should be good to be commited. The rest is work in progress state to gather possible comments. Peter Krempa (6): qemu: snapshot: Touch up error message qemu: snapshot

[libvirt] [PATCH RFC 1/6] qemu: snapshot: Touch up error message

2013-11-25 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d2dbaf5..96bc87e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -11858,8 +11858,8 @@ qemuDomainSnapshotPrepare(virDomainObjP

Re: [libvirt] [PATCHv4 3/8] storage: implement rudimentary glusterfs pool refresh

2013-11-25 Thread Eric Blake
On 11/25/2013 08:52 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:25PM -0700, Eric Blake wrote: >> Actually put gfapi to use, by allowing the creation of a gluster >> pool. Right now, all volumes are treated as raw and directories >> are skipped; further patches will allow peering

Re: [libvirt] [PATCHv4 2/8] storage: document gluster pool

2013-11-25 Thread Eric Blake
On 11/25/2013 08:40 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:24PM -0700, Eric Blake wrote: >> Add support for a new , similar to >> RBD and Sheepdog. Terminology wise, a gluster volume >> forms a libvirt storage pool, within the gluster volume, >> individual files are treated

Re: [libvirt] [PATCHv4 1/8] storage: initial support for linking with libgfapi

2013-11-25 Thread Eric Blake
On 11/25/2013 08:39 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:23PM -0700, Eric Blake wrote: >> We support gluster volumes in domain XML, so we also ought to >> support them as a storage pool. Besides, a future patch will >> want to take advantage of libgfapi to handle the case

Re: [libvirt] [PATCH 01/22] conf: Implement virStorageVolType enum helper functions

2013-11-25 Thread Eric Blake
On 11/25/2013 09:11 AM, Peter Krempa wrote: > Add support for string conversion from and to the virStorageVolType > enum. > --- > src/conf/storage_conf.c | 4 > src/conf/storage_conf.h | 2 ++ > src/libvirt_private.syms | 2 ++ > 3 files changed, 8 insertions(+) You can drop most of this p

Re: [libvirt] Help required in simulating libvirt TLS server

2013-11-25 Thread Eric Blake
On 11/25/2013 10:59 AM, Arun Viswanath wrote: > Hi All, > > Will some one explain how is this tls libvirt server is implemented. For my > testing purpose I need to implement the similar TLS server in Java or > Python and this server is capable to receive all libvirt calls like > getCapabilities, h

[libvirt] Help required in simulating libvirt TLS server

2013-11-25 Thread Arun Viswanath
Hi All, Will some one explain how is this tls libvirt server is implemented. For my testing purpose I need to implement the similar TLS server in Java or Python and this server is capable to receive all libvirt calls like getCapabilities, hostname etc and return response as I'm configured. Basical

Re: [libvirt] [PATCH libvirt-python] Update README file contents and add HACKING file

2013-11-25 Thread Eric Blake
On 11/25/2013 10:18 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The previous README file from the python code is more like a > HACKING file. Rename it and update the content. Then add a > basic README file > > Signed-off-by: Daniel P. Berrange > --- > HACKING | 37 ++

[libvirt] [PATCHv4 3/5] vbox_tmpl.c: Better XML description for snapshots

2013-11-25 Thread Manuel VIVES
It will be needed for the futur patches because we will redefine snapshots --- src/conf/domain_conf.c |2 +- src/vbox/vbox_tmpl.c | 427 ++-- 2 files changed, 417 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domai

[libvirt] [PATCHv4 5/5] vbox_tmpl.c: Add methods for undefining snapshots

2013-11-25 Thread Manuel VIVES
All the informations concerning snapshots (and snapshot disks) will be deleted from the vbox xml. But the differencing disks will be kept so you will be able to redefine the snapshots. --- src/vbox/vbox_tmpl.c | 391 ++ 1 file changed, 391 insertion

[libvirt] [PATCHv4 1/5] viruuid.h/c: Util method for finding uuid patterns in some strings

2013-11-25 Thread Manuel VIVES
--- po/POTFILES.in |1 + src/libvirt_private.syms |1 + src/util/viruuid.c | 81 ++ src/util/viruuid.h |1 + 4 files changed, 84 insertions(+) diff --git a/po/POTFILES.in b/po/POTFILES.in index 15afdec..451a6fc 100644

[libvirt] [PATCHv4 4/5] vbox_tmpl.c: Patch for redefining snapshots

2013-11-25 Thread Manuel VIVES
The snapshots are saved in xml files, and then can be redefined --- src/vbox/vbox_tmpl.c | 852 +- 1 file changed, 844 insertions(+), 8 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index e05ed97..23f8aab 100644 --- a/src/vb

[libvirt] [PATCHv4 2/5] virstring.h/c: Util method for making some find and replace in strings

2013-11-25 Thread Manuel VIVES
--- src/libvirt_private.syms |1 + src/util/virstring.c | 48 ++ src/util/virstring.h |2 ++ 3 files changed, 51 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 99cc32a..b761fb6 100644 --- a/src/lib

[libvirt] [PATCHv4 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2

2013-11-25 Thread Manuel VIVES
Hi, This is a serie of patches in order to support undefining and redefining snapshots with VirtualBox 4.2. The serie of patches is rather big, and adds among other things some utility functions unrelated to VirtualBox in patches 1 & 2. The code review could be done in several parts: e.g. patches

Re: [libvirt] [PATCHv2] storage: expose volume meta-type in XML

2013-11-25 Thread John Ferlan
On 11/25/2013 11:56 AM, Eric Blake wrote: > I got annoyed at having to use both 'virsh vol-list $pool --details' > AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated > the volume correctly. Since two-thirds of the data present in > virStorageVolGetInfo() already appears in virStorageVo

Re: [libvirt] [PATCHv2] storage: expose volume meta-type in XML

2013-11-25 Thread Eric Blake
On 11/25/2013 10:06 AM, Daniel P. Berrange wrote: > On Mon, Nov 25, 2013 at 09:56:48AM -0700, Eric Blake wrote: >> I got annoyed at having to use both 'virsh vol-list $pool --details' >> AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated >> the volume correctly. Since two-thirds of the

[libvirt] [PATCH libvirt-python] Update README file contents and add HACKING file

2013-11-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The previous README file from the python code is more like a HACKING file. Rename it and update the content. Then add a basic README file Signed-off-by: Daniel P. Berrange --- HACKING | 37 + README | 41 +-

Re: [libvirt] [PATCHv2] storage: expose volume meta-type in XML

2013-11-25 Thread Daniel P. Berrange
On Mon, Nov 25, 2013 at 09:56:48AM -0700, Eric Blake wrote: > I got annoyed at having to use both 'virsh vol-list $pool --details' > AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated > the volume correctly. Since two-thirds of the data present in > virStorageVolGetInfo() already appea

[libvirt] [PATCHv2] storage: expose volume meta-type in XML

2013-11-25 Thread Eric Blake
I got annoyed at having to use both 'virsh vol-list $pool --details' AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated the volume correctly. Since two-thirds of the data present in virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(), this just adds the remaining piece

Re: [libvirt] [PATCH] Remove obsolete 'tests' makefile target

2013-11-25 Thread Eric Blake
On 11/25/2013 09:15 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The 'docs/examples' code was long ago removed and now the > python code was gone too, the custom 'tests' makefile target > serves no purpopse s/purpopse/purpose/ ACK. -- Eric Blake eblake redhat com+1-919

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Don Dugger
On Mon, Nov 25, 2013 at 04:02:37PM +, Daniel P. Berrange wrote: > On Mon, Nov 25, 2013 at 08:55:12AM -0700, Don Dugger wrote: > > On Mon, Nov 25, 2013 at 03:48:45PM +, Daniel P. Berrange wrote: > > > On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: > > > > On Mon, Nov 25, 2013 at

[libvirt] [PATCH] Remove obsolete 'tests' makefile target

2013-11-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The 'docs/examples' code was long ago removed and now the python code was gone too, the custom 'tests' makefile target serves no purpopse Signed-off-by: Daniel P. Berrange --- Makefile.am | 3 --- 1 file changed, 3 deletions(-) diff --git a/Makefile.am b/Makefile.am

[libvirt] [PATCH 19/22] conf: Add functions to copy and free network disk source definitions

2013-11-25 Thread Peter Krempa
To simplify operations on virDomainDiskHostDef arrays we will need deep copy and freeing functions. Add and properly export them. --- src/conf/domain_conf.c | 55 +--- src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 2 ++ 3 files changed

[libvirt] [PATCH 17/22] snapshot: conf: Use common parsing and formatting functions for source

2013-11-25 Thread Peter Krempa
Disk source elements for snapshots were using separate code from our config parser. As snapshots can be stored on more than just regular files, we will need the universal parser to allow us to expose a variety of snapshot disk targets. This patch reuses the config parsers and formatters to do the j

[libvirt] [PATCH 22/22] qemu: Clear old translated pool source

2013-11-25 Thread Peter Krempa
Clear the old data to avoid leaking it when attempting to re-translate a pool on the same domain object. --- src/qemu/qemu_conf.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index e098c13..1192d23 100644 --- a/src/qemu/qemu_conf.c +++ b/src/q

[libvirt] [PATCH 20/22] qemu: snapshot: Detect internal snapshots also for sheepdog and RBD

2013-11-25 Thread Peter Krempa
When doing an internal snapshot on a VM with sheepdog or RBD disks we would not set a flag to mark the domain is using internal snapshots and might end up creating a mixed snapshot. Move the setting of the variable to avoid this problem. --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insert

[libvirt] [PATCH 08/22] qemu: Use qemuBuildNetworkDriveURI to handle http/ftp and friends

2013-11-25 Thread Peter Krempa
Prepare the function to integrate other protocols and start folding other network protocols into a common place. --- src/qemu/qemu_command.c | 199 +--- 1 file changed, 122 insertions(+), 77 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/q

[libvirt] [PATCH 02/22] test: Implement fake storage pool driver in qemuxml2argv test

2013-11-25 Thread Peter Krempa
To support testing of "volume" disk backing, we need to implement a few disk driver backend functions. The fake storage driver uses files in storagepoolxml2xmlout/POOLNAME.xml as XML files for pool definitions and volume names are in format "VOL_TYPE+VOL_PATH". By default type "block" is assumed (

[libvirt] [PATCH 11/22] qemu: Unify formatting of RBD sources

2013-11-25 Thread Peter Krempa
--- src/qemu/qemu_command.c | 155 +++- 1 file changed, 61 insertions(+), 94 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index afb8fe6..9704c90 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3253,7

[libvirt] [PATCH 07/22] qemu: Simplify call pattern of qemuBuildDriveURIString

2013-11-25 Thread Peter Krempa
Automatically assign secret type from the disk source definition and pull in adding of the comma. Then update callers to keep generated output the same. --- src/qemu/qemu_command.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/src/qemu/qem

[libvirt] [PATCH 21/22] conf: Add helper do clear disk source authentication struct

2013-11-25 Thread Peter Krempa
Add virDomainDiskAuthClear to help cleaning out the struct in other places too. --- src/conf/domain_conf.c | 17 ++--- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/d

[libvirt] [PATCH 09/22] qemu: Migrate sheepdog source generation into common function

2013-11-25 Thread Peter Krempa
--- src/qemu/qemu_command.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b1c7803..82fce0e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3754,6 +3754,29 @@

[libvirt] [PATCH 01/22] conf: Implement virStorageVolType enum helper functions

2013-11-25 Thread Peter Krempa
Add support for string conversion from and to the virStorageVolType enum. --- src/conf/storage_conf.c | 4 src/conf/storage_conf.h | 2 ++ src/libvirt_private.syms | 2 ++ 3 files changed, 8 insertions(+) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 8b378c2..1355056

[libvirt] [PATCH 03/22] qemuxml2argv: Add test to verify correct usage of disk type="volume"

2013-11-25 Thread Peter Krempa
Tweak the existing file to test command line generator too. --- tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool.args | 8 tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool.xml | 2 +- tests/qemuxml2argvtest.c | 2 ++ 3 files changed, 11 insertions

[libvirt] [PATCH 15/22] conf: Split out seclabel formating code for disk source

2013-11-25 Thread Peter Krempa
The code is common for all the various disk types. Split it out to a common function. --- src/conf/domain_conf.c | 62 -- 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 03663e4..d

[libvirt] [PATCH 05/22] qemu: Refactor qemuTranslatePool source

2013-11-25 Thread Peter Krempa
The function was a mess originally making decisions on volume type instead of pool type. Refactor it so that it doesn't require a special formatter function in qemu and use typecasted strings to avoid possible future omittings. --- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 +

[libvirt] [PATCH 16/22] conf: Export disk source formatter and parser

2013-11-25 Thread Peter Krempa
This code will be reused in the snapshot disk definition parser. --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 20 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d000f97..09ea51f 100644 ---

[libvirt] [PATCH 14/22] conf: Clean up virDomainDiskSourceDefFormatInternal

2013-11-25 Thread Peter Krempa
Avoid if statements when used with virBufferEscapeString which automaticaly omits the whole string. Also add some line breaks to visualy separate the code. --- src/conf/domain_conf.c | 50 +- 1 file changed, 21 insertions(+), 29 deletions(-) diff --

[libvirt] [PATCH 12/22] qemu: Refactor disk source string formatting

2013-11-25 Thread Peter Krempa
--- src/qemu/qemu_command.c | 128 1 file changed, 86 insertions(+), 42 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9704c90..7a6e322 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3827,1

[libvirt] [PATCH 06/22] qemu: Split out formatting of network disk source URI

2013-11-25 Thread Peter Krempa
The snapshot code will need to use qemu-style formatted URIs of network disks. Split out the code to avoid duplication. --- src/qemu/qemu_command.c | 146 src/qemu/qemu_command.h | 6 ++ 2 files changed, 91 insertions(+), 61 deletions(-) diff --g

[libvirt] [PATCH 04/22] qemuxml2argv: Add test for disk type='volume' with iSCSI pools

2013-11-25 Thread Peter Krempa
Tweak the existing file so that it can be tested for command line corectness. --- tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool-mode.args | 10 ++ tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool-mode.xml | 4 ++-- tests/qemuxml2argvtest.c

[libvirt] [PATCH 18/22] snapshot: conf: Fix NULL dereference when element is empty

2013-11-25 Thread Peter Krempa
Consider the following valid snapshot XML as the element is allowed to be empty in the domainsnapshot.rng schema: $ cat snap.xml produces the following error: $ virsh snapshot-create domain snap.xml error: internal error: unknown disk snapshot driver '(null)' Th

[libvirt] [PATCH 10/22] qemu: Split out NBD command generation

2013-11-25 Thread Peter Krempa
--- src/qemu/qemu_command.c | 117 +--- 1 file changed, 61 insertions(+), 56 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 82fce0e..afb8fe6 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3680,7

[libvirt] [PATCH 00/22] Misc refactors and cleanups leading to gluster snapshot support

2013-11-25 Thread Peter Krempa
Peter Krempa (22): conf: Implement virStorageVolType enum helper functions test: Implement fake storage pool driver in qemuxml2argv test qemuxml2argv: Add test to verify correct usage of disk type="volume" qemuxml2argv: Add test for disk type='volume' with iSCSI pools qemu: Refactor qemuT

[libvirt] [PATCH 13/22] conf: Support disk source formatting without needing a virDomainDiskDefPtr

2013-11-25 Thread Peter Krempa
The element formatting function was expecting a virDomainDiskDefPtr to store the data. As snapshots are not using this data structure to hold the data, we need to add an internal function which splits out individual fields separately. --- src/conf/domain_conf.c | 131 +

Re: [libvirt] [PATCH] storage: expose volume meta-type in XML

2013-11-25 Thread Eric Blake
On 11/25/2013 03:41 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 03:26:11PM -0700, Eric Blake wrote: >> I got annoyed at having to use both 'virsh vol-list $pool --details' >> AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated >> the volume correctly. Since two-thirds of the

Re: [libvirt] [PATCH] storage: expose volume meta-type in XML

2013-11-25 Thread Eric Blake
On 11/24/2013 09:57 PM, Osier Yang wrote: > On 23/11/13 06:26, Eric Blake wrote: >> I got annoyed at having to use both 'virsh vol-list $pool --details' >> AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated >> the volume correctly. Since two-thirds of the data present in >> virStorageV

Re: [libvirt] [PATCH] spec: Don't save/restore running VMs on libvirt-client update

2013-11-25 Thread Jiri Denemark
On Mon, Nov 25, 2013 at 09:00:43 -0700, Eric Blake wrote: > On 11/25/2013 08:53 AM, Jiri Denemark wrote: > > The previous attempt (commit d65e0e1) removed just one of two > > libvirt-guests restarts that happened on libvirt-client update. Let's > > remove the last one too :-) > > > > https://bugzi

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Daniel P. Berrange
On Mon, Nov 25, 2013 at 08:55:12AM -0700, Don Dugger wrote: > On Mon, Nov 25, 2013 at 03:48:45PM +, Daniel P. Berrange wrote: > > On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: > > > On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: > > > > On Sun, Nov 24, 2013 at

Re: [libvirt] [PATCH] spec: Don't save/restore running VMs on libvirt-client update

2013-11-25 Thread Eric Blake
On 11/25/2013 08:53 AM, Jiri Denemark wrote: > The previous attempt (commit d65e0e1) removed just one of two > libvirt-guests restarts that happened on libvirt-client update. Let's > remove the last one too :-) > > https://bugzilla.redhat.com/show_bug.cgi?id=962225 > > Signed-off-by: Jiri Denemar

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Eric Blake
On 11/25/2013 08:55 AM, Don Dugger wrote: > > I'm basing this on code inspection so I could be wrong but if you look > at the Python interface code for libvirt_virDomainSetSchedulerParameters > it checks the return value from virDomainSetSchedulerParameters and, > if it is <0, then the Pythong co

Re: [libvirt] [PATCHv4 8/8] storage: probe qcow2 volumes in gluster pool

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 08:20:30PM -0700, Eric Blake wrote: > Putting together pieces from previous patches, it is now possible > for 'virsh vol-dumpxml --pool gluster volname' to report metadata > about a qcow2 file stored on gluster. The backing file is still > treated as raw; to fix that, more

Re: [libvirt] [PATCHv4 6/8] storage: improve allocation stats reported on gluster files

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 08:20:28PM -0700, Eric Blake wrote: > We already had code for handling allocation different than > capacity for sparse files; we just had to wire it up to be > used when inspecting gluster images. > > * src/storage/storage_backend.c > (virStorageBackendUpdateVolTargetInfoFD

Re: [libvirt] [PATCHv4 7/8] storage: improve handling of symlinks in gluster

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 08:20:29PM -0700, Eric Blake wrote: > With this patch, dangling and looping symlinks are silently > ignored, while links to files and directories are treated the > same as the underlying file or directory. This is the same > behavior as both 'directory' and 'netfs' pools. >

Re: [libvirt] [PATCHv4 5/8] storage: improve directory support in gluster pool

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 08:20:27PM -0700, Eric Blake wrote: > diff --git a/tests/storagevolxml2xmlin/vol-gluster-dir.xml > b/tests/storagevolxml2xmlin/vol-gluster-dir.xml > new file mode 100644 > index 000..bd20a6a > --- /dev/null > +++ b/tests/storagevolxml2xmlin/vol-gluster-dir.xml > @@ -0,

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Don Dugger
On Mon, Nov 25, 2013 at 03:48:45PM +, Daniel P. Berrange wrote: > On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: > > On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: > > > On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: > > > > On Sat, Nov 23, 201

Re: [libvirt] [PATCHv4 4/8] storage: add network-dir as new storage volume type

2013-11-25 Thread Daniel P. Berrange
On Mon, Nov 25, 2013 at 10:42:30AM +, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 08:20:26PM -0700, Eric Blake wrote: > > In the 'directory' and 'netfs' storage pools, a user can see > > both 'file' and 'dir' storage volume types, to know when they > > can descend into a subdirectory.

[libvirt] [PATCH] spec: Don't save/restore running VMs on libvirt-client update

2013-11-25 Thread Jiri Denemark
The previous attempt (commit d65e0e1) removed just one of two libvirt-guests restarts that happened on libvirt-client update. Let's remove the last one too :-) https://bugzilla.redhat.com/show_bug.cgi?id=962225 Signed-off-by: Jiri Denemark --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion

Re: [libvirt] [PATCHv4 3/8] storage: implement rudimentary glusterfs pool refresh

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 08:20:25PM -0700, Eric Blake wrote: > Actually put gfapi to use, by allowing the creation of a gluster > pool. Right now, all volumes are treated as raw and directories > are skipped; further patches will allow peering into files to > allow for qcow2 files and backing chain

[libvirt] [python PATCH] maint: next release is 1.2.0

2013-11-25 Thread Eric Blake
No other hits for: git grep '1\.1\.5' * libvirt-utils.h: Fix comment. Signed-off-by: Eric Blake --- Pushing under the trivial rule (and as a test that the new python repo is set up correctly). libvirt-utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-utils.h

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Daniel P. Berrange
On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: > On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: > > On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: > > > On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger wrote: > > > > > > > > This Python interface code

Re: [libvirt] [PATCH v4] virsh domxml-from-native to treat SCSI as the bus type for pseries by default

2013-11-25 Thread Cole Robinson
On 11/22/2013 12:27 PM, Shivaprasad G Bhat wrote: > The bus type IDE being enum Zero, the bus type on pseries system appears as > IDE for all the -hda/-cdrom and for disk drives with if="none" type. Pseries > platform needs this to appear as SCSI instead of IDE. The ide being not > supported, th

Re: [libvirt] [PATCHv4 1/8] storage: initial support for linking with libgfapi

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 08:20:23PM -0700, Eric Blake wrote: > We support gluster volumes in domain XML, so we also ought to > support them as a storage pool. Besides, a future patch will > want to take advantage of libgfapi to handle the case of a > gluster device holding qcow2 rather than raw sto

Re: [libvirt] [PATCHv4 2/8] storage: document gluster pool

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 08:20:24PM -0700, Eric Blake wrote: > Add support for a new , similar to > RBD and Sheepdog. Terminology wise, a gluster volume > forms a libvirt storage pool, within the gluster volume, > individual files are treated as libvirt storage volumes. > > * docs/schemas/storagep

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Don Dugger
On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: > On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: > > On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger wrote: > > > > > > This Python interface code is returning a -1 on errors for the > > > `baselineCPU' API. Since th

Re: [libvirt] [PATCH] Remove python binding

2013-11-25 Thread Eric Blake
On 11/25/2013 08:09 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 12:08:46PM -0700, Eric Blake wrote: >>> >>> FYI I ran 'autobuild.sh' to validate the full RPM builds here. >>> >> >> All right, looks like we're nearly ready to pull the trigger then :) > > So here's what I propose changin

Re: [libvirt] [PATCH] tests: Make pci config files writable

2013-11-25 Thread Eric Blake
On 11/25/2013 07:24 AM, Daniel P. Berrange wrote: >> object-locking-files.txt >> + >> +# Some tests tend to write into files. Notably, the virpcitest, which detach >> +# and reset a pci device (achieved byt writing into a pci config file). >> +check-local: >> +chmod -R u+w $(srcdir)/virpc

[libvirt] New libvirt python GIT repository

2013-11-25 Thread Daniel P. Berrange
We have now pushed the python binding code to its new GIT repository location. If you intend to work on python bindings, please get yourself a checkout of the following http://libvirt.org/git/?p=libvirt-python.git;a=summary git://libvirt.org/libvirt-python.git The python binding will genera

Re: [libvirt] [PATCH] Remove python binding

2013-11-25 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 12:08:46PM -0700, Eric Blake wrote: > > > > FYI I ran 'autobuild.sh' to validate the full RPM builds here. > > > > All right, looks like we're nearly ready to pull the trigger then :) So here's what I propose changing vs my patch diff --git a/configure.ac b/configure.ac

Re: [libvirt] [PATCHv2] storage: allow interleave in volume XML

2013-11-25 Thread Eric Blake
On 11/24/2013 09:24 PM, Osier Yang wrote: > On 23/11/13 03:54, Eric Blake wrote: >> The RNG grammar did not allow arbitrary interleaving, which makes >> it harder than necessary to create a new volume from handwritten XML. >> (Compare also to commit caf516db for pools). >> >> * docs/schemas/storage

Re: [libvirt] [PATCH 4/4] vbox: add support for 4.3 APIs

2013-11-25 Thread Ryota Ozaki
On Mon, Nov 25, 2013 at 8:26 PM, Laine Stump wrote: > On 11/21/2013 04:41 PM, Ryota Ozaki wrote: >> Makefile.am, vbox_V4_3.c and vbox_driver.c do regular >> modifitions to support a new version of APIs. >> >> vbox_tmpl.c basically fixes incompatibilities since 4.2. >> >> The affected incompatibili

  1   2   >