Re: [libvirt] [PATCH 3/3] qemu: introduce vram64 attribute for QXL video device

On Mon, Feb 22, 2016 at 07:26:42PM +0100, Pavel Hrdina wrote: On Mon, Feb 22, 2016 at 04:16:49PM +0100, Martin Kletzander wrote: On Mon, Feb 22, 2016 at 02:34:14PM +0100, Pavel Hrdina wrote: >This attribute is used to extend secondary PCI bar and expose it to the >guest as 64bit memory. It

Re: [libvirt] [PATCH V2 4/4] libxl: add support for rbd qdisk

On 02/22/2016 07:35 AM, Ján Tomko wrote: > On Wed, Feb 17, 2016 at 05:33:45PM -0700, Jim Fehlig wrote: >> xl/libxl already supports qemu's network-based block backends >> such as nbd and rbd. libvirt has supported configuring such >> s for long time too. This patch adds support for rbd >> disks in

[libvirt] Fw: [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

Sorry, accidentally sent to just Andrea the first time around, resending... Begin forwarded message: Date: Mon, 22 Feb 2016 16:53:15 +1100 From: David Gibson To: Andrea Bolognani Subject: Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and

Re: [libvirt] [FOR 1.3.0 PATCH] conf: add net device prefix for Xen

On 12/08/2015 04:06 PM, Jim Fehlig wrote: > Daniel P. Berrange wrote: >> On Mon, Dec 07, 2015 at 10:59:32PM -0700, Jim Fehlig wrote: >>> On 12/07/2015 11:52 AM, Daniel P. Berrange wrote: On Mon, Dec 07, 2015 at 09:42:21AM -0700, Jim Fehlig wrote: > In commit d2e5538b1, the libxl driver

Re: [libvirt] Block replication driver

On 02/16, Peter Krempa wrote: > On Fri, Feb 12, 2016 at 13:22:01 -0700, Eric Blake wrote: > > On 12/02/2015 02:08 AM, Simon Kollberg wrote: > > [...] > > > > My initial thought was to manually set the alias of the > > > disk and add a new reference element to the backingStore: > > > > > > ...

Re: [libvirt] kvm: "warning: host doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]"

(CCing libvir-list) On Sat, Feb 20, 2016 at 04:00:30AM -0500, Paolo Bonzini wrote: > - Original Message - > > From: "Jan Kiszka" > > To: "Eduardo Habkost" , "Paolo Bonzini" > > > > Cc: "qemu-devel" ,

Re: [libvirt] [PATCH v3 2/3] util: Introduce API's for Polkit text authentication

On 02/22/2016 10:41 AM, Martin Kletzander wrote: > On Fri, Feb 12, 2016 at 12:12:32PM -0500, John Ferlan wrote: >> Introduce virPolkitAgentCreate and virPolkitAgentDestroy >> >> virPolkitAgentCreate will run the polkit pkttyagent image as an >> asynchronous >> command in order to handle the

Re: [libvirt] [Xen-devel] [PATCH V2 0/4] libxl: support qemu's network-based block backends

On 02/18/2016 03:51 AM, Ian Campbell wrote: > On Wed, 2016-02-17 at 17:33 -0700, Jim Fehlig wrote: >> xl/libxl already supports qemu's network-based block backends >> such as nbd and rbd. libvirt has supported configuring network >> disks for long time too. This series marries the two in the >>

Re: [libvirt] [PATCH 3/3] qemu: introduce vram64 attribute for QXL video device

On Mon, Feb 22, 2016 at 04:16:49PM +0100, Martin Kletzander wrote: > On Mon, Feb 22, 2016 at 02:34:14PM +0100, Pavel Hrdina wrote: > >This attribute is used to extend secondary PCI bar and expose it to the > >guest as 64bit memory. It works like this: attribute vram is there to > >set size of

Re: [libvirt] [PATCH] qemu: add support for LSI SAS1068 (aka MPT Fusion) SCSI controller

- Original Message - > From: "John Ferlan" > To: "Paolo Bonzini" , libvir-list@redhat.com > Sent: Monday, February 22, 2016 3:00:19 PM > Subject: Re: [libvirt] [PATCH] qemu: add support for LSI SAS1068 (aka MPT > Fusion) SCSI controller > > >

Re: [libvirt] [PATCH V2] Fix bug of attaching redirdev device

On 22.02.2016 17:44, Osier Yang wrote: > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1298070 > > The corresponding chardev must be attached first, otherwise the > the qemu command line won't be complete (missing the host part), > --- > src/qemu/qemu_hotplug.c | 15 ++- > 1 file

[libvirt] [PATCH V2] Fix bug of attaching redirdev device

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1298070 The corresponding chardev must be attached first, otherwise the the qemu command line won't be complete (missing the host part), --- src/qemu/qemu_hotplug.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] Fix bug of attaching redirdev device

On 2016年02月23日 00:21, Michal Privoznik wrote: On 18.02.2016 17:02, Osier Yang wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1298070 Hey! It's nice to see people returning :) Have been about two years! :-) The corresponding chardev must be attached first, otherwise the the

Re: [libvirt] [PATCH v2 6/9] hostdev: Minor style adjustments

On Tue, 2016-01-26 at 18:59 -0500, John Ferlan wrote: > On 01/25/2016 11:21 AM, Andrea Bolognani wrote: > > Mostly labels names and whitespace. > >  > > No functional changes. > > --- > >  src/util/virhostdev.c | 23 ++- > >  1 file changed, 14 insertions(+), 9 deletions(-) > > 

Re: [libvirt] [PATCH] Fix bug of attaching redirdev device

On 18.02.2016 17:02, Osier Yang wrote: > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1298070 > Hey! It's nice to see people returning :) > The corresponding chardev must be attached first, otherwise the > the qemu command line won't be complete (missing the host part), > --- >

Re: [libvirt] About the vfio error when using SR-IOV

On Mon, 22 Feb 2016 10:23:16 -0500 Laine Stump wrote: > On 02/22/2016 04:29 AM, Xiao Ma (xima2) wrote: > > Hi, All > > > > I want to use the SR-IOV of intel 82576 NIC. > > > > I enabled IOMMU and VT-d and SR-IOV in BIOS. > > And enabled VT-d in kernel. > > The OS information is

Re: [libvirt] [PATCH] Fix bug of attaching redirdev device

ping? > >> On 18 Feb 2016, at 16:02, Osier Yang wrote: > >>> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1298070 > >>> > >>> The corresponding chardev must be attached first, otherwise the > >>> the qemu command line won't be complete (missing the host part), > >>> --- >

Re: [libvirt] [PATCH] cmdSaveImageEdit: Prefer VSH_EXCLUSIVE_OPTIONS over by hand check

On Mon, Feb 22, 2016 at 01:48:15PM +0100, Michal Privoznik wrote: > Since we have the macro there's no need for us to unwind it by > hand and check for mutually exclusive flags ourselves. > > Signed-off-by: Michal Privoznik > --- > tools/virsh-domain.c | 5 + > 1 file

Re: [libvirt] [PATCH v3 2/3] util: Introduce API's for Polkit text authentication

On Fri, Feb 12, 2016 at 12:12:32PM -0500, John Ferlan wrote: Introduce virPolkitAgentCreate and virPolkitAgentDestroy virPolkitAgentCreate will run the polkit pkttyagent image as an asynchronous command in order to handle the local agent authentication via stdin/stdout. The code makes use of

Re: [libvirt] [PATCH] cmdNetworkUpdate: Prefer VSH_EXCLUSIVE_OPTIONS over if-else tree

On Mon, Feb 22, 2016 at 01:48:14PM +0100, Michal Privoznik wrote: > We have macros that check and reject mutually exclusive > parameters to our commands. Use those instead of if-else tree. > > Signed-off-by: Michal Privoznik > --- > tools/virsh-network.c | 21

Re: [libvirt] [PATCH v2] Migration with --live --offline option performs offline migration without warning/error.

On Mon, Feb 22, 2016 at 07:26:54AM -0500, Nitesh Konkar wrote: > This patch gives an error when migration is attempted with both > --live and --offline options. > > Signed-off-by: Nitesh Konkar > --- > tools/virsh-domain.c | 4 > 1 file changed, 4 insertions(+)

Re: [libvirt] [PATCH v2 2/2] qemu: add spice opengl support

On 22.02.2016 16:04, Daniel P. Berrange wrote: > On Mon, Feb 22, 2016 at 09:49:04AM -0500, Marc-André Lureau wrote: >> Hi >> >> - Original Message - >>> On 19.02.2016 15:30, Marc-André Lureau wrote: Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument to

Re: [libvirt] About the vfio error when using SR-IOV

On 02/22/2016 04:29 AM, Xiao Ma (xima2) wrote: Hi, All I want to use the SR-IOV of intel 82576 NIC. I enabled IOMMU and VT-d and SR-IOV in BIOS. And enabled VT-d in kernel. The OS information is bellow: [root@host3 nova]# cat /etc/redhat-release CentOS Linux release 7.1.1503 (Core) [root@host3

Re: [libvirt] [PATCH 3/3] qemu: introduce vram64 attribute for QXL video device

On Mon, Feb 22, 2016 at 02:34:14PM +0100, Pavel Hrdina wrote: This attribute is used to extend secondary PCI bar and expose it to the guest as 64bit memory. It works like this: attribute vram is there to set size of secondary PCI bar and guest sees it as 32bit memory, attribute vram64 can

Re: [libvirt] [PATCH v2 2/2] qemu: add spice opengl support

[dropping Andrea from the cc-list for the sake of his Inbox] On Mon, Feb 22, 2016 at 09:49:04AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On 19.02.2016 15:30, Marc-André Lureau wrote: > > > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on > > >

Re: [libvirt] [PATCH v2 2/2] qemu: add spice opengl support

On Mon, Feb 22, 2016 at 09:49:04AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On 19.02.2016 15:30, Marc-André Lureau wrote: > > > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on > > > argument > > > to > > > enable opengl rendering context

Re: [libvirt] [PATCH v2 2/2] qemu: add spice opengl support

[reducing the cc-list] On Fri, Feb 19, 2016 at 03:30:15PM +0100, Marc-André Lureau wrote: > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument to > enable opengl rendering context (patches on the ML). This is necessary to > actually enable virgl rendering. > > Add a

Re: [libvirt] [PATCH v2 1/2] util: TristateBool and TristateSwitch are interchangeable

Hi - Original Message - > > VIR_ENUM_DECL(virTristateBool) > > VIR_ENUM_DECL(virTristateSwitch) > > > > +/* the two enums must be in sync to be able to use helpers interchangeably > > in > > + * some special cases */ > > +verify((int)VIR_TRISTATE_BOOL_YES ==

Re: [libvirt] [PATCH v2 2/2] qemu: add spice opengl support

Hi - Original Message - > On 19.02.2016 15:30, Marc-André Lureau wrote: > > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument > > to > > enable opengl rendering context (patches on the ML). This is necessary to > > actually enable virgl rendering. > > > > Add a

Re: [libvirt] [PATCH v2 2/2] qemu: add spice opengl support

On 19.02.2016 15:30, Marc-André Lureau wrote: > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument to > enable opengl rendering context (patches on the ML). This is necessary to > actually enable virgl rendering. > > Add a qemuxml2argv test for virtio-gpu + spice with

Re: [libvirt] [PATCH V2 4/4] libxl: add support for rbd qdisk

On Wed, Feb 17, 2016 at 05:33:45PM -0700, Jim Fehlig wrote: > xl/libxl already supports qemu's network-based block backends > such as nbd and rbd. libvirt has supported configuring such > s for long time too. This patch adds support for rbd > disks in the libxl driver by generating a rbd device

Re: [libvirt] [PATCH v2 1/2] util: TristateBool and TristateSwitch are interchangeable

On 19.02.2016 15:30, Marc-André Lureau wrote: > It may be useful in some cases to call TristateSwitch helper with > TristateBool. > Document that enum values equivalency in the code. > > Signed-off-by: Marc-André Lureau > --- > src/util/virutil.h | 7 ++- > 1

Re: [libvirt] [PATCH V2 3/4] xenconfig: support xl<->xml conversion of rbd disk devices

On Wed, Feb 17, 2016 at 05:33:44PM -0700, Jim Fehlig wrote: > The target= setting in xl disk configuration can be used to encode > meta info that is meaningful to a backend. Leverage this fact to > support qdisk network disk types such as rbd. E.g. config > such as > > > > >

Re: [libvirt] [PATCH V2 2/4] xenconfig: produce key=value disk config syntax in xl formatter

On Wed, Feb 17, 2016 at 05:33:43PM -0700, Jim Fehlig wrote: > The most formal form of xl disk configuration uses key=value > syntax to define each configuration item, e.g. > > format=raw, vdev=xvda, access=rw, backendtype=phy, target=disksrc > > Change the xl disk formatter to produce this

Re: [libvirt] [PATCH V2 1/4] xenconfig: replace text 'xm' with 'xl' in xlconfigtest

On Wed, Feb 17, 2016 at 05:33:42PM -0700, Jim Fehlig wrote: > While at it, improve a few comments. No functional change. > > Signed-off-by: Jim Fehlig > --- > tests/xlconfigtest.c | 34 +++--- > 1 file changed, 19 insertions(+), 15 deletions(-) >

Re: [libvirt] [PATCH] qemu: add support for LSI SAS1068 (aka MPT Fusion) SCSI controller

On 02/11/2016 05:48 AM, Paolo Bonzini wrote: > This does nothing more than adding the new device and capability. > The device is present since QEMU 2.6.0. > > Signed-off-by: Paolo Bonzini > --- > src/qemu/qemu_capabilities.c | 2 + >

Re: [libvirt] [PATCH] qemu_process: mark auto-generated spice ports as reserved

On Mon, Feb 22, 2016 at 02:07:11PM +0100, Michal Privoznik wrote: > On 18.02.2016 19:17, Pavel Hrdina wrote: [...] > ACK > > Michal Thanks Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/6] storage:dir: adapts .uploadVol .dowloadVol for ploop volume

On Thu, Feb 18, 2016 at 06:17:09PM +0300, Olga Krishtal wrote: > On 18/02/16 16:57, Ján Tomko wrote: > > On Wed, Feb 17, 2016 at 02:40:02PM +0300, Olga Krishtal wrote: > >> In case of ploop volume, target path of the volume is the path to the > >> directory that contains image file named root.hds

Re: [libvirt] [PATCH 6/6] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

On Thu, Feb 18, 2016 at 07:39:37PM +0300, Olga Krishtal wrote: > On 18/02/16 18:17, Ján Tomko wrote: > > On Thu, Feb 18, 2016 at 05:04:16PM +0300, Maxim Nestratov wrote: > >> 18.02.2016 16:46, Ján Tomko пишет: > >>> On Wed, Feb 17, 2016 at 02:40:05PM +0300, Olga Krishtal wrote: > To update

[libvirt] [PATCH 1/3] qemu_capabilities: introduce QEMU_CAPS_QXL(_VGA)_VRAM64

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 2 ++ tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 2 ++ tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 2 ++

[libvirt] [PATCH 0/3] implement vram64 attribute for QXL video device

Pavel Hrdina (3): qemu_capabilities: introduce QEMU_CAPS_QXL(_VGA)_VRAM64 docs/formatdomain: rewrite video documentation qemu: introduce vram64 attribute for QXL video device docs/formatdomain.html.in | 18 +++- docs/schemas/domaincommon.rng

[libvirt] [PATCH 3/3] qemu: introduce vram64 attribute for QXL video device

This attribute is used to extend secondary PCI bar and expose it to the guest as 64bit memory. It works like this: attribute vram is there to set size of secondary PCI bar and guest sees it as 32bit memory, attribute vram64 can extend this secondary PCI bar. If both attributes are used, guest

[libvirt] [PATCH 2/3] docs/formatdomain: rewrite video documentation

Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index a524c17..3fcd728 100644 --- a/docs/formatdomain.html.in +++

Re: [libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

On Mon, Feb 22, 2016 at 12:15:14PM +0100, Michal Privoznik wrote: On 22.02.2016 11:29, Martin Kletzander wrote: Checking whether x > 0 before looping over [0..x] items doesn't make sense and multi-line body must have curly brackets around it. Best viewed with '-w'. Signed-off-by: Martin

[libvirt] Plans for next release

So we are getting close to the end of the month and it's time to push a new release. I think that if we want to push it by March 1st we should start the freeze Wednesday at the latest, maybe RC1 on Wed, RC2 friday and release next Mon if everything looks okay. If there is an issue with this

Re: [libvirt] [PATCH] qemu_process: mark auto-generated spice ports as reserved

On 18.02.2016 19:17, Pavel Hrdina wrote: > In case you will specify graphics like this: > > > > or > > > > libvirt will automatically add autoport='no'. This leads to an issue > that in qemuProcessStop() we don't release that port because we are > releasing both port if autoport=yes or only

[libvirt] [PATCH] cmdNetworkUpdate: Prefer VSH_EXCLUSIVE_OPTIONS over if-else tree

We have macros that check and reject mutually exclusive parameters to our commands. Use those instead of if-else tree. Signed-off-by: Michal Privoznik --- tools/virsh-network.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git

[libvirt] [PATCH] cmdSaveImageEdit: Prefer VSH_EXCLUSIVE_OPTIONS over by hand check

Since we have the macro there's no need for us to unwind it by hand and check for mutually exclusive flags ourselves. Signed-off-by: Michal Privoznik --- tools/virsh-domain.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/virsh-domain.c

Re: [libvirt] [PATCH] Migration with --live --offline option performs offline migration without warning/error.

Hello Peter, Thanks for the reply. I have made changes according to your suggestion and re-submitted the patch as [patch v2] on the mailing list. Link:- https://www.redhat.com/archives/libvir-list/2016-February/msg01071.html Warm Regards, Nitesh Konkar. On Fri, Feb 19, 2016 at 8:57 PM, Peter

Re: [libvirt] [PATCH] Use correct pci addresses during interface-detach[v2]

On 19.02.2016 12:53, Nitesh Konkar wrote: > The virsh attach virsh detach interface command fails when both live and > config > are set and when the interface gets attached to different pci slots > on live and config xml respectively. > > When we attach an interface with both --live and

[libvirt] [PATCH v2] Migration with --live --offline option performs offline migration without warning/error.

This patch gives an error when migration is attempted with both --live and --offline options. Signed-off-by: Nitesh Konkar --- tools/virsh-domain.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

Re: [libvirt] dist-git build problem on epel-6-x86_64 chroot

Le 19/02/2016 11:40, Miroslav Suchý a écrit : Dne 19.1.2016 v 17:01 Jean-Marc LIGER napsal(a): Hy, I'm facing the problem below on epel-6-x86_64 chroot for both from URL and upload SRPM : [2016-01-19 15:16:26,790][ INFO][PID:3241] Setting up builder: 172.25.94.167 [2016-01-19 15:16:27,991][

Re: [libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

On 22.02.2016 11:29, Martin Kletzander wrote: > Checking whether x > 0 before looping over [0..x] items doesn't make > sense and multi-line body must have curly brackets around it. > > Best viewed with '-w'. > > Signed-off-by: Martin Kletzander > --- >

Re: [libvirt] [PATCH v3 0/3] Add capability for text based polkit authentication for virsh

ping... Thanks, John On 02/12/2016 12:12 PM, John Ferlan wrote: > v2: http://www.redhat.com/archives/libvir-list/2016-February/msg00618.html > > Adjustments since v2: > > Patch 1 - Change not only the message (as requested), but also use a >different and new error code

[libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

Checking whether x > 0 before looping over [0..x] items doesn't make sense and multi-line body must have curly brackets around it. Best viewed with '-w'. Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c| 24 +---

Re: [libvirt] [PATCH] qemu: add support for LSI SAS1068 (aka MPT Fusion) SCSI controller

On Thu, Feb 11, 2016 at 11:48:20AM +0100, Paolo Bonzini wrote: > This does nothing more than adding the new device and capability. > The device is present since QEMU 2.6.0. > > Signed-off-by: Paolo Bonzini > --- > src/qemu/qemu_capabilities.c | 2 + >

Re: [libvirt] [PATCH] virDomainDefFormatInternal: Drop useless check

On Mon, Feb 22, 2016 at 10:06:34AM +0100, Erik Skultety wrote: On 22/02/16 08:57, Michal Privoznik wrote: There's a check if a domain definition has any graphics card and if so, we iterate over each one of them. This makes no sense, because even if it has none we can still iterate over.

[libvirt] About the vfio error when using SR-IOV

Hi, All I want to use the SR-IOV of intel 82576 NIC. I enabled IOMMU and VT-d and SR-IOV in BIOS. And enabled VT-d in kernel. The OS information is bellow: [root@host3 nova]# cat /etc/redhat-release CentOS Linux release 7.1.1503 (Core) [root@host3 nova]# uname -an Linux host3.localdomain

Re: [libvirt] [PATCH] virDomainDefFormatInternal: Drop useless check

On 22/02/16 08:57, Michal Privoznik wrote: > There's a check if a domain definition has any graphics card and > if so, we iterate over each one of them. This makes no sense, > because even if it has none we can still iterate over. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH] adminDaemonListServers: Don't leak @srv_names array

On 22/02/16 08:57, Michal Privoznik wrote: > When getting a list of servers registered for a daemon, it's > returned as a dynamically allocated array filled in with pointers > to constant strings. Because the array is dynamic, it should be > freed when no longer needed (but not the strings!). Even

[libvirt] [PATCH] adminDaemonListServers: Don't leak @srv_names array

When getting a list of servers registered for a daemon, it's returned as a dynamically allocated array filled in with pointers to constant strings. Because the array is dynamic, it should be freed when no longer needed (but not the strings!). Even the function that creates the array suggests that.

[libvirt] [PATCH] virDomainDefFormatInternal: Drop useless check

There's a check if a domain definition has any graphics card and if so, we iterate over each one of them. This makes no sense, because even if it has none we can still iterate over. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 8 +++- 1 file changed, 3